reactos.git
4 years ago[REACTOS] Fix remaining ' \n' typos, in *.rc (#2393)
Serge Gautherie [Fri, 6 Mar 2020 18:08:25 +0000 (19:08 +0100)]
[REACTOS] Fix remaining ' \n' typos, in *.rc (#2393)

Addendum to commit 554c41e4 (#2387).
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
4 years ago[PSDK][XDK] Move 2 aliases to psdk/winbase.h from xdk/winnt_old.h
Serge Gautherie [Fri, 28 Feb 2020 12:14:36 +0000 (13:14 +0100)]
[PSDK][XDK] Move 2 aliases to psdk/winbase.h from xdk/winnt_old.h

4 years ago[PSDK] winbase.h: Add missing LPEXCEPTION_RECORD
Serge Gautherie [Fri, 28 Feb 2020 12:14:36 +0000 (13:14 +0100)]
[PSDK] winbase.h: Add missing LPEXCEPTION_RECORD

ROSTESTS-251

4 years ago[KERNEL32_WINETEST] Fix COMMCONFIG.wcProviderData values (#2410)
Serge Gautherie [Fri, 6 Mar 2020 17:24:22 +0000 (18:24 +0100)]
[KERNEL32_WINETEST] Fix COMMCONFIG.wcProviderData values (#2410)

Import test part of
https://source.winehq.org/git/wine.git/commit/a59d6387b6734cf0acb187e9c178d7c540751cae

ROSTESTS-251

4 years ago[SETUPAPI] Implement StopDevice()
Hervé Poussineau [Wed, 4 Mar 2020 22:43:30 +0000 (23:43 +0100)]
[SETUPAPI] Implement StopDevice()

4 years ago[NTUSER] Fix ShellHook notifications when creating/activating windows (#2396)
JoachimHenze [Thu, 5 Mar 2020 14:39:23 +0000 (15:39 +0100)]
[NTUSER] Fix ShellHook notifications when creating/activating windows (#2396)

4 years ago[CPL][TIMEDATE] Romanian & Italian translation update (#2404)
Hermès BÉLUSCA - MAÏTO [Wed, 4 Mar 2020 23:21:31 +0000 (00:21 +0100)]
[CPL][TIMEDATE] Romanian & Italian translation update (#2404)

4 years ago[PSDK] Extend struct _SECPKG_DLL_FUNCTIONS, fix definitions. 2254/head
Andreas Maier [Tue, 7 Jan 2020 18:06:37 +0000 (19:06 +0100)]
[PSDK] Extend struct _SECPKG_DLL_FUNCTIONS, fix definitions.

* Add missing enums to MSV1_0_PROTOCOL_MESSAGE_TYPE and SECPKG_EXTENDED_INFORMATION_CLASS
* Add missing function entries to LSA_SECPKG_FUNCTION_TABLE and add needed definitions.
* Fix params of PLSA_AP_CALL_PACKAGE
* Fix SpInitializeFn (+ NTAPI)

4 years ago[WIN32SS] Improve Drawing Scrollbars
Joachim Henze [Wed, 4 Mar 2020 01:12:06 +0000 (02:12 +0100)]
[WIN32SS] Improve Drawing Scrollbars

A very nice patch of JIRA user "I_kill_Bugs". Many many Thanks!

It addresses:
- CORE-14755 fixed, flashing scrollbar triangles (we know 131 affected apps just from rapps!)
- CORE-13931 fixed, FamiTracker invisible about-dlg
- CORE-14685 improves a bit, but is not entirely fixed
- CORE-11561 improves a bit, but is not entirely fixed
- The patch avoids unnecessary redraws, speeds up GUI interaction and NSIS install times

Jim Tabor had no complains about it, I just did some white-space-tweaks on EOL and indentation.

FTR A testbot run (not on master but on 0.4.13-RC-48-g818e5bc)
https://reactos.org/testman/compare.php?ids=71645,71666 VBox LGTM
https://reactos.org/testman/compare.php?ids=71646,71667 KVM LGTM

I felt tempted to port back, but decided to play safe and commit to master just.

4 years ago[NTOS:MM] Assert PFN lock ownership in MiInsertPageInFreeList. 2371/head
Thomas Faber [Wed, 12 Feb 2020 20:09:49 +0000 (21:09 +0100)]
[NTOS:MM] Assert PFN lock ownership in MiInsertPageInFreeList.

AMD64 initialization previously only raised the IRQL.
It now acquires the lock where needed, as i386 does.

4 years ago[USBHUB] Partially implement USBH_ProcessHubStateChange. CORE-16704 2370/head
Thomas Faber [Sat, 22 Feb 2020 09:32:11 +0000 (10:32 +0100)]
[USBHUB] Partially implement USBH_ProcessHubStateChange. CORE-16704

4 years ago[USBHUB] Fix recipient in USBH_SyncClearPortStatus. CORE-16704
Thomas Faber [Sat, 22 Feb 2020 09:31:40 +0000 (10:31 +0100)]
[USBHUB] Fix recipient in USBH_SyncClearPortStatus. CORE-16704

4 years ago[CONSRV] Fix a corruption of the CONSRV memory when converting read input events...
Hermès Bélusca-Maïto [Sun, 1 Mar 2020 23:56:33 +0000 (00:56 +0100)]
[CONSRV] Fix a corruption of the CONSRV memory when converting read input events back to ANSI.

This fixes a 6-year old copy-paste bug introduced by commit b47d51c6 (r64004).

4 years ago[CONSRV] Some code simplification and tidy up.
Hermès Bélusca-Maïto [Sun, 1 Mar 2020 16:22:05 +0000 (17:22 +0100)]
[CONSRV] Some code simplification and tidy up.

4 years ago[CONSRV] Use NtClearEvent() and NtClose() instead of the Win32 functions.
Hermès Bélusca-Maïto [Sat, 29 Feb 2020 19:11:09 +0000 (20:11 +0100)]
[CONSRV] Use NtClearEvent() and NtClose() instead of the Win32 functions.

4 years ago[CONSRV] Tidy up lineinput.c by moving the History* helper prototypes to a suitable...
Hermès Bélusca-Maïto [Sat, 29 Feb 2020 18:57:50 +0000 (19:57 +0100)]
[CONSRV] Tidy up lineinput.c by moving the History* helper prototypes to a suitable header file.

4 years ago[KERNEL32:CONSOLE] Explicitly use _WIN32_WINNT_VISTA.
Hermès Bélusca-Maïto [Sat, 29 Feb 2020 18:55:52 +0000 (19:55 +0100)]
[KERNEL32:CONSOLE] Explicitly use _WIN32_WINNT_VISTA.

4 years ago[CONSRV] Support history resizing from console settings and from SetConsoleHistoryInf...
Hermès Bélusca-Maïto [Sat, 29 Feb 2020 16:35:57 +0000 (17:35 +0100)]
[CONSRV] Support history resizing from console settings and from SetConsoleHistoryInfo() server implementation.

In addition, honour the maximum number of history buffers allowed when
creating new ones.

Some implementation information has been obtained from
https://github.com/microsoft/terminal
(under MIT License).

4 years ago[NTOS:IO] Fix indentation. No code changes!
Eric Kohl [Sun, 1 Mar 2020 22:34:30 +0000 (23:34 +0100)]
[NTOS:IO] Fix indentation. No code changes!

4 years ago[NTOS:IO] Improve the device action worker
Eric Kohl [Sun, 1 Mar 2020 22:29:23 +0000 (23:29 +0100)]
[NTOS:IO] Improve the device action worker

- Improve the device action worker to support more than just a single action
- Move the action queue code from IoInvalidateDeviceRelations to a new function IopQueueDeviceAction.

4 years ago[FREELDR] Move the PC VESA and hardware detection libraries into the PC directory...
Dmitry Borisov [Sun, 1 Mar 2020 19:41:47 +0000 (01:41 +0600)]
[FREELDR] Move the PC VESA and hardware detection libraries into the PC directory (#2355)

Because it contains platform-specific code.

4 years ago[SHELL32] Improve ShellExecCmdLine in path resolving (#2397)
Katayama Hirofumi MZ [Sun, 1 Mar 2020 10:32:33 +0000 (19:32 +0900)]
[SHELL32] Improve ShellExecCmdLine in path resolving (#2397)

Fix and improve private function shell32!ShellExecCmdLine to improve Run Dialog behavior. CORE-14409

4 years ago[VIDEOPRT] Workaround bug CORE-16695 (infinite loop when reading EDID on LiveCD in...
Hervé Poussineau [Sun, 1 Mar 2020 09:06:18 +0000 (10:06 +0100)]
[VIDEOPRT] Workaround bug CORE-16695 (infinite loop when reading EDID on LiveCD in QEMU)

For some reason, we don't get valid EDIDs when using LiveCD on QEMU.
We ignore them, and try to read the one of the next child.
This leads to a infinite loop and then, an out of memory error.

As it can also happen in other circonstances, stop enumeration as soon
as an invalid EDID is detected.

This breaks configurations with graphic cards with 2+ outputs, where
the first one is not plugged to a monitor, and the second one is plugged
to a monitor.

CORE-16695

4 years ago[NTOS:IO] Move IopRemovePlugPlayEvent around and add the ResponseData parameter ...
Eric Kohl [Sat, 29 Feb 2020 13:26:16 +0000 (14:26 +0100)]
[NTOS:IO] Move IopRemovePlugPlayEvent around and add the ResponseData parameter (not used yet)

4 years ago[SHELL32_APITEST] Add DoPropTest to SHChangeNotify testcase
Katayama Hirofumi MZ [Sat, 29 Feb 2020 07:02:48 +0000 (16:02 +0900)]
[SHELL32_APITEST] Add DoPropTest to SHChangeNotify testcase

CORE-13950

4 years ago[SHELL32_APITEST] Support multi-process of SHChangeNotify testcase (#2399)
Katayama Hirofumi MZ [Fri, 28 Feb 2020 23:13:52 +0000 (08:13 +0900)]
[SHELL32_APITEST] Support multi-process of SHChangeNotify testcase (#2399)

The shell32!SHChangeNotify function must be tested on multiple processes. CORE-13950

4 years ago[SHELL32][BOOTDATA] Unselect filename extension upon renaming (#2398)
Katayama Hirofumi MZ [Fri, 28 Feb 2020 23:08:26 +0000 (08:08 +0900)]
[SHELL32][BOOTDATA] Unselect filename extension upon renaming (#2398)

You can disable unselecting by setting TRUE to SelectExtOnRename value of HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer. CORE-15242

4 years ago[DOC] 3rd Party Files.txt: Add 'Schily Tools, mkisofs' entry
Serge Gautherie [Tue, 25 Feb 2020 02:12:35 +0000 (03:12 +0100)]
[DOC] 3rd Party Files.txt: Add 'Schily Tools, mkisofs' entry

4 years ago[UTILMAN] Small refactor on process management code (#2375)
Bișoc George [Thu, 27 Feb 2020 17:45:21 +0000 (18:45 +0100)]
[UTILMAN] Small refactor on process management code (#2375)

Implement a small helper, GetProcessID(), that will be used to return the process ID which we are interested in. This largely removes some duplicated code. The following patch addresses the Jansen's comment on #1608 PR.

4 years ago[CMD] Fix 'if' command for root directories (#2394)
Katayama Hirofumi MZ [Thu, 27 Feb 2020 14:12:20 +0000 (23:12 +0900)]
[CMD] Fix 'if' command for root directories (#2394)

CORE-14797

4 years ago[WINESYNC]: d3dx9 is now in sync with wine-staging wine-4.2
Jérôme Gardou [Wed, 5 Feb 2020 21:14:09 +0000 (22:14 +0100)]
[WINESYNC]: d3dx9 is now in sync with wine-staging wine-4.2

4 years ago[WINESYNC] d3dx9_36: Implement ID3DXSkinInfoImpl_UpdateSkinnedMesh.
winesync [Wed, 5 Feb 2020 21:14:01 +0000 (22:14 +0100)]
[WINESYNC] d3dx9_36: Implement ID3DXSkinInfoImpl_UpdateSkinnedMesh.

This patch fixes last problem of bug 32572.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36: Align texture dimensions to block size for compressed textures...
winesync [Wed, 5 Feb 2020 21:13:59 +0000 (22:13 +0100)]
[WINESYNC] d3dx9_36: Align texture dimensions to block size for compressed textures in D3DXCheckTextureRequirements.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36: No need to fail if we don't support vertices reordering in D3DXM...
winesync [Wed, 5 Feb 2020 21:13:58 +0000 (22:13 +0100)]
[WINESYNC] d3dx9_36: No need to fail if we don't support vertices reordering in D3DXMESHOPT_ATTRSORT

A non optimized mesh does not prevent rendering as long as we return valid data to the application.
In our case we provided an identity remapping array when no vertices reordering is done.

Avencast demo works perfectly well (using native effects functions).

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36: Filter out D3DCompile warning messages that are not present...
winesync [Wed, 5 Feb 2020 21:13:57 +0000 (22:13 +0100)]
[WINESYNC] d3dx9_36: Filter out D3DCompile warning messages that are not present with D3DCompileShader. (try 4)

This patch fixes vertex processing issue of bug 33770.

The problem comes from the fact that even if the call succeeds,
the game interprets a non null error_messages pointer as an error.

By calling D3DCompile we use a newer version of the compiler which is more
strict and generates the following warning.
  - warning X3206: 'dot': implicit truncation of vector type
  - warning X3206: implicit truncation of vector type
  - warning X3206: 'mul': implicit truncation of vector type
D3DCompileShader does not generate such warnings.

These is confirmed in the DX SDK release note:
New Warning X3206: Implicit Truncation of Vector Type
Beginning in the August 2009 release of the DirectX SDK, the compiler will warn
when an implicit truncation of a vector type occurs.

The warnings cannot be disable so this patch filters out these strings in D3DCompileShader
and reset the error messages pointer if the resulting buffer is empty.

Try 2:
  - only filter out lines containing "X3206:" in case d3dcompiler_43 has localization

Try 3:
  - use move in place instead of copying the buffer

Try 4:
  - filter simplification by Sebastian and remove 'mul' testing left-out in search string

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36/tests: Add initial tests for dummy skininfo interface.
winesync [Wed, 5 Feb 2020 21:13:56 +0000 (22:13 +0100)]
[WINESYNC] d3dx9_36/tests: Add initial tests for dummy skininfo interface.

wine-staging patch by Michael Müller <michael@fds-team.de>

4 years ago[WINESYNC] d3dx9_36: Return dummy skininfo interface in D3DXLoadSkinMeshFromXof when...
winesync [Wed, 5 Feb 2020 21:13:55 +0000 (22:13 +0100)]
[WINESYNC] d3dx9_36: Return dummy skininfo interface in D3DXLoadSkinMeshFromXof when skin information is unavailable.

wine-staging patch by Michael Müller <michael@fds-team.de>

4 years ago[WINESYNC] d3dx9_36: ID3DXFont_DrawText calc_rect can be null
winesync [Wed, 5 Feb 2020 21:13:54 +0000 (22:13 +0100)]
[WINESYNC] d3dx9_36: ID3DXFont_DrawText calc_rect can be null

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
wine-staging patch by Alistair Leslie-Hughes <leslie_alistair@hotmail.com>

4 years ago[WINESYNC] d3dx9_36: Support NULL terminated strings in ID3DXFont_DrawText
winesync [Wed, 5 Feb 2020 21:13:53 +0000 (22:13 +0100)]
[WINESYNC] d3dx9_36: Support NULL terminated strings in ID3DXFont_DrawText

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
wine-staging patch by Alistair Leslie-Hughes <leslie_alistair@hotmail.com>

4 years ago[WINESYNC] d3dx9_36: Fix horizontal centering in ID3DXFont_DrawText.
winesync [Wed, 5 Feb 2020 21:13:52 +0000 (22:13 +0100)]
[WINESYNC] d3dx9_36: Fix horizontal centering in ID3DXFont_DrawText.

Fix remaining text issues in Air Strike.
Should fix text placement in Stronghold Kingdoms.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36: Implement ID3DXFontImpl_DrawText.
winesync [Wed, 5 Feb 2020 21:13:51 +0000 (22:13 +0100)]
[WINESYNC] d3dx9_36: Implement ID3DXFontImpl_DrawText.

Changes by Sebastian Lackner <sebastian@fds-team.de>:
* Use pitch value for locked buffer instead of assuming that pitch = width * bytesperpixel
* Avoid one for loop to simplify code
* Ensure that DrawText doesn't dereference a NULL pointer when count != 0.

Changes by Christian Costa <titan.costa@gmail.com>
* Use dedicated variables for text width & height instead of reusing rect.right and rect.bottom
* Remove useless test in pixel conversion
* Remove left over 'partial stub' in fixme

Changes by Sebastian Lackner <sebastian@fds-team.de>:
* Replace code to convert text from ascii to widechar
* Strip terminating NULL chars before drawing text

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36: add DXTn support
winesync [Wed, 5 Feb 2020 21:11:40 +0000 (22:11 +0100)]
[WINESYNC] d3dx9_36: add DXTn support

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36: Improve D3DXSaveTextureToFile to save simple texture to dds...
winesync [Wed, 5 Feb 2020 21:11:39 +0000 (22:11 +0100)]
[WINESYNC] d3dx9_36: Improve D3DXSaveTextureToFile to save simple texture to dds file.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36: Add support for FOURCC surface to save_dds_surface_to_memory.
winesync [Wed, 5 Feb 2020 21:11:38 +0000 (22:11 +0100)]
[WINESYNC] d3dx9_36: Add support for FOURCC surface to save_dds_surface_to_memory.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9: Implement D3DXComputeTangent
winesync [Wed, 5 Feb 2020 20:51:59 +0000 (21:51 +0100)]
[WINESYNC] d3dx9: Implement D3DXComputeTangent

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
wine-staging patch by Alistair Leslie-Hughes <leslie_alistair@hotmail.com>

4 years ago[WINESYNC] d3dx9_*: Add D3DXSHProjectCubeMap stub
winesync [Sat, 1 Feb 2020 17:09:04 +0000 (18:09 +0100)]
[WINESYNC] d3dx9_*: Add D3DXSHProjectCubeMap stub

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46284

wine-staging patch by Andrey Gusev <andrey.goosev@gmail.com>

4 years ago[WINESYNC] d3dx9_36: Add semi-stub for D3DXOptimizeVertices.
winesync [Sat, 1 Feb 2020 17:02:30 +0000 (18:02 +0100)]
[WINESYNC] d3dx9_36: Add semi-stub for D3DXOptimizeVertices.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36/tests: Remove useless \n within some ok messages.
winesync [Sat, 1 Feb 2020 17:02:28 +0000 (18:02 +0100)]
[WINESYNC] d3dx9_36/tests: Remove useless \n within some ok messages.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36/tests: Add additional tests for special cases.
winesync [Sat, 1 Feb 2020 17:02:27 +0000 (18:02 +0100)]
[WINESYNC] d3dx9_36/tests: Add additional tests for special cases.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36/tests: Add initial tests for D3DXDisassembleShader.
winesync [Sat, 1 Feb 2020 17:02:27 +0000 (18:02 +0100)]
[WINESYNC] d3dx9_36/tests: Add initial tests for D3DXDisassembleShader.

wine-staging patch by Sebastian Lackner <sebastian@fds-team.de>

4 years ago[WINESYNC] d3dx9_36: Implement D3DXDisassembleShader. (v2)
winesync [Sat, 1 Feb 2020 17:02:26 +0000 (18:02 +0100)]
[WINESYNC] d3dx9_36: Implement D3DXDisassembleShader. (v2)

Changes in v2 (by Christian Costa):
  * More generic code for D3DXDisassembleShader.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36: Improve stub for ID3DXEffectImpl_CloneEffect.
winesync [Sat, 1 Feb 2020 17:02:25 +0000 (18:02 +0100)]
[WINESYNC] d3dx9_36: Improve stub for ID3DXEffectImpl_CloneEffect.

wine-staging patch by Sebastian Lackner <sebastian@fds-team.de>

4 years ago[WINESYNC] d3dx9_36: Add format description for X8L8V8U8 for format conversions.
winesync [Sat, 1 Feb 2020 17:02:25 +0000 (18:02 +0100)]
[WINESYNC] d3dx9_36: Add format description for X8L8V8U8 for format conversions.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9_36: Recognize bump luminance X8L8V8U8 when loading dds file.
winesync [Sat, 1 Feb 2020 17:02:24 +0000 (18:02 +0100)]
[WINESYNC] d3dx9_36: Recognize bump luminance X8L8V8U8 when loading dds file.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9: Return D3DFMT_A8R8G8B8 in D3DXGetImageInfoFromFileInMemory for...
winesync [Sat, 1 Feb 2020 17:02:24 +0000 (18:02 +0100)]
[WINESYNC] d3dx9: Return D3DFMT_A8R8G8B8 in D3DXGetImageInfoFromFileInMemory for 32 bpp BMP with alpha.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC] d3dx9: Use parameter data for the first constant only in d3dx_set_shader_c...
winesync [Sat, 1 Feb 2020 17:00:27 +0000 (18:00 +0100)]
[WINESYNC] d3dx9: Use parameter data for the first constant only in d3dx_set_shader_const_state().

Signed-off-by: Paul Gofman <gofmanp@gmail.com>
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id f72204abd6037e59ba1bf500a3a9d0316e65a024 by Paul Gofman <gofmanp@gmail.com>

4 years ago[WINESYNC] d3dx9: Handle short parameter in d3dx_set_shader_const_state().
winesync [Sat, 1 Feb 2020 16:57:28 +0000 (17:57 +0100)]
[WINESYNC] d3dx9: Handle short parameter in d3dx_set_shader_const_state().

The issue is spotted in https://bugs.winehq.org/show_bug.cgi?id=46553,
while fixing it alone is reported not to affect the bug.

Signed-off-by: Paul Gofman <gofmanp@gmail.com>
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id b3e91c3408797da72fdd5066e983d8861d9271ea by Paul Gofman <gofmanp@gmail.com>

4 years ago[WINESYNC] d3dx9/tests: Add more tests for VertexShaderConstant state.
winesync [Sat, 1 Feb 2020 16:57:28 +0000 (17:57 +0100)]
[WINESYNC] d3dx9/tests: Add more tests for VertexShaderConstant state.

Signed-off-by: Paul Gofman <gofmanp@gmail.com>
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 6fe2728b215fcc22940c556f195fe223c5ac2cff by Paul Gofman <gofmanp@gmail.com>

4 years ago[WINESYNC] d3dx9/tests: Clear vertex shader constants in test_effect_states().
winesync [Sat, 1 Feb 2020 16:57:27 +0000 (17:57 +0100)]
[WINESYNC] d3dx9/tests: Clear vertex shader constants in test_effect_states().

Signed-off-by: Paul Gofman <gofmanp@gmail.com>
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id cf992bebb056814a05fe3a82011c4de701c144c4 by Paul Gofman <gofmanp@gmail.com>

4 years ago[WINESYNC] d3dx9/tests: Actually test the return of the effect SetInt() call.
winesync [Sat, 1 Feb 2020 16:57:25 +0000 (17:57 +0100)]
[WINESYNC] d3dx9/tests: Actually test the return of the effect SetInt() call.

Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 7e01ec6018c062d11b29ba2b9a2056d98e8bc406 by Michael Stefaniuc <mstefani@winehq.org>

4 years ago[WINESYNC]: revert wine-staging patchset for d3dx9
Jérôme Gardou [Sat, 1 Feb 2020 16:57:23 +0000 (17:57 +0100)]
[WINESYNC]: revert wine-staging patchset for d3dx9

4 years ago[REACTOS] Exclude some wine modules from clang-format
Jérôme Gardou [Sat, 4 Jan 2020 09:43:45 +0000 (10:43 +0100)]
[REACTOS] Exclude some wine modules from clang-format

4 years ago[TOOLS] Add a python script for syncing wine patches
Jérôme Gardou [Sat, 4 Jan 2020 01:14:02 +0000 (02:14 +0100)]
[TOOLS] Add a python script for syncing wine patches

This requires the pygit2 module
usage : ./winesync.py module <wine-tag> <winestaging-tag>

for instance ./winesync.py d3dx9 wine-4.1 v4.1

This requires to have a wine git checkout and a wine-staging checkout
configuration is done through yaml file named <module>.cfg specifying
the following:
 - file mappings
 - directory mappings
 - latest wine version the module is synced with
it then creates a local branch in the wine checkout, based on the given
tag, and then the staging script is ran on top of it.
Thanks to the mappings defined in the module configuration file, it then
create individual commits in the reactos git checkout with reworked
path.
In case of problem, it stops and lets you amend the latest commit and go
along with the process once this is done. (Makefile.in modified, new or
removed files, patches not cleanly applied)

Staging patches are added into the <module>_staging directory for the
ease of reverting them later. (TODO)

See previous [WINESYNC] commits to have an overview of the result

4 years ago[WINESYNC]: d3dx9 is now in sync with wine-staging wine-4.1
Jérôme Gardou [Sat, 4 Jan 2020 01:11:44 +0000 (02:11 +0100)]
[WINESYNC]: d3dx9 is now in sync with wine-staging wine-4.1

4 years ago[WINESYNC]d3dx9_36: Implement ID3DXSkinInfoImpl_UpdateSkinnedMesh.
winesync [Sat, 4 Jan 2020 01:11:30 +0000 (02:11 +0100)]
[WINESYNC]d3dx9_36: Implement ID3DXSkinInfoImpl_UpdateSkinnedMesh.

This patch fixes last problem of bug 32572.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36: Align texture dimensions to block size for compressed textures...
winesync [Sat, 4 Jan 2020 01:11:30 +0000 (02:11 +0100)]
[WINESYNC]d3dx9_36: Align texture dimensions to block size for compressed textures in D3DXCheckTextureRequirements.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36: No need to fail if we don't support vertices reordering in D3DXME...
winesync [Sat, 4 Jan 2020 01:11:30 +0000 (02:11 +0100)]
[WINESYNC]d3dx9_36: No need to fail if we don't support vertices reordering in D3DXMESHOPT_ATTRSORT

A non optimized mesh does not prevent rendering as long as we return valid data to the application.
In our case we provided an identity remapping array when no vertices reordering is done.

Avencast demo works perfectly well (using native effects functions).

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36: Filter out D3DCompile warning messages that are not present with...
winesync [Sat, 4 Jan 2020 01:11:30 +0000 (02:11 +0100)]
[WINESYNC]d3dx9_36: Filter out D3DCompile warning messages that are not present with D3DCompileShader. (try 4)

This patch fixes vertex processing issue of bug 33770.

The problem comes from the fact that even if the call succeeds,
the game interprets a non null error_messages pointer as an error.

By calling D3DCompile we use a newer version of the compiler which is more
strict and generates the following warning.
  - warning X3206: 'dot': implicit truncation of vector type
  - warning X3206: implicit truncation of vector type
  - warning X3206: 'mul': implicit truncation of vector type
D3DCompileShader does not generate such warnings.

These is confirmed in the DX SDK release note:
New Warning X3206: Implicit Truncation of Vector Type
Beginning in the August 2009 release of the DirectX SDK, the compiler will warn
when an implicit truncation of a vector type occurs.

The warnings cannot be disable so this patch filters out these strings in D3DCompileShader
and reset the error messages pointer if the resulting buffer is empty.

Try 2:
  - only filter out lines containing "X3206:" in case d3dcompiler_43 has localization

Try 3:
  - use move in place instead of copying the buffer

Try 4:
  - filter simplification by Sebastian and remove 'mul' testing left-out in search string

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36/tests: Add initial tests for dummy skininfo interface.
winesync [Sat, 4 Jan 2020 01:11:30 +0000 (02:11 +0100)]
[WINESYNC]d3dx9_36/tests: Add initial tests for dummy skininfo interface.

wine-staging patch by Michael Müller <michael@fds-team.de>

4 years ago[WINESYNC]d3dx9_36: Return dummy skininfo interface in D3DXLoadSkinMeshFromXof when...
winesync [Sat, 4 Jan 2020 01:11:30 +0000 (02:11 +0100)]
[WINESYNC]d3dx9_36: Return dummy skininfo interface in D3DXLoadSkinMeshFromXof when skin information is unavailable.

wine-staging patch by Michael Müller <michael@fds-team.de>

4 years ago[WINESYNC]d3dx9_36: ID3DXFont_DrawText calc_rect can be null
winesync [Sat, 4 Jan 2020 01:11:30 +0000 (02:11 +0100)]
[WINESYNC]d3dx9_36: ID3DXFont_DrawText calc_rect can be null

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
wine-staging patch by Alistair Leslie-Hughes <leslie_alistair@hotmail.com>

4 years ago[WINESYNC]d3dx9_36: Support NULL terminated strings in ID3DXFont_DrawText
winesync [Sat, 4 Jan 2020 01:11:30 +0000 (02:11 +0100)]
[WINESYNC]d3dx9_36: Support NULL terminated strings in ID3DXFont_DrawText

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
wine-staging patch by Alistair Leslie-Hughes <leslie_alistair@hotmail.com>

4 years ago[WINESYNC]d3dx9_36: Fix horizontal centering in ID3DXFont_DrawText.
winesync [Sat, 4 Jan 2020 01:11:30 +0000 (02:11 +0100)]
[WINESYNC]d3dx9_36: Fix horizontal centering in ID3DXFont_DrawText.

Fix remaining text issues in Air Strike.
Should fix text placement in Stronghold Kingdoms.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36: Implement ID3DXFontImpl_DrawText.
winesync [Sat, 4 Jan 2020 01:11:30 +0000 (02:11 +0100)]
[WINESYNC]d3dx9_36: Implement ID3DXFontImpl_DrawText.

Changes by Sebastian Lackner <sebastian@fds-team.de>:
* Use pitch value for locked buffer instead of assuming that pitch = width * bytesperpixel
* Avoid one for loop to simplify code
* Ensure that DrawText doesn't dereference a NULL pointer when count != 0.

Changes by Christian Costa <titan.costa@gmail.com>
* Use dedicated variables for text width & height instead of reusing rect.right and rect.bottom
* Remove useless test in pixel conversion
* Remove left over 'partial stub' in fixme

Changes by Sebastian Lackner <sebastian@fds-team.de>:
* Replace code to convert text from ascii to widechar
* Strip terminating NULL chars before drawing text

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36: add DXTn support
winesync [Sat, 4 Jan 2020 01:09:33 +0000 (02:09 +0100)]
[WINESYNC]d3dx9_36: add DXTn support

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36: Improve D3DXSaveTextureToFile to save simple texture to dds file.
winesync [Sat, 4 Jan 2020 01:09:33 +0000 (02:09 +0100)]
[WINESYNC]d3dx9_36: Improve D3DXSaveTextureToFile to save simple texture to dds file.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36: Add support for FOURCC surface to save_dds_surface_to_memory.
winesync [Sat, 4 Jan 2020 01:09:33 +0000 (02:09 +0100)]
[WINESYNC]d3dx9_36: Add support for FOURCC surface to save_dds_surface_to_memory.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9: Implement D3DXComputeTangent
winesync [Sat, 4 Jan 2020 01:07:11 +0000 (02:07 +0100)]
[WINESYNC]d3dx9: Implement D3DXComputeTangent

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
wine-staging patch by Alistair Leslie-Hughes <leslie_alistair@hotmail.com>

4 years ago[WINESYNC]d3dx9_*: Add D3DXSHProjectCubeMap stub
winesync [Sat, 4 Jan 2020 00:56:18 +0000 (01:56 +0100)]
[WINESYNC]d3dx9_*: Add D3DXSHProjectCubeMap stub

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46284

wine-staging patch by Andrey Gusev <andrey.goosev@gmail.com>

4 years ago[WINESYNC]d3dx9_36: Add semi-stub for D3DXOptimizeVertices.
winesync [Sat, 4 Jan 2020 00:49:33 +0000 (01:49 +0100)]
[WINESYNC]d3dx9_36: Add semi-stub for D3DXOptimizeVertices.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36/tests: Remove useless \n within some ok messages.
winesync [Sat, 4 Jan 2020 00:49:33 +0000 (01:49 +0100)]
[WINESYNC]d3dx9_36/tests: Remove useless \n within some ok messages.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36/tests: Add additional tests for special cases.
winesync [Sat, 4 Jan 2020 00:49:33 +0000 (01:49 +0100)]
[WINESYNC]d3dx9_36/tests: Add additional tests for special cases.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36/tests: Add initial tests for D3DXDisassembleShader.
winesync [Sat, 4 Jan 2020 00:49:33 +0000 (01:49 +0100)]
[WINESYNC]d3dx9_36/tests: Add initial tests for D3DXDisassembleShader.

wine-staging patch by Sebastian Lackner <sebastian@fds-team.de>

4 years ago[WINESYNC]d3dx9_36: Implement D3DXDisassembleShader. (v2)
winesync [Sat, 4 Jan 2020 00:49:33 +0000 (01:49 +0100)]
[WINESYNC]d3dx9_36: Implement D3DXDisassembleShader. (v2)

Changes in v2 (by Christian Costa):
  * More generic code for D3DXDisassembleShader.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36: Improve stub for ID3DXEffectImpl_CloneEffect.
winesync [Sat, 4 Jan 2020 00:49:33 +0000 (01:49 +0100)]
[WINESYNC]d3dx9_36: Improve stub for ID3DXEffectImpl_CloneEffect.

wine-staging patch by Sebastian Lackner <sebastian@fds-team.de>

4 years ago[WINESYNC]d3dx9_36: Add format description for X8L8V8U8 for format conversions.
winesync [Sat, 4 Jan 2020 00:49:33 +0000 (01:49 +0100)]
[WINESYNC]d3dx9_36: Add format description for X8L8V8U8 for format conversions.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9_36: Recognize bump luminance X8L8V8U8 when loading dds file.
winesync [Sat, 4 Jan 2020 00:49:33 +0000 (01:49 +0100)]
[WINESYNC]d3dx9_36: Recognize bump luminance X8L8V8U8 when loading dds file.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9: Return D3DFMT_A8R8G8B8 in D3DXGetImageInfoFromFileInMemory for 32...
winesync [Sat, 4 Jan 2020 00:49:33 +0000 (01:49 +0100)]
[WINESYNC]d3dx9: Return D3DFMT_A8R8G8B8 in D3DXGetImageInfoFromFileInMemory for 32 bpp BMP with alpha.

wine-staging patch by Christian Costa <titan.costa@gmail.com>

4 years ago[WINESYNC]d3dx9/tests: Add more tests for D3DXMatrixTransformation().
winesync [Sat, 4 Jan 2020 00:49:33 +0000 (01:49 +0100)]
[WINESYNC]d3dx9/tests: Add more tests for D3DXMatrixTransformation().

Most of those new tests were written by Rico Schüller.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33456
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 956d7356e0559a07aac68bcaf73a5005e0600fad by David Adam <david.adam.cnrs@gmail.com>

4 years ago[WINESYNC]d3dx9: Use wincodecs directly without initializing COM system.
winesync [Sat, 4 Jan 2020 00:48:04 +0000 (01:48 +0100)]
[WINESYNC]d3dx9: Use wincodecs directly without initializing COM system.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 77c3761ad4e557f9fa311299e77746bf225a575a by Nikolay Sivov <nsivov@codeweavers.com>

4 years ago[WINESYNC]d3dx9/tests: Avoid some 64-bit test failures.
winesync [Sat, 4 Jan 2020 00:48:04 +0000 (01:48 +0100)]
[WINESYNC]d3dx9/tests: Avoid some 64-bit test failures.

Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 699eb8cdba8fe236f038550e2bd68a4cd2cab055 by Matteo Bruni <mbruni@codeweavers.com>

4 years ago[WINESYNC]d3dx9: Improve D3DXMatrixTransformation2D().
winesync [Sat, 4 Jan 2020 00:48:04 +0000 (01:48 +0100)]
[WINESYNC]d3dx9: Improve D3DXMatrixTransformation2D().

Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id dba1304bdde9639b01fa7b1e93cce1a298999b72 by Matteo Bruni <mbruni@codeweavers.com>

4 years ago[WINESYNC]d3dx9: Improve D3DXMatrixTransformation() implementation.
winesync [Sat, 4 Jan 2020 00:48:04 +0000 (01:48 +0100)]
[WINESYNC]d3dx9: Improve D3DXMatrixTransformation() implementation.

Inspired by a patch from David Adam.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33456
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id f54260a789387ab40de3d80291ad9000176dabe1 by Matteo Bruni <mbruni@codeweavers.com>

4 years ago[WINESYNC]d3dx9/tests: Fix a couple of ok() messages.
winesync [Sat, 4 Jan 2020 00:48:04 +0000 (01:48 +0100)]
[WINESYNC]d3dx9/tests: Fix a couple of ok() messages.

Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 5a5beba6c4e3bc53790e3a31916d0aaf57dc19b8 by Matteo Bruni <mbruni@codeweavers.com>

4 years ago[WINESYNC]d3dx9/tests: Expect plain render target creation to work.
winesync [Sat, 4 Jan 2020 00:48:04 +0000 (01:48 +0100)]
[WINESYNC]d3dx9/tests: Expect plain render target creation to work.

Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 64b6bb4d4a54642434594f0df2afcd2e90b2a0a8 by Matteo Bruni <mbruni@codeweavers.com>

4 years ago[WINESYNC]d3dx9: Use {lock|unlock}_surface() in D3DXLoadSurfaceFromMemory().
winesync [Sat, 4 Jan 2020 00:48:04 +0000 (01:48 +0100)]
[WINESYNC]d3dx9: Use {lock|unlock}_surface() in D3DXLoadSurfaceFromMemory().

Signed-off-by: Paul Gofman <gofmanp@gmail.com>
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 65956ae50a136fe8467a0332c7495f36617a16dc by Paul Gofman <gofmanp@gmail.com>

4 years ago[WINESYNC]d3dx9: Use temporary surface in D3DXSaveSurfaceToFileInMemory() for unmappa...
winesync [Sat, 4 Jan 2020 00:48:04 +0000 (01:48 +0100)]
[WINESYNC]d3dx9: Use temporary surface in D3DXSaveSurfaceToFileInMemory() for unmappable textures.

Fixes a regression triggered by commit
949dbbd31f450178c90ea8267097a975b77c3219.

Signed-off-by: Paul Gofman <gofmanp@gmail.com>
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 092c14b9d86ee1e96e465908cc524ec85988d0ff by Paul Gofman <gofmanp@gmail.com>

4 years ago[WINESYNC]d3dx9: Do not ignore surface map failure in D3DXSaveSurfaceToFileInMemory().
winesync [Sat, 4 Jan 2020 00:48:04 +0000 (01:48 +0100)]
[WINESYNC]d3dx9: Do not ignore surface map failure in D3DXSaveSurfaceToFileInMemory().

Signed-off-by: Paul Gofman <gofmanp@gmail.com>
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id ce090114340fe6ce9314f543a1389de9bdc6df14 by Paul Gofman <gofmanp@gmail.com>

4 years ago[WINESYNC]d3dx9/tests: Add test for D3DXFillVolumeTexture() with default pool texture.
winesync [Sat, 4 Jan 2020 00:48:04 +0000 (01:48 +0100)]
[WINESYNC]d3dx9/tests: Add test for D3DXFillVolumeTexture() with default pool texture.

Signed-off-by: Paul Gofman <gofmanp@gmail.com>
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 61e7e6ec1bf5d13d4cafa883ac74fe987c339740 by Paul Gofman <gofmanp@gmail.com>

4 years ago[WINESYNC]d3dx9: Use temporary surface in D3DXFillTexture() for unmappable textures.
winesync [Sat, 4 Jan 2020 00:48:04 +0000 (01:48 +0100)]
[WINESYNC]d3dx9: Use temporary surface in D3DXFillTexture() for unmappable textures.

Fixes a regression triggered by commit 949dbbd31f450178c90ea8267097a975b77c3219.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46453
Signed-off-by: Paul Gofman <gofmanp@gmail.com>
Signed-off-by: Matteo Bruni <mbruni@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 4e44d74afb12b40f673e3be0a91cd523013544cd by Paul Gofman <gofmanp@gmail.com>