Hermès Bélusca-Maïto [Mon, 25 Jun 2018 16:49:07 +0000 (18:49 +0200)]
[NTOS:SE] Add a documentation note about SeTokenIsWriteRestricted() and SeTokenIsAdmin(), and update the one for NtDuplicateToken().
[XDK] Move TOKEN_HAS_ADMIN_GROUP where appropriate.
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 14:03:40 +0000 (16:03 +0200)]
[NTOS:SE] Minor style changes.
- Use TRUE/FALSE instead of 1/0 for booleans.
- Use NULL instead of 0 for null pointers.
- Print 0x prefix for hex values in DPRINTs.
- Use new annotations for SepCreateToken() and SepDuplicateToken().
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:32:06 +0000 (15:32 +0200)]
[NTOS:SE] In SepCreateClientSecurity(), fix the impersonation level value passed to the SeCopyClientToken() call.
Caught while debugging, in the case the ImpersonationLevel value was
uninitialized, due to the fact it was left untouched on purpose by
PsReferenceEffectiveToken().
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:31:15 +0000 (15:31 +0200)]
[FORMATTING] No code change; typo fix.
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:24:44 +0000 (15:24 +0200)]
[NTOS:SE] Finish SepCreateImpersonationTokenDacl() implementation.
- Re-enable a commented-out block;
- Return the allocated Dacl.
- Use the correct pool tag when freeing the allocated Dacl.
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 13:21:33 +0000 (15:21 +0200)]
[NTOS:PS] Adjust the PsReferenceEffectiveToken() prototype in the header; add a comment about the fact that the ImpersonationLevel parameter can be left untouched on purpose in one special case.
Hermès Bélusca-Maïto [Mon, 25 Jun 2018 12:55:46 +0000 (14:55 +0200)]
[PSDK] ntsecpkg.h: fix minor typos (make some structure names MS-PSDK-compatible), and add LSA_TOKEN_INFORMATION_V2.
Hermès Bélusca-Maïto [Sun, 24 Jun 2018 01:30:10 +0000 (03:30 +0200)]
[SAMSRV] In SamrGetAliasMembership(), perform STATUS_OBJECT_NAME_NOT_FOUND status fixup in the assignment loop as done in the allocation loop.
This avoids this function returning failure while everything actually succeeded.
Hermès Bélusca-Maïto [Sun, 24 Jun 2018 01:25:21 +0000 (03:25 +0200)]
[LSASRV] If TokenInfo1->Privileges is NULL, which can be expected, pass a valid pointer to a valid but empty privilege structure to NtCreateToken(), as it always want a non-NULL pointer.
Hermès Bélusca-Maïto [Fri, 22 Jun 2018 22:17:05 +0000 (00:17 +0200)]
[ADVAPI32] Additions for CreateProcessAsUserA/W().
- Use a common helper function used by both the ANSI and UNICODE functions
so that the large code block that deals with setting the new process token
becomes automatically common to both these functions, while the ANSI vs.
UNICODE conversions are handled directly via the CreateProcessA/W() calls.
- Duplicate the token and acquire the process primary token assignment
privilege before calling NtSetInformationProcess().
Katayama Hirofumi MZ [Wed, 27 Jun 2018 21:11:31 +0000 (06:11 +0900)]
[SHELL32] Add missing desktop.ini files (#640)
Add the "desktop.ini" files to the special folders to realize their custom icons.
CORE-10045
Bișoc George [Wed, 27 Jun 2018 21:09:56 +0000 (23:09 +0200)]
[TRANSLATION][AT] Implement the Italian resource file (#641)
Katayama Hirofumi MZ [Wed, 27 Jun 2018 21:06:54 +0000 (06:06 +0900)]
[SHELL32] Enable custom CD/DVD icons (#639)
Properly show the custom icon specified in "autorun.inf" file in CDs/DVDs.
CORE-14766
David Knapp [Tue, 26 Jun 2018 07:13:49 +0000 (09:13 +0200)]
[AUTOCHK] Improve autochk messages
Bișoc George [Mon, 25 Jun 2018 08:35:14 +0000 (10:35 +0200)]
[NEWDEV] Fix a truncated text
Russell Johnson [Sun, 24 Jun 2018 18:29:57 +0000 (11:29 -0700)]
[SHELL32] Fixed TRASH_CanTrashFile() sending the wrong path string to GetVolumeInformationW() (#635)
Function TRASH_CanTrashFile() would always fail because GetVolumeInformationW() requires only the base root path. The path (stored in buffer wszRootPathName) was not being stripped correctly.
CORE-12340
Katayama Hirofumi MZ [Sun, 24 Jun 2018 18:04:25 +0000 (03:04 +0900)]
[SHELL32] Implement Folder Options File Types 'Change' button (#629)
CORE-12906
Katayama Hirofumi MZ [Sun, 24 Jun 2018 18:02:36 +0000 (03:02 +0900)]
[BROWSEUI] Re-enable the "Folder Options" menu item (#630)
It was originally disabled in r71192 (
8b77c254).
CORE-11141
Katayama Hirofumi MZ [Sun, 24 Jun 2018 17:59:03 +0000 (02:59 +0900)]
[SHELL32] Fix desktop.ini folder icon again (retrial of #595) (#632)
#595 failed at non-Desktop folder. We should use ILGetDisplayNameExW instead of SHGetPathFromLDList to get path from psf and pidl.
CORE-9196
Bișoc George [Sun, 24 Jun 2018 17:49:47 +0000 (19:49 +0200)]
[TRANSLATION][WHOAMI] Add Italian resource (#626)
Note: Supersedes PR #627
Katayama Hirofumi MZ [Sun, 24 Jun 2018 17:46:06 +0000 (02:46 +0900)]
[SHELL32] Implement OpenAs_RunDLLA/W (#628)
CORE-14751
Abdulganiev Rafael [Sun, 24 Jun 2018 17:42:34 +0000 (21:42 +0400)]
[TRANSLATION][SHELL32] Update Russian translation (#633)
David Quintana [Thu, 31 May 2018 21:50:49 +0000 (23:50 +0200)]
Add a document on the rules we should follow while managing/reviewing PRs,
and link to it from CONTRIBUTING.md and CODE_OF_CONDUCT.md
Timo Kreuzer [Tue, 15 May 2018 11:08:49 +0000 (13:08 +0200)]
[CMAKE] Add support for VS 15.7.1 / CL 19.14.x
Katayama Hirofumi MZ [Sat, 23 Jun 2018 02:00:11 +0000 (11:00 +0900)]
[SHELL32] Improve French Folder Options
Getequ [Fri, 22 Jun 2018 18:15:12 +0000 (01:15 +0700)]
[REGEDIT] Fix importing very big *.reg files (HEX values commonly) (#618)
This bug was found when I tried to import *.reg with huge HEX value (about 500 and much more lines of hex text).
Katayama Hirofumi MZ [Fri, 22 Jun 2018 14:44:58 +0000 (23:44 +0900)]
[SHLWAPI][APITESTS] Add test for PathUnExpandEnvStringsForUser (#602)
ROSTESTS-308
Katayama Hirofumi MZ [Fri, 22 Jun 2018 14:40:06 +0000 (23:40 +0900)]
[SHELL32] Implement the 'General' tab of the "Folder Options" dialog (#604)
CORE-14678
Hermès Bélusca-Maïto [Fri, 22 Jun 2018 14:34:16 +0000 (16:34 +0200)]
[EXPLORER] Simplify the current-shell-is-explorer check when trying to start the auto-start programs, by using the existing code.
Katayama Hirofumi MZ [Fri, 22 Jun 2018 14:02:25 +0000 (23:02 +0900)]
[USERINIT][EXPLORER] Fix auto startup of Start Menu (#594)
- Remove code for Start-Menu auto-startup items from userinit and put it where it belongs: in explorer.
CORE-10839
Katayama Hirofumi MZ [Fri, 22 Jun 2018 13:37:03 +0000 (22:37 +0900)]
[SHELL32] Fix desktop.ini folder icon (#595)
The folder icon location specified in desktop.ini of a folder should accept its relative path.
CORE-9196
Katayama Hirofumi MZ [Thu, 21 Jun 2018 16:18:57 +0000 (01:18 +0900)]
[EXPLORER] 'Run' (Win+R) should set the proper current directory (#593)
Arnav Bhatt [Thu, 21 Jun 2018 12:07:03 +0000 (17:37 +0530)]
[WELCOME] Add Hindi translation (#620)
Serge Gautherie [Thu, 21 Jun 2018 12:05:35 +0000 (14:05 +0200)]
[LOG2LINES] translate_line(): Let 'offset' be an 'unsigned int', instead of a 'size_t' (#624)
Avoids half-uninitialized value on, i.e., Linux 64-bit (with ReactOS 32-bit).
CORE-14737
Andrea Crescentini [Thu, 21 Jun 2018 12:03:35 +0000 (14:03 +0200)]
[TRANSLATION] Improving italian translation (#623)
- Improved Italian translation for USETUP, WELCOME, REACTOS, EXPLORER.
- Completed translation in SYSSETUP.
- Correct some characters encoding and text alignment in USETUP.
Serge Gautherie [Fri, 8 Jun 2018 14:24:05 +0000 (16:24 +0200)]
[NETAPI32_APITEST] Fix a NULL dereference of pInfo
With DPH enabled,
{{
Unhandled exception
ExceptionCode:
c0000005
Faulting Address: 0
...
modules/rostests/apitests/netapi32/DsRoleGetPrimaryDomainInformation.c:23 (func_DsRoleGetPrimaryDomainInformation)
...
}}
Bișoc George [Thu, 14 Jun 2018 08:05:36 +0000 (10:05 +0200)]
[USETUP] Some changes to address the recent review
Bișoc George [Wed, 13 Jun 2018 13:56:05 +0000 (15:56 +0200)]
[USETUP] Italian translation update
Thomas Faber [Fri, 30 Mar 2018 11:33:53 +0000 (13:33 +0200)]
Set minimum required version to 3.2.1 and set appropriate policies.
#556
Katayama Hirofumi MZ [Sat, 2 Jun 2018 02:05:52 +0000 (11:05 +0900)]
[APITESTS] Add ShellStateTest
Katayama Hirofumi MZ [Thu, 7 Jun 2018 06:48:42 +0000 (15:48 +0900)]
[SHELL32][APITESTS] Add tests of OpenAs_RunDLL
Serge Gautherie [Sun, 11 Feb 2018 22:37:34 +0000 (23:37 +0100)]
[DELAYIMP] Fix/Merge definitions of __pfnDliNotifyHook2 and __pfnDliFailureHook2
Serge Gautherie [Sun, 11 Feb 2018 22:33:16 +0000 (23:33 +0100)]
[DELAYIMP] Fix 2 Clang-Cl warnings about __pfnDliNotifyHook2Default and __pfnDliFailureHook2Default
"warning: 'extern' variable has an initializer [-Wextern-initializer]"
CORE-14306
Denis Malikov [Tue, 5 Jun 2018 17:13:51 +0000 (00:13 +0700)]
[SHELL32] Copy-paste files/folders into current place.
Files are copied with trying to find new path by adding (%d) suffix before asking for overwrite existing item
CORE-13788
Serge Gautherie [Fri, 18 May 2018 04:51:00 +0000 (06:51 +0200)]
[HALX86] Fix a Clang-Cl warning about KiUnexpectedInterrupt
"warning: cast between incompatible calling conventions 'cdecl' and 'fastcall'; calls through this pointer may abort at runtime [-Wcast-calling-convention]"
CORE-14306
Serge Gautherie [Fri, 8 Jun 2018 04:31:26 +0000 (06:31 +0200)]
[SYSSETUP] Fix a DPH report about dwPageCount
- "(sdk/lib/rtl/heappage.c:1329) corrupted suffix pattern"
detected at
"dll/win32/syssetup/wizard.c:2672 (InstallWizard)"
- Add an ASSERT(), as hinted by Mark Jansen.
Yaroslav Veremenko [Tue, 12 Jun 2018 21:38:05 +0000 (15:38 -0600)]
[MODULES] Update README file, with instructions about how to include rostests and rosapps (#613)
Adam Słaboń [Tue, 12 Jun 2018 13:51:37 +0000 (15:51 +0200)]
[TRANSLATION] Polish translation update (#611)
Polish translation update for MODE, USETUP and SHELL32.
Bișoc George [Mon, 11 Jun 2018 20:53:57 +0000 (22:53 +0200)]
[USETUP] Display the ReactOS release status (#608)
Update the introduction page with a more up-to-date exposition of the current status of ReactOS.
Erdem Ersoy [Mon, 11 Jun 2018 12:56:59 +0000 (12:56 +0000)]
[TRANSLATION][NOTEPAD] Update Turkish translation (#609)
Thomas Faber [Sun, 10 Jun 2018 13:45:57 +0000 (15:45 +0200)]
[ADVAPI32] Fix crash when running advapi32:security with DPH.
Import the following Wine commits:
*
79636bebbfa Michael Müller: advapi32: Set last error to ERROR_SUCCESS in GetSidIdentifierAuthority.
*
1d03ba76116 Hans Leidekker: advapi32: Fix parsing empty DACL/SACL security descriptor strings.
*
5bc2e83c7ab Hans Leidekker: advapi32: Fix size returned from ConvertStringSecurityDescriptorToSecurityDescriptor on 64-bit.
Thomas Faber [Mon, 4 Dec 2017 20:13:43 +0000 (21:13 +0100)]
[AFD] Respect the maximum receive buffer size for datagram sockets. CORE-14048
Hermès Bélusca-Maïto [Sun, 10 Jun 2018 01:59:22 +0000 (03:59 +0200)]
[CONSRV] Don't show the newly-created console if the window station, on which the console is created, is not interactive.
Hermès Bélusca-Maïto [Sun, 10 Jun 2018 01:23:01 +0000 (03:23 +0200)]
[CONSRV] Use a similar parameter name as in other functions.
Hermès Bélusca-Maïto [Sat, 9 Jun 2018 22:48:45 +0000 (00:48 +0200)]
[WIN32K] Fix DBG_PRINT macro.
Pierre Schweitzer [Sat, 9 Jun 2018 20:17:17 +0000 (22:17 +0200)]
[FASTFAT] Don't add an extra \, when renaming a file at root.
This fixes failures to rename a file where destination is
the root of a FAT volume.
CORE-10503
Pierre Schweitzer [Sat, 9 Jun 2018 16:21:32 +0000 (18:21 +0200)]
[FASTFAT] Use the FastFAT mechanism for counting clusters already implemented
This allows us having more accurate statistics regarding available clusters
count. Even though FastFAT and chkdsk still don't agree!
CORE-3877
Mark Jansen [Tue, 5 Jun 2018 20:08:18 +0000 (22:08 +0200)]
[RAPPS] Fix command line handling
Mark Jansen [Tue, 5 Jun 2018 22:21:06 +0000 (00:21 +0200)]
[ATL] Add CString.CompareNoCase
Mark Jansen [Tue, 5 Jun 2018 20:07:39 +0000 (22:07 +0200)]
[RAPPS] Select the search bar with ctrl+f
Hermès Bélusca-Maïto [Sat, 9 Jun 2018 13:37:54 +0000 (15:37 +0200)]
[USERSRV] HardError: Free WindowTitleU buffer only if we really allocated it.
Pierre Schweitzer [Sat, 9 Jun 2018 10:36:43 +0000 (12:36 +0200)]
[FASTFAT] Start implementing FAT32 statistics support
Not fully perfect yet, chkdsk still complains.
CORE-3877
Pierre Schweitzer [Sat, 9 Jun 2018 10:11:43 +0000 (12:11 +0200)]
[FASTFAT] Save the FSINFO sector location
Pierre Schweitzer [Fri, 8 Jun 2018 22:18:21 +0000 (00:18 +0200)]
[AUTOCHK] Let the timeout for disk repair to be configured
Bișoc George [Fri, 8 Jun 2018 17:06:56 +0000 (19:06 +0200)]
[TRANSLATION][DRWTSN32] Implement Romanian and Italian resource translations for Dr.Watson (#607)
Pierre Schweitzer [Thu, 7 Jun 2018 17:33:23 +0000 (19:33 +0200)]
[FASTFAT] Properly check for buffer size on dir enumeration.
This avoids improper returns when multiple entries are requested
and, in rare circumstances, entries not being seen by umode.
CORE-14699
Serge Gautherie [Thu, 7 Jun 2018 16:27:56 +0000 (18:27 +0200)]
[MSI_WINETEST] Fix MSVC_IDE build. (#564)
"reactos-cov\modules\rostests\winetests\msi\msi_winetest.rc(2): error RC2135: file not found: custom.dll [C:\ros_build\modules\rostests\winetests\msi\msi_winetest.vcxproj]".
Output files are written to Debug\ and Release\ subfolders in VSSolution mode, so the RC compiler will only find custom.dll if it knows to look in the right folder.
Thanks to Thomas Faber, who helped.
CORE-11836
Katayama Hirofumi MZ [Wed, 6 Jun 2018 12:04:50 +0000 (21:04 +0900)]
[SHELL32] Split dialogs/folder_options.cpp (#582)
The dialogs/folder_options.cpp source file in shell32 is too big to manage. We will split it to smaller files.
CORE-12906
Hermès Bélusca-Maïto [Tue, 5 Jun 2018 21:50:11 +0000 (23:50 +0200)]
[CRT] Always initialize _[w]pgmptr with a *FULL* path to the current application.
Otherwise fall back to the computed argv[0].
This is expected by some applications, for example Git.
Code is adapted from Wine.
Many thanks to Stanislav Motylkov for having investigated this bug!
CORE-12931 CORE-13892 CORE-13898 CORE-14066
Serge Gautherie [Tue, 5 Jun 2018 19:23:21 +0000 (21:23 +0200)]
[USER32_APITEST] RedrawWindow: Add a DestroyWindow() call (#423)
Addendum to
7905efdf357ad830d4abba23a428dcd9e6195247.
CORE-13734
Serge Gautherie [Tue, 5 Jun 2018 18:17:34 +0000 (20:17 +0200)]
[RSHELL] Remove a duplicated add_custom_command() call (#570)
Serge Gautherie [Tue, 5 Jun 2018 18:16:22 +0000 (20:16 +0200)]
[EXT2FS][REISERFS] VSSolution: Actually disable C4189 errors (#540)
Multiple "error C4189: '[...]': local variable is initialized but not referenced".
Thanks to Yuntian Zhang, who hinted at this in CORE-11836.
CORE-11280
Serge Gautherie [Fri, 25 May 2018 10:25:55 +0000 (12:25 +0200)]
[BROWSEUI] Remove a duplicated add_custom_command() call
Pierre Schweitzer [Tue, 5 Jun 2018 17:33:36 +0000 (19:33 +0200)]
[AUTOCHK] Allow users to skip disk checking if dirty
CORE-14692
Pierre Schweitzer [Tue, 5 Jun 2018 17:30:11 +0000 (19:30 +0200)]
[VFATLIB] Only check volume if full scan or if allowed to fix it
This allows doing a quick probe about whether a volume needs to be
fixed by checking its dirty bit.
CORE-14692
Serge Gautherie [Fri, 25 May 2018 00:49:08 +0000 (02:49 +0200)]
[CONFIGURE][CMAKE] Remove Visual Studio 9 (2008) support
ReactOS does not compile anymore with it.
VS9 is already officially unsupported.
CORE-11836
Serge Gautherie [Tue, 29 May 2018 14:02:26 +0000 (16:02 +0200)]
[CMAKE] Add "--always" parameter to "git describe" call
"fatal: No names found, cannot describe anything." message,
when called without enough history, i.e. appveyor.yml "clone_depth: 5".
Jared Smudde [Tue, 5 Jun 2018 15:17:00 +0000 (10:17 -0500)]
[MSHTA] Implement MSHTA.exe (#577) CORE-12813
Implement mshta.exe. It links directly to the function RunHTMLApplication in mshtml and passes the file name and other optional arguments along. While the function is unimplemented in mshtml, it's a start.
[MSHTML] Add ADD_IMPORTLIB to CMakeLists so mshta can link to mshtml.
[BOOTDATA] Add the association information for mshta.exe to the registry.
Thomas Faber [Mon, 4 Jun 2018 12:36:07 +0000 (14:36 +0200)]
[NTOS:CC] Access SectionObjectPointers without lock in CcRosInitializeFileCache. CORE-14691
kmtest:NtCreateSection calls CcInitializeCacheMap with a
NULL value for SectionObjectPointers. This will cause an exception when
trying to access it, which in Windows can be handled gracefully.
However accessing it while holding ViewLock means the lock will not be
released, leading to an APC_INDEX_MISMATCH bugcheck.
This solves the problem by allocating SharedCacheMap outside the lock,
then freeing it again under lock if another thread has updated SharedCacheMap
in the mean time. This is also What Windows Does(TM).
Katayama Hirofumi MZ [Mon, 4 Jun 2018 23:20:25 +0000 (08:20 +0900)]
[FONTS] Delete 16px bitmap from Tahoma Bold
Thomas Faber [Tue, 5 Jun 2018 09:36:30 +0000 (11:36 +0200)]
[OLE32_WINETEST] Fix MSVC build.
Thomas Faber [Mon, 4 Jun 2018 18:25:13 +0000 (20:25 +0200)]
[JSCRIPT] Fix MSVC build.
Amine Khaldi [Mon, 4 Jun 2018 02:59:33 +0000 (03:59 +0100)]
[XMLLITE_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:59:11 +0000 (03:59 +0100)]
[WTSAPI32] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:58:45 +0000 (03:58 +0100)]
[WMVCORE] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:58:20 +0000 (03:58 +0100)]
[WINTRUST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:57:53 +0000 (03:57 +0100)]
[WININET_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:57:34 +0000 (03:57 +0100)]
[WININET] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:57:07 +0000 (03:57 +0100)]
[WINHTTP_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:56:48 +0000 (03:56 +0100)]
[WINHTTP] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:56:11 +0000 (03:56 +0100)]
[WINDOWSCODECS_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:55:39 +0000 (03:55 +0100)]
[WINDOWSCODECS] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:54:55 +0000 (03:54 +0100)]
[INCLUDE/WINE] Update rbtree.h. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:54:01 +0000 (03:54 +0100)]
[WBEMPROX] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:53:34 +0000 (03:53 +0100)]
[VERSION] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:53:02 +0000 (03:53 +0100)]
[VBSCRIPT_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:52:36 +0000 (03:52 +0100)]
[VBSCRIPT] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:51:59 +0000 (03:51 +0100)]
[USP10_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:51:34 +0000 (03:51 +0100)]
[USP10] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:50:58 +0000 (03:50 +0100)]
[URLMON_WINETEST] Sync with Wine Staging 3.9. CORE-14656