reactos.git
12 months ago[WINMM] Sync wine commit ebae298 as a fix for CORE-15336 (#1031)
Baruch Rutman [Wed, 14 Nov 2018 11:32:55 +0000 (13:32 +0200)]
[WINMM] Sync wine commit ebae298 as a fix for CORE-15336 (#1031)

Reduce CPU usage by only attempting once to load the default joystick driver.
Fix for CORE-15336

Imported wine commit ebae298
https://github.com/wine-mirror/wine/commit/ebae298aa4d2711fef35d4ac60c6012438f36d61
https://www.winehq.org/pipermail/wine-devel/2018-November/134767.html

12 months ago[TFTPD] Fix Coverity #1434273 "Out-of-Bounds access" (#1037)
Pako Smith [Wed, 14 Nov 2018 11:30:30 +0000 (14:30 +0300)]
[TFTPD] Fix Coverity #1434273 "Out-of-Bounds access" (#1037)

'extbuff' must be of size _MAX_PATH to comply with its usage in the GetModuleFileName() call made in the code.

13 months ago[NTOSKRNL] Don't leak DACL 1036/head
Pierre Schweitzer [Sun, 11 Nov 2018 22:20:46 +0000 (23:20 +0100)]
[NTOSKRNL] Don't leak DACL

Spotted by Thomas :-)

13 months ago[MC] Add messages 2500-2999. The NERR-range is complete.
Eric Kohl [Sun, 11 Nov 2018 21:38:07 +0000 (22:38 +0100)]
[MC] Add messages 2500-2999. The NERR-range is complete.

13 months ago[PSDK] Add missing NERR-codes to lmerr.h
Eric Kohl [Sun, 11 Nov 2018 21:37:02 +0000 (22:37 +0100)]
[PSDK] Add missing NERR-codes to lmerr.h

13 months ago[NTOS:IO] RAW-FS: Few improvements.
Hermès Bélusca-Maïto [Sun, 11 Nov 2018 20:27:30 +0000 (21:27 +0100)]
[NTOS:IO] RAW-FS: Few improvements.

- Simplify the volume-deletion code in RawCheckForDismount().

- Fixes the OpenCount check in RawClose(): the VCB mutex must be
  released when the volume has not been dismounted, either because
  OpenCount != 0 or because RawCheckForDismount() returned FALSE.

- Explicitly use VCB_STATE_LOCKED instead of hardcoding its value.

- In IRP_MN_VERIFY_VOLUME handling, lock the volume before playing
  with it, and again let the volume be dismounted only if OpenCount == 0
  (and the IoDeleteDevice() call is done by RawCheckForDismount()).

13 months ago[NTOS:IO] RAW-FS: Minor code formatting only.
Hermès Bélusca-Maïto [Sun, 11 Nov 2018 20:23:21 +0000 (21:23 +0100)]
[NTOS:IO] RAW-FS: Minor code formatting only.

13 months ago[SETUPLIB] Lock the BTRFS volume before installing the new bootsector code.
Hermès Bélusca-Maïto [Sun, 11 Nov 2018 19:31:35 +0000 (20:31 +0100)]
[SETUPLIB] Lock the BTRFS volume before installing the new bootsector code.

CORE-15334 CORE-15339

The BTRFS driver requires the volume to be locked in order to modify
the first sectors of the partition, even though they are outside the
file-system space / in the reserved area (they are situated before
the super-block at 0x1000) and is in principle allowed by the NT
storage stack.
So we lock here in order to write the bootsector at sector 0.
If locking fails, we ignore and continue nonetheless.

See also the following links for reference:
https://stackoverflow.com/a/12928934
https://docs.microsoft.com/en-us/windows/desktop/api/fileapi/nf-fileapi-writefile
https://support.microsoft.com/en-us/help/942448/changes-to-the-file-system-and-to-the-storage-stack-to-restrict-direct

13 months ago[SETUPLIB] Use proper file share access when opening partitions for raw access.
Hermès Bélusca-Maïto [Sun, 11 Nov 2018 16:14:13 +0000 (17:14 +0100)]
[SETUPLIB] Use proper file share access when opening partitions for raw access.

13 months ago[BTRFS] Import BTRFS upstream commit e43183a0 "open_file: set granted_access when...
Mark Harmstone [Sun, 11 Nov 2018 18:47:35 +0000 (18:47 +0000)]
[BTRFS] Import BTRFS upstream commit e43183a0 "open_file: set granted_access when creating file".

Better solution for the original problem described at:
https://github.com/maharmstone/btrfs/pull/123

13 months ago[MC] Add messages 2300-2484 to netmsg.dll.
Eric Kohl [Sun, 11 Nov 2018 18:53:34 +0000 (19:53 +0100)]
[MC] Add messages 2300-2484 to netmsg.dll.

13 months ago[PSDK] Add missing NERR_IsDfsShare to lmerr.h.
Eric Kohl [Sun, 11 Nov 2018 18:33:49 +0000 (19:33 +0100)]
[PSDK] Add missing NERR_IsDfsShare to lmerr.h.

13 months ago[NETSHELL] CNetConUiObject: Fix implementation of IContextMenu.
Giannis Adamopoulos [Sun, 11 Nov 2018 18:09:53 +0000 (20:09 +0200)]
[NETSHELL] CNetConUiObject: Fix implementation of IContextMenu.
The id that InvokeCommand gets is the one used by QueryContextMenu after subtracting idCmdFirst.

13 months ago[NETSHELL] CNetConUiObject: Implement handling the rename context menu item
Giannis Adamopoulos [Sun, 11 Nov 2018 13:46:58 +0000 (15:46 +0200)]
[NETSHELL] CNetConUiObject: Implement handling the rename context menu item

13 months ago[NETSHELL] CNetConUiObject: Use a switch in InvokeCommand
Giannis Adamopoulos [Sun, 11 Nov 2018 13:37:44 +0000 (15:37 +0200)]
[NETSHELL] CNetConUiObject: Use a switch in InvokeCommand

13 months ago[NETSHELL] CNetworkConnections: Remove SFGAO_CANRENAME bit when renaming shouldn...
Giannis Adamopoulos [Sun, 11 Nov 2018 10:40:45 +0000 (12:40 +0200)]
[NETSHELL] CNetworkConnections: Remove SFGAO_CANRENAME bit when renaming shouldn't be enabled.
This fixes the problem where renaming could take place by clicking on a name even when it is disabled in the context menu.
CORE-14116

13 months ago[NETSHELL] CNetworkConnections: SetNameOf should always return a new pidl on success.
Giannis Adamopoulos [Sun, 11 Nov 2018 10:29:20 +0000 (12:29 +0200)]
[NETSHELL] CNetworkConnections: SetNameOf should always return a new pidl on success.
CORE-14116

13 months ago[SHELL32] CDefView: Don't assume that SetNameOf always works properly so initialize...
Giannis Adamopoulos [Sun, 11 Nov 2018 10:27:55 +0000 (12:27 +0200)]
[SHELL32] CDefView: Don't assume that SetNameOf always works properly so initialize pidlNew to NULL before
CORE-14116

13 months ago[FLTMC] Add volumes usage info
Ged Murphy [Sun, 11 Nov 2018 18:05:47 +0000 (18:05 +0000)]
[FLTMC] Add volumes usage info

13 months ago[FLTMC] Implement 'fltmc volumes'
Ged Murphy [Sun, 11 Nov 2018 17:57:56 +0000 (17:57 +0000)]
[FLTMC] Implement 'fltmc volumes'

13 months ago[FLTMC] Support displaying legacy FS filters
Ged Murphy [Sun, 11 Nov 2018 15:41:23 +0000 (15:41 +0000)]
[FLTMC] Support displaying legacy FS filters

13 months ago[FLTMC] Fix output when no args are shown
Ged Murphy [Sun, 11 Nov 2018 15:02:34 +0000 (15:02 +0000)]
[FLTMC] Fix output when no args are shown

13 months ago[TRANSLATION] Turkish translations of many components. (#1026)
Ercan Ersoy [Sun, 11 Nov 2018 17:13:48 +0000 (20:13 +0300)]
[TRANSLATION] Turkish translations of many components. (#1026)

13 months ago[TRANSLATION] Update Simplified Chinese translation. (#1028)
Luo Yufan [Sun, 11 Nov 2018 16:57:12 +0000 (00:57 +0800)]
[TRANSLATION] Update Simplified Chinese translation. (#1028)

13 months ago[MC] Add messages 2250-2299 and 3510-3513 to netmsg.dll.
Eric Kohl [Sun, 11 Nov 2018 16:55:16 +0000 (17:55 +0100)]
[MC] Add messages 2250-2299 and 3510-3513 to netmsg.dll.

13 months ago[TRANSLATION] Polish translation update (#1029)
Adam Słaboń [Sun, 11 Nov 2018 16:55:01 +0000 (17:55 +0100)]
[TRANSLATION] Polish translation update (#1029)

Translated missing strings and improved existing translations.

13 months ago[SETUP] Align partition start at 2048 minimum
Pierre Schweitzer [Sun, 11 Nov 2018 16:34:35 +0000 (17:34 +0100)]
[SETUP] Align partition start at 2048 minimum

This will allow compatibility with modern OSes and
modern disk management utilities.
It will also improve performances by properly aligning
partition start.
And it will let enough room at the begin of the disk
for 3rd party bootloaders.

WARNING: this is not compatible with previous partition
model, and old one will likely not be compatible. You'll
have to erase your whole partition table and start from
scratch.

13 months ago[DRWTSN32] Include displacement in stacktrace.
Mark Jansen [Sun, 11 Nov 2018 14:39:37 +0000 (15:39 +0100)]
[DRWTSN32] Include displacement in stacktrace.

13 months ago[GFLAGS] Use the registry access flags passed in
Mark Jansen [Sun, 11 Nov 2018 14:34:59 +0000 (15:34 +0100)]
[GFLAGS] Use the registry access flags passed in

13 months ago[MS] Add messages 2200-2249 and 3502-3507 to netmsg.dll.
Eric Kohl [Sun, 11 Nov 2018 14:46:15 +0000 (15:46 +0100)]
[MS] Add messages 2200-2249 and 3502-3507 to netmsg.dll.

13 months ago[NTOSKRNL] Create a security descriptor for the \security directory object
Pierre Schweitzer [Sat, 10 Nov 2018 22:23:59 +0000 (23:23 +0100)]
[NTOSKRNL] Create a security descriptor for the \security directory object

13 months agoUpdate the release info
Bișoc George [Sat, 10 Nov 2018 14:48:11 +0000 (15:48 +0100)]
Update the release info

13 months ago[NTOSKRNL] Return security descriptor size when querying object basic info
Pierre Schweitzer [Sat, 10 Nov 2018 09:31:03 +0000 (10:31 +0100)]
[NTOSKRNL] Return security descriptor size when querying object basic info

13 months ago[NTOSKRNL] Return quota information when querying object basic info
Pierre Schweitzer [Sat, 10 Nov 2018 09:02:34 +0000 (10:02 +0100)]
[NTOSKRNL] Return quota information when querying object basic info

13 months ago[MC] Add some messages to netmsg.dll.
Eric Kohl [Sat, 10 Nov 2018 09:32:30 +0000 (10:32 +0100)]
[MC] Add some messages to netmsg.dll.

13 months ago[TRANSLATION] Update Simplified Chinese translation. (#1025)
Luo Yufan [Fri, 9 Nov 2018 14:31:53 +0000 (22:31 +0800)]
[TRANSLATION] Update Simplified Chinese translation. (#1025)

13 months ago[OSK][RAPPS][USETUP] Turkish translations update. (#1024)
Ercan Ersoy [Fri, 9 Nov 2018 14:13:03 +0000 (17:13 +0300)]
[OSK][RAPPS][USETUP] Turkish translations update. (#1024)

13 months ago[FDEBUG][OSK][WINHLP32] Turkish translations update. (#1022)
Ercan Ersoy [Thu, 8 Nov 2018 17:52:56 +0000 (20:52 +0300)]
[FDEBUG][OSK][WINHLP32] Turkish translations update. (#1022)

13 months ago[SYSDM] Update Simplified Chinese translation. (#1021)
Luo Yufan [Thu, 8 Nov 2018 13:08:34 +0000 (21:08 +0800)]
[SYSDM] Update Simplified Chinese translation. (#1021)

13 months ago[USETUP] Fix and add Turkish translation. (#1020)
Ercan Ersoy [Thu, 8 Nov 2018 12:25:45 +0000 (15:25 +0300)]
[USETUP] Fix and add Turkish translation. (#1020)

13 months ago[USETUP] Display the chosen filesystem name in case of bootcode installation failure.
Hermès Bélusca-Maïto [Wed, 7 Nov 2018 23:54:59 +0000 (00:54 +0100)]
[USETUP] Display the chosen filesystem name in case of bootcode installation failure.

Simplified implementation of the proposed solution by George Bișoc
and revised by Victor Perevertkin from PR #952.

NOTE: For whatever reason ERROR_INSTALL_BOOTCODE and ERROR_WRITE_BOOT
seem to be redundant with each other. To be investigated...

13 months ago[USETUP] Remove the PARTITION_EXT2 constant and use PARTITION_LINUX in favour since...
Bișoc George [Sun, 28 Oct 2018 12:28:56 +0000 (13:28 +0100)]
[USETUP] Remove the PARTITION_EXT2 constant and use PARTITION_LINUX in favour since PARTITION_EXT2 is just an alias to PARTITION_LINUX

And since we're here, add PARTITION_LINUX_EXT to ReactOS I/O controls header (rosioctl.h).

13 months ago[USETUP] When choosing BTRFS for the partition, don't think of it as Ext2 but just...
Bișoc George [Fri, 19 Oct 2018 18:07:44 +0000 (20:07 +0200)]
[USETUP] When choosing BTRFS for the partition, don't think of it as Ext2 but just a Linux partition

Most of Linux filesystems have the MBR ID assigned as 0x83 and when the user chooses BTRFS upon partitions page wizard, we're thinking of the partition as having Ext2 filesystem which is wrong and misleading.

13 months ago[TRANSLATIONS] Style fixes for Estonian
Joann Mõndresku [Sun, 28 Oct 2018 07:28:09 +0000 (09:28 +0200)]
[TRANSLATIONS] Style fixes for Estonian

13 months ago[WELCOME] Fix some Turkish translations.
Ercan Ersoy [Wed, 7 Nov 2018 19:02:31 +0000 (22:02 +0300)]
[WELCOME] Fix some Turkish translations.

13 months ago[REACTOS] Fix and add Turkish translations.
Ercan Ersoy [Wed, 7 Nov 2018 19:00:33 +0000 (22:00 +0300)]
[REACTOS] Fix and add Turkish translations.

13 months ago[TRANSLATIONS] Estonian for various base applications
Joann Mõndresku [Fri, 26 Oct 2018 21:40:19 +0000 (00:40 +0300)]
[TRANSLATIONS] Estonian for various base applications

13 months ago[INCLUDE] typo in msgdump.h, s/MS_msgdump/MD_msgdump/ (#1016)
Katayama Hirofumi MZ [Wed, 7 Nov 2018 15:51:41 +0000 (00:51 +0900)]
[INCLUDE] typo in msgdump.h, s/MS_msgdump/MD_msgdump/ (#1016)

Fix #1015.

13 months ago[APPWIZ] Update polish translation (#921)
Zcooger [Wed, 7 Nov 2018 15:20:32 +0000 (16:20 +0100)]
[APPWIZ] Update polish translation (#921)

13 months ago[INCLUDE] Add <winxx.h> and <msgdump.h> (#1015)
Katayama Hirofumi MZ [Wed, 7 Nov 2018 13:28:59 +0000 (22:28 +0900)]
[INCLUDE] Add <winxx.h> and <msgdump.h> (#1015)

File "sdk/include/reactos/msgdump.h" I added helps us dump Win32API message info. Use freely.

13 months ago[SHELL32] Fix CORE-15295, wrong edit width in IDD_FILE_PROPERTIES for all langs
Joachim Henze [Wed, 7 Nov 2018 00:40:53 +0000 (01:40 +0100)]
[SHELL32] Fix CORE-15295, wrong edit width in IDD_FILE_PROPERTIES for all langs

13 months ago[NETSHELL] Add missing interface stubs to CNetworkConnections (aka CConnectionFolder).
Eric Kohl [Tue, 6 Nov 2018 21:23:08 +0000 (22:23 +0100)]
[NETSHELL] Add missing interface stubs to CNetworkConnections (aka CConnectionFolder).

13 months ago[REACTOS] Add features/usability additions.
Hermès Bélusca-Maïto [Sun, 28 Jan 2018 22:47:25 +0000 (23:47 +0100)]
[REACTOS] Add features/usability additions.

- Interface the TreeList code and populate it with the list of
  discovered disks and partitions. Code is adapted from USETUP.
  Also display the names of the disks.

- Display some installation settings summary, before doing the
  installation proper.

- Force the user to select a checkbox when (s)he acknowledges that
  ReactOS is alpha-quality software and may break on his/her computer
  or corrupt his/her data.

- Improve wizard pages transitions and buttons enabling/disabling.

- Press Shift-F10 to start a command-line (as in the 2nd-stage setup
  in syssetup.dll).

- Use some explicit UNICODE functions/macros.

13 months ago[REACTOS] Add two icons (drive and partition) for the drive list.
Hermès Bélusca-Maïto [Sun, 28 Jan 2018 22:05:43 +0000 (23:05 +0100)]
[REACTOS] Add two icons (drive and partition) for the drive list.

13 months ago[REACTOS] Update translations and add dialog controls for Setup Summary dialog.
Hermès Bélusca-Maïto [Sun, 28 Jan 2018 21:53:47 +0000 (22:53 +0100)]
[REACTOS] Update translations and add dialog controls for Setup Summary dialog.

13 months ago[REACTOS] Add a TreeList control (TreeView with columns).
Hermès Bélusca-Maïto [Sun, 28 Jan 2018 21:10:51 +0000 (22:10 +0100)]
[REACTOS] Add a TreeList control (TreeView with columns).

Add the TreeList control from Anton Zechner and Sébastien Kirche
from https://github.com/sebkirche/treelist (under GPL-3.0+) as a
*TEMPORARY* solution until a better-suited control for ReactOS is
developed.

- Compilation fixes for the TreeList control.

13 months ago[SETUPLIB] Retrieve and store the machine (architecture) ID of the discovered NTOS...
Hermès Bélusca-Maïto [Sun, 28 Jan 2018 22:32:52 +0000 (23:32 +0100)]
[SETUPLIB] Retrieve and store the machine (architecture) ID of the discovered NTOS installations. Will be used later.

13 months ago[SETUPLIB][USETUP] Partition code improvements.
Hermès Bélusca-Maïto [Sun, 28 Jan 2018 22:24:06 +0000 (23:24 +0100)]
[SETUPLIB][USETUP] Partition code improvements.

- SETUPLIB and USETUP: Convert PARTENTRY::DriveLetter to WCHAR.

- SETUPLIB: Retrieve volume label.

- SETUPLIB and USETUP: Move the partition types (IDs) table from
  USETUP to SETUPLIB so that they can share it with the 1st-stage
  GUI installer too. Also take the opportunity to update the table
  with information from http://www.win.tue.nl/~aeb/partitions/partition_types-1.html
  and cross-checked with the list from Paragon Hard-Disk Manager.

- USETUP: Simplify PrintPartitionData().
- Add some code comments.

13 months ago[REACTOS] Add helpers and modify ConvertNtPathToWin32Path() to make it use a cache...
Hermès Bélusca-Maïto [Tue, 9 Jan 2018 02:21:38 +0000 (03:21 +0100)]
[REACTOS] Add helpers and modify ConvertNtPathToWin32Path() to make it use a cache of NT/Win32 path mappings.

This increases performance for each time the SETUPLIB calls (using NT paths)
Win32 SetupAPI functions which of course only accept Win32 paths.

- Handle also the fact that a NT path to convert may start with
  \Device\HarddiskX\PartitionY\..., which can be a symlink to
  \Device\HarddiskVolumeN\... on some systems. In that case, the
  Win32 path mapping should be done slightly differently.

- Add support for network mapped drives.

13 months ago[REACTOS] Diverse UI improvements.
Hermès Bélusca-Maïto [Sun, 7 Jan 2018 00:35:48 +0000 (01:35 +0100)]
[REACTOS] Diverse UI improvements.

- Improve UI usage and wizard transitions (Work In Progress).
- Add interfacing code that display installation status.
- When the user attempts to cancel the installation during file copying,
  pause the file copying, and restart it if the user changes it mind and
  wants to continue the installation. Otherwise file copying is properly
  halted.

13 months ago[BOOTDATA][SETUPLIB][REACTOS] INF support fixes.
Hermès Bélusca-Maïto [Mon, 15 Jan 2018 17:09:53 +0000 (18:09 +0100)]
[BOOTDATA][SETUPLIB][REACTOS] INF support fixes.

- BOOTDATA: Use standard INF signature string, so that they can be
  opened successfully using ReactOS' or Windows' setupapi.dll with
  the INF_STYLE_WIN4 style.

- SETUPLIB: Use the correct INF_STYLE_* INF styles in SpInfOpenInfFile() calls.

- REACTOS : Switch thread locale to user-specified LocaleId when calling
  SetupOpenInfFileW(), so that the correct localized strings are used.

13 months ago[SETUPLIB] Fixes and improvements for the file copying code.
Hermès Bélusca-Maïto [Sun, 7 Jan 2018 00:35:48 +0000 (01:35 +0100)]
[SETUPLIB] Fixes and improvements for the file copying code.

- In PrepareCopyInfFile(), explicitly use AddSectionToCopyQueueCab()
  to retrieve the files from the CAB INF.

  Otherwise if one continued to use and rely on AddSectionToCopyQueue()
  to do this job instead, bad things could happen like, re-enumerating
  twice or more (and adding them to the file queue) the same files.
  This is because in the new code AddSectionToCopyQueue() can be called
  many times to deal with different SIF file sections. The old code then
  called AddSectionToCopyQueueCab() in turn, but on the same list...
  Now the steps performed are clear, and everything works as intended.

- Simplify the code that computes the full source and destination paths
  for the files to be copied and directories to be created, using helper
  functions.

- Compute the source file and target location from the TXTSETUP.SIF
  entries in a NT-compatible manner.

13 months ago[BOOTDATA] Use a Win2k3-compatible TXTSETUP.SIF layout for the specification of the...
Hermès Bélusca-Maïto [Sun, 7 Jan 2018 00:47:52 +0000 (01:47 +0100)]
[BOOTDATA] Use a Win2k3-compatible TXTSETUP.SIF layout for the specification of the files list.

Also add detailed documentation about the meaning of each field, obtained from:
- my own tests;
- http://www.msfn.org/board/topic/125480-txtsetupsif-syntax/
- http://www.msfn.org/board/topic/127677-txtsetupsif-layoutinf-reference/

In addition, add a spreadsheet that helps generating the files list.

Note that the files source directory is "\reactos", until we use
per-architecture directories in the installation medium.

13 months ago[SETUPLIB][USETUP] Move all the code that performs file copying into the SETUPLIB.
Hermès Bélusca-Maïto [Sun, 7 Jan 2018 00:35:48 +0000 (01:35 +0100)]
[SETUPLIB][USETUP] Move all the code that performs file copying into the SETUPLIB.

13 months ago[SETUPLIB][USETUP] Add support for setup error handling.
Hermès Bélusca-Maïto [Sun, 28 Oct 2018 21:51:33 +0000 (22:51 +0100)]
[SETUPLIB][USETUP] Add support for setup error handling.

13 months ago[WIN32SS][FONT] Fix regression of #1004 (#1012)
Katayama Hirofumi MZ [Mon, 5 Nov 2018 07:24:23 +0000 (16:24 +0900)]
[WIN32SS][FONT] Fix regression of #1004 (#1012)

Signed-off-by: Doug Lyons <douglyons@douglyons.com>
CORE-15333

13 months ago[SCHEDSVC] Start jobs on timeout
Eric Kohl [Sun, 4 Nov 2018 23:22:30 +0000 (00:22 +0100)]
[SCHEDSVC] Start jobs on timeout

- Start jobs on timeout
- Add job flags to the idl file

13 months ago[WIN32SS][FONT] Fix ntmCellHeight value to usWinAscent + usWinDescent (#1010)
Katayama Hirofumi MZ [Sun, 4 Nov 2018 21:03:53 +0000 (06:03 +0900)]
[WIN32SS][FONT] Fix ntmCellHeight value to usWinAscent + usWinDescent (#1010)

CORE-15331

13 months ago[MC] Add some messages to netmsg.dll
Eric Kohl [Sun, 4 Nov 2018 17:39:13 +0000 (18:39 +0100)]
[MC] Add some messages to netmsg.dll

13 months ago[LSASRV] Return STATUS_DIRECTORY_SERVICE_REQUIRED for all trusted domain functions...
Eric Kohl [Sun, 4 Nov 2018 14:27:57 +0000 (15:27 +0100)]
[LSASRV] Return STATUS_DIRECTORY_SERVICE_REQUIRED for all trusted domain functions that use a policy handle and a domain name or domain SID when the machine is not a domain controller.

13 months ago[LSASRV] Coding style fixes
Eric Kohl [Sun, 4 Nov 2018 11:50:21 +0000 (12:50 +0100)]
[LSASRV] Coding style fixes

13 months ago[KMTESTS:MM] Fix 'PAGE_NOACCESS' copypasta, in an error string
Serge Gautherie [Sat, 3 Nov 2018 13:57:24 +0000 (14:57 +0100)]
[KMTESTS:MM] Fix 'PAGE_NOACCESS' copypasta, in an error string

ROSTESTS-110

13 months ago[KMTESTS/MM] Enable again accessing forbidden memory.
Jérôme Gardou [Fri, 2 Nov 2018 17:26:52 +0000 (18:26 +0100)]
[KMTESTS/MM] Enable again accessing forbidden memory.

Also adda test case for the PAGE_GUARD case

ROSTESTS-110

13 months ago[NTOS/MM] Properly handle page faults in regions marked with
Jérôme Gardou [Fri, 2 Nov 2018 17:23:16 +0000 (18:23 +0100)]
[NTOS/MM] Properly handle page faults in regions marked with
PAGE_NOACCESS or PAGE_GUARD

ROSTESTS-110

13 months ago[NTOS/MM] Move up MmAlterViewAttributes for later use in MmNotPresentFaultSectionView
Jérôme Gardou [Fri, 2 Nov 2018 17:20:13 +0000 (18:20 +0100)]
[NTOS/MM] Move up MmAlterViewAttributes for later use in MmNotPresentFaultSectionView

No code change

13 months ago[WIN32SS][FONT] Define IntUnicodeStringToBuffer function and use it (#1004)
Katayama Hirofumi MZ [Fri, 2 Nov 2018 20:42:58 +0000 (05:42 +0900)]
[WIN32SS][FONT] Define IntUnicodeStringToBuffer function and use it (#1004)

- Define IntUnicodeStringToBuffer function to copy the contents of a UNICODE_STRING to a string buffer with a UNICODE_NULL correctly.
- Use it.
JIRA issue: N/A

13 months ago[WIN32SS][FONT] Improve Precision Penalty (#1006)
Katayama Hirofumi MZ [Fri, 2 Nov 2018 20:37:05 +0000 (05:37 +0900)]
[WIN32SS][FONT] Improve Precision Penalty (#1006)

13 months ago[REACTOS] Don't include another module's PCH aka fix build.
Thomas Faber [Fri, 2 Nov 2018 10:10:07 +0000 (11:10 +0100)]
[REACTOS] Don't include another module's PCH aka fix build.

13 months ago[WIN32SS][FONT] Add ASSERT_FREETYPE_LOCK_HELD(); in FillTMEx (#1005)
Katayama Hirofumi MZ [Fri, 2 Nov 2018 09:53:50 +0000 (18:53 +0900)]
[WIN32SS][FONT] Add ASSERT_FREETYPE_LOCK_HELD(); in FillTMEx (#1005)

Add a assertion for locking, in FillTMEx function of freetype.c. CORE-15166

13 months ago[SETUPAPI] Don't let LZClose() reset error code
Pierre Schweitzer [Fri, 2 Nov 2018 08:34:25 +0000 (09:34 +0100)]
[SETUPAPI] Don't let LZClose() reset error code

13 months agoAvoid stray temp files in failure cases of do_file_copyW. CORE-12616
Carlo Bramini [Fri, 2 Mar 2018 09:14:07 +0000 (10:14 +0100)]
Avoid stray temp files in failure cases of do_file_copyW. CORE-12616

13 months ago[WIN32SS][FONT] Move IntUnLockFreeType(); in ftGdiGetTextMetricsW (#1002)
Katayama Hirofumi MZ [Fri, 2 Nov 2018 07:29:18 +0000 (16:29 +0900)]
[WIN32SS][FONT] Move IntUnLockFreeType(); in ftGdiGetTextMetricsW (#1002)

Adjust timing of FreeType unlocking in ftGdiGetTextMetricsW function of "freetype.c". JIRA issue: N/A

13 months ago[WIN32SS][FONT] Add DPRINT1 and ASSERT for font resize failure (#1003)
Katayama Hirofumi MZ [Fri, 2 Nov 2018 07:28:00 +0000 (16:28 +0900)]
[WIN32SS][FONT] Add DPRINT1 and ASSERT for font resize failure (#1003)

Add DPRINT1 and ASSERT calls for font resize failure in IntRequestFontSize function. JIRA issue: N/A

13 months ago[REACTOS] Temporarily exclude the 1st-stage GUI setup from build, until I (or someone...
Hermès Bélusca-Maïto [Thu, 1 Nov 2018 22:20:27 +0000 (23:20 +0100)]
[REACTOS] Temporarily exclude the 1st-stage GUI setup from build, until I (or someone else) finds the correct way to fix the GCC builds.

13 months ago[SETUPLIB][USETUP] Minor improvements.
Hermès Bélusca-Maïto [Sun, 7 Jan 2018 00:35:48 +0000 (01:35 +0100)]
[SETUPLIB][USETUP] Minor improvements.

- Use adequate access flag when opening symbolic links.
- Simplify the prototype of UpdateRegistry() since now both Setup INF
  handle and settings lists are inside the USETUP_DATA structure.

13 months ago[USETUP] Improve SetupCommitFileQueueW() to make it compatible with its Win32 counter...
Hermès Bélusca-Maïto [Mon, 15 Jan 2018 17:48:51 +0000 (18:48 +0100)]
[USETUP] Improve SetupCommitFileQueueW() to make it compatible with its Win32 counterpart.

This means, call in the correct order the user callback with the correct
parameters (in particular the correct paths for file copy operations),
and check also for the callback returned value to know whether or not to
continue the file operations.

13 months ago[SETUPLIB][REACTOS][USETUP] Further improve the interfacing with INF and File-Queue...
Hermès Bélusca-Maïto [Sat, 6 Jan 2018 15:47:37 +0000 (16:47 +0100)]
[SETUPLIB][REACTOS][USETUP] Further improve the interfacing with INF and File-Queue APIs.

This allows using some of the SetupApi.dll functions when SETUPLIB is
used in the (Win32) GUI 1st-stage installer "REACTOS", while using the
custom implemented NT-aware functions in "USETUP".

13 months ago[USETUP] Improvements for the File-queues code.
Hermès Bélusca-Maïto [Fri, 5 Jan 2018 01:08:59 +0000 (02:08 +0100)]
[USETUP] Improvements for the File-queues code.

- Add support for delete and move/rename operations, which are needed
  for implementing ReactOS upgrading support.

- Use cabinet contexts.
- Use standard LIST_ENTRY structures for implementing the lists.

- Move the path-building hack code in SetupCommitFileQueueW() that had
  been introduced in r66604 (97bb83f) out of the file-queues code.

- Make the function prototypes compatible with win32's setupapi functions.
- Fix the format of the data passed to the custom notification handler.
- Adjust the file-copy callback to correctly use its arguments (setupapi-compatible).

13 months ago[UMPNPMGR] Implement PNP_DetectResourceConflict().
Eric Kohl [Thu, 1 Nov 2018 13:50:08 +0000 (14:50 +0100)]
[UMPNPMGR] Implement PNP_DetectResourceConflict().

13 months ago[RICHED20] Revert ocr_reverse.cur to fix CORE-15190
Joachim Henze [Tue, 30 Oct 2018 18:06:50 +0000 (19:06 +0100)]
[RICHED20] Revert ocr_reverse.cur to fix CORE-15190

Old cursor looks better.
We revert to SVN state r75865 and note the diff for Amine
so that the wrong version won't come back in the future.

Old file is just 326bytes while the one that we do not want is 33.134bytes
which means we will save some RAM as well.

13 months ago[CMAKE] Do not add any extension to separate debug symbol files (#1000)
Jérôme Gardou [Tue, 30 Oct 2018 16:23:42 +0000 (17:23 +0100)]
[CMAKE] Do not add any extension to separate debug symbol files (#1000)

There is no possibility for GDB to recognize them otherwise

13 months ago[WIN32SS] Fix SwitchToThisWindow for #998 (#999)
Katayama Hirofumi MZ [Tue, 30 Oct 2018 08:24:47 +0000 (17:24 +0900)]
[WIN32SS] Fix SwitchToThisWindow for #998 (#999)

Reduce a failure in SwitchToThisWindow testcase of #998. CORE-15165

13 months ago[APITESTS] Add InSendMessage check in SwitchToThisWindow testcase (#998)
Katayama Hirofumi MZ [Tue, 30 Oct 2018 08:14:37 +0000 (17:14 +0900)]
[APITESTS] Add InSendMessage check in SwitchToThisWindow testcase (#998)

CORE-15165

13 months ago[APITESTS] Improve CloseWindow testcase (#997)
Katayama Hirofumi MZ [Mon, 29 Oct 2018 23:54:40 +0000 (08:54 +0900)]
[APITESTS] Improve CloseWindow testcase (#997)

Improve the testcase for user32!CloseWindow function.

13 months ago[APITESTS] Add CloseWindow testcase (#996)
Katayama Hirofumi MZ [Mon, 29 Oct 2018 23:38:03 +0000 (08:38 +0900)]
[APITESTS] Add CloseWindow testcase (#996)

Add a testcase for user32!CloseWindow function.

13 months ago[WIN32SS] Make window foreground in SwitchToThisWindow (#995)
Katayama Hirofumi MZ [Mon, 29 Oct 2018 23:13:05 +0000 (08:13 +0900)]
[WIN32SS] Make window foreground in SwitchToThisWindow (#995)

CORE-15165

13 months ago[FLTMGR] Remove duplicated export
Pierre Schweitzer [Mon, 29 Oct 2018 16:28:01 +0000 (17:28 +0100)]
[FLTMGR] Remove duplicated export

13 months ago[FLTMGR] Add a bit more basic code layout for filter registration
Ged Murphy [Mon, 29 Oct 2018 17:03:11 +0000 (17:03 +0000)]
[FLTMGR] Add a bit more basic code layout for filter registration
Needs implementing

13 months ago[FLTMGR] Remove duplicated export
Pierre Schweitzer [Mon, 29 Oct 2018 16:28:01 +0000 (17:28 +0100)]
[FLTMGR] Remove duplicated export

13 months ago[FLTMGR] Callers must have registered an unload routine to be allowed to unload
Ged Murphy [Mon, 29 Oct 2018 11:28:10 +0000 (11:28 +0000)]
[FLTMGR] Callers must have registered an unload routine to be allowed to unload