reactos.git
20 months ago[PrintUI|NTPrint] Printing Application Utility Support
James Tabor [Wed, 13 May 2020 01:26:02 +0000 (20:26 -0500)]
[PrintUI|NTPrint] Printing Application Utility Support

PrintUI : Move to printing base directory.
NTPrint : Import from wine.

NTPrint does have a API test program from wine, not imported at this
time.

These will be Sync/Ported to full forked.

20 months ago[MSAFD] Workaround regression CORE-15804
Joachim Henze [Wed, 13 May 2020 00:39:37 +0000 (02:39 +0200)]
[MSAFD] Workaround regression CORE-15804

To fix 'MSTSC fails to connect with error "ERROR: Bad packet header"'
which regressed by 0.4.12-dev-752-g
6bc61f63f1e0ad20ab09f881d6968558eba9a8e6

In 0.4.12 and 0.4.13 releases I totally reverted
Pierre Schweitzer's work instead.

Thanks to Doug Lyons, author of this new workaround,
we can keep Pierre's work.
We think MSAFD is a better place to workaround than
our MSTSC binary, because our MSTSC runs fine on
W2K3SP2.

I will backport this new workaround also into 0.4.14RC.

20 months ago[UNIATA] Workaround regression CORE-16078, booting broke on specific Intel Z170
Joachim Henze [Sun, 2 Jun 2019 12:23:18 +0000 (14:23 +0200)]
[UNIATA] Workaround regression CORE-16078, booting broke on specific Intel Z170

JIRA-user "Illen" reported booting from his Z170 controller worked up to
0.4.12-dev-936-g89aaf0e
and would refuse booting - beginning with uniata commit
0.4.12-dev-937-g
b54613073127f5204660d9e9ab86159fea06b23e

For sure this workaround is just a temporary and no proper solution,
but was confirmed to be working by "Illen".
We have no clear understanding of the real bug yet.
Can be replaced by something better at any time.
It was already committed into 0.4.12, 0.4.13, 0.4.14.
We never had an affected release therefore.

Since no one took care of this bug ever,
the workaround will now be committed to master as well.

cherry picked from commit 0.4.13-RC-9-g
11178f38e407a8d3621668295c2a28cd1ed9d7d1

20 months ago[NTOSKRNL][HAL][BOOTVID] Some more code refactoring bootvid_refactor 2763/head
Stanislav Motylkov [Sat, 9 May 2020 14:20:57 +0000 (17:20 +0300)]
[NTOSKRNL][HAL][BOOTVID] Some more code refactoring

- Add boot video color constants
- Refactor palette initialization
- Move some common stuff in right place
- Get rid of some magic constants and hardcoded values
- Get rid of TopDelta variable (calculated at compile time)
- Update SAL annotations

Addendum to 5f2ca473. CORE-16216 CORE-16219

20 months ago[FONTVIEW] Ensure the extension filter is properly double-null terminated
Mark Jansen [Mon, 11 May 2020 18:52:30 +0000 (20:52 +0200)]
[FONTVIEW] Ensure the extension filter is properly double-null terminated

20 months ago[BROWSEUI] PL-pl update
Piotr Hetnarowicz [Mon, 11 May 2020 07:06:33 +0000 (09:06 +0200)]
[BROWSEUI] PL-pl update

browseui.dll - PL-pl translation update :)

20 months ago[MAIN.CPL] PL-pl update
Piotr Hetnarowicz [Mon, 11 May 2020 08:01:17 +0000 (10:01 +0200)]
[MAIN.CPL] PL-pl update

MAIN.CPL - PL-pl
-dialogs fix
-strings update

20 months ago[INTL.CPL] PL-pl update
Piotr Hetnarowicz [Mon, 11 May 2020 08:41:12 +0000 (10:41 +0200)]
[INTL.CPL] PL-pl update

intl.cpl - PL-pl update
-dialogs fix
-strings update

20 months ago[WIN32SS] Fix DrawTextExWorker extent for Spotify (#2759)
Katayama Hirofumi MZ [Mon, 11 May 2020 09:32:47 +0000 (18:32 +0900)]
[WIN32SS] Fix DrawTextExWorker extent for Spotify (#2759)

CORE-16747

20 months ago[SHELL32] Don't hardcode C: drive (#2768)
Katayama Hirofumi MZ [Mon, 11 May 2020 02:43:07 +0000 (11:43 +0900)]
[SHELL32] Don't hardcode C: drive (#2768)

CORE-13235

20 months ago[CMD] Quick fix for the REM command parser. CORE-17030
Hermès Bélusca-Maïto [Mon, 11 May 2020 02:22:58 +0000 (04:22 +0200)]
[CMD] Quick fix for the REM command parser. CORE-17030

20 months ago[UMPNPMGR] Implement PNP_GetFirstLogConf and PNP_GetNextLogConf (WIP)
Eric Kohl [Sun, 10 May 2020 18:45:11 +0000 (20:45 +0200)]
[UMPNPMGR] Implement PNP_GetFirstLogConf and PNP_GetNextLogConf (WIP)

- PNP_GetFirstLogConf only works for resources lists.
- PNP_GetNextLogConf does not return a valid tag yet.

20 months ago[FREELDR] Add vertical screen scrolling for Xbox with console mode (#2745)
Dmitry Borisov [Sun, 10 May 2020 16:35:51 +0000 (22:35 +0600)]
[FREELDR] Add vertical screen scrolling for Xbox with console mode (#2745)

Also turn off debug messages to screen before setting up the CPU (To print a character to the screen on some ports the MMIO access should be executed, so it throws an exception).

CORE-16216

20 months ago[SNDREC32] French translation update (#2761)
Kyle Katarn [Sun, 10 May 2020 16:22:13 +0000 (18:22 +0200)]
[SNDREC32] French translation update (#2761)

And add/fix colliding keyboard accelerators.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
20 months ago[ARP] Print a message when there is no relevant entry to be shown
Eric Kohl [Sun, 10 May 2020 07:04:50 +0000 (09:04 +0200)]
[ARP] Print a message when there is no relevant entry to be shown

20 months ago[WINNLS] Fix of GetCurrencyFormatW to handle "32" grouping format (#2719)
Kyle Katarn [Sun, 10 May 2020 06:34:35 +0000 (08:34 +0200)]
[WINNLS] Fix of GetCurrencyFormatW to handle "32" grouping format (#2719)

20 months ago[ARP] Coding style fixes only
Eric Kohl [Sun, 10 May 2020 06:24:10 +0000 (08:24 +0200)]
[ARP] Coding style fixes only

20 months ago[ARP] Improvements to ARP
Eric Kohl [Sat, 9 May 2020 22:46:42 +0000 (00:46 +0200)]
[ARP] Improvements to ARP

- Print message on failed memory allocations.
- Functions return error code instead of exit code.
- Convert error code to exit code in the main function only.
- Always free the allocated memory.
- Fix bug from previous commit: Use _tprintf instead _putts to print messages.

20 months ago[ISAPNP] Mark Read Data Port as not having a unique ID
Hervé Poussineau [Sat, 9 May 2020 14:53:00 +0000 (16:53 +0200)]
[ISAPNP] Mark Read Data Port as not having a unique ID

This fixes a bugcheck in ntoskrnl.exe when computer has multiple ISA buses.

CORE-17034

20 months ago[SHELL32] Return ERROR_INVALID_DRIVE if the drive type is unknown or there is no...
Charles Ambrye [Sat, 9 May 2020 12:54:15 +0000 (05:54 -0700)]
[SHELL32] Return ERROR_INVALID_DRIVE if the drive type is unknown or there is no volume mounted (#2703)

Return ERROR_INVALID_DRIVE if the drive is either unknown or unmounted.

20 months ago[COMDLG32] Add some more places to the places bar in the open file dialog. (#2732)
Jared Smudde [Sat, 9 May 2020 12:50:20 +0000 (07:50 -0500)]
[COMDLG32] Add some more places to the places bar in the open file dialog. (#2732)

Add Recent Documents and My Network Places to the places bar in the open file dialog.

NOTE: Technically this "places bar" can be customized:
https://www.tenforums.com/tutorials/126153-change-places-bar-items-common-dialog-box-windows.html
https://www.sevenforums.com/tutorials/85487-common-file-dialog-box-customize-places-bar.html

20 months agoFix of comdlg32 Treeview undue handling of WM_SYSKEYDOWN (#2731)
Kyle Katarn [Sat, 9 May 2020 12:37:26 +0000 (14:37 +0200)]
Fix of comdlg32 Treeview undue handling of WM_SYSKEYDOWN (#2731)

Remove WM_SYSKEYDOWN handling at component level, in consistency with other components (ListView,...)
Early embodiement of the fix proposed to WineHQ : https://bugs.winehq.org/show_bug.cgi?id=49097 in order to remove functionnal limitation in ReactOS. CORE-17020

20 months ago[SNDREC32] Fix incorrect opaque text rendering (#2760)
Kyle Katarn [Sat, 9 May 2020 12:09:58 +0000 (14:09 +0200)]
[SNDREC32] Fix incorrect opaque text rendering (#2760)

Remove "Opaque" parameter so that the transparency can be correctly used.

20 months ago[ARP] Replace some hard-coded strings by message resources
Eric Kohl [Sat, 9 May 2020 10:28:40 +0000 (12:28 +0200)]
[ARP] Replace some hard-coded strings by message resources

20 months ago[RTLVER] Add missing bugcodes dependency.
Thomas Faber [Sat, 9 May 2020 09:11:49 +0000 (11:11 +0200)]
[RTLVER] Add missing bugcodes dependency.

20 months ago[RSAENH][MSXML3][OLE32] Revert PRIVATE commits (cbe8a9f and 38b438b)
Katayama Hirofumi MZ [Sat, 9 May 2020 08:55:37 +0000 (17:55 +0900)]
[RSAENH][MSXML3][OLE32] Revert PRIVATE commits (cbe8a9f and 38b438b)

20 months ago[MSXML3][OLE32] DllGetClassObject should be PRIVATE
Katayama Hirofumi MZ [Sat, 9 May 2020 08:02:08 +0000 (17:02 +0900)]
[MSXML3][OLE32] DllGetClassObject should be PRIVATE

20 months ago[RSAENH] DllRegisterServer should be PRIVATE
Katayama Hirofumi MZ [Sat, 9 May 2020 07:59:59 +0000 (16:59 +0900)]
[RSAENH] DllRegisterServer should be PRIVATE

20 months agoRevert "Revert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753)"...
Katayama Hirofumi MZ [Sat, 9 May 2020 06:32:15 +0000 (15:32 +0900)]
Revert "Revert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753)" (#2758)

This reverts commit 66b0a48a75d41fbc047d63df9b561e2c80626376.

20 months agoRevert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753)
Katayama Hirofumi MZ [Sat, 9 May 2020 02:30:11 +0000 (11:30 +0900)]
Revert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753)

This reverts commit 2d4d3f5fce0c875d3e714c51de16dfb0cd0a9cd3.

Reverts #2146. I think #2135 (e329e83) and #2146 (2d4d3f5) are my mistakes.
CORE-16552, CORE-16747

20 months ago[FREELDR] Fix some more register accesses and magic values
Stanislav Motylkov [Fri, 8 May 2020 20:02:42 +0000 (23:02 +0300)]
[FREELDR] Fix some more register accesses and magic values

Addendum to 764e884.

20 months ago[ISAPNP] Enable driver
Hervé Poussineau [Fri, 8 May 2020 18:00:58 +0000 (20:00 +0200)]
[ISAPNP] Enable driver

20 months ago[UTILMAN] Use the ShellAboutW API routine to display the about dialog (#2743)
George Bișoc [Thu, 7 May 2020 11:01:36 +0000 (13:01 +0200)]
[UTILMAN] Use the ShellAboutW API routine to display the about dialog (#2743)

In addition to that, add the missing function prototypes in the DLL dialog header of Utilman, add missing IN/OUT annotations and remove CheckUtilityState() prototype which is barely used (it's not implemented either).

20 months ago[APISETS] api-ms-win-core-winrt-l1-1-0: Ro*() are NT8+ (#2739)
Serge Gautherie [Thu, 7 May 2020 11:00:10 +0000 (13:00 +0200)]
[APISETS] api-ms-win-core-winrt-l1-1-0: Ro*() are NT8+ (#2739)

(Supersedes PR #2374.)
CORE-16707

20 months ago[SYSDM][DESK] Fix GetDC/ReleaseDC error management (#2707)
Kyle Katarn [Thu, 7 May 2020 10:57:46 +0000 (12:57 +0200)]
[SYSDM][DESK] Fix GetDC/ReleaseDC error management (#2707)

## Purpose
[SYSDM]
- When closing System Properties page, log show
(win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()!
because GetDC() is called (multiple times) without properly calling ReleaseDC() as required in order to release a device context.
- This module also lacks some error management in case null DC are provided (on error).
- LiveCD Userinit, based on SYSDM is affected too.

[DESK]
- Fix missing ReleaseDC related to the spectrum (color depth)

## Proposed changes
- ReleaseDC() added.
- Error management in case of null DC.
- Overall alignement of LiveCD Userinit and SYSDM.

20 months ago[CREDITS] Add myself to the credits document (#2747)
George Bișoc [Thu, 7 May 2020 10:39:44 +0000 (12:39 +0200)]
[CREDITS] Add myself to the credits document (#2747)

20 months ago[RAPPS] 64bit compatibility fix (#2748)
He Yang [Thu, 7 May 2020 09:08:08 +0000 (17:08 +0800)]
[RAPPS] 64bit compatibility fix (#2748)

Change SetWindowLongW to SetWindowLongPtrW.

It's the same (because the value is 0) but I think it's better.

20 months ago[PCIIDEX] Increase command port length to 8 from 7. CORE-9922 (#2711)
Serge Gautherie [Thu, 7 May 2020 07:16:18 +0000 (09:16 +0200)]
[PCIIDEX] Increase command port length to 8 from 7. CORE-9922 (#2711)

Co-Authored-By: Vadim Galyant <vgal@rambler.ru>
20 months ago[FREELDR] Workaround regression CORE-16469
Joachim Henze [Wed, 6 May 2020 21:44:50 +0000 (23:44 +0200)]
[FREELDR] Workaround regression CORE-16469

This prevents ReactOS asserting when 'My computer'
is opened, while it tries to send commands to floppy drive.

Many thanks to patches author Doug Lyons.

The regression was introduced by 0.4.13-dev-1081-g
eeff926ede1b2109bb0e129a960b74f3261cf2f1

patch was committed to 0.4.13rls and 0.4.14rls as well.

Today it was committed to master as well, as
the initially planned investigation for the root cause
did still not happen and we can not afford the time
to retest and workaround this over and over again.
Thank god that Oleg Dubinskiy was still around to retest
this again and confirmed it can still happen, because
unlike initially, personally I was not able to reproduce it
today anymore!

Since every release was work-arounded, we did never
expose the bug in any final release.

20 months ago[README] "Building ReactOS" belongs to "Building" part (#2741)
Alexander Rechitskiy [Wed, 6 May 2020 11:14:41 +0000 (14:14 +0300)]
[README] "Building ReactOS" belongs to "Building" part (#2741)

- Improved logic of the text
- Removed some line breaks to improve readability on some screen sizes

20 months ago[README] Update RosBE links and badges to version 2.2.0 (#2742)
Alexander Rechitskiy [Wed, 6 May 2020 11:02:30 +0000 (14:02 +0300)]
[README] Update RosBE links and badges to version 2.2.0 (#2742)

https://reactos.org/project-news/rosbe-22-released/

20 months ago[USERINIT] Add unattend.inf functionality to livecd 2727/head
Mark Jansen [Sun, 3 May 2020 18:18:30 +0000 (20:18 +0200)]
[USERINIT] Add unattend.inf functionality to livecd

20 months ago[SHELL32] Distinguish floppy and removable drives (#2645)
Katayama Hirofumi MZ [Tue, 5 May 2020 15:35:01 +0000 (00:35 +0900)]
[SHELL32] Distinguish floppy and removable drives (#2645)

Distinguish floppy drive and non-floppy removable drive in icon and description. CORE-10221

20 months ago[REGEDIT] Fix HeapFree() on the wrong variable (#2736)
Kyle Katarn [Tue, 5 May 2020 08:44:45 +0000 (10:44 +0200)]
[REGEDIT] Fix HeapFree() on the wrong variable (#2736)

- When exporting registry keys (to .reg files) some variables from the heap are not free'd while the debug log indicates "HEAP: Trying to free an invalid address".
- This is due to the export_registry_key() function that calls
HeapFree() for reg_key_name. But this variable is an argument provided by the caller, which is always a statically defined array of WCHAR.
- Meanwhile reg_key_name_buf is never free'd and cause a memory leak each time the function gets called.

20 months ago[ADVAPI32] Remove now-redundant comment (#2735)
Serge Gautherie [Tue, 5 May 2020 08:37:09 +0000 (10:37 +0200)]
[ADVAPI32] Remove now-redundant comment (#2735)

Addendum to 5dfe345.

20 months ago[ADVAPI32] Fix undue debug print in nominal case (#2734)
Kyle Katarn [Mon, 4 May 2020 20:30:36 +0000 (22:30 +0200)]
[ADVAPI32] Fix undue debug print in nominal case (#2734)

In current implementation, when regedit opens HKCR root key, an error is logged
err:(dll/win32/advapi32/reg/hkcr.c:964) Returning 259.
This is not correct as the code 259 is ERROR_NO_MORE_ITEMS which is the nominal return value when end of enumeration is reached.

20 months ago[APISETS] *_seh_filter_*() are NT6+ (#2729)
Serge Gautherie [Mon, 4 May 2020 20:26:38 +0000 (22:26 +0200)]
[APISETS] *_seh_filter_*() are NT6+ (#2729)

Addendum to 65fd292. CORE-16700

20 months ago[NETID] Update Polish translation (#2709)
Adam Stachowicz [Mon, 4 May 2020 20:20:04 +0000 (22:20 +0200)]
[NETID] Update Polish translation (#2709)

Addendum to c276681.

20 months ago[REACTOS] Drop support for Visual Studio below 2015 2658/head
Victor Perevertkin [Sat, 25 Apr 2020 00:14:44 +0000 (03:14 +0300)]
[REACTOS] Drop support for Visual Studio below 2015

20 months ago[REACTOS] Raise C standard to gnu99
Victor Perevertkin [Sat, 25 Apr 2020 00:10:27 +0000 (03:10 +0300)]
[REACTOS] Raise C standard to gnu99
And remove -Wdeclaration-after-statement

20 months ago[GITHUB][TRAVIS][APPVEYOR] Move all CI to GitHub Actions 2688/head
Victor Perevertkin [Wed, 29 Apr 2020 09:07:50 +0000 (12:07 +0300)]
[GITHUB][TRAVIS][APPVEYOR] Move all CI to GitHub Actions

20 months ago[HTTPAPI] Convert httpapi.dll to a stub-only library
Victor Perevertkin [Mon, 4 May 2020 08:33:57 +0000 (11:33 +0300)]
[HTTPAPI] Convert httpapi.dll to a stub-only library
Wine's implementation relies on http.sys driver, which we don't have
anyway. Function declarations are taken from Wine 5.7

CORE-16963

20 months ago[SHELL32] Follow-up 2 of #2659
Katayama Hirofumi MZ [Mon, 4 May 2020 07:22:38 +0000 (16:22 +0900)]
[SHELL32] Follow-up 2 of #2659

Add TODO comments.
Make CreateAPCThread static.
CORE-13950

20 months ago[SHELL32] Follow-up of #2659
Katayama Hirofumi MZ [Mon, 4 May 2020 06:28:16 +0000 (15:28 +0900)]
[SHELL32] Follow-up of #2659

Add CreateAPCThread function and use it. CORE-13950

20 months ago[SHELL32] Notify filesystem changes (#2659)
Katayama Hirofumi MZ [Mon, 4 May 2020 05:53:23 +0000 (14:53 +0900)]
[SHELL32] Notify filesystem changes (#2659)

Notify filesystem change notifications by using ReadDirectoryChangesW function. Creating/Deleting files/folders will be responsive in Explorer. CORE-13950

20 months ago[SHELL32] Set the Run dialog to use the newer style browse for file dialog. (#2728)
Jared Smudde [Mon, 4 May 2020 03:53:35 +0000 (22:53 -0500)]
[SHELL32] Set the Run dialog to use the newer style browse for file dialog. (#2728)

Apply the OFN_EXPLORER flag to the Run dialog so the dialog uses the newer style browse dialog.

20 months ago[RAPPS] Fix the locale fix
Mark Jansen [Sun, 3 May 2020 18:33:23 +0000 (20:33 +0200)]
[RAPPS] Fix the locale fix

20 months ago[RAPPS] Fix locale fallback code
Mark Jansen [Sun, 3 May 2020 16:33:06 +0000 (18:33 +0200)]
[RAPPS] Fix locale fallback code

20 months ago[SDK][STDLIB][STRING] Wine-sync wcsrtombs_l and _mbstowcs_l
Bișoc George [Fri, 1 May 2020 16:36:19 +0000 (18:36 +0200)]
[SDK][STDLIB][STRING] Wine-sync wcsrtombs_l and _mbstowcs_l

This is a partial sync of the CRT library with wcsrtombs_l and _mbstowcs_l functions from WINE. The _wctomb_s_l implementation of WINE which is used by _wctomb_s, _wctomb_l and wctomb brings failed results of the wctomb unit testcase and at the same time it crashes the whole testcase after.

Therefore I will not address the wctomb function for the moment being.

20 months ago[WELCOME] pl-pl update (#2717)
Piotr Hetnarowicz [Sun, 3 May 2020 13:30:04 +0000 (15:30 +0200)]
[WELCOME] pl-pl update (#2717)

welcome.exe pl-pl update

20 months ago[SYSDM] Fix the missing TABSTOP style on Startup and Recovery dialog (#2722)
Kyle Katarn [Sun, 3 May 2020 10:16:45 +0000 (12:16 +0200)]
[SYSDM] Fix the missing TABSTOP style on Startup and Recovery dialog (#2722)

Now the OS choice and the debug info selection combo-boxes can be selected via keyboard navigation.

20 months ago[XBOXVMP] Work with Xbox GPU registers properly
Stanislav Motylkov [Sat, 2 May 2020 20:18:34 +0000 (23:18 +0300)]
[XBOXVMP] Work with Xbox GPU registers properly

Bug was noticed with GCC 8.4

20 months ago[FREELDR] Work with Xbox GPU memory registers properly
Stanislav Motylkov [Sat, 2 May 2020 20:16:58 +0000 (23:16 +0300)]
[FREELDR] Work with Xbox GPU memory registers properly

Bug was noticed with GCC 8.4

20 months ago[RAPPS] Polish translation
Adam Stachowicz [Sat, 2 May 2020 09:39:13 +0000 (09:39 +0000)]
[RAPPS] Polish translation

After https://github.com/reactos/reactos/commit/fb1582d330116f9946e235d99b5384dd76b6fa79

20 months ago[SNDVOL32] Fix GetDC/ReleaseDC error management (#2713)
Kyle Katarn [Sat, 2 May 2020 09:43:30 +0000 (11:43 +0200)]
[SNDVOL32] Fix GetDC/ReleaseDC error management (#2713)

GetDC() is called without properly calling ReleaseDC() as required in order to releases a device context. Similar to #2707

20 months ago[KERNEL32_APITEST] s/QueryUserAPC/QueueUseAPC/
Katayama Hirofumi MZ [Sat, 2 May 2020 05:58:48 +0000 (14:58 +0900)]
[KERNEL32_APITEST] s/QueryUserAPC/QueueUseAPC/

20 months ago[RAPPS] Add error messages on all download failure cases
Kyle Katarn [Fri, 1 May 2020 21:52:57 +0000 (23:52 +0200)]
[RAPPS] Add error messages on all download failure cases

- Implement error message for all failure condition of RAPPS Download
- Implement logging for failure conditions not needing user complementary awareness (cancellation)
- Support for localization
CORE-16851

20 months ago[NETID] Disable the 'Network ID' and 'Change' buttons and show the admin note when...
Eric Kohl [Fri, 1 May 2020 20:34:01 +0000 (22:34 +0200)]
[NETID] Disable the 'Network ID' and 'Change' buttons and show the admin note when the current user is not an administrator

20 months ago[NETID] Fix a typo in NetworkDlg_OnOK
Eric Kohl [Fri, 1 May 2020 20:00:32 +0000 (22:00 +0200)]
[NETID] Fix a typo in NetworkDlg_OnOK

20 months ago[NETID] Fix the left margin on the Computer Name dialog
Eric Kohl [Fri, 1 May 2020 18:00:12 +0000 (20:00 +0200)]
[NETID] Fix the left margin on the Computer Name dialog

20 months ago[NETID] Improve the 'Computer name' property page
Eric Kohl [Fri, 1 May 2020 17:40:15 +0000 (19:40 +0200)]
[NETID] Improve the 'Computer name' property page

- Check for changes of the host and domain name.
- Use NetGetJoinInformation to retrieve the join status.
- Implement the SyncDomainWithMembership setting.
- Disable the administrator warning temporarily.

20 months ago[SERVMAN] UI update and Error Management (#2653)
Kyle Katarn [Fri, 1 May 2020 17:01:59 +0000 (19:01 +0200)]
[SERVMAN] UI update and Error Management (#2653)

Purpose
=======
- Current design does not warn user nor logs DEBUG traces when Service Start/Stop command fails or reach timeout.
- Current Service Start/Stop progress window are WS_EX_TOOLWINDOW which reduce lisibility, is a ReactOS specificity without good reason.

Proposed changes
================
- DPRINT1 traces added on failure cases.
- Error Message box presented to user upon failure with explicit root cause identification.
- Change Dialog definition to standard window.

20 months ago[KDGDB] Fix GCC8 build
Sylvain Deverre [Fri, 1 May 2020 14:37:13 +0000 (16:37 +0200)]
[KDGDB] Fix GCC8 build

20 months ago[CRT_APITEST] Implement wctomb() testcase (#2701)
Bișoc George [Fri, 1 May 2020 14:01:11 +0000 (16:01 +0200)]
[CRT_APITEST] Implement wctomb() testcase (#2701)

20 months ago[WIN32SS][NTDDRAW] Get complexity of visible region in DxEngGetDCState (#2604)
Oleg Dubinskiy [Fri, 1 May 2020 13:57:11 +0000 (16:57 +0300)]
[WIN32SS][NTDDRAW] Get complexity of visible region in DxEngGetDCState (#2604)

CORE-7733

Get the complexity of visible region in the DxEngGetDCState() function, according to its remarks.
This implementation returns a number of rectangles that make up the region, similarly to as it done in REGION_Complexity() function:
https://git.reactos.org/?p=reactos.git;a=blob;f=win32ss/gdi/ntgdi/region.c;h=38bf3d377fa805e9db8768774c4fc473590252d0;hb=HEAD#l573
It is required by MS ddraw.dll when calling win32k/dxg functions during launching DirectDraw test or any DirectX 1 - 7 apps/games.

20 months ago[OLE32][WINESYNC] Fix Wine's implementation of IMalloc.DidAlloc based from Wine 5...
Kyle Katarn [Fri, 1 May 2020 13:01:19 +0000 (15:01 +0200)]
[OLE32][WINESYNC] Fix Wine's implementation of IMalloc.DidAlloc based from Wine 5.7 (#2662)

CORE-15262

This fixes the exceptions raised when calling "Scan folder" a second time in SUMo 5.10.16.
The problem was reported to WineHQ : https://bugs.winehq.org/show_bug.cgi?id=48941

Import Wine commits by Nikolay Sivov, with the help of Doug Lyons:
- https://source.winehq.org/git/wine.git/commit/08f4b6ee0a05fe27e56cb9777dce845dcf1072f8
  ole32: Fix IMalloc::DidAlloc() return value to reflect block validity.
- https://source.winehq.org/git/wine.git/commit/1e3bc9f3a61a197e794cca07a59c9497b237af62
  ole32: Improve thread safety in DidAlloc().
- https://source.winehq.org/git/wine.git/commit/06d36b1adf1ae7b73a200d6a35a143f6b3fd91c9
  ole32: Fix spy callback arguments for IMalloc::GetSize().

20 months ago[SYSDM] Virtual Memory panel : Complementary fix from PR #2597 (#2706)
Kyle Katarn [Fri, 1 May 2020 12:47:04 +0000 (14:47 +0200)]
[SYSDM] Virtual Memory panel : Complementary fix from PR #2597 (#2706)

Fix all lang resources in order to reflect main changes from PR #2597 (16MB>2MB).
To translators: Please sync the respective translations!

CORE-12486

20 months ago[SYSSETUP] Improve SetupQueryRegisteredOsComponent export (#2702)
Oleg Dubinskiy [Fri, 1 May 2020 10:45:19 +0000 (13:45 +0300)]
[SYSSETUP] Improve SetupQueryRegisteredOsComponent export (#2702)

CORE-16784

Co-authored-by: Mark Jansen <mark.jansen@reactos.org>
20 months ago[ACPICA] Update to version 20190430. CORE-16998
Thomas Faber [Fri, 1 May 2020 10:18:11 +0000 (12:18 +0200)]
[ACPICA] Update to version 20190430. CORE-16998

20 months ago[USBCCGP] Ignore IRP_MN_REMOVE_DEVICE return status and don't wait for it to complete. 2540/head
Thomas Faber [Fri, 8 Mar 2019 14:49:22 +0000 (15:49 +0100)]
[USBCCGP] Ignore IRP_MN_REMOVE_DEVICE return status and don't wait for it to complete.

20 months ago[USBCCGP] Don't handle IRP_MN_QUERY_DEVICE_TEXT requests other than device description.
Thomas Faber [Wed, 6 Mar 2019 13:58:46 +0000 (14:58 +0100)]
[USBCCGP] Don't handle IRP_MN_QUERY_DEVICE_TEXT requests other than device description.

20 months ago[USBCCGP] Correctly stub PDO power IRP handling.
Thomas Faber [Wed, 6 Mar 2019 13:57:58 +0000 (14:57 +0100)]
[USBCCGP] Correctly stub PDO power IRP handling.

20 months ago[USBCCGP] Always forward device relations IRPs.
Thomas Faber [Wed, 6 Mar 2019 13:57:01 +0000 (14:57 +0100)]
[USBCCGP] Always forward device relations IRPs.

20 months ago[NET][MC] Replace the last string resource by a message from netmsg.dll.
Eric Kohl [Fri, 1 May 2020 07:40:37 +0000 (09:40 +0200)]
[NET][MC] Replace the last string resource by a message from netmsg.dll.

- Move translations to netmsg.dll.
- Keep italian translation as a comment because netmsg.dll does not have an italian translation yet.
- Remove obsolete resource files.

20 months ago[SHELL32] Delete IDM_RECENTMENUHEAD resource menu (#2705)
Katayama Hirofumi MZ [Fri, 1 May 2020 06:58:58 +0000 (15:58 +0900)]
[SHELL32] Delete IDM_RECENTMENUHEAD resource menu (#2705)

Follow-up of #2648. Reduce translation cost and resource data.
CORE-3588, CORE-11483

20 months ago[CPL][HOTPLUG] Add Japanese translation
Katayama Hirofumi MZ [Fri, 1 May 2020 01:52:19 +0000 (10:52 +0900)]
[CPL][HOTPLUG] Add Japanese translation

20 months ago[TIMEDATA] Improve Japanese translation
Katayama Hirofumi MZ [Fri, 1 May 2020 01:37:46 +0000 (10:37 +0900)]
[TIMEDATA] Improve Japanese translation

20 months ago[UTILMAN] Add Japanese translation
Katayama Hirofumi MZ [Fri, 1 May 2020 01:34:36 +0000 (10:34 +0900)]
[UTILMAN] Add Japanese translation

20 months ago[CMDUTILS][LABEL] Improve Japanese translation
Katayama Hirofumi MZ [Fri, 1 May 2020 01:31:11 +0000 (10:31 +0900)]
[CMDUTILS][LABEL] Improve Japanese translation

20 months ago[MYDOCS] Add Japanese translation
Katayama Hirofumi MZ [Fri, 1 May 2020 01:25:47 +0000 (10:25 +0900)]
[MYDOCS] Add Japanese translation

20 months ago[CMAKE] Support file lists in add_cd_file for all cases
Victor Perevertkin [Thu, 30 Apr 2020 23:39:59 +0000 (02:39 +0300)]
[CMAKE] Support file lists in add_cd_file for all cases
Addendum to 6b48d54

20 months ago[CMAKE] Fix driver inf files generation for livecd
Victor Perevertkin [Thu, 30 Apr 2020 22:23:51 +0000 (01:23 +0300)]
[CMAKE] Fix driver inf files generation for livecd
CORE-16975

20 months ago[ERRCODES.MC] Change some occurrences of "Windows" to "ReactOS" where it makes the...
Hermès Bélusca-Maïto [Thu, 30 Apr 2020 22:05:25 +0000 (00:05 +0200)]
[ERRCODES.MC] Change some occurrences of "Windows" to "ReactOS" where it makes the most sense.

20 months ago[ERRCODES.MC] Remove the "ERROR_xxxx - " prefixes from each error message.
Hermès Bélusca-Maïto [Thu, 30 Apr 2020 21:54:12 +0000 (23:54 +0200)]
[ERRCODES.MC] Remove the "ERROR_xxxx - " prefixes from each error message.

20 months ago[SHELL32] Fix "Open With..." spamming registry MRU keys. (#2685)
Kyle Katarn [Thu, 30 Apr 2020 21:03:10 +0000 (23:03 +0200)]
[SHELL32] Fix "Open With..." spamming registry MRU keys. (#2685)

CORE-16981

The problem:
============

- When opening "Open With..." dialog for a given file format, multiple MRU items are appended to registry : 2 items written, even if dialog is closed "cancel".
- Expected behavior : 1 MRU item if execute is selected and 0 MRU if cancel is selected.

Fix:
====

- MRU item to be added when "Execute" is selected only.
- Once added, set the presence flag to avoid multiple MRU items being added later.

20 months ago[ZIPFLDR_APITEST] Add test enumerating over zip folder's parent 2630/head
Mark Jansen [Wed, 22 Apr 2020 18:47:00 +0000 (20:47 +0200)]
[ZIPFLDR_APITEST] Add test enumerating over zip folder's parent
Disable tests for unimplemented features

20 months ago[ZIPFLDR] Set correct access time on file extraction
Mark Jansen [Sun, 5 Jan 2020 01:25:05 +0000 (02:25 +0100)]
[ZIPFLDR] Set correct access time on file extraction

20 months ago[ATL] Add CAtlArray::GetData
Mark Jansen [Mon, 20 Jan 2020 19:10:40 +0000 (20:10 +0100)]
[ATL] Add CAtlArray::GetData

20 months ago[ZIPFLDR_APITEST] Add some basic IDataObject tests
Mark Jansen [Sat, 4 Jan 2020 16:49:02 +0000 (17:49 +0100)]
[ZIPFLDR_APITEST] Add some basic IDataObject tests
CORE-16241

20 months ago[SHELLEXT] Fixed some typos in Portuguese translation
Jose Carlos Jesus [Wed, 29 Apr 2020 18:55:30 +0000 (19:55 +0100)]
[SHELLEXT] Fixed some typos in Portuguese translation