2 years ago[REG] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Sun, 27 May 2018 02:48:33 +0000 (03:48 +0100)]
[REG] Sync with Wine Staging 3.9. CORE-14656

2 years ago[USETUP] Similarly to what was done for GenLists, factor out the UI code from the...
Hermès Bélusca-Maïto [Mon, 15 May 2017 19:41:18 +0000 (19:41 +0000)]
[USETUP] Similarly to what was done for GenLists, factor out the UI code from the partition list code.

This will allow to reuse it for the 1st-stage GUI setup too, while using another UI representation.
Add also two partition iterator functions: GetNextPartition and GetPrevPartition.

svn path=/branches/setup_improvements/; revision=74554

2 years ago[USETUP] Factor out the UI-specific code from the GenList code, and wrap it inside...
Hermès Bélusca-Maïto [Mon, 15 May 2017 16:22:18 +0000 (16:22 +0000)]
[USETUP] Factor out the UI-specific code from the GenList code, and wrap it inside a GENERIC_LIST_UI structure.

The aim here is to decouple the UI-specific code from code that can be used by both the text-mode USETUP and a future 1st-stage GUI setup.
Indeed, the GenLists can actually be used in the 1st-stage GUI; and their contents be displayed inside ListBoxes/ListViews... (this is just one example amongst others).

Additionally (in usetup.c):
- Make both FormatPartitionPage and CheckFileSystemPage return PAGE_NUMBERs.
- Improve a couple of comments.

svn path=/branches/setup_improvements/; revision=74553

2 years ago[USETUP] Additions for generic lists.
Hermès Bélusca-Maïto [Mon, 15 May 2017 01:43:28 +0000 (01:43 +0000)]
[USETUP] Additions for generic lists.

- Allow retrieving the number of items existing in the list;
- Fix the name of some function parameters.

svn path=/branches/setup_improvements/; revision=74547

2 years ago[USETUP] Additions for the PartList code.
Hermès Bélusca-Maïto [Sat, 13 May 2017 16:40:30 +0000 (16:40 +0000)]
[USETUP] Additions for the PartList code.

- Document more some of the fields in the PARTENTRY, DISKETNRY and PARTLIST structures;
- Remove the redundant members "SystemDisk", "OriginalSystemDisk" and "TempDisk" in PARTLIST as these can be consistently deduced from the corresponding (Original)(System)(Temp)Partition members
  (note that we however keep "CurrentDisk" alongside "CurrentPartition", see the comment in the code why we do it so).
- Adjust the rest of the code to take the removal of the redundant members into account. The 2nd parameter of GetNextUnformattedPartition() and GetNextUncheckedPartition() is now really optional.
- Introduce a SetPartitionType() helper to simplify the code that sets the partition type, which also automatically adjusts other internal variables of said partition in accordance.
- "Mounted" logical drives can have assigned letters too, registered in \DosDevices\.

svn path=/branches/setup_improvements/; revision=74532

2 years ago[USETUP] Code improvements for PartList.
Hermès Bélusca-Maïto [Sat, 13 May 2017 16:32:53 +0000 (16:32 +0000)]
[USETUP] Code improvements for PartList.

- Use explicit ansi string safe functions (where they are used ansi, but not explicitely);
- Add (old-school) function parameters annotations;
- Use PARTITION_ENTRY_UNUSED where needed (instead of hardcoding its value);
- Turn some functions static to this module;
- Turn the 2nd parameter of both GetNextUnformattedPartition() and GetNextUncheckedPartition() optional (for next commit);
- Improve some comments;
- Use NT types.

svn path=/branches/setup_improvements/; revision=74531

2 years ago[USETUP] Enhancements for filesystem utility functions.
Hermès Bélusca-Maïto [Sat, 13 May 2017 16:20:10 +0000 (16:20 +0000)]
[USETUP] Enhancements for filesystem utility functions.

- Introduce code that detects the filesystem of a (mounted?) partition, using NtQueryVolumeInformationFile() with FileFsAttributeInformation class,
  aka. rely on ReactOS itself (kernel, storage stack, filesystem drivers...) to recognize the FS on a partition that should normally be seen by the system.
  This currently half-works for whatever reason (to be insvestigated), while it works on Windows.
- Fix few comments & a function parameter name.
- Use NT string pointer types.

svn path=/branches/setup_improvements/; revision=74529

2 years ago[USETUP] Add & modify some file utility functions that are going to be used next.
Hermès Bélusca-Maïto [Sat, 13 May 2017 16:13:49 +0000 (16:13 +0000)]
[USETUP] Add & modify some file utility functions that are going to be used next.

- ConcatPaths that concatenates paths (or a path and a file name);
- OpenAndMapFile (resp. UnMapFile), whose purpose is to open a file and map it in memory (resp. unmap it from memory).
- Add extra optional parameters to DoesPathExist and DoesFileExist: an optional "RootDirectory" handle and, for DoesFileExist only, an optional PathName.
- Close the opened file handles only on success.

svn path=/branches/setup_improvements/; revision=74528
svn path=/branches/setup_improvements/; revision=74538
svn path=/branches/setup_improvements/; revision=74549

2 years ago[USETUP] Fix some spacings in the french translation.
Hermès Bélusca-Maïto [Wed, 17 May 2017 23:37:41 +0000 (23:37 +0000)]
[USETUP] Fix some spacings in the french translation.

svn path=/branches/setup_improvements/; revision=74574

2 years ago[USETUP] Code formatting only.
Hermès Bélusca-Maïto [Sat, 13 May 2017 16:23:08 +0000 (16:23 +0000)]
[USETUP] Code formatting only.

svn path=/branches/setup_improvements/; revision=74530

2 years ago[MSV1_0] Add logon support for the LocalService and NetworkService accounts
Eric Kohl [Sat, 26 May 2018 16:42:31 +0000 (18:42 +0200)]
[MSV1_0] Add logon support for the LocalService and NetworkService accounts

2 years ago[FASTFAT] Lock DirResource when modifying an entry on disk.
Pierre Schweitzer [Sat, 26 May 2018 15:12:03 +0000 (17:12 +0200)]
[FASTFAT] Lock DirResource when modifying an entry on disk.

Likely not optimal, but fixes some races conditions where
the directory is uninit in the middle of the write.

2 years ago[MSPAINT] When clicking selection, invalidate _and_ repaint Scroll Client _and_ Image...
Benedikt Freisen [Sat, 26 May 2018 11:23:20 +0000 (13:23 +0200)]
[MSPAINT] When clicking selection, invalidate _and_ repaint Scroll Client _and_ Image Area

Previously, the canvas disappeared when a selection was clicked until the mouse was moved.


2 years ago[MSPAINT] Store subsequent changes to file selected via Save As
Benedikt Freisen [Sat, 26 May 2018 10:36:47 +0000 (12:36 +0200)]
[MSPAINT] Store subsequent changes to file selected via Save As

Paint has erroneously been storing subsequent changes to Unnamed.bmp


2 years ago[UBTRFS] Upgrade to 1.0.2
Pierre Schweitzer [Sat, 26 May 2018 09:00:51 +0000 (11:00 +0200)]
[UBTRFS] Upgrade to 1.0.2


2 years ago[SHELLBTRFS] Upgrade to 1.0.2
Pierre Schweitzer [Sat, 26 May 2018 08:58:48 +0000 (10:58 +0200)]
[SHELLBTRFS] Upgrade to 1.0.2


2 years ago[BTRFS] Upgrade to 1.0.2
Pierre Schweitzer [Sat, 26 May 2018 08:44:36 +0000 (10:44 +0200)]
[BTRFS] Upgrade to 1.0.2


2 years ago[FASTFAT] Initialize cache if neded for changing volume label.
Pierre Schweitzer [Sat, 26 May 2018 08:12:00 +0000 (10:12 +0200)]
[FASTFAT] Initialize cache if neded for changing volume label.


2 years ago[MSGINA] Clean-up the resource IDs and the dialog function names.
Eric Kohl [Fri, 25 May 2018 23:54:58 +0000 (01:54 +0200)]
[MSGINA] Clean-up the resource IDs and the dialog function names.

2 years ago[NTOSKRNL] Implement KeQueryValuesProcess().
Pierre Schweitzer [Fri, 25 May 2018 19:40:39 +0000 (21:40 +0200)]
[NTOSKRNL] Implement KeQueryValuesProcess().

And make use of it.

2 years ago[NTOSKRNL] Make NtSetInformationJobObject() success for JobObjectExtendedLimitInformation
Pierre Schweitzer [Fri, 25 May 2018 06:46:19 +0000 (08:46 +0200)]
[NTOSKRNL] Make NtSetInformationJobObject() success for JobObjectExtendedLimitInformation

This fixes pip from Python 2.7.9 starting in ReactOS.
Though it doesn't work due to TLS issues.

2 years ago[NTOSKRNL] Define required sizes with structures sizes
Pierre Schweitzer [Fri, 25 May 2018 06:14:44 +0000 (08:14 +0200)]
[NTOSKRNL] Define required sizes with structures sizes

2 years ago[SDK] Add more types for job objects information
Pierre Schweitzer [Fri, 25 May 2018 06:14:16 +0000 (08:14 +0200)]
[SDK] Add more types for job objects information

2 years ago[NTOSKRNL] Implement NtQueryInformationJobObject().
Pierre Schweitzer [Thu, 24 May 2018 22:18:20 +0000 (00:18 +0200)]
[NTOSKRNL] Implement NtQueryInformationJobObject().

This is required by some Python2 applications
such as pip.exe

2 years ago[SDK] Add a few types for job objects information
Pierre Schweitzer [Thu, 24 May 2018 22:17:58 +0000 (00:17 +0200)]
[SDK] Add a few types for job objects information

2 years ago[MSPAINT] Fix call sequence in OnRButtonUp
Stanislav Motylkov [Thu, 24 May 2018 17:11:46 +0000 (20:11 +0300)]
[MSPAINT] Fix call sequence in OnRButtonUp

This fixes unexpected undo action when zooming out with right mouse

The call sequence in OnLButtonUp is already correct.


2 years ago[STORPORT] Enumerate attached devices
Eric Kohl [Thu, 24 May 2018 09:39:01 +0000 (11:39 +0200)]
[STORPORT] Enumerate attached devices

- Implement AcquireSpinlock, ReleaseSpinlock and GetExtendedFunctionTable notifications.
- Implement a bus scan routine, borrowed from scsiport.

Storport and storahci are now able to detect a disk device attached to a Virtual Box AHCI controller.

2 years ago[MSPAINT] Fix divide by zero in drawZoomFrame
Stanislav Motylkov [Wed, 23 May 2018 21:31:20 +0000 (00:31 +0300)]
[MSPAINT] Fix divide by zero in drawZoomFrame

CORE-14539 #resolve

2 years ago[SHELL32] Add icons to the 'File Types' listview (#557)
Katayama Hirofumi MZ [Wed, 23 May 2018 21:25:11 +0000 (06:25 +0900)]
[SHELL32] Add icons to the 'File Types' listview (#557)

This commit adds icons to the listview of the 'File Types' property sheet of Folder Options.

2 years ago[MSPAINT] Fix copy-pasta bug (#562)
Stanislav Motylkov [Wed, 23 May 2018 20:17:22 +0000 (23:17 +0300)]
[MSPAINT] Fix copy-pasta bug (#562)

This would fix setting image height via Attributes dialog and help fixing CORE-14539.

2 years ago[MSGINA] Implement the Welcome text feature
Eric Kohl [Wed, 23 May 2018 11:51:45 +0000 (13:51 +0200)]
[MSGINA] Implement the Welcome text feature

2 years ago[NTOSKRNL] Addendum to 8a8cb4d: don't print uninit pointer.
Pierre Schweitzer [Wed, 23 May 2018 06:44:43 +0000 (08:44 +0200)]
[NTOSKRNL] Addendum to 8a8cb4d: don't print uninit pointer.

2 years ago[NTOSKRNL] Only consider SharedCacheMap value once ViewLock is acquired.
Pierre Schweitzer [Wed, 23 May 2018 06:37:50 +0000 (08:37 +0200)]
[NTOSKRNL] Only consider SharedCacheMap value once ViewLock is acquired.

This avoids a really nasty race condition in our cache controler where
two concurrents could try to initialize cache on the same file.
This had two nasty effects: first shared map was purely leaked and erased
by the second one. And the private cache map, allocated on the first shared
cache map couldn't be freed and was leading to Mm BSOD (free in a middle of
a block).

This was often triggered while building ReactOS on ReactOS (with multi threads).
With that patch, I cannot crash anylonger while building ReactOS.


2 years ago[MSGINA] Clear the password on logoff
Eric Kohl [Tue, 22 May 2018 22:27:11 +0000 (00:27 +0200)]
[MSGINA] Clear the password on logoff

2 years ago[MSGIINA] Make sure we do not leak bitmaps
Eric Kohl [Tue, 22 May 2018 22:24:01 +0000 (00:24 +0200)]
[MSGIINA] Make sure we do not leak bitmaps

2 years ago[FASTFAT] Properly handle IRPs that can wait and these that cannot.
Pierre Schweitzer [Tue, 22 May 2018 19:29:10 +0000 (21:29 +0200)]
[FASTFAT] Properly handle IRPs that can wait and these that cannot.


2 years ago[MSGINA] Always stop the automatic login after the first try
Eric Kohl [Tue, 22 May 2018 19:19:58 +0000 (21:19 +0200)]
[MSGINA] Always stop the automatic login after the first try

Fixes CORE-14643

2 years ago[WINLOGON] Ignore the CTRL+SHIFT+ESC hotkey when the session is not in the logged...
Eric Kohl [Tue, 22 May 2018 16:14:42 +0000 (18:14 +0200)]
[WINLOGON] Ignore the CTRL+SHIFT+ESC hotkey when the session is not in the logged-on state

Should fix CORE-13478

2 years ago[MSGINA] Do not try to impersonate the user on shutdown when we are already logged off
Eric Kohl [Tue, 22 May 2018 15:35:33 +0000 (17:35 +0200)]
[MSGINA] Do not try to impersonate the user on shutdown when we are already logged off

2 years ago[MSGINA] Close the LSA handle on shutdown
Eric Kohl [Tue, 22 May 2018 15:31:20 +0000 (17:31 +0200)]
[MSGINA] Close the LSA handle on shutdown

2 years ago[MSGINA] Close the user token in WlxLogoff
Eric Kohl [Tue, 22 May 2018 14:32:10 +0000 (16:32 +0200)]
[MSGINA] Close the user token in WlxLogoff

2 years ago[MSGINA] Rename context variable: Domain -> DomainName
Eric Kohl [Tue, 22 May 2018 12:39:38 +0000 (14:39 +0200)]
[MSGINA] Rename context variable: Domain -> DomainName

2 years ago[WINLOGON] Prevent shell restart when the user is logged off
Eric Kohl [Tue, 22 May 2018 12:36:55 +0000 (14:36 +0200)]
[WINLOGON] Prevent shell restart when the user is logged off

2 years ago[BOOTDATA][MSGINA][SYSSETUP] Rename the DefaultDomain registry value to DefaultDomainName
Eric Kohl [Tue, 22 May 2018 09:30:27 +0000 (11:30 +0200)]
[BOOTDATA][MSGINA][SYSSETUP] Rename the DefaultDomain registry value to DefaultDomainName

2 years ago[MSGINA] Add the IgnoreShiftOverride feature again
Eric Kohl [Tue, 22 May 2018 09:06:38 +0000 (11:06 +0200)]
[MSGINA] Add the IgnoreShiftOverride feature again

2 years ago[MSGINA] Simplify the auto logon code path
Eric Kohl [Mon, 21 May 2018 14:29:02 +0000 (16:29 +0200)]
[MSGINA] Simplify the auto logon code path

- Get rid of DoAutoLogon() and the AutoLogonState variable.
- Handle the auto logon in the normal logon code path instead.
- Set bAutoAdminLogon to FALSE on a successful login. This will prevent another automatic logon after a logoff.
- The IgnoreShiftOverride feature got lost by this change but I will add it again.

2 years ago[WINLOGON] Fix build.
Pierre Schweitzer [Mon, 21 May 2018 09:33:02 +0000 (11:33 +0200)]
[WINLOGON] Fix build.

2 years ago[WINLOGON] Close all dialog boxes on SAS
Eric Kohl [Mon, 21 May 2018 09:20:50 +0000 (11:20 +0200)]
[WINLOGON] Close all dialog boxes on SAS


2 years ago[FASTFAT] Properly queue pending write IRPs.
Pierre Schweitzer [Mon, 21 May 2018 08:41:59 +0000 (10:41 +0200)]
[FASTFAT] Properly queue pending write IRPs.

Addendum to 30b836b

2 years ago[FASTFAT] When extending a file, also lock the DirResource.
Pierre Schweitzer [Mon, 21 May 2018 08:28:44 +0000 (10:28 +0200)]
[FASTFAT] When extending a file, also lock the DirResource.

This avoids race conditions under high IOs and thus corruption on
the FS, or assertions failures in the kernel.
Easily triggered by building ReactOS on ReactOS ;-).

2 years ago[SETUPAPI] Add stubs for CM_Detect_Resource_Conflict and CM_Detect_Resource_Conflict_Ex
Eric Kohl [Mon, 21 May 2018 00:30:35 +0000 (02:30 +0200)]
[SETUPAPI] Add stubs for CM_Detect_Resource_Conflict and CM_Detect_Resource_Conflict_Ex

2 years ago[CONUTILS] Remove old code; modify an informative note.
Hermès Bélusca-Maïto [Sun, 20 May 2018 20:38:48 +0000 (22:38 +0200)]
[CONUTILS] Remove old code; modify an informative note.

2 years ago[SDK] "0.4.10-dev" Starts here. 0.4.10-dev
Joachim Henze [Sun, 20 May 2018 18:35:12 +0000 (20:35 +0200)]
[SDK] "0.4.10-dev" Starts here.

tag will be added in next commit.

2 years ago[CMD] Use string-safe call to build the new console title (possibly truncated, we...
Hermès Bélusca-Maïto [Sun, 20 May 2018 17:57:43 +0000 (19:57 +0200)]
[CMD] Use string-safe call to build the new console title (possibly truncated, we don't care), avoiding any buffer overflow. Caught by David Quintana.

2 years ago[USETUP] Remove now-unneeded file.
Hermès Bélusca-Maïto [Sun, 20 May 2018 17:27:57 +0000 (19:27 +0200)]
[USETUP] Remove now-unneeded file.

2 years ago[BOOTDATA] Set the 'BootExecute' SMSS value to an empty value as we do not want AutoC...
Hermès Bélusca-Maïto [Sun, 20 May 2018 16:32:59 +0000 (18:32 +0200)]
[BOOTDATA] Set the 'BootExecute' SMSS value to an empty value as we do not want AutoChk to start when booting the LiveCD. CORE-14633
Add also a missing closing quote.

2 years ago[SETUPAPI] Fix MSVC build; pathetic GCC/LD didn't see we were using two different...
Hermès Bélusca-Maïto [Sun, 20 May 2018 13:31:45 +0000 (15:31 +0200)]
[SETUPAPI] Fix MSVC build; pathetic GCC/LD didn't see we were using two different prototypes for these functions.

2 years ago[FASTFAT] Fail if allocating the stream FO fails.
Pierre Schweitzer [Sun, 20 May 2018 11:53:11 +0000 (13:53 +0200)]
[FASTFAT] Fail if allocating the stream FO fails.

2 years ago[SAMSRV] SamrChangePasswordUser: Check StoredLmEmpty and StoredNtEmpty instead of...
Eric Kohl [Sun, 20 May 2018 09:53:01 +0000 (11:53 +0200)]
[SAMSRV] SamrChangePasswordUser: Check StoredLmEmpty and StoredNtEmpty instead of checking StoredNtEmpty twice

2 years ago[SETUPAPI] Implement CM_Get_Resource_Conflict_Count and add stubs for CM_Get_Resource...
Eric Kohl [Sun, 20 May 2018 09:35:43 +0000 (11:35 +0200)]
[SETUPAPI] Implement CM_Get_Resource_Conflict_Count and add stubs for CM_Get_Resource_Conflict_DetailsA/W

2 years ago[EVENTMSG] Add French translation.
Pierre Schweitzer [Sun, 20 May 2018 09:35:21 +0000 (11:35 +0200)]
[EVENTMSG] Add French translation.

2 years ago[OLE32] Restore 4 cur files (+ note diff) to fix CORE-14608
Joachim Henze [Sat, 19 May 2018 23:41:34 +0000 (01:41 +0200)]
[OLE32] Restore 4 cur files (+ note diff) to fix CORE-14608

2 years ago[NTOS] Demote an ASSERT to a mere DPRINT since we only support registry hives with...
Hermès Bélusca-Maïto [Sat, 19 May 2018 20:04:20 +0000 (22:04 +0200)]
[NTOS] Demote an ASSERT to a mere DPRINT since we only support registry hives with cluster size == 1 in any case so far (other sizes are UNIMPLEMENTED!)

2 years ago[SETUPAPI] Implement CM_Free_Resource_Conflict_Handle() and CM_Query_Resource_Conflic...
Eric Kohl [Sat, 19 May 2018 16:11:48 +0000 (18:11 +0200)]
[SETUPAPI] Implement CM_Free_Resource_Conflict_Handle() and CM_Query_Resource_Conflict_List()

2 years ago[SHELL32] Allow deleting a file type/extension (#553)
Katayama Hirofumi MZ [Sat, 19 May 2018 14:12:11 +0000 (23:12 +0900)]
[SHELL32] Allow deleting a file type/extension (#553)


2 years ago[SETUPAPI] Add CM_Free_Resource_Conflict_Handle and CM_Query_Resource_Conflict_List...
Eric Kohl [Sat, 19 May 2018 13:11:17 +0000 (15:11 +0200)]
[SETUPAPI] Add CM_Free_Resource_Conflict_Handle and CM_Query_Resource_Conflict_List stubs

2 years ago[FASTFAT] Addendum to d69f318
Pierre Schweitzer [Sat, 19 May 2018 11:45:56 +0000 (13:45 +0200)]
[FASTFAT] Addendum to d69f318

2 years ago[USETUP] Use _wcstoui64() instead of atoi() to convert the partition size in order...
Eric Kohl [Sat, 19 May 2018 11:30:20 +0000 (13:30 +0200)]
[USETUP] Use _wcstoui64() instead of atoi() to convert the partition size in order to prevent unexpected misinterpretation of leading zeroes.

2 years ago[TRANSLATION] Polish translation update (#554)
Adam Słaboń [Sat, 19 May 2018 11:17:49 +0000 (13:17 +0200)]
[TRANSLATION] Polish translation update (#554)

- Added translations for cmdutils (at, clip, comp, eventcreate, mode, taskkill, wmic) and zipfldr.
- Updated translations for cmdutils (reg), drwtsn32, mmc, eventvwr, shell32 and cpl applets (console, input).

2 years ago[BOOTDATA] Add the (still disabled) faeroese keyboard layout
Eric Kohl [Sat, 19 May 2018 10:41:37 +0000 (12:41 +0200)]
[BOOTDATA] Add the (still disabled) faeroese keyboard layout


2 years ago[USETUP] Improved entering of partition size
Eric Kohl [Sat, 19 May 2018 10:09:12 +0000 (12:09 +0200)]
[USETUP] Improved entering of partition size

Patch by Эдуард.


2 years ago[FASTFAT] Misc. fixes spotted by Thomas.
Pierre Schweitzer [Sat, 19 May 2018 08:07:14 +0000 (10:07 +0200)]
[FASTFAT] Misc. fixes spotted by Thomas.

2 years ago[FASTFAT] Completely rewrite support for dirty volumes.
Pierre Schweitzer [Fri, 18 May 2018 21:00:13 +0000 (23:00 +0200)]
[FASTFAT] Completely rewrite support for dirty volumes.

Until now, our support for dirty volumes was totally broken
to a point where, on FAT32 volume, the dirty couldn't even
be written nor read from the disk.

This commit totally rewrites its handling, for both FAT16 and FAT32
so that it's now fully functionnal. Furthermore, it also gets
totally compatible with our vfatlib, and thus, autochk.
Now, on mount, FastFAT will check if the volume is dirty or not, and
autochk will be able to ask for a repair if dirty. vfatlib will
repair the volume and remove the dirty bit. So that, on next
reboot, the volume will be mounted clean.

As a reminder, the dirty bit is set immediately after mounting
the volume, so that, if you crash or have a powercut, autochk
will always attempt to repair your volume (with more or less,
that's FAT!).

If you want to experience without breaking your FAT volume,
just boot, open a cmd prompt and type: fsutil dirty set c:
and reboot!


2 years ago[FASTFAT] Allow locking system volume on boot.
Pierre Schweitzer [Fri, 18 May 2018 20:35:03 +0000 (22:35 +0200)]
[FASTFAT] Allow locking system volume on boot.

This is a hack, and totally not the default behavior.
But it will allow autochk locking the boot volume in
order to verify it on boot, in case it would have
been improperly dismounted.


2 years ago[SHELL32] Fix usage of DeferWindowPos (fix of #544) (#552)
Katayama Hirofumi MZ [Fri, 18 May 2018 20:27:22 +0000 (05:27 +0900)]
[SHELL32] Fix usage of DeferWindowPos (fix of #544) (#552)

2 years ago[DRWTSN32] Use GetCommandLineW for CommandLineToArgvW.
Mark Jansen [Sun, 13 May 2018 21:22:56 +0000 (23:22 +0200)]
[DRWTSN32] Use GetCommandLineW for CommandLineToArgvW.
Spotted by Hermès

2 years ago[FASTFAT] Uninit directory cache on last handle close.
Pierre Schweitzer [Fri, 18 May 2018 12:51:24 +0000 (14:51 +0200)]
[FASTFAT] Uninit directory cache on last handle close.


2 years ago[FASTFAT] Only initialize directory cache on use.
Pierre Schweitzer [Fri, 18 May 2018 12:03:20 +0000 (14:03 +0200)]
[FASTFAT] Only initialize directory cache on use.

This avoids initializing cache directly on directory
The advantage is we reduce the load on cache manager
and on memory manager by avoiding creating everytime
a stream file object, and initializing cache for it.

This will avoid initializing cache for started
applications 'current directory' which is just opened
for having a valid handle but no read/write is performed
in it, by default.

This is a step forward for autochk.


2 years ago[SHELL32] Add 'Create New Extension' IDD_NEWEXTENSION dialog (#544)
Katayama Hirofumi MZ [Fri, 18 May 2018 10:47:52 +0000 (19:47 +0900)]
[SHELL32] Add 'Create New Extension' IDD_NEWEXTENSION dialog (#544)

A 'Create New Extension' dialog is implemented, which enables the user to add a new file extension.

2 years ago[FASTFAT] When attaching our FCB to a FO, also set the VPB.
Pierre Schweitzer [Fri, 18 May 2018 08:29:45 +0000 (10:29 +0200)]
[FASTFAT] When attaching our FCB to a FO, also set the VPB.

Spotted by Alex.

2 years ago[TRANSLATION][DRWTSN32] Add zh-CN translation. (#549)
Wexpo Lyu [Thu, 17 May 2018 17:57:57 +0000 (01:57 +0800)]
[TRANSLATION][DRWTSN32] Add zh-CN translation. (#549)

2 years ago[TRANSLATION][TASKMGR] Update Chinese Translation.
Wexpo Lyu [Wed, 16 May 2018 13:28:58 +0000 (21:28 +0800)]
[TRANSLATION][TASKMGR] Update Chinese Translation.

2 years ago[IPHLPAPI] ipstats_reactos: Review all TRACE/WARN calls
Serge Gautherie [Sat, 24 Feb 2018 15:16:26 +0000 (16:16 +0100)]
[IPHLPAPI] ipstats_reactos: Review all TRACE/WARN calls

- Improve/Promote failures to ERR.
- Improve other TRACE calls.

2 years ago[CHARMAP]Code improvements (#436)
Baruch Rutman [Thu, 17 May 2018 15:18:57 +0000 (18:18 +0300)]
[CHARMAP]Code improvements (#436)

* [CHARMAP][GETUNAME] Code improvements

Based on the code from nls2txt,
switches the linking from dynamic to static, also simplifies the code.

2 years ago[KMTEST] Check/Wait for start/stop of services to complete
Serge Gautherie [Tue, 16 Jan 2018 04:47:34 +0000 (05:47 +0100)]
[KMTEST] Check/Wait for start/stop of services to complete

This is cleaner behavior and lets report failures.

- Create KmtEnsureServiceState(),
  called at end of KmtStartService() and KmtStopService().
- Create KmtGetServiceStateAsString(),
  called from KmtEnsureServiceState().


2 years agoFixed typo
Peter Wathall [Mon, 30 Apr 2018 00:17:19 +0000 (00:17 +0000)]
Fixed typo

2 years agoFixed typo
Peter Wathall [Mon, 30 Apr 2018 00:17:01 +0000 (00:17 +0000)]
Fixed typo

2 years agoFixed typo
Peter Wathall [Mon, 30 Apr 2018 00:16:45 +0000 (00:16 +0000)]
Fixed typo

2 years ago[FASTFAT] Deny dismounting system volume or a volume with a pagefile
Pierre Schweitzer [Wed, 16 May 2018 19:44:47 +0000 (21:44 +0200)]
[FASTFAT] Deny dismounting system volume or a volume with a pagefile

2 years ago[USETUP] Remove the WIN32 support because usetup is a native-only application
Eric Kohl [Tue, 15 May 2018 21:35:17 +0000 (23:35 +0200)]
[USETUP] Remove the WIN32 support because usetup is a native-only application

2 years ago[USETUP] Disable install path test that may tests
Eric Kohl [Tue, 15 May 2018 20:58:34 +0000 (22:58 +0200)]
[USETUP] Disable install path test that may tests

2 years ago[USETUP] Remove unused VolumeLabel and FileSystemName from the PARTENTRY type
Eric Kohl [Tue, 15 May 2018 18:02:04 +0000 (20:02 +0200)]
[USETUP] Remove unused VolumeLabel and FileSystemName from the PARTENTRY type

2 years ago[USETUP] Get rid of the interface directory because we support text-mode only
Eric Kohl [Tue, 15 May 2018 17:47:52 +0000 (19:47 +0200)]
[USETUP] Get rid of the interface directory because we support text-mode only

2 years ago[USETUP] Simplify the unattended code path in the install directory page and verify...
Eric Kohl [Tue, 15 May 2018 16:11:12 +0000 (18:11 +0200)]
[USETUP] Simplify the unattended code path in the install directory page and verify the unattended install path.

2 years ago[USETUP] Improve the install path checks
Eric Kohl [Tue, 15 May 2018 13:45:31 +0000 (15:45 +0200)]
[USETUP] Improve the install path checks

- Path must not contain whitespace characters.
- Path must be at least 2 characters long.
- Path must start with a backslash.
- Path must not end with a backslash.
- Path components must not end with a dot.


2 years ago[USETUP] Add support for HOME, END, DEL, LEFT and RIGHT keys to partition size and...
Eric Kohl [Tue, 15 May 2018 09:28:33 +0000 (11:28 +0200)]
[USETUP] Add support for HOME, END, DEL, LEFT and RIGHT keys to partition size and install path edit fields.


2 years ago[USETUP] Fix the name of the backspace key in the german translation
Eric Kohl [Mon, 14 May 2018 21:35:48 +0000 (23:35 +0200)]
[USETUP] Fix the name of the backspace key in the german translation


2 years ago[NDIS] Fix parameter order when calling ResetHandler. CORE-14624
Thomas Faber [Mon, 14 May 2018 16:16:02 +0000 (18:16 +0200)]
[NDIS] Fix parameter order when calling ResetHandler. CORE-14624

2 years ago[CLIPBRD] Improvements for the Clipboard Viewer.
Hermès Bélusca-Maïto [Sun, 13 May 2018 20:15:41 +0000 (22:15 +0200)]
[CLIPBRD] Improvements for the Clipboard Viewer.

- Improve the scrolling support for bitmaps, DIBs and text formats.
  This completes the work started in CORE-10679 by Ricardo Hanke.
  Includes scrolling with the keyboard and the mouse wheel.
- Add support for the CF_DSP* clipboard formats, as well as CF_TEXT
- Add support for owner-display clipboard format CF_OWNERDISPLAY.
- Realize any palette found in the clipboard (CF_PALETTE) before
  displaying the clipboard data format we want.
- Remove dead code.
- Update the file headers.

2 years agoAdd virtio drivers to
Andrew Cook [Sun, 13 May 2018 04:56:44 +0000 (14:56 +1000)]
Add virtio drivers to

qxl has some visual glitches, viostor loads but it seems reactos
doesn't support scsi disks yet