20 months ago[NTOSKRNL] Add the CcDataFlushes and CcDataPages counters
Pierre Schweitzer [Sat, 24 Feb 2018 13:02:33 +0000 (14:02 +0100)]
[NTOSKRNL] Add the CcDataFlushes and CcDataPages counters

20 months ago[NTOSKRNL] Add the CcPinReadWait and CcPinReadNoWait counters
Pierre Schweitzer [Sat, 24 Feb 2018 12:47:15 +0000 (13:47 +0100)]
[NTOSKRNL] Add the CcPinReadWait and CcPinReadNoWait counters

20 months ago[SHLWAPI] Cherry-pick Wine commit 7be8beab68c (Don't attempt to un-expect ComputerNam...
Thomas Faber [Sat, 24 Feb 2018 13:15:48 +0000 (14:15 +0100)]
[SHLWAPI] Cherry-pick Wine commit 7be8beab68c (Don't attempt to un-expect ComputerName in PathUnExpandEnvStrings) by Katayama Hirofumi MZ. CORE-13816

20 months ago[KERNEL32_WINETEST] Cherry-pick Wine commit 85f515292aa (Close process / thread handl...
Thomas Faber [Sat, 24 Feb 2018 13:14:35 +0000 (14:14 +0100)]
[KERNEL32_WINETEST] Cherry-pick Wine commit 85f515292aa (Close process / thread handles) by Mark Jansen.

20 months ago[IMAGEHLP_WINETEST] Un-mark a ROS-diff that's been committed upstream.
Thomas Faber [Sat, 24 Feb 2018 11:05:12 +0000 (12:05 +0100)]
[IMAGEHLP_WINETEST] Un-mark a ROS-diff that's been committed upstream.

20 months ago[NTOSKRNL] Return some Cc counters in SystemPerformanceInformation
Pierre Schweitzer [Sat, 24 Feb 2018 12:35:17 +0000 (13:35 +0100)]
[NTOSKRNL] Return some Cc counters in SystemPerformanceInformation

20 months ago[NTOSKRNL] Add the CcMapDataWait and CcMapDataNoWait counters
Pierre Schweitzer [Sat, 24 Feb 2018 12:28:45 +0000 (13:28 +0100)]
[NTOSKRNL] Add the CcMapDataWait and CcMapDataNoWait counters

20 months ago[SERVICES][ADVAPI32] Fix the broken service stop sequence
Eric Kohl [Sat, 24 Feb 2018 10:14:05 +0000 (11:14 +0100)]
[SERVICES][ADVAPI32] Fix the broken service stop sequence

- Refactor ScmControlService() so that it can be used to send the dispatcher loop stop command.
- Separate the code to decrement the image run counter from the service image cleanup code.

- RSetServiceStatus(): Stop the dispatcher loop when the image run counter is zero and remove the service image after that.

- Do not terminate the service dispatcher loop when the last service is being stopped. Wait for an explicit dispatcher stop command (empty service name).


20 months ago[IPHLPAPI] Fix getNumRoutes() return value, on Mib error (#391)
Serge Gautherie [Fri, 23 Feb 2018 17:35:02 +0000 (18:35 +0100)]
[IPHLPAPI] Fix getNumRoutes() return value, on Mib error (#391)

20 months ago[SHELL32] -CMenuToolbarBase: Remove all buttons on destruction. CORE-13194
Giannis Adamopoulos [Fri, 23 Feb 2018 10:27:48 +0000 (12:27 +0200)]
[SHELL32] -CMenuToolbarBase: Remove all buttons on destruction. CORE-13194
It seems that TBN_DELETINGBUTTON isn't called when the toolbar gets destroyed so the only way to avoid leaking the data is emptying it ourselves.

20 months ago[SHIMENG] Do not crash on a NULL ModuleName & BaseAddress.
Mark Jansen [Thu, 22 Feb 2018 22:25:34 +0000 (23:25 +0100)]
[SHIMENG] Do not crash on a NULL ModuleName & BaseAddress.

20 months ago[KMTESTS:FSRTL] Fix all FsRtlLargeMcbTestsFastFat() checks
Serge Gautherie [Thu, 22 Feb 2018 15:03:42 +0000 (16:03 +0100)]
[KMTESTS:FSRTL] Fix all FsRtlLargeMcbTestsFastFat() checks

Addendum to 22037684e42e29abc99a9a280278b16305eaa2e2.

- Result: check "== FALSE" not "= TRUE".
- Report compared values, not different ones.


20 months ago[NTOS:CC] Don't read past the end of the file in CcPerformReadAhead. 390/head
Thomas Faber [Tue, 20 Feb 2018 12:49:54 +0000 (13:49 +0100)]
[NTOS:CC] Don't read past the end of the file in CcPerformReadAhead.

20 months ago[NTOS:CC] Avoid some magic numbers.
Thomas Faber [Tue, 20 Feb 2018 12:18:34 +0000 (13:18 +0100)]
[NTOS:CC] Avoid some magic numbers.

20 months ago[SHELL32] Fix PIDL leak in CMenuSFToolbar::FillToolbar. CORE-13194
Thomas Faber [Thu, 22 Feb 2018 10:51:07 +0000 (11:51 +0100)]
[SHELL32] Fix PIDL leak in CMenuSFToolbar::FillToolbar. CORE-13194

20 months ago[DHCPCSVC] Fix a memory leak in bind_lease introduced in r14645 (!). CORE-14353
Thomas Faber [Thu, 22 Feb 2018 10:28:55 +0000 (11:28 +0100)]
[DHCPCSVC] Fix a memory leak in bind_lease introduced in r14645 (!). CORE-14353

20 months ago[KMTESTS:FSRTL] Add a few more tests matching MS FastFAT.
Pierre Schweitzer [Wed, 21 Feb 2018 21:50:23 +0000 (22:50 +0100)]
[KMTESTS:FSRTL] Add a few more tests matching MS FastFAT.


20 months ago[IPHLPAPI] Fix memory leak in getNumRoutes. CORE-14353
Thomas Faber [Wed, 21 Feb 2018 17:40:23 +0000 (18:40 +0100)]
[IPHLPAPI] Fix memory leak in getNumRoutes. CORE-14353

20 months ago[KMTESTS:FSRTL] Avoid writing to string literals. ROSTESTS-298
Thomas Faber [Wed, 21 Feb 2018 14:16:47 +0000 (15:16 +0100)]
[KMTESTS:FSRTL] Avoid writing to string literals. ROSTESTS-298

20 months ago[VFATLIB] Fix FAT partitions formatting in a non clean fashion.
Pierre Schweitzer [Tue, 20 Feb 2018 23:16:36 +0000 (00:16 +0100)]
[VFATLIB] Fix FAT partitions formatting in a non clean fashion.

(So the fun begins)
In spite of what VFATLIB headers pretend, there's not magic in FAT boot sector.
The 3 first bytes are just the jump instruction (to the boot code). No jump, no boot.
Also, some (many?) FAT implementations rely on the jump code to help detecting that
a FAT volume is really a FAT volume. Like MS FastFAT. Or our own FAT recognizer in FS_REC.
The story is that, up to that commit, we zeroed the 3 first bytes; leading to broken
FAT volumes.
This got hidden in most cases by the fact that during setup, when we install boot
loader, we erase parts of the boot sector, including the jump instruction, making the
volume valid again. But that wouldn't fix secondary volumes where the boot loader isn't
And, also, imagine a scenario where you want to install ReactOS on a newly formatted volume
with MS FastFAT instead of our own implementation... That would simply not work to
the fact that the driver wouldn't recognize the fresh formatted volume!

(So the non fashion begins)
Fix this by putting a not that valid jump into the boot sector when formatting our
partitions. That way, our volume is always regarding a FAT view point. But, instead of
putting values that mean (nearly) nothing. We should also put a dummy bootloader
displaying the user and error message, as done by dosfstools.

(So the hope begins)
This opens the way for trying to install ReactOS with MS FastFAT (doesn't work yet).


20 months ago[SC] Addendum to 4728157: Add missed values to query errors and usage output. (#387)
Serge Gautherie [Tue, 20 Feb 2018 18:45:55 +0000 (19:45 +0100)]
[SC] Addendum to 4728157: Add missed values to query errors and usage output. (#387)

20 months ago[SHELL32] CShellItem: Fix GetDisplayName and Compare
Giannis Adamopoulos [Tue, 20 Feb 2018 14:59:00 +0000 (16:59 +0200)]
[SHELL32] CShellItem: Fix GetDisplayName and Compare
The two methods were completely broken because they passed a full pidl to the parent folder (and not desktop folder).
Compile SHGetNameFromIDList to use it in CShellItem but don't export it.

20 months ago[SHELL32] CShellItem: Implement BindToHandler and improve GetAttributes based on...
Giannis Adamopoulos [Tue, 20 Feb 2018 14:31:28 +0000 (16:31 +0200)]
[SHELL32] CShellItem: Implement BindToHandler and improve GetAttributes based on wine
Fixes lots of tests.

20 months ago[SHELL32] CShellItem: Fix return value of Compare method
Giannis Adamopoulos [Tue, 20 Feb 2018 12:36:31 +0000 (14:36 +0200)]
[SHELL32] CShellItem: Fix return value of Compare method

20 months ago[SHELL32] CDefaultContextMenu: Implement GetCommandString
Giannis Adamopoulos [Tue, 20 Feb 2018 11:05:59 +0000 (13:05 +0200)]
[SHELL32] CDefaultContextMenu: Implement GetCommandString

20 months ago[SHELL32] Fix a couple of tests
Giannis Adamopoulos [Tue, 20 Feb 2018 09:48:40 +0000 (11:48 +0200)]
[SHELL32] Fix a couple of tests

20 months ago[SHELL32] shellpath: sync a part of _SHGetDefaultValue with wine
Giannis Adamopoulos [Tue, 20 Feb 2018 08:58:14 +0000 (10:58 +0200)]
[SHELL32] shellpath: sync a part of _SHGetDefaultValue with wine
on 32bit builds CSIDL_PROGRAM_FILESX86 is treated as CSIDL_PROGRAM_FILES and on wow64 builds CSIDL_PROGRAM_FILES gets treated as CSIDL_PROGRAM_FILESX86

20 months ago[SHELL32] Fix some test failures
Giannis Adamopoulos [Mon, 19 Feb 2018 01:23:15 +0000 (03:23 +0200)]
[SHELL32] Fix some test failures

20 months ago[REACTOS] Fix a number of Get/SetWindowsLong*Ptr* issues and use GWLP_* instead of...
Timo Kreuzer [Mon, 5 Feb 2018 01:42:14 +0000 (02:42 +0100)]
[REACTOS] Fix a number of Get/SetWindowsLong*Ptr* issues and use GWLP_* instead of GWL_* where appropriate.

20 months ago[WIN32K] Implement NtUserSetWindowLongPtr for 64 bit builds
Timo Kreuzer [Fri, 29 Dec 2017 09:46:19 +0000 (10:46 +0100)]
[WIN32K] Implement NtUserSetWindowLongPtr for 64 bit builds
Also fix return type of NtUserQueryWindow and type of WND::dwUserData and the value for bAnsi in SetWindowLongPtrA

20 months ago[RTL][XDK][KERNERL32_WINETEST] Import wine actctx changes from 3.2-37c98396
Mark Jansen [Mon, 19 Feb 2018 21:23:39 +0000 (22:23 +0100)]
[RTL][XDK][KERNERL32_WINETEST] Import wine actctx changes from 3.2-37c98396
This adds support for reading the trustInfo (requestedExecutionLevel),
and the compatibility (supportedOs) sections.

20 months ago[RAPPS] Various fixes
Mark Jansen [Sun, 18 Feb 2018 14:27:08 +0000 (15:27 +0100)]
[RAPPS] Various fixes
- Ask the user if they want to continue on cab certificate problems
- Fix memory leaks in failure paths
- Properly disable caching

20 months ago[SNDREC32] it-IT.rc: add a missing new line
Giannis Adamopoulos [Mon, 19 Feb 2018 00:03:35 +0000 (02:03 +0200)]
[SNDREC32] it-IT.rc: add a missing new line

20 months ago[SHELL32] CFSFolder: Fix some tests for GetAttributesOf
Giannis Adamopoulos [Sun, 18 Feb 2018 23:59:30 +0000 (01:59 +0200)]
[SHELL32] CFSFolder: Fix some tests for GetAttributesOf

20 months ago[SERVICES] Update a drivers status properly
Eric Kohl [Sun, 18 Feb 2018 17:47:42 +0000 (18:47 +0100)]
[SERVICES] Update a drivers status properly

- ScmUnloadDriver: Handle failed unload properly.
- ScmGetDriverStatus: A driver is running when its driver object was found. Otherwise it has been stopped.
- ScmControlDriver: Check a drivers status before and after unloading.


20 months ago[COMCTL32] Export GetWindowSubclass by name.
Mark Jansen [Sun, 18 Feb 2018 22:04:45 +0000 (23:04 +0100)]
[COMCTL32] Export GetWindowSubclass by name.

20 months ago[NTOSKRNL] Fix mismatching spinlock release in CcPerformReadAhead()
Pierre Schweitzer [Sun, 18 Feb 2018 18:32:08 +0000 (19:32 +0100)]
[NTOSKRNL] Fix mismatching spinlock release in CcPerformReadAhead()

20 months ago[KMTESTS:CC] Addendum to 3fe0e28: use ok_irql.
Pierre Schweitzer [Sun, 18 Feb 2018 13:50:29 +0000 (14:50 +0100)]
[KMTESTS:CC] Addendum to 3fe0e28: use ok_irql.


20 months ago[KMTESTS:IO] Fix a Clang-Cl warning about NameLength 380/head
Serge Gautherie [Sun, 18 Feb 2018 13:06:23 +0000 (14:06 +0100)]
[KMTESTS:IO] Fix a Clang-Cl warning about NameLength

"warning: variable 'NameLength' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]"


20 months ago[KMTESTS:IO] Correctly free name in IoFilesystem's TestAllInformation.
Thomas Faber [Sun, 18 Feb 2018 13:05:10 +0000 (14:05 +0100)]
[KMTESTS:IO] Correctly free name in IoFilesystem's TestAllInformation.

Spotted by Serge Gautherie.

20 months ago[KMTESTS:NPFS] Fix 2 Clang-Cl warnings about ShareAccess
Serge Gautherie [Tue, 13 Feb 2018 12:05:35 +0000 (13:05 +0100)]
[KMTESTS:NPFS] Fix 2 Clang-Cl warnings about ShareAccess

"warning: variable 'ShareAccess' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]"


20 months ago[KMTESTS:CC] Add IRQL tests for CcCopyRead showing that a spinlock is held during...
Pierre Schweitzer [Sun, 18 Feb 2018 12:58:01 +0000 (13:58 +0100)]
[KMTESTS:CC] Add IRQL tests for CcCopyRead showing that a spinlock is held during Cc IO operations.


20 months ago[HAL] Eliminate tail calls from HalpHardwareInterruptLevel. CORE-14076 178/head
Thomas Faber [Sun, 18 Feb 2018 11:51:16 +0000 (12:51 +0100)]
[HAL] Eliminate tail calls from HalpHardwareInterruptLevel. CORE-14076

20 months ago[HAL] Eliminate tail calls from HalpDispatchInterrupt[2]. CORE-14076
Thomas Faber [Sun, 18 Feb 2018 11:50:54 +0000 (12:50 +0100)]
[HAL] Eliminate tail calls from HalpDispatchInterrupt[2]. CORE-14076

20 months ago[HAL] Eliminate tail calls from HalEndSystemInterrupt. CORE-14076
Thomas Faber [Sun, 18 Feb 2018 11:49:24 +0000 (12:49 +0100)]
[HAL] Eliminate tail calls from HalEndSystemInterrupt. CORE-14076

20 months ago[HAL] Create a macro for the HalpEndSoftwareInterrupt to allow reuse. CORE-14076
Thomas Faber [Sun, 18 Feb 2018 11:42:18 +0000 (12:42 +0100)]
[HAL] Create a macro for the HalpEndSoftwareInterrupt to allow reuse. CORE-14076

20 months ago[HAL] Convert HalpEndSoftwareInterrupt2 to fastcall. CORE-14076
Thomas Faber [Sun, 11 Feb 2018 10:33:16 +0000 (11:33 +0100)]
[HAL] Convert HalpEndSoftwareInterrupt2 to fastcall. CORE-14076

20 months ago[RAPPS] Some fixes to our completely broken cert pinning attempt.
Mark Jansen [Sun, 18 Feb 2018 11:56:33 +0000 (12:56 +0100)]
[RAPPS] Some fixes to our completely broken cert pinning attempt.
- We should not open a new connection to request a certificate.
- Update the issuer / subject for the LE certificate.
- User proper types.
- Require all fields that we check to be present.

Without checking the public key or the entire certificate it's still not secure, but we are a step closer.
Dedicated to Joachim Henze

20 months ago[NTOSKRNL] Don't make CcScheduleReadAhead() too noisy
Pierre Schweitzer [Sun, 18 Feb 2018 10:30:51 +0000 (11:30 +0100)]
[NTOSKRNL] Don't make CcScheduleReadAhead() too noisy

20 months ago[WIN32K:NTUSER] Safely handle allocation failure in IntCloneMenu. CORE-14222 366/head
Thomas Faber [Thu, 1 Feb 2018 10:08:14 +0000 (11:08 +0100)]
[WIN32K:NTUSER] Safely handle allocation failure in IntCloneMenu. CORE-14222

20 months ago[WIN32K:NTUSER] Avoid allocating an extra item in IntCloneMenuItems. CORE-14222
Thomas Faber [Thu, 1 Feb 2018 10:07:39 +0000 (11:07 +0100)]
[WIN32K:NTUSER] Avoid allocating an extra item in IntCloneMenuItems. CORE-14222

20 months ago[WIN32K:NTUSER] Handle realloc failure in IntRemoveMenuItem. CORE-14222
Thomas Faber [Thu, 1 Feb 2018 10:06:50 +0000 (11:06 +0100)]
[WIN32K:NTUSER] Handle realloc failure in IntRemoveMenuItem. CORE-14222

20 months ago[WIN32K:NTUSER] Handle allocation failure in PopupMenuWndProc. CORE-14222
Thomas Faber [Thu, 1 Feb 2018 10:06:03 +0000 (11:06 +0100)]
[WIN32K:NTUSER] Handle allocation failure in PopupMenuWndProc. CORE-14222

20 months ago[KMTESTS] Change license to LGPL and update to SPDX headers.
Thomas Faber [Sun, 18 Feb 2018 10:14:13 +0000 (11:14 +0100)]
[KMTESTS] Change license to LGPL and update to SPDX headers.

Permission for this change was given by all authors
(who are now mentioned in the copyright lines).

20 months ago[NTSTATUS] Add some status messages.
Hermès Bélusca-Maïto [Sun, 18 Feb 2018 01:49:31 +0000 (02:49 +0100)]
[NTSTATUS] Add some status messages.

20 months ago[BOOTDATA] Add some informative registry values (Win2k3 compat).
Hermès Bélusca-Maïto [Sun, 18 Feb 2018 00:41:53 +0000 (01:41 +0100)]
[BOOTDATA] Add some informative registry values (Win2k3 compat).

- In HKLM\SYSTEM\CurrentControlSet\Control\Windows, add "Directory"
  and "SystemDirectory" values, giving the ReactOS installation
  directories (purely informative).
- Also add the "ErrorMode" value that specifies how the hard-error
  popups are displayed. This value will be used later.
- Fix event log sources ordering.

20 months ago[BOOTDATA] Add "Application Popup" as a known source of events for the System event...
Hermès Bélusca-Maïto [Sun, 18 Feb 2018 00:16:24 +0000 (01:16 +0100)]
[BOOTDATA] Add "Application Popup" as a known source of events for the System event log.

20 months ago[CMAKE] Increase KERNEL_VERSION_PATCH_LEVEL to 9 CORE-14345
Joachim Henze [Sat, 17 Feb 2018 22:48:16 +0000 (23:48 +0100)]

To make 1st stage setup properly report "0.4.9"

20 months ago[SC] Fix MSVC build.
Hermès Bélusca-Maïto [Sat, 17 Feb 2018 20:03:58 +0000 (21:03 +0100)]
[SC] Fix MSVC build.

20 months ago[SHELL32] CFSDropTarget: style fixes
Giannis Adamopoulos [Sat, 17 Feb 2018 20:01:04 +0000 (22:01 +0200)]
[SHELL32] CFSDropTarget: style fixes

20 months ago[SHELL32] CDefView: remove a useless print
Giannis Adamopoulos [Sat, 17 Feb 2018 19:36:31 +0000 (21:36 +0200)]
[SHELL32] CDefView: remove a useless print

20 months ago[SHELL32] CFSDropTarget: Use copy depending on the source drive
Giannis Adamopoulos [Sat, 17 Feb 2018 11:59:51 +0000 (13:59 +0200)]
[SHELL32] CFSDropTarget: Use copy depending on the source drive
Show the default action as the default menu item in the right click menu.

20 months ago[SHELL32] CFSDropTarget: Initial implementation of right click drag menu
Giannis Adamopoulos [Fri, 16 Feb 2018 18:33:44 +0000 (20:33 +0200)]
[SHELL32] CFSDropTarget: Initial implementation of right click drag menu

20 months ago[SHELL32] CDefView: Implement several methods needed for drop targets
Giannis Adamopoulos [Sat, 17 Feb 2018 17:29:20 +0000 (19:29 +0200)]
[SHELL32] CDefView: Implement several methods needed for drop targets
Set the view object as the site of the drop target.
Implement GetItemPosition, SelectAndPositionItems, IsDropOnSource, GetDragPoint.
Use DROPEFFECT_COPY only when the item supports it.

20 months ago[SHELL32] Add menu resource which is used when dragging files with right click
Giannis Adamopoulos [Sat, 17 Feb 2018 17:18:43 +0000 (19:18 +0200)]
[SHELL32] Add menu resource which is used when dragging files with right click

20 months ago[SC] Implement missing query/queryex options
Eric Kohl [Sat, 17 Feb 2018 18:26:06 +0000 (19:26 +0100)]
[SC] Implement missing query/queryex options
- PrintService: Print optional display name.
- MainUsage: Print missing query options.
- Parse query options and use them to enumerate services.

20 months ago[CMAKE] Call "git describe" with the --long parameter to always output the format...
Colin Finck [Sat, 17 Feb 2018 17:09:07 +0000 (18:09 +0100)]
[CMAKE] Call "git describe" with the --long parameter to always output the format we are used to.

20 months ago[SHELL32_APITEST] Run the CUserNotification worker test function in a thread to copy... 0.4.9-dev
Hermès Bélusca-Maïto [Sat, 17 Feb 2018 15:02:22 +0000 (16:02 +0100)]
[SHELL32_APITEST] Run the CUserNotification worker test function in a thread to copy with possible test timeouts. CORE-13177

20 months ago[NTOSKRNL] Don't call OOM dumper in case we were trying to allocate more than 100...
Pierre Schweitzer [Sat, 17 Feb 2018 14:09:38 +0000 (15:09 +0100)]
[NTOSKRNL] Don't call OOM dumper in case we were trying to allocate more than 100 pages.
In such case, we'll consider the caller is bogus and we'll fail in silence.
Dedicated to Mark (again!)

20 months ago[NTOSKRNL] Allow more chars in ExpTagAllowPrint().
Pierre Schweitzer [Sat, 17 Feb 2018 14:06:29 +0000 (15:06 +0100)]
[NTOSKRNL] Allow more chars in ExpTagAllowPrint().
Dedicated to Mark

20 months ago[FASTFAT] Drop read ahead locking routines in favor of lazy writer routines.
Pierre Schweitzer [Sat, 17 Feb 2018 12:48:32 +0000 (13:48 +0100)]
[FASTFAT] Drop read ahead locking routines in favor of lazy writer routines.
This avoids code duplication while being consistent with MS FastFAT.

20 months ago[SHELL32] Fix COM registration of IShellFolder, IShellLinkA/W, IQueryContinue and...
Hermès Bélusca-Maïto [Fri, 16 Feb 2018 22:30:09 +0000 (23:30 +0100)]
[SHELL32] Fix COM registration of IShellFolder, IShellLinkA/W, IQueryContinue and IUserNotification classes.

20 months ago[EXPLORER] Update French translation
Pierre Schweitzer [Fri, 16 Feb 2018 18:36:25 +0000 (19:36 +0100)]
[EXPLORER] Update French translation

20 months agoimprove SHGetFileInfo (#118)
Katayama Hirofumi MZ [Fri, 16 Feb 2018 11:00:08 +0000 (20:00 +0900)]
improve SHGetFileInfo (#118)

This patch reduces failures of SHGetFileInfo function. CORE-7159
* improve WideByteToWideChar calls
* fix bugs related to file attributes and SHGFI_EXETYPE
* s/sizeof(temppsfi)/0/

20 months ago[D3D9][ARPING] Add missing va_start() and va_end() (#371)
Serge Gautherie [Fri, 16 Feb 2018 09:28:25 +0000 (10:28 +0100)]
[D3D9][ARPING] Add missing va_start() and va_end() (#371)

20 months ago[COM_APITEST] Reenable two known interfaces (#367). Caught by Thomas.
Hermès Bélusca-Maïto [Thu, 15 Feb 2018 23:15:41 +0000 (00:15 +0100)]
[COM_APITEST] Reenable two known interfaces (#367). Caught by Thomas.

20 months ago[I8042PRT] Apply a workaround for Dell Latitude D610
Doug Lyons [Thu, 15 Feb 2018 21:48:01 +0000 (22:48 +0100)]
[I8042PRT] Apply a workaround for Dell Latitude D610

20 months ago[SHELL32_APITEST] Add a test for the CUserNotification implementation. CORE-13177 367/head
Hermès Bélusca-Maïto [Thu, 15 Feb 2018 00:17:32 +0000 (01:17 +0100)]
[SHELL32_APITEST] Add a test for the CUserNotification implementation. CORE-13177

20 months ago[SHELL32] Implement the CUserNotification class, which implements the IUserNotificati...
Hermès Bélusca-Maïto [Wed, 7 Feb 2018 01:20:26 +0000 (02:20 +0100)]
[SHELL32] Implement the CUserNotification class, which implements the IUserNotification interface. CORE-13177

20 months ago[COM_APITEST] Add tests for IUserNotification. CORE-13177
Hermès Bélusca-Maïto [Wed, 7 Feb 2018 01:14:07 +0000 (02:14 +0100)]
[COM_APITEST] Add tests for IUserNotification. CORE-13177

20 months ago[PSDK] Add definitions for IUserNotification, IQueryContinue, and IUserNotification2...
Hermès Bélusca-Maïto [Wed, 7 Feb 2018 01:15:41 +0000 (02:15 +0100)]
[PSDK] Add definitions for IUserNotification, IQueryContinue, and IUserNotification2 and IUserNotificationCallback (Vista+).

20 months ago[SC] Disable debug messages on user interface (#382)
Serge Gautherie [Thu, 15 Feb 2018 13:58:17 +0000 (14:58 +0100)]
[SC] Disable debug messages on user interface (#382)

20 months ago[HAL] Implement APIC-based profiling for x64. 116/head
Ivan Labutin [Mon, 6 Nov 2017 18:40:21 +0000 (21:40 +0300)]
[HAL] Implement APIC-based profiling for x64.

20 months ago[IP] Silence "TCP operation failed" debug spam.
Thomas Faber [Thu, 15 Feb 2018 11:19:57 +0000 (12:19 +0100)]
[IP] Silence "TCP operation failed" debug spam.

20 months ago[SHELL32] CNewMenu: Don't use CWM_GETISHELLBROWSER.
Giannis Adamopoulos [Wed, 14 Feb 2018 22:58:22 +0000 (00:58 +0200)]
CDefaultContextMenu: Set the site for context menu extensions
CNewMenu: Get SID_IFolderView service of the site to get the IShellView

20 months ago[SHELL32] Fix the toolbar buttons in the file open dialog
Giannis Adamopoulos [Wed, 14 Feb 2018 22:23:18 +0000 (00:23 +0200)]
[SHELL32] Fix the toolbar buttons in the file open dialog
CDefView: Make GetItemObject return an IContectMenu after setting itself as the site.
CDefViewBckgrndMenu: Make the inner context menu use the same site. Implement handling CMDSTR_VIEWLISTA and CMDSTR_VIEWDETAILSA.
CDefaultContextMenu: CMDSTR_VIEWLISTA and CMDSTR_VIEWDETAILSA shouldn't be handled in this class.
Fixes CORE-14327 and the two buttons that change the view mode

20 months ago[SHELL32] Fix glitch in de-DE.rc
Joachim Henze [Wed, 14 Feb 2018 19:12:10 +0000 (20:12 +0100)]
[SHELL32] Fix glitch in de-DE.rc

checkbox captions are too long.
issue was introduced by 3624c5d6fd2cf1c589c26f75ac2d6054f7a838a0

fixes CORE-14329 for de-DE

20 months ago[SHELL32] CDefViewBckgrndMenu: Fix handling string verbs.
Giannis Adamopoulos [Tue, 13 Feb 2018 22:03:35 +0000 (00:03 +0200)]
[SHELL32] CDefViewBckgrndMenu: Fix handling string verbs.
It shouldn't be necessary for QueryContextMenu to be called before InvokeCommand.
Move retrieving the IContextMenu of the folder to the initialization of the class.

20 months ago[SHLWAPI] Import wine commit 2c163225730e88 as addendum to the SHCreateWorkerWindowW...
Hermès Bélusca-Maïto [Tue, 13 Feb 2018 21:05:13 +0000 (22:05 +0100)]
[SHLWAPI] Import wine commit 2c163225730e88 as addendum to the SHCreateWorkerWindowW/A fixes from commit 770bf93.

20 months ago[TRANSLATION][INF] Update Simplified Chinese translation. (#378)
Luo Yufan [Tue, 13 Feb 2018 21:16:25 +0000 (05:16 +0800)]
[TRANSLATION][INF] Update Simplified Chinese translation. (#378)

20 months ago[COMCTL32] Import wine commit 71cf0a31d99feb to fix the name column width in rapps.
Mark Jansen [Tue, 13 Feb 2018 18:47:58 +0000 (19:47 +0100)]
[COMCTL32] Import wine commit 71cf0a31d99feb to fix the name column width in rapps.

20 months ago[SHLWAPI] Improvements for SHCreateWorkerWindowW/A() prototypes + fix x64-bit compati...
Hermès Bélusca-Maïto [Mon, 12 Feb 2018 23:10:09 +0000 (00:10 +0100)]
[SHLWAPI] Improvements for SHCreateWorkerWindowW/A() prototypes + fix x64-bit compatibility. Sent upstream.

[SHLWAPI] Refactor the SHCreateWorkerWindowW() prototype to match its ANSI SHCreateWorkerWindowA() counterpart.

The last parameter is really to be understood as an extra window data, and not a "message result" (as it would be the case for dialog window procedure).
That is why I also remove the mention of "DWLP_MSGRESULT" in the SetWindowLongPtrW() call.
SHCreateWorkerWindowA() had it OK but SHCreateWorkerWindowW() did not.


[SHLWAPI] Make SHCreateWorkerWindowA() and SHCreateWorkerWindowW() x64-compatible.

The first parameter of these functions is a pointer to a window procedure, having a definite prototype, so employ a correct typedef WNDPROC,
which ensures both correct pointer size and parameter type enforcement.
This also ensures that we use instead a correct pointer size, since otherwise LONG remains 32-bits for Windows compatibility on x64 platforms.
The wndProc parameter is thus casted to LONG_PTR to comply with the SetWindowLongPtrA/W calls.

In SHCreateWorkerWindowW(), the last "wnd_extra" parameter should also be LONG_PTR to be able to pass 64-bit data pointer on x64 platforms.
Therefore fix also setting the wc.cbWndExtra size. One should note that the ANSI SHCreateWorkerWindowA() function had everything OK already.

20 months ago[CDFS_NEW] Fix a bug in Microsoft CDFS implementation where the top level IRP
Pierre Schweitzer [Mon, 12 Feb 2018 19:45:12 +0000 (20:45 +0100)]
[CDFS_NEW] Fix a bug in Microsoft CDFS implementation where the top level IRP
is set before locking is actually attempted for Cc worker thread (lazy write/read ahead).
So in case locking fails, the top level IRP is set and never unset, and latter
call will hit the assert where it expects the top level IRP to be NULL.

Should be reported upstream (tm).


20 months ago[SERVICES] Set a complete service status for running boot start or system start drivers
Eric Kohl [Mon, 12 Feb 2018 14:50:30 +0000 (15:50 +0100)]
[SERVICES] Set a complete service status for running boot start or system start drivers

20 months ago[SERVICES] Fix the initial service status
Eric Kohl [Mon, 12 Feb 2018 13:58:02 +0000 (14:58 +0100)]
[SERVICES] Fix the initial service status

- The initial dwWin32ExitCode for a disabled service is ERROR_SERVICE_DISABLED and ERROR_SRVICE_NEVER_STARTED for non-disabled services.
- The initial dwWaitHint is 2000 (2 seconds) for (user-mode) services and 0 for drivers.
- Move all driver-related code to driver.c.

20 months ago[APPSHIM_APITEST] Fix 2 Clang-Cl warnings about ok2
Serge Gautherie [Sun, 11 Feb 2018 22:15:06 +0000 (23:15 +0100)]
[APPSHIM_APITEST] Fix 2 Clang-Cl warnings about ok2

"warning: expression result unused [-Wunused-value]"


20 months ago[EXPLORER] Fix a Clang-Cl warning about Icon->ProcessId
Serge Gautherie [Sun, 11 Feb 2018 22:57:15 +0000 (23:57 +0100)]
[EXPLORER] Fix a Clang-Cl warning about Icon->ProcessId

"warning: expression result unused [-Wunused-value]"
Regressed in be2bf9b.


20 months ago[EXPLORER] WatchList should be freed with delete[], not delete (#374)
Bișoc George [Sun, 11 Feb 2018 21:56:38 +0000 (22:56 +0100)]
[EXPLORER] WatchList should be freed with delete[], not delete (#374)

WatchList is a set of array objects, initialized with "new[]", so it should be freed with "delete[]" to free all of its elements. Otherwise using only "delete" only frees the first variable but not its array. This would lead to an undefined behaviour.

20 months ago[CONUTILS] Relax the enforcement of using FORMAT_MESSAGE_MAX_WIDTH_MASK in the ConMsg...
Hermès Bélusca-Maïto [Sun, 11 Feb 2018 17:08:39 +0000 (18:08 +0100)]
[CONUTILS] Relax the enforcement of using FORMAT_MESSAGE_MAX_WIDTH_MASK in the ConMsg* and ConResMsg* functions.

21 months ago[MAGNIFY] Call PostQuitMessage() only at the very end.
Hermès Bélusca-Maïto [Sat, 10 Feb 2018 23:35:29 +0000 (00:35 +0100)]
[MAGNIFY] Call PostQuitMessage() only at the very end.