Amine Khaldi [Thu, 18 Jan 2018 23:01:06 +0000 (00:01 +0100)]
[ATL][ATL80][ATL100] Sync with Wine 3.0. CORE-14225
Amine Khaldi [Thu, 18 Jan 2018 23:00:10 +0000 (00:00 +0100)]
[INCLUDE/WINE] Update atlbase.h. CORE-14225
Amine Khaldi [Thu, 18 Jan 2018 22:52:46 +0000 (23:52 +0100)]
[COMDLG32] Sync with Wine 3.0. CORE-14225
Amine Khaldi [Thu, 18 Jan 2018 22:49:50 +0000 (23:49 +0100)]
[COMCTL32_WINETEST] Sync with Wine 3.0. CORE-14225
Amine Khaldi [Thu, 18 Jan 2018 22:49:20 +0000 (23:49 +0100)]
[COMCTL32] Sync with Wine 3.0. CORE-14225
Amine Khaldi [Thu, 18 Jan 2018 22:37:48 +0000 (23:37 +0100)]
[PSDK] Update commctrl.h. CORE-14225
Amine Khaldi [Thu, 18 Jan 2018 12:34:21 +0000 (13:34 +0100)]
[FREETYPE] Update to v2.9.0 and use this as a chance to slim down our lib a bit. CORE-14220
David Quintana [Wed, 17 Jan 2018 23:21:14 +0000 (00:21 +0100)]
[EXPLORER] Fix the code that requests the taskbar to recalculate the size,
after an icon is removed due to missing owner. Also cleaned up the other case.
David Quintana [Tue, 16 Jan 2018 21:11:14 +0000 (22:11 +0100)]
[EXPLORER] Fix some issues with the notification area code,
and implement NIS_SHAREDICON while at it.
Colin Finck [Wed, 17 Jan 2018 11:52:12 +0000 (12:52 +0100)]
[PRINTING] Replace all my custom marshalling code by calls to the newly implemented APIs, thereby significantly reducing the codebase and providing a sane template to implement more Printing APIs.
Colin Finck [Wed, 17 Jan 2018 09:55:02 +0000 (10:55 +0100)]
[PRINTING] Try to fix Linux build #2
Colin Finck [Wed, 17 Jan 2018 09:41:55 +0000 (10:41 +0100)]
[PRINTING] Try to fix Linux build.
Why this previously built without any errors using GCC and MSVC under Windows is left as an exercise to the reader.
Colin Finck [Wed, 17 Jan 2018 09:13:25 +0000 (10:13 +0100)]
[PRINTING] Implement the undocumented MarshallDownStructure, MarshallDownStructuresArray, MarshallUpStructure, and MarshallUpStructuresArray to the extent I need and could find out through black-box testing.
PDBs reveal that these functions are also used in winspool.drv, but not imported from spoolss.dll to retain the client/server architecture.
As winspool.drv highly benefits from the MarshallUp* functions, I put them in a source file shared between spoolss.dll and winspool.drv.
The added API Tests cover my testing and all implemented features.
One more item done from https://reactos.org/wiki/Printing !
Thomas Faber [Tue, 16 Jan 2018 21:10:22 +0000 (22:10 +0100)]
[NTOS:MM] Fix broken ASSERT. CID 701285
Giannis Adamopoulos [Tue, 16 Jan 2018 09:43:28 +0000 (11:43 +0200)]
[EXPLORER] CTrayBandSite: Call DBID_SETWINDOWTHEME on new bands to make them use the theme of the taskbar. CORE-14176
Giannis Adamopoulos [Tue, 16 Jan 2018 09:36:34 +0000 (11:36 +0200)]
[BROWSEUI] CISFBand: Handle DBID_SETWINDOWTHEME. CORE-14176
Pierre Schweitzer [Mon, 15 Jan 2018 22:20:53 +0000 (23:20 +0100)]
[NTOSKRNL] Implement CcIsThereDirtyData()
Mark Jansen [Sat, 13 Jan 2018 23:57:56 +0000 (00:57 +0100)]
[KERNEL32] Add version info to VerifyVersionInfo mismatch print.
Giannis Adamopoulos [Fri, 12 Jan 2018 16:52:08 +0000 (18:52 +0200)]
[UXTHEME] -Pass a non 0 wParam when themes get enabled and 0 when they get disabled
Giannis Adamopoulos [Fri, 12 Jan 2018 16:49:09 +0000 (18:49 +0200)]
[COMCTL32] rebar: Remove some hacks and fix checking for transparent background
Giannis Adamopoulos [Mon, 15 Jan 2018 10:45:41 +0000 (12:45 +0200)]
[USER32] InternalGetWindowText: Write to caller's buffer only when one was provided. CORE-13614
Giannis Adamopoulos [Mon, 15 Jan 2018 10:36:45 +0000 (12:36 +0200)]
[USER32] Stop hiding exceptions left and right
Joachim Henze [Sun, 14 Jan 2018 12:54:30 +0000 (13:54 +0100)]
[SYSDM] Fix text truncation for ru-RU CORE-13845
Timo Kreuzer [Mon, 1 Jan 2018 14:24:05 +0000 (15:24 +0100)]
[NTOS] Fix 64 bit warnings
Joachim Henze [Sun, 14 Jan 2018 12:52:34 +0000 (13:52 +0100)]
[DESK] Fix text truncation for ru-RU CORE-13845
Mark Jansen [Thu, 28 Dec 2017 22:19:52 +0000 (23:19 +0100)]
[PSDK][ACTXPROXY] Add IExplorerCommand and related classes (Vista+)
Pierre Schweitzer [Sat, 13 Jan 2018 20:27:29 +0000 (21:27 +0100)]
[NTOSKRNL] When mapping data in CcMapData(), don't truncate offset to ULONG.
This would affect reads/writes on large volumes where offset is higher than what a ULONG can hold.
This really nasty bug was hitting CcMapData() but also CcPinRead() (due to the nature of its implementation)
and both were returning garbage data under certain circumstances with Ext2Fsd.
This should (I hope!) help some other FSDs to work better in ROS.
CORE-12456
Mark Jansen [Sat, 13 Jan 2018 19:57:04 +0000 (20:57 +0100)]
[BROWSEUI] Do not clear a CComPtr with memset.
Giannis Adamopoulos [Sat, 13 Jan 2018 19:27:57 +0000 (21:27 +0200)]
[SHELL32] CDrivesFolder: Fix showing the drive capacity. CORE-14201
Giannis Adamopoulos [Sat, 13 Jan 2018 19:14:16 +0000 (21:14 +0200)]
[EXPLORER] Winkey + E shortcut should open "My Computer" instead of "My documents" CORE-14199
Giannis Adamopoulos [Sat, 13 Jan 2018 14:19:27 +0000 (16:19 +0200)]
[COMCTL32] toolbar: Use the theme text color for the dropdown arrows. CORE-13855
Giannis Adamopoulos [Sat, 13 Jan 2018 12:57:24 +0000 (14:57 +0200)]
[SHELL32] CMenuBand: Redraw the toolbars if this is the menu bar of a window and its active state changed. Use COLOR_GRAYTEXT for the text of the inactive menu bar items. CORE-14197
Amine Khaldi [Fri, 12 Jan 2018 20:09:58 +0000 (21:09 +0100)]
[USBOHCI_NEW] Bring-in the USB OHCI miniport driver created by Vadim Galyant. (#244)
[USBOHCI_NEW] Add the new usbport-based OHCI driver.
Serge Gautherie [Sun, 7 Jan 2018 14:07:22 +0000 (15:07 +0100)]
[DRWTSN32] Update output string copypasta from #268
168223aeb88f5503dedc60b982a1ba80d972703d.
Giannis Adamopoulos [Wed, 10 Jan 2018 21:29:20 +0000 (23:29 +0200)]
[COMCTL32] -toolbar: Improve drawing diabled text with themes. CORE-13855
Vadim Galyant [Wed, 10 Jan 2018 17:58:44 +0000 (18:58 +0100)]
[USBPORT] In USBHI_GetExtendedHubInformation, pass the correct port index to RH_GetPortStatus.
Vadim Galyant [Sat, 6 Jan 2018 03:48:37 +0000 (12:48 +0900)]
[USBHUB] Move DPRINT after check Status.
Vadim Galyant [Sat, 6 Jan 2018 03:55:09 +0000 (12:55 +0900)]
[USBHUB] Correcting L"USB\\Vid_0000&Pid_0000" for case BusQueryDeviceID in USBH_PdoQueryId() if INIT_PORT_FAILED.
Giannis Adamopoulos [Wed, 10 Jan 2018 13:52:42 +0000 (15:52 +0200)]
[COMCTL32] status: Use DrawThemeText when drawing text with themes. CORE-13855
Giannis Adamopoulos [Wed, 10 Jan 2018 11:42:53 +0000 (13:42 +0200)]
[COMCTL32] rebar: Use DrawThemeText when drawing text with themes. CORE-13855
Thomas Faber [Sat, 6 Jan 2018 17:11:18 +0000 (18:11 +0100)]
[MSAFD] Avoid magic numbers in NtCreateEvent calls.
Thomas Faber [Mon, 8 Jan 2018 12:58:20 +0000 (13:58 +0100)]
[TCPIP] Fix buffer sizes in ReadIpConfiguration.
Thomas Faber [Mon, 8 Jan 2018 12:51:04 +0000 (13:51 +0100)]
[TCPIP] Check for allocation failures in ReadIpConfiguration. CID
1411924
Colin Finck [Wed, 10 Jan 2018 08:24:22 +0000 (09:24 +0100)]
[KERNEL32] Accept all images for NT 3.1 and higher instead of bailing out at image versions > 5.01 (#273)
Print a debug message whenever an application newer than ReactOS' internal NT version is started.
This gets a simple "Hello World" compiled by VS' 2017 regular "v141" toolchain to run under ReactOS.
Please retry NT6+ applications!
Mark Jansen [Tue, 29 Aug 2017 20:21:58 +0000 (22:21 +0200)]
[SHIMENG] Mark modified dll's as visited, and apply shims to newly loaded dlls
Mark Jansen [Sun, 7 Jan 2018 20:52:13 +0000 (21:52 +0100)]
[APPHELP] Try Dos and Nt path formats in SdbGetFileAttributes.
Andreas Maier [Thu, 4 Jan 2018 11:15:38 +0000 (12:15 +0100)]
[SETUPAPI]: Fix a FIXME in SetupDiSetDeviceRegistryPropertyA.
Rename SetupDiSetDeviceRegistryPropertyW to IntSetupDiSetDeviceRegistryPropertyAW and use it for both (A/W).
The FIXME in the A-Version was already implemented in the W-Version.
CORE-14173.
Mark Jansen [Mon, 8 Jan 2018 20:18:30 +0000 (21:18 +0100)]
[NTOS] Limit the spam from NtNotifyChangeMultipleKeys.
CORE-13125
Mark Jansen [Mon, 8 Jan 2018 20:06:23 +0000 (21:06 +0100)]
[SDK] Add UNIMPLEMENTED_ONCE macro, to be used for functions that spam.
Colin Finck [Mon, 8 Jan 2018 17:04:50 +0000 (18:04 +0100)]
[RAPPS] Remove the RAPPS database from the main source tree. It will now be maintained in the new repository https://github.com/reactos/rapps-db
As a bonus, the public database at https://svn.reactos.org/packages/rappmgr.cab is now automatically updated with every commit to that repository.
Thanks to Alexander Shaposhnikov for the idea and help!
Katayama Hirofumi MZ [Mon, 8 Jan 2018 15:24:31 +0000 (00:24 +0900)]
[USETUP] Improve muifonts.h and add a SimHei font substitution entry (#272)
Thomas Faber [Mon, 8 Jan 2018 08:50:56 +0000 (09:50 +0100)]
[ADVAPI32] Fix non-PCH build.
Mark Jansen [Sat, 6 Jan 2018 19:48:21 +0000 (20:48 +0100)]
[ADVAPI32] Stub OpenTrace and ProcessTrace so newer versions of ProcessExplorer start again.
CORE-10312
Mark Jansen [Sat, 6 Jan 2018 20:09:51 +0000 (21:09 +0100)]
[PSDK] Fix definition of INVALID_PROCESSTRACE_HANDLE as suggested by Thomas.
#267
Erdem Ersoy [Sun, 7 Jan 2018 21:09:42 +0000 (21:09 +0000)]
[TRANSLATIONS] Update the email address and add a note in the Turkish translation document (#271)
jimtabor [Sun, 7 Jan 2018 20:47:42 +0000 (14:47 -0600)]
[RichEd20] Fix structure by adding missing byte, see CORE-8452.
Update version, tell wine.
This fixes "Assertion failed: style->cbSize == sizeof(CHARFORMAT2W)".
Serge Gautherie [Sun, 7 Jan 2018 14:07:22 +0000 (15:07 +0100)]
[FASTFAT] Improve code style in addition to
8294118174b28a10daec3f763d8b5ab64104d1fa.
Joachim Henze [Sun, 7 Jan 2018 16:58:47 +0000 (17:58 +0100)]
[WIN32K] revert PR173 to fix regressions in Chrome/Chromium CORE-14170
This reverts
ea4daf8b6873cd6256c45ac1c6b7cfea2e58b340 committed 2017-12-09 to master, the commit was named
"[WIN32K] Fix NtGdiGetTextFaceW to report face name correctly (#173)",
reverting got ack of khmz,
reopening less severe CORE-14071 accordingly
Pierre Schweitzer [Sun, 7 Jan 2018 14:29:33 +0000 (15:29 +0100)]
[FASTFAT] Notify on file size change in FileAllocationInformation/FileEndOfFileInformation
Pierre Schweitzer [Sun, 7 Jan 2018 13:16:11 +0000 (14:16 +0100)]
[FASTFAT] Add a wrapper around FsRtlNotifyFullReportChange
Timo Kreuzer [Sun, 7 Jan 2018 11:03:44 +0000 (12:03 +0100)]
[DRWTSN32] Fix amd64 build
Pierre Schweitzer [Sun, 7 Jan 2018 10:44:25 +0000 (11:44 +0100)]
[FASTFAT] When a file gets overwritten, notify about the changes
Pierre Schweitzer [Sun, 7 Jan 2018 10:34:41 +0000 (11:34 +0100)]
[FASTFAT] When overwriting a file, also update its write time
Pierre Schweitzer [Sat, 6 Jan 2018 21:02:10 +0000 (22:02 +0100)]
[FASTFAT] When dealing with attributes on IRP_MJ_CREATE, filter user input to ensure we have only attributes we can handle.
This applies to files newly created, or for files overwritten where attributes are reset/modified.
Pierre Schweitzer [Sat, 6 Jan 2018 20:39:25 +0000 (21:39 +0100)]
[NTFS] Apply fix from
52f0726: allow partial info copy on dir enumeration on first entry return.
This is assorted with misc fixes to make this code closer to what we currently have in FastFAT.
This also allows fixing a memory leak in case of single entry return.
CORE-13367
Timo Kreuzer [Mon, 1 Jan 2018 21:40:43 +0000 (22:40 +0100)]
[NTOS:MM] Pass FaultCode to MiDispatchFault
Timo Kreuzer [Tue, 2 Jan 2018 10:31:37 +0000 (11:31 +0100)]
[NTOS:MM] Mark local functions with static
Timo Kreuzer [Tue, 2 Jan 2018 10:22:22 +0000 (11:22 +0100)]
[NTOS:MM] Add support for NX page-faults
Timo Kreuzer [Mon, 1 Jan 2018 22:03:56 +0000 (23:03 +0100)]
[NTOS:MM] Make use of FaultCode and MI_IS_NOT_PRESENT_FAULT and MI_IS_WRITE_ACCESS macros in MmArmAccessFault.
Timo Kreuzer [Mon, 1 Jan 2018 21:52:37 +0000 (22:52 +0100)]
[NTOS:MM] Pass The FaultCode to MmArmAcceessFault as well and translate it there to what was declared as "StoreInstruction"
No functional changes.
Timo Kreuzer [Mon, 1 Jan 2018 14:25:45 +0000 (15:25 +0100)]
[NTOS:MM] Pass page fault code to MmAccessFault
Note: before we had a BOOLEAN parameter called StoreInstruction, but in reality it was not specifying whether the fault was from a store store instruction, but whether it was an access violation rather than a page-not-present fault. On x86 without PAE there are only 2 kinds of access violations: (1) Access of a kernel mode page from user mode, which is handled early and (2) access of a read-only (or COW) page with a writing instruction. Therefore we could get away with this, even though it relied on the wrong assumption that a fault, which was not a page-not-present-fault, was automatically a write access. This commit only changes one thing: we pass the full fault-code to MmAccessFault and handle the rest from there in exactly the same way as before. More changes are coming to make things clear.
Luo Yufan [Sat, 6 Jan 2018 17:05:07 +0000 (01:05 +0800)]
[TRANSLATION] Update Simplified Chinese translations and font settings. (#266)
Timo Kreuzer [Thu, 4 Jan 2018 18:23:47 +0000 (19:23 +0100)]
[NDK] Fix some ob types (64 bit)
Timo Kreuzer [Thu, 4 Jan 2018 17:29:11 +0000 (18:29 +0100)]
! Fix build of tracert
# Conflicts:
# sdk/include/psdk/ipexport.h
Pierre Schweitzer [Sat, 6 Jan 2018 12:54:21 +0000 (13:54 +0100)]
[FLTMGR] Properly allocate CCB in CreatePortCCB()
CID
1427031
Colin Finck [Sat, 6 Jan 2018 12:27:41 +0000 (13:27 +0100)]
[NTOS:CM] Improve code in cmsysini.c (#216)
Based on an original patch by Timo Kreuzer, with modifications by me to adapt it to latest HEAD and use a single exit path through the Cleanup label. This reliably frees all allocated handles.
The original code returns STATUS_SUCCESS for many cases. This has been preserved.
In the future, it should be checked though whether returning success is appropriate for all these cases.
CORE-6844
Pierre Schweitzer [Sat, 6 Jan 2018 11:11:02 +0000 (12:11 +0100)]
[USETUP] When opening the target file for dropping readonly mode only use required access.
This avoids the open failing on certain file systems where GENERIC_WRITE access would be denied
for a readonly file.
This is an addendum to
82f44a2.
CORE-14158
Mark Jansen [Sat, 6 Jan 2018 10:47:54 +0000 (11:47 +0100)]
[DRWTSN32] Implement basic crash report functionality
On application crash, drwtsn32 will attach to the application and try to get a dump, consisting of:
- List of loaded modules
- List of loaded threads
- Per thread, a stacktrace
- Per thread, a small hexdump from the stack
- Per thread, a dump of the most common registers
This dump is saved to the desktop, and the user is notified of the dump being dropped there.
CORE-14180
#145
Luo Yufan [Fri, 5 Jan 2018 13:15:03 +0000 (21:15 +0800)]
[TRANSLATION] Improve Simplified Chinese Translations (#265)
* Update Simplified Chinese translation of SYSSETUP
* Update Simplified Chinese translations and font settings.
* Update Translation of SHELL32.
Giannis Adamopoulos [Fri, 5 Jan 2018 09:53:35 +0000 (11:53 +0200)]
[SHELL32] CMenuToolbarBase: Use COLOR_MENUTEXT color for the text color in normal menu items. CORE-13855
Giannis Adamopoulos [Thu, 4 Jan 2018 21:25:37 +0000 (23:25 +0200)]
[COMCTL32] tab: Use DrawThemeText when drawing text with themes. CORE-13855
Pierre Schweitzer [Thu, 4 Jan 2018 20:47:59 +0000 (21:47 +0100)]
[USETUP] When overwriting a file, if open fails, it might be because the file is readonly.
In such situation, try to drop the readonly attribute before overwritting the file.
This fixes setup not being able to overwrite FAT bootcode when reusing a FAT partition
already installed without reformatting.
CORE-14158
Timo Kreuzer [Sun, 22 Oct 2017 08:57:40 +0000 (10:57 +0200)]
[NTOS:EX] Don't dereference ExpCritSecOutOfMemoryEvent when it was never referenced.
David Quintana [Thu, 4 Jan 2018 18:15:06 +0000 (19:15 +0100)]
[PSDK] Change #if to #ifdef, to be more consistent with the majority of our codebase.
David Quintana [Thu, 4 Jan 2018 17:21:16 +0000 (18:21 +0100)]
[PSDK] Add ICMP_ECHO_REPLY32 needed by 64-bit code. Fixes x64 build of tracert.
Giannis Adamopoulos [Thu, 4 Jan 2018 12:30:47 +0000 (14:30 +0200)]
[COMCTL32] toolbar: Draw checked and not hot buttons as checked, not hot. CORE-13592
Should be sent to wine.
Katayama Hirofumi MZ [Thu, 4 Jan 2018 10:00:36 +0000 (19:00 +0900)]
[NTOS:KDBG] Fix DPRINT format specifier in KdPortInitializeEx. CORE-14174
Timo Kreuzer [Wed, 27 Dec 2017 14:20:52 +0000 (15:20 +0100)]
[NTOS:MM] Use MiResolveDemandZeroFault instead of MiDispatchFault
Timo Kreuzer [Wed, 27 Dec 2017 16:18:00 +0000 (17:18 +0100)]
[NTOS:MM] Implement resolving PXE/PPE page table demand zero faults
Timo Kreuzer [Wed, 27 Dec 2017 14:09:39 +0000 (15:09 +0100)]
[NTOS:MM] Increment Prcb->MmDemandZeroCount while holding the Pfn lock
Timo Kreuzer [Tue, 1 Nov 2011 21:03:00 +0000 (22:03 +0100)]
[NTOS/MM] Add Protection parameter to MiResolveDemandZeroFault
Bișoc George [Wed, 3 Jan 2018 20:29:44 +0000 (21:29 +0100)]
[DLL][WIN32][NEWDEV] Wrong character in the Romanian translation removed (#259)
Replaced "ú" with "u". Is that letter even a thing? :D
Stanislav Motylkov [Wed, 3 Jan 2018 20:24:26 +0000 (23:24 +0300)]
[SYSSETUP] Add marquee progress bar to show setup is alive (#262)
CORE-14163 #resolve
Bișoc George [Wed, 3 Jan 2018 09:25:25 +0000 (10:25 +0100)]
[RAPPS] Romanian translation update
Quick update covering the latest commit - CORE-13789.
Bișoc George [Wed, 3 Jan 2018 09:23:51 +0000 (10:23 +0100)]
[RAPPS] Italian translation update
Quick-update covering the latest commit - CORE-13789.
Joachim Henze [Wed, 3 Jan 2018 08:48:31 +0000 (09:48 +0100)]
[RAPPS] update translation de-DE.rc for CORE-13789
Alexander Shaposhnikov [Tue, 2 Jan 2018 20:45:59 +0000 (22:45 +0200)]
[RAPPS] Make selection global
- Added a 'Selected for installation' category that shows what was selected.
Selection is now kept between categories.
- New string is added to resources.
ru-RU.rc and uk-UA.rc strings are translated.
CORE-13789
Pierre Schweitzer [Wed, 3 Jan 2018 07:47:36 +0000 (08:47 +0100)]
[DISKPART] Don't crash on input if user provided no command
CORE-14018
Hermes Belusca-Maito [Wed, 27 Dec 2017 16:14:02 +0000 (17:14 +0100)]
[NTOS:INBV] Simplify a little bit the BootLogoFadeIn() function
- Use KeDelayExecutionThread() instead of KeStallExecutionProcessor().
- Fix magic values and add comments.
- Fix structure name.
Stanislav Motylkov [Thu, 14 Dec 2017 12:49:15 +0000 (15:49 +0300)]
[NTOS:INBV] Implement rotation bar for boot screen
CORE-10327 #resolve