reactos.git
8 years ago[KMTESTS:IO]
Pierre Schweitzer [Tue, 22 Sep 2015 22:31:08 +0000 (22:31 +0000)]
[KMTESTS:IO]
Extend the IoCreateFile tests with two parts tests.
First part properly checks for opening/reparse handling on mount points (and ideally on symlinks, see below).
The other part checks for proper handling of the IO_STOP_ON_SYMLINK parameter.

Regarding symlink, I'm clearly not convinced that what I did is correct (hence the failure on both W2K3 & ROS). It seems to me that symlink resolution is up to the FSD and not to IO which only handles mount point traversal.
If someone (Alex?) can confirm/infirm and give more insight, that's more than welcome.

svn path=/trunk/; revision=69322

8 years ago[DEVMGR]
Ged Murphy [Tue, 22 Sep 2015 21:44:19 +0000 (21:44 +0000)]
[DEVMGR]
- A few cmake fixes

svn path=/trunk/; revision=69321

8 years ago[DEVMGR]
Ged Murphy [Tue, 22 Sep 2015 18:23:03 +0000 (18:23 +0000)]
[DEVMGR]
- Build the properties as C++
- Rearrange the folder structure
- The whole thing now builds and runs from VS (with a few hacks). CMake next

svn path=/trunk/; revision=69320

8 years ago[SHELL32]
Giannis Adamopoulos [Tue, 22 Sep 2015 18:11:32 +0000 (18:11 +0000)]
[SHELL32]
- Add a helper HCR_GetClassName function to load the name of a reg folder to a STRRET
- Further simplify CAdminToolsFolder, CFontsFolder and CMyDocsFolder

svn path=/trunk/; revision=69319

8 years ago[KMTESTS:MM]
Pierre Schweitzer [Tue, 22 Sep 2015 18:05:45 +0000 (18:05 +0000)]
[KMTESTS:MM]
MmAllocatePagesForMdlEx() was added on Windows 2003 SP1. Import it for "older" systems.

svn path=/trunk/; revision=69318

8 years ago[CLUSAPI] Order the exports and make sure the list matches our target (Windows Server...
Amine Khaldi [Tue, 22 Sep 2015 17:19:14 +0000 (17:19 +0000)]
[CLUSAPI] Order the exports and make sure the list matches our target (Windows Server 2003 Sp2). By Radek Liška, confirmed by me. CORE-8174

svn path=/trunk/; revision=69317

8 years ago[CARDS] Order the exports and make sure the list matches our target (Windows Server...
Amine Khaldi [Tue, 22 Sep 2015 17:15:37 +0000 (17:15 +0000)]
[CARDS] Order the exports and make sure the list matches our target (Windows Server 2003 Sp2). By Radek Liška, confirmed by me. CORE-8174

svn path=/trunk/; revision=69316

8 years ago[BATT] Order the exports and make sure the list matches our target (Windows Server...
Amine Khaldi [Tue, 22 Sep 2015 17:08:38 +0000 (17:08 +0000)]
[BATT] Order the exports and make sure the list matches our target (Windows Server 2003 Sp2). By Radek Liška, confirmed by me. CORE-8174

svn path=/trunk/; revision=69315

8 years ago[CPLS] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114
Amine Khaldi [Tue, 22 Sep 2015 17:04:32 +0000 (17:04 +0000)]
[CPLS] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114

svn path=/trunk/; revision=69314

8 years ago[RosApps|WineFile]
James Tabor [Tue, 22 Sep 2015 00:40:19 +0000 (00:40 +0000)]
[RosApps|WineFile]
Patch by Jared Smudde - Sync wine File with wine. See ROSAPPS-302.

svn path=/trunk/; revision=69313

8 years ago[Win32SS]
James Tabor [Tue, 22 Sep 2015 00:38:48 +0000 (00:38 +0000)]
[Win32SS]
- Fix MDI menu redraw. Tested with WineFile.

svn path=/trunk/; revision=69312

8 years ago[MOUNTMGR]
Pierre Schweitzer [Mon, 21 Sep 2015 19:11:06 +0000 (19:11 +0000)]
[MOUNTMGR]
While we're at calling IoCreateFile, skip parameters checking, we know our parameters are alright.

svn path=/trunk/; revision=69311

8 years ago[MOUNTMGR]
Pierre Schweitzer [Mon, 21 Sep 2015 16:49:49 +0000 (16:49 +0000)]
[MOUNTMGR]
MagicValue--;

svn path=/trunk/; revision=69310

8 years ago[INTL]
Eric Kohl [Sun, 20 Sep 2015 19:34:51 +0000 (19:34 +0000)]
[INTL]
Implement a save routine for the GeoID. Stores the current GeoID in the default user profile too, if required.
CORE-10172 #resolve

svn path=/trunk/; revision=69309

8 years ago[INTL]
Eric Kohl [Sun, 20 Sep 2015 19:00:10 +0000 (19:00 +0000)]
[INTL]
- Unicodify the CPL. Get rid of <tchar.h>.
- Pass a pointer to all getter and setter functions of the customization property sheet pages.
- Remove the "Property of" text from the property sheets.
- Convert "SendMessage(GetDlgItem(..." to "SendDlgItemMessage(...".

svn path=/trunk/; revision=69308

8 years ago[NTDLL_APITESTS]
Pierre Schweitzer [Sun, 20 Sep 2015 17:51:41 +0000 (17:51 +0000)]
[NTDLL_APITESTS]
Add more tests

svn path=/trunk/; revision=69307

8 years ago[SHELL32] Add missing DS_MODALFRAME style to extended properties dialog. Patch by...
Robert Naumann [Sun, 20 Sep 2015 16:25:39 +0000 (16:25 +0000)]
[SHELL32] Add missing DS_MODALFRAME style to extended properties dialog. Patch by Jared Smudde CORE-10219

svn path=/trunk/; revision=69306

8 years ago[NTDLL_APITESTS]
Pierre Schweitzer [Sun, 20 Sep 2015 14:04:48 +0000 (14:04 +0000)]
[NTDLL_APITESTS]
Properly init string length

svn path=/trunk/; revision=69305

8 years ago[NTDLL_APITESTS]
Pierre Schweitzer [Sun, 20 Sep 2015 13:32:34 +0000 (13:32 +0000)]
[NTDLL_APITESTS]
Add more tests

svn path=/trunk/; revision=69304

8 years ago[NTDLL_APITESTS]
Pierre Schweitzer [Sun, 20 Sep 2015 10:42:05 +0000 (10:42 +0000)]
[NTDLL_APITESTS]
Add a few tests for RtlGenerate8dot3Name()

svn path=/trunk/; revision=69303

8 years ago[HAL]
Thomas Faber [Sun, 20 Sep 2015 09:45:59 +0000 (09:45 +0000)]
[HAL]
- Print a message if EISA DMA support is detected. Detection should probably not even be attempted unless the machine supports EISA; the print will show whether that's correct.
CORE-9895

svn path=/trunk/; revision=69302

8 years ago[IDL]
Thomas Faber [Sun, 20 Sep 2015 06:21:41 +0000 (06:21 +0000)]
[IDL]
- ms-dtyp.idl doesn't need UNICODE_STRING

svn path=/trunk/; revision=69301

8 years ago[KMTESTS:KE]
Thomas Faber [Sat, 19 Sep 2015 23:59:02 +0000 (23:59 +0000)]
[KMTESTS:KE]
- Add tests for acquiring mutants recursively
CORE-10218

svn path=/trunk/; revision=69300

8 years ago[NTVDM]
Aleksandar Andrejevic [Sat, 19 Sep 2015 22:42:13 +0000 (22:42 +0000)]
[NTVDM]
Also save and restore the registers around other mouse callbacks
and the DOS driver routine calls.

svn path=/trunk/; revision=69299

8 years ago[NTVDM]
Aleksandar Andrejevic [Sat, 19 Sep 2015 22:29:45 +0000 (22:29 +0000)]
[NTVDM]
Save and restore BP, DS and ES when calling the mouse callback.

svn path=/trunk/; revision=69298

8 years ago[NTVDM]
Aleksandar Andrejevic [Sat, 19 Sep 2015 22:12:56 +0000 (22:12 +0000)]
[NTVDM]
Save and restore the general purpose and segment registers around Int32Call
calls in the BIOS. Also, make sure CF doesn't get set by the called interrupt
procedure.

svn path=/trunk/; revision=69297

8 years ago[KMTESTS]
Thomas Faber [Sat, 19 Sep 2015 21:46:40 +0000 (21:46 +0000)]
[KMTESTS]
- Add missing OBJ_KERNEL_HANDLE
- OBJ_KERNEL_HANDLE in user mode has no effect... no reason to make a define around it
CORE-10207

svn path=/trunk/; revision=69296

8 years ago[MOUNTMGR]
Pierre Schweitzer [Sat, 19 Sep 2015 21:23:45 +0000 (21:23 +0000)]
[MOUNTMGR]
Fix CVE-2015-1769:
- When opening remote databases, don't attempt to migrate w2k database to current format.
- Also, when opening/creating the remote database, don't allow following symlinks anymore.
In case a symlink would be detected, an error message will be printed.

Commit dedicated to Alex :-).

CORE-10216 #resolve #comment Fixed with r69295

svn path=/trunk/; revision=69295

8 years ago[BLUE][RTL][VIDEOPRT]
Thomas Faber [Sat, 19 Sep 2015 21:10:11 +0000 (21:10 +0000)]
[BLUE][RTL][VIDEOPRT]
- Add missing OBJ_KERNEL_HANDLE
CORE-10207

svn path=/trunk/; revision=69294

8 years ago[PSDK]
Pierre Schweitzer [Sat, 19 Sep 2015 20:51:20 +0000 (20:51 +0000)]
[PSDK]
Define STATUS_STOPPED_ON_SYMLINK

svn path=/trunk/; revision=69293

8 years ago[MOUNTMGR]
Pierre Schweitzer [Sat, 19 Sep 2015 20:37:09 +0000 (20:37 +0000)]
[MOUNTMGR]
Implement ReconcileThisDatabaseWithMasterWorker() which was the last missing bit of our MountMgr :-)

svn path=/trunk/; revision=69292

8 years ago[MOUNTMGR]
Pierre Schweitzer [Sat, 19 Sep 2015 14:50:04 +0000 (14:50 +0000)]
[MOUNTMGR]
Our ReconcileThisDatabaseWithMasterWorker() routine will expect two parameters: the device extension + the device to which reconcile remote database.
So, fix our code accordingly

svn path=/trunk/; revision=69291

8 years ago[WIN32SS} So ehm DBG is always defined to 0 or 1 (unless one messes around with it...
Stefan Ginsberg [Sat, 19 Sep 2015 14:25:52 +0000 (14:25 +0000)]
[WIN32SS} So ehm DBG is always defined to 0 or 1 (unless one messes around with it, like in Uniata...) so consistently check with #if and not #ifdef or else debug code gets in the free build.

svn path=/trunk/; revision=69290

8 years ago[MOUNTMGR]
Pierre Schweitzer [Sat, 19 Sep 2015 14:16:06 +0000 (14:16 +0000)]
[MOUNTMGR]
Include ntdddisk.h

svn path=/trunk/; revision=69289

8 years ago[PSDK]
Pierre Schweitzer [Sat, 19 Sep 2015 14:15:01 +0000 (14:15 +0000)]
[PSDK]
Add GPT attributes for PARTITION_BASIC_DATA_GUID partitions

svn path=/trunk/; revision=69288

8 years ago[NTVDM]: Fix usage of RtlCompareMemory.
Hermès Bélusca-Maïto [Sat, 19 Sep 2015 14:02:22 +0000 (14:02 +0000)]
[NTVDM]: Fix usage of RtlCompareMemory.

svn path=/trunk/; revision=69287

8 years ago[KD] Stub out the (new) unsupported KD API messages a bit more by adding 2 missing...
Stefan Ginsberg [Sat, 19 Sep 2015 13:58:08 +0000 (13:58 +0000)]
[KD] Stub out the (new) unsupported KD API messages a bit more by adding 2 missing ones, likely API names and associated structures. Thanks to Mark Jensen for finding out the structs.

svn path=/trunk/; revision=69286

8 years ago[CRT] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114
Amine Khaldi [Sat, 19 Sep 2015 13:50:57 +0000 (13:50 +0000)]
[CRT] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114

svn path=/trunk/; revision=69285

8 years ago[MOUNTMGR]
Pierre Schweitzer [Sat, 19 Sep 2015 13:03:41 +0000 (13:03 +0000)]
[MOUNTMGR]
Implement the IOCTL_MOUNTMGR_QUERY_DOS_VOLUME_PATHS:
- Implement MountMgrQueryVolumePaths()
- Implement MountMgrValidateBackPointer()
- Implement MountMgrQueryDosVolumePaths()
- Rename a struct var to reflect its real usage

svn path=/trunk/; revision=69284

8 years ago[KMTESTS:KE]
Thomas Faber [Sat, 19 Sep 2015 12:57:51 +0000 (12:57 +0000)]
[KMTESTS:KE]
- Add a small stress test for scheduling behavior after event set/wake
CORE-10212

svn path=/trunk/; revision=69283

8 years ago[KMTESTS:KE]
Thomas Faber [Sat, 19 Sep 2015 12:39:01 +0000 (12:39 +0000)]
[KMTESTS:KE]
- Make KeEvent test count constant to prevent it from appearing flaky in Testman

svn path=/trunk/; revision=69282

8 years ago[KMTESTS:KE]
Thomas Faber [Sat, 19 Sep 2015 12:15:16 +0000 (12:15 +0000)]
[KMTESTS:KE]
- Skip tests that assert on checked builds
- Avoid excessive stack usage
- Avoid some signed vs unsigned comparisons

svn path=/trunk/; revision=69281

8 years ago[INTL]
Eric Kohl [Sat, 19 Sep 2015 12:14:35 +0000 (12:14 +0000)]
[INTL]
Implement the "Apply all settings to the current user account and to the default user profile" feature.
CORE-10172

svn path=/trunk/; revision=69280

8 years ago[KMTESTS:KE]
Thomas Faber [Sat, 19 Sep 2015 11:27:18 +0000 (11:27 +0000)]
[KMTESTS:KE]
- Don't skip most of the KeEvent test on checked builds
- Don't try to run things at stupid IRQLs

svn path=/trunk/; revision=69279

8 years ago[AVIFIL32] Get back Dll{Register,Unregister}Server exports. They do not exist in...
Amine Khaldi [Fri, 18 Sep 2015 21:20:42 +0000 (21:20 +0000)]
[AVIFIL32] Get back Dll{Register,Unregister}Server exports. They do not exist in native but we need to register this dll. CORE-8174

svn path=/trunk/; revision=69278

8 years ago[NTOS:OB]
Thomas Faber [Fri, 18 Sep 2015 19:42:56 +0000 (19:42 +0000)]
[NTOS:OB]
- Improve DPRINT in NtWaitForMultipleObjects

svn path=/trunk/; revision=69277

8 years ago[AVIFIL32] Order the exports, remove some, correct AVIFileCreateStream redirection...
Amine Khaldi [Fri, 18 Sep 2015 19:40:16 +0000 (19:40 +0000)]
[AVIFIL32] Order the exports, remove some, correct AVIFileCreateStream redirection and make sure the list matches our target (Windows Server 2003 Sp2). By Radek Liška, confirmed and slightly changed by me. CORE-8174

svn path=/trunk/; revision=69276

8 years ago[AVICAP32] Order the exports and make sure the list matches our target (Windows Serve...
Amine Khaldi [Fri, 18 Sep 2015 19:31:37 +0000 (19:31 +0000)]
[AVICAP32] Order the exports and make sure the list matches our target (Windows Server 2003 Sp2). By Radek Liška, confirmed by me. CORE-8174

svn path=/trunk/; revision=69275

8 years ago[AUTHZ] Order the exports, remove some and make sure the list matches our target...
Amine Khaldi [Fri, 18 Sep 2015 19:22:26 +0000 (19:22 +0000)]
[AUTHZ] Order the exports, remove some and make sure the list matches our target (Windows Server 2003 Sp2). By Radek Liška, confirmed and slightly changed by me. CORE-8174

svn path=/trunk/; revision=69274

8 years ago[ADVPACK] Order the exports, add missing ones and make sure the list matches our...
Amine Khaldi [Fri, 18 Sep 2015 19:19:05 +0000 (19:19 +0000)]
[ADVPACK] Order the exports, add missing ones and make sure the list matches our target (Windows Server 2003 Sp2). By Radek Liška, confirmed and slightly changed by me. CORE-8174

svn path=/trunk/; revision=69273

8 years ago[ACTIVEDS] Order the exports, add missing ones and make sure the list matches our...
Amine Khaldi [Fri, 18 Sep 2015 18:43:17 +0000 (18:43 +0000)]
[ACTIVEDS] Order the exports, add missing ones and make sure the list matches our target (Windows Server 2003 Sp2). By Radek Liška, confirmed and slightly changed by me. CORE-8174

svn path=/trunk/; revision=69272

8 years ago[ACLUI] Order the exports and make sure the list matches our target (Windows Server...
Amine Khaldi [Fri, 18 Sep 2015 18:38:52 +0000 (18:38 +0000)]
[ACLUI] Order the exports and make sure the list matches our target (Windows Server 2003 Sp2). By Radek Liška, confirmed and slightly changed by me. CORE-8174

svn path=/trunk/; revision=69271

8 years ago[BASESRV][NTVDM][TESTVDD] Improve the FILE header section. Brought to you by Adam...
Amine Khaldi [Fri, 18 Sep 2015 17:01:49 +0000 (17:01 +0000)]
[BASESRV][NTVDM][TESTVDD] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114

svn path=/trunk/; revision=69270

8 years ago[NTOS]
Thomas Faber [Fri, 18 Sep 2015 14:22:12 +0000 (14:22 +0000)]
[NTOS]
- Add some missing OBJ_KERNEL_HANDLE
CORE-10207

svn path=/trunk/; revision=69269

8 years ago[NDISUIO]
Thomas Faber [Fri, 18 Sep 2015 13:33:05 +0000 (13:33 +0000)]
[NDISUIO]
- Improve NduNetPnPEvent. Patch by Jacob S. Preciado
CORE-10205 #resolve

svn path=/trunk/; revision=69268

8 years ago[NTOS:CM]
Thomas Faber [Fri, 18 Sep 2015 13:00:16 +0000 (13:00 +0000)]
[NTOS:CM]
- Fix SID mixup in CmpHiveRootSecurityDescriptor

svn path=/trunk/; revision=69267

8 years ago[NTOS:CM]
Thomas Faber [Fri, 18 Sep 2015 11:14:54 +0000 (11:14 +0000)]
[NTOS:CM]
- Actually use the allocated security descriptor in CmpCreateRegistryRoot

svn path=/trunk/; revision=69266

8 years ago[KMTESTS:CM]
Thomas Faber [Fri, 18 Sep 2015 11:06:11 +0000 (11:06 +0000)]
[KMTESTS:CM]
- Add a test for registry hive security descriptors

svn path=/trunk/; revision=69265

8 years ago[DISKPART][EXPLORER][LOGONUI][SMSS][USERINIT][WINLOGON] Improve the FILE header secti...
Amine Khaldi [Fri, 18 Sep 2015 10:13:50 +0000 (10:13 +0000)]
[DISKPART][EXPLORER][LOGONUI][SMSS][USERINIT][WINLOGON] Improve the FILE header section. Brought to you by Adam Stachowicz. CORE-10114

svn path=/trunk/; revision=69264

8 years ago[Win32k]
James Tabor [Fri, 18 Sep 2015 09:28:20 +0000 (09:28 +0000)]
[Win32k]
- Fix a activation drawing issue, if the window is not activated do not draw it active. Used testmenu program from CORE-1573 to test it. If this creates a new problem please open a Jira report.

svn path=/trunk/; revision=69263

8 years ago[NTOS:CM]
Thomas Faber [Fri, 18 Sep 2015 09:25:58 +0000 (09:25 +0000)]
[NTOS:CM]
- Improve pool tagging

svn path=/trunk/; revision=69262

8 years ago[NTVDM]
Hermès Bélusca-Maïto [Thu, 17 Sep 2015 23:04:05 +0000 (23:04 +0000)]
[NTVDM]
- Support loading executables with the old EXE signature ('ZM' instead of 'MZ').
- Fix the EXE loader so that:
  * we can load programs of >= 1Mb size, by exploiting the fact that on real DOS, the computed exe size (which uses the number of 512-byte blocks, stored in the EXE header) is stored in a WORD variable.
    This has as an effect to truncate the value, and if it is such that the truncated value is less than the size of available memory, the EXE can be loaded (partly, of course). Some apps expect this behaviour,
    for example, Turbo C++ IDE.
  * Simplify the memory limits computation, according to http://www.tavi.co.uk/phobos/exeformat.html , which is the correct algorithm used by DOS (and confirmed by FreeDOS also).

svn path=/trunk/; revision=69261

8 years ago[TRANSLATION]
Daniel Reimer [Thu, 17 Sep 2015 17:26:52 +0000 (17:26 +0000)]
[TRANSLATION]
Romanian resources maintenance by Ștefan Fulea
CORE-10042 #resolve #comment Committed, thx ^^

svn path=/trunk/; revision=69260

8 years ago[RTL] Add support for vectored continue handlers, complementing the vectored exceptio...
Stefan Ginsberg [Thu, 17 Sep 2015 13:36:55 +0000 (13:36 +0000)]
[RTL] Add support for vectored continue handlers, complementing the vectored exception handler support we already have, by doing some massive shared code usage: just use two different lists for the different handler types and all the code is basically the same. Call the "new" functionality from RtlDispatchException and stub it out for kernel mode. Clean up the existing code and simplify it. Passes the Winetests fine, not that they test this a a lot.

#CORE-10202

svn path=/trunk/; revision=69259

8 years ago[MSXML3] When renaming an icon identifier in the header, do it in the resource file...
Robert Naumann [Thu, 17 Sep 2015 05:23:29 +0000 (05:23 +0000)]
[MSXML3] When renaming an icon identifier in the header, do it in the resource file too CORE-10200

svn path=/trunk/; revision=69258

8 years ago[MSXML3][BOOTDATA] Add icons for XML and XSL files and use them. Patch by Jared Smudd...
Robert Naumann [Wed, 16 Sep 2015 21:45:48 +0000 (21:45 +0000)]
[MSXML3][BOOTDATA] Add icons for XML and XSL files and use them. Patch by Jared Smudde with some modifications by me. CORE-10133

svn path=/trunk/; revision=69257

8 years ago[SYSDM]
Eric Kohl [Wed, 16 Sep 2015 20:56:14 +0000 (20:56 +0000)]
[SYSDM]
Set the proper title for the hardware profile properties dialog.
CORE-10197 #resolve #comment Looks much better now!

svn path=/trunk/; revision=69256

8 years ago[NETSHELL] Change the icons to make network activity more visible. Icons by reactosfa...
Robert Naumann [Wed, 16 Sep 2015 18:20:40 +0000 (18:20 +0000)]
[NETSHELL] Change the icons to make network activity more visible. Icons by reactosfanboy. CORE-10031

svn path=/trunk/; revision=69255

8 years ago[UxTheme]
James Tabor [Wed, 16 Sep 2015 08:53:35 +0000 (08:53 +0000)]
[UxTheme]
- Fix uninitialized local variable context, MSVC Build. See CORE-9225.

svn path=/trunk/; revision=69254

8 years ago[UxTheme]
James Tabor [Wed, 16 Sep 2015 08:12:52 +0000 (08:12 +0000)]
[UxTheme]
- Fix user side GetScrollBarInfo. See CORE-9225.

svn path=/trunk/; revision=69253

8 years ago- Real fix MSVC build?
James Tabor [Wed, 16 Sep 2015 08:06:26 +0000 (08:06 +0000)]
- Real fix MSVC build?

svn path=/trunk/; revision=69252

8 years ago- Fix MSVC build?
James Tabor [Wed, 16 Sep 2015 07:55:42 +0000 (07:55 +0000)]
- Fix MSVC build?

svn path=/trunk/; revision=69251

8 years ago[User32]
James Tabor [Wed, 16 Sep 2015 07:13:03 +0000 (07:13 +0000)]
[User32]
- Fix return for SCROLLBARINFO RECT to use screen coordinates. See CORE-9225.

svn path=/trunk/; revision=69250

8 years ago[User32]
James Tabor [Wed, 16 Sep 2015 04:15:35 +0000 (04:15 +0000)]
[User32]
- Fix wine sync, Notify parent after capture is released, see CORE-10194.

svn path=/trunk/; revision=69249

8 years ago[HAL] Get rid off REGISTERCALL ("regparm(3)" for GCC) and replace with good old NTAPI...
Stefan Ginsberg [Tue, 15 Sep 2015 23:03:42 +0000 (23:03 +0000)]
[HAL] Get rid off REGISTERCALL ("regparm(3)" for GCC) and replace with good old NTAPI (stdcall). Such an obsession with avoiding stack usage is not healthy nor makes much sense today (or even a long time before today) with processors that have a decent L1 cache, whose "cost of access" is basically the same as to that of a register, and with processors being capable of recognising basic access patterns to ensure frequently used memory (read: stack) is in the cache. Slapping FASTCALL/regparm on frequently used code does not ensure it actually operates faster. You want to know what really hurts performance (and cache)? Slapping FORCEINLINE on everything like if it was some kind of asm macro, making code needlessly bloated.

svn path=/trunk/; revision=69248

8 years ago[SHELL33] fix a typo and the icon id's in recyclebin reg script. Now the icons are...
Robert Naumann [Tue, 15 Sep 2015 21:26:08 +0000 (21:26 +0000)]
[SHELL33] fix a typo and the icon id's in recyclebin reg script. Now the icons are correct again. CORE-10193

svn path=/trunk/; revision=69247

8 years ago[NTVDM]
Hermès Bélusca-Maïto [Tue, 15 Sep 2015 20:09:11 +0000 (20:09 +0000)]
[NTVDM]
Correctly call the device strategy/interrupt routines. Should fix a bunch of weird errors. This also fixes the NTVDM crash when Command&Conquer terminates, however it doesn't fix the DOS/4GW exception it encounters.
CORE-9678

svn path=/trunk/; revision=69246

8 years agouse the same file as 33.ico for 142.ico. should fix CORE-10193
Robert Naumann [Tue, 15 Sep 2015 19:56:53 +0000 (19:56 +0000)]
use the same file as 33.ico for 142.ico. should fix CORE-10193

svn path=/trunk/; revision=69245

8 years agoCompletely disable the debug register assertions in the trap exit code for KDBG as...
Stefan Ginsberg [Tue, 15 Sep 2015 17:55:14 +0000 (17:55 +0000)]
Completely disable the debug register assertions in the trap exit code for KDBG as it sets them improperly. These checks should not have been added for KDBG to begin with and would have made any usage of address breakpoints inside KDBG end up in a trap exit breakpoint. Whoever knows KDBG better than I do please investigate. However, enable the DR7 debug check for KD as it handles the debug registers just fine. The likelihood of loading a driver that modifies a debug register (which would be the only other thing triggering this) is pretty slim.

svn path=/trunk/; revision=69244

8 years ago[KMTESTS:MM]
Thomas Faber [Tue, 15 Sep 2015 16:46:28 +0000 (16:46 +0000)]
[KMTESTS:MM]
- Keep the number of tests constant in MmMdl because Testman

svn path=/trunk/; revision=69243

8 years agoFix a load of assumptions about default calling convention, a lot more remain.
Stefan Ginsberg [Tue, 15 Sep 2015 13:15:28 +0000 (13:15 +0000)]
Fix a load of assumptions about default calling convention, a lot more remain.

svn path=/trunk/; revision=69242

8 years ago[CMD]
Pierre Schweitzer [Tue, 15 Sep 2015 11:14:58 +0000 (11:14 +0000)]
[CMD]
- Fix a broken check
- Plug a memory leak

svn path=/trunk/; revision=69241

8 years ago[FREELDR] Fix a whole bunch of assumptions about default calling convention being...
Stefan Ginsberg [Tue, 15 Sep 2015 11:07:28 +0000 (11:07 +0000)]
[FREELDR] Fix a whole bunch of assumptions about default calling convention being cdecl, mostly in code called from/to assembly. Freeldr now links with /Gz (standard calling convention as stdcall), which is what this is all about

svn path=/trunk/; revision=69240

8 years agoFix unexpected side-effect of properly defining CDECL for CRT (how is gcc fine with...
Stefan Ginsberg [Tue, 15 Sep 2015 10:48:39 +0000 (10:48 +0000)]
Fix unexpected side-effect of properly defining CDECL for CRT (how is gcc fine with this?)

svn path=/trunk/; revision=69239

8 years agoSprinkle cdecl declarations liberally all around to make a bunch of the base componen...
Stefan Ginsberg [Tue, 15 Sep 2015 10:35:49 +0000 (10:35 +0000)]
Sprinkle cdecl declarations liberally all around to make a bunch of the base components compile (freeldr compiles but does not link yet). Some of these should really be NTAPI, working on that.

svn path=/trunk/; revision=69238

8 years ago[SHELL32] Add missing icons. Patch by Jared Smudde CORE-9938
Robert Naumann [Tue, 15 Sep 2015 10:28:01 +0000 (10:28 +0000)]
[SHELL32] Add missing icons. Patch by Jared Smudde CORE-9938

svn path=/trunk/; revision=69237

8 years ago[MSFS]
Thomas Faber [Tue, 15 Sep 2015 09:40:30 +0000 (09:40 +0000)]
[MSFS]
- Use a NULL timeout for infinite waits instead of waiting for 100 ns. CORE-10188 #resolve
- Wait for available read data in user mode to handle thread termination
- Return STATUS_IO_TIMEOUT also for a zero-length timeout. Fixes Wine tests
- Avoid MmGetSystemAddressForMdl
- Acquiring a mutex is not a UserRequest

svn path=/trunk/; revision=69236

8 years ago[NOTEPAD] Use the correct class name for Notepad. Now we use the same as Wine and...
Robert Naumann [Tue, 15 Sep 2015 07:26:09 +0000 (07:26 +0000)]
[NOTEPAD] Use the correct class name for Notepad. Now we use the same as Wine and Windows. Patch by Ricardo Hanke CORE-5629

svn path=/trunk/; revision=69235

8 years ago[ASM]
Hermès Bélusca-Maïto [Tue, 15 Sep 2015 01:59:14 +0000 (01:59 +0000)]
[ASM]
Fix the file header description. Consistently use .endm for closing a macro started with .macro.

[NTVDM]
- Add "_clean" targets to generated asm16 targets.
- Fix CMake dependency generation in a somewhat hackish way: I don't know how to cleanly specify the location of generated files for custom targets. And it is also hackish because in a CMake custom command which depends on the COMMAND.COM target, I also need to explicitely say that the command depends on the output file created by the COMMAND.COM target...
- Add COMMAND.COM to the CD files, even if NTVDM doesn't use an external command.com for now. CORE-5221

svn path=/trunk/; revision=69234

8 years ago[User32]
James Tabor [Tue, 15 Sep 2015 00:15:16 +0000 (00:15 +0000)]
[User32]
- Patch by Alex Henrie : Send BM_SETCHECK before WM_CAPTURECHANGED and add tests.

svn path=/trunk/; revision=69233

8 years ago[MOUNTMGR]
Pierre Schweitzer [Mon, 14 Sep 2015 22:30:13 +0000 (22:30 +0000)]
[MOUNTMGR]
Implement the IOCTL IOCTL_MOUNTMGR_VOLUME_MOUNT_POINT_DELETED:
- Implement MountMgrVolumeMountPointDeleteed()
- Rename a struct var to reflect its real usage

svn path=/trunk/; revision=69232

8 years ago[MEH]
Pierre Schweitzer [Mon, 14 Sep 2015 22:10:47 +0000 (22:10 +0000)]
[MEH]
Meh.

svn path=/trunk/; revision=69231

8 years ago[MOUNTMGR]
Pierre Schweitzer [Mon, 14 Sep 2015 21:52:16 +0000 (21:52 +0000)]
[MOUNTMGR]
MountMgrVolumeMountPointCreated() returns success if databases are already performing a sync

svn path=/trunk/; revision=69230

8 years ago[SHELL32]
Thomas Faber [Mon, 14 Sep 2015 19:20:55 +0000 (19:20 +0000)]
[SHELL32]
- Arch, don't leave unused variables
CORE-9867

svn path=/trunk/; revision=69229

8 years ago[SHELL32]
Thomas Faber [Mon, 14 Sep 2015 19:14:48 +0000 (19:14 +0000)]
[SHELL32]
- Stop asserting 'ref == 0' in CComCreatorCentralInstance::Term. It's caught enough reference leaks and is mostly just annoying now.
CORE-9867 #resolve

svn path=/trunk/; revision=69228

8 years ago[NTOS:PNP]
Thomas Faber [Mon, 14 Sep 2015 18:58:58 +0000 (18:58 +0000)]
[NTOS:PNP]
- Fix memory leak in IopDetectResourceConflict. While we're at it use pool tagging, kernel handles and avoid INVALID_HANDLE_VALUE.

svn path=/trunk/; revision=69227

8 years ago[USETUP] Addendum to r69121 CORE-10058
Robert Naumann [Mon, 14 Sep 2015 10:40:44 +0000 (10:40 +0000)]
[USETUP] Addendum to r69121 CORE-10058

svn path=/trunk/; revision=69226

8 years ago[UNIATA] Get back a ros diff spotted by Thomas and use our debug checks in some more...
Amine Khaldi [Mon, 14 Sep 2015 10:33:09 +0000 (10:33 +0000)]
[UNIATA] Get back a ros diff spotted by Thomas and use our debug checks in some more places. CORE-10185

svn path=/trunk/; revision=69225

8 years ago[UNIATA] Sync to 0.45h1. CORE-10185
Amine Khaldi [Mon, 14 Sep 2015 10:24:48 +0000 (10:24 +0000)]
[UNIATA] Sync to 0.45h1. CORE-10185

svn path=/trunk/; revision=69224

8 years ago[ACLEDIT] Order the exports, add missing one and make sure the list matches our targe...
Amine Khaldi [Mon, 14 Sep 2015 09:51:11 +0000 (09:51 +0000)]
[ACLEDIT] Order the exports, add missing one and make sure the list matches our target (Windows Server 2003 Sp2). By Radek Liška, confirmed and slightly changed by me. CORE-8174

svn path=/trunk/; revision=69223