Timo Kreuzer [Mon, 24 Jun 2019 22:26:08 +0000 (00:26 +0200)]
[CMIDRIVER] Try to fix build
Timo Kreuzer [Sat, 25 May 2019 10:22:04 +0000 (12:22 +0200)]
[STDUNK][PORTCLS][CMIDriver] Fix issue with operator new/delete
Fix for MSVC warning "C2323: 'operator new': non-member operator new or delete functions may not be declared static or in a namespace other than the global namespace."
See https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-what-s-new-2003-through-2015?view=vs-2019 section "Overloaded operator new and operator delete"
Timo Kreuzer [Mon, 24 Jun 2019 19:16:10 +0000 (21:16 +0200)]
[GDI32_APITEST] Extend test for SetWorldTransform (#1686)
Katayama Hirofumi MZ [Mon, 24 Jun 2019 12:32:40 +0000 (21:32 +0900)]
[WIN32SS][NTGDI] Strictly check in XFORMOBJ_iSetXform (#1676)
Check if the determinant of the given transformation matrix is non-zero. If zero, the function returns DDI_ERROR without change. CORE-15554
Hermès Bélusca-Maïto [Sun, 23 Jun 2019 19:05:28 +0000 (21:05 +0200)]
[BOOTVID] Diverse enhancements.
- Import cmdcnst.h and vga.h headers from the 'vga_new' VGA Miniport Driver,
that contain definitions related to VGA registers as well as command-stream
functionality.
- Replace a bunch of hardcoded values by their corresponding defintions.
- Replace "Captain-Obvious" comments in VgaIsPresent() with actual
explanations from the corresponding function in 'vga_new'.
- Simplify the VgaInterpretCmdStream() function, based on the
corresponding one from 'vga_new'.
- Use concise comments in the 'AT_Initialization' command stream definition.
- Import the 'VGA_640x480' initialization command stream from 'vga_new'
and use it as the full VGA initialization stream whenever the HAL
does not handle the VGA display (HalResetDisplay() returning FALSE).
Otherwise we just use the 'AT_Initialization' command stream that
performs minimal initialization.
- Remove unused AT_Initialization and other declarations from ARM build.
Timo Kreuzer [Sun, 23 Jun 2019 20:35:19 +0000 (22:35 +0200)]
[INFLIB] Fix INFCONTEXT structure to be compatible with the official definition (#1603)
* [INFLIB] Fix INFCONTEXT structure to be compatible with the official definition.
This makes inflib work on x64.
Eric Kohl [Sun, 23 Jun 2019 19:45:54 +0000 (21:45 +0200)]
[SETUPAPI][UMPNPMGR] PNP_UnregisterNotification: Add 2 unknown parameters
Eric Kohl [Sun, 23 Jun 2019 17:26:44 +0000 (19:26 +0200)]
[SETUPAPI][UMPNPMGR] Improve CMP_RegisterNotification/PNP_RegisterNotification
Pass the notification filter to PNP_RegisterNotification as a byte-pointer to the filter and the size of the filter.
Hermès Bélusca-Maïto [Sun, 23 Jun 2019 01:03:40 +0000 (03:03 +0200)]
[BOOTVID] Fixes for VgaIsPresent() and VidInitialize().
- VgaIsPresent(): Re-select the memory mode register before playing
around with the sequencer flag. Otherwise the VGA may not be detected
correctly from time to time.
- VidInitialize(): Simplify the initialization loop, reset AddressSpace
to its "default" value of 1 when calling HalFindBusAddressTranslation()
on 'NullAddress'.
Hermès Bélusca-Maïto [Sun, 23 Jun 2019 00:29:01 +0000 (02:29 +0200)]
[BOOTVID] Simplify the code by introducing and using IO port helper macros.
- Move around two header includes.
- Remove a redundant assignment in VgaInterpretCmdStream().
Hermès Bélusca-Maïto [Sat, 22 Jun 2019 21:27:26 +0000 (23:27 +0200)]
[VGA_NEW] Fix confusion between CRTC Controller and Graphics Controller registers.
Hermès Bélusca-Maïto [Sat, 22 Jun 2019 21:24:13 +0000 (23:24 +0200)]
[NTVDM] Fix whitespace.
Hermès Bélusca-Maïto [Sat, 22 Jun 2019 21:03:10 +0000 (23:03 +0200)]
[WIN32K] Fix spelling typo.
Joachim Henze [Sat, 22 Jun 2019 20:27:23 +0000 (22:27 +0200)]
[WIN32SS] Fix multiple scrollbar redraw issues
This fixes:
- CORE-15911 "Scrollbars do not dissapear when Maximizing and not needed"
- CORE-10617 "ListView corrupt scrollbar upon resizing the column-header"
and will appease regression:
- CORE-15429 "Uninitialized scrollbars in 'My Computer'"
By applying clientFix.patch from CORE-15911 contributed by JIRA-user 'I_Kill_Bugs'.
https://reactos.org/testman/compare.php?ids=66723,66729
Earlier I already committed this fix into 0.4.12-RC-9-g
5ac548544ff6b3d52c6591385d9029164e766d71
Eric Kohl [Sat, 22 Jun 2019 18:59:16 +0000 (20:59 +0200)]
[NETCFGX] Start a network adapter device after the custom install steps have been completed.
This could probably fix CORE-16103
Eric Kohl [Sat, 22 Jun 2019 18:50:51 +0000 (20:50 +0200)]
[SETUPAPI] Implement SetupDiRestartDevices()
jimtabor [Sat, 22 Jun 2019 17:02:51 +0000 (12:02 -0500)]
[Win32SS] Complete Print Driver Callbacks
This callback works. Haven't commit the rest yet. Still thinking about
the data packets types and shapes. Using wordpad to test this. It works,
loads and unloads due to incomplete driver support and no PDEV. It
crashes in ComCtl32 while loading a text file. When this gets committed
without a solution, the code will be commented out.
Andreas Maier [Sat, 22 Jun 2019 14:36:14 +0000 (16:36 +0200)]
[COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression) (#1674)
* [COMCTL32] Fix CORE-14619 (Checkbox buttons theming regression)
Fix cb_states / rb_states lookup table.
* [README.WINE] comctl32 is synced to WineStaging-3.3.
See commit
b3fb8555 .
Bișoc George [Sat, 22 Jun 2019 14:20:58 +0000 (16:20 +0200)]
[FASTFAT][FLTMGR][NTOS] Do not explicitly call ObfDereferenceObject() (#1636)
"Most code should not directly call the platform-specific ObfDereferenceObject() function but use the ObDereferenceObject() macro instead."
CORE-16081
Jose Carlos Jesus [Sat, 22 Jun 2019 14:10:37 +0000 (16:10 +0200)]
[NEWDEV] Add Portuguese (neutral) translation.
Jose Carlos Jesus [Thu, 20 Jun 2019 19:27:19 +0000 (20:27 +0100)]
[NETID] Add Portuguese (neutral) translation.
Jose Carlos Jesus [Thu, 20 Jun 2019 18:01:17 +0000 (19:01 +0100)]
[NETCFGX] Add Portuguese (neutral) translation.
Bișoc George [Sat, 22 Jun 2019 13:37:59 +0000 (15:37 +0200)]
[MAIN.CPL] Adjust the GROUPBOX control spacing for French resource (#1682)
CORE-12372
James Tabor [Fri, 21 Jun 2019 18:10:03 +0000 (13:10 -0500)]
[Win32SS] Add Driver Callback
Add user driver callback to be used later on.
Katayama Hirofumi MZ [Fri, 21 Jun 2019 06:50:14 +0000 (15:50 +0900)]
[GDI32_APITEST] Fixup of
90be07f (#1675)
Katayama Hirofumi MZ [Fri, 21 Jun 2019 06:45:54 +0000 (15:45 +0900)]
[GDI32_APITEST] Improve TextTransform (add translation) (#1675)
Add some coordinate translation tests. CORE-15554
Eric Kohl [Thu, 20 Jun 2019 20:07:42 +0000 (22:07 +0200)]
[NETSHELL] Improvements to the network setup (2a/x)
Step 2a: Really check the binding between network components.
Next Step: Bind the Tcpip transport to all enumerated network adapters.
Eric Kohl [Thu, 20 Jun 2019 20:02:18 +0000 (22:02 +0200)]
[NETCFGX] Read a components bind value and implement the IsBoundTo method.
Hermès Bélusca-Maïto [Thu, 20 Jun 2019 19:15:12 +0000 (21:15 +0200)]
[NETSTAT] Really fix the build.
Hermès Bélusca-Maïto [Thu, 20 Jun 2019 18:59:23 +0000 (20:59 +0200)]
[NETSTAT] Simplify DoFormatMessage(), and fix build.
Lee Schroeder [Sat, 15 Jun 2019 17:25:54 +0000 (11:25 -0600)]
[NETSTAT] Convert the netstat utility to Unicode, and localize it. (#1657)
CORE-16119
Also, change its resource file description to reflect that the utility isn't just for TCPv4.
Eric Kohl [Thu, 20 Jun 2019 18:04:10 +0000 (20:04 +0200)]
[NETCFGX] EnumClientServiceProtocol: Use the right parent key when trying to open the 'NDI' subkey.
This makes the description of the selected item show up in the network connection properties.
Hermès Bélusca-Maïto [Sat, 27 Apr 2019 15:57:49 +0000 (17:57 +0200)]
[NTOS:KE] Use multi-processor-aware KeGetPcr() instead of the legacy PCR.
Hermès Bélusca-Maïto [Tue, 23 Apr 2019 01:42:24 +0000 (03:42 +0200)]
[NTOS:KE] Fixup for the NMI task handler: handle NMI recursion. -- Code was lost in commit
2efed8ef (r45040).
Hermès Bélusca-Maïto [Mon, 4 Feb 2019 00:16:29 +0000 (01:16 +0100)]
[NTOS:KE] Improvements for the Trap02 (NMI) and Trap08 (double-fault) exception handlers.
- Add FRAME_TSS FPO debug information for Trap02 and Trap08.
- Switch the active TSS in Trap08 in the very same way as is done in Trap02.
This allows to correctly debug NMI and double-fault exceptions with WinDbg,
by following the different TSS contexts, as described in:
https://blogs.msdn.microsoft.com/debuggingtoolbox/2008/02/22/special-command-analyzing-and-reconstructing-the-stack-using-the-k-command-and-its-variations/
https://blogs.msdn.microsoft.com/ntdebugging/2009/11/25/part-1-got-stack-no-we-ran-out-of-kernel-mode-stack-and-kv-wont-tell-me-why/
http://www.osronline.com/article.cfm?article=254 and http://www.osronline.com/article.cfm?article=328
Hermès Bélusca-Maïto [Mon, 4 Feb 2019 00:02:26 +0000 (01:02 +0100)]
[NTOS:KE][SDK:ASM] Code formatting/styling only.
- Un-hardcode the RPL_MASK value.
- s/KiUnexpectedInterrupt&Number/KiUnexpectedInterrupt&Vector/
- Use C-style comments in traphdlr.c as everywhere else in the file.
- Update the URLs for the MSDN "FPO" macro documentation.
Hermès Bélusca-Maïto [Thu, 20 Jun 2019 16:04:26 +0000 (18:04 +0200)]
[DEVMGR] Add the missing pt-PT.rc translation file. Strange, I thought I added it before...
Mas Ahmad Muhammad [Wed, 19 Jun 2019 08:32:35 +0000 (15:32 +0700)]
[CPL_DESK] Update Indonesian translation.
Mas Ahmad Muhammad [Wed, 19 Jun 2019 08:32:03 +0000 (15:32 +0700)]
[CPL_MMSYS] Update Indonesian translation.
Mas Ahmad Muhammad [Tue, 18 Jun 2019 19:08:09 +0000 (02:08 +0700)]
[CPL_TIMEDATE] Update Indonesian translation.
Mas Ahmad Muhammad [Tue, 18 Jun 2019 19:07:02 +0000 (02:07 +0700)]
[CPL_CONSOLE] Update Indonesian translation.
Mas Ahmad Muhammad [Tue, 18 Jun 2019 11:14:02 +0000 (18:14 +0700)]
[CPL_APPWIZ] Add Indonesian translation.
Mas Ahmad Muhammad [Tue, 18 Jun 2019 10:47:00 +0000 (17:47 +0700)]
[CPL_ACCESS] Update Indonesian translation.
Mas Ahmad Muhammad [Tue, 18 Jun 2019 04:37:12 +0000 (11:37 +0700)]
[SETUP_WELCOME] Update Indonesian translation.
Mas Ahmad Muhammad [Tue, 18 Jun 2019 04:25:08 +0000 (11:25 +0700)]
[NEWDEV] Update Indonesian translation.
Mas Ahmad Muhammad [Thu, 20 Jun 2019 14:48:22 +0000 (16:48 +0200)]
[IEFRAME] Add Indonesian translation.
Mas Ahmad Muhammad [Tue, 18 Jun 2019 02:51:18 +0000 (09:51 +0700)]
[DEVMGR] Update Indonesian translation.
Mas Ahmad Muhammad [Tue, 18 Jun 2019 02:49:11 +0000 (09:49 +0700)]
[MSGINA] Update Indonesian translation.
Mas Ahmad Muhammad [Sun, 16 Jun 2019 12:28:39 +0000 (19:28 +0700)]
[WINLOGON] Update Indonesian translation.
Mas Ahmad Muhammad [Sun, 16 Jun 2019 11:05:04 +0000 (18:05 +0700)]
[COMCTL32] Add Indonesian translation.
Mas Ahmad Muhammad [Sun, 16 Jun 2019 10:18:04 +0000 (17:18 +0700)]
[SHUTDOWN] Add Indonesian translation.
Mas Ahmad Muhammad [Sun, 16 Jun 2019 03:20:28 +0000 (10:20 +0700)]
[THEMEUI] Add Indonesian translation.
Mas Ahmad Muhammad [Sat, 15 Jun 2019 04:29:39 +0000 (11:29 +0700)]
[NOTEPAD] Update Indonesian translation.
Mas Ahmad Muhammad [Sat, 15 Jun 2019 02:42:28 +0000 (09:42 +0700)]
[COMDLG32] Add Indonesian translation.
Mas Ahmad Muhammad [Fri, 14 Jun 2019 08:35:56 +0000 (15:35 +0700)]
[SETUP_REACTOS] Add Indonesian translation.
Mas Ahmad Muhammad [Fri, 14 Jun 2019 07:32:03 +0000 (14:32 +0700)]
[BROWSEUI] Add Indonesian translation.
Mas Ahmad Muhammad [Fri, 14 Jun 2019 05:27:52 +0000 (12:27 +0700)]
[SHORTCUTS] Update Indonesian translation.
Mas Ahmad Muhammad [Fri, 14 Jun 2019 04:23:15 +0000 (11:23 +0700)]
[ROSAPPS_SHORTCUTS] Update Indonesian translation.
Jose Carlos Jesus [Thu, 20 Jun 2019 15:13:40 +0000 (17:13 +0200)]
[DEVMGR] Add Portuguese (neutral) translation.
Jose Carlos Jesus [Thu, 20 Jun 2019 15:13:21 +0000 (17:13 +0200)]
[CREDUI] Update Portuguese (neutral) translation.
Jose Carlos Jesus [Thu, 20 Jun 2019 08:47:18 +0000 (09:47 +0100)]
[COMDLG32] Update Portuguese (neutral) translation.
Jose Carlos Jesus [Thu, 20 Jun 2019 08:28:59 +0000 (09:28 +0100)]
[COMCTL32] Update Portuguese (neutral) translation.
Jose Carlos Jesus [Thu, 20 Jun 2019 08:22:43 +0000 (09:22 +0100)]
[BROWSEUI] Add Portuguese (neutral) translation.
Jose Carlos Jesus [Thu, 20 Jun 2019 08:09:44 +0000 (09:09 +0100)]
[ACLUI] Add Portuguese (neutral) translation.
Filip Š [Thu, 20 Jun 2019 14:07:06 +0000 (16:07 +0200)]
Create FUNDING.yml (#1658)
GitHub now supports sponsorships in the repository.
https://help.github.com/en/articles/displaying-a-sponsor-button-in-your-repository
Katayama Hirofumi MZ [Thu, 20 Jun 2019 09:58:45 +0000 (18:58 +0900)]
[WIN32SS][NTGDI] usWinAscent and usWinDescent must be treated as signed (#1670)
TT_OS2.usWinAscent and TT_OS2.usWinDescent must be treated as FT_Short. These values affect font metrics. This PR will fix CORE-14994.
Eric Kohl [Wed, 19 Jun 2019 20:38:31 +0000 (22:38 +0200)]
[NETCFGX] Add the interfaces INetCfgBindingInterface and IEnumNetCfgBindingInterface (stubs only).
Andreas Maier [Tue, 18 Jun 2019 20:40:27 +0000 (22:40 +0200)]
[EXPLORER] Properly initialise tbBtn.iBitmap. CORE-14262.
In CNotifyToolbar::AddButton tbBtn.iBitmap (imagelist-index)
was inialised with 0. Tigthvnc adds the icon wihtout NIF_ICON flag.
So the wrong icon index was kept and later replaced.
Andreas Maier [Tue, 18 Jun 2019 19:00:43 +0000 (21:00 +0200)]
[EXPLORER] fix traces
Eric Kohl [Tue, 18 Jun 2019 20:35:46 +0000 (22:35 +0200)]
[NETCFGX] Add the interfaces INetCfgBindingPath and IEnumNetCfgBindingPath (stubs only).
Eric Kohl [Tue, 18 Jun 2019 19:46:40 +0000 (21:46 +0200)]
[NETCFGX] NetPropPageProvider: Handle the Min and Max values for INT, LONG and WORD types properly
CORE-15095
Mark Jansen [Sat, 15 Jun 2019 20:32:22 +0000 (22:32 +0200)]
[URLMON] Directly call cabinet!Extract instead of calling it via advpack!ExtractFilesW
CORE-15795
Jose Carlos Jesus [Mon, 17 Jun 2019 13:04:50 +0000 (15:04 +0200)]
[REGEDIT] Update Portuguese (neutral) translations. (#1656)
Jose Carlos Jesus [Sat, 15 Jun 2019 12:46:17 +0000 (13:46 +0100)]
[RAPPS] Add Portuguese (neutral) translation. (#1656)
Jose Carlos Jesus [Sat, 15 Jun 2019 11:42:28 +0000 (12:42 +0100)]
[NOTEPAD] Update Portuguese (neutral) translation. (#1656)
Jose Carlos Jesus [Sat, 15 Jun 2019 10:27:04 +0000 (11:27 +0100)]
[WLANCONF] Add Portuguese (neutral) translation. (#1656)
Jose Carlos Jesus [Mon, 27 May 2019 22:48:01 +0000 (23:48 +0100)]
[RUNONCE][USERINIT] Add Portuguese (neutral) translation. (#1656)
Jose Carlos Jesus [Mon, 27 May 2019 21:35:21 +0000 (22:35 +0100)]
[APPWIZ.CPL] Update Portuguese Brazilian, and add Portuguese (neutral) translations. (#1656)
Jose Carlos Jesus [Mon, 27 May 2019 21:23:36 +0000 (22:23 +0100)]
[WINLOGON] Add Portuguese (neutral) translation. (#1656)
Jose Carlos Jesus [Mon, 27 May 2019 21:09:50 +0000 (22:09 +0100)]
[ACCESS.CPL] Add & update Portuguese translation. (#1656)
Eric Kohl [Mon, 17 Jun 2019 12:57:08 +0000 (14:57 +0200)]
[NETCFGX] Add the INetCfgComponentBindings interface to the NetCfgComponent class.
Eric Kohl [Mon, 17 Jun 2019 11:47:52 +0000 (13:47 +0200)]
[UUID] Add some missing NetCfg IIDs.
Katayama Hirofumi MZ [Mon, 17 Jun 2019 11:33:31 +0000 (20:33 +0900)]
[KERNEL32_APITEST] Improve SetComputerNameExW testcase (#1661)
Improve SetComputerNameExW testcase to check invalid characters. CORE-16122
Katayama Hirofumi MZ [Mon, 17 Jun 2019 11:29:03 +0000 (20:29 +0900)]
[SDK][INCLUDE] Update msgdump.h and winxx.h (TreeView and ListView support)
Katayama Hirofumi MZ [Mon, 17 Jun 2019 01:04:45 +0000 (10:04 +0900)]
[REGEDIT] Adjust ListView column widths (#1663)
CORE-15187
Eric Kohl [Sun, 16 Jun 2019 23:18:05 +0000 (01:18 +0200)]
[NETSHELL] Improvements to the network setup (1/x)
Step 1: Find the TcpIp transport and enumerate the installed network adapters using INetCfg.
Next Step: Find out how the binding process works and bind the TcpIp transport to all enumerated network adapters. This will replace the blind binding process we are using right now.
Eric Kohl [Sun, 16 Jun 2019 22:46:30 +0000 (00:46 +0200)]
[NETCFGX] Resize a helper buffer to accommodate a device instance id.
This prevent NULL pointer exceptions in calls to INetCfgComponent::GetPnpDevNodeId().
Eric Kohl [Sun, 16 Jun 2019 21:58:29 +0000 (23:58 +0200)]
[MEDIA] Add netcfgx.dll to the EarlyRegisterDll list so that we can use it in the 2nd install phase.
Eric Kohl [Sun, 16 Jun 2019 21:55:31 +0000 (23:55 +0200)]
[NETCFGX] Set the ComponentId value when a NIC is installed.
Mark Jansen [Sun, 16 Jun 2019 19:54:44 +0000 (21:54 +0200)]
[INPUT] Don't race the system to free an imagelist
Benjamin Aerni [Sun, 16 Jun 2019 21:00:53 +0000 (14:00 -0700)]
[I8042PRT] Add Latitude E6400 to the hack list (#1665)
Let it make grow, grow, grow... !!
Mark Jansen [Sun, 16 Jun 2019 11:56:54 +0000 (13:56 +0200)]
[RASAPI32] Add RasClearConnectionStatistics stub
CORE-10092
Thomas Faber [Sat, 15 Jun 2019 19:25:01 +0000 (21:25 +0200)]
[WIN32K:ENG] In PDEVOBJ_vRefreshModeList, find a proper match for the current display mode instead of assuming a constant index. CORE-15325
Hermès Bélusca-Maïto [Sat, 15 Jun 2019 23:00:40 +0000 (01:00 +0200)]
[HOSTNAME] Retrieve the DNS *host name* of the computer, and not the computer name.
CORE-16095, ROSTESTS-326
Doug-Lyons [Sat, 8 Jun 2019 22:39:05 +0000 (17:39 -0500)]
[ROSTESTS] Add a new test for "gethostname" in ws2_32_apitest. (#1630)
ROSTESTS-326
Make the test more robust; clean up on failures.
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Mark Jansen [Wed, 12 Jun 2019 16:52:14 +0000 (18:52 +0200)]
[WIN32K] Use KeStackAttachProcess
Mark Jansen [Mon, 10 Jun 2019 17:47:50 +0000 (19:47 +0200)]
[WIN32K] Attach to the target process before unhooking
CORE-16083
Mark Jansen [Mon, 10 Jun 2019 17:43:12 +0000 (19:43 +0200)]
[WIN32K] Fix indenting in IntRemoveHook
Victor Perevertkin [Sat, 15 Jun 2019 16:24:27 +0000 (19:24 +0300)]
[NTFS] Do not print debug message for every function call by default
Hermès Bélusca-Maïto [Sat, 15 Jun 2019 17:09:28 +0000 (19:09 +0200)]
[MAGNIFY] Minor whitespace / formatting fixes; use the new file headers + some code simplifications here and there...