reactos.git
3 months ago[NTOSKRNL] Add support for large allocations in !poolfind
Pierre Schweitzer [Tue, 8 Jan 2019 07:42:51 +0000 (08:42 +0100)]
[NTOSKRNL] Add support for large allocations in !poolfind

3 months ago[NTOSKRNL] In !irpfind, add info about current stack major/minor
Pierre Schweitzer [Mon, 7 Jan 2019 07:41:36 +0000 (08:41 +0100)]
[NTOSKRNL] In !irpfind, add info about current stack major/minor

3 months ago[KERNEL32] GetComputerNameExW: Fix crash in kernel32_winetest environ test
Eric Kohl [Mon, 7 Jan 2019 21:45:33 +0000 (22:45 +0100)]
[KERNEL32] GetComputerNameExW: Fix crash in kernel32_winetest environ test

3 months ago[UXTHEME] Fix a series of problems regarding ThemeCalculateCaptionButtonsPos
Giannis Adamopoulos [Mon, 7 Jan 2019 09:38:42 +0000 (11:38 +0200)]
[UXTHEME] Fix a series of problems regarding ThemeCalculateCaptionButtonsPos
Only call it when needed. Also make it fail properly if the window theme could not be opened.
CORE-15564

3 months ago[NTOSKRNL] Misc fixes to !irpfind
Pierre Schweitzer [Sun, 6 Jan 2019 22:21:20 +0000 (23:21 +0100)]
[NTOSKRNL] Misc fixes to !irpfind

3 months ago[NTOSKRNL] Move KDBG MM functions implementation to their own file
Pierre Schweitzer [Sun, 6 Jan 2019 21:49:23 +0000 (22:49 +0100)]
[NTOSKRNL] Move KDBG MM functions implementation to their own file

3 months ago[GDI32] Add missing dependency 1206/head
Mark Jansen [Sun, 6 Jan 2019 19:57:10 +0000 (20:57 +0100)]
[GDI32] Add missing dependency

3 months ago[WINSPOOL] Semi implement DocumentPropertiesW
Mark Jansen [Sun, 6 Jan 2019 01:24:42 +0000 (02:24 +0100)]
[WINSPOOL] Semi implement DocumentPropertiesW
CORE-15522

3 months ago[PRINTING] Semi-implement GetPrinterDriverW
Mark Jansen [Sat, 29 Dec 2018 22:51:32 +0000 (23:51 +0100)]
[PRINTING] Semi-implement GetPrinterDriverW
CORE-15522

3 months ago[PRINTING] The first argument to PackStrings can be const.
Mark Jansen [Sun, 6 Jan 2019 11:18:40 +0000 (12:18 +0100)]
[PRINTING] The first argument to PackStrings can be const.

3 months ago[FREELDR] Minor code formatting; constify some non-mutable data.
Hermès Bélusca-Maïto [Sun, 6 Jan 2019 17:34:49 +0000 (18:34 +0100)]
[FREELDR] Minor code formatting; constify some non-mutable data.

3 months ago[TRANSLATION] Update Chinese translation. (#1223)
Luo Yufan [Sun, 6 Jan 2019 15:35:11 +0000 (23:35 +0800)]
[TRANSLATION] Update Chinese translation. (#1223)

[CLIPBRD][SOLITAIRE][RAPPS][REGEDIT][WINHLP32][WORDPAD][FDEBUG][SYSDM][BROWSEUI][DEVMGR][IEFRAME][OLEDLG][SHELL32][SYSSETUP][INF][WINFILE][NTVDM][USER32]

3 months ago[NTOSKRNL] Fix !irpfind usage message
Pierre Schweitzer [Sun, 6 Jan 2019 12:00:43 +0000 (13:00 +0100)]
[NTOSKRNL] Fix !irpfind usage message

3 months ago[NTOSKRNL] Properly check for address validity in !poolfind
Pierre Schweitzer [Sun, 6 Jan 2019 11:58:14 +0000 (12:58 +0100)]
[NTOSKRNL] Properly check for address validity in !poolfind

3 months ago[NTOSKRNL] Reimplement !irpfind using !poolfind helpers
Pierre Schweitzer [Sun, 6 Jan 2019 11:49:57 +0000 (12:49 +0100)]
[NTOSKRNL] Reimplement !irpfind using !poolfind helpers

This allows avoiding one of the previous implementation limits:
leaked IRP not queued to a thread are now totally visible since
we look directly in the memory pool.

3 months ago[NTOSKRNL] Implement !poolfind command in KDBG
Pierre Schweitzer [Sun, 6 Jan 2019 10:54:05 +0000 (11:54 +0100)]
[NTOSKRNL] Implement !poolfind command in KDBG

For now, it allows searching for pool allocations in
both paged and non paged pool.

It is based on Andreas Schuster work to identify POOL_HEADER
structures.

3 months ago[NTUSER] Fix SetProcessDefaultLayout() (#1013) 1013/head
Baruch Rutman [Sat, 20 Oct 2018 08:53:14 +0000 (11:53 +0300)]
[NTUSER] Fix SetProcessDefaultLayout() (#1013)

- Add a check in co_UserCreateWindowEx() for parentless windows,
  that checks the default layout direction; if it's LAYOUT_RTL
  add the WS_EX_LAYOUTRTL flag to the extended window styles.

- Make the internal routine accepting also LAYOUT_LTR as a value for SetProcessDefaultLayout().
  Limit receiving value to LAYOUT_ORIENTATIONMASK (and not just LAYOUT_RTL)
  or LAYOUT_LTR, as per written in:
  https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-setprocessdefaultlayout

Now all the applications that call SetProcessDefaultLayout() to mirror the layout get mirrored.
This is based on Wine.

3 months ago[FONT][GDI32] Fix font enumeration functions (#1221)
Katayama Hirofumi MZ [Sun, 6 Jan 2019 01:43:34 +0000 (10:43 +0900)]
[FONT][GDI32] Fix font enumeration functions (#1221)

Fix EnumFonts, EnumFontFamilies and EnumFontFamiliesEx functions.
The charsets of the font substitutes are also enumerated.
Delete meaningless codes. CORE-15558

3 months ago[GDI32_APITEST] Improve CreateFontIndirect testcase
Katayama Hirofumi MZ [Sun, 6 Jan 2019 00:12:00 +0000 (09:12 +0900)]
[GDI32_APITEST] Improve CreateFontIndirect testcase

3 months ago[FREELDR] Simplify code by using a AddReactOSArcDiskInfo() helper, and few extra...
Hermès Bélusca-Maïto [Sat, 5 Jan 2019 18:25:35 +0000 (19:25 +0100)]
[FREELDR] Simplify code by using a AddReactOSArcDiskInfo() helper, and few extra additions.

- Introduce the AddReactOSArcDiskInfo() helper to get rid of the
  duplicated reactos_arc_disk_info usage scattered amongst different
  files.

- GetHarddiskInformation(): If we cannot read the disk that has been
  enumerated by the BIOS, return a default identifier string.

- GetHarddiskInformation(): The last character of the disk identifier
  string corresponds to whether its MBR is "valid"/has the 0xAA55
  signature (use 'A') or whether it's not (use 'X'). Tested on Windows.

- Split PcInitializeBootDevices() in two: the first part of this
  function that enumerates hard disks from the BIOS is now moved into
  EnumerateHarddisks().

- The 'ValidPartitionTable' field of the ARC disk signature records must
  be initialized with correct value that is specified in the different
  AddReactOSArcDiskInfo() calls.

3 months ago[KERNEL32] make some NLS and Format functions work. Wine-sync with latest version
Denis Malikov [Sun, 18 Nov 2018 14:32:13 +0000 (21:32 +0700)]
[KERNEL32] make some NLS and Format functions work. Wine-sync with latest version

3 months ago[WIN32SS:NTUSER] Completely update the metrics in co_IntInitializeDesktopGraphics().
Hermès Bélusca-Maïto [Sat, 5 Jan 2019 15:36:30 +0000 (16:36 +0100)]
[WIN32SS:NTUSER] Completely update the metrics in co_IntInitializeDesktopGraphics().

This change is similar to what is done in UserChangeDisplaySettings()
after changing screen video mode.

This allows e.g. having windows to be correctly maximized during
2nd-stage GUI setup. To compare and reproduce during 2nd-stage GUI
setup, open cmd.exe (Shift-F10) and from there a GUI app, e.g.
regedit.exe, and maximize it. Observe the limits used by the window.

3 months agoResource file strings cleanup (#581)
David Quintana [Sat, 5 Jan 2019 14:44:16 +0000 (15:44 +0100)]
Resource file strings cleanup (#581)

[CMDUTILS/AT] Fix missing translation strings in certain files.
[NOTEPAD] Fix SUBLANG code to brazillian.
[RAPPS] Fix missing translation strings in certain files.
[FDEBUG] Fix translation string ID.
[CPL/INPUT] Fix missing translation strings in certain files.
[ACPPAGE] Fix incorrect resource IDs.
[NETSHELL] Fix incorrect resource IDs.
[DEVMGR] Fix missing translation strings in certain files.
[LSASRV] Fix missing translation strings in certain files.
[RASDLG] Fix missing translation strings in certain files.
[SHELL32] Fix missing translation strings and incorrect resource IDs.
[TAPIUI] Fix missing translation strings in certain files.
[WINFILE] Fix incorrect resource IDs.
[NTVDM] Fix missing translation strings in certain files.
[USERSRV] Fix missing translation strings in certain files.
[BROWSEUI] One more missing string.
[FLTMC] Fix missing translation strings in certain files.

Detected using the TransDiffer tool (early alpha).
This doesn't include everything anymore, but I wanted to get the PR out of the way.

3 months ago[SDK] Reset InDbgPrint state when an exception occurs 1220/head
Mark Jansen [Fri, 4 Jan 2019 20:55:38 +0000 (21:55 +0100)]
[SDK] Reset InDbgPrint state when an exception occurs
Previously this would not get reset, and all debug prints from the
current thread would be muted.

3 months ago[NET] Implement the /add and /del options of the computer command.
Eric Kohl [Sat, 5 Jan 2019 13:54:40 +0000 (14:54 +0100)]
[NET] Implement the /add and /del options of the computer command.

3 months ago[VCDCONTROLTOOL] Implement Romanian & Italian translations (#1218)
Bișoc George [Sat, 5 Jan 2019 13:54:57 +0000 (14:54 +0100)]
[VCDCONTROLTOOL] Implement Romanian & Italian translations (#1218)

3 months ago[MSVCRT] export _except_handler4_common
Denis Malikov [Sun, 18 Nov 2018 17:02:22 +0000 (00:02 +0700)]
[MSVCRT] export _except_handler4_common

3 months ago[LOG2LINES] Use translate_line() for command line input too
Serge Gautherie [Sat, 22 Dec 2018 01:12:46 +0000 (02:12 +0100)]
[LOG2LINES] Use translate_line() for command line input too

NB: Last step would be to re-use translate_files()...

3 months ago[NTDLL][RTL] Implement RtlGetFullPathName_UEx
Andrew Boyarshin [Mon, 26 Nov 2018 12:50:40 +0000 (19:50 +0700)]
[NTDLL][RTL] Implement RtlGetFullPathName_UEx

3 months ago[APPHELP] Prevent a nullptr dereference 1216/head
Mark Jansen [Thu, 3 Jan 2019 21:17:54 +0000 (22:17 +0100)]
[APPHELP] Prevent a nullptr dereference

3 months ago[SHIMENG] Prevent a nullptr dereference
Mark Jansen [Thu, 3 Jan 2019 21:17:01 +0000 (22:17 +0100)]
[SHIMENG] Prevent a nullptr dereference

3 months ago[APPCOMPAT] Move sdbtagid.h and sdbtypes.h to a shared location
Mark Jansen [Thu, 3 Jan 2019 21:11:13 +0000 (22:11 +0100)]
[APPCOMPAT] Move sdbtagid.h and sdbtypes.h to a shared location

3 months ago[SHIMENG] Ignore shims that are loading
Mark Jansen [Thu, 22 Nov 2018 23:18:17 +0000 (00:18 +0100)]
[SHIMENG] Ignore shims that are loading

3 months ago[APPHELP] Fix a typo in the logging
Mark Jansen [Thu, 22 Nov 2018 23:08:58 +0000 (00:08 +0100)]
[APPHELP] Fix a typo in the logging

3 months ago[SHIMLIB] c++ compatibility
Mark Jansen [Thu, 22 Nov 2018 21:20:21 +0000 (22:20 +0100)]
[SHIMLIB] c++ compatibility

3 months ago[REACTOS] Fix misc 64 bit issues (#783)
Timo Kreuzer [Sat, 5 Jan 2019 09:50:11 +0000 (10:50 +0100)]
[REACTOS] Fix misc 64 bit issues (#783)

* [WIN32K] Fix handle calculation in DbgGdiHTIntegrityCheck
* [NOTEPAD] Fix MSVC warnings
* [PSDK] Simplify *PROC definitions in windef.h
* [VIDEOPRT] Don't try to use NtVdmControl on x64
* [FREELDR] Fix some macros
* [CRT] Make qsort 64 bit compatible
* [NTOS] Use #ifndef _WIN64 instead of #ifdef _M_IX86 around C_ASSERTs
* [FAST486] Fix 64 bit warnings and change DWORD to ULONG, so it can be used in kernel mode
* [APPHELP_APITEST] Fix 64 bit issue

3 months ago[MPG123] Update to version 1.25.10. CORE-15280
Thomas Faber [Sat, 1 Dec 2018 17:43:56 +0000 (18:43 +0100)]
[MPG123] Update to version 1.25.10. CORE-15280

3 months ago[MBEDTLS] Update to version 2.7.6. CORE-15280
Thomas Faber [Wed, 31 Oct 2018 15:00:34 +0000 (16:00 +0100)]
[MBEDTLS] Update to version 2.7.6. CORE-15280

Note: this disables the MBEDTLS_DEPRECATED_REMOVED configuration value,
because we require the now-deprecated MD5 & SHA functions for bcrypt.

3 months ago[LIBPNG] Update to version 1.6.35. CORE-15280
Thomas Faber [Mon, 29 Oct 2018 17:15:10 +0000 (18:15 +0100)]
[LIBPNG] Update to version 1.6.35. CORE-15280

3 months ago[OSK] Fix a sentence in Italian resource (#1219)
Bișoc George [Fri, 4 Jan 2019 22:14:16 +0000 (23:14 +0100)]
[OSK] Fix a sentence in Italian resource (#1219)

Addendum to 76002778 (see the comment left).

3 months ago[TRANSLATION] Improve Chinese translation of VCDControlTool. (#1217)
Luo Yufan [Fri, 4 Jan 2019 20:20:50 +0000 (04:20 +0800)]
[TRANSLATION] Improve Chinese translation of VCDControlTool. (#1217)

3 months ago[APISETS] Remove default kernel32 import library, since stubs no longer need it 1182/head
Mark Jansen [Sun, 23 Dec 2018 21:39:10 +0000 (22:39 +0100)]
[APISETS] Remove default kernel32 import library, since stubs no longer need it

3 months ago[VERIFIER] Remove stub special case, since our normal 'stub' code no longer links...
Mark Jansen [Sun, 23 Dec 2018 21:37:45 +0000 (22:37 +0100)]
[VERIFIER] Remove stub special case, since our normal 'stub' code no longer links against kernel32

3 months ago[WINSRV] ConSrvConnect: Always store the control dispatcher routine
Giannis Adamopoulos [Fri, 4 Jan 2019 17:38:36 +0000 (19:38 +0200)]
[WINSRV] ConSrvConnect: Always store the control dispatcher routine
This shouldn't be used only for console applications but can potentially be used by any application to receive shutdown notifications.
MSDN provides more information in the documentation for SetConsoleCtrlHandler. Our services.exe also expect to receive shutdown notifications in this way.

3 months ago[WINSRV] usersrv: Fix a wrong debug print
Giannis Adamopoulos [Fri, 4 Jan 2019 17:28:19 +0000 (19:28 +0200)]
[WINSRV] usersrv: Fix a wrong debug print

3 months ago[WINSRV] usersrv: Don't terminate processes with no top level windows
Giannis Adamopoulos [Thu, 3 Jan 2019 12:29:11 +0000 (14:29 +0200)]
[WINSRV] usersrv: Don't terminate processes with no top level windows
Consrv will handle these.

3 months ago[WINSRV] usersrv: remove wrong dead code and fix indentation
Giannis Adamopoulos [Thu, 3 Jan 2019 12:20:22 +0000 (14:20 +0200)]
[WINSRV] usersrv: remove wrong dead code and fix indentation

3 months ago[WINSRV] consrv: Implement terminating console processes on shutdown
Giannis Adamopoulos [Thu, 3 Jan 2019 12:26:57 +0000 (14:26 +0200)]
[WINSRV] consrv: Implement terminating console processes on shutdown
Also stub handling non-console, non-gui processes.

3 months ago[WINSRV] usersrv: Simplify sanity checks in UserClientShutdown
Giannis Adamopoulos [Thu, 3 Jan 2019 23:22:44 +0000 (01:22 +0200)]
[WINSRV] usersrv: Simplify sanity checks in UserClientShutdown
UserClientShutdown will never be called for csrss so we don't need to have a check for that. The existing check was broken and wasn't doing anything anyway.
Handle processing winlogon by doing nothing so that consrv won't be bothered about it.

3 months ago[MOUNTMGR] Fix buffer length checking
Pierre Schweitzer [Thu, 3 Jan 2019 22:10:31 +0000 (23:10 +0100)]
[MOUNTMGR] Fix buffer length checking

Found by Vadim Galiant.

CORE-15549

3 months ago[LDR] Ensure we start with a valid pointer 1201/head
Mark Jansen [Fri, 28 Dec 2018 18:27:32 +0000 (19:27 +0100)]
[LDR] Ensure we start with a valid pointer

3 months ago[LDR] Actually allocate what is asked for
Mark Jansen [Fri, 28 Dec 2018 18:27:09 +0000 (19:27 +0100)]
[LDR] Actually allocate what is asked for

3 months ago[LDR] Don't dereference a possible nullptr on a malformed forwarded import
Mark Jansen [Fri, 28 Dec 2018 18:26:32 +0000 (19:26 +0100)]
[LDR] Don't dereference a possible nullptr on a malformed forwarded import

3 months ago[LDR] Don't dereference a possible nullptr
Mark Jansen [Fri, 28 Dec 2018 18:25:43 +0000 (19:25 +0100)]
[LDR] Don't dereference a possible nullptr

3 months ago[OSK] Update translation files (#1189)
Bișoc George [Thu, 3 Jan 2019 21:28:03 +0000 (22:28 +0100)]
[OSK] Update translation files (#1189)

Translate the welcome dialog resource for Italian and Romanian.

3 months ago[APPWIZ] Russian and Ukrainian Translations Update (#1215)
Yaroslav Kibysh [Thu, 3 Jan 2019 21:20:40 +0000 (23:20 +0200)]
[APPWIZ] Russian and Ukrainian Translations Update (#1215)

3 months agoAddendum to 60f018ae: Remove obsolete DPRINTs and fix a DPRINT.
Eric Kohl [Thu, 3 Jan 2019 19:59:20 +0000 (20:59 +0100)]
Addendum to 60f018ae: Remove obsolete DPRINTs and fix a DPRINT.

3 months ago[RXCE] Fix leftover
Pierre Schweitzer [Thu, 3 Jan 2019 15:59:45 +0000 (16:59 +0100)]
[RXCE] Fix leftover

3 months ago[USER32] Let App Switcher activate only one window (#1214)
Katayama Hirofumi MZ [Thu, 3 Jan 2019 15:34:58 +0000 (00:34 +0900)]
[USER32] Let App Switcher activate only one window (#1214)

3 months ago[RDBSS] Fix pointer value assignation.
Hermès Bélusca-Maïto [Thu, 3 Jan 2019 14:47:29 +0000 (15:47 +0100)]
[RDBSS] Fix pointer value assignation.

3 months ago[RXCE] Fix 64 bit build
Timo Kreuzer [Thu, 3 Jan 2019 13:27:15 +0000 (14:27 +0100)]
[RXCE] Fix 64 bit build

3 months ago[ACPI] Add code to retrieve packet type data from ACPI methods. This will enable...
Eric Kohl [Wed, 2 Jan 2019 22:29:12 +0000 (23:29 +0100)]
[ACPI] Add code to retrieve packet type data from ACPI methods. This will enable the cmbatt driver to retrieve _BIF (battery information) or _BST (battery status) data. Also fix the buffer size calculation for integer and string data.

3 months ago[TCPIP] Don't trust the TEB
Pierre Schweitzer [Wed, 2 Jan 2019 22:01:24 +0000 (23:01 +0100)]
[TCPIP] Don't trust the TEB

And trust the Russian hackers to exploit that.

3 months ago[WIN32SS] Try to recover display when changing the display mode fails for whatever...
Hermès Bélusca-Maïto [Wed, 2 Jan 2019 19:55:40 +0000 (20:55 +0100)]
[WIN32SS] Try to recover display when changing the display mode fails for whatever reason.

This helps when e.g. changing the resolution on the Dell Latitude D531,
which reports that it supports large resolutions (e.g. 1920x1440x32 and
others larger than 1024x768x32) but fails to apply these.
This usually happens because PDEVOBJ_pSurface(), and more precisely
ppdev->pldev->pfn.EnableSurface(), fails for these resolutions.

- PDEVOBJ_bSwitchMode(): Set the new video mode, or restore the original
  one in case of failure + release the allocated ppdevTmp if previous
  calls fail. Also unlock in reverse order of locking order.

- UserChangeDisplaySettings(): In case PDEVOBJ_pSurface() fails (but has
  reverted the original video mode), we still need to refresh the
  display since the display may have been messed up.

3 months ago[WIN32SS:NTUSER] Remove some hardcoded buffer sizes + number of chars vs. bytes mixup.
Hermès Bélusca-Maïto [Wed, 2 Jan 2019 19:53:42 +0000 (20:53 +0100)]
[WIN32SS:NTUSER] Remove some hardcoded buffer sizes + number of chars vs. bytes mixup.

3 months ago[WIN32SS:NTUSER] Minor whitespace formatting.
Hermès Bélusca-Maïto [Wed, 2 Jan 2019 19:51:46 +0000 (20:51 +0100)]
[WIN32SS:NTUSER] Minor whitespace formatting.

3 months ago[FRAMEBUF] Correctly check the return value of the EngDeviceIoControl() call and...
Hermès Bélusca-Maïto [Tue, 1 Jan 2019 19:44:24 +0000 (20:44 +0100)]
[FRAMEBUF] Correctly check the return value of the EngDeviceIoControl() call and return adequate value in DrvAssertMode().

3 months ago[NTUSER] Fix a few tests related to desktops and window stations
Giannis Adamopoulos [Wed, 2 Jan 2019 14:50:35 +0000 (16:50 +0200)]
[NTUSER] Fix a few tests related to desktops and window stations
- NtUserOpenInputDesktop: Don't crash if there is no input desktop yet
- NtUserOpenInputDesktop: Fail if the process doesn't belong to the interactive window station
- NtUserCreateWindowStation: Clear error on success
- DesktopWindowProc: Use UserOpenInputDesktop to get a handle to the input desktop

3 months ago[RDBSS][RXCE] Implement IRP cancellation
Pierre Schweitzer [Wed, 2 Jan 2019 14:01:38 +0000 (15:01 +0100)]
[RDBSS][RXCE] Implement IRP cancellation

CORE-15441

3 months ago[TRANSLATION] Spanish translations (#944)
Julio Carchi [Wed, 2 Jan 2019 11:01:44 +0000 (06:01 -0500)]
[TRANSLATION] Spanish translations (#944)

3 months ago[NTOSKRNL] Add a raw implementation of !irpfind in kdbg
Pierre Schweitzer [Tue, 1 Jan 2019 20:58:18 +0000 (21:58 +0100)]
[NTOSKRNL] Add a raw implementation of !irpfind in kdbg

This is far from perfect, and totally doesn't match the
WinDBG way of doing it. Instead of browsing pool to find
matching 'IRP' tags, we just browse all the processes
to find the queued IRP. This requires the IRPs to be queued,
obviously, and will make us miss the leaked IRPs, for instance.

Proper way to do it would be to implement !poolfind and then
rely on its implementation to find our IRPs.

Perhaps later ;-)

3 months ago[TRANSLATION] Hindi translation of browseui, comctl32 and shell32 (#1209)
Arnav Bhatt [Tue, 1 Jan 2019 18:43:42 +0000 (00:13 +0530)]
[TRANSLATION] Hindi translation of browseui, comctl32 and shell32 (#1209)

3 months ago[LDR] Introduce a private heap for the loader. 1204/head
Mark Jansen [Sun, 14 Oct 2018 21:16:36 +0000 (23:16 +0200)]
[LDR] Introduce a private heap for the loader.
This ensures we can still do stuff when the process heap is corrupted.

3 months ago[BATTC] Fixed an oops!
Eric Kohl [Tue, 1 Jan 2019 12:48:43 +0000 (13:48 +0100)]
[BATTC] Fixed an oops!

3 months ago[BATTC] Some tiny fixes
Eric Kohl [Tue, 1 Jan 2019 12:13:20 +0000 (13:13 +0100)]
[BATTC] Some tiny fixes

- Add missing parameter to a DPRINT.
- Print pointers using %p instead of %x.
- Move all executable code behind a functions initial DPRINT.
- Do not use non-trivial initializers.
- Check for NULL instead of using !.
- Add missing parentheses.

3 months ago[BATTC] Fix indentation. No code changes!
Eric Kohl [Tue, 1 Jan 2019 11:58:53 +0000 (12:58 +0100)]
[BATTC] Fix indentation. No code changes!

3 months ago[TCPIP] Check buffer before dereferencing it
Pierre Schweitzer [Tue, 1 Jan 2019 09:45:48 +0000 (10:45 +0100)]
[TCPIP] Check buffer before dereferencing it

CID 716664

3 months ago[SETUP] Silence some noisy DPRINT1
Pierre Schweitzer [Tue, 1 Jan 2019 08:57:26 +0000 (09:57 +0100)]
[SETUP] Silence some noisy DPRINT1

3 months agoHappy New Year 2019 everybody!
Hermès Bélusca-Maïto [Mon, 31 Dec 2018 23:00:00 +0000 (00:00 +0100)]
Happy New Year 2019 everybody!

3 months ago[TRANSLATION] Update Chinese translation. (#1212)
Luo Yufan [Mon, 31 Dec 2018 20:47:58 +0000 (04:47 +0800)]
[TRANSLATION] Update Chinese translation. (#1212)

3 months ago[UMPNPMGR] PNP_GetDeviceList: Implement the enumeration of service device instances.
Eric Kohl [Mon, 31 Dec 2018 20:37:48 +0000 (21:37 +0100)]
[UMPNPMGR] PNP_GetDeviceList: Implement the enumeration of service device instances.

3 months ago[CONTRIBUTING] Add a notice for how to set your real name/mail (#1197)
Bișoc George [Mon, 31 Dec 2018 20:31:32 +0000 (21:31 +0100)]
[CONTRIBUTING] Add a notice for how to set your real name/mail (#1197)

Instead of posting the links each time, they'll be posted on README for future notice.

3 months ago[MPLAY32] Accept paths with double quotes from command-line (#1210)
Stanislav Motylkov [Mon, 31 Dec 2018 20:29:58 +0000 (23:29 +0300)]
[MPLAY32] Accept paths with double quotes from command-line (#1210)

CORE-15525

3 months ago[WIN32K] Deny deviceless calls to EngDeviceIoControl
Pierre Schweitzer [Mon, 31 Dec 2018 19:33:59 +0000 (20:33 +0100)]
[WIN32K] Deny deviceless calls to EngDeviceIoControl

This fixes BSOD happening in ntoskrnl coming from win32k under certain
conditions with 3rd party display drivers (such as VBox or VMware)

3 months ago[UMPNPMGR] PNP_GetDeviceListSize: Implement the buffer size calculation for the enume...
Eric Kohl [Mon, 31 Dec 2018 15:14:04 +0000 (16:14 +0100)]
[UMPNPMGR] PNP_GetDeviceListSize: Implement the buffer size calculation for the enumeration of services instances.

3 months ago[ZLIB] Import upstream commit 38e8ce32afbaa82f67d992b9f3056f281fe69259:
Hervé Poussineau [Mon, 31 Dec 2018 13:23:14 +0000 (14:23 +0100)]
[ZLIB] Import upstream commit 38e8ce32afbaa82f67d992b9f3056f281fe69259:

Fix CLEAR_HASH macro to be usable as a single statement.
As it is used in deflateParams().

3 months ago[TCPIP] Don't assume the TEB is always defined
Pierre Schweitzer [Mon, 31 Dec 2018 12:59:58 +0000 (13:59 +0100)]
[TCPIP] Don't assume the TEB is always defined

Fixes the crash in kmtest:TcpIpConnect test.

3 months ago[UMPNPMGR] PNP_GetDeviceList/PNP_GetDeviceListSize: Move device relations code into...
Eric Kohl [Mon, 31 Dec 2018 10:20:30 +0000 (11:20 +0100)]
[UMPNPMGR] PNP_GetDeviceList/PNP_GetDeviceListSize: Move device relations code into separate functions.

3 months ago[RTL] Fix RtlNewSecurityGrantedAccess improperly zeroing output buffer
Hervé Poussineau [Mon, 31 Dec 2018 10:11:43 +0000 (11:11 +0100)]
[RTL] Fix RtlNewSecurityGrantedAccess improperly zeroing output buffer

3 months ago[IPHLPAPI] Add support for service tags in GetOwnerModuleFromTcp/UdpEntry
Pierre Schweitzer [Mon, 31 Dec 2018 10:08:28 +0000 (11:08 +0100)]
[IPHLPAPI] Add support for service tags in GetOwnerModuleFromTcp/UdpEntry

If a service tag is set in owner information, then, we'll query advapi32 and
thus services to get the service name instead of the image name

3 months ago[TCPIP] Return the SubProcessTag when enumerating connections with owner class
Pierre Schweitzer [Mon, 31 Dec 2018 09:35:40 +0000 (10:35 +0100)]
[TCPIP] Return the SubProcessTag when enumerating connections with owner class

3 months ago[TCPIP] Save the SubProcessTag when an ADDRESS_FILE is created
Pierre Schweitzer [Mon, 31 Dec 2018 09:21:14 +0000 (10:21 +0100)]
[TCPIP] Save the SubProcessTag when an ADDRESS_FILE is created

3 months ago[SDK] Add PsGetCurrentThreadTeb() to the DDK
Pierre Schweitzer [Sun, 30 Dec 2018 21:47:36 +0000 (22:47 +0100)]
[SDK] Add PsGetCurrentThreadTeb() to the DDK

3 months ago[ADVAPI32_APITEST] Add tests showing that first field of OwningModuleInfo is the tag
Pierre Schweitzer [Sun, 30 Dec 2018 21:36:54 +0000 (22:36 +0100)]
[ADVAPI32_APITEST] Add tests showing that first field of OwningModuleInfo is the tag

Also, show that querying owner information about a connection owned by a service
returns the service name, and not the image nor its path.

Obviously, that fails in ReactOS.

3 months ago[FONT][WIN32SS] Partially implement font/text rotation (#1207)
Katayama Hirofumi MZ [Mon, 31 Dec 2018 09:56:43 +0000 (18:56 +0900)]
[FONT][WIN32SS] Partially implement font/text rotation (#1207)

Partially implement font/text rotation by LOGFONT.lfEscapement and improve the rendering image. If the angle was not a multiple of 90 degrees, then the background won't be filled. CORE-11848, CORE-15319

3 months ago[TRANSLATION] Update Chinese translation. (#1205)
Luo Yufan [Mon, 31 Dec 2018 09:47:37 +0000 (17:47 +0800)]
[TRANSLATION] Update Chinese translation. (#1205)

[NET][DISKPART][WINLOGON][ACCESS][APPWIZ][DESK][JOY][MMSYS][POWERCFG][SYSDM][NETCFGX][NETID][SAMSRV][TAPIUI][INF] Update Chinese translation.

3 months ago[APPWIZ] Do not hardcode the strings (#1208)
Bișoc George [Mon, 31 Dec 2018 07:42:53 +0000 (08:42 +0100)]
[APPWIZ] Do not hardcode the strings (#1208)

Let's make those message strings translatable.

3 months ago[SERVICES] Properly check again PID
Pierre Schweitzer [Sun, 30 Dec 2018 20:25:48 +0000 (21:25 +0100)]
[SERVICES] Properly check again PID

This fixes services not being found.
With that commit and the previous one, I_QueryTagInformation is now fully
functionnal and properly returns service name for a specific tag

3 months ago[SERVICES] pszName is a string, mark it so
Pierre Schweitzer [Sun, 30 Dec 2018 20:23:36 +0000 (21:23 +0100)]
[SERVICES] pszName is a string, mark it so

This fixes returning string with RI_ScQueryServiceTagInfo

3 months ago[ADVAPI32] When starting or sending a control to a service, set the tag in the TEB
Pierre Schweitzer [Sun, 30 Dec 2018 19:45:11 +0000 (20:45 +0100)]
[ADVAPI32] When starting or sending a control to a service, set the tag in the TEB

This now allows tracking the threads of the services thanks to their tag.

This fixes the failing test in advapi32:ServiceEnv