reactos.git
5 years ago[HIDCLASS][USBHUB]
Thomas Faber [Fri, 4 Sep 2015 17:31:58 +0000 (17:31 +0000)]
[HIDCLASS][USBHUB]
- Fix IRP leaks in success case of hidclass!HidClassFDO_GetDescriptors and usbhub!FowardUrbToRootHub

svn path=/trunk/; revision=69008

5 years ago[SETUPAPI] Partially sync query.c with Wine Staging 1.7.47. CORE-9924
Amine Khaldi [Fri, 4 Sep 2015 17:29:32 +0000 (17:29 +0000)]
[SETUPAPI] Partially sync query.c with Wine Staging 1.7.47. CORE-9924

svn path=/trunk/; revision=69007

5 years ago[CRT]
Pierre Schweitzer [Fri, 4 Sep 2015 16:49:51 +0000 (16:49 +0000)]
[CRT]
Fix memory allocation in __dllonexit

CID 514138

svn path=/trunk/; revision=69006

5 years ago[CRT]
Pierre Schweitzer [Fri, 4 Sep 2015 16:41:51 +0000 (16:41 +0000)]
[CRT]
Fix rand_s implementation so that it doesn't leak resources, so that it doesn't dereference null pointer, so that it matches MSDN documentation (https://msdn.microsoft.com/fr-fr/library/sxtz2fa8.aspx)

CID 716561
CID 716668

svn path=/trunk/; revision=69005

5 years ago[NTOS]
Thomas Faber [Fri, 4 Sep 2015 16:16:48 +0000 (16:16 +0000)]
[NTOS]
- Fix TAG_IRP

svn path=/trunk/; revision=69004

5 years ago[CDROM]
Thomas Faber [Fri, 4 Sep 2015 16:01:46 +0000 (16:01 +0000)]
[CDROM]
- Avoid IRP leaks

svn path=/trunk/; revision=69003

5 years ago[MOUNTMGR]
Pierre Schweitzer [Fri, 4 Sep 2015 15:58:44 +0000 (15:58 +0000)]
[MOUNTMGR]
Fix a nasty typo in QueryPointsFromMemory() which was like breaking the behavior of IOCTL_MOUNTMGR_QUERY_POINTS, IOCTL_MOUNTMGR_DELETE_POINTS

CID 1321853

svn path=/trunk/; revision=69002

5 years ago[NTFS]
Pierre Schweitzer [Fri, 4 Sep 2015 15:52:19 +0000 (15:52 +0000)]
[NTFS]
Don't bother comparing names if they have null length

svn path=/trunk/; revision=69001

5 years ago[NTFS]
Pierre Schweitzer [Fri, 4 Sep 2015 15:37:15 +0000 (15:37 +0000)]
[NTFS]
Don't attempt to dereference a null pointer
CID 1321987

svn path=/trunk/; revision=69000

5 years ago[BOOTMGFW]
Thomas Faber [Fri, 4 Sep 2015 15:33:12 +0000 (15:33 +0000)]
[BOOTMGFW]
- Fix build with RUNTIME_CHECKS (and hopefully STACK_PROTECTOR)

svn path=/trunk/; revision=68999

5 years ago[TOOLS]
Thomas Faber [Fri, 4 Sep 2015 15:22:16 +0000 (15:22 +0000)]
[TOOLS]
- Fix MSVC warnings for C++ host-tools

svn path=/trunk/; revision=68998

5 years ago[BOOTMGFW] Add missing dependency.
Amine Khaldi [Fri, 4 Sep 2015 14:45:40 +0000 (14:45 +0000)]
[BOOTMGFW] Add missing dependency.

svn path=/trunk/; revision=68997

5 years ago[BOOTMGFW] Add missing dependency.
Amine Khaldi [Fri, 4 Sep 2015 14:43:01 +0000 (14:43 +0000)]
[BOOTMGFW] Add missing dependency.

svn path=/trunk/; revision=68996

5 years ago[BOOTMGFW] Set the subsystem differently between GCC and MSVC builds.
Amine Khaldi [Fri, 4 Sep 2015 14:40:15 +0000 (14:40 +0000)]
[BOOTMGFW] Set the subsystem differently between GCC and MSVC builds.

svn path=/trunk/; revision=68995

5 years ago[TXTSETUP]
Alex Ionescu [Fri, 4 Sep 2015 14:26:09 +0000 (14:26 +0000)]
[TXTSETUP]
Still takes 3 commits to get 1 right.

svn path=/trunk/; revision=68994

5 years ago[BOOTMGFW]
Alex Ionescu [Fri, 4 Sep 2015 14:23:45 +0000 (14:23 +0000)]
[BOOTMGFW]
Try to fix header.

svn path=/trunk/; revision=68993

5 years ago[BOOTMGFW]
Alex Ionescu [Fri, 4 Sep 2015 14:16:56 +0000 (14:16 +0000)]
[BOOTMGFW]
Nothing to see here. I hope this doesn't break the build.

svn path=/trunk/; revision=68992

5 years ago[MUP]
Pierre Schweitzer [Fri, 4 Sep 2015 13:58:44 +0000 (13:58 +0000)]
[MUP]
Fix uninitialized address freeing in case of error in MupGetProviderInformation(), InitializeProvider()
CID 1322227
CID 1322240

svn path=/trunk/; revision=68990

5 years ago[USBSTOR] fix memory leaks CID 1322134
Christoph von Wittich [Fri, 4 Sep 2015 12:05:14 +0000 (12:05 +0000)]
[USBSTOR] fix memory leaks CID 1322134

svn path=/trunk/; revision=68989

5 years ago[SHELL32] fix a memory leak CID 1322145
Christoph von Wittich [Fri, 4 Sep 2015 11:43:48 +0000 (11:43 +0000)]
[SHELL32] fix a memory leak CID 1322145

svn path=/trunk/; revision=68988

5 years ago[WIN32SS] fix memory leak in error case CID 716637
Christoph von Wittich [Fri, 4 Sep 2015 09:39:08 +0000 (09:39 +0000)]
[WIN32SS] fix memory leak in error case CID 716637

svn path=/trunk/; revision=68987

5 years ago[FASTFAT]
Thomas Faber [Fri, 4 Sep 2015 08:37:01 +0000 (08:37 +0000)]
[FASTFAT]
- Don't try to free an uninitialized pointer in VfatSetRenameInformation. CID 1250303
- Actually use the dynamically calculated HashTableSize. CID 1237119/1237120/1237121

svn path=/trunk/; revision=68986

5 years ago[I8042PRT] fix memory leak CID 1322163
Christoph von Wittich [Fri, 4 Sep 2015 08:32:00 +0000 (08:32 +0000)]
[I8042PRT] fix memory leak CID 1322163

svn path=/trunk/; revision=68985

5 years ago[SERVMAN] fix memory leak CID 1322153
Christoph von Wittich [Fri, 4 Sep 2015 08:29:08 +0000 (08:29 +0000)]
[SERVMAN] fix memory leak CID 1322153

svn path=/trunk/; revision=68984

5 years ago[DHCPSVC] fix resource leak in error case CID 1248422
Christoph von Wittich [Fri, 4 Sep 2015 08:15:11 +0000 (08:15 +0000)]
[DHCPSVC] fix resource leak in error case CID 1248422

svn path=/trunk/; revision=68983

5 years ago[RSYM]
Thomas Faber [Fri, 4 Sep 2015 08:06:17 +0000 (08:06 +0000)]
[RSYM]
- This is not the typo you are looking for

svn path=/trunk/; revision=68982

5 years ago[CRT] fix resource leak in error case CID 716561
Christoph von Wittich [Fri, 4 Sep 2015 08:02:53 +0000 (08:02 +0000)]
[CRT] fix resource leak in error case CID 716561

svn path=/trunk/; revision=68981

5 years ago[RSYM]
Thomas Faber [Fri, 4 Sep 2015 08:02:35 +0000 (08:02 +0000)]
[RSYM]
- Sort symbol entries with line number information before those without. Fixes backtraces showing ":0" as file/line for the first line of a function

svn path=/trunk/; revision=68980

5 years ago[PORTCLS] fix memory leak in error case CID 716555
Christoph von Wittich [Fri, 4 Sep 2015 07:59:51 +0000 (07:59 +0000)]
[PORTCLS] fix memory leak in error case CID 716555

svn path=/trunk/; revision=68979

5 years ago[WDMAUD.DRV] fix memory leak in error case CID 716484
Christoph von Wittich [Fri, 4 Sep 2015 07:55:30 +0000 (07:55 +0000)]
[WDMAUD.DRV] fix memory leak in error case CID 716484

svn path=/trunk/; revision=68978

5 years ago[NSLOOKUP] fix resource leaks CID 701325
Christoph von Wittich [Fri, 4 Sep 2015 07:48:18 +0000 (07:48 +0000)]
[NSLOOKUP] fix resource leaks CID 701325

svn path=/trunk/; revision=68977

5 years ago[NTKRNLMP]
Thomas Faber [Fri, 4 Sep 2015 06:37:05 +0000 (06:37 +0000)]
[NTKRNLMP]
- Apply link flags to the right module

svn path=/trunk/; revision=68976

5 years ago[VSSAPI]
Hermès Bélusca-Maïto [Fri, 4 Sep 2015 01:14:51 +0000 (01:14 +0000)]
[VSSAPI]
Compile the THISCALL calling convention support only for x86. On x64, we are automatically in THISCALL.
Also I suggest we turn this file (and maybe also /lib/sdk/crt/except/i386/cpp.s) into a "msvc-thiscall.c" as it is already done in some other DLLs (like in ole32, riched20).
Fixes build in x64.

svn path=/trunk/; revision=68975

5 years ago[few apps][LOGONUI][FREELDR][MSGINA][BLUE] VOIDify function paramater lists when...
Hermès Bélusca-Maïto [Fri, 4 Sep 2015 00:21:03 +0000 (00:21 +0000)]
[few apps][LOGONUI][FREELDR][MSGINA][BLUE] VOIDify function paramater lists when they indeed don't take any arguments.

svn path=/trunk/; revision=68974

5 years ago[WIN32SS] VOIDify function paramater lists when they indeed don't take any arguments.
Hermès Bélusca-Maïto [Fri, 4 Sep 2015 00:11:49 +0000 (00:11 +0000)]
[WIN32SS] VOIDify function paramater lists when they indeed don't take any arguments.

svn path=/trunk/; revision=68973

5 years agoForgot those three ones.
Hermès Bélusca-Maïto [Thu, 3 Sep 2015 23:59:27 +0000 (23:59 +0000)]
Forgot those three ones.

svn path=/trunk/; revision=68972

5 years ago[NTDLL][HAL][INFLIB][RTL][NTOS] VOIDify function paramater lists when they indeed...
Hermès Bélusca-Maïto [Thu, 3 Sep 2015 23:57:39 +0000 (23:57 +0000)]
[NTDLL][HAL][INFLIB][RTL][NTOS] VOIDify function paramater lists when they indeed don't take any arguments.

svn path=/trunk/; revision=68971

5 years ago[NTOSKRNL]
Pierre Schweitzer [Thu, 3 Sep 2015 22:19:16 +0000 (22:19 +0000)]
[NTOSKRNL]
Mark more functions as INIT

svn path=/trunk/; revision=68970

5 years ago[SHELL32]
Aleksandar Andrejevic [Thu, 3 Sep 2015 22:16:28 +0000 (22:16 +0000)]
[SHELL32]
Make the RLE-compressed AVIs even smaller.
CORE-10093 #resolve #comment Fixed in revision r68969.

svn path=/trunk/; revision=68969

5 years ago[ADVAPI32]
Pierre Schweitzer [Thu, 3 Sep 2015 21:27:51 +0000 (21:27 +0000)]
[ADVAPI32]
Fix memory leaks in case of failure

CID 1322129
CID 1322130

svn path=/trunk/; revision=68968

5 years ago[MUP]
Pierre Schweitzer [Thu, 3 Sep 2015 21:19:05 +0000 (21:19 +0000)]
[MUP]
Fix an hypthetic uninit var usage in MupCreate().
Dedicated to Chris.

CID 1322239

svn path=/trunk/; revision=68967

5 years ago[INTL]
Eric Kohl [Thu, 3 Sep 2015 20:37:17 +0000 (20:37 +0000)]
[INTL]
- Update all values in "HKCU\Control Panel\International" when a new language is selected.
- Update the language examples after a language change.
- Disable all settings that should not be affected by a language change.
Missing:
- Top-level windows do not get notification yet.
- Language settings customization should not work yet.
CORE-10074

svn path=/trunk/; revision=68966

5 years ago[CDFS]
Pierre Schweitzer [Thu, 3 Sep 2015 20:34:47 +0000 (20:34 +0000)]
[CDFS]
[FASTFAT]
[MUP]
[NTFS]
Mark DriverEntry() and associated functions as INIT

svn path=/trunk/; revision=68965

5 years ago- Now that we actually take the trouble to set up MmLargeStackSize properly, use...
Stefan Ginsberg [Thu, 3 Sep 2015 20:04:28 +0000 (20:04 +0000)]
- Now that we actually take the trouble to set up MmLargeStackSize properly, use it! Also make it possible to set via the registry by adding it to the control vector table.

svn path=/trunk/; revision=68964

5 years ago[SHELL32]
Aleksandar Andrejevic [Thu, 3 Sep 2015 19:42:46 +0000 (19:42 +0000)]
[SHELL32]
RLE-compress the AVIs.

svn path=/trunk/; revision=68963

5 years ago- Enable INIT_FUNCTION for HAL while keeping FreeLdr happy and not putting anything...
Stefan Ginsberg [Thu, 3 Sep 2015 17:52:13 +0000 (17:52 +0000)]
- Enable INIT_FUNCTION for HAL while keeping FreeLdr happy and not putting anything into .INIT when compiling mini-HAL for it.

svn path=/trunk/; revision=68962

5 years ago[RECYCLEBIN] tabs to spaces (no code changes)
Christoph von Wittich [Thu, 3 Sep 2015 17:40:13 +0000 (17:40 +0000)]
[RECYCLEBIN] tabs to spaces (no code changes)

svn path=/trunk/; revision=68961

5 years ago[RECYCLEBIN] fix some resource leaks CID 716559 716560
Christoph von Wittich [Thu, 3 Sep 2015 17:35:37 +0000 (17:35 +0000)]
[RECYCLEBIN] fix some resource leaks CID 716559 716560

svn path=/trunk/; revision=68960

5 years ago- Don't put VdmpInitialize in .INIT either as it is not called during kernel initiali...
Stefan Ginsberg [Thu, 3 Sep 2015 16:52:28 +0000 (16:52 +0000)]
- Don't put VdmpInitialize in .INIT either as it is not called during kernel initialization, but from videoport driver during its initialization. CORE-10097

svn path=/trunk/; revision=68938

5 years ago- Enable placing kernel functions in the .INIT section (GCC only, MSVC is TBD). This...
Stefan Ginsberg [Thu, 3 Sep 2015 15:31:09 +0000 (15:31 +0000)]
- Enable placing kernel functions in the .INIT section (GCC only, MSVC is TBD). This allows them to be freed from memory after initialization is finished.
- PspMapSystemDll and IopDisplayLoadingMessage are called from non-initialization code, so don't put them in .INIT. CmpHiveRootSecurityDescriptor is called from initialization code, but too late in boot, so don't discard it either.
- Trying to enable this for HAL as well leads to a weird crash very early in boot. Investigation is ongoing. Until then we will just have to keep the huge PCI Class/Vendor tables in memory...
- Enable it for Win32k though as it seems to work fine there.
- Remove INIT_FUNCTION from function prototypes, it serves no purpose there.
See issue 10097 for more details.

svn path=/trunk/; revision=68937

5 years ago[Win32SS]
James Tabor [Thu, 3 Sep 2015 14:29:53 +0000 (14:29 +0000)]
[Win32SS]
- Fix hilite text with objects. Mirror changes.

svn path=/trunk/; revision=68936

5 years ago[RTL]
James Tabor [Thu, 3 Sep 2015 12:59:26 +0000 (12:59 +0000)]
[RTL]
- Fix Underscore drawing for Win32k and related functions.

svn path=/trunk/; revision=68935

5 years ago[NTFS]
Pierre Schweitzer [Thu, 3 Sep 2015 12:57:04 +0000 (12:57 +0000)]
[NTFS]
Remove deadcode CID 1321946

svn path=/trunk/; revision=68934

5 years ago[NTFS]
Pierre Schweitzer [Thu, 3 Sep 2015 12:49:36 +0000 (12:49 +0000)]
[NTFS]
With the newly introduced mechanism (in r68829), on attributes list loop, there shouldn't be any AttributeList attribute anymore.
So, don't attempt to dump them.

svn path=/trunk/; revision=68933

5 years ago[WS2_32] leave critical section in error case CID 716028
Christoph von Wittich [Thu, 3 Sep 2015 11:22:11 +0000 (11:22 +0000)]
[WS2_32] leave critical section in error case CID 716028

svn path=/trunk/; revision=68932

5 years ago[OSK] fix resource leak in error case CID 1322148
Christoph von Wittich [Thu, 3 Sep 2015 09:33:58 +0000 (09:33 +0000)]
[OSK] fix resource leak in error case CID 1322148

svn path=/trunk/; revision=68931

5 years ago- Explicitly make the kernel .rsrc/Resource Directory non-discardable and non-pageabl...
Stefan Ginsberg [Thu, 3 Sep 2015 09:29:26 +0000 (09:29 +0000)]
- Explicitly make the kernel .rsrc/Resource Directory non-discardable and non-pageable on MSVC builds, as it is accessed from bugcheck code. Previously this data was marked as discardable and the bugcheck routine would bugcheck (after a certain stage in boot) when trying to access the bugcheck code data because the data was discarded and the memory invalidated. Thanks to Thomas for the help and the fix.

svn path=/trunk/; revision=68930

5 years ago[WINLOGON] fix resource leak in error case CID 1322159
Christoph von Wittich [Thu, 3 Sep 2015 08:48:31 +0000 (08:48 +0000)]
[WINLOGON] fix resource leak in error case CID 1322159

svn path=/trunk/; revision=68929

5 years ago[CRT] Addendum to r68927
Christoph von Wittich [Thu, 3 Sep 2015 07:42:05 +0000 (07:42 +0000)]
[CRT] Addendum to r68927

svn path=/trunk/; revision=68928

5 years ago[CRT] atan2 pass arguments in the correct order CID 1322203
Christoph von Wittich [Thu, 3 Sep 2015 07:35:54 +0000 (07:35 +0000)]
[CRT] atan2 pass arguments in the correct order CID 1322203

svn path=/trunk/; revision=68927

5 years ago[KERNEL32_WINETEST]
Thomas Faber [Thu, 3 Sep 2015 07:18:00 +0000 (07:18 +0000)]
[KERNEL32_WINETEST]
- Enable test_thread_fpu_cw on MSVC builds

svn path=/trunk/; revision=68926

5 years ago[NTOS:SE] fix uninitialized variable usage CID 1322236
Christoph von Wittich [Thu, 3 Sep 2015 07:15:52 +0000 (07:15 +0000)]
[NTOS:SE] fix uninitialized  variable usage CID 1322236

svn path=/trunk/; revision=68925

5 years ago[EXPLORER] proper fix for CID 1321923, 1321924
Christoph von Wittich [Thu, 3 Sep 2015 07:01:29 +0000 (07:01 +0000)]
[EXPLORER] proper fix for CID 13219231321924

svn path=/trunk/; revision=68924

5 years ago[EXPLORER] remove dead code CID 1321923, 1321924
Christoph von Wittich [Thu, 3 Sep 2015 06:24:13 +0000 (06:24 +0000)]
[EXPLORER] remove dead code CID 13219231321924

svn path=/trunk/; revision=68923

5 years ago[Win32k]
James Tabor [Wed, 2 Sep 2015 23:25:48 +0000 (23:25 +0000)]
[Win32k]
- Yes we must specify everything in ReactOS. Fix CORE-10085.

svn path=/trunk/; revision=68922

5 years ago- Remove test code from nonclient.
James Tabor [Wed, 2 Sep 2015 23:08:04 +0000 (23:08 +0000)]
- Remove test code from nonclient.

svn path=/trunk/; revision=68921

5 years ago[Win32k]
James Tabor [Wed, 2 Sep 2015 23:06:19 +0000 (23:06 +0000)]
[Win32k]
- Use the same style for get messages in nonclient.
- Remove bit checks left over from testing. Fix CORE-10086.

svn path=/trunk/; revision=68920

5 years ago[COM_APITEST]
Sylvain Petreolle [Wed, 2 Sep 2015 20:52:34 +0000 (20:52 +0000)]
[COM_APITEST]
Do not test for ISFHelper anymore.

svn path=/trunk/; revision=68919

5 years ago[RTL]
Pierre Schweitzer [Wed, 2 Sep 2015 20:18:42 +0000 (20:18 +0000)]
[RTL]
Finally, use the correct implementation for RtlAssert().

In testbots, the behavior will be the following:
On prompt, sysreg will always issue a 'break once' instruction. In umode, where kdbg isn't instructed to handle breakpoint, this will lead to application being killed. With a lot of noise. This matches previous behavior.
In kmode, where kdbg handles breakpoints, sysreg2 will ask for a bt and will reboot the VM. As it was done previously.

The testbots already have the newest available sysreg2 revision.

This was made possible thanks to the help of Stefan and Thomas.
It was also made possible thanks to the commits:
- in trunk: r68899, r68905, r68917
- in project-tools: r2074, r2232

CORE-10088 #resolve #comment Fixed with r68918

svn path=/trunk/; revision=68918

5 years ago[KERNEL32]
Pierre Schweitzer [Wed, 2 Sep 2015 20:11:39 +0000 (20:11 +0000)]
[KERNEL32]
Always print information about unhandled exception, even when GUI error dialog boxes are disabled

CORE-10088

svn path=/trunk/; revision=68917

5 years ago[SHELL32] - Remove Reactos only ISFHelper interface that is no longer used.
Giannis Adamopoulos [Wed, 2 Sep 2015 18:20:40 +0000 (18:20 +0000)]
[SHELL32] - Remove Reactos only ISFHelper interface that is no longer used.

svn path=/trunk/; revision=68916

5 years ago[SHELL32]
Giannis Adamopoulos [Wed, 2 Sep 2015 13:14:46 +0000 (13:14 +0000)]
[SHELL32]
- CNewMenu: Get the folder path from the pidl passed in the Initialize method. No need to query the defview for that.
- Dont use a reactos only interface to create a new directory. Prefer to do it with less code using exported functions.
- Add a new SelectNewItem method that is used when creating a new file or directory.
- Apply same fix for browse for folder dialog.

svn path=/trunk/; revision=68915

5 years ago[CRT] just print the error number if we don't have a matching string
Christoph von Wittich [Wed, 2 Sep 2015 12:33:11 +0000 (12:33 +0000)]
[CRT] just print the error number if we don't have a matching string

svn path=/trunk/; revision=68914

5 years ago[CRT] fix null pointer deref in _gmtime64_s CID 515314
Christoph von Wittich [Wed, 2 Sep 2015 10:20:21 +0000 (10:20 +0000)]
[CRT] fix null pointer deref in _gmtime64_s CID 515314

svn path=/trunk/; revision=68913

5 years ago[SHELL32] - Fix copy paste bug
Giannis Adamopoulos [Wed, 2 Sep 2015 09:31:16 +0000 (09:31 +0000)]
[SHELL32] - Fix copy paste bug

svn path=/trunk/; revision=68912

5 years ago[NTOS:SE]
Thomas Faber [Wed, 2 Sep 2015 09:19:52 +0000 (09:19 +0000)]
[NTOS:SE]
- Correctly check ACE type in SeFastTraverseCheck. CID 1102005

svn path=/trunk/; revision=68911

5 years ago[NTMARTA] fix copypasta
Christoph von Wittich [Wed, 2 Sep 2015 08:56:58 +0000 (08:56 +0000)]
[NTMARTA] fix copypasta

svn path=/trunk/; revision=68910

5 years ago[RTL]
Thomas Faber [Wed, 2 Sep 2015 05:38:02 +0000 (05:38 +0000)]
[RTL]
- Fix check for optional parameters in RtlGetCallersAddress

svn path=/trunk/; revision=68909

5 years ago[Win32k]
James Tabor [Tue, 1 Sep 2015 23:58:23 +0000 (23:58 +0000)]
[Win32k]
- Fix painting message regression.

svn path=/trunk/; revision=68908

5 years ago- Implement super-simple KeSweepICache that always flushes the entire instruction...
Stefan Ginsberg [Tue, 1 Sep 2015 23:45:48 +0000 (23:45 +0000)]
- Implement super-simple KeSweepICache that always flushes the entire instruction cache. Use it in KD64 after modifying memory to make sure CPU gets the correct code to execute, and in NtFlushInstructionCache. May improve breakpoints somewhat.
- Move NtFlushInstructionCache from sysinfo.c to virtual.c where it fits better. Likewise, move it from kefuncs to mmfuncs in NDK, and fix function arguments (ULONG -> SIZE_T).
- Re-enable TRAP_DEBUG, adding back critical checks in the trap code. Checks can be improved but it is better than potentially silently messing up system state.
- Move remaining RtlPrefetchMemoryNonTemporal code into kernel. Stubbed for non-x86.
- By Hermes suggestion, override ASSERT to NT_ASSERT only for MSVC builds as that is where the main benefit is.

svn path=/trunk/; revision=68907

5 years ago[HHPCOMP]
Pierre Schweitzer [Tue, 1 Sep 2015 22:44:56 +0000 (22:44 +0000)]
[HHPCOMP]
Fix headers inclusion on MacOSX.
This fixes hhpcomp build on MacOSX
Patch by Nicolas Rouvière

CORE-10084 #resolve #comment Committed in r68906. Thanks!

svn path=/trunk/; revision=68906

5 years ago[NTOSKRNL]
Pierre Schweitzer [Tue, 1 Sep 2015 22:32:55 +0000 (22:32 +0000)]
[NTOSKRNL]
Fix KdpPrompt():
- Don't attempt to return in the middle of the loop. It leads to keep the mouse disabled instead of reenabling it.
- Also, return a string length that actually matches what was written to the output buffer.

This fixes invalid behavior on RtlAssert when used with #if 0 moved to #if 1, or when Windows NTDLL is used in ReactOS.

CORE-10082 #resolve #comment Fixed with r68905
CORE-10083 #resolve #comment Fixed with r68905

svn path=/trunk/; revision=68905

5 years ago[Win32SS|UxTheme]
James Tabor [Tue, 1 Sep 2015 22:10:13 +0000 (22:10 +0000)]
[Win32SS|UxTheme]
- Move Menu to server side. See CORE-7797 and CORE-8299.
- This was for speed while moving windows about the desktop and fixed test results too.

svn path=/trunk/; revision=68904

5 years ago- Move misplaced RtlPrefetchMemoryNonTemporal from rtl into kernel where it belongs...
Stefan Ginsberg [Tue, 1 Sep 2015 19:51:52 +0000 (19:51 +0000)]
- Move misplaced RtlPrefetchMemoryNonTemporal from rtl into kernel where it belongs (it only exists as an export for use by drivers to safely try to use prefetchnta even if it may not be available). Use existing global KePrefetchNTAGranularity that is set to the correct value via cpuid instead of hardcoded "Ke386CacheAlignment".

svn path=/trunk/; revision=68903

5 years ago[NTOS:KE]
Thomas Faber [Tue, 1 Sep 2015 18:26:29 +0000 (18:26 +0000)]
[NTOS:KE]
- Enable DPC timeout check on debug builds. Suggested by Stefan

svn path=/trunk/; revision=68902

5 years ago[NTOS:EX]
Thomas Faber [Tue, 1 Sep 2015 17:52:09 +0000 (17:52 +0000)]
[NTOS:EX]
- Remove the timer's list entry instead of the list head in NtSetTimer and NtCancelTimer. Fixes list entry corruption on VMware Hybrid builder
CORE-10081 #resolve

svn path=/trunk/; revision=68901

5 years ago[NTOSKRNL]
Pierre Schweitzer [Tue, 1 Sep 2015 17:32:34 +0000 (17:32 +0000)]
[NTOSKRNL]
Fix MSVC build?

svn path=/trunk/; revision=68900

5 years ago[NTOSKRNL]
Pierre Schweitzer [Tue, 1 Sep 2015 17:23:56 +0000 (17:23 +0000)]
[NTOSKRNL]
Probe buffers in case they come from user-mode in KdpPrint() and KdpPrompt().
This fixes two fixme.

svn path=/trunk/; revision=68899

5 years ago[CRT]
Thomas Faber [Tue, 1 Sep 2015 14:57:30 +0000 (14:57 +0000)]
[CRT]
- Rewrite _fpreset based on Wine. Fixes the last kernel32:thread test failure

svn path=/trunk/; revision=68898

5 years ago[NETAPI32]
Thomas Faber [Tue, 1 Sep 2015 14:09:51 +0000 (14:09 +0000)]
[NETAPI32]
- Correctly reallocate buffer in NetWkstaUserGetInfo. Fixes one of the many exceptions when running netapi32 tests with DPH.

svn path=/trunk/; revision=68897

5 years ago[PSDK]
Thomas Faber [Tue, 1 Sep 2015 14:07:06 +0000 (14:07 +0000)]
[PSDK]
- Sync access.idl and msinkaut.idl with Wine. Fixes MIDL warnings.

svn path=/trunk/; revision=68896

5 years ago[STOBJECT] only change the volume icon when the state changed
Christoph von Wittich [Tue, 1 Sep 2015 13:55:34 +0000 (13:55 +0000)]
[STOBJECT] only change the volume icon when the state changed

svn path=/trunk/; revision=68895

5 years ago- Fix what should hopefully be the last bug in the floating point state save/load...
Stefan Ginsberg [Tue, 1 Sep 2015 13:20:50 +0000 (13:20 +0000)]
- Fix what should hopefully be the last bug in the floating point state save/load code -- in KiNpxHandler check if the state is loaded before unloading it instead of checking if it is *unloaded* before... unloading it. Also clear up some comments.
- Thomas is da man.

svn path=/trunk/; revision=68894

5 years ago[EXPLORER]
David Quintana [Tue, 1 Sep 2015 12:32:05 +0000 (12:32 +0000)]
[EXPLORER]
* Remove old icons from the tray imagelist.

svn path=/trunk/; revision=68893

5 years ago[SHELL32]
Giannis Adamopoulos [Tue, 1 Sep 2015 10:18:40 +0000 (10:18 +0000)]
[SHELL32]
- Fix a hack that broke copying files after recent fixes.

svn path=/trunk/; revision=68892

5 years ago- You know what, NT_ASSERT is awesome.
Stefan Ginsberg [Tue, 1 Sep 2015 09:25:18 +0000 (09:25 +0000)]
- You know what, NT_ASSERT is awesome.

svn path=/trunk/; revision=68891

5 years ago- Missed these. Goodbye NT_ASSERT.
Stefan Ginsberg [Tue, 1 Sep 2015 08:41:39 +0000 (08:41 +0000)]
- Missed these. Goodbye NT_ASSERT.

svn path=/trunk/; revision=68890

5 years ago[Win32k]
James Tabor [Tue, 1 Sep 2015 01:48:37 +0000 (01:48 +0000)]
[Win32k]
- Fix more ATI issues, pass more related tests. See CORE-6551.

svn path=/trunk/; revision=68889

5 years ago- Remove all NT_ASSERT from the kernel and replace with good old ASSERT, for ease...
Stefan Ginsberg [Tue, 1 Sep 2015 01:45:59 +0000 (01:45 +0000)]
- Remove all NT_ASSERT from the kernel and replace with good old ASSERT, for ease of debugging, especially for tests run on the build servers. There is no need to use NT_ASSERT in the kernel.
- The fish is long gone.

svn path=/trunk/; revision=68888

5 years ago- Fix link fix build.
Stefan Ginsberg [Tue, 1 Sep 2015 00:38:40 +0000 (00:38 +0000)]
- Fix link fix build.

svn path=/trunk/; revision=68887