Eric Kohl [Sun, 25 Aug 2019 09:39:12 +0000 (11:39 +0200)]
[NETAPI32] Implement DsAddressToSiteNamesA and DsAddressToSiteNamesExA
Ioannis Adamopoulos [Sun, 25 Aug 2019 09:17:42 +0000 (12:17 +0300)]
[HEADERS] Move some helpers from undocshell.h to shellutils.h as they didn't cover anything undocumented. Merge traycmd.h in undocshell.h as both contain just undocumented shell definitions.
Eric Kohl [Sun, 25 Aug 2019 09:15:00 +0000 (11:15 +0200)]
[NETAPI32] Fix a typo in DsDeregisterDnsHostRecordsA
Thank you very much UserNT and Thomas for the hint!
Katayama Hirofumi MZ [Sun, 25 Aug 2019 03:07:31 +0000 (12:07 +0900)]
[SETUPLIB][USETUP] Fix build about switch
Katayama Hirofumi MZ [Sun, 25 Aug 2019 02:37:26 +0000 (11:37 +0900)]
[MEDIA][FONTS] Add Thai MS Sans Serif (ssee874.fon) CORE-16166
Hermès Bélusca-Maïto [Sun, 25 Aug 2019 00:08:23 +0000 (02:08 +0200)]
[SETUPLIB][USETUP] Slightly modify how and when the HW system partition is detected and used.
CORE-16274
SETUPLIB:
=========
- Find the system partition initially when we create the list of
partitions.
- Split the old CheckActiveSystemPartition() helper in two helpers:
FindSupportedSystemPartition() and SetActivePartition(). This allows
simplifying slightly the former one, and allows the user, in an
interactive situation, to decide whether the "supported system
partition" found can actually be used or not.
- Remove the "OriginalSystemPartition" hack in the PARTLIST structure.
- Add a note regarding the SystemPartition member in PARTLIST.
USETUP:
=======
- Use the introduced helpers from above. If the "system" partition we
are going to use, in case we install ReactOS on a fixed disk, is *NOT*
the same as the original one (e.g. because it is detected to be not
supported by ReactOS...), display an informative screen to the user
and let him confirm whether or not he wants to change the partition.
If we install on a fixed disk, try to find a supported system partition
on the system. Otherwise if we install on a removable disk, use the
install partition as the system partition instead.
This allows providing a fix for CORE-16274.
Hermès Bélusca-Maïto [Sat, 24 Aug 2019 23:32:46 +0000 (01:32 +0200)]
[SETUPLIB][USETUP] Code simplifications & fixes.
SETUPLIB:
=========
- Remove useless HiddenSectors member in PARTENTRY structure.
- InsertDiskRegion() helper returns a BOOLEAN success.
- CreateInsertBlankRegion() helper sets LogicalPartition.
- Simplify the InitializePartitionEntry() helper so that its PartEntry
parameter is clearly the one that is being initialized (i.e. converted
from a blank region to) an actual partition, and use the helper
CreateInsertBlankRegion(). The calculations for the StartSector and
SectorCount are exactly equivalent with the old version of this
function. Also make it return a BOOLEAN success instead.
+ Add some extra validation checks.
+ Adjust CreatePrimaryPartition(), CreateExtendedPartition() and
CreateLogicalPartition() in this regard.
- Better handling of "RAW"-mounted partitions: treat them as
"Unformatted" only if they are RAW *AND* their PartitionType is one of
those associated with FAT file-system. Otherwise we cannot decide
whether they are indeed unformatted or have an unknown file-system on
them, therefore treat them as the latter.
In this regard, the IsSupportedActivePartition() helper should not
look for FileSystem == RAW but instead only look whether the partition
is Unformatted.
This should help with situations similar to the one described in CORE-16274
where a partition with a genuine file-system but not recognized by
ReactOS (because we currently do not have the EXT2/3/4 filesystem
driver loaded during 1st-stage setup due to commit
5a650f6b) and
therefore mounted as RAW, was thought to be unformatted.
USETUP:
=======
- Use the "global" SystemPartition pointer: this is the "system"
partition we will actually use. It can be different from the actual
one of the computer, for example when we install ReactOS on a
removable disk. This allows also to simplify the code.
- Remove the single-used DestinationDriveLetter variable.
- Remove BuildInstallPaths() helper and use InitDestinationPaths()
directly instead.
- Always mention the disk where the partition being formatted is.
- Cleanup old code comments, add assertions here & there...
Eric Kohl [Sat, 24 Aug 2019 20:57:36 +0000 (22:57 +0200)]
[NETAPI32] Implement DsDeregisterDnsHostRecordsA
Eric Kohl [Sat, 24 Aug 2019 19:40:11 +0000 (21:40 +0200)]
[NETAPI32] Implement DsGetDcNameWithAccountA
Eric Kohl [Sat, 24 Aug 2019 17:44:37 +0000 (19:44 +0200)]
[NETAPI32] Implement DsGetDcSiteCoverageA
Eric Kohl [Sat, 24 Aug 2019 12:00:33 +0000 (14:00 +0200)]
[NETAPI32] Add the NetpAllocStrFromWStr helper function
Eric Kohl [Sat, 24 Aug 2019 11:15:41 +0000 (13:15 +0200)]
[NETAPI32] Implement DsGetSiteNameA
Also add the NetpAllocAnsiStrFromWStr helper function.
Eric Kohl [Sat, 24 Aug 2019 08:02:55 +0000 (10:02 +0200)]
[NTOSKRNL] Fix indentation. No code changes!
Mark Jansen [Tue, 20 Aug 2019 17:09:10 +0000 (19:09 +0200)]
[TESTS] Add a test for spec2def
Timo Kreuzer [Sat, 17 Aug 2019 18:29:16 +0000 (20:29 +0200)]
[CMAKE] Turn C4715: "'function': not all control paths return a value" into an error on MSVC builds
Mark Jansen [Tue, 20 Aug 2019 12:20:17 +0000 (14:20 +0200)]
[NTOSKRNL] Demote some noisy dprints
Mark Jansen [Tue, 20 Aug 2019 12:19:29 +0000 (14:19 +0200)]
[SETUPAPI] Demote some noisy dprints
Mark Jansen [Sun, 23 Dec 2018 17:36:59 +0000 (18:36 +0100)]
[NTDLL] Use the embedded manifest from the process to check compatibility.
Shy Zedaka [Wed, 21 Aug 2019 10:03:32 +0000 (13:03 +0300)]
[TRANSLATION] Changes to Newdev and hdwwiz
Shy Zedaka [Mon, 19 Aug 2019 17:41:20 +0000 (20:41 +0300)]
[TRANSLATION] Change the recycle bin from 'Trash' to 'Recycle bin'
Serge Gautherie [Wed, 21 Aug 2019 07:01:47 +0000 (09:01 +0200)]
[README.WINE] Update paths and add winetests/iphlpapi (#1866)
Mark Jansen [Sun, 18 Aug 2019 19:48:44 +0000 (21:48 +0200)]
[CRT_APITEST] Exclude a test with the same rule as in the cmakelist
Mark Jansen [Sun, 18 Aug 2019 19:48:07 +0000 (21:48 +0200)]
[NTDLL_VISTA] Fix the build for arm
Mark Jansen [Sun, 18 Aug 2019 19:47:35 +0000 (21:47 +0200)]
[FRAMEDYN[ARM] Fix some exports
Mark Jansen [Sun, 18 Aug 2019 19:47:14 +0000 (21:47 +0200)]
[NTDLL][ARM] Export pow
Mark Jansen [Sun, 18 Aug 2019 17:13:04 +0000 (19:13 +0200)]
[TIMEOUT] Use Int32x32To64 instead of __emul
Mark Jansen [Tue, 20 Aug 2019 11:02:35 +0000 (13:02 +0200)]
[SDK] Update Int32x32To64 macro for arm
Mark Jansen [Sun, 18 Aug 2019 17:12:30 +0000 (19:12 +0200)]
[RUNTMCHK] Provide fallback memset for arm builds
Mark Jansen [Sun, 18 Aug 2019 17:11:50 +0000 (19:11 +0200)]
[FREELDR][ARM] Suppress error about unused var
Mark Jansen [Sun, 18 Aug 2019 17:06:54 +0000 (19:06 +0200)]
[NDK][ARM] Stub a few required types for bootlib
Mark Jansen [Sun, 18 Aug 2019 17:03:35 +0000 (19:03 +0200)]
[BOOTLIB] Disable some x86 / x64 specific code for other architectures
Mark Jansen [Sun, 18 Aug 2019 17:02:46 +0000 (19:02 +0200)]
[ROSLOAD] Disable some arch-specific code for arm
Mark Jansen [Sun, 18 Aug 2019 14:39:45 +0000 (16:39 +0200)]
[CMAKE] Add explicit failure message
Previously this would show up as dependency cycle
Mark Jansen [Sun, 18 Aug 2019 14:14:16 +0000 (16:14 +0200)]
[CMAKE] Some arm cmake fixes
Serge Gautherie [Tue, 20 Aug 2019 04:36:16 +0000 (06:36 +0200)]
[IPHLPAPI] icmp.c: Restore sync after Wine Staging 1.7.55
Mark all our (new) differences.
Victor Perevertkin [Sat, 17 Aug 2019 20:08:22 +0000 (23:08 +0300)]
[PSDK] Fix GCC8 complaining on duplicate and wrong declarations
Victor Perevertkin [Sat, 17 Aug 2019 20:05:45 +0000 (23:05 +0300)]
[APITESTS] Ignore GCC8 warnings where we test some crazy stuff
Victor Perevertkin [Sat, 17 Aug 2019 20:04:41 +0000 (23:04 +0300)]
[APITESTS] Use StringCbPrintfA instead of sprintf
And fix a buffer size in Test_AddFontResourceA
Victor Perevertkin [Sat, 17 Aug 2019 19:56:40 +0000 (22:56 +0300)]
[WINETESTS] Supress GCC8 warnings
Victor Perevertkin [Mon, 19 Aug 2019 22:07:45 +0000 (01:07 +0300)]
[CMAKE] Define GCC and CLANG cmake variables
Victor Perevertkin [Sat, 17 Aug 2019 19:15:04 +0000 (22:15 +0300)]
[VIDEOPRT] Fix RtlCopyMemory sizeof usage
Spotted by GCC8
Joachim Henze [Tue, 20 Aug 2019 10:07:56 +0000 (12:07 +0200)]
[WIN32SS] WindowSnap must not affect the taskbar
This fixes regression CORE-16289 where we could not longer
move the taskbar at a different than default location,
as WindowSnap would interfere.
Many Thanks to the patches author Doug Lyons.
Eventually the heuristic that we use here to identify the
taskbar via used window-styles could be improved later.
Theoretically possible that it bails out on some other windows.
The regression was introduced by 0.4.12-dev-373-g
7e396787ed00a3939031447725f79697a41878e1
Yaroslav Kibysh [Mon, 19 Aug 2019 23:52:25 +0000 (02:52 +0300)]
[NTOS:INBV] Refactor boot screen code and resources (#1649)
* [NTOS:INBV] Move typedefs to the only single file where they are used.
* [NTOS:INBV] Refactor code & resources
Remove garbage
* [NTOS:INBV] Reduce fade time and remove wait for animation.
Stanislav Motylkov [Mon, 19 Aug 2019 21:48:49 +0000 (00:48 +0300)]
[HAL] Refactor PCI blacklisting for Xbox
- Use a separate function for detecting blacklisted PCI slots
- Blacklist PCI-to-PCI bridge to avoid stack overflow on real hardware Microsoft Xbox 1.3
CORE-16319 CORE-16216
Mark Jansen [Mon, 19 Aug 2019 23:41:40 +0000 (01:41 +0200)]
[RAPPS] Remove unused function definitions
Giannis Adamopoulos [Mon, 29 Apr 2019 12:12:32 +0000 (15:12 +0300)]
[RAPPS] CDownloadManager: Get rid of the implementation of IBindStatusCallback as we stopped using URLDownloadToFileW a decade ago
Giannis Adamopoulos [Mon, 29 Apr 2019 11:21:08 +0000 (14:21 +0300)]
[RAPPS] CDownloadManager: simplify canceling
Giannis Adamopoulos [Mon, 29 Apr 2019 08:33:33 +0000 (11:33 +0300)]
[RAPPS] factor CDownloaderProgress class out of CDownloadManager and CDownloadDialog
Giannis Adamopoulos [Mon, 29 Apr 2019 08:05:35 +0000 (11:05 +0300)]
[RAPPS] CDowloadingAppsListView: The download dialog doesn't use the layout engine so there is no need for it to be a CUiWindow
Giannis Adamopoulos [Sun, 28 Apr 2019 15:15:55 +0000 (18:15 +0300)]
[RAPPS] CMainWindow: use more atl
Giannis Adamopoulos [Sun, 28 Apr 2019 03:30:32 +0000 (06:30 +0300)]
[RAPPS] CMainWindow: remove unused functions , and the globals g_MainWindow and hListView
Giannis Adamopoulos [Sun, 28 Apr 2019 15:08:55 +0000 (18:08 +0300)]
[RAPPS] CMainWindow: Make SelectedEnumType a member
Giannis Adamopoulos [Sun, 28 Apr 2019 13:47:23 +0000 (16:47 +0300)]
[RAPPS] CMainWindow: Move gui part of UninstallApplication in it
Giannis Adamopoulos [Sun, 28 Apr 2019 13:21:16 +0000 (16:21 +0300)]
[RAPPS] CMainWindow: make szSearchPattern a member
Giannis Adamopoulos [Sun, 28 Apr 2019 03:45:12 +0000 (06:45 +0300)]
[RAPPS] CMainWindow: move RemoveAppFromRegistry in it
Giannis Adamopoulos [Sun, 28 Apr 2019 03:39:02 +0000 (06:39 +0300)]
[RAPPS] CMainWindow: Make EnumInstalledAppProc and EnumAvailableAppProc methods
Giannis Adamopoulos [Sun, 28 Apr 2019 03:27:53 +0000 (06:27 +0300)]
[RAPPS] CAppRichEdit: Add a new class that handles filling the richtext control
Giannis Adamopoulos [Sun, 28 Apr 2019 03:19:43 +0000 (06:19 +0300)]
[RAPPS] Don't use CDownloadManager outside loaddlg.cpp
Giannis Adamopoulos [Sun, 28 Apr 2019 03:10:45 +0000 (06:10 +0300)]
[RAPPS] move the message proc to gui.cpp
Giannis Adamopoulos [Sun, 28 Apr 2019 15:01:27 +0000 (18:01 +0300)]
[RAPPS] remove the old splitter code that was not used
Giannis Adamopoulos [Sun, 28 Apr 2019 12:55:12 +0000 (15:55 +0300)]
[ROSCTRLS.H] Add CListView::SetItemText and CListView::SetCheckState
Victor Perevertkin [Mon, 19 Aug 2019 22:34:58 +0000 (01:34 +0300)]
[USB] Enable *_new usb stack
Victor Perevertkin [Thu, 1 Aug 2019 18:17:44 +0000 (21:17 +0300)]
[USBPORT] Fix endless loop, occasionally happened on real hardware
William Kent [Mon, 19 Aug 2019 22:29:58 +0000 (18:29 -0400)]
Add support for save and restore reg.exe subcommands (#1565)
* [REG] Add save and restore help strings
* [REG] Implement REG SAVE
* [REG] Assert the BACKUP privilege
With this change applied, reg.exe correctly saves a key on Windows 10.
* [REG] Use RegSaveKeyEx()
* [REG] Implement REG RESTORE
* [REG] Close the process token
* [REG] Remove duplicate string
* [REG] Add missing comma
* [REG] Copy new strings into translation files
* [REG] Update STRING_USAGE translations
"Should be submitted to wine" (tm)
Bișoc George [Mon, 19 Aug 2019 18:38:46 +0000 (20:38 +0200)]
[UTILMAN] Add Romanian and Italian translations
Mark Jansen [Fri, 16 Aug 2019 23:42:29 +0000 (01:42 +0200)]
[COMCTL32] imagelist: Invalidate the cookie of a destroyed imagelist
CORE-16316
CORE-16275
Konstantin Motylkov [Sun, 18 Aug 2019 22:56:27 +0000 (00:56 +0200)]
[DNSAPI][DNSAPI_APITEST] Fix DnsQuery_UTF8 function and add tests
CORE-11634
Pierre Schweitzer [Mon, 19 Aug 2019 17:46:08 +0000 (19:46 +0200)]
[UTILMAN] Meh
Shy Zedaka [Mon, 19 Aug 2019 17:13:55 +0000 (20:13 +0300)]
[UTILMAN] Fix Small typo in one of the checkboxes
Mark Jansen [Mon, 19 Aug 2019 12:13:43 +0000 (14:13 +0200)]
[UTILMAN] Fix the build for msvc
Pierre Schweitzer [Mon, 19 Aug 2019 11:42:52 +0000 (13:42 +0200)]
[UTILMAN] Add French translation
Stanislav Motylkov [Sun, 18 Aug 2019 17:16:12 +0000 (20:16 +0300)]
[DDK][PSDK] Add missing definitions for WPA/WPA2 authentication
Part of it was already added in
3da616a. CORE-11924
Bișoc George [Wed, 24 Apr 2019 14:06:05 +0000 (16:06 +0200)]
Implement Utility Manager software
CORE-15974
Serge Gautherie [Thu, 15 Aug 2019 20:21:21 +0000 (22:21 +0200)]
[SHELL32][STOBJECT] Enforce ShellExecuteW(..., file, parameters, ...)
CORE-16299
Mark Jansen [Mon, 19 Aug 2019 00:33:13 +0000 (02:33 +0200)]
[LDR][APPHELP] Add a shim that disables manifest compatibility version parsing
Pierre Schweitzer [Mon, 19 Aug 2019 08:44:56 +0000 (10:44 +0200)]
[NTOSKRNL] Handle symlink parsing when it's bound to a specific object
Katayama Hirofumi MZ [Sun, 18 Aug 2019 13:46:56 +0000 (22:46 +0900)]
[NOTEPAD] Encoding detection (#1852)
CORE-15548
In notepad, if there is no BOM in the input file, then judge the text encoding.
Eric Kohl [Sun, 18 Aug 2019 12:54:12 +0000 (14:54 +0200)]
[MSV1_0] Add SpLsaModeInitialize and SpUserModeInitialize.
SpLsaModeInitialize and SpUserModeInitialize will provide access to SSPI functions. LSASRV will soon access the LsaAp functions via SpLsaModeInialize.
Hermès Bélusca-Maïto [Sun, 18 Aug 2019 13:23:23 +0000 (15:23 +0200)]
[FREELDR] Demote the ArcOpen() trace in WinLdrLoadImage() to a warning only.
Hermès Bélusca-Maïto [Fri, 16 Aug 2019 16:14:19 +0000 (18:14 +0200)]
[FFS] Silence some only-informative KdPrints.
Katayama Hirofumi MZ [Sun, 18 Aug 2019 09:53:37 +0000 (18:53 +0900)]
[COMCTL32_APITEST] Add propsheetv6 testcase (#1853)
The proof of #1842. Property sheet does unchange the page after WM_INITDIALOG. CORE-16280
Bișoc George [Wed, 13 Feb 2019 16:13:48 +0000 (17:13 +0100)]
[USETUP] Localize the rest of the hardcoded error message strings
Stanislav Motylkov [Sat, 17 Aug 2019 17:03:39 +0000 (20:03 +0300)]
[HAL] Xbox needs more PCI blacklisting!
CORE-16216
Serge Gautherie [Sat, 17 Aug 2019 16:20:51 +0000 (18:20 +0200)]
[CMAKE] KDBG and _WINKD_ do not need a value
Serge Gautherie [Fri, 4 May 2018 21:25:24 +0000 (23:25 +0200)]
[IPHLPAPI] icmp.c: Complete sync with Wine Staging 1.7.55
- Restore a missing brace.
- Mark all our differences (at that time). Please inspect them.
CORE-10536
Andrew Cook [Fri, 15 Feb 2019 01:33:13 +0000 (12:33 +1100)]
Search for host-tools path
Allows source-relative paths
Andrew Cook [Wed, 13 Feb 2019 10:06:49 +0000 (21:06 +1100)]
Add WITH_HOST_TOOLS option
Required for cross-compiling with msvc as only one target
architecture is available at a time in the dev prompt
Andrew Cook [Mon, 1 Oct 2018 11:07:44 +0000 (21:07 +1000)]
Rework host tools
Now configured at the same time as reactos and only
one list of targets to maintain
Correctly rebuilds when a tool changes (tested widl)
Serge Gautherie [Sat, 8 Jun 2019 02:16:20 +0000 (04:16 +0200)]
[NTOS:IO] iomgr.c: Add a missing '#if defined(KDBG)'
Victor Martinez [Sat, 17 Aug 2019 13:44:57 +0000 (16:44 +0300)]
[UDFS] Avoid freeing Vcb when it couldn't have been allocated in UDFPnpSurpriseRemove()
CORE-11203
Victor Martinez [Sat, 17 Aug 2019 13:39:55 +0000 (16:39 +0300)]
[UDFS] Fix NewCFBName leakage in UDFFirstOpenFile()
CORE-11098
Victor Martinez [Sat, 17 Aug 2019 13:30:21 +0000 (16:30 +0300)]
[UDFS] Fix accessing an already freed pointer in UDFMarkAllocatedAsNotXXX()
CORE-11182
Victor Martinez [Sat, 17 Aug 2019 12:52:19 +0000 (15:52 +0300)]
[UDFS] Don't access OldInIcb after being freed
CORE-11199
Bișoc George [Sun, 4 Aug 2019 09:21:28 +0000 (11:21 +0200)]
[DESK] Change the property "Screensaver" page on text change
If the user takes action on the edit box control of "Screensaver" dialog page, enable the "Apply" property button.
CORE-16280
Victor Martinez [Sat, 17 Aug 2019 12:43:24 +0000 (15:43 +0300)]
[UDFS] Fix uninitialized variable
CORE-11216
Katayama Hirofumi MZ [Sat, 17 Aug 2019 11:02:57 +0000 (20:02 +0900)]
[COMCTL32] Unchange the property sheet page after WM_INITDIALOG (#1842)
In my testing on Win2k3, EN_CHANGE is generated in OnInitDialog, that is correct. The target is property sheet. The property sheet does unchange the page after WM_INITDIALOG generation. CORE-16280
Andreas Maier [Fri, 21 Jun 2019 09:58:07 +0000 (11:58 +0200)]
[COMCTL32] remove unused theme_*.c files.
Thomas Faber [Sat, 20 Jul 2019 20:20:33 +0000 (22:20 +0200)]
[RSYM] When determining the current function, always prefer COFF symbols if they're closer.
Stanislav Motylkov [Fri, 16 Aug 2019 23:36:17 +0000 (02:36 +0300)]
[FREELDR] Add missing VideoSetTextCursorPosition handler for Xbox
This fixes null pointer call bug, which was revealed in
85d44fc. Spotted by Mark Jansen. CORE-16216
Co-authored-by: Mark Jansen <mark.jansen@reactos.org>
Shy Zedaka [Fri, 16 Aug 2019 13:16:41 +0000 (16:16 +0300)]
[TRANSLATION][NEWDEV] Complete Hebrew Translations for New Device Prompt