Suraj K Suresh [Mon, 23 Dec 2019 08:51:51 +0000 (14:21 +0530)]
[PSDK] Support STRICT_TYPED_ITEMIDS in shlobj.h. CORE-16385
Hermès Bélusca-Maïto [Fri, 3 Jan 2020 18:33:21 +0000 (19:33 +0100)]
[CRT] Define _INTEGRAL_MAX_BITS only if it isn't already defined by the compiler. CORE-16555
Hermès Bélusca-Maïto [Fri, 3 Jan 2020 16:41:14 +0000 (17:41 +0100)]
[NTDLL_APITEST] Addendum to
ae8c9a1f: really test the "zero Length, non-zero MaximumLength" case. + add few simplifications.
Hermès Bélusca-Maïto [Tue, 24 Dec 2019 12:27:15 +0000 (13:27 +0100)]
[BLUE] Add IOCTL buffers validation. Addendum to commit
bfd8a848.
Also convert all sizes and positions of CONSOLE_DRAW to USHORT since
this is the standard type for all console buffer positions & sizes
(minimum value 0, maximum value 0xFFFF == 65535).
Timo Kreuzer [Sat, 21 Sep 2019 17:37:03 +0000 (19:37 +0200)]
[NTDLL] Architecture specific spec file improvements
Timo Kreuzer [Sat, 21 Sep 2019 15:45:01 +0000 (17:45 +0200)]
[NTDLL] Remove redundant Zw* -> Nt* forwarders
Timo Kreuzer [Sat, 21 Sep 2019 13:48:59 +0000 (15:48 +0200)]
[NTDLL] Add some more stub exports
Timo Kreuzer [Sat, 21 Sep 2019 10:46:01 +0000 (12:46 +0200)]
[RTL][NTDLL] Add some function stubs
- LdrSetAppCompatDllRedirectionCallback
- RtlCancelTimer
- RtlCreateServiceSid
- RtlQueryProcessHeapInformation
- RtlQueueApcWow64Thread
- RtlSetTimer
- RtlUnhandledExceptionFilter2
- RtlpNotOwnerCriticalSection
Timo Kreuzer [Sat, 21 Sep 2019 11:26:54 +0000 (13:26 +0200)]
[NTDLL] Export some more existing functions
Timo Kreuzer [Thu, 19 Sep 2019 13:56:29 +0000 (15:56 +0200)]
[NTDLL] Ordinals -> @
Timo Kreuzer [Sun, 22 Sep 2019 12:59:09 +0000 (14:59 +0200)]
[SPEC2DEF] Set ordinals explicitly in export def file
The reason is that dlltool orders the exports differently than MSVC builds (MSVC orders the exports by symbol name, rather than by export name), so we rely on sorting in the spec file, which was only respected, when ordinals were put into the def file.
On MSVC builds it is left to the linker to determine the correct order, which helps to get the differences between architectures right (different symbol decoration, difference between order for functions like NtLoadKey vs NtLoadKey2, which results from the stdcall decoration on x86, which is missing on other architectures.
TODO: To correctly handle non-x86 architectures with GCC builds, spec2def would need to reorder the export list based on symbol names, which would work for C functions, by taking the calling convention into account, but would require an extra c++-stdcall calling convention to be added to know the corresponding symbol starts with "?".
Timo Kreuzer [Mon, 23 Sep 2019 11:57:32 +0000 (13:57 +0200)]
[NDK][XDK][RTL] Fix definition of RtlFillMemoryUlong on x64
Timo Kreuzer [Tue, 13 Mar 2018 19:04:34 +0000 (20:04 +0100)]
[SETUP] Don't free a DLL that is still in use by a different thread
Thomas Faber [Sun, 1 Dec 2019 19:36:13 +0000 (20:36 +0100)]
[NTOS:KE] In KiExitV86Mode, restore KTSS::Esp0 to its standard value. CORE-16531
The trap frame is in a random location on the stack, and setting Esp0 there
wastes significant amounts of space and may lead to unexpected stack overflows.
Also use a more descriptive expression for the V86 members of the KTRAP_FRAME.
Thomas Faber [Tue, 31 Dec 2019 20:07:39 +0000 (21:07 +0100)]
[WIN32K:NTGDI] Add missing probe to NtGdiGetPath.
Thomas Faber [Tue, 31 Dec 2019 20:06:43 +0000 (21:06 +0100)]
[WIN32K:NTGDI] Avoid breakpoints in syscalls.
Eric Kohl [Thu, 2 Jan 2020 22:13:18 +0000 (23:13 +0100)]
[NTOS:IO] Fix indentation. No code changes!
Hermès Bélusca-Maïto [Tue, 18 Jun 2019 00:27:47 +0000 (02:27 +0200)]
[LSASRV] Add parameter validation in LsapSetLogonSessionData().
Hermès Bélusca-Maïto [Tue, 18 Jun 2019 00:27:08 +0000 (02:27 +0200)]
[MSV1_0] Extend parameter validation in LsaApLogonUserEx2() and MsvpChangePassword(); fix crash in LsaApLogonUserEx2() when LogonDomainName points to a NULL string.
Hermès Bélusca-Maïto [Thu, 2 Jan 2020 20:10:42 +0000 (21:10 +0100)]
[RTL] Fix RtlValidateUnicodeString() regarding the tests and add some SAL annotations.
Hermès Bélusca-Maïto [Thu, 2 Jan 2020 20:09:32 +0000 (21:09 +0100)]
[NTDLL_APITEST] Add a test for RtlValidateUnicodeString().
Thomas Faber [Thu, 2 Jan 2020 15:26:50 +0000 (16:26 +0100)]
[DISK_NEW] Return correct info size in failure case of DiskIoctlGetPartitionInfoEx.
Thomas Faber [Thu, 2 Jan 2020 12:27:19 +0000 (13:27 +0100)]
[CDROM] Return the correct data length for IOCTL_DISK_GET_LENGTH_INFO. CORE-16607
Maxim Smirnov [Thu, 2 Jan 2020 12:35:32 +0000 (15:35 +0300)]
[SHELL32] Fix extra fixme (#1975)
This patch removes this line from the log:
`fixme:(dll\win32\shell32\shlexec.cpp:1810) flags ignored: 0x00000004`
Oleg Dubinskiy [Thu, 2 Jan 2020 09:06:18 +0000 (11:06 +0200)]
[BOOTDATA] Add AppliedDPI registry value (#1966)
Add AppliedDPI DWORD registry value 0x00000060 (96 DPI) into HKCU\Control Panel\Desktop\WindowMetrics registry key. For now it does nothing, since saving DPI registry settings is not implemented yet. It's required only for ViStart 8 to be started successfully (with MS VB6 Runtime installed and wshom.ocx replaced). CORE-13877
Serge Gautherie [Fri, 2 Aug 2019 15:39:50 +0000 (17:39 +0200)]
[FREELDR] Update ACPI Extended Attributes support to 6.3 (#1782)
Update BIOS_MEMORY_MAP and PcMemGetBiosMemoryMap() from ACPI 6.2-A to ACPI 6.3.
Co-Authored-By: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Hermès Bélusca-Maïto [Wed, 1 Jan 2020 20:08:37 +0000 (21:08 +0100)]
[FREELDR] Simplify the PrintText() and FrLdrBugCheckWithMessage() routines by using a new PrintTextV() helper.
Serge Gautherie [Wed, 31 Jul 2019 13:48:46 +0000 (15:48 +0200)]
[FREELDR] Reimplement i386PrintText(), adding line wrap handling. CORE-16268
Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
Serge Gautherie [Wed, 31 Jul 2019 13:39:59 +0000 (15:39 +0200)]
[FREELDR] xboxcons.c, i386bug.c: Formatting and whitespace fixes.
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Stanislav Motylkov [Sat, 28 Dec 2019 20:52:18 +0000 (23:52 +0300)]
[WS2_32_APITEST] Add some tests for GetAddrInfoW
Test results proves WSAStartup call should precede GetAddrInfoW calls.
Katayama Hirofumi MZ [Wed, 1 Jan 2020 11:28:42 +0000 (20:28 +0900)]
[SDK][INCLUDE] Total refinement of Gdiplus headers (#2223)
Missing functions added. CORE-16585
Katayama Hirofumi MZ [Wed, 1 Jan 2020 10:10:47 +0000 (19:10 +0900)]
[SDK][INCLUDE] Improve gdiplusgraphics.h (#2222)
CORE-16585
Katayama Hirofumi MZ [Wed, 1 Jan 2020 08:06:34 +0000 (17:06 +0900)]
[SDK][INCLUDE] Improve gdiplusmetafile.h (#2221)
CORE-16585
Katayama Hirofumi MZ [Wed, 1 Jan 2020 07:48:52 +0000 (16:48 +0900)]
[SDK][INCLUDE] Improve gdiplusmatrix.h (#2220)
CORE-16585
Katayama Hirofumi MZ [Wed, 1 Jan 2020 06:40:46 +0000 (15:40 +0900)]
[SDK][INCLUDE] Improve gdiplusstringformat.h (#2219)
CORE-16585
Katayama Hirofumi MZ [Wed, 1 Jan 2020 06:40:05 +0000 (15:40 +0900)]
[SDK][INCLUDE] Improve gdipluspath.h (#2218)
CORE-16585
Katayama Hirofumi MZ [Wed, 1 Jan 2020 04:53:30 +0000 (13:53 +0900)]
[SDK][INCLUDE] Refinement of Gdiplus headers (#2217)
Define getNat helper functions in gdiplusbase.h and use them. CORE-16585
Hermès Bélusca-Maïto [Tue, 31 Dec 2019 23:00:00 +0000 (00:00 +0100)]
Happy New Year 2020 to everyone!!
🎊 🎆 🍾 🥳
.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.
__, ,__) __, ,__) __, ,__) ░░▄████▄░▄███▄░▄████▄░▄███▄░░
(--|__| _ ,_ ,_ (--|\ | _ (--\ | _ _ ,_ ░░▀▀░▄██░██░██░▀▀░▄██░██░██░░
_| |(_||_)|_)(_| _| \|(/_(_|_) \|(/_(_|| ░░░▄██▀░░██░██░░▄██▀░░██░██░░
( | | ,_| ( (__| ░░██████░▀███▀░██████░▀███▀░░
.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.
███████████████████████████████████████████████████████████████████████████████
██████████████████▓▒▒▒▒▒▒▓▓█████████████████████████▓▓▒▒▒▒▒▒▓██████████████████
███████████████▒▒▒▒▓▓███▓▓▓▒▒░▒▓▓█████████████▓▒▒░▒▒▓▓████▓▓▒▒▒▓███████████████
█████████████▓░░░░░░░░░▒▒▓██████▓▒▒▒▓█████▓▒▒▒▓██████▓▒▒░░░░░░░░░▓█████████████
███████████▒▓░▒█████████▓▓▒░▒▓███▓▓▓▓▓▓▓▓▓▓▓▓████▒▒▒▒▓▓████████▓▒░▓▓███████████
██████████▒▒▓░▓██████████████▓▓▓▓▓█████▓▓▓▓▓▓▓▓▒▒███████████████▓░▓░▒██████████
█████████▓░▓█░▓██████████▓▒▒▒▒▓▓▓▓███████▓▓▓▓▓▓▓▓▓▒▒▓███████████▓░█▒░▓█████████
█████████▓▒██▒▒████████▒▒░░░░▒▒▓▓▓███████▓▓▓▓▓▓▓▓▓▓▓▒▒░█████████▒▒█▓▒▒█████████
█████████▓░██▓░▓█████▓▓▒▒░░░░▒▒▓▓▓▓████▓▓▓▓▓▓▓▓▒▒▓▓▓▓▓▒░░▓█████▓░▓█▓░▓█████████
██████████░▓██▒▒▓██▓▓▓▓▓▒▒▒▒▒▒▓▓▓▓██████▓▓▓▓▓▓▒▒▒▒▒▓▓▓▓▒▒░░███▓░▒██▒░██████████
██████████▒▒▓██▒▒▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█████████▓▓▓▒▒▒▒▒▒▒▒▒▓▒▒▒▒░░▓█▒▒██▓░▓██████████
███████████▒▒███▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓████▓▓▓▓▓▓▒▒░▒▒▒▒▒▒▒▒▒░░░▒███▒▓███████████
████████████▒▒█▓▓▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▒▒░░░░▒▒░░░▒▒▒░░░▓██▒▒████████████
█████████████▒▒▒▒▒▒░▒▓▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▓▓▒▒░░░░░░░░░░░░░▒▒▒▓▒▒█████████████
██████████████░░▒▒▒▒░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▒▒▒▒▒░░░░░░░░░▒░░▒░▒██████████████
██████████████▓▒░▒▒▒▒▒░░▒▒░░░░░░░░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░░░░░░▓███████████████
██████████████▓▒▓░░▒▒▒▒░░░░░░░░░░░░░░░░░▒▒▒▒▒▒░░░░░░░░░░▒░░░░░▓▒▓▓█████████████
███████████▓▒▓▓▓▒▒░░░░░▒▒░░░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░░▒▒▒█▒▒▓███████████
██████████▓▒▒█▓▓▒▒░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▓▒▒▒▒██▒▒▓██████████
█████████▓▒▓██▓▒▒▒▒░░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▒▒▒▒▒▒▓███▓▒▓█████████
████████▓▒▓███▓▒▒▒▒░░░▒░░░░░░▒░░░░░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▓▓▒▒▓▒▓██▓▒▓████████
███████▓▒▓███▒▓▓▒▒▒░░░░░▒░░░░░░▒░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▓▓▓▓▒▒██▓▒▓██▓▒████████
███████▒▒██▓▒▓█▓▓▒▒░░░░░░░▒░░░░░░▒░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▒▓▓▓▒▒▓███▓▒███▒▓███████
██████▓▒▓██▒▒███▓▒▒▒░░░░░░░░▒▒░░░░░▒▒░░░░░░░░▒▒░░▒▓▓▓▓▒▒▒▒▒▒▓█████▒▒██▓░▓██████
██████▒▒██▒▒█████▓▒▒▒░░░░░░░░░▒░░░░░░░▒░░░░▒▒░░▒▓▒▒▒▒▒▒▒▒▒▒████████▒▒██▒▒██████
██████▒▓██░▓██████▓▓▒▒▒░░░░░░░░░░▒░░░░░░░▒░░░░▒▒▒▒▒▒▒▓▓▒▒██████████▒░██▒▒██████
██████▒▒▓▓▒█████████▓▓▒▒▒░░░░░░░░░░▒▒░░░░▒▒▒▓░░░▒▒▒▒▒▓▓████████████▓▒▓▓░▒██████
██████▓░▒▒▒███████████▓▓▒▒░░░░▒▒▒░▒░▒▒▒▒░░▒▒▒▒▒▓▒░░▒▒██████████████▓░▒▒▒███████
███████▓▒░░▒█████████▓▒▒░░▒▓▓▒▒▒░░░░▒▒▒▓▒▓▒░░▒▒▓▓██▓▓▒░▒▒▓█████████▒░░▒████████
██████████▒░░░░░░░▒▒▓▓█████▓▓▒░░▒▓██▓▓████████▒░▒▒▓██████▓▓▒▒░░░░░░░▒██████████
███████████▓▒▒▒▓▓████▓▓▒▒▒░▒▒█████████████████████▒▒░▒▒▓▓▓███▓▓▒▒▒▒████████████
████████████████▓▓▓▓▓▓███████████████████████████████████▓▓▓▓▓▓████████████████
███████████████████████████████████████████████████████████████████████████████
███████████████████████████████████████████████████████████████████████████████
██████████████████████████████████████████████████████████▓░░▓████████░░░▓█████
███▒░░░░▒▓███████████████████████████████████████▒█████▓▒▒▓██▓▒▒▓████▓░█▓░▓████
███▒█████░▒███▓▒▒▒▒▒▓████▓▒▒▒▒▒▓█▓███▓▒▒▒▒▒▒▓██▓▒░▒▒▓▒▓█████████▓▒██▓▒█████████
███▒█████░▒█▓▒▒█████▒▒██▒▒▓████▓░▒██▒▒▓████▓▒▓██▓░▓██▓███████████▓▓██▓░░░▒█████
███▒█▓░░▒▓█▓▒▒▓▒░░▒▓▒░▒▓▒███████▒▒██▒████████████░███▓███████████▓▓██████░▒████
███▒██░▓███▓▒▓█████████▓▒███████▒▒██▒████████████░███▒▓██████████▓████████░▓███
███▒███░▒▓██▓▒▒████▓▒▓██▓▒▒▓██▓▒░▒██▓▒▒▓███▓▒▓███░████▓▒▒█████▒▒▓███▓▒▓██░▓████
███▒████▓░▓████▒▒▒▒▒██████▓▒▒▒▒▓█▓████▓▒▒▒▒▓█████▒███████▓▒▒▒▒▓███████▒▒▒▓█████
███████████████████████████████████████████████████████████████████████████████
Eric Kohl [Tue, 31 Dec 2019 22:23:23 +0000 (23:23 +0100)]
[ADVAPI32] OpenSCManagerA/W: Set the last error even in case of success
This fixes a failure in the QueryServiceConfig2 api test.
Eric Kohl [Tue, 31 Dec 2019 16:59:10 +0000 (17:59 +0100)]
[LSASRV] LsarLookupSids: Return proper domain information for nameless domains
Stanislav Motylkov [Tue, 31 Dec 2019 15:10:34 +0000 (18:10 +0300)]
[FREELDR] Obtain Xbox memory map via multiboot spec (#1971)
- Also obtain framebuffer memory size the same way.
References:
https://wiki.osdev.org/Detecting_Memory_(x86)#Memory_Map_Via_GRUB
https://www.gnu.org/software/grub/manual/multiboot/multiboot.html#Boot-information-format
CORE-16216 CORE-16300
Timo Kreuzer [Mon, 30 Dec 2019 14:34:38 +0000 (15:34 +0100)]
[NTOS:KE] Rename some locking functions to reflect the IRQL level changes
* KiAcquireApcLock -> KiAcquireApcLockRaiseToSynch
* KiAcquireApcLockAtDpcLevel -> KiAcquireApcLockAtSynchLevel
* KiReleaseApcLockFromDpcLevel -> KiReleaseApcLockFromSynchLevel
* KiAcquireApcLockAtApcLevel -> KiAcquireApcLockRaiseToDpc
* KiAcquireProcessLock -> KiAcquireProcessLockRaiseToSynch
* KiReleaseProcessLockFromDpcLevel -> KiReleaseProcessLockFromSynchLevel
* KiAcquireDispatcherLockAtDpcLevel -> KiAcquireDispatcherLockAtSynchLevel
* KiReleaseDispatcherLockFromDpcLevel -> KiReleaseDispatcherLockFromSynchLevel
* Add some ASSERTs
Thomas Faber [Sun, 29 Dec 2019 12:49:18 +0000 (13:49 +0100)]
[NTDLL_APITEST] Add a test for NtUnloadDriver.
Thomas Faber [Wed, 10 Jul 2019 10:25:36 +0000 (12:25 +0200)]
[APITESTS] Centrally define AllocateGuarded/FreeGuarded instead of duplicating them.
Thomas Faber [Sun, 29 Dec 2019 12:47:40 +0000 (13:47 +0100)]
[NTOS:IO] Use UNICODE_STRING operations in IopUnloadDriver.
Fixes several overflow vulnerabilities.
Thomas Faber [Sun, 29 Dec 2019 12:46:15 +0000 (13:46 +0100)]
[NTOS] Make RtlFindCharInUnicodeString available in the kernel.
Thomas Faber [Sun, 29 Dec 2019 12:44:59 +0000 (13:44 +0100)]
[NDK] RtlFindCharInUnicodeString is only available in user mode.
Katayama Hirofumi MZ [Tue, 31 Dec 2019 14:14:52 +0000 (23:14 +0900)]
[SDK][INCLUDE] Rename Gdiplus::Region::region as nativeRegion (#2212)
CORE-16585
Katayama Hirofumi MZ [Tue, 31 Dec 2019 11:40:16 +0000 (20:40 +0900)]
[SDK][INCLUDE] Improve Gdiplus::Graphics (#2211)
CORE-16585
Katayama Hirofumi MZ [Tue, 31 Dec 2019 10:24:59 +0000 (19:24 +0900)]
[SDK][INCLUDE] Rename Gdiplus::Graphics::graphics as nativeGraphics (#2210)
Make it w32api-compatible. CORE-16585
Katayama Hirofumi MZ [Tue, 31 Dec 2019 08:53:35 +0000 (17:53 +0900)]
[SDK][INCLUDE] Move Gdiplus::TextureBrush codes (#2208)
Move the code into the place it should be in. CORE-16585
Timo Kreuzer [Thu, 30 May 2019 13:44:56 +0000 (15:44 +0200)]
[NTOS] In KeWaitFor*Object(s) assert that the current IRQL is SYNCH_LEVEL. not DISPATCH_LEVEL, since acquiring the dispatcher lock raises to SYNCH_LEVEL, which is != DISPATCH_LEVEL on x64 and SMP builds.
Katayama Hirofumi MZ [Tue, 31 Dec 2019 08:11:38 +0000 (17:11 +0900)]
[SDK][INCLUDE] Implement Gdiplus::Pen (#2207)
CORE-16585
Katayama Hirofumi MZ [Tue, 31 Dec 2019 06:45:57 +0000 (15:45 +0900)]
[SDK][INCLUDE] Rename Gdiplus::Pen::pen as nativePen (#2206)
CORE-16585
Katayama Hirofumi MZ [Tue, 31 Dec 2019 05:54:41 +0000 (14:54 +0900)]
[SDK][INCLUDE] Implement Gdiplus::Brush (#2205)
CORE-16585
Katayama Hirofumi MZ [Tue, 31 Dec 2019 03:36:08 +0000 (12:36 +0900)]
[SDK][INCLUDE] Rename Gdiplus::Brush::brush as nativeBrush (#2204)
Make it w32api-compatible. CORE-16585
Katayama Hirofumi MZ [Tue, 31 Dec 2019 02:37:46 +0000 (11:37 +0900)]
[SDK][INCLUDE] Improve Gdiplus::FontCollection (#2203)
CORE-16585
Katayama Hirofumi MZ [Tue, 31 Dec 2019 02:34:28 +0000 (11:34 +0900)]
[SDK][INCLUDE] Implement Gdiplus::ImageAttributes (#2202)
CORE-16585
Katayama Hirofumi MZ [Tue, 31 Dec 2019 02:30:12 +0000 (11:30 +0900)]
[SDK][INCLUDE] Implement Gdiplus::CustomLineCap (#2201)
Implement Gdiplus::CustomLineCap and Gdiplus::AdjustableArrowCap. CORE-16585
Katayama Hirofumi MZ [Tue, 31 Dec 2019 02:28:56 +0000 (11:28 +0900)]
[SDK][TOOLS] Add do_code_format.sh to sdk/tools (#2191)
do_code_format.sh --- A command line tool using clang-format
Katayama Hirofumi MZ [Tue, 31 Dec 2019 00:23:45 +0000 (09:23 +0900)]
[SDK][INCLUDE] Implementing Gdiplus::GraphicsPath (#2200)
Point, PointF, Size, SizeF, Rect and RectF are also implemented. CORE-16585
Katayama Hirofumi MZ [Tue, 31 Dec 2019 00:21:42 +0000 (09:21 +0900)]
[WIN32SS][WINSRV] Add CSR API_NUMBER info comments (#2192)
Add comments to improve human-readability and referencing of CSR API. CORE-12451
Timo Kreuzer [Tue, 24 Dec 2019 17:31:59 +0000 (18:31 +0100)]
[NTOS:IO] Fix list enumeration in IopShutdownBaseFileSystems
Victor Perevertkin [Thu, 19 Dec 2019 23:52:30 +0000 (02:52 +0300)]
[WINHTTP_WINETEST] Restore test_persistent_connection execution
This reverts commit
a22031d
ROSTESTS-295
Victor Perevertkin [Thu, 19 Dec 2019 22:43:07 +0000 (01:43 +0300)]
[WINHTTP] Initialize winsock upon WinHttpOpen
As it was done before syncing with wine-staging 4.18 (
5bd6580)
ROSTESTS-348
Katayama Hirofumi MZ [Mon, 30 Dec 2019 10:59:09 +0000 (19:59 +0900)]
[SDK][INCLUDE] Improve gdiplusheader.h (#2197)
CORE-16585
Katayama Hirofumi MZ [Mon, 30 Dec 2019 10:57:55 +0000 (19:57 +0900)]
[SDK][INCLUDE] Improve gdipluseffects.h (#2196)
CORE-16585
Katayama Hirofumi MZ [Mon, 30 Dec 2019 09:07:13 +0000 (18:07 +0900)]
[SDK][INCLUDE] Improve gdipluscolor.h (#2195)
CORE-16585
Katayama Hirofumi MZ [Mon, 30 Dec 2019 05:45:26 +0000 (14:45 +0900)]
[SDK][INCLUDE] Rename Gdiplus::Image::image as nativeImage (Retry) (#2189)
CORE-16585
Victor Perevertkin [Thu, 19 Dec 2019 18:01:30 +0000 (21:01 +0300)]
[NTOS:KD] Fix wrong debug level checking logic in KdpPrint.
Use NtQueryDebugFilterState in that function for consistency.
Thanks Hermès Bélusca-Maïto for help
Thomas Faber [Sun, 29 Dec 2019 17:51:05 +0000 (18:51 +0100)]
[WIN32K:NTUSER] Avoid user memory access outside of SEH in NtUserEnumDisplaySettings.
Thomas Faber [Sun, 29 Dec 2019 15:14:58 +0000 (16:14 +0100)]
[WIN32K:NTUSER] Correctly capture UNICODE_STRING in NtUserEnumDisplaySettings.
Thomas Faber [Sun, 29 Dec 2019 15:14:17 +0000 (16:14 +0100)]
[WIN32K:NTUSER] Add missing probe in NtUserGetClassName.
Hermès Bélusca-Maïto [Sun, 29 Dec 2019 18:08:47 +0000 (19:08 +0100)]
[CMD] If the prompt displays the information line on top of the screen, ensure that the prompt won't be hidden below it.
CORE-16193
Hermès Bélusca-Maïto [Sun, 29 Dec 2019 15:53:36 +0000 (16:53 +0100)]
[CMD] Code formatting; don't hardcode the string buffer sizes in function calls.
Eric Kohl [Sun, 29 Dec 2019 16:28:55 +0000 (17:28 +0100)]
[SAMSRV] SamrEnumerate...: Return STATUS_NO_MORE_ENTRIES if there is nothing to enumerate.
Hermès Bélusca-Maïto [Sun, 29 Dec 2019 15:23:37 +0000 (16:23 +0100)]
[BROWSEUI] Remove unneeded header, addendum to
d967b5aa.
Hermès Bélusca-Maïto [Sun, 29 Dec 2019 15:08:38 +0000 (16:08 +0100)]
[NETAPI32] Improve some error traces.
Hermès Bélusca-Maïto [Sun, 29 Dec 2019 14:57:57 +0000 (15:57 +0100)]
[SHELL32] Remove some trailing spaces; use explicitly global namespace for some functions.
Hermès Bélusca-Maïto [Sun, 29 Dec 2019 14:48:42 +0000 (15:48 +0100)]
[BROWSEUI] Remove useless RegenerateUserEnvironment() call.
[SHELL32] Call RegenerateUserEnvironment() in WM_SETTINGCHANGE handler **ONLY** when lParam points to the L"Environment" string.
CORE-15147
Hermès Bélusca-Maïto [Sun, 29 Dec 2019 14:10:19 +0000 (15:10 +0100)]
[WIN32SS:USER] Some minimal work and fixes concerning message queues timeouts.
CORE-15147
- Rename CLIENTTHREADINFO::tickLastMsgChecked into timeLastRead as
documented in https://reactos.org/wiki/Techwiki:Win32k/CLIENTTHREADINFO .
This is the last time the message queue was read.
- This is the structure member one must compare against the current tick
count timestamp in order to heuristically determine whether a message
queue thread is hung!! Fix MsqIsHung() in accordance, add extra debug
logging in order to help us determining which of our code present
regular GUI hangs, and add as well an extra "TimeOut" parameter so as
not to hardcode a fixed value within that function but instead
allowing its caller to specify possible different values.
- THREADINFO::timeLast is on the contrary the last message time stamp,
and will definitively differ from CLIENTTHREADINFO::timeLastRead .
It should only be used for information purposes!
- Accordingly, in NtUserGetThreadState()::THREADSTATE_UPTIMELASTREAD
and in InitThreadCallback(), only (re-)initialize the timeLastRead
member of the CLIENTTHREADINFO structure of the THREADINFO of interest.
- In co_IntPeekMessage(), update more often the timeLastRead timestamp
whenever the current message queue has been read (but NOT timeLast!!
That one will be updated ONLY WHEN a message is found!).
- In co_IntSendMessageTimeoutSingle() first check whether the window to
which we send the message is being destroyed, before checking for
queue hangs etc. Collapse the logic checks for queue hang and increase
the hang timeout check to 4 times MSQ_HUNG (== 4 * 5 seconds) and
display a debug trace.
Thomas Faber [Sun, 29 Dec 2019 14:10:37 +0000 (15:10 +0100)]
[INCLUDE] Safely handle odd & large lengths in ProbeAndCaptureUnicodeString.
Thomas Faber [Sun, 29 Dec 2019 14:02:11 +0000 (15:02 +0100)]
[WIN32K:NTUSER] Add missing parameter probe in NtUserGetClassInfo.
Katayama Hirofumi MZ [Sun, 29 Dec 2019 14:21:05 +0000 (23:21 +0900)]
[SDK][INCLUDE] Formatting gdiplus headers (#2190)
Just code formatting. CORE-16585
$ clang-format -style=file -i sdk/include/psdk/gdiplus[a-z]*
Eric Kohl [Sun, 29 Dec 2019 13:36:32 +0000 (14:36 +0100)]
[NTOS:IO] Fix indentation. No code changes!
Thomas Faber [Sun, 29 Dec 2019 09:33:38 +0000 (10:33 +0100)]
[NTOS:CM] Probe for write in NtLockProductActivationKeys.
This doesn't technically make a difference, but it's good practice.
Thomas Faber [Sun, 29 Dec 2019 09:00:59 +0000 (10:00 +0100)]
[NTOS:CM] Protect user memory access with SEH in NtQueryOpenSubKeys.
Eric Kohl [Sun, 29 Dec 2019 09:09:56 +0000 (10:09 +0100)]
[SYSSETUP] Start the dnscache service after the network support has been installed
CORE-16558
Katayama Hirofumi MZ [Sun, 29 Dec 2019 04:12:39 +0000 (13:12 +0900)]
[KERNEL32_APITEST] More power to ConsoleCP testcase (#2187)
Strengthen kernel32_apitest ConsoleCP testcase for COMMON_LVB_LEADING_BYTE and COMMON_LVB_TRAILING_BYTE attributes. CORE-12451
Katayama Hirofumi MZ [Sat, 28 Dec 2019 13:30:21 +0000 (22:30 +0900)]
[MSPAINT] Revert LoadDIBFromFile for workaround (#2186)
CORE-16566
Victor Perevertkin [Fri, 27 Dec 2019 16:47:07 +0000 (19:47 +0300)]
[REACTOS] Exclude some modules from clang-format
Victor Perevertkin [Tue, 24 Dec 2019 10:55:30 +0000 (13:55 +0300)]
[REACTOS] Introduce .clang-format file
And set up a Travis job for checking formatting on PRs
Mark Jansen [Fri, 27 Dec 2019 18:52:21 +0000 (19:52 +0100)]
[CMAKE] Update baseaddresses with gcc 8.3
Mark Jansen [Fri, 27 Dec 2019 18:51:20 +0000 (19:51 +0100)]
[SDK] Add usage / help to gen_baseaddress.py
Mark Jansen [Fri, 27 Dec 2019 18:50:23 +0000 (19:50 +0100)]
Change whitespace so gcc 8.3 wont falsely complain about misleading indentation
Thomas Faber [Fri, 27 Dec 2019 16:01:15 +0000 (17:01 +0100)]
[NTDLL:LDR] Add a print on illegal DLL relocation.
Hermès Bélusca-Maïto [Thu, 26 Dec 2019 16:19:11 +0000 (17:19 +0100)]
This was not meant to be committed!
This reverts commit
5e14dbd6481f29f9f3b666e64b5bfd74ac887f73.
Hermès Bélusca-Maïto [Thu, 26 Dec 2019 16:16:04 +0000 (17:16 +0100)]
[SETUPLIB] Register the \DosDevices\?: drive letter from installation time in the correct SYSTEM\MountedDevices registry key, i.e. the one of the ReactOS being currently installed.
CORE-15575
However I now hit a separate bug (see the report) that still prevent the
drive letter to be correctly assigned at reboot.
Hermès Bélusca-Maïto [Thu, 26 Dec 2019 12:53:50 +0000 (13:53 +0100)]
WIP kdbg work.
Katayama Hirofumi MZ [Thu, 26 Dec 2019 10:08:01 +0000 (19:08 +0900)]
[NTUSER] Fix caret display mistake (#2180)
Take care of caret visibility. co_IntSetCaretPos function wrongly drawn the caret upon invisible caret. @Doug-Lyons did test this patch. CORE-15661