22 months ago[NETSTAT] '-p UDP' depends on '-a'
Serge Gautherie [Sat, 29 Jun 2019 13:14:39 +0000 (15:14 +0200)]
[NETSTAT] '-p UDP' depends on '-a'

22 months ago[NTFS] Correctly find attributes stored in another file record in MFT (and referenced...
Sylvain Deverre [Thu, 8 Aug 2019 20:09:13 +0000 (22:09 +0200)]
[NTFS] Correctly find attributes stored in another file record in MFT (and referenced in data stream)

22 months agoRevert "[WININET_APITEST] Add Download testcase (#1832)" (#1839)
Katayama Hirofumi MZ [Fri, 16 Aug 2019 08:01:03 +0000 (17:01 +0900)]
Revert "[WININET_APITEST] Add Download testcase (#1832)" (#1839)

This reverts commit 7464241adabfbdfec5a058697632a8d3938479fb.

22 months ago[ROSAPPS][NETREG] Fix build
Katayama Hirofumi MZ [Fri, 16 Aug 2019 07:57:40 +0000 (16:57 +0900)]

22 months agoUpdate Headers for Printing and Other
James Tabor [Fri, 16 Aug 2019 02:39:26 +0000 (21:39 -0500)]
Update Headers for Printing and Other

Add missing flags and function types. Fix typos.

22 months ago[COMCTL32] Saturated images: Take mask-images in account.
Andreas Maier [Sat, 1 Jun 2019 17:09:44 +0000 (19:09 +0200)]
[COMCTL32] Saturated images: Take mask-images in account.

This fixes CORE-14209 - Some icons not drawn in IDA Free

22 months ago[COMCTL32] Improve failure cases.
Andreas Maier [Fri, 31 May 2019 08:15:06 +0000 (10:15 +0200)]
[COMCTL32] Improve failure cases.

22 months ago[NDIS] Enforce '#if DBG' around MiniDisplayPacket[2]()
Serge Gautherie [Sat, 8 Jun 2019 01:03:40 +0000 (03:03 +0200)]
[NDIS] Enforce '#if DBG' around MiniDisplayPacket[2]()

Also add 'static' on MiniDisplayPacket2().

22 months ago[OSK] General refactoring
Bișoc George [Tue, 16 Jul 2019 15:35:30 +0000 (17:35 +0200)]
[OSK] General refactoring

- Replace the existing header files in favour to a pre-compiled header instead. Furthermore, move all the function prototypes in the pre-compiled header.
- As per the prototype definitions, LoadDataFromRegistry() and SaveDataToRegistry() mustn't accept any number of parameters.
- Rename rsrc.rc to osk.rc (main resource file) as most of user-mode applications name have their main resource as the same application's name anyways.
- When querying and saving the data to registry, use only one value, greatly reducing the bloat of variables (as per the Hermes Belusca's request on #1729 PR).
- Update the header description reflecting the official ReactOS Coding style guidelines.

22 months ago[THEMES][LUNAR] Update
Adam Słaboń [Sat, 13 Jul 2019 15:29:46 +0000 (17:29 +0200)]

Improved Button and Combo Button bitmaps, fixed SYSSETUP Lunar resource.

22 months ago[SHELL32] Run Dialog Text Fix
Shy Zedaka [Sun, 4 Aug 2019 20:54:51 +0000 (23:54 +0300)]
[SHELL32] Run Dialog Text Fix

22 months ago[TASKMGR] Implement proper process tree ending
Paweł Cholewa [Thu, 15 Aug 2019 17:07:05 +0000 (19:07 +0200)]
[TASKMGR] Implement proper process tree ending

 * Implement ShutdownProcessTree in endproc.c which recursively kills process trees
 * Include tlhelp32.h in precomp.h
 * Check if the child process can be shut down

22 months ago[NTOSKRNL] Move DPRINT1("Thread wants too much stack\n") around
Serge Gautherie [Thu, 25 Apr 2019 01:22:16 +0000 (03:22 +0200)]
[NTOSKRNL] Move DPRINT1("Thread wants too much stack\n") around

To KiUserModeCallout() from MmGrowKernelStackEx().

As suggested by Thomas Faber:
"MmGrowKernelStackEx really shouldn't be DPRINT'ing."


22 months ago[FREELDR] Improve debug output
Timo Kreuzer [Sat, 27 Jul 2019 07:58:38 +0000 (09:58 +0200)]
[FREELDR] Improve debug output

22 months ago[NTOS:MM] MmSizeOfSystemCacheInPages is ULONG_PTR, not ULONG
Timo Kreuzer [Sat, 27 Jul 2019 07:32:29 +0000 (09:32 +0200)]
[NTOS:MM] MmSizeOfSystemCacheInPages is ULONG_PTR, not ULONG

Fixes failed assertion on x64.

22 months ago[NTOS:KE:I386] Fix parameter description for KiSwapContext
Timo Kreuzer [Thu, 27 Jun 2019 16:05:55 +0000 (18:05 +0200)]
[NTOS:KE:I386] Fix parameter description for KiSwapContext

22 months ago[NTOS:IO] In IopSynchronousCall first check IrpStack->MajorFunction before checking...
Timo Kreuzer [Sun, 2 Jun 2019 07:45:45 +0000 (09:45 +0200)]
[NTOS:IO] In IopSynchronousCall first check IrpStack->MajorFunction before checking minor

Minor function indices are not unique, they are subfunctions, so without first checking the major function, they are ambiguous.

22 months ago[BROWSEUI] Try to "fix" IEThreadParamBlock structure for x64
Timo Kreuzer [Sat, 1 Jun 2019 12:42:14 +0000 (14:42 +0200)]
[BROWSEUI] Try to "fix" IEThreadParamBlock structure for x64

22 months ago[PSDK] dbghelp.h: Fix 64 bit version of LOADED_IMAGE
Timo Kreuzer [Mon, 22 Apr 2019 11:03:24 +0000 (13:03 +0200)]
[PSDK] dbghelp.h: Fix 64 bit version of LOADED_IMAGE

22 months ago[TDI] Improve spec file
Timo Kreuzer [Mon, 20 Aug 2018 15:11:40 +0000 (17:11 +0200)]
[TDI] Improve spec file

22 months ago[PSDK] Fix #ifdef in winuser.h
Timo Kreuzer [Mon, 20 Aug 2018 14:02:44 +0000 (16:02 +0200)]
[PSDK] Fix #ifdef in winuser.h

22 months ago[VIDEOPRT] Fix order of some exports
Timo Kreuzer [Thu, 12 Jul 2018 11:23:04 +0000 (13:23 +0200)]
[VIDEOPRT] Fix order of some exports

22 months ago[NTOS:EX] Use InterlockedExchangeAdd64 instead of InterlockedCompareExchange64 loop...
Timo Kreuzer [Thu, 12 Jul 2018 13:54:52 +0000 (15:54 +0200)]
[NTOS:EX] Use InterlockedExchangeAdd64 instead of InterlockedCompareExchange64 loop in ExAllocateLocallyUniqueId

22 months ago[WIN32K] InitVideo() should return NTSTATUS, so return STATUS_SUCCESS instead of 1
Timo Kreuzer [Sun, 11 Feb 2018 20:53:03 +0000 (21:53 +0100)]
[WIN32K] InitVideo() should return NTSTATUS, so return STATUS_SUCCESS instead of 1

22 months ago[NTOS:IO] Improve an alignment
Timo Kreuzer [Thu, 4 Jan 2018 17:29:24 +0000 (18:29 +0100)]
[NTOS:IO] Improve an alignment

22 months ago[KSUSER] Improve pointer arithmetics
Timo Kreuzer [Thu, 28 Dec 2017 17:35:30 +0000 (18:35 +0100)]
[KSUSER] Improve pointer arithmetics

22 months ago[SHELL32] Fix Desktop Properties menu item action (#1833)
Katayama Hirofumi MZ [Thu, 15 Aug 2019 14:10:06 +0000 (23:10 +0900)]
[SHELL32] Fix Desktop Properties menu item action (#1833)

1. Right Click the Desktop.
2. Choose "Properties" menu item.
3. "Properties for Display" dialog must be shown.

The parameters of ShellExecuteW were wrong. The execution parameters must be separated from the file parameter.

22 months ago[KERNEL32] implement CreateSemaphoreExW/A and adjust macroses for it
Denis Malikov [Sun, 18 Nov 2018 16:51:20 +0000 (23:51 +0700)]
[KERNEL32] implement CreateSemaphoreExW/A and adjust macroses for it

22 months ago[KERNEL32] Partially fix dll/win32/kernel32/client/vista.c compilation as NT6
Serge Gautherie [Thu, 15 Aug 2019 13:42:34 +0000 (15:42 +0200)]
[KERNEL32] Partially fix dll/win32/kernel32/client/vista.c compilation as NT6


22 months ago[3RDPARTY] Suppress MSVC printf format warnings in 3rd-party code
Timo Kreuzer [Sat, 20 Jul 2019 15:34:24 +0000 (17:34 +0200)]
[3RDPARTY] Suppress MSVC printf format warnings in 3rd-party code

22 months ago[REACTOS] Fix MSVC printf format warnings
Timo Kreuzer [Mon, 20 Aug 2018 15:42:27 +0000 (17:42 +0200)]
[REACTOS] Fix MSVC printf format warnings

22 months ago[DBGHELP_APITEST] Add rsym+pdb tests on loaded modules 1445/head
Mark Jansen [Wed, 27 Mar 2019 22:09:36 +0000 (23:09 +0100)]
[DBGHELP_APITEST] Add rsym+pdb tests on loaded modules
Also reorder some stuff to make the tests more alike

22 months ago[REACTOS] Fix SIZE_T related warnings
Timo Kreuzer [Sun, 26 May 2019 13:00:21 +0000 (15:00 +0200)]
[REACTOS] Fix SIZE_T related warnings

22 months ago[VIDEOPRT] Implement support for INT10 on x64 using the newly implemented HAL functions.
Timo Kreuzer [Sun, 11 Feb 2018 18:22:30 +0000 (19:22 +0100)]
[VIDEOPRT] Implement support for INT10 on x64 using the newly implemented HAL functions.

22 months ago[VIDEOPRT] Fixes for x64
Timo Kreuzer [Sun, 11 Feb 2018 13:01:43 +0000 (14:01 +0100)]
[VIDEOPRT] Fixes for x64

22 months ago[VIDEOPRT] Call IntInt10CallBios from VideoPortInt10, instead of code duplication
Timo Kreuzer [Sun, 11 Feb 2018 12:49:14 +0000 (13:49 +0100)]
[VIDEOPRT] Call IntInt10CallBios from VideoPortInt10, instead of code duplication

22 months ago[VIDEOPRT] [FORMATTING] No code change
Timo Kreuzer [Sun, 11 Feb 2018 12:43:05 +0000 (13:43 +0100)]
[VIDEOPRT] [FORMATTING] No code change

22 months ago[HAL] Implement amd64 BIOS call support
Timo Kreuzer [Sun, 11 Feb 2018 18:21:01 +0000 (19:21 +0100)]
[HAL] Implement amd64 BIOS call support

The code uses FAST486 to emulate the BIOS code.

22 months ago[NDK] Add BIOS call API for amd64
Timo Kreuzer [Sun, 11 Feb 2018 15:43:51 +0000 (16:43 +0100)]
[NDK] Add BIOS call API for amd64

22 months ago[Translation] More Hebrew Translations
Shy Zedaka [Mon, 5 Aug 2019 21:01:24 +0000 (00:01 +0300)]
[Translation] More Hebrew Translations

Co-authored-by: Baruch Rutman <>
22 months ago[NTOSKRNL][PS] Implement NtQueueApcThreadEx and use it in NtQueueApcThread
Andrew Boyarshin [Sun, 25 Nov 2018 07:11:04 +0000 (14:11 +0700)]
[NTOSKRNL][PS] Implement NtQueueApcThreadEx and use it in NtQueueApcThread

Actually rename NtQueueApcThread to NtQueueApcThreadEx and ignore one additional parameter for now.

22 months ago[SHELL32] CDefView: Improve the context menu positioning 1817/head
Mark Jansen [Thu, 8 Aug 2019 19:01:19 +0000 (21:01 +0200)]
[SHELL32] CDefView: Improve the context menu positioning
Previously we would always show a menu on the focused item, but
this should only be done when it is also selected.

22 months ago[WININET_APITEST] Add Download testcase (#1832)
Katayama Hirofumi MZ [Thu, 15 Aug 2019 08:50:57 +0000 (17:50 +0900)]
[WININET_APITEST] Add Download testcase (#1832)


22 months ago[MEDIA][FONTS] Add Baltic MS Sans Serif (ssee1257.fon) CORE-16166
Katayama Hirofumi MZ [Thu, 15 Aug 2019 01:23:50 +0000 (10:23 +0900)]
[MEDIA][FONTS] Add Baltic MS Sans Serif (ssee1257.fon) CORE-16166

22 months ago[FREELDR] Minor fixes.
Hermès Bélusca-Maïto [Wed, 14 Aug 2019 13:59:01 +0000 (15:59 +0200)]
[FREELDR] Minor fixes.

- Add some forgotten, or move some misplaced ArcClose() calls so as
  to avoid leakages in failure paths. (Thanks to Serge Gautherie for
  having caught some of them.)

- Simplify some code; remove unneeded casts; use string-safe functions.

22 months ago[FREELDR] Minor enhancements for disk/partition boot and UI.
Hermès Bélusca-Maïto [Tue, 13 Aug 2019 15:34:57 +0000 (17:34 +0200)]
[FREELDR] Minor enhancements for disk/partition boot and UI.

- Factor out disk & partition opening in LoadAndBootPartition() and
  LoadAndBootDrive() into a LoadAndBootPartitionOrDrive() helper.

- Use ARC paths and ArcOpen()/ArcRead() instead of calling the
  machine-specific BIOS-oriented DiskGetPartitionEntry() and
  MachDiskReadLogicalSectors() functions to open the disk/partition
  and read their boot sectors.

- Don't forget to close the opened boot sector file in LoadAndBootBootSector().

- Add assertions for DiskReadBufferSize in PcMemFinalizeMemoryMap()
  and EnumerateHarddisks().

- x86/amd64 only:
  * Add a DisableA20 helper for disabling the A20 line, before rebooting
    back, or chain-load a boot sector, into 16-bit world.
    Also pulse the output port of the keyboard controller to clear out
    its state after having set the state of the A20 line.

  * In addition to disabling the A20 line when rebooting or chain-loading
    a boot sector, reset the video back to 80x25 text mode.

- Reset the cursor position back to the origin when initializing or
  terminating the TUI.

22 months ago[OSK] Romanian translation update (#1820)
Bișoc George [Mon, 12 Aug 2019 18:58:39 +0000 (20:58 +0200)]
[OSK] Romanian translation update (#1820)

22 months ago[ATL_APITEST] Simplify code by using ok_int etc. (#1824)
Katayama Hirofumi MZ [Mon, 12 Aug 2019 14:10:47 +0000 (23:10 +0900)]
[ATL_APITEST] Simplify code by using ok_int etc. (#1824)

Simplify the code by using ok_int, ok_long etc.

22 months ago[MEDIA][FONTS] Total adjustment of MS Sans Serif
Katayama Hirofumi MZ [Mon, 12 Aug 2019 13:19:55 +0000 (22:19 +0900)]
[MEDIA][FONTS] Total adjustment of MS Sans Serif

22 months ago[SDK][INCLUDE] Update msgdump.h and winxx.h
Katayama Hirofumi MZ [Mon, 12 Aug 2019 10:31:44 +0000 (19:31 +0900)]
[SDK][INCLUDE] Update msgdump.h and winxx.h

22 months ago[ATL_APITEST] Add 'atltest.h' and use it (#1822)
Katayama Hirofumi MZ [Mon, 12 Aug 2019 10:24:08 +0000 (19:24 +0900)]
[ATL_APITEST] Add 'atltest.h' and use it (#1822)

- Add "atltest.h" header file for common use in atl_apitest.
- Delete the duplicated and simplify.

22 months ago[ATL] Add a minimal CAtlArray implementation 1819/head
Mark Jansen [Fri, 9 Aug 2019 22:22:03 +0000 (00:22 +0200)]
[ATL] Add a minimal CAtlArray implementation

22 months ago[ATL_APITEST] Add simple test for CAtlArray
Mark Jansen [Fri, 9 Aug 2019 19:25:16 +0000 (21:25 +0200)]
[ATL_APITEST] Add simple test for CAtlArray

22 months ago[ATL_APITEST] Change proj files to have a different intermediate dir
Mark Jansen [Fri, 9 Aug 2019 19:24:33 +0000 (21:24 +0200)]
[ATL_APITEST] Change proj files to have a different intermediate dir

22 months ago[ATL][ATL_APITEST] Add CAtlList::InsertBefore/After + test
Mark Jansen [Fri, 9 Aug 2019 17:14:43 +0000 (19:14 +0200)]
[ATL][ATL_APITEST] Add CAtlList::InsertBefore/After + test

22 months agoAddendum to fba4ad4c.
Hermès Bélusca-Maïto [Sun, 11 Aug 2019 20:06:27 +0000 (22:06 +0200)]
Addendum to fba4ad4c.

22 months ago[FREELDR] Move files where they are only used.
Hermès Bélusca-Maïto [Sun, 11 Aug 2019 16:56:40 +0000 (18:56 +0200)]
[FREELDR] Move files where they are only used.

- Merge fade.c/palette.c/video.c into video.c and move it into UI.
- Move inffile.c into NTLDR.

22 months ago[MEDIA][FONTS] Add Arabic MS Sans Serif (ssee1256.fon)
Katayama Hirofumi MZ [Sun, 11 Aug 2019 00:36:39 +0000 (09:36 +0900)]
[MEDIA][FONTS] Add Arabic MS Sans Serif (ssee1256.fon)


22 months ago[WIN32SS][NTUSER] Fix menu drawing after style change (#1821)
Katayama Hirofumi MZ [Sat, 10 Aug 2019 22:46:14 +0000 (07:46 +0900)]
[WIN32SS][NTUSER] Fix menu drawing after style change (#1821)

There were menu drawing regression after
This PR will fix it. CORE-16244

- We don't have to draw the frame manually because of WS_EX_DLGMODALFRAME extended style.
- We don't need the margins (MENU_TOP_MARGIN and MENU_BOTTOM_MARGIN) in the client area any more because the client area doesn't contain the frame width.
- Use GetSystemMetrics(SM_CXDLGFRAME) and GetSystemMetrics(SM_CYDLGFRAME) for frame width.

22 months ago[FREELDR] Addendum to 31a3f317.
Hermès Bélusca-Maïto [Sat, 10 Aug 2019 17:47:49 +0000 (19:47 +0200)]
[FREELDR] Addendum to 31a3f317.

22 months ago[PROCESSR] Employ usual casing for CurrentControlSet key.
Hermès Bélusca-Maïto [Sat, 10 Aug 2019 17:14:04 +0000 (19:14 +0200)]
[PROCESSR] Employ usual casing for CurrentControlSet key.

22 months ago[FREELDR] Some changes that accumulated since years in my local copy. Also initialize...
Hermès Bélusca-Maïto [Sat, 10 Aug 2019 17:13:20 +0000 (19:13 +0200)]
[FREELDR] Some changes that accumulated since years in my local copy. Also initialize SetupBlock->ArcSetupDeviceName to some valid value.

22 months ago[FREELDR] Rework EXT2 filesystem to interface with ARC and not be tied to the boot...
Hermès Bélusca-Maïto [Sat, 10 Aug 2019 14:36:11 +0000 (16:36 +0200)]
[FREELDR] Rework EXT2 filesystem to interface with ARC and not be tied to the boot volume.

See 28bf1f3b (r42537) and c599bd7d (r43267) for additional information.

22 months ago[FREELDR] Diverse enhancements.
Hermès Bélusca-Maïto [Sat, 10 Aug 2019 11:44:33 +0000 (13:44 +0200)]
[FREELDR] Diverse enhancements.

- Get rid of the FsCloseFile(), FsReadFile(), FsGetFileInformation(),
  FsGetFileSize() and FsSetFilePointer() wrappers and use the ARC
  functions directly instead. Make FsOpenFile() return an ARC file
  descriptor ID of the correct type. Get rid of unused FS_* defines.

- Use TRACEs in the ***Mount() filesystem functions for diagnostics

- Remove a leak in FatGetFatEntry(). Assign stuff via QuadPart where
  possible in FatMount(). Remove an unused member in FAT_FILE_INFO.

- Reduce code indentation in BtrFsMount() and remove a leak there.

- Disable reading the "BootPath" parameter in the linux loader since
  we don't use this parameter (yet??)

22 months ago[LSASS] Initialize SAM before starting the security services
Eric Kohl [Sat, 10 Aug 2019 12:36:10 +0000 (14:36 +0200)]
[LSASS] Initialize SAM before starting the security services

We need to initialize SAM before the security services get started, otherwise we will have a running SamSs service although SAM is not initialized at that time. This is no good.

22 months ago[SERVICES] Improvements to registry control sets
Eric Kohl [Sat, 10 Aug 2019 12:24:11 +0000 (14:24 +0200)]
[SERVICES] Improvements to registry control sets

- Add a function that creates a new control set and deletes unused control sets in case of a successful boot.
- Add a stub function that will soon switch to the last known good control set in case of an unsuccessful boot.

22 months ago[IDL][WINLOGON] Rename locally used functions of the winreg rpc interface
Eric Kohl [Sat, 10 Aug 2019 12:04:58 +0000 (14:04 +0200)]
[IDL][WINLOGON] Rename locally used functions of the winreg rpc interface

- Function 14 is named BaseRegNotifyChangeKeyValue
- Function 28 is named OpenDynData

22 months ago[WIN32SS][NTUSER] Fix popup menu freezing
Katayama Hirofumi MZ [Sat, 10 Aug 2019 06:40:32 +0000 (15:40 +0900)]
[WIN32SS][NTUSER] Fix popup menu freezing

22 months ago[WIN32SS][NTGDI] Registry-based font management (#1816)
Katayama Hirofumi MZ [Sat, 10 Aug 2019 05:52:09 +0000 (14:52 +0900)]
[WIN32SS][NTGDI] Registry-based font management (#1816)

- Add IntGdiAddFontResourceEx function that is extended from IntGdiAddFontResource, in order to add dwFlags parameter.
- Add IntLoadFontsInRegistry function that will load the fonts from registry info.
- If loading from registry failed, IntLoadSystemFonts will be called.
- Use IntLoadFontsInRegistry rather than IntLoadSystemFonts in the OS startup.
- Add NameFromCharSet function.
- Append " (CharSetName)" to registry value name if not TrueType.

22 months ago[WIN32SS][NTUSER] Fix popup menu window styles (#1814)
Katayama Hirofumi MZ [Fri, 9 Aug 2019 23:33:25 +0000 (08:33 +0900)]
[WIN32SS][NTUSER] Fix popup menu window styles (#1814)

Fix the class style, the window style and the extended style of the popup menu window. CORE-16244

22 months ago[FREELDR] Fix erroneous change from d05be0da regarding RAMDISK loading in SETUPLDR.
Hermès Bélusca-Maïto [Thu, 8 Aug 2019 21:06:33 +0000 (23:06 +0200)]
[FREELDR] Fix erroneous change from d05be0da regarding RAMDISK loading in SETUPLDR.

Restore the correct position of (optional) RAMDISK loading code, before
attempting to open txtsetup.sif since the bootcd ISO might be the RAMDISK.

22 months ago[WIN32SS] Ensure the last menu item is not accidentally selected when a system menu... 1812/head
Mark Jansen [Wed, 7 Aug 2019 21:53:42 +0000 (23:53 +0200)]
[WIN32SS] Ensure the last menu item is not accidentally selected when a system menu is off-screen

22 months ago[WIN32SS] Do not propagate TPM_VERTICAL to sub-menus
Mark Jansen [Wed, 7 Aug 2019 20:14:58 +0000 (22:14 +0200)]
[WIN32SS] Do not propagate TPM_VERTICAL to sub-menus
With this change we can remove the workaround from the off-screen
menus dropping below their parent.
Many thanks to Joachim for his help debugging / testing this.


22 months ago[WIN32SS] Fix tray popup menus stuck to the bottom of the screen
Mark Jansen [Wed, 7 Aug 2019 19:50:25 +0000 (21:50 +0200)]
[WIN32SS] Fix tray popup menus stuck to the bottom of the screen
Dedicated to Joachim

22 months ago[WIN32SS] Fix off-screen menu's dropping below their parent
Mark Jansen [Tue, 6 Aug 2019 23:52:18 +0000 (01:52 +0200)]
[WIN32SS] Fix off-screen menu's dropping below their parent

22 months ago[WIN32SS] For application menu's, only exclude the menu item,
Mark Jansen [Tue, 6 Aug 2019 22:50:21 +0000 (00:50 +0200)]
[WIN32SS] For application menu's, only exclude the menu item,
not the entire window.
Because the application menu is part of the application window,
this would lead to bad results.

22 months ago[FONTVIEW] Broadcast WM_FONTCHANGE message (#1815)
Katayama Hirofumi MZ [Thu, 8 Aug 2019 12:41:15 +0000 (21:41 +0900)]
[FONTVIEW] Broadcast WM_FONTCHANGE message (#1815)

We have to send WM_FONTCHANGE message when the font list was changed.

22 months ago[WIN32SS][NTUSER] Fix MENU_DrawScrollArrows (#1753)
Katayama Hirofumi MZ [Thu, 8 Aug 2019 04:56:23 +0000 (13:56 +0900)]
[WIN32SS][NTUSER] Fix MENU_DrawScrollArrows (#1753)

Fix drawing the menu scrolling arrows. CORE-13211

22 months ago[FREELDR] Verbose error output for FS errors
Victor Perevertkin [Mon, 29 Jul 2019 20:25:03 +0000 (23:25 +0300)]
[FREELDR] Verbose error output for FS errors

22 months ago[FREELDR] Better fix for x64. Addendum to 268cdf57.
Hermès Bélusca-Maïto [Wed, 7 Aug 2019 17:30:55 +0000 (19:30 +0200)]
[FREELDR] Better fix for x64. Addendum to 268cdf57.

22 months ago[FREELDR] Fix EditBox initial string display length: do not count the NULL-terminator.
Hermès Bélusca-Maïto [Wed, 7 Aug 2019 17:18:04 +0000 (19:18 +0200)]
[FREELDR] Fix EditBox initial string display length: do not count the NULL-terminator.

22 months ago[FREELDR] Add ReactOS Setup as a custom boot type. (#1763) 1763/head
Yaroslav Kibysh [Sun, 28 Jul 2019 21:17:03 +0000 (00:17 +0300)]
[FREELDR] Add ReactOS Setup as a custom boot type. (#1763)
CORE-9023 CORE-16260

Co-authored-by: Hermès Bélusca-Maïto <>
22 months ago[FREELDR] Add "Edit Boot Command Line" feature. (#1763)
Yaroslav Kibysh [Sun, 28 Jul 2019 17:23:41 +0000 (20:23 +0300)]
[FREELDR] Add "Edit Boot Command Line" feature. (#1763)
CORE-9023 CORE-16260

Co-authored-by: Hermès Bélusca-Maïto <>
22 months ago[FREELDR] Some enhancements for the UI code. (#1763)
Hermès Bélusca-Maïto [Fri, 2 Aug 2019 19:35:23 +0000 (21:35 +0200)]
[FREELDR] Some enhancements for the UI code. (#1763)

- EditBox: Display the initial contents of the text buffer.
  This allows modifying already existing text in the passed buffer.

- Menu:
  * Make both MenuHeader and MenuFooter optional (but the latter is
    more "optional" than the former...).

  * Allow passing a user-provided "Context" structure to the key-press
    filter callback, and pass also the index of the menu item that has
    been selected.

- Minor formatting fixes.

22 months ago[FREELDR] Fix x64 build.
Hermès Bélusca-Maïto [Wed, 7 Aug 2019 16:47:54 +0000 (18:47 +0200)]
[FREELDR] Fix x64 build.

22 months ago[FREELDR] Don't call twice strlen() implicitly (in the min() macro).
Hermès Bélusca-Maïto [Wed, 7 Aug 2019 16:33:53 +0000 (18:33 +0200)]
[FREELDR] Don't call twice strlen() implicitly (in the min() macro).

22 months ago[FREELDR] xboxmem: Fix array out-of-bounds access (#1775)
Stanislav Motylkov [Wed, 7 Aug 2019 10:06:37 +0000 (13:06 +0300)]
[FREELDR] xboxmem: Fix array out-of-bounds access (#1775)

Memory map array should be large enough to fit additional descriptors.

CORE-16216 CORE-16267

22 months ago[SETUP][BOOTDATA][INF] Helvetica-to-Arial substitutes (#1809)
Katayama Hirofumi MZ [Wed, 7 Aug 2019 10:02:38 +0000 (19:02 +0900)]
[SETUP][BOOTDATA][INF] Helvetica-to-Arial substitutes (#1809)

Set the destinations of "Helvetica" font substitutes to "Arial". CORE-16264

22 months ago[SETUP][BOOTDATA][INF] Delete Tahoma-to-Tahoma substitutes (#1808)
Katayama Hirofumi MZ [Wed, 7 Aug 2019 10:01:25 +0000 (19:01 +0900)]
[SETUP][BOOTDATA][INF] Delete Tahoma-to-Tahoma substitutes (#1808)

Delete loopy Tahoma-to-Tahoma font substitutes. CORE-16264

22 months ago[WIN32K:NTGDI] Fix ASSERTS in REGION_bXformRgn. CORE-15992 1798/head
Doug Lyons [Sun, 4 Aug 2019 23:43:49 +0000 (18:43 -0500)]
[WIN32K:NTGDI] Fix ASSERTS in REGION_bXformRgn. CORE-15992

22 months ago[MEDIA][FONTS] Add Microsoft Sans Serif font (#1805)
Katayama Hirofumi MZ [Wed, 7 Aug 2019 03:31:13 +0000 (12:31 +0900)]
[MEDIA][FONTS] Add Microsoft Sans Serif font (#1805)

Add "Microsoft Sans Serif" fonts. CORE-16264

- Add "Microsoft Sans Serif" font by duplicating "Liberation Sans" font and renaming it.
- Add LICENSE file.

I made these font files by using FontForge. Its family name is "Microsoft Sans Serif". Its display name is "Microsoft Sans Serif". Its font filename is micross.ttf. The Underline Position is hacked by adding an integer value for workaround of FontForge's bug.

22 months ago[FREELDR] Some ARC-spec compatibility refactoring + simplifications & fixes.
Hermès Bélusca-Maïto [Tue, 6 Aug 2019 20:30:54 +0000 (22:30 +0200)]
[FREELDR] Some ARC-spec compatibility refactoring + simplifications & fixes.

- During loading and initialization of the list of operating systems
  available in freeldr.ini, convert any legacy operating system entry
  encountered -- they are like those in NTLDR's boot.ini file, i.e.:

    ArcOsLoadPartition="LoadIdentifier" /List /of /Options

  into a new operating system INI entry, like those used by default in
  FreeLoader. This allows us to avoid treating this corner-case later in
  different parts of the code. Also, the "BootType" value is now
  determined there, only once.

- Convert the OS loaders entry-points to ARC-compatible ones, following
  the "Advanced RISC Computing Specification, Version 1.2" specification

- Introduce helpers for retrieving options values from the argument vector
  in a simple way.

- Simplify LoadOperatingSystem(), since now the "BootType" value has
  been determined once while loading the list of OSes (see above) and
  is well-defined there. Use the BuildArgvForOsLoader() helper to build
  the ARC-compatible argument vector from the corresponding INI settings
  for the selected operating system entry, and use it when calling the
  corresponding OS loader.

- In the OS loaders, since we can now directly read the settings from
  the argument vector (instead of using INI settings), we can avoid
  using a bunch of fixed-size string buffers, and avoid potentially
  failing IniOpenSection() calls as well.

- Simplify code in the Linux loader (and the RemoveQuotes() function).

- Add UiShowMessageBoxesInArgv() that acts on the "MessageBox=" settings
  passed through the argument vector (equivalent to
  UiShowMessageBoxesInSection() ).

- Use string-safe functions where needed (copy/concatenation/printf on
  fixed-size buffers).

22 months ago[FREELDR] Add an INI helper that allows modifying an existing setting's value in...
Hermès Bélusca-Maïto [Fri, 2 Aug 2019 21:32:30 +0000 (23:32 +0200)]
[FREELDR] Add an INI helper that allows modifying an existing setting's value in memory.

22 months ago[WIN32SS] Exclude the entire menu from overlapping, not just the menu item 1807/head
Mark Jansen [Mon, 5 Aug 2019 20:57:21 +0000 (22:57 +0200)]
[WIN32SS] Exclude the entire menu from overlapping, not just the menu item

22 months ago[WIN32SS] Iteratively mutate menu flags until we find a 'best fit'
Mark Jansen [Sun, 4 Aug 2019 21:47:02 +0000 (23:47 +0200)]
[WIN32SS] Iteratively mutate menu flags until we find a 'best fit'

22 months ago[WIN32SS] Rewrite MENU_ShowPopup to take the exclude rectangle into account
Mark Jansen [Sat, 15 Jun 2019 19:14:41 +0000 (21:14 +0200)]
[WIN32SS] Rewrite MENU_ShowPopup to take the exclude rectangle into account

22 months ago[SHELL32] Improve ShellExecute
Joachim Henze [Tue, 6 Aug 2019 18:24:55 +0000 (20:24 +0200)]
[SHELL32] Improve ShellExecute

This fixes regression CORE-6412 and also fixes CORE-12927
by bringing us a bit closer to Wine implementation.

Thanks to patches author Doug Lyons.
The removed code looks like historic workaround code.

Automated tests do improve as well

I intend to merge this back into 0.4.12RC.

22 months ago[SYSSETUP] Caption of 2nd stage ReactOS Setup is too heavy (#1806)
Katayama Hirofumi MZ [Tue, 6 Aug 2019 02:09:56 +0000 (11:09 +0900)]
[SYSSETUP] Caption of 2nd stage ReactOS Setup is too heavy (#1806)

The caption text of 2nd stage ReactOS Setup was too bold. CORE-16295

22 months ago[INF] Added BTRFS inf to remove unknown device
Benjamin Aerni [Mon, 5 Aug 2019 19:18:23 +0000 (12:18 -0700)]
[INF] Added BTRFS inf to remove unknown device


22 months ago[SERVICES] Enable the backup and restore privileges before loading or unloading a...
Eric Kohl [Mon, 5 Aug 2019 18:18:17 +0000 (20:18 +0200)]
[SERVICES] Enable the backup and restore privileges before loading or unloading a user profile and then disable them again.