reactos.git
2 years ago[MSI_WINETEST] Fix MSVC_IDE build. (#564)
Serge Gautherie [Thu, 7 Jun 2018 16:27:56 +0000 (18:27 +0200)]
[MSI_WINETEST] Fix MSVC_IDE build. (#564)

"reactos-cov\modules\rostests\winetests\msi\msi_winetest.rc(2): error RC2135: file not found: custom.dll [C:\ros_build\modules\rostests\winetests\msi\msi_winetest.vcxproj]".

Output files are written to Debug\ and Release\ subfolders in VSSolution mode, so the RC compiler will only find custom.dll if it knows to look in the right folder.

Thanks to Thomas Faber, who helped.

CORE-11836

2 years ago[SHELL32] Split dialogs/folder_options.cpp (#582)
Katayama Hirofumi MZ [Wed, 6 Jun 2018 12:04:50 +0000 (21:04 +0900)]
[SHELL32] Split dialogs/folder_options.cpp (#582)

The dialogs/folder_options.cpp source file in shell32 is too big to manage. We will split it to smaller files.
CORE-12906

2 years ago[CRT] Always initialize _[w]pgmptr with a *FULL* path to the current application.
Hermès Bélusca-Maïto [Tue, 5 Jun 2018 21:50:11 +0000 (23:50 +0200)]
[CRT] Always initialize _[w]pgmptr with a *FULL* path to the current application.

Otherwise fall back to the computed argv[0].
This is expected by some applications, for example Git.
Code is adapted from Wine.

Many thanks to Stanislav Motylkov for having investigated this bug!

CORE-12931 CORE-13892 CORE-13898 CORE-14066

2 years ago[USER32_APITEST] RedrawWindow: Add a DestroyWindow() call (#423)
Serge Gautherie [Tue, 5 Jun 2018 19:23:21 +0000 (21:23 +0200)]
[USER32_APITEST] RedrawWindow: Add a DestroyWindow() call (#423)

Addendum to 7905efdf357ad830d4abba23a428dcd9e6195247.

CORE-13734

2 years ago[RSHELL] Remove a duplicated add_custom_command() call (#570)
Serge Gautherie [Tue, 5 Jun 2018 18:17:34 +0000 (20:17 +0200)]
[RSHELL] Remove a duplicated add_custom_command() call (#570)

2 years ago[EXT2FS][REISERFS] VSSolution: Actually disable C4189 errors (#540)
Serge Gautherie [Tue, 5 Jun 2018 18:16:22 +0000 (20:16 +0200)]
[EXT2FS][REISERFS] VSSolution: Actually disable C4189 errors (#540)

Multiple "error C4189: '[...]': local variable is initialized but not referenced".

Thanks to Yuntian Zhang, who hinted at this in CORE-11836.

CORE-11280

2 years ago[BROWSEUI] Remove a duplicated add_custom_command() call
Serge Gautherie [Fri, 25 May 2018 10:25:55 +0000 (12:25 +0200)]
[BROWSEUI] Remove a duplicated add_custom_command() call

2 years ago[AUTOCHK] Allow users to skip disk checking if dirty
Pierre Schweitzer [Tue, 5 Jun 2018 17:33:36 +0000 (19:33 +0200)]
[AUTOCHK] Allow users to skip disk checking if dirty

CORE-14692

2 years ago[VFATLIB] Only check volume if full scan or if allowed to fix it
Pierre Schweitzer [Tue, 5 Jun 2018 17:30:11 +0000 (19:30 +0200)]
[VFATLIB] Only check volume if full scan or if allowed to fix it

This allows doing a quick probe about whether a volume needs to be
fixed by checking its dirty bit.

CORE-14692

2 years ago[CONFIGURE][CMAKE] Remove Visual Studio 9 (2008) support
Serge Gautherie [Fri, 25 May 2018 00:49:08 +0000 (02:49 +0200)]
[CONFIGURE][CMAKE] Remove Visual Studio 9 (2008) support

ReactOS does not compile anymore with it.
VS9 is already officially unsupported.

CORE-11836

2 years ago[CMAKE] Add "--always" parameter to "git describe" call
Serge Gautherie [Tue, 29 May 2018 14:02:26 +0000 (16:02 +0200)]
[CMAKE] Add "--always" parameter to "git describe" call

"fatal: No names found, cannot describe anything." message,
when called without enough history, i.e. appveyor.yml "clone_depth: 5".

2 years ago[MSHTA] Implement MSHTA.exe (#577) CORE-12813
Jared Smudde [Tue, 5 Jun 2018 15:17:00 +0000 (10:17 -0500)]
[MSHTA] Implement MSHTA.exe (#577) CORE-12813

Implement mshta.exe. It links directly to the function RunHTMLApplication in mshtml and passes the file name and other optional arguments along. While the function is unimplemented in mshtml, it's a start.

[MSHTML] Add ADD_IMPORTLIB to CMakeLists so mshta can link to mshtml.
[BOOTDATA] Add the association information for mshta.exe to the registry.

2 years ago[NTOS:CC] Access SectionObjectPointers without lock in CcRosInitializeFileCache.... 596/head
Thomas Faber [Mon, 4 Jun 2018 12:36:07 +0000 (14:36 +0200)]
[NTOS:CC] Access SectionObjectPointers without lock in CcRosInitializeFileCache. CORE-14691

kmtest:NtCreateSection calls CcInitializeCacheMap with a
NULL value for SectionObjectPointers. This will cause an exception when
trying to access it, which in Windows can be handled gracefully.
However accessing it while holding ViewLock means the lock will not be
released, leading to an APC_INDEX_MISMATCH bugcheck.

This solves the problem by allocating SharedCacheMap outside the lock,
then freeing it again under lock if another thread has updated SharedCacheMap
in the mean time. This is also What Windows Does(TM).

2 years ago[FONTS] Delete 16px bitmap from Tahoma Bold
Katayama Hirofumi MZ [Mon, 4 Jun 2018 23:20:25 +0000 (08:20 +0900)]
[FONTS] Delete 16px bitmap from Tahoma Bold

2 years ago[OLE32_WINETEST] Fix MSVC build.
Thomas Faber [Tue, 5 Jun 2018 09:36:30 +0000 (11:36 +0200)]
[OLE32_WINETEST] Fix MSVC build.

2 years ago[JSCRIPT] Fix MSVC build.
Thomas Faber [Mon, 4 Jun 2018 18:25:13 +0000 (20:25 +0200)]
[JSCRIPT] Fix MSVC build.

2 years ago[XMLLITE_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:59:33 +0000 (03:59 +0100)]
[XMLLITE_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[WTSAPI32] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:59:11 +0000 (03:59 +0100)]
[WTSAPI32] Sync with Wine Staging 3.9. CORE-14656

2 years ago[WMVCORE] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:58:45 +0000 (03:58 +0100)]
[WMVCORE] Sync with Wine Staging 3.9. CORE-14656

2 years ago[WINTRUST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:58:20 +0000 (03:58 +0100)]
[WINTRUST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[WININET_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:57:53 +0000 (03:57 +0100)]
[WININET_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[WININET] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:57:34 +0000 (03:57 +0100)]
[WININET] Sync with Wine Staging 3.9. CORE-14656

2 years ago[WINHTTP_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:57:07 +0000 (03:57 +0100)]
[WINHTTP_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[WINHTTP] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:56:48 +0000 (03:56 +0100)]
[WINHTTP] Sync with Wine Staging 3.9. CORE-14656

2 years ago[WINDOWSCODECS_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:56:11 +0000 (03:56 +0100)]
[WINDOWSCODECS_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[WINDOWSCODECS] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:55:39 +0000 (03:55 +0100)]
[WINDOWSCODECS] Sync with Wine Staging 3.9. CORE-14656

2 years ago[INCLUDE/WINE] Update rbtree.h. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:54:55 +0000 (03:54 +0100)]
[INCLUDE/WINE] Update rbtree.h. CORE-14656

2 years ago[WBEMPROX] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:54:01 +0000 (03:54 +0100)]
[WBEMPROX] Sync with Wine Staging 3.9. CORE-14656

2 years ago[VERSION] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:53:34 +0000 (03:53 +0100)]
[VERSION] Sync with Wine Staging 3.9. CORE-14656

2 years ago[VBSCRIPT_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:53:02 +0000 (03:53 +0100)]
[VBSCRIPT_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[VBSCRIPT] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:52:36 +0000 (03:52 +0100)]
[VBSCRIPT] Sync with Wine Staging 3.9. CORE-14656

2 years ago[USP10_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:51:59 +0000 (03:51 +0100)]
[USP10_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[USP10] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:51:34 +0000 (03:51 +0100)]
[USP10] Sync with Wine Staging 3.9. CORE-14656

2 years ago[URLMON_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:50:58 +0000 (03:50 +0100)]
[URLMON_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[URLMON] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:50:24 +0000 (03:50 +0100)]
[URLMON] Sync with Wine Staging 3.9. CORE-14656

2 years ago[RPCRT4_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:49:34 +0000 (03:49 +0100)]
[RPCRT4_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[RPCRT4] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:49:11 +0000 (03:49 +0100)]
[RPCRT4] Sync with Wine Staging 3.9. CORE-14656

2 years ago[RICHED20_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:48:31 +0000 (03:48 +0100)]
[RICHED20_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[RICHED20] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:48:07 +0000 (03:48 +0100)]
[RICHED20] Sync with Wine Staging 3.9. CORE-14656

2 years ago[PROPSYS] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:47:25 +0000 (03:47 +0100)]
[PROPSYS] Sync with Wine Staging 3.9. CORE-14656

2 years ago[PIDGEN] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:46:44 +0000 (03:46 +0100)]
[PIDGEN] Sync with Wine Staging 3.9. CORE-14656

2 years ago[OLE32_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:46:11 +0000 (03:46 +0100)]
[OLE32_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[OLE32] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:45:35 +0000 (03:45 +0100)]
[OLE32] Sync with Wine Staging 3.9. CORE-14656

2 years ago[ODBCCP32_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:44:42 +0000 (03:44 +0100)]
[ODBCCP32_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[ODBCCP32] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:44:04 +0000 (03:44 +0100)]
[ODBCCP32] Sync with Wine Staging 3.9. CORE-14656

2 years ago[NTDSAPI] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:43:22 +0000 (03:43 +0100)]
[NTDSAPI] Sync with Wine Staging 3.9. CORE-14656

2 years ago[PSDK] Update ntdsapi.h. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:42:29 +0000 (03:42 +0100)]
[PSDK] Update ntdsapi.h. CORE-14656

2 years ago[MSCTF_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:41:36 +0000 (03:41 +0100)]
[MSCTF_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[MSCTF] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:41:08 +0000 (03:41 +0100)]
[MSCTF] Sync with Wine Staging 3.9. CORE-14656

2 years ago[PSDK] Update msctf.idl. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:40:17 +0000 (03:40 +0100)]
[PSDK] Update msctf.idl. CORE-14656

2 years ago[JSCRIPT_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:39:17 +0000 (03:39 +0100)]
[JSCRIPT_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[JSCRIPT] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:38:45 +0000 (03:38 +0100)]
[JSCRIPT] Sync with Wine Staging 3.9. CORE-14656

2 years ago[ITSS_WINETEST] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:37:50 +0000 (03:37 +0100)]
[ITSS_WINETEST] Sync with Wine Staging 3.9. CORE-14656

2 years ago[ITSS] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:37:18 +0000 (03:37 +0100)]
[ITSS] Sync with Wine Staging 3.9. CORE-14656

2 years ago[IMM32] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:36:30 +0000 (03:36 +0100)]
[IMM32] Sync with Wine Staging 3.9. CORE-14656

2 years ago[IEFRAME] Sync with Wine Staging 3.9. CORE-14656
Amine Khaldi [Mon, 4 Jun 2018 02:35:42 +0000 (03:35 +0100)]
[IEFRAME] Sync with Wine Staging 3.9. CORE-14656

2 years ago[SYSSETUP] If creating the default-user hive file fails because the file already...
Hermès Bélusca-Maïto [Sun, 3 Jun 2018 23:36:19 +0000 (01:36 +0200)]
[SYSSETUP] If creating the default-user hive file fails because the file already exists, make a backup (i.e. rename it) and retry its creation.

This situation happens when one "updates" ReactOS by re-installing it on top of an existing installation.

2 years ago[SETUPLIB] Silence annoying DPRINT1s.
Hermès Bélusca-Maïto [Sun, 3 Jun 2018 21:23:24 +0000 (23:23 +0200)]
[SETUPLIB] Silence annoying DPRINT1s.

2 years ago[USETUP] Use correct flags for the NtCreateFile call that creates new file directories.
Hermès Bélusca-Maïto [Wed, 31 May 2017 02:08:16 +0000 (04:08 +0200)]
[USETUP] Use correct flags for the NtCreateFile call that creates new file directories.

DIRECTORY_ALL_ACCESS is not the correct flag, because it is used with the NtCreateDirectoryObject API
that creates virtual "directories" in the NT object namespace; that's not our purpose here.

svn path=/branches/setup_improvements/; revision=74716

2 years ago[SETUPLIB][USETUP] Diverse additions.
Hermès Bélusca-Maïto [Wed, 31 May 2017 01:43:12 +0000 (03:43 +0200)]
[SETUPLIB][USETUP] Diverse additions.

- Use NT string safe functions.
- Add support for other bootloaders;
- Update a couple of comments;
- Remove deprecated __REACTOS__ #ifdefs.

svn path=/branches/setup_improvements/; revision=74713

2 years ago[SETUPLIB] Adjustments in the code.
Hermès Bélusca-Maïto [Wed, 31 May 2017 01:11:05 +0000 (01:11 +0000)]
[SETUPLIB] Adjustments in the code.

- Call OpenAndMapFile() with its new ReadWrite parameter;
- Add informative comments in osdetect.c;
- In partlist.c, check whether a disk has a valid MBR by also checking for its 0xAA55 signature.

svn path=/branches/setup_improvements/; revision=74712

2 years ago[SETUPLIB] Additions for filesup.c and inicache.c.
Hermès Bélusca-Maïto [Wed, 31 May 2017 00:18:13 +0000 (00:18 +0000)]
[SETUPLIB] Additions for filesup.c and inicache.c.

- In DoesFileExist(): Call NtOpenFile with FILE_GENERIC_READ instead of the more generic GENERIC_READ access right.
- OpenAndMapFile(): Add support for opening & mapping files with write access (to be used latter).

svn path=/branches/setup_improvements/; revision=74710

- Split IniCacheLoad() and IniCacheSave() into: themselves & IniCacheLoadByHandle() and IniCacheSaveByHandle(),
  respectively, so that we can load & save INI files if we already have an opened handle to them.

svn path=/branches/setup_improvements/; revision=74711

2 years ago[USETUP] Minor fixes & simplifications.
Hermès Bélusca-Maïto [Tue, 30 May 2017 00:15:54 +0000 (00:15 +0000)]
[USETUP] Minor fixes & simplifications.

- Remove a redundant NtClose() call;
- Return failure if NtQuerySymbolicLinkObject() fails;
- Use RTL_CONSTANT_STRING and RtlInitEmptyUnicodeString() where needed;
- Reduce code indent level;
- Add old-style function annotations;
- Remove the deprecated code copyright notice, since the copyright in usage is already reported in the COPYING file in the top level ReactOS source code directory.

svn path=/branches/setup_improvements/; revision=74698

2 years ago[SETUPLIB] Add a new module "bldrsup.c" (WIP) where I place all the NT boot loaders...
Hermès Bélusca-Maïto [Thu, 25 May 2017 23:52:50 +0000 (23:52 +0000)]
[SETUPLIB] Add a new module "bldrsup.c" (WIP) where I place all the NT boot loaders (i.e. ntldr, freeldr, and possibly bootmgr in the future) management functions.

So far we only have:
- a function FindNTOSBootLoader() that detects the existence of a given boot loader;
- a function EnumerateNTOSBootEntries() (and corresponding helpers) that enumerate the different boot entries in the configuration file(s) for a given boot loader, and for each entry, calls a user-provided callback.
Only supported at the moment: ntldr and freeldr.
Doing that allows me to simplify large portions of the NT-OS detection code so that it becomes more bootloader-agnostic, and this will help me for simplifying some parts of usetup/bootsup.c too, later...

svn path=/branches/setup_improvements/; revision=74661

2 years ago[SETUPLIB][USETUP] Refactor the DoesFileExist() function so that it now looks closer...
Hermès Bélusca-Maïto [Wed, 24 May 2017 16:37:49 +0000 (16:37 +0000)]
[SETUPLIB][USETUP] Refactor the DoesFileExist() function so that it now looks closer to DoesPathExist() and use it almost everywhere.

- Adjust also its callers, adjust OpenAndMapFile() parameters.
- Related to that, simplify IsValidNTOSInstallation() parameters & introduce a IsValidNTOSInstallation_UStr()
  that does the same, but takes a UNICODE_STRING instead.
- Simplify CheckForValidPEAndVendor().

Now only exactly 5 calls use the "old" 'DoesFileExist' syntax, using a temporarily auxiliary function "DoesFileExist_2"...

svn path=/branches/setup_improvements/; revision=74641

2 years ago[SETUPLIB][USETUP] Transform the existing ConcatPaths() function into a variadic...
Hermès Bélusca-Maïto [Tue, 23 May 2017 22:30:54 +0000 (22:30 +0000)]
[SETUPLIB][USETUP] Transform the existing ConcatPaths() function into a variadic function, and derive a CombinePaths() from it (plus their equivalent taking va_list).

This allows building concatenated paths with an arbitrary number of separated components.
- Use the newly-introduced CombinePaths() and ConcatPaths() functions.
- Fix also few comments, and place some UNICODE_NULLs here & there.

svn path=/branches/setup_improvements/; revision=74637
svn path=/branches/setup_improvements/; revision=74640

2 years ago[SETUPLIB][USETUP] Move some code to the SetupLib.
Hermès Bélusca-Maïto [Tue, 23 May 2017 11:39:12 +0000 (11:39 +0000)]
[SETUPLIB][USETUP] Move some code to the SetupLib.

- filesup.c's functions ConcatPaths(), Does[Path|File]Exist(), NtPathToDiskPartComponents(), OpenAndMapFile(), UnMapFile();
- Move the inicache library to setuplib as it'll be used for the 1st stage GUI setup too (indeed, there is no good INI file API
  under Win32; the Win32 profile "API" is just good enough to manipulate the win16 ini files, and are here anyways for backward
  compatibility purposes only);
- Move the OS detector too.
- Remove the duplicated ConcatPaths() code in arcname.c.

svn path=/branches/setup_improvements/; revision=74634
svn path=/branches/setup_improvements/; revision=74638

2 years ago[NTOSKRNL] Ignore IMAGE_SCN_CNT_UNINITIALIZED_DATA
Mark Jansen [Thu, 19 Apr 2018 19:58:09 +0000 (21:58 +0200)]
[NTOSKRNL] Ignore IMAGE_SCN_CNT_UNINITIALIZED_DATA
CORE-12582
CORE-14556

2 years ago[NTDLL_APITEST] Add tests for mapping and relocating an image with IMAGE_SCN_CNT_UNIN...
Thomas Faber [Thu, 19 Apr 2018 19:55:35 +0000 (21:55 +0200)]
[NTDLL_APITEST] Add tests for mapping and relocating an image with IMAGE_SCN_CNT_UNINITIALIZED_DATA
CORE-12582
CORE-14556

2 years ago[CREDITS] Update the credits list
Stanislav Motylkov [Thu, 31 May 2018 21:10:42 +0000 (00:10 +0300)]
[CREDITS] Update the credits list

2 years ago[SYSDM] Update the credits list
Stanislav Motylkov [Thu, 31 May 2018 18:23:42 +0000 (21:23 +0300)]
[SYSDM] Update the credits list

Added to Development Team:

Aleksandar Andrejevic
Alexander Shaposhnikov
Amine Khaldi
Benedikt Freisen
Cameron Gutman
David Quintana
Giannis Adamopoulos
Hermès Bélusca-Maïto
Jérôme Gardou
Katayama Hirofumi MZ
Mark Jansen
Peter Hater
Stanislav Motylkov
Thomas Faber
Vadim Galyant

Added to Release Engineers:

Amine Khaldi
Joachim Henze
Thomas Faber

2 years ago[SYSDM] Fix typo in the credits
Stanislav Motylkov [Thu, 31 May 2018 16:22:27 +0000 (19:22 +0300)]
[SYSDM] Fix typo in the credits

Contributers -> Contributors

2 years ago[SCREENSAVER] Add Italian translation. (#587)
SebastianoPistore [Sun, 3 Jun 2018 14:43:50 +0000 (16:43 +0200)]
[SCREENSAVER] Add Italian translation. (#587)

By Sebastiano Pistore.

2 years ago[COMCTL32] Simplify some ifdefs CORE-14649
Joachim Henze [Sun, 3 Jun 2018 12:27:34 +0000 (14:27 +0200)]
[COMCTL32] Simplify some ifdefs CORE-14649

Addendum to 16d6c9b5e05ffd7a0fff29531f69e18b010124c0
Giannis suggested and Thomas explained:

Before the Wine sync, comctl32/button.c was based on ROS's
user32/button.c, so _USER32_ would highlight changes between
user32 (originally based on Wine) and comctl32. Now our
comctl32/button.c is based on Wine's comctl32/button.c, so
__REACTOS__ is enough.

2 years ago[CMD] Improve the situations when the console title can be changed.
Hermès Bélusca-Maïto [Sun, 3 Jun 2018 00:15:44 +0000 (02:15 +0200)]
[CMD] Improve the situations when the console title can be changed.

- Introduce two small helpers to change and restore the console title.
- Console title can change even when internal commands are executed.
- Note that when commands are run from within batch files, title is unchanged.
- When "cmd.exe /c command" is run, the console title is unchanged; however
  when "cmd.exe /k command" is run, the console title changes.

2 years ago[CMD] Print a newline after the interactive 'pause' command message finishes to run.
Hermès Bélusca-Maïto [Sun, 3 Jun 2018 00:13:11 +0000 (02:13 +0200)]
[CMD] Print a newline after the interactive 'pause' command message finishes to run.

2 years ago[BOOTDATA] Use double quotes for mspaint file path
Stanislav Motylkov [Sat, 2 Jun 2018 10:17:41 +0000 (13:17 +0300)]
[BOOTDATA] Use double quotes for mspaint file path

Addendum to 313ded4. CORE-13293

2 years ago[ZIPFLDR] Fix text-cutoff + improve de-DE CORE-14682
Joachim Henze [Sat, 2 Jun 2018 20:03:03 +0000 (22:03 +0200)]
[ZIPFLDR] Fix text-cutoff + improve de-DE CORE-14682

2 years ago[SYSDM] Improvements to the user profile page
Eric Kohl [Sat, 2 Jun 2018 14:11:10 +0000 (16:11 +0200)]
[SYSDM] Improvements to the user profile page

- Store the full profile user name in the listview item for later use in the delete and copy functions.
- Change the button state according to the selected profile.
- Fix some hard-coded string sizes.

2 years ago[CRT] Reimplement qsort() using FreeBSD implementation.
Pierre Schweitzer [Sat, 2 Jun 2018 11:52:09 +0000 (13:52 +0200)]
[CRT] Reimplement qsort() using FreeBSD implementation.

Our implementation had a bug that could be triggered while
building our USBD library on ReactOS: the compare function
could be called with a NULL pointer instead of a valid value.

With this bug fixed (and the cmd hack in CORE-14648), ReactOS
can totally selfhost :-)! I was able to build LiveCD and BootCD
without any trouble, crash, deadlock or whatever.
(Next step: having a buildbot slave hosted on ReactOS ;-)).

Enjoy: https://twitter.com/HeisSpiter/status/1002880397103988737

CORE-14680

2 years ago[COMCTL32] Fix regression CORE-14649
Joachim Henze [Sat, 2 Jun 2018 10:26:48 +0000 (12:26 +0200)]
[COMCTL32] Fix regression CORE-14649

Fixes a regression that was introduced by Wine Staging 3.3 Sync.
Symptom was missing button text and icons for specific buttons
in Delphi applications, e.g. Double-Commander, Lazarus, Peazip.
The patch restores and ifdef-guards previous changes of Giannis.

2 years ago[SYSDM] Retrieve and show the domain and user names for the user profiles
Eric Kohl [Sat, 2 Jun 2018 10:18:19 +0000 (12:18 +0200)]
[SYSDM] Retrieve and show the domain and user names for the user profiles

Fixes CORE-11789

2 years ago[KERNEL32] Get/SetTimeZoneInformation: Convert the Milliseconds value between TIME_FI...
Eric Kohl [Fri, 1 Jun 2018 10:49:26 +0000 (12:49 +0200)]
[KERNEL32] Get/SetTimeZoneInformation: Convert the Milliseconds value between TIME_FIELDS and SYSTEMTIME too

CORE-14658

2 years agoCreate a Code of conduct to complete the Github community checklist (#431)
Dheeraj Bhaskar [Thu, 31 May 2018 21:26:33 +0000 (02:56 +0530)]
Create a Code of conduct to complete the Github community checklist (#431)

2 years ago[MSPAINT] use __targv[1] instead of lpszArgument
Benedikt Freisen [Thu, 31 May 2018 18:17:30 +0000 (20:17 +0200)]
[MSPAINT] use __targv[1] instead of lpszArgument

This should make Paint's handling of command line strings less brittle.

CORE-13293

2 years ago[USETUP] Some fixes/improvements suggested by Thomas (2/2).
Hermès Bélusca-Maïto [Mon, 22 May 2017 15:55:16 +0000 (17:55 +0200)]
[USETUP] Some fixes/improvements suggested by Thomas (2/2).

- In the partlist.c disk getters: Remove useless "IsListEmpty(&List->DiskListHead)" checks, because this is actually the kind of check the while() loop does just after...
- Fix few DPRINTs.

svn path=/branches/setup_improvements/; revision=74629

2 years ago[USETUP] Further improve the OS detection code.
Hermès Bélusca-Maïto [Mon, 22 May 2017 22:59:11 +0000 (22:59 +0000)]
[USETUP] Further improve the OS detection code.

- Improve FindExistingNTOSInstall() so that we can find an existing installation either by system root
  ARC path or NT path. This is used during the enumeration of available installations from the boot.ini/freeldr.ini
  and during other existence & validity checks of NTOS installations.
- Improve AddNTOSInstallation() so that we can save the system root ARC path and NT path of the installation,
  as well as its partition entry structure pointer, for caching & later retrieval purposes.
- Remove some deprecated comments & todos, and implement other todos.
- Improve the output of some DPRINTs.
- Fix the return value of FindSubStrI.

svn path=/branches/setup_improvements/; revision=74632

2 years ago[USETUP] Some fixes/improvements suggested by Thomas (1/2).
Hermès Bélusca-Maïto [Mon, 22 May 2017 15:55:16 +0000 (17:55 +0200)]
[USETUP] Some fixes/improvements suggested by Thomas (1/2).

- isspace('\0') returns FALSE anyways so no need to separately test for a NULL character;
- The (str/wcs)toul function cannot return a NULL pointer from its second paramter;
- VersionInfo32_FindChild(): the third argument is indeed a number of characters (not bytes),
  so rename the parameter to make this fact clear. The function is however correctly used within this module.

svn path=/branches/setup_improvements/; revision=74629

2 years ago[USETUP] Improve the NTOS installations detector.
Hermès Bélusca-Maïto [Mon, 22 May 2017 01:19:08 +0000 (01:19 +0000)]
[USETUP] Improve the NTOS installations detector.

In all the disks/partitions available, it searches for the presence of freeldr.ini / boot.ini, open & parse them,
and enumerates the available boot entries (as candidates for installations). For each of them, it maps their ARC paths
into the NT namespace (hence the ARC 2 NT path resolver committed in r74621), then attempts to detect in these paths
the existence of NTOS installations.

svn path=/branches/setup_improvements/; revision=74622

2 years ago[SETUPLIB] Add an ARC path to (and from) NT path resolver.
Hermès Bélusca-Maïto [Mon, 22 May 2017 01:09:35 +0000 (01:09 +0000)]
[SETUPLIB] Add an ARC path to (and from) NT path resolver.

The NT path resolver allows mapping between an ARC path as specified in freeldr.ini / boot.ini , to its corresponding NT path, if possible.
Currently, only the mapping direction "ARC to NT" is implemented. It will be used wherever such mappings are needed, for example when identifying
the ReactOS / Windows installations from the available freeldr.ini / boot.ini entries (for upgrading / repair purposes).

The resolver supports the usual ARC paths: multi()disk()[r|f]disk()[partition()] ; eisa()disk()[r|f]disk()[partition()] ; multi()disk()cdrom() ;
scsi()disk()[r|f]disk()[partition()] ; scsi()cdrom()fdisk() ; ramdisk(x) ; net(x) (actually reported as "unsupported" since it would map to some
path on some network), and the newly-introduced Win2k signature()disk()rdisk()[partition()].

The code is in work-in-progress status.
Some validation tests, that were used during the implementation of the resolver, have been added.

svn path=/branches/setup_improvements/; revision=74621
svn path=/branches/setup_improvements/; revision=74631

2 years ago[USETUP][SETUPLIB] Move all the code that retrieves the version resources from PE...
Hermès Bélusca-Maïto [Sun, 21 May 2017 23:41:04 +0000 (23:41 +0000)]
[USETUP][SETUPLIB] Move all the code that retrieves the version resources from PE executable, out of osdetect.c, and place it in its own module inside the SetupLib.

Remove also some commented headers in precomp.h.

svn path=/branches/setup_improvements/; revision=74618

2 years ago[USETUP] PartList module: Add a couple of disk/partition getters: GetDiskByBiosNumber...
Hermès Bélusca-Maïto [Sun, 21 May 2017 23:36:13 +0000 (23:36 +0000)]
[USETUP] PartList module: Add a couple of disk/partition getters: GetDiskByBiosNumber, GetDiskByNumber, GetDiskBySCSI, GetDiskBySignature, GetPartition, GetDiskOrPartition.
They will be used in the subsequent commits.

svn path=/branches/setup_improvements/; revision=74617

2 years ago[USETUP] Introduce an NT OS installation detector: a functionality that attempts...
Hermès Bélusca-Maïto [Sat, 13 May 2017 16:13:19 +0000 (16:13 +0000)]
[USETUP] Introduce an NT OS installation detector: a functionality that attempts to detect installations of NT 5.x operating systems (MS Windows <= 2k3, ReactOS).

The aim is to use this detector to be able to detect and select an existing installation of ReactOS for upgrading.
The user then could either select one, or skip this step and perform a regular ReactOS installation.

What remains to be done, is to parse the NTOS loader configuration files (freeldr.ini in ReactOS' case, or boot.ini in Win2k3's case, etc...)
to retrieve the actual installation paths. So far these are currently hardcoded for testing purposes only.

The detector attempts to distinguish between ReactOS and Windows installations by checking at the company name vendor of the ntoskrnl.exe & ntdll.dll files,
so that only ReactOS installations are allowed to be upgraded.

svn path=/branches/setup_improvements/; revision=74527
svn path=/branches/setup_improvements/; revision=74550

2 years ago[NDK] Replace the SYSTEMTIME fields StandardDate and DaylightDate in RTL_TIME_ZONE_IN...
Eric Kohl [Thu, 31 May 2018 15:48:29 +0000 (17:48 +0200)]
[NDK] Replace the SYSTEMTIME fields StandardDate and DaylightDate in RTL_TIME_ZONE_INFORMATION by TIME_FIELDs and fix resulting errors

Patch will be sent upstream.

CORE-14658

2 years ago[NTDLL_APITEST] Add missing test file for 0f8e7207.
Eric Kohl [Thu, 31 May 2018 15:12:52 +0000 (17:12 +0200)]
[NTDLL_APITEST] Add missing test file for 0f8e7207.

CORE-14658

2 years ago[NTDLL_APITEST][LIB_RTL] Add a test for RtlQueryTimeZoneInformation and fix the bug...
Eric Kohl [Thu, 31 May 2018 14:47:42 +0000 (16:47 +0200)]
[NTDLL_APITEST][LIB_RTL] Add a test for RtlQueryTimeZoneInformation and fix the bug in RtlpQueryRegistryDirect

In working on some problems with Time Zone adjustments in  ReactOS I found that the RtlQueryTimeZoneInformation function is partially broken and wrote an apitest to capture the failures.

Patch by Doug Lyons.

CORE-14658

2 years ago[WINLOGON] Update Italian translation (#513) (by deleted user)
Hermès Bélusca-Maïto [Thu, 31 May 2018 13:41:09 +0000 (15:41 +0200)]
[WINLOGON] Update Italian translation (#513) (by deleted user)

2 years ago[SHELL32] Fix and improve the PickIconDlg function (#574)
Katayama Hirofumi MZ [Thu, 31 May 2018 13:33:07 +0000 (22:33 +0900)]
[SHELL32] Fix and improve the PickIconDlg function (#574)

CORE-10972

2 years ago[USERENV] LoadUserProfileW: User the user name passed in via lpProfileInfo to create...
Eric Kohl [Wed, 30 May 2018 21:28:27 +0000 (23:28 +0200)]
[USERENV] LoadUserProfileW: User the user name passed in via lpProfileInfo to create the profile directory instead of the user name extracted from the token

2 years ago[SHELL32] Implement the 'Advanced' button of the 'File Types' dialog (#565)
Katayama Hirofumi MZ [Wed, 30 May 2018 15:22:31 +0000 (00:22 +0900)]
[SHELL32] Implement the 'Advanced' button of the 'File Types' dialog (#565)

This allows the user to edit the File Type / extension information by clicking 'Advanced' button in the 'File Types' property sheet of Folder Options.
CORE-12906, CORE-10972