Katayama Hirofumi MZ [Fri, 15 May 2020 07:36:13 +0000 (16:36 +0900)]
[SHELL32] Don't hardcode C: drive again (#2777)
- Avoid buffer overrun.
- Don't hardcode C: drive.
CORE-13235
Katayama Hirofumi MZ [Thu, 14 May 2020 13:52:22 +0000 (22:52 +0900)]
[SHELL32] Implement SheShortenPathA (#2785)
Implement shell32!SheShortenPathA function.
Katayama Hirofumi MZ [Thu, 14 May 2020 13:51:53 +0000 (22:51 +0900)]
[SHELL32] Implement MakeShellURLFromPathA (#2784)
Implement shell32!MakeShellURLFromPathA function.
Ricardo Hanke [Thu, 14 May 2020 12:47:48 +0000 (14:47 +0200)]
[OPENGLCFG] Empty list boxes if registry key is missing (#2750)
If the registry key that holds the names of installed opengl drivers is missing, all list boxes in openglcfg are empty. This is a minor code rearrangement to fix this behavior.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Piotr Hetnarowicz [Thu, 14 May 2020 12:33:32 +0000 (14:33 +0200)]
[SHELL32] PL-pl Dialogs fix (#2788)
- Fixed invisible text in DIALOGS.
George Bișoc [Thu, 14 May 2020 12:32:38 +0000 (14:32 +0200)]
[NTDLL_APITEST] Add initial NtQueryInformationThread() testcase (#2782)
Serge Gautherie [Thu, 14 May 2020 12:31:53 +0000 (14:31 +0200)]
[NDK][XDK] Add 3 CM_RESOURCE_INTERRUPT_* defines (#2755)
Kyle Katarn [Thu, 14 May 2020 12:30:57 +0000 (14:30 +0200)]
[SNDREC32] Use the ShellAboutW API routine to display the about dialog (#2754)
Kyle Katarn [Thu, 14 May 2020 12:30:35 +0000 (14:30 +0200)]
[SERVMAN] Use the ShellAboutW API routine to display the about dialog (#2752)
Kyle Katarn [Thu, 14 May 2020 12:28:57 +0000 (14:28 +0200)]
[RAPPS] Use ShellAbout() to display the about dialog (#2751)
As the dialog simply displays the copyright names and nothing particular it makes sense to use ShellAboutW() instead.
Kyle Katarn [Thu, 14 May 2020 12:24:59 +0000 (14:24 +0200)]
[SHORTCUTS] Addition of Wine IE Shortcuts in Start Menu (#2726)
CORE-11257
Kyle Katarn [Thu, 14 May 2020 12:24:13 +0000 (14:24 +0200)]
[SYSDM][USRMGR] French translation update (#2765)
CORE-16596
Erdem Ersoy [Thu, 14 May 2020 12:23:05 +0000 (15:23 +0300)]
[TRANSLATIONS] Turkish translation updates (#2724)
* [TRANSLATIONS] Translate desk.cpl to Turkish
* Update file header
* [TRANSLATIONS]
* Update translations of syssteup
* Update translations of userenv
* Update translations of shell32 (partial)
* [TRANSLATION] Fix a translation
* [TRANSLATION] Translate Turkish strings to Turkish
for hivedef.inf
* Update Turkish translations of shell32 partially
* Update shell32 Turkish translations (partially)
* Update shell32 Turkish translations (partially)
* Fix translation for desk.cpl
Oleg Dubinskiy [Thu, 14 May 2020 12:21:16 +0000 (15:21 +0300)]
[REGAPI] Import regapi.dll from Wine Staging 5.7 CORE-16458 (#2723)
- Comment some other missing exports Windows regapi.dll has them, but Wine's one doesn't.
Required by MS winlogon with Win32SS replaced. I double-rechecked: now it doesn't fail due to missing regapi.dll in system32 or separate missing functions in this dll, exactly the same as with MS regapi. In pair with my profmap.dll (which was merged recently), now it fails due to InitializeUserProfile() stub in our userenv.dll (if to replace msgina too).
Also I compared the exports of MS regapi.dll and Wine's one. Win2k3 version has all exports that Wine version has and some others (which looks like were dropped in NT6). But those exports which already exist, are enough to allow MS winlogon no longer fail.
CORE-16458
Katayama Hirofumi MZ [Thu, 14 May 2020 00:47:21 +0000 (09:47 +0900)]
[SHLWAPI] Implement SHIsLowMemoryMachine (#2783)
Implement shlwapi!SHIsLowMemoryMachine function.
Katayama Hirofumi MZ [Thu, 14 May 2020 00:38:38 +0000 (09:38 +0900)]
[SHELL32] Half-implement SHWinHelp
Joachim Henze [Wed, 13 May 2020 15:08:25 +0000 (17:08 +0200)]
[NTOSKRNL] Restore section layout for NTOSKRNL to fix BSOD regression CORE-14683
This version (after .rsrc) works different than the
proper version I used for 0.4.12 (after .reloc).
Inserting after .rsrc is actually not correct, but Thomas believes it can
be used as a temporary trick to avoid random memory corruption upon
relocations of the kernel, caused by ROSBE-154.
I follow his advice, although when judging from practical tests only:
as long as we limit this script to NTOSKRNL like I do for releases
there have no negative consequences been observed in real life yet
even with the proper version of 0.4.12.
Up to now those problems have only been observed when used for drivers
MODULE TYPE sdk/cmake/gcc.cmake as well, like
it was tried for a moment in master 0.4.13-dev-609-g
c4d8e2a6e9660c1f0d0d24877219baca443bbce0
Using for drivers immediately did lead to BSODs like CORE-16183 and therefore was
mitigated in master by total disabling of the scripts for both,
kernel and drivers in
0.4.13-dev-621-g
36e9a6f8ddc70018b55b0cad0b13128b1cbb60c2
To allow installing DVDWritenow without BSOD,
we need the script at least for ntoskrnl!
I committed this patch (after .rsrc) already into 0.4.13RC and 0.4.14RC.
Katayama Hirofumi MZ [Wed, 13 May 2020 13:36:44 +0000 (22:36 +0900)]
[MPLAY32] Don't hardcode C: drive (#2778)
CORE-13235
Katayama Hirofumi MZ [Wed, 13 May 2020 13:21:17 +0000 (22:21 +0900)]
[ROSAPPS][MAN] Don't hardcode C: drive (#2780)
CORE-13235
He Yang [Wed, 13 May 2020 12:26:29 +0000 (20:26 +0800)]
[RAPPS] Corrections for Chinese Simplified dialog UI translation (#2781)
Yaroslav Kibysh [Wed, 13 May 2020 12:12:22 +0000 (15:12 +0300)]
[NOTEPAD] Update Ukrainian translation (#2775)
Yaroslav Kibysh [Wed, 13 May 2020 12:11:48 +0000 (15:11 +0300)]
[SYSSETUP] Update Ukrainian translation (#2776)
Katayama Hirofumi MZ [Wed, 13 May 2020 04:42:18 +0000 (13:42 +0900)]
[FTP] Don't hardcode C: drive (#2767)
CORE-13235
James Tabor [Wed, 13 May 2020 01:34:22 +0000 (20:34 -0500)]
[NtGDI] Add missing type for EPS Print Escape
Part of GDI escape printing.
James Tabor [Wed, 13 May 2020 01:26:02 +0000 (20:26 -0500)]
[PrintUI|NTPrint] Printing Application Utility Support
PrintUI : Move to printing base directory.
NTPrint : Import from wine.
NTPrint does have a API test program from wine, not imported at this
time.
These will be Sync/Ported to full forked.
Joachim Henze [Wed, 13 May 2020 00:39:37 +0000 (02:39 +0200)]
[MSAFD] Workaround regression CORE-15804
To fix 'MSTSC fails to connect with error "ERROR: Bad packet header"'
which regressed by 0.4.12-dev-752-g
6bc61f63f1e0ad20ab09f881d6968558eba9a8e6
In 0.4.12 and 0.4.13 releases I totally reverted
Pierre Schweitzer's work instead.
Thanks to Doug Lyons, author of this new workaround,
we can keep Pierre's work.
We think MSAFD is a better place to workaround than
our MSTSC binary, because our MSTSC runs fine on
W2K3SP2.
I will backport this new workaround also into 0.4.14RC.
Joachim Henze [Sun, 2 Jun 2019 12:23:18 +0000 (14:23 +0200)]
[UNIATA] Workaround regression CORE-16078, booting broke on specific Intel Z170
JIRA-user "Illen" reported booting from his Z170 controller worked up to
0.4.12-dev-936-g89aaf0e
and would refuse booting - beginning with uniata commit
0.4.12-dev-937-g
b54613073127f5204660d9e9ab86159fea06b23e
For sure this workaround is just a temporary and no proper solution,
but was confirmed to be working by "Illen".
We have no clear understanding of the real bug yet.
Can be replaced by something better at any time.
It was already committed into 0.4.12, 0.4.13, 0.4.14.
We never had an affected release therefore.
Since no one took care of this bug ever,
the workaround will now be committed to master as well.
cherry picked from commit 0.4.13-RC-9-g
11178f38e407a8d3621668295c2a28cd1ed9d7d1
Stanislav Motylkov [Sat, 9 May 2020 14:20:57 +0000 (17:20 +0300)]
[NTOSKRNL][HAL][BOOTVID] Some more code refactoring
- Add boot video color constants
- Refactor palette initialization
- Move some common stuff in right place
- Get rid of some magic constants and hardcoded values
- Get rid of TopDelta variable (calculated at compile time)
- Update SAL annotations
Addendum to
5f2ca473. CORE-16216 CORE-16219
Mark Jansen [Mon, 11 May 2020 18:52:30 +0000 (20:52 +0200)]
[FONTVIEW] Ensure the extension filter is properly double-null terminated
Piotr Hetnarowicz [Mon, 11 May 2020 07:06:33 +0000 (09:06 +0200)]
[BROWSEUI] PL-pl update
browseui.dll - PL-pl translation update :)
Piotr Hetnarowicz [Mon, 11 May 2020 08:01:17 +0000 (10:01 +0200)]
[MAIN.CPL] PL-pl update
MAIN.CPL - PL-pl
-dialogs fix
-strings update
Piotr Hetnarowicz [Mon, 11 May 2020 08:41:12 +0000 (10:41 +0200)]
[INTL.CPL] PL-pl update
intl.cpl - PL-pl update
-dialogs fix
-strings update
Katayama Hirofumi MZ [Mon, 11 May 2020 09:32:47 +0000 (18:32 +0900)]
[WIN32SS] Fix DrawTextExWorker extent for Spotify (#2759)
CORE-16747
Katayama Hirofumi MZ [Mon, 11 May 2020 02:43:07 +0000 (11:43 +0900)]
[SHELL32] Don't hardcode C: drive (#2768)
CORE-13235
Hermès Bélusca-Maïto [Mon, 11 May 2020 02:22:58 +0000 (04:22 +0200)]
[CMD] Quick fix for the REM command parser. CORE-17030
Eric Kohl [Sun, 10 May 2020 18:45:11 +0000 (20:45 +0200)]
[UMPNPMGR] Implement PNP_GetFirstLogConf and PNP_GetNextLogConf (WIP)
- PNP_GetFirstLogConf only works for resources lists.
- PNP_GetNextLogConf does not return a valid tag yet.
Dmitry Borisov [Sun, 10 May 2020 16:35:51 +0000 (22:35 +0600)]
[FREELDR] Add vertical screen scrolling for Xbox with console mode (#2745)
Also turn off debug messages to screen before setting up the CPU (To print a character to the screen on some ports the MMIO access should be executed, so it throws an exception).
CORE-16216
Kyle Katarn [Sun, 10 May 2020 16:22:13 +0000 (18:22 +0200)]
[SNDREC32] French translation update (#2761)
And add/fix colliding keyboard accelerators.
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
Eric Kohl [Sun, 10 May 2020 07:04:50 +0000 (09:04 +0200)]
[ARP] Print a message when there is no relevant entry to be shown
Kyle Katarn [Sun, 10 May 2020 06:34:35 +0000 (08:34 +0200)]
[WINNLS] Fix of GetCurrencyFormatW to handle "32" grouping format (#2719)
Eric Kohl [Sun, 10 May 2020 06:24:10 +0000 (08:24 +0200)]
[ARP] Coding style fixes only
Eric Kohl [Sat, 9 May 2020 22:46:42 +0000 (00:46 +0200)]
[ARP] Improvements to ARP
- Print message on failed memory allocations.
- Functions return error code instead of exit code.
- Convert error code to exit code in the main function only.
- Always free the allocated memory.
- Fix bug from previous commit: Use _tprintf instead _putts to print messages.
Hervé Poussineau [Sat, 9 May 2020 14:53:00 +0000 (16:53 +0200)]
[ISAPNP] Mark Read Data Port as not having a unique ID
This fixes a bugcheck in ntoskrnl.exe when computer has multiple ISA buses.
CORE-17034
Charles Ambrye [Sat, 9 May 2020 12:54:15 +0000 (05:54 -0700)]
[SHELL32] Return ERROR_INVALID_DRIVE if the drive type is unknown or there is no volume mounted (#2703)
Return ERROR_INVALID_DRIVE if the drive is either unknown or unmounted.
Jared Smudde [Sat, 9 May 2020 12:50:20 +0000 (07:50 -0500)]
[COMDLG32] Add some more places to the places bar in the open file dialog. (#2732)
Add Recent Documents and My Network Places to the places bar in the open file dialog.
NOTE: Technically this "places bar" can be customized:
https://www.tenforums.com/tutorials/126153-change-places-bar-items-common-dialog-box-windows.html
https://www.sevenforums.com/tutorials/85487-common-file-dialog-box-customize-places-bar.html
Kyle Katarn [Sat, 9 May 2020 12:37:26 +0000 (14:37 +0200)]
Fix of comdlg32 Treeview undue handling of WM_SYSKEYDOWN (#2731)
Remove WM_SYSKEYDOWN handling at component level, in consistency with other components (ListView,...)
Early embodiement of the fix proposed to WineHQ : https://bugs.winehq.org/show_bug.cgi?id=49097 in order to remove functionnal limitation in ReactOS. CORE-17020
Kyle Katarn [Sat, 9 May 2020 12:09:58 +0000 (14:09 +0200)]
[SNDREC32] Fix incorrect opaque text rendering (#2760)
Remove "Opaque" parameter so that the transparency can be correctly used.
Eric Kohl [Sat, 9 May 2020 10:28:40 +0000 (12:28 +0200)]
[ARP] Replace some hard-coded strings by message resources
Thomas Faber [Sat, 9 May 2020 09:11:49 +0000 (11:11 +0200)]
[RTLVER] Add missing bugcodes dependency.
Katayama Hirofumi MZ [Sat, 9 May 2020 08:55:37 +0000 (17:55 +0900)]
[RSAENH][MSXML3][OLE32] Revert PRIVATE commits (
cbe8a9f and
38b438b)
Katayama Hirofumi MZ [Sat, 9 May 2020 08:02:08 +0000 (17:02 +0900)]
[MSXML3][OLE32] DllGetClassObject should be PRIVATE
Katayama Hirofumi MZ [Sat, 9 May 2020 07:59:59 +0000 (16:59 +0900)]
[RSAENH] DllRegisterServer should be PRIVATE
Katayama Hirofumi MZ [Sat, 9 May 2020 06:32:15 +0000 (15:32 +0900)]
Revert "Revert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753)" (#2758)
This reverts commit
66b0a48a75d41fbc047d63df9b561e2c80626376.
Katayama Hirofumi MZ [Sat, 9 May 2020 02:30:11 +0000 (11:30 +0900)]
Revert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753)
This reverts commit
2d4d3f5fce0c875d3e714c51de16dfb0cd0a9cd3.
Reverts #2146. I think #2135 (
e329e83) and #2146 (
2d4d3f5) are my mistakes.
CORE-16552, CORE-16747
Stanislav Motylkov [Fri, 8 May 2020 20:02:42 +0000 (23:02 +0300)]
[FREELDR] Fix some more register accesses and magic values
Addendum to
764e884.
Hervé Poussineau [Fri, 8 May 2020 18:00:58 +0000 (20:00 +0200)]
[ISAPNP] Enable driver
George Bișoc [Thu, 7 May 2020 11:01:36 +0000 (13:01 +0200)]
[UTILMAN] Use the ShellAboutW API routine to display the about dialog (#2743)
In addition to that, add the missing function prototypes in the DLL dialog header of Utilman, add missing IN/OUT annotations and remove CheckUtilityState() prototype which is barely used (it's not implemented either).
Serge Gautherie [Thu, 7 May 2020 11:00:10 +0000 (13:00 +0200)]
[APISETS] api-ms-win-core-winrt-l1-1-0: Ro*() are NT8+ (#2739)
(Supersedes PR #2374.)
CORE-16707
Kyle Katarn [Thu, 7 May 2020 10:57:46 +0000 (12:57 +0200)]
[SYSDM][DESK] Fix GetDC/ReleaseDC error management (#2707)
## Purpose
[SYSDM]
- When closing System Properties page, log show
(win32ss/user/ntuser/windc.c:749) err: [
00060138] GetDC() without ReleaseDC()!
because GetDC() is called (multiple times) without properly calling ReleaseDC() as required in order to release a device context.
- This module also lacks some error management in case null DC are provided (on error).
- LiveCD Userinit, based on SYSDM is affected too.
[DESK]
- Fix missing ReleaseDC related to the spectrum (color depth)
## Proposed changes
- ReleaseDC() added.
- Error management in case of null DC.
- Overall alignement of LiveCD Userinit and SYSDM.
George Bișoc [Thu, 7 May 2020 10:39:44 +0000 (12:39 +0200)]
[CREDITS] Add myself to the credits document (#2747)
He Yang [Thu, 7 May 2020 09:08:08 +0000 (17:08 +0800)]
[RAPPS] 64bit compatibility fix (#2748)
Change SetWindowLongW to SetWindowLongPtrW.
It's the same (because the value is 0) but I think it's better.
Serge Gautherie [Thu, 7 May 2020 07:16:18 +0000 (09:16 +0200)]
[PCIIDEX] Increase command port length to 8 from 7. CORE-9922 (#2711)
Co-Authored-By: Vadim Galyant <vgal@rambler.ru>
Joachim Henze [Wed, 6 May 2020 21:44:50 +0000 (23:44 +0200)]
[FREELDR] Workaround regression CORE-16469
This prevents ReactOS asserting when 'My computer'
is opened, while it tries to send commands to floppy drive.
Many thanks to patches author Doug Lyons.
The regression was introduced by 0.4.13-dev-1081-g
eeff926ede1b2109bb0e129a960b74f3261cf2f1
patch was committed to 0.4.13rls and 0.4.14rls as well.
Today it was committed to master as well, as
the initially planned investigation for the root cause
did still not happen and we can not afford the time
to retest and workaround this over and over again.
Thank god that Oleg Dubinskiy was still around to retest
this again and confirmed it can still happen, because
unlike initially, personally I was not able to reproduce it
today anymore!
Since every release was work-arounded, we did never
expose the bug in any final release.
Alexander Rechitskiy [Wed, 6 May 2020 11:14:41 +0000 (14:14 +0300)]
[README] "Building ReactOS" belongs to "Building" part (#2741)
- Improved logic of the text
- Removed some line breaks to improve readability on some screen sizes
Alexander Rechitskiy [Wed, 6 May 2020 11:02:30 +0000 (14:02 +0300)]
[README] Update RosBE links and badges to version 2.2.0 (#2742)
https://reactos.org/project-news/rosbe-22-released/
Mark Jansen [Sun, 3 May 2020 18:18:30 +0000 (20:18 +0200)]
[USERINIT] Add unattend.inf functionality to livecd
Katayama Hirofumi MZ [Tue, 5 May 2020 15:35:01 +0000 (00:35 +0900)]
[SHELL32] Distinguish floppy and removable drives (#2645)
Distinguish floppy drive and non-floppy removable drive in icon and description. CORE-10221
Kyle Katarn [Tue, 5 May 2020 08:44:45 +0000 (10:44 +0200)]
[REGEDIT] Fix HeapFree() on the wrong variable (#2736)
- When exporting registry keys (to .reg files) some variables from the heap are not free'd while the debug log indicates "HEAP: Trying to free an invalid address".
- This is due to the export_registry_key() function that calls
HeapFree() for reg_key_name. But this variable is an argument provided by the caller, which is always a statically defined array of WCHAR.
- Meanwhile reg_key_name_buf is never free'd and cause a memory leak each time the function gets called.
Serge Gautherie [Tue, 5 May 2020 08:37:09 +0000 (10:37 +0200)]
[ADVAPI32] Remove now-redundant comment (#2735)
Addendum to
5dfe345.
Kyle Katarn [Mon, 4 May 2020 20:30:36 +0000 (22:30 +0200)]
[ADVAPI32] Fix undue debug print in nominal case (#2734)
In current implementation, when regedit opens HKCR root key, an error is logged
err:(dll/win32/advapi32/reg/hkcr.c:964) Returning 259.
This is not correct as the code 259 is ERROR_NO_MORE_ITEMS which is the nominal return value when end of enumeration is reached.
Serge Gautherie [Mon, 4 May 2020 20:26:38 +0000 (22:26 +0200)]
[APISETS] *_seh_filter_*() are NT6+ (#2729)
Addendum to
65fd292. CORE-16700
Adam Stachowicz [Mon, 4 May 2020 20:20:04 +0000 (22:20 +0200)]
[NETID] Update Polish translation (#2709)
Addendum to
c276681.
Victor Perevertkin [Sat, 25 Apr 2020 00:14:44 +0000 (03:14 +0300)]
[REACTOS] Drop support for Visual Studio below 2015
Victor Perevertkin [Sat, 25 Apr 2020 00:10:27 +0000 (03:10 +0300)]
[REACTOS] Raise C standard to gnu99
And remove -Wdeclaration-after-statement
Victor Perevertkin [Wed, 29 Apr 2020 09:07:50 +0000 (12:07 +0300)]
[GITHUB][TRAVIS][APPVEYOR] Move all CI to GitHub Actions
Victor Perevertkin [Mon, 4 May 2020 08:33:57 +0000 (11:33 +0300)]
[HTTPAPI] Convert httpapi.dll to a stub-only library
Wine's implementation relies on http.sys driver, which we don't have
anyway. Function declarations are taken from Wine 5.7
CORE-16963
Katayama Hirofumi MZ [Mon, 4 May 2020 07:22:38 +0000 (16:22 +0900)]
[SHELL32] Follow-up 2 of #2659
Add TODO comments.
Make CreateAPCThread static.
CORE-13950
Katayama Hirofumi MZ [Mon, 4 May 2020 06:28:16 +0000 (15:28 +0900)]
[SHELL32] Follow-up of #2659
Add CreateAPCThread function and use it. CORE-13950
Katayama Hirofumi MZ [Mon, 4 May 2020 05:53:23 +0000 (14:53 +0900)]
[SHELL32] Notify filesystem changes (#2659)
Notify filesystem change notifications by using ReadDirectoryChangesW function. Creating/Deleting files/folders will be responsive in Explorer. CORE-13950
Jared Smudde [Mon, 4 May 2020 03:53:35 +0000 (22:53 -0500)]
[SHELL32] Set the Run dialog to use the newer style browse for file dialog. (#2728)
Apply the OFN_EXPLORER flag to the Run dialog so the dialog uses the newer style browse dialog.
Mark Jansen [Sun, 3 May 2020 18:33:23 +0000 (20:33 +0200)]
[RAPPS] Fix the locale fix
Mark Jansen [Sun, 3 May 2020 16:33:06 +0000 (18:33 +0200)]
[RAPPS] Fix locale fallback code
Bișoc George [Fri, 1 May 2020 16:36:19 +0000 (18:36 +0200)]
[SDK][STDLIB][STRING] Wine-sync wcsrtombs_l and _mbstowcs_l
This is a partial sync of the CRT library with wcsrtombs_l and _mbstowcs_l functions from WINE. The _wctomb_s_l implementation of WINE which is used by _wctomb_s, _wctomb_l and wctomb brings failed results of the wctomb unit testcase and at the same time it crashes the whole testcase after.
Therefore I will not address the wctomb function for the moment being.
Piotr Hetnarowicz [Sun, 3 May 2020 13:30:04 +0000 (15:30 +0200)]
[WELCOME] pl-pl update (#2717)
welcome.exe pl-pl update
Kyle Katarn [Sun, 3 May 2020 10:16:45 +0000 (12:16 +0200)]
[SYSDM] Fix the missing TABSTOP style on Startup and Recovery dialog (#2722)
Now the OS choice and the debug info selection combo-boxes can be selected via keyboard navigation.
Stanislav Motylkov [Sat, 2 May 2020 20:18:34 +0000 (23:18 +0300)]
[XBOXVMP] Work with Xbox GPU registers properly
Bug was noticed with GCC 8.4
Stanislav Motylkov [Sat, 2 May 2020 20:16:58 +0000 (23:16 +0300)]
[FREELDR] Work with Xbox GPU memory registers properly
Bug was noticed with GCC 8.4
Adam Stachowicz [Sat, 2 May 2020 09:39:13 +0000 (09:39 +0000)]
[RAPPS] Polish translation
After https://github.com/reactos/reactos/commit/
fb1582d330116f9946e235d99b5384dd76b6fa79
Kyle Katarn [Sat, 2 May 2020 09:43:30 +0000 (11:43 +0200)]
[SNDVOL32] Fix GetDC/ReleaseDC error management (#2713)
GetDC() is called without properly calling ReleaseDC() as required in order to releases a device context. Similar to #2707
Katayama Hirofumi MZ [Sat, 2 May 2020 05:58:48 +0000 (14:58 +0900)]
[KERNEL32_APITEST] s/QueryUserAPC/QueueUseAPC/
Kyle Katarn [Fri, 1 May 2020 21:52:57 +0000 (23:52 +0200)]
[RAPPS] Add error messages on all download failure cases
- Implement error message for all failure condition of RAPPS Download
- Implement logging for failure conditions not needing user complementary awareness (cancellation)
- Support for localization
CORE-16851
Eric Kohl [Fri, 1 May 2020 20:34:01 +0000 (22:34 +0200)]
[NETID] Disable the 'Network ID' and 'Change' buttons and show the admin note when the current user is not an administrator
Eric Kohl [Fri, 1 May 2020 20:00:32 +0000 (22:00 +0200)]
[NETID] Fix a typo in NetworkDlg_OnOK
Eric Kohl [Fri, 1 May 2020 18:00:12 +0000 (20:00 +0200)]
[NETID] Fix the left margin on the Computer Name dialog
Eric Kohl [Fri, 1 May 2020 17:40:15 +0000 (19:40 +0200)]
[NETID] Improve the 'Computer name' property page
- Check for changes of the host and domain name.
- Use NetGetJoinInformation to retrieve the join status.
- Implement the SyncDomainWithMembership setting.
- Disable the administrator warning temporarily.
Kyle Katarn [Fri, 1 May 2020 17:01:59 +0000 (19:01 +0200)]
[SERVMAN] UI update and Error Management (#2653)
Purpose
=======
- Current design does not warn user nor logs DEBUG traces when Service Start/Stop command fails or reach timeout.
- Current Service Start/Stop progress window are WS_EX_TOOLWINDOW which reduce lisibility, is a ReactOS specificity without good reason.
Proposed changes
================
- DPRINT1 traces added on failure cases.
- Error Message box presented to user upon failure with explicit root cause identification.
- Change Dialog definition to standard window.
Sylvain Deverre [Fri, 1 May 2020 14:37:13 +0000 (16:37 +0200)]
[KDGDB] Fix GCC8 build
Bișoc George [Fri, 1 May 2020 14:01:11 +0000 (16:01 +0200)]
[CRT_APITEST] Implement wctomb() testcase (#2701)
Oleg Dubinskiy [Fri, 1 May 2020 13:57:11 +0000 (16:57 +0300)]
[WIN32SS][NTDDRAW] Get complexity of visible region in DxEngGetDCState (#2604)
CORE-7733
Get the complexity of visible region in the DxEngGetDCState() function, according to its remarks.
This implementation returns a number of rectangles that make up the region, similarly to as it done in REGION_Complexity() function:
https://git.reactos.org/?p=reactos.git;a=blob;f=win32ss/gdi/ntgdi/region.c;h=
38bf3d377fa805e9db8768774c4fc473590252d0;hb=HEAD#l573
It is required by MS ddraw.dll when calling win32k/dxg functions during launching DirectDraw test or any DirectX 1 - 7 apps/games.
Kyle Katarn [Fri, 1 May 2020 13:01:19 +0000 (15:01 +0200)]
[OLE32][WINESYNC] Fix Wine's implementation of IMalloc.DidAlloc based from Wine 5.7 (#2662)
CORE-15262
This fixes the exceptions raised when calling "Scan folder" a second time in SUMo 5.10.16.
The problem was reported to WineHQ : https://bugs.winehq.org/show_bug.cgi?id=48941
Import Wine commits by Nikolay Sivov, with the help of Doug Lyons:
- https://source.winehq.org/git/wine.git/commit/
08f4b6ee0a05fe27e56cb9777dce845dcf1072f8
ole32: Fix IMalloc::DidAlloc() return value to reflect block validity.
- https://source.winehq.org/git/wine.git/commit/
1e3bc9f3a61a197e794cca07a59c9497b237af62
ole32: Improve thread safety in DidAlloc().
- https://source.winehq.org/git/wine.git/commit/
06d36b1adf1ae7b73a200d6a35a143f6b3fd91c9
ole32: Fix spy callback arguments for IMalloc::GetSize().