reactos.git
3 months ago[UDFS] Fix accessing an already freed pointer in UDFMarkAllocatedAsNotXXX()
Victor Martinez [Sat, 17 Aug 2019 13:30:21 +0000 (16:30 +0300)]
[UDFS] Fix accessing an already freed pointer in UDFMarkAllocatedAsNotXXX()
CORE-11182

3 months ago[UDFS] Don't access OldInIcb after being freed
Victor Martinez [Sat, 17 Aug 2019 12:52:19 +0000 (15:52 +0300)]
[UDFS] Don't access OldInIcb after being freed
CORE-11199

3 months ago[DESK] Change the property "Screensaver" page on text change
Bișoc George [Sun, 4 Aug 2019 09:21:28 +0000 (11:21 +0200)]
[DESK] Change the property "Screensaver" page on text change

If the user takes action on the edit box control of "Screensaver" dialog page, enable the "Apply" property button.

CORE-16280

3 months ago[UDFS] Fix uninitialized variable
Victor Martinez [Sat, 17 Aug 2019 12:43:24 +0000 (15:43 +0300)]
[UDFS] Fix uninitialized variable
CORE-11216

3 months ago[COMCTL32] Unchange the property sheet page after WM_INITDIALOG (#1842)
Katayama Hirofumi MZ [Sat, 17 Aug 2019 11:02:57 +0000 (20:02 +0900)]
[COMCTL32] Unchange the property sheet page after WM_INITDIALOG (#1842)

In my testing on Win2k3, EN_CHANGE is generated in OnInitDialog, that is correct. The target is property sheet. The property sheet does unchange the page after WM_INITDIALOG generation. CORE-16280

3 months ago[COMCTL32] remove unused theme_*.c files.
Andreas Maier [Fri, 21 Jun 2019 09:58:07 +0000 (11:58 +0200)]
[COMCTL32] remove unused theme_*.c files.

3 months ago[RSYM] When determining the current function, always prefer COFF symbols if they... 1742/head
Thomas Faber [Sat, 20 Jul 2019 20:20:33 +0000 (22:20 +0200)]
[RSYM] When determining the current function, always prefer COFF symbols if they're closer.

3 months ago[FREELDR] Add missing VideoSetTextCursorPosition handler for Xbox
Stanislav Motylkov [Fri, 16 Aug 2019 23:36:17 +0000 (02:36 +0300)]
[FREELDR] Add missing VideoSetTextCursorPosition handler for Xbox

This fixes null pointer call bug, which was revealed in 85d44fc. Spotted by Mark Jansen. CORE-16216

Co-authored-by: Mark Jansen <mark.jansen@reactos.org>
3 months ago[TRANSLATION][NEWDEV] Complete Hebrew Translations for New Device Prompt
Shy Zedaka [Fri, 16 Aug 2019 13:16:41 +0000 (16:16 +0300)]
[TRANSLATION][NEWDEV] Complete Hebrew Translations for New Device Prompt

3 months ago[FREELDR] Add Serial ports detection in DetectIsaBios() (#1829)
Stanislav Motylkov [Fri, 16 Aug 2019 18:00:25 +0000 (21:00 +0300)]
[FREELDR] Add Serial ports detection in DetectIsaBios() (#1829)

CORE-16216

3 months ago[SDK] As sole author of the file, relicense it as LPGL
Pierre Schweitzer [Fri, 16 Aug 2019 17:54:44 +0000 (19:54 +0200)]
[SDK] As sole author of the file, relicense it as LPGL

It allows third party developers (such as Mark Harmstone :-)) to use it

3 months ago[USBOHCI_NEW] Fix unused variable
Victor Perevertkin [Fri, 16 Aug 2019 17:37:11 +0000 (20:37 +0300)]
[USBOHCI_NEW] Fix unused variable

3 months ago[CONSOLE] New Portuguese Translation 1788/head
Jose Carlos Jesus [Fri, 16 Aug 2019 16:47:08 +0000 (18:47 +0200)]
[CONSOLE] New Portuguese Translation

3 months ago[DESKMON] Update Portuguese Translation
Jose Carlos Jesus [Mon, 5 Aug 2019 23:20:18 +0000 (00:20 +0100)]
[DESKMON] Update Portuguese Translation

3 months ago[DESK] New Portuguese translation
Jose Carlos Jesus [Mon, 5 Aug 2019 23:14:11 +0000 (00:14 +0100)]
[DESK] New Portuguese translation

3 months ago[SHELL][COMCTL32] pt_PT_Translation Improvements
Jose Carlos Jesus [Sat, 3 Aug 2019 16:55:09 +0000 (17:55 +0100)]
[SHELL][COMCTL32] pt_PT_Translation Improvements

3 months ago[HDWWIZ] New pt_PT_Translation
Jose Carlos Jesus [Sat, 3 Aug 2019 16:52:05 +0000 (17:52 +0100)]
[HDWWIZ] New pt_PT_Translation

3 months ago[FREELDR] Add PCI BIOS emulation and PCI bus enumeration for Xbox (#1830)
Stanislav Motylkov [Fri, 16 Aug 2019 17:14:10 +0000 (20:14 +0300)]
[FREELDR] Add PCI BIOS emulation and PCI bus enumeration for Xbox (#1830)

CORE-16216 CORE-16308

3 months ago[AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv (#1826)
Oleg Dubinskiy [Fri, 16 Aug 2019 17:11:04 +0000 (20:11 +0300)]
[AUDIOSRV][BOOTDATA][INCLUDE][MMSYS] Rename RosAudioSrv to AudioSrv (#1826)

Rename RosAudioSrv to AudioSrv in audio service itself and in all system components which are related to this, same as it done in Win2k3.
It allows MS DxDiag to detect the system audio service correctly, so it becomes possible to run DirectSound test properly with MS dsound.dll, although it works with some minor errors and only in older VirtualBox versions, ~ up to 5.1.38 (and in other emulators as well).

CORE-16307

3 months ago[USBOHCI_NEW] Refactor OHCI_AbortTransfer function
Stanislav Motylkov [Thu, 27 Jun 2019 23:38:10 +0000 (02:38 +0300)]
[USBOHCI_NEW] Refactor OHCI_AbortTransfer function

- Added SAL annotation
- Simplified local variables
- Replace counterintuitive `do {} while ()` loops with nice `for` loops
- Get rid of goto and its label, it can be simply avoided

3 months ago[COMCTL32] Export LoadIconMetric and LoadIconWithScaleDown 1064/head
Andrew Boyarshin [Sun, 25 Nov 2018 06:47:11 +0000 (13:47 +0700)]
[COMCTL32] Export LoadIconMetric and LoadIconWithScaleDown

They are already implemented and there is little sense for them to be hidden.
Required for ProcessHacker 3.0+.

3 months ago[HAL] Add Xbox Hardware Abstraction Layer
Stanislav Motylkov [Mon, 12 Aug 2019 09:23:25 +0000 (12:23 +0300)]
[HAL] Add Xbox Hardware Abstraction Layer

- Create xbox.cmake based on legacy.cmake and pic.cmake
- Revive Xbox HAL files and add them to the build
- Fix boot with Xbox HAL, add missing parts from halinit_up.c
- Code style and debug logging improvements in pcibus.c
- Allow to choose Xbox HAL in usetup

CORE-16216

3 months ago[JSCRIPT] import wine commits "stub + implement Enumerator()"
Andreas Maier [Fri, 19 Apr 2019 19:00:27 +0000 (21:00 +0200)]
[JSCRIPT] import wine commits "stub + implement Enumerator()"

https://source.winehq.org/git/wine.git/commit/6630bc4096870d1586e6d431b93dd74eb7ce017d
https://source.winehq.org/git/wine.git/commit/a015c626438dc8cba445242c68d4175f381b2128

CORE-13810

3 months ago[W32TIME] The interval is specified in seconds, but we need milliseconds
Mark Jansen [Fri, 16 Aug 2019 14:29:20 +0000 (16:29 +0200)]
[W32TIME] The interval is specified in seconds, but we need milliseconds

3 months ago[COMCTL32] Checking size grip bounds in x-axis only
Waritnan Sookbuntherng [Tue, 11 Dec 2018 15:25:16 +0000 (22:25 +0700)]
[COMCTL32] Checking size grip bounds in x-axis only

3 months ago[COMCTL32] Hide size grip when the parent window is maximized
Waritnan Sookbuntherng [Tue, 11 Dec 2018 15:22:47 +0000 (22:22 +0700)]
[COMCTL32] Hide size grip when the parent window is maximized

3 months ago[NETSTAT] '-p UDP' depends on '-a'
Serge Gautherie [Sat, 29 Jun 2019 13:14:39 +0000 (15:14 +0200)]
[NETSTAT] '-p UDP' depends on '-a'

3 months ago[NTFS] Correctly find attributes stored in another file record in MFT (and referenced...
Sylvain Deverre [Thu, 8 Aug 2019 20:09:13 +0000 (22:09 +0200)]
[NTFS] Correctly find attributes stored in another file record in MFT (and referenced in data stream)

3 months agoRevert "[WININET_APITEST] Add Download testcase (#1832)" (#1839)
Katayama Hirofumi MZ [Fri, 16 Aug 2019 08:01:03 +0000 (17:01 +0900)]
Revert "[WININET_APITEST] Add Download testcase (#1832)" (#1839)

This reverts commit 7464241adabfbdfec5a058697632a8d3938479fb.

3 months ago[ROSAPPS][NETREG] Fix build
Katayama Hirofumi MZ [Fri, 16 Aug 2019 07:57:40 +0000 (16:57 +0900)]
[ROSAPPS][NETREG] Fix build

3 months agoUpdate Headers for Printing and Other
James Tabor [Fri, 16 Aug 2019 02:39:26 +0000 (21:39 -0500)]
Update Headers for Printing and Other

Add missing flags and function types. Fix typos.

3 months ago[COMCTL32] Saturated images: Take mask-images in account.
Andreas Maier [Sat, 1 Jun 2019 17:09:44 +0000 (19:09 +0200)]
[COMCTL32] Saturated images: Take mask-images in account.

This fixes CORE-14209 - Some icons not drawn in IDA Free

3 months ago[COMCTL32] Improve failure cases.
Andreas Maier [Fri, 31 May 2019 08:15:06 +0000 (10:15 +0200)]
[COMCTL32] Improve failure cases.

3 months ago[NDIS] Enforce '#if DBG' around MiniDisplayPacket[2]()
Serge Gautherie [Sat, 8 Jun 2019 01:03:40 +0000 (03:03 +0200)]
[NDIS] Enforce '#if DBG' around MiniDisplayPacket[2]()

Also add 'static' on MiniDisplayPacket2().

3 months ago[OSK] General refactoring
Bișoc George [Tue, 16 Jul 2019 15:35:30 +0000 (17:35 +0200)]
[OSK] General refactoring

- Replace the existing header files in favour to a pre-compiled header instead. Furthermore, move all the function prototypes in the pre-compiled header.
- As per the prototype definitions, LoadDataFromRegistry() and SaveDataToRegistry() mustn't accept any number of parameters.
- Rename rsrc.rc to osk.rc (main resource file) as most of user-mode applications name have their main resource as the same application's name anyways.
- When querying and saving the data to registry, use only one value, greatly reducing the bloat of variables (as per the Hermes Belusca's request on #1729 PR).
- Update the header description reflecting the official ReactOS Coding style guidelines.

3 months ago[THEMES][LUNAR] Update
Adam Słaboń [Sat, 13 Jul 2019 15:29:46 +0000 (17:29 +0200)]
[THEMES][LUNAR] Update

Improved Button and Combo Button bitmaps, fixed SYSSETUP Lunar resource.

3 months ago[SHELL32] Run Dialog Text Fix
Shy Zedaka [Sun, 4 Aug 2019 20:54:51 +0000 (23:54 +0300)]
[SHELL32] Run Dialog Text Fix

3 months ago[TASKMGR] Implement proper process tree ending
Paweł Cholewa [Thu, 15 Aug 2019 17:07:05 +0000 (19:07 +0200)]
[TASKMGR] Implement proper process tree ending

 * Implement ShutdownProcessTree in endproc.c which recursively kills process trees
 * Include tlhelp32.h in precomp.h
 * Check if the child process can be shut down

3 months ago[NTOSKRNL] Move DPRINT1("Thread wants too much stack\n") around
Serge Gautherie [Thu, 25 Apr 2019 01:22:16 +0000 (03:22 +0200)]
[NTOSKRNL] Move DPRINT1("Thread wants too much stack\n") around

To KiUserModeCallout() from MmGrowKernelStackEx().

As suggested by Thomas Faber:
"MmGrowKernelStackEx really shouldn't be DPRINT'ing."

CORE-14494

3 months ago[FREELDR] Improve debug output
Timo Kreuzer [Sat, 27 Jul 2019 07:58:38 +0000 (09:58 +0200)]
[FREELDR] Improve debug output

3 months ago[NTOS:MM] MmSizeOfSystemCacheInPages is ULONG_PTR, not ULONG
Timo Kreuzer [Sat, 27 Jul 2019 07:32:29 +0000 (09:32 +0200)]
[NTOS:MM] MmSizeOfSystemCacheInPages is ULONG_PTR, not ULONG

Fixes failed assertion on x64.

3 months ago[NTOS:KE:I386] Fix parameter description for KiSwapContext
Timo Kreuzer [Thu, 27 Jun 2019 16:05:55 +0000 (18:05 +0200)]
[NTOS:KE:I386] Fix parameter description for KiSwapContext

3 months ago[NTOS:IO] In IopSynchronousCall first check IrpStack->MajorFunction before checking...
Timo Kreuzer [Sun, 2 Jun 2019 07:45:45 +0000 (09:45 +0200)]
[NTOS:IO] In IopSynchronousCall first check IrpStack->MajorFunction before checking minor

Minor function indices are not unique, they are subfunctions, so without first checking the major function, they are ambiguous.

3 months ago[BROWSEUI] Try to "fix" IEThreadParamBlock structure for x64
Timo Kreuzer [Sat, 1 Jun 2019 12:42:14 +0000 (14:42 +0200)]
[BROWSEUI] Try to "fix" IEThreadParamBlock structure for x64

3 months ago[PSDK] dbghelp.h: Fix 64 bit version of LOADED_IMAGE
Timo Kreuzer [Mon, 22 Apr 2019 11:03:24 +0000 (13:03 +0200)]
[PSDK] dbghelp.h: Fix 64 bit version of LOADED_IMAGE

3 months ago[TDI] Improve spec file
Timo Kreuzer [Mon, 20 Aug 2018 15:11:40 +0000 (17:11 +0200)]
[TDI] Improve spec file

3 months ago[PSDK] Fix #ifdef in winuser.h
Timo Kreuzer [Mon, 20 Aug 2018 14:02:44 +0000 (16:02 +0200)]
[PSDK] Fix #ifdef in winuser.h

3 months ago[VIDEOPRT] Fix order of some exports
Timo Kreuzer [Thu, 12 Jul 2018 11:23:04 +0000 (13:23 +0200)]
[VIDEOPRT] Fix order of some exports

3 months ago[NTOS:EX] Use InterlockedExchangeAdd64 instead of InterlockedCompareExchange64 loop...
Timo Kreuzer [Thu, 12 Jul 2018 13:54:52 +0000 (15:54 +0200)]
[NTOS:EX] Use InterlockedExchangeAdd64 instead of InterlockedCompareExchange64 loop in ExAllocateLocallyUniqueId

3 months ago[WIN32K] InitVideo() should return NTSTATUS, so return STATUS_SUCCESS instead of 1
Timo Kreuzer [Sun, 11 Feb 2018 20:53:03 +0000 (21:53 +0100)]
[WIN32K] InitVideo() should return NTSTATUS, so return STATUS_SUCCESS instead of 1

3 months ago[NTOS:IO] Improve an alignment
Timo Kreuzer [Thu, 4 Jan 2018 17:29:24 +0000 (18:29 +0100)]
[NTOS:IO] Improve an alignment

3 months ago[KSUSER] Improve pointer arithmetics
Timo Kreuzer [Thu, 28 Dec 2017 17:35:30 +0000 (18:35 +0100)]
[KSUSER] Improve pointer arithmetics

3 months ago[SHELL32] Fix Desktop Properties menu item action (#1833)
Katayama Hirofumi MZ [Thu, 15 Aug 2019 14:10:06 +0000 (23:10 +0900)]
[SHELL32] Fix Desktop Properties menu item action (#1833)

1. Right Click the Desktop.
2. Choose "Properties" menu item.
3. "Properties for Display" dialog must be shown.

The parameters of ShellExecuteW were wrong. The execution parameters must be separated from the file parameter.
CORE-16299

3 months ago[KERNEL32] implement CreateSemaphoreExW/A and adjust macroses for it
Denis Malikov [Sun, 18 Nov 2018 16:51:20 +0000 (23:51 +0700)]
[KERNEL32] implement CreateSemaphoreExW/A and adjust macroses for it

3 months ago[KERNEL32] Partially fix dll/win32/kernel32/client/vista.c compilation as NT6
Serge Gautherie [Thu, 15 Aug 2019 13:42:34 +0000 (15:42 +0200)]
[KERNEL32] Partially fix dll/win32/kernel32/client/vista.c compilation as NT6

CORE-12596

3 months ago[3RDPARTY] Suppress MSVC printf format warnings in 3rd-party code
Timo Kreuzer [Sat, 20 Jul 2019 15:34:24 +0000 (17:34 +0200)]
[3RDPARTY] Suppress MSVC printf format warnings in 3rd-party code

3 months ago[REACTOS] Fix MSVC printf format warnings
Timo Kreuzer [Mon, 20 Aug 2018 15:42:27 +0000 (17:42 +0200)]
[REACTOS] Fix MSVC printf format warnings

3 months ago[DBGHELP_APITEST] Add rsym+pdb tests on loaded modules 1445/head
Mark Jansen [Wed, 27 Mar 2019 22:09:36 +0000 (23:09 +0100)]
[DBGHELP_APITEST] Add rsym+pdb tests on loaded modules
Also reorder some stuff to make the tests more alike

3 months ago[REACTOS] Fix SIZE_T related warnings
Timo Kreuzer [Sun, 26 May 2019 13:00:21 +0000 (15:00 +0200)]
[REACTOS] Fix SIZE_T related warnings

3 months ago[VIDEOPRT] Implement support for INT10 on x64 using the newly implemented HAL functions.
Timo Kreuzer [Sun, 11 Feb 2018 18:22:30 +0000 (19:22 +0100)]
[VIDEOPRT] Implement support for INT10 on x64 using the newly implemented HAL functions.

3 months ago[VIDEOPRT] Fixes for x64
Timo Kreuzer [Sun, 11 Feb 2018 13:01:43 +0000 (14:01 +0100)]
[VIDEOPRT] Fixes for x64

3 months ago[VIDEOPRT] Call IntInt10CallBios from VideoPortInt10, instead of code duplication
Timo Kreuzer [Sun, 11 Feb 2018 12:49:14 +0000 (13:49 +0100)]
[VIDEOPRT] Call IntInt10CallBios from VideoPortInt10, instead of code duplication

3 months ago[VIDEOPRT] [FORMATTING] No code change
Timo Kreuzer [Sun, 11 Feb 2018 12:43:05 +0000 (13:43 +0100)]
[VIDEOPRT] [FORMATTING] No code change

3 months ago[HAL] Implement amd64 BIOS call support
Timo Kreuzer [Sun, 11 Feb 2018 18:21:01 +0000 (19:21 +0100)]
[HAL] Implement amd64 BIOS call support

The code uses FAST486 to emulate the BIOS code.

3 months ago[NDK] Add BIOS call API for amd64
Timo Kreuzer [Sun, 11 Feb 2018 15:43:51 +0000 (16:43 +0100)]
[NDK] Add BIOS call API for amd64

3 months ago[Translation] More Hebrew Translations
Shy Zedaka [Mon, 5 Aug 2019 21:01:24 +0000 (00:01 +0300)]
[Translation] More Hebrew Translations

Co-authored-by: Baruch Rutman <peterooch@gmail.com>
3 months ago[NTOSKRNL][PS] Implement NtQueueApcThreadEx and use it in NtQueueApcThread
Andrew Boyarshin [Sun, 25 Nov 2018 07:11:04 +0000 (14:11 +0700)]
[NTOSKRNL][PS] Implement NtQueueApcThreadEx and use it in NtQueueApcThread

Actually rename NtQueueApcThread to NtQueueApcThreadEx and ignore one additional parameter for now.

3 months ago[SHELL32] CDefView: Improve the context menu positioning 1817/head
Mark Jansen [Thu, 8 Aug 2019 19:01:19 +0000 (21:01 +0200)]
[SHELL32] CDefView: Improve the context menu positioning
Previously we would always show a menu on the focused item, but
this should only be done when it is also selected.

3 months ago[WININET_APITEST] Add Download testcase (#1832)
Katayama Hirofumi MZ [Thu, 15 Aug 2019 08:50:57 +0000 (17:50 +0900)]
[WININET_APITEST] Add Download testcase (#1832)

CORE-16310

3 months ago[MEDIA][FONTS] Add Baltic MS Sans Serif (ssee1257.fon) CORE-16166
Katayama Hirofumi MZ [Thu, 15 Aug 2019 01:23:50 +0000 (10:23 +0900)]
[MEDIA][FONTS] Add Baltic MS Sans Serif (ssee1257.fon) CORE-16166

3 months ago[FREELDR] Minor fixes.
Hermès Bélusca-Maïto [Wed, 14 Aug 2019 13:59:01 +0000 (15:59 +0200)]
[FREELDR] Minor fixes.

- Add some forgotten, or move some misplaced ArcClose() calls so as
  to avoid leakages in failure paths. (Thanks to Serge Gautherie for
  having caught some of them.)

- Simplify some code; remove unneeded casts; use string-safe functions.

3 months ago[FREELDR] Minor enhancements for disk/partition boot and UI.
Hermès Bélusca-Maïto [Tue, 13 Aug 2019 15:34:57 +0000 (17:34 +0200)]
[FREELDR] Minor enhancements for disk/partition boot and UI.

- Factor out disk & partition opening in LoadAndBootPartition() and
  LoadAndBootDrive() into a LoadAndBootPartitionOrDrive() helper.

- Use ARC paths and ArcOpen()/ArcRead() instead of calling the
  machine-specific BIOS-oriented DiskGetPartitionEntry() and
  MachDiskReadLogicalSectors() functions to open the disk/partition
  and read their boot sectors.

- Don't forget to close the opened boot sector file in LoadAndBootBootSector().

- Add assertions for DiskReadBufferSize in PcMemFinalizeMemoryMap()
  and EnumerateHarddisks().

- x86/amd64 only:
  * Add a DisableA20 helper for disabling the A20 line, before rebooting
    back, or chain-load a boot sector, into 16-bit world.
    Also pulse the output port of the keyboard controller to clear out
    its state after having set the state of the A20 line.

  * In addition to disabling the A20 line when rebooting or chain-loading
    a boot sector, reset the video back to 80x25 text mode.

- Reset the cursor position back to the origin when initializing or
  terminating the TUI.

3 months ago[OSK] Romanian translation update (#1820)
Bișoc George [Mon, 12 Aug 2019 18:58:39 +0000 (20:58 +0200)]
[OSK] Romanian translation update (#1820)

3 months ago[ATL_APITEST] Simplify code by using ok_int etc. (#1824)
Katayama Hirofumi MZ [Mon, 12 Aug 2019 14:10:47 +0000 (23:10 +0900)]
[ATL_APITEST] Simplify code by using ok_int etc. (#1824)

Simplify the code by using ok_int, ok_long etc.

3 months ago[MEDIA][FONTS] Total adjustment of MS Sans Serif
Katayama Hirofumi MZ [Mon, 12 Aug 2019 13:19:55 +0000 (22:19 +0900)]
[MEDIA][FONTS] Total adjustment of MS Sans Serif

3 months ago[SDK][INCLUDE] Update msgdump.h and winxx.h
Katayama Hirofumi MZ [Mon, 12 Aug 2019 10:31:44 +0000 (19:31 +0900)]
[SDK][INCLUDE] Update msgdump.h and winxx.h

3 months ago[ATL_APITEST] Add 'atltest.h' and use it (#1822)
Katayama Hirofumi MZ [Mon, 12 Aug 2019 10:24:08 +0000 (19:24 +0900)]
[ATL_APITEST] Add 'atltest.h' and use it (#1822)

- Add "atltest.h" header file for common use in atl_apitest.
- Delete the duplicated and simplify.

3 months ago[ATL] Add a minimal CAtlArray implementation 1819/head
Mark Jansen [Fri, 9 Aug 2019 22:22:03 +0000 (00:22 +0200)]
[ATL] Add a minimal CAtlArray implementation

3 months ago[ATL_APITEST] Add simple test for CAtlArray
Mark Jansen [Fri, 9 Aug 2019 19:25:16 +0000 (21:25 +0200)]
[ATL_APITEST] Add simple test for CAtlArray

3 months ago[ATL_APITEST] Change proj files to have a different intermediate dir
Mark Jansen [Fri, 9 Aug 2019 19:24:33 +0000 (21:24 +0200)]
[ATL_APITEST] Change proj files to have a different intermediate dir

3 months ago[ATL][ATL_APITEST] Add CAtlList::InsertBefore/After + test
Mark Jansen [Fri, 9 Aug 2019 17:14:43 +0000 (19:14 +0200)]
[ATL][ATL_APITEST] Add CAtlList::InsertBefore/After + test

3 months agoAddendum to fba4ad4c.
Hermès Bélusca-Maïto [Sun, 11 Aug 2019 20:06:27 +0000 (22:06 +0200)]
Addendum to fba4ad4c.

3 months ago[FREELDR] Move files where they are only used.
Hermès Bélusca-Maïto [Sun, 11 Aug 2019 16:56:40 +0000 (18:56 +0200)]
[FREELDR] Move files where they are only used.

- Merge fade.c/palette.c/video.c into video.c and move it into UI.
- Move inffile.c into NTLDR.

3 months ago[MEDIA][FONTS] Add Arabic MS Sans Serif (ssee1256.fon)
Katayama Hirofumi MZ [Sun, 11 Aug 2019 00:36:39 +0000 (09:36 +0900)]
[MEDIA][FONTS] Add Arabic MS Sans Serif (ssee1256.fon)

CORE-16166

3 months ago[WIN32SS][NTUSER] Fix menu drawing after style change (#1821)
Katayama Hirofumi MZ [Sat, 10 Aug 2019 22:46:14 +0000 (07:46 +0900)]
[WIN32SS][NTUSER] Fix menu drawing after style change (#1821)

There were menu drawing regression after https://github.com/reactos/reactos/commit/03adec81414abb53e589ecd9061042b9ca2104c1.
This PR will fix it. CORE-16244

- We don't have to draw the frame manually because of WS_EX_DLGMODALFRAME extended style.
- We don't need the margins (MENU_TOP_MARGIN and MENU_BOTTOM_MARGIN) in the client area any more because the client area doesn't contain the frame width.
- Use GetSystemMetrics(SM_CXDLGFRAME) and GetSystemMetrics(SM_CYDLGFRAME) for frame width.

3 months ago[FREELDR] Addendum to 31a3f317.
Hermès Bélusca-Maïto [Sat, 10 Aug 2019 17:47:49 +0000 (19:47 +0200)]
[FREELDR] Addendum to 31a3f317.

3 months ago[PROCESSR] Employ usual casing for CurrentControlSet key.
Hermès Bélusca-Maïto [Sat, 10 Aug 2019 17:14:04 +0000 (19:14 +0200)]
[PROCESSR] Employ usual casing for CurrentControlSet key.

3 months ago[FREELDR] Some changes that accumulated since years in my local copy. Also initialize...
Hermès Bélusca-Maïto [Sat, 10 Aug 2019 17:13:20 +0000 (19:13 +0200)]
[FREELDR] Some changes that accumulated since years in my local copy. Also initialize SetupBlock->ArcSetupDeviceName to some valid value.

3 months ago[FREELDR] Rework EXT2 filesystem to interface with ARC and not be tied to the boot...
Hermès Bélusca-Maïto [Sat, 10 Aug 2019 14:36:11 +0000 (16:36 +0200)]
[FREELDR] Rework EXT2 filesystem to interface with ARC and not be tied to the boot volume.

See 28bf1f3b (r42537) and c599bd7d (r43267) for additional information.

3 months ago[FREELDR] Diverse enhancements.
Hermès Bélusca-Maïto [Sat, 10 Aug 2019 11:44:33 +0000 (13:44 +0200)]
[FREELDR] Diverse enhancements.

- Get rid of the FsCloseFile(), FsReadFile(), FsGetFileInformation(),
  FsGetFileSize() and FsSetFilePointer() wrappers and use the ARC
  functions directly instead. Make FsOpenFile() return an ARC file
  descriptor ID of the correct type. Get rid of unused FS_* defines.

- Use TRACEs in the ***Mount() filesystem functions for diagnostics
  purposes.

- Remove a leak in FatGetFatEntry(). Assign stuff via QuadPart where
  possible in FatMount(). Remove an unused member in FAT_FILE_INFO.

- Reduce code indentation in BtrFsMount() and remove a leak there.

- Disable reading the "BootPath" parameter in the linux loader since
  we don't use this parameter (yet??)

3 months ago[LSASS] Initialize SAM before starting the security services
Eric Kohl [Sat, 10 Aug 2019 12:36:10 +0000 (14:36 +0200)]
[LSASS] Initialize SAM before starting the security services

We need to initialize SAM before the security services get started, otherwise we will have a running SamSs service although SAM is not initialized at that time. This is no good.

3 months ago[SERVICES] Improvements to registry control sets
Eric Kohl [Sat, 10 Aug 2019 12:24:11 +0000 (14:24 +0200)]
[SERVICES] Improvements to registry control sets

- Add a function that creates a new control set and deletes unused control sets in case of a successful boot.
- Add a stub function that will soon switch to the last known good control set in case of an unsuccessful boot.

3 months ago[IDL][WINLOGON] Rename locally used functions of the winreg rpc interface
Eric Kohl [Sat, 10 Aug 2019 12:04:58 +0000 (14:04 +0200)]
[IDL][WINLOGON] Rename locally used functions of the winreg rpc interface

- Function 14 is named BaseRegNotifyChangeKeyValue
- Function 28 is named OpenDynData

3 months ago[WIN32SS][NTUSER] Fix popup menu freezing
Katayama Hirofumi MZ [Sat, 10 Aug 2019 06:40:32 +0000 (15:40 +0900)]
[WIN32SS][NTUSER] Fix popup menu freezing

3 months ago[WIN32SS][NTGDI] Registry-based font management (#1816)
Katayama Hirofumi MZ [Sat, 10 Aug 2019 05:52:09 +0000 (14:52 +0900)]
[WIN32SS][NTGDI] Registry-based font management (#1816)

CORE-16269
- Add IntGdiAddFontResourceEx function that is extended from IntGdiAddFontResource, in order to add dwFlags parameter.
- Add IntLoadFontsInRegistry function that will load the fonts from registry info.
- If loading from registry failed, IntLoadSystemFonts will be called.
- Use IntLoadFontsInRegistry rather than IntLoadSystemFonts in the OS startup.
- Add NameFromCharSet function.
- Append " (CharSetName)" to registry value name if not TrueType.

3 months ago[WIN32SS][NTUSER] Fix popup menu window styles (#1814)
Katayama Hirofumi MZ [Fri, 9 Aug 2019 23:33:25 +0000 (08:33 +0900)]
[WIN32SS][NTUSER] Fix popup menu window styles (#1814)

Fix the class style, the window style and the extended style of the popup menu window. CORE-16244

3 months ago[FREELDR] Fix erroneous change from d05be0da regarding RAMDISK loading in SETUPLDR.
Hermès Bélusca-Maïto [Thu, 8 Aug 2019 21:06:33 +0000 (23:06 +0200)]
[FREELDR] Fix erroneous change from d05be0da regarding RAMDISK loading in SETUPLDR.

Restore the correct position of (optional) RAMDISK loading code, before
attempting to open txtsetup.sif since the bootcd ISO might be the RAMDISK.

3 months ago[WIN32SS] Ensure the last menu item is not accidentally selected when a system menu... 1812/head
Mark Jansen [Wed, 7 Aug 2019 21:53:42 +0000 (23:53 +0200)]
[WIN32SS] Ensure the last menu item is not accidentally selected when a system menu is off-screen
CORE-16297

3 months ago[WIN32SS] Do not propagate TPM_VERTICAL to sub-menus
Mark Jansen [Wed, 7 Aug 2019 20:14:58 +0000 (22:14 +0200)]
[WIN32SS] Do not propagate TPM_VERTICAL to sub-menus
With this change we can remove the workaround from the off-screen
menus dropping below their parent.
Many thanks to Joachim for his help debugging / testing this.

CORE-16297

3 months ago[WIN32SS] Fix tray popup menus stuck to the bottom of the screen
Mark Jansen [Wed, 7 Aug 2019 19:50:25 +0000 (21:50 +0200)]
[WIN32SS] Fix tray popup menus stuck to the bottom of the screen
Dedicated to Joachim
CORE-16297