14 years agoAdd a testing suite for CMD based on CMD scripts.
Colin Finck [Sat, 17 May 2008 20:01:21 +0000 (20:01 +0000)]
Add a testing suite for CMD based on CMD scripts.
Of course, ReactOS' cmd doesn't work at all with the framework at the moment :-)

Some tests were taken from "seta_test.cmd" by Royce. (see file headers)

svn path=/trunk/; revision=33560

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Sat, 17 May 2008 19:46:54 +0000 (19:46 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=33559

14 years agoAutosyncing with Wine HEAD
The Wine Synchronizer [Sat, 17 May 2008 19:46:01 +0000 (19:46 +0000)]
Autosyncing with Wine HEAD

svn path=/trunk/; revision=33558

14 years agoAdd code to create, delete and rename user groups.
Eric Kohl [Sat, 17 May 2008 16:06:54 +0000 (16:06 +0000)]
Add code to create, delete and rename user groups.

svn path=/trunk/; revision=33557

14 years ago-make rbuild files XML compliant by adding the XInclude namespace
Marc Piulachs [Sat, 17 May 2008 15:44:47 +0000 (15:44 +0000)]
-make rbuild files XML compliant by adding the XInclude namespace
-sync winetest to WINE-rc1
-add a rbuild file for winetest (not added to build yet)
note: minor winetest modifications should be made like loading tests from a folder at startup

svn path=/trunk/; revision=33556

14 years agoLimit the maximum user name length to 20 characters when a user name is changed from...
Eric Kohl [Sat, 17 May 2008 15:19:01 +0000 (15:19 +0000)]
Limit the maximum user name length to 20 characters when a user name is changed from within the users list.

svn path=/trunk/; revision=33555

14 years agoNew user dialog: Implement user options properly.
Eric Kohl [Sat, 17 May 2008 14:00:39 +0000 (14:00 +0000)]
New user dialog: Implement user options properly.

svn path=/trunk/; revision=33554

14 years agoAdd DCE pointer to window class. Start support for real Class DCEs.
James Tabor [Sat, 17 May 2008 11:55:24 +0000 (11:55 +0000)]
Add DCE pointer to window class. Start support for real Class DCEs.

svn path=/trunk/; revision=33553

14 years agoSynced urlmon.dll with Wine HEAD.
Pierre Schweitzer [Sat, 17 May 2008 10:36:13 +0000 (10:36 +0000)]
Synced urlmon.dll with Wine HEAD.
This *does not* fix Downloader, but it now returns an error message.

svn path=/trunk/; revision=33552

14 years agoAdd ROS_BUILDENGINE variable to determine the location of rbuild
Marc Piulachs [Sat, 17 May 2008 09:56:15 +0000 (09:56 +0000)]
Add ROS_BUILDENGINE variable to determine the location of rbuild
- Allows using an rbuild executable other than the one found in the same source tree (tools\rbuild)

svn path=/trunk/; revision=33551

14 years agoAdd fusion.idl from Wine
Hervé Poussineau [Sat, 17 May 2008 09:53:01 +0000 (09:53 +0000)]
Add fusion.idl from Wine

svn path=/trunk/; revision=33550

14 years agoLimit introduction string to 256 letters (no more, not less)
Pierre Schweitzer [Sat, 17 May 2008 09:45:13 +0000 (09:45 +0000)]
Limit introduction string to 256 letters (no more, not less)

svn path=/trunk/; revision=33549

14 years agoMake 100% sure that the correct "regedit.exe" is launched by using GetWindowsDirector...
Colin Finck [Sat, 17 May 2008 09:39:36 +0000 (09:39 +0000)]
Make 100% sure that the correct "regedit.exe" is launched by using GetWindowsDirectory and appending "\regedit.exe" as suggested by Alex on ros-dev.

svn path=/trunk/; revision=33547

14 years agoRevert the _T('x') to 'x' changes from my previous commit.
Colin Finck [Sat, 17 May 2008 09:23:21 +0000 (09:23 +0000)]
Revert the _T('x') to 'x' changes from my previous commit.
Although both methods work properly, _T('x') seems to be the more convenient method used throughout cmd.

svn path=/trunk/; revision=33546

14 years ago- Fix some warnings spotted by MSVC
Colin Finck [Sat, 17 May 2008 08:49:39 +0000 (08:49 +0000)]
- Fix some warnings spotted by MSVC
- Define cmd_exit to ExitProcess if _DEBUG_MEM is not defined.
  Fixes compilation, when _DEBUG_MEM is turned off.

svn path=/trunk/; revision=33545

14 years agoApply the same fix to dwnl
Pierre Schweitzer [Sat, 17 May 2008 08:20:32 +0000 (08:20 +0000)]
Apply the same fix to dwnl

svn path=/trunk/; revision=33544

14 years agoZero memory using HeapAlloc flag
Pierre Schweitzer [Sat, 17 May 2008 08:19:23 +0000 (08:19 +0000)]
Zero memory using HeapAlloc flag
Spotted by Stefan Ginsberg <>

svn path=/trunk/; revision=33543

14 years agoRemove IRP_MJ_QUERY_INFORMATION / FileNetworkOpenInformation
Hervé Poussineau [Fri, 16 May 2008 19:00:47 +0000 (19:00 +0000)]
Remove IRP_MJ_QUERY_INFORMATION / FileNetworkOpenInformation
Fix misc bugs

svn path=/trunk/; revision=33542

14 years agoCarlo Bramini (carlo DOT bramix AT libero DOT it):
Colin Finck [Fri, 16 May 2008 16:53:36 +0000 (16:53 +0000)]
Carlo Bramini (carlo DOT bramix AT libero DOT it):
- Implemented "regedt32", which just calls "regedit"
See issue #3248 for more details.

svn path=/trunk/; revision=33541

14 years agoCheck if memory was goodly allocated and zero it before use
Pierre Schweitzer [Fri, 16 May 2008 16:13:04 +0000 (16:13 +0000)]
Check if memory was goodly allocated and zero it before use

svn path=/trunk/; revision=33540

14 years ago- Add specific properties to the keyboardlayout module type. They will assist us...
Marc Piulachs [Thu, 15 May 2008 22:38:18 +0000 (22:38 +0000)]
- Add specific properties to the keyboardlayout module type. They will assist us on autogenerating/updating the [keyboardLayout] & [Files.KeyboardLayout] from txtsetup and registry information automatically in the near future
note: All rbuild files in reactos\dll\keyboard must be updated to contain the follwing information:

<module name="kbdusl" type="keyboardlayout" (...) description="US Dvorak for left hand" lcid="00030409" layoutId="001A" layoutnameresid="5027" >

svn path=/trunk/; revision=33539

14 years ago- change module type kernelmodedll -> keyboardlayout
Marc Piulachs [Thu, 15 May 2008 22:23:34 +0000 (22:23 +0000)]
- change module type kernelmodedll -> keyboardlayout

svn path=/trunk/; revision=33538

14 years agoImprove filter command by changing its syntax
Hervé Poussineau [Thu, 15 May 2008 20:43:26 +0000 (20:43 +0000)]
Improve filter command by changing its syntax
Syntax: filter [error|warning|trace|info|level]+|-[componentname|default]

svn path=/trunk/; revision=33537

14 years agoFix debug output of strings
Hervé Poussineau [Thu, 15 May 2008 20:29:50 +0000 (20:29 +0000)]
Fix debug output of strings

svn path=/trunk/; revision=33536

14 years agoOops, didn't see the commented section.
Gregor Brunmar [Thu, 15 May 2008 20:13:40 +0000 (20:13 +0000)]
Oops, didn't see the commented section.

svn path=/trunk/; revision=33535

14 years agoSynced listbox LB_SETCURSEL behaviour with Wine, to pass a couple of more winetests.
Gregor Brunmar [Thu, 15 May 2008 20:11:26 +0000 (20:11 +0000)]
Synced listbox LB_SETCURSEL behaviour with Wine, to pass a couple of more winetests.

svn path=/trunk/; revision=33534

14 years agocmd: replace static traces by dynamic ones
Hervé Poussineau [Thu, 15 May 2008 20:02:05 +0000 (20:02 +0000)]
cmd: replace static traces by dynamic ones

svn path=/trunk/; revision=33533

14 years agoPatch by Kamil Hornicek ( tykef AT atlas DOT cz ):
Gregor Brunmar [Thu, 15 May 2008 19:07:46 +0000 (19:07 +0000)]
Patch by Kamil Hornicek ( tykef AT atlas DOT cz ):
* Fixed DialogBoxParam to set correct error values and returning correct error codes

svn path=/trunk/; revision=33532

14 years ago- Add specific module type for keyboard layouts
Marc Piulachs [Thu, 15 May 2008 14:46:15 +0000 (14:46 +0000)]
- Add specific module type for keyboard layouts
- Added a description attribute to modules
- Added a lcid attribute to modules (KeyboardLayout only)

svn path=/trunk/; revision=33531

14 years ago- Rename the LICINFO structure to LIC_CONTEXT as LICINFO is already used in one of...
Colin Finck [Thu, 15 May 2008 14:33:33 +0000 (14:33 +0000)]
- Rename the LICINFO structure to LIC_CONTEXT as LICINFO is already used in one of the official MS PSDK headers
- Replace IsUserAdmin (Wine API) with IsUserAnAdmin (shell32 API)

When you now add the PROCESSOR_POWER_INFORMATION structure to "precomp.h" (which was "accidentally omitted from WinNT.h" according to MSDN..), sysdm.cpl can be compiled using MSVC and the MS PSDK headers.

svn path=/trunk/; revision=33530

14 years ago- use menu identifier for menu items which have submenus
Johannes Anderwald [Thu, 15 May 2008 14:10:55 +0000 (14:10 +0000)]
- use menu identifier for menu items which have submenus
- menu item is a separator when id, flags and string is zero (verified with MS Visual 2005)
- set item separator MF_GRAYED as default style
- rewrite CheckMenuRadioItem
- check if checkmarks applies to more than one submenu
- check if checkmark was set
- dont set checkmark on menu item separator
- recurse into sub menus when available
- implement handling by MF_BYPOSITION
- ReactOS now passes now all tests from test_CheckMenuRadioItem in user32_winetest

svn path=/trunk/; revision=33529

14 years agoCarlo Bramini (carlo DOT bramix AT libero DOT it):
Colin Finck [Thu, 15 May 2008 14:06:19 +0000 (14:06 +0000)]
Carlo Bramini (carlo DOT bramix AT libero DOT it):
- Simplify blitting the screen bitmap to the main window.

This also hides a ROS GDI bug, for which I'm going to open a new bug report.
See issue #3241 for more details.

svn path=/trunk/; revision=33528

14 years agoRemove old leftovers from the time when shell32 was still synchronized with Wine
Colin Finck [Thu, 15 May 2008 13:55:26 +0000 (13:55 +0000)]
Remove old leftovers from the time when shell32 was still synchronized with Wine

svn path=/trunk/; revision=33527

14 years ago- Added a new attribute 'internal' to 'Property' element. Internal properties are...
Marc Piulachs [Thu, 15 May 2008 13:55:25 +0000 (13:55 +0000)]
- Added a new attribute 'internal' to 'Property' element. Internal properties are like regular properties but internal to rbuild (they are not included in the generated makefile)

svn path=/trunk/; revision=33526

14 years ago- Start implement "Advanced Key Settings" and "Change Key Sequence" dialogs
Dmitry Chapyshev [Thu, 15 May 2008 12:38:12 +0000 (12:38 +0000)]
- Start implement "Advanced Key Settings" and "Change Key Sequence" dialogs
- Update all resources

svn path=/trunk/; revision=33525

14 years agoAdd Client and Color transform objects.
James Tabor [Thu, 15 May 2008 11:38:46 +0000 (11:38 +0000)]
Add Client and Color transform objects.

svn path=/trunk/; revision=33524

14 years ago- Don't show applets on taskbar
Dmitry Chapyshev [Thu, 15 May 2008 05:43:01 +0000 (05:43 +0000)]
- Don't show applets on taskbar

svn path=/trunk/; revision=33523

14 years agoImplement Delete/CreateColorSpace and Get/SetColorSpace.
James Tabor [Thu, 15 May 2008 02:15:10 +0000 (02:15 +0000)]
Implement Delete/CreateColorSpace and Get/SetColorSpace.

svn path=/trunk/; revision=33522

14 years agoStefan Ginsberg <>
Aleksey Bragin [Wed, 14 May 2008 20:59:43 +0000 (20:59 +0000)]
Stefan Ginsberg <>
- Spelling fixes.
- Remove deprecated and unused HalReleaseDisplayOwnership prototype.
- Fix handle leak in NtCreateProfile.
- Don't miss an OBTRACE debug print in ObpCloseHandle in STATUS_SUCCESS case.

svn path=/trunk/; revision=33521

14 years agoStefan Ginsberg <>
Aleksey Bragin [Wed, 14 May 2008 20:57:19 +0000 (20:57 +0000)]
Stefan Ginsberg <>
- Remove deprecated NEW_SCHEDULER define.
- Remove empty addition arc subdirectory in include/reactos/arc

svn path=/trunk/; revision=33520

14 years ago- update msiexec version
Marc Piulachs [Wed, 14 May 2008 17:32:19 +0000 (17:32 +0000)]
- update msiexec version
- add iexplorer

svn path=/trunk/; revision=33519

14 years ago- sync msiexec to Wine 1.0-rc1
Marc Piulachs [Wed, 14 May 2008 17:25:57 +0000 (17:25 +0000)]
- sync msiexec to Wine 1.0-rc1
- change module type to win32cui inset of win32gui

svn path=/trunk/; revision=33518

14 years agoAdd iexplore from Wine. (Disabled until shdocvw sync)
Steven Edwards [Wed, 14 May 2008 17:24:40 +0000 (17:24 +0000)]
Add iexplore from Wine. (Disabled until shdocvw sync)

svn path=/trunk/; revision=33517

14 years ago- Check that the user name does not contain any illegal characters.
Eric Kohl [Wed, 14 May 2008 17:02:17 +0000 (17:02 +0000)]
- Check that the user name does not contain any illegal characters.
- Check that both passwords are the same.
- Limit the maximum user name length to 20 characters.

svn path=/trunk/; revision=33516

14 years ago- Implement "Set Default" button
Dmitry Chapyshev [Wed, 14 May 2008 15:51:53 +0000 (15:51 +0000)]
- Implement "Set Default" button
- Added checking whether there was already layout

svn path=/trunk/; revision=33515

14 years ago- Set catalan default keyboard layout to spanish (no specific catalan kb layout exists)
Marc Piulachs [Wed, 14 May 2008 14:40:17 +0000 (14:40 +0000)]
- Set catalan default keyboard layout to spanish (no specific catalan kb layout exists)
- [FORMATTING] small code indent for LanguageList contents

svn path=/trunk/; revision=33514

14 years agoCarlo Bramini (carlo DOT bramix AT libero DOT it)
Colin Finck [Wed, 14 May 2008 14:18:11 +0000 (14:18 +0000)]
Carlo Bramini (carlo DOT bramix AT libero DOT it)
- Italian translations and various fixes to Magnify (fixes part of bug #3241 as well)

Changes by me:
- Shorten the german dialog string a bit, so that it won't be truncated. Strings for Static controls can only be 256 characters long.
  A french translator should change the text as well, because it's longer than 256 characters.

See issue #3245 for more details.

svn path=/trunk/; revision=33513

14 years ago- Implement generic list PageUp/PageDown
Marc Piulachs [Wed, 14 May 2008 14:01:06 +0000 (14:01 +0000)]
- Implement generic list PageUp/PageDown

svn path=/trunk/; revision=33512

14 years agoA few missing defines I needed
Ged Murphy [Wed, 14 May 2008 11:38:10 +0000 (11:38 +0000)]
A few missing defines I needed

svn path=/trunk/; revision=33511

14 years agoWe have Brush Attributes already define in ntgdihdl.h, its a user space structure.
James Tabor [Tue, 13 May 2008 23:54:20 +0000 (23:54 +0000)]
We have Brush Attributes already define in ntgdihdl.h, its a user space structure.

svn path=/trunk/; revision=33510

14 years agoImplement NtGdiSetVirtualResolution, SetSizeDevice and NtGdiScaleViewport/WindowExtEx...
James Tabor [Tue, 13 May 2008 23:26:02 +0000 (23:26 +0000)]
Implement NtGdiSetVirtualResolution, SetSizeDevice and NtGdiScaleViewport/WindowExtEx. Getting ready to fix wine gdi mapping tests.

svn path=/trunk/; revision=33509

14 years agoOpen the Explorer Shell Folder instead of providing a standalone Control Panel.
Colin Finck [Tue, 13 May 2008 21:39:25 +0000 (21:39 +0000)]
Open the Explorer Shell Folder instead of providing a standalone Control Panel.
This changed enables us to remove lots of files from the app :-)

svn path=/trunk/; revision=33508

14 years agoCompletely revamped "control.exe":
Colin Finck [Tue, 13 May 2008 21:30:55 +0000 (21:30 +0000)]
Completely revamped "control.exe":
- Now uses shell32 functions for loading the control panel applets, so that the mutex is used as well (see bug #781)
- Supports all built-in command-line parameters, which are supported by the WinXP version.
  This also added support for opening shell folders.
- Loads other possible parameters from the registry.
- Only passes the command for RunControlPanel to each ListView item, not a whole struct whose members aren't needed later.
- Fixed memory leaks
- Added a header file
- Fixed indentation

This is the last version of the standalone Control Panel.
I will change it to call the Explorer shell folder in my next commit.
See issue #781 for more details.

svn path=/trunk/; revision=33507

14 years agodisplay available command line options when started with "-?"
Martin Fuchs [Tue, 13 May 2008 21:01:09 +0000 (21:01 +0000)]
display available command line options when started with "-?"

svn path=/trunk/; revision=33506

14 years ago- Implement the creation and removal of user accounts.
Eric Kohl [Tue, 13 May 2008 20:55:37 +0000 (20:55 +0000)]
- Implement the creation and removal of user accounts.
- User name and passwords are NOT checked upon the creation of a new user account.
- Disable all unimplemented popup menu items.

svn path=/trunk/; revision=33505

14 years ago- Implement "Input language Properties" dialog
Dmitry Chapyshev [Tue, 13 May 2008 20:23:23 +0000 (20:23 +0000)]
- Implement "Input language Properties" dialog

svn path=/trunk/; revision=33504

14 years agoHopefully fixes bug #1110. Requested fixed by amine48rz.
Gregor Brunmar [Tue, 13 May 2008 20:14:30 +0000 (20:14 +0000)]
Hopefully fixes bug #1110. Requested fixed by amine48rz.
See issue #1110 for more details.

svn path=/trunk/; revision=33503

14 years ago- Remove a leftover.
Aleksey Bragin [Tue, 13 May 2008 19:29:20 +0000 (19:29 +0000)]
- Remove a leftover.

svn path=/trunk/; revision=33502

14 years agoFixed spelling mistake from previous checkin
Gregor Brunmar [Tue, 13 May 2008 18:12:08 +0000 (18:12 +0000)]
Fixed spelling mistake from previous checkin

svn path=/trunk/; revision=33501

14 years agoNtUserBuildHwndList() returns NTSTATUS, not ULONG. More correct fix than 33483 to...
Gregor Brunmar [Tue, 13 May 2008 18:09:08 +0000 (18:09 +0000)]
NtUserBuildHwndList() returns NTSTATUS, not ULONG. More correct fix than 33483 to some of the winetest problems. Pass return value as out parameter instead.

svn path=/trunk/; revision=33500

14 years agoCase-sensitivity fix for Linux build hosts. Spotted by Tushar S. (GreyGhost)
KJK::Hyperion [Tue, 13 May 2008 17:32:19 +0000 (17:32 +0000)]
Case-sensitivity fix for Linux build hosts. Spotted by Tushar S. (GreyGhost)

svn path=/trunk/; revision=33499

14 years agoadd some info for xen to txtmode.cfg
Christoph von Wittich [Tue, 13 May 2008 17:30:29 +0000 (17:30 +0000)]
add some info for xen to txtmode.cfg
fix a bug rosboot_test.cpp

svn path=/trunk/; revision=33498

14 years agodon't display all debug data 4 times when using PipeReader class (spotted by janderwald)
Christoph von Wittich [Tue, 13 May 2008 17:17:31 +0000 (17:17 +0000)]
don't display all debug data 4 times when using PipeReader class (spotted by janderwald)

svn path=/trunk/; revision=33497

14 years ago- move hardcoded xen configuration name to config file
Johannes Anderwald [Tue, 13 May 2008 16:22:31 +0000 (16:22 +0000)]
- move hardcoded xen configuration name to config file

svn path=/trunk/; revision=33496

14 years ago- Update Russian translation
Dmitry Chapyshev [Tue, 13 May 2008 13:46:31 +0000 (13:46 +0000)]
- Update Russian translation
- Small fix mstsc icon

svn path=/trunk/; revision=33495

14 years ago- [FORMATTING] replace tabs by spaces
Marc Piulachs [Tue, 13 May 2008 11:43:39 +0000 (11:43 +0000)]
- [FORMATTING] replace tabs by spaces
- Modified keyboard layout listbox location to give usetup a more consistent look

svn path=/trunk/; revision=33494

14 years ago- fixed and simplified scroll behavior
Marc Piulachs [Tue, 13 May 2008 11:29:56 +0000 (11:29 +0000)]
- fixed and simplified scroll behavior

svn path=/trunk/; revision=33493

14 years agoUse a Mutex, so that CPL applets cannot be launched multiple times.
Colin Finck [Tue, 13 May 2008 08:56:23 +0000 (08:56 +0000)]
Use a Mutex, so that CPL applets cannot be launched multiple times.
Fixes bug #781 partly, we still need a fix in "control.exe" (see my comment in the bug report)

svn path=/trunk/; revision=33492

14 years agoimprove visual scroll behavior (arrow-up/-down hints) of the generic list (first...
Klemens Friedl [Tue, 13 May 2008 08:04:59 +0000 (08:04 +0000)]
improve visual scroll behavior (arrow-up/-down hints) of the generic list (first step setup)

svn path=/trunk/; revision=33491

14 years agoAdded W32PF and Brush flags. Fixed IntGdiExtCreatePen and all related so to pass...
James Tabor [Tue, 13 May 2008 05:13:25 +0000 (05:13 +0000)]
Added W32PF and Brush flags. Fixed IntGdiExtCreatePen and all related so to pass wine gdi32 pen tests. Fail 100 out of 664 no skips.

svn path=/trunk/; revision=33490

14 years agofix build, sorry
Timo Kreuzer [Tue, 13 May 2008 04:30:00 +0000 (04:30 +0000)]
fix build, sorry

svn path=/trunk/; revision=33489

14 years ago- fix a pointer to INT cast
Timo Kreuzer [Tue, 13 May 2008 04:18:07 +0000 (04:18 +0000)]
- fix a pointer to INT cast
- use InterlockedExchangePointer instead of InterlockedExchange for a pointer

svn path=/trunk/; revision=33488

14 years agoDon't strip trailing spaces from the command line
Colin Finck [Mon, 12 May 2008 21:26:38 +0000 (21:26 +0000)]
Don't strip trailing spaces from the command line
This way, stuff like "notepad abc.txt  " will correctly pass "abc.txt  " as the filename like Windows does.

See issue #1818 for more details.

svn path=/trunk/; revision=33487

14 years agoFix the Release build by marking MmPageArraySize as unreferenced.
Colin Finck [Mon, 12 May 2008 20:48:48 +0000 (20:48 +0000)]
Fix the Release build by marking MmPageArraySize as unreferenced.
Changing the ASSERT, so that it doesn't spit out an "unused variable" warning on Release builds doesn't work, because then it expects this variable to exist. (which is not the case for some struct elements passed to ASSERT in some other parts of the kernel)

svn path=/trunk/; revision=33486

14 years ago[FORMATTING] Fix indentation (4 spaces)
Colin Finck [Mon, 12 May 2008 20:11:11 +0000 (20:11 +0000)]
[FORMATTING] Fix indentation (4 spaces)

svn path=/trunk/; revision=33485

14 years agoThe lstr* functions don't reset the last error on an exception. Also they handle...
Colin Finck [Mon, 12 May 2008 20:01:48 +0000 (20:01 +0000)]
The lstr* functions don't reset the last error on an exception. Also they handle more than just access violation exceptions.
This makes us passing (at least) one more sub test of a Wine test (user32_winetest text)
Behaviour verified under Windows XP SP2.

svn path=/trunk/; revision=33484

14 years ago* Synced DIALOG_DlgDirListW() and DIALOG_DlgDirSelect() from Wine to get more user32...
Gregor Brunmar [Mon, 12 May 2008 19:36:39 +0000 (19:36 +0000)]
* Synced DIALOG_DlgDirListW() and DIALOG_DlgDirSelect() from Wine to get more user32.dll winetests to pass
* Fixed indentation in User32EnumWindows()
* Removed internal use of Set/GetLastError() from User32EnumWindows() - makes even more winetests pass

svn path=/trunk/; revision=33483

14 years agoSync CharLowerA/W and CharUpperA/W with Wine (after replacing Wine's SEH with PSEH).
Colin Finck [Mon, 12 May 2008 18:35:21 +0000 (18:35 +0000)]
Sync CharLowerA/W and CharUpperA/W with Wine (after replacing Wine's SEH with PSEH).
This way, we pass all user32 wsprintf Wine tests.
Verified under Windows XP SP2.

svn path=/trunk/; revision=33482

14 years agoMisc patch, for later Icm support, update CreateCompatibleDC.
James Tabor [Mon, 12 May 2008 18:16:48 +0000 (18:16 +0000)]
Misc patch, for later Icm support, update CreateCompatibleDC.

svn path=/trunk/; revision=33481

14 years agoDo not touch the new user name if the user cancels the rename action.
Eric Kohl [Mon, 12 May 2008 17:39:58 +0000 (17:39 +0000)]
Do not touch the new user name if the user cancels the rename action.

svn path=/trunk/; revision=33479

14 years ago- ModifyMenu[A|W], AppendMenu[A|W], InsertMenu[A|W] should accept MF_HILITE
Johannes Anderwald [Mon, 12 May 2008 17:17:55 +0000 (17:17 +0000)]
- ModifyMenu[A|W], AppendMenu[A|W], InsertMenu[A|W] should accept MF_HILITE
- verified by user32_winetest.exe
- ReactOS now passes these tests (test_menu_flags)

svn path=/trunk/; revision=33478

14 years ago- create the profiles directory if it does not yet exist
Johannes Anderwald [Mon, 12 May 2008 16:59:06 +0000 (16:59 +0000)]
- create the profiles directory if it does not yet exist

svn path=/trunk/; revision=33477

14 years agoRemove all remaining occurrences of the W64 macro.
Colin Finck [Mon, 12 May 2008 15:59:31 +0000 (15:59 +0000)]
Remove all remaining occurrences of the W64 macro.
The __w64 setting is obsolete beginning with MSVC 2008.

svn path=/trunk/; revision=33475

14 years ago- Fix a typo in NtSecureConnectPort, ViewBase was not updated, thus confusing callers.
Aleksey Bragin [Mon, 12 May 2008 15:27:15 +0000 (15:27 +0000)]
- Fix a typo in NtSecureConnectPort, ViewBase was not updated, thus confusing callers.
See issue #3242 for more details.

svn path=/trunk/; revision=33473

14 years agoconvert another pointer calculations to FIELD_OFFSET macro and use "%p" instead of...
Timo Kreuzer [Mon, 12 May 2008 15:12:43 +0000 (15:12 +0000)]
convert another pointer calculations to FIELD_OFFSET macro and use "%p" instead of casting pointers to long

svn path=/trunk/; revision=33472

14 years ago- Make IoCreateNotificationEvent and IoCreateSynchronizationEvent create kernel handl...
Aleksey Bragin [Mon, 12 May 2008 13:42:05 +0000 (13:42 +0000)]
- Make IoCreateNotificationEvent and IoCreateSynchronizationEvent create kernel handles (according to MSDN Spotted by Stefan Ginsberg.

svn path=/trunk/; revision=33470

14 years agoUse dynamic debug system
Hervé Poussineau [Mon, 12 May 2008 12:01:51 +0000 (12:01 +0000)]
Use dynamic debug system

svn path=/trunk/; revision=33469

14 years agoReuse existing function instead of duplicating functionality
Hervé Poussineau [Mon, 12 May 2008 09:58:14 +0000 (09:58 +0000)]
Reuse existing function instead of duplicating functionality
Patch by Carlo Bramini, carlo dot bramix at libero dot it
See issue #2437 for more details.

svn path=/trunk/; revision=33468

14 years ago"\\.\" always exists
Hervé Poussineau [Mon, 12 May 2008 09:40:08 +0000 (09:40 +0000)]
"\\.\" always exists
Fixes "copy freeldr.ini con:" command

svn path=/trunk/; revision=33467

14 years ago- Fix yet another typo in the same line, spotted by Stefan Ginsberg.
Aleksey Bragin [Mon, 12 May 2008 08:34:33 +0000 (08:34 +0000)]
- Fix yet another typo in the same line, spotted by Stefan Ginsberg.

svn path=/trunk/; revision=33465

14 years agoKamil Hornicek <>
Aleksey Bragin [Mon, 12 May 2008 08:33:26 +0000 (08:33 +0000)]
Kamil Hornicek <>
- Update tests to Wine head (as of 11th of May, 2008).

svn path=/trunk/; revision=33464

14 years ago- Fix a typo, spotted by Stefan Ginsberg.
Aleksey Bragin [Mon, 12 May 2008 08:11:31 +0000 (08:11 +0000)]
- Fix a typo, spotted by Stefan Ginsberg.

svn path=/trunk/; revision=33463

14 years agoFixed ExtCreatePen and started CreatePen. Tested with wine gdi32 cross test. Isolated...
James Tabor [Mon, 12 May 2008 07:31:15 +0000 (07:31 +0000)]
Fixed ExtCreatePen and started CreatePen. Tested with wine gdi32 cross test. Isolated problem in win32k.

svn path=/trunk/; revision=33461

14 years agoFixed wine all of gdi32 dc tests and only 2 of gdiobj tests left todo.
James Tabor [Mon, 12 May 2008 04:59:20 +0000 (04:59 +0000)]
Fixed wine all of gdi32 dc tests and only 2 of gdiobj tests left todo.

svn path=/trunk/; revision=33460

14 years agoFix typo spoted by Stefan100.
James Tabor [Mon, 12 May 2008 01:55:34 +0000 (01:55 +0000)]
Fix typo spoted by Stefan100.

svn path=/trunk/; revision=33459

14 years agoNtUserEnumDisplaySettings returns NTSTATUS not BOOL, it doesn't set LastError value...
Timo Kreuzer [Sun, 11 May 2008 23:51:55 +0000 (23:51 +0000)]
NtUserEnumDisplaySettings returns NTSTATUS not BOOL, it doesn't set LastError value. Fix parameter validation and return value, based on tests in w32knapi.Move NtUserEnumDisplayMonitors and NtUserEnumDisplaySettings from windc to a new file display.c (Int functions should go there, too). adapt user32 functions accordingly. As a result w32knapi test doesn't crash anymore.

svn path=/trunk/; revision=33458

14 years agofix a header name
Timo Kreuzer [Sun, 11 May 2008 23:25:02 +0000 (23:25 +0000)]
fix a header name

svn path=/trunk/; revision=33457

14 years agopatch by hyperion: convert pointer calculations with FIELD_OFFSET macro
Timo Kreuzer [Sun, 11 May 2008 23:15:44 +0000 (23:15 +0000)]
patch by hyperion: convert pointer calculations with FIELD_OFFSET macro

svn path=/trunk/; revision=33456

14 years agouse "%p" to DPRINT a pointer instead of casting it to int and using "%08x"
Timo Kreuzer [Sun, 11 May 2008 22:28:20 +0000 (22:28 +0000)]
use "%p" to DPRINT a pointer instead of casting it to int and using "%08x"

svn path=/trunk/; revision=33455

14 years ago- Use InterlockedExchangePointer instead of InterlockedExchange for a pointer.
Timo Kreuzer [Sun, 11 May 2008 22:23:45 +0000 (22:23 +0000)]
- Use InterlockedExchangePointer instead of InterlockedExchange for a pointer.
- Don't cast a DWORD to HANDLE directly
- ViewSize param of MmMapViewOfSection is SIZE_T, not ULONG

svn path=/trunk/; revision=33454