22 months ago[WIN32K:NTUSER] Correctly delete menus in failure cases in MENU_GetSystemMenu. CORE...
Thomas Faber [Sat, 3 Mar 2018 07:19:48 +0000 (08:19 +0100)]
[WIN32K:NTUSER] Correctly delete menus in failure cases in MENU_GetSystemMenu. CORE-12180

22 months ago[WIN32K:NTUSER] Handle IntCloneMenu failure in MENU_GetSystemMenu. CORE-12180
Thomas Faber [Sat, 3 Mar 2018 07:19:13 +0000 (08:19 +0100)]
[WIN32K:NTUSER] Handle IntCloneMenu failure in MENU_GetSystemMenu. CORE-12180

22 months ago[EXPLORER] Remove SetBandSiteInfo hack. CORE-9809
Thomas Faber [Sat, 3 Mar 2018 07:18:34 +0000 (08:18 +0100)]
[EXPLORER] Remove SetBandSiteInfo hack. CORE-9809

22 months ago[STORPORT][DDK] Add the StorPortExtendedFunction stub
Eric Kohl [Sat, 3 Mar 2018 13:19:33 +0000 (14:19 +0100)]
[STORPORT][DDK] Add the StorPortExtendedFunction stub
- Add the StorPortExtendedFunction stub to the storport driver.
- Add the declaration of StorPortExtendedFunction to the ddk.


22 months ago[TRANSLATION] Some translations update
Sergey Stopkin [Fri, 2 Mar 2018 15:23:30 +0000 (21:23 +0600)]
[TRANSLATION] Some translations update

22 months ago[COM_APITEST] Add some interfaces.
Thomas Faber [Fri, 2 Mar 2018 13:15:08 +0000 (14:15 +0100)]
[COM_APITEST] Add some interfaces.

22 months ago[COM_APITEST] Fix test failures on Win2003.
Thomas Faber [Fri, 2 Mar 2018 13:14:53 +0000 (14:14 +0100)]
[COM_APITEST] Fix test failures on Win2003.

22 months ago[NTOS:KE] Don't loop indefinitely trying to figure out the CPU frequency. CORE-14419
Thomas Faber [Thu, 1 Mar 2018 09:36:27 +0000 (10:36 +0100)]
[NTOS:KE] Don't loop indefinitely trying to figure out the CPU frequency. CORE-14419

Previously, we would keep sampling the CPU frequency until two subsequent
samples differed by at most 1 MHz. This could take several seconds, and would
unnecessarily delay boot.
Instead, if sampling is too unreliable, just give up and calculate the average
frequency from 10 samples. This is no worse than picking the frequency that
just happened to be returned twice in a row.

The fact that this method of sampling fails could indicate that there's a
problem with our performance counter implementation or timer interrupt,
but that's a separate issue...

22 months ago[TELEPHON.CPL] Include winuser.h in the rc which is needed for manifest_hosted.rc
Giannis Adamopoulos [Thu, 1 Mar 2018 08:05:12 +0000 (10:05 +0200)]
[TELEPHON.CPL] Include winuser.h in the rc which is needed for manifest_hosted.rc
Add a check in manifest_hosted.rc to make sure that winuser.h is included

22 months ago[BEEPMIDI] Don't busy-wait when no notes are playing. CORE-12860
Thomas Faber [Tue, 27 Feb 2018 17:36:22 +0000 (18:36 +0100)]
[BEEPMIDI] Don't busy-wait when no notes are playing. CORE-12860

- Use a new work_available event to allow ProcessPlayingNotes to sleep when no
  notes are to be played.
- Get rid of the pointless thread_termination_complete event, wait on the
  thread handle instead.
- Don't leak thread_handle.

22 months ago[SHIMGVW] -Add the 123 manifest to load the v6 comctl32. CORE-14415
Giannis Adamopoulos [Thu, 1 Mar 2018 07:20:44 +0000 (09:20 +0200)]
[SHIMGVW] -Add the 123 manifest to load the v6 comctl32. CORE-14415
This shows that we may have problems in the future with applications using just comctl32 v5

22 months ago[DESK] Fix text truncation in fr-FR.rc
Joachim Henze [Wed, 28 Feb 2018 22:00:31 +0000 (23:00 +0100)]
[DESK] Fix text truncation in fr-FR.rc


22 months ago[MMSYS] fix text truncation in fr-FR.rc
Joachim Henze [Wed, 28 Feb 2018 20:19:42 +0000 (21:19 +0100)]
[MMSYS] fix text truncation in fr-FR.rc


22 months ago[NTOKSRNL] Don't blindly schedule read-ahead on CcCopyRead() call.
Pierre Schweitzer [Wed, 28 Feb 2018 19:54:53 +0000 (20:54 +0100)]
[NTOKSRNL] Don't blindly schedule read-ahead on CcCopyRead() call.

This avoids locking Cc for too long by trying to read-ahead data which
is already in cache.
We now will only schedule a read ahead if next read should bring us
to a new VACB (perhaps not in cache).

This notably fixes Inkscape setup which was slown down by read-ahead
due to continous 1 byte reads.

Thanks to Thomas for his help on this issue.


22 months ago[STOBJECT] Use timers to distinguish between single and double clicks
Eric Kohl [Wed, 28 Feb 2018 19:29:29 +0000 (20:29 +0100)]
[STOBJECT] Use timers to distinguish between single and double clicks
- Volume, Power and Hotplug icon: Use timers to distinguish between single and double clicks.
- Volume icon: Show the tray volume dialog on a single click.

22 months ago[EXPLORER] CTrayWindow: Set the initial lock state in the band site
Giannis Adamopoulos [Wed, 28 Feb 2018 15:14:00 +0000 (17:14 +0200)]
[EXPLORER] CTrayWindow: Set the initial lock state in the band site
This alongside the previous commit, fix locking and unlocking the taskbar.

22 months ago[BROWSEUI] CBandSite: Implement SetBandSiteInfo and GetBandSiteInfo
Giannis Adamopoulos [Wed, 28 Feb 2018 15:16:46 +0000 (17:16 +0200)]
[BROWSEUI] CBandSite: Implement SetBandSiteInfo and GetBandSiteInfo

22 months ago[BROWSEUI] CBandSite: Style fixes
Giannis Adamopoulos [Wed, 28 Feb 2018 14:22:37 +0000 (16:22 +0200)]
[BROWSEUI] CBandSite: Style fixes

22 months ago[TRANSLATION] Completed German translation in taskmgr
Simon Dräger [Mon, 26 Feb 2018 12:32:43 +0000 (13:32 +0100)]
[TRANSLATION] Completed German translation in taskmgr

22 months ago[USER32] Small fixes for messages carrying pointers
Giannis Adamopoulos [Sat, 24 Feb 2018 18:26:24 +0000 (20:26 +0200)]
[USER32] Small fixes for messages carrying pointers
SendNotifyMessageW: It doesn't support messages with pointers so there is no need to call MsgiUMToKMMessage
SendMessageTimeoutW, SendMessageTimeoutA: These two do support marshaling pointers so they need to use MsgiUMToKMMessage.
This is actually a bug that happens only in the rare case where we send a WM_COPYDATA with a timeout.

22 months ago[WINSRV] Implement sending the hard error balloon package to explorer
Giannis Adamopoulos [Thu, 22 Feb 2018 17:15:45 +0000 (19:15 +0200)]
[WINSRV] Implement sending the hard error balloon package to explorer
[EXPLORER] Implement showing the hard error balloon

22 months ago[SNDVOL32] Add the tray volume dialog
Eric Kohl [Sun, 25 Feb 2018 20:58:34 +0000 (21:58 +0100)]
[SNDVOL32] Add the tray volume dialog
- Add the tray volume dialog (run "sndvol32 /t").
- Add a simple command line parser.

22 months ago[ADVAPI32] Few improvements for Services.
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 22:35:35 +0000 (23:35 +0100)]
[ADVAPI32] Few improvements for Services.

- Set some last errors.
- Fix error code returned by ScLookupServiceByServiceName().
- Check the validity of the handler proc in RegisterServiceCtrlHandler(Ex)W().
- Improve some traces; comment some code.

22 months ago[ADVAPI32] Code formatting + improve two traces.
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 18:40:08 +0000 (19:40 +0100)]
[ADVAPI32] Code formatting + improve two traces.

22 months ago[ADVAPI32] ScStartService(): Just start the thread straight ahead, and return a suita...
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 18:02:38 +0000 (19:02 +0100)]
[ADVAPI32] ScStartService(): Just start the thread straight ahead, and return a suitable error code if thread creation failed.

22 months ago[ADVAPI32] Take into account the service handler context when dispatching a control...
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 17:53:05 +0000 (18:53 +0100)]
[ADVAPI32] Take into account the service handler context when dispatching a control notification to a service. (Used e.g. by tcpsvcs.)

22 months ago[ADVAPI32] Use RPC types where needed. Comments cleanup.
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 15:31:00 +0000 (16:31 +0100)]
[ADVAPI32] Use RPC types where needed. Comments cleanup.

22 months ago[TRANSLATION] Completed German translation in stobject (#401)
Simon Dräger [Sun, 25 Feb 2018 22:36:05 +0000 (23:36 +0100)]
[TRANSLATION] Completed German translation in stobject (#401)

22 months ago[TRANSLATION] Minor German grammatical improvements
Simon Dräger [Sun, 25 Feb 2018 14:21:35 +0000 (15:21 +0100)]
[TRANSLATION] Minor German grammatical improvements

22 months ago[ADVAPI32_APITEST] Open services & SCM handles with correct access rights; improve...
Hermès Bélusca-Maïto [Sun, 25 Feb 2018 15:09:21 +0000 (16:09 +0100)]
[ADVAPI32_APITEST] Open services & SCM handles with correct access rights; improve a check order.

22 months ago[CONTRIBUTING] Update .gitmessage
Alexander Shaposhnikov [Sun, 25 Feb 2018 14:14:41 +0000 (16:14 +0200)]
[CONTRIBUTING] Update .gitmessage

The template is made more clear and specific.
Added non-mandatory width hints.

22 months ago[SC] Support the paramchange and netbind* control codes in the control command
Eric Kohl [Sun, 25 Feb 2018 13:08:16 +0000 (14:08 +0100)]
[SC] Support the paramchange and netbind* control codes in the control command

Eric Kohl [Sun, 25 Feb 2018 10:07:14 +0000 (11:07 +0100)]

22 months ago[CDFS_NEW] Sync with HEAD.
Pierre Schweitzer [Sun, 25 Feb 2018 09:13:15 +0000 (10:13 +0100)]
[CDFS_NEW] Sync with HEAD.


22 months ago[BOOTDATA] Do not include caroots.inf in registry.inf. CORE-12020
Thomas Faber [Sat, 24 Feb 2018 17:01:58 +0000 (18:01 +0100)]
[BOOTDATA] Do not include caroots.inf in registry.inf. CORE-12020

This splits registry.inf roughly in half, which massively reduces heap usage
in 1st stage. DPH and low-memory scenarios benefit from this.

22 months ago[SERVICES] Use safe-string routines in some places, and do not hardcode buffer lengths.
Hermès Bélusca-Maïto [Sat, 24 Feb 2018 23:48:43 +0000 (00:48 +0100)]
[SERVICES] Use safe-string routines in some places, and do not hardcode buffer lengths.

22 months ago[SERVICES] Send services shutdown notifications only if they accept them.
Hermès Bélusca-Maïto [Sat, 24 Feb 2018 23:31:17 +0000 (00:31 +0100)]
[SERVICES] Send services shutdown notifications only if they accept them.

22 months ago[SERVICES] Add french translation.
Hermès Bélusca-Maïto [Sat, 24 Feb 2018 23:06:27 +0000 (00:06 +0100)]
[SERVICES] Add french translation.

22 months ago[TRANSLATION] German syntax fix. 399/head
Simon Dräger [Sat, 24 Feb 2018 16:13:53 +0000 (17:13 +0100)]
[TRANSLATION] German syntax fix.

It is rather unusual to put a "then" after "If..", so removed that.

22 months ago[BOOTDATA] Fix path to temp folder for the Swedish locale (#381)
Harteex [Sat, 24 Feb 2018 22:08:55 +0000 (23:08 +0100)]
[BOOTDATA] Fix path to temp folder for the Swedish locale (#381)

22 months ago[NTOSKRNL] Implement ThreadHideFromDebugger in NtSetInformationThread()
Pierre Schweitzer [Sat, 24 Feb 2018 21:06:18 +0000 (22:06 +0100)]
[NTOSKRNL] Implement ThreadHideFromDebugger in NtSetInformationThread()

22 months ago[ACLAYERS] Add WIN8 and WIN81 VersionLie shims
Mark Jansen [Sat, 10 Feb 2018 14:31:55 +0000 (15:31 +0100)]
[ACLAYERS] Add WIN8 and WIN81 VersionLie shims

22 months ago[APPSHIM_APITEST] Add Win8 and Win81 versionlie tests
Mark Jansen [Sat, 10 Feb 2018 14:31:06 +0000 (15:31 +0100)]
[APPSHIM_APITEST] Add Win8 and Win81 versionlie tests

22 months ago[ACPPAGE] Enable version lies until Win7 + some cleanup
Mark Jansen [Tue, 6 Feb 2018 18:32:51 +0000 (19:32 +0100)]
[ACPPAGE] Enable version lies until Win7 + some cleanup

22 months ago[APPHELP] Set debug level in case of parse failure
Mark Jansen [Tue, 6 Feb 2018 18:32:26 +0000 (19:32 +0100)]
[APPHELP] Set debug level in case of parse failure

22 months ago[SERVMAN] Add an accelerator for the F5 (refresh) key
Eric Kohl [Sat, 24 Feb 2018 17:38:08 +0000 (18:38 +0100)]
[SERVMAN] Add an accelerator for the F5 (refresh) key


22 months ago[WIN32K] Get rid of some instances of the ugly RETURN() macro
Timo Kreuzer [Sat, 9 Sep 2017 12:42:53 +0000 (14:42 +0200)]
[WIN32K] Get rid of some instances of the ugly RETURN() macro

22 months ago[FORMATTING] Fix indentation, no functional changes.
Timo Kreuzer [Mon, 19 Feb 2018 14:04:38 +0000 (15:04 +0100)]
[FORMATTING] Fix indentation, no functional changes.

22 months ago[NTOSKRNL] Implement the support for reserve IRP in IO
Pierre Schweitzer [Sat, 24 Feb 2018 13:50:23 +0000 (14:50 +0100)]
[NTOSKRNL] Implement the support for reserve IRP in IO

The reserve IRP is an IRP which is allocated on system boot and kept during
the whole system life. Its purpose is to allow page reads in case of
low-memory situations where the system doesn't have enough memory left
to allocate an IRP to read from the page file (would be catastrophic situation).

22 months ago[NTOSKRNL] Add the CcDataFlushes and CcDataPages counters
Pierre Schweitzer [Sat, 24 Feb 2018 13:02:33 +0000 (14:02 +0100)]
[NTOSKRNL] Add the CcDataFlushes and CcDataPages counters

22 months ago[NTOSKRNL] Add the CcPinReadWait and CcPinReadNoWait counters
Pierre Schweitzer [Sat, 24 Feb 2018 12:47:15 +0000 (13:47 +0100)]
[NTOSKRNL] Add the CcPinReadWait and CcPinReadNoWait counters

22 months ago[SHLWAPI] Cherry-pick Wine commit 7be8beab68c (Don't attempt to un-expect ComputerNam...
Thomas Faber [Sat, 24 Feb 2018 13:15:48 +0000 (14:15 +0100)]
[SHLWAPI] Cherry-pick Wine commit 7be8beab68c (Don't attempt to un-expect ComputerName in PathUnExpandEnvStrings) by Katayama Hirofumi MZ. CORE-13816

22 months ago[KERNEL32_WINETEST] Cherry-pick Wine commit 85f515292aa (Close process / thread handl...
Thomas Faber [Sat, 24 Feb 2018 13:14:35 +0000 (14:14 +0100)]
[KERNEL32_WINETEST] Cherry-pick Wine commit 85f515292aa (Close process / thread handles) by Mark Jansen.

22 months ago[IMAGEHLP_WINETEST] Un-mark a ROS-diff that's been committed upstream.
Thomas Faber [Sat, 24 Feb 2018 11:05:12 +0000 (12:05 +0100)]
[IMAGEHLP_WINETEST] Un-mark a ROS-diff that's been committed upstream.

22 months ago[NTOSKRNL] Return some Cc counters in SystemPerformanceInformation
Pierre Schweitzer [Sat, 24 Feb 2018 12:35:17 +0000 (13:35 +0100)]
[NTOSKRNL] Return some Cc counters in SystemPerformanceInformation

22 months ago[NTOSKRNL] Add the CcMapDataWait and CcMapDataNoWait counters
Pierre Schweitzer [Sat, 24 Feb 2018 12:28:45 +0000 (13:28 +0100)]
[NTOSKRNL] Add the CcMapDataWait and CcMapDataNoWait counters

22 months ago[SERVICES][ADVAPI32] Fix the broken service stop sequence
Eric Kohl [Sat, 24 Feb 2018 10:14:05 +0000 (11:14 +0100)]
[SERVICES][ADVAPI32] Fix the broken service stop sequence

- Refactor ScmControlService() so that it can be used to send the dispatcher loop stop command.
- Separate the code to decrement the image run counter from the service image cleanup code.

- RSetServiceStatus(): Stop the dispatcher loop when the image run counter is zero and remove the service image after that.

- Do not terminate the service dispatcher loop when the last service is being stopped. Wait for an explicit dispatcher stop command (empty service name).


22 months ago[IPHLPAPI] Fix getNumRoutes() return value, on Mib error (#391)
Serge Gautherie [Fri, 23 Feb 2018 17:35:02 +0000 (18:35 +0100)]
[IPHLPAPI] Fix getNumRoutes() return value, on Mib error (#391)

22 months ago[SHELL32] -CMenuToolbarBase: Remove all buttons on destruction. CORE-13194
Giannis Adamopoulos [Fri, 23 Feb 2018 10:27:48 +0000 (12:27 +0200)]
[SHELL32] -CMenuToolbarBase: Remove all buttons on destruction. CORE-13194
It seems that TBN_DELETINGBUTTON isn't called when the toolbar gets destroyed so the only way to avoid leaking the data is emptying it ourselves.

22 months ago[SHIMENG] Do not crash on a NULL ModuleName & BaseAddress.
Mark Jansen [Thu, 22 Feb 2018 22:25:34 +0000 (23:25 +0100)]
[SHIMENG] Do not crash on a NULL ModuleName & BaseAddress.

22 months ago[KMTESTS:FSRTL] Fix all FsRtlLargeMcbTestsFastFat() checks
Serge Gautherie [Thu, 22 Feb 2018 15:03:42 +0000 (16:03 +0100)]
[KMTESTS:FSRTL] Fix all FsRtlLargeMcbTestsFastFat() checks

Addendum to 22037684e42e29abc99a9a280278b16305eaa2e2.

- Result: check "== FALSE" not "= TRUE".
- Report compared values, not different ones.


22 months ago[NTOS:CC] Don't read past the end of the file in CcPerformReadAhead. 390/head
Thomas Faber [Tue, 20 Feb 2018 12:49:54 +0000 (13:49 +0100)]
[NTOS:CC] Don't read past the end of the file in CcPerformReadAhead.

22 months ago[NTOS:CC] Avoid some magic numbers.
Thomas Faber [Tue, 20 Feb 2018 12:18:34 +0000 (13:18 +0100)]
[NTOS:CC] Avoid some magic numbers.

22 months ago[SHELL32] Fix PIDL leak in CMenuSFToolbar::FillToolbar. CORE-13194
Thomas Faber [Thu, 22 Feb 2018 10:51:07 +0000 (11:51 +0100)]
[SHELL32] Fix PIDL leak in CMenuSFToolbar::FillToolbar. CORE-13194

22 months ago[DHCPCSVC] Fix a memory leak in bind_lease introduced in r14645 (!). CORE-14353
Thomas Faber [Thu, 22 Feb 2018 10:28:55 +0000 (11:28 +0100)]
[DHCPCSVC] Fix a memory leak in bind_lease introduced in r14645 (!). CORE-14353

22 months ago[KMTESTS:FSRTL] Add a few more tests matching MS FastFAT.
Pierre Schweitzer [Wed, 21 Feb 2018 21:50:23 +0000 (22:50 +0100)]
[KMTESTS:FSRTL] Add a few more tests matching MS FastFAT.


22 months ago[IPHLPAPI] Fix memory leak in getNumRoutes. CORE-14353
Thomas Faber [Wed, 21 Feb 2018 17:40:23 +0000 (18:40 +0100)]
[IPHLPAPI] Fix memory leak in getNumRoutes. CORE-14353

22 months ago[KMTESTS:FSRTL] Avoid writing to string literals. ROSTESTS-298
Thomas Faber [Wed, 21 Feb 2018 14:16:47 +0000 (15:16 +0100)]
[KMTESTS:FSRTL] Avoid writing to string literals. ROSTESTS-298

22 months ago[VFATLIB] Fix FAT partitions formatting in a non clean fashion.
Pierre Schweitzer [Tue, 20 Feb 2018 23:16:36 +0000 (00:16 +0100)]
[VFATLIB] Fix FAT partitions formatting in a non clean fashion.

(So the fun begins)
In spite of what VFATLIB headers pretend, there's not magic in FAT boot sector.
The 3 first bytes are just the jump instruction (to the boot code). No jump, no boot.
Also, some (many?) FAT implementations rely on the jump code to help detecting that
a FAT volume is really a FAT volume. Like MS FastFAT. Or our own FAT recognizer in FS_REC.
The story is that, up to that commit, we zeroed the 3 first bytes; leading to broken
FAT volumes.
This got hidden in most cases by the fact that during setup, when we install boot
loader, we erase parts of the boot sector, including the jump instruction, making the
volume valid again. But that wouldn't fix secondary volumes where the boot loader isn't
And, also, imagine a scenario where you want to install ReactOS on a newly formatted volume
with MS FastFAT instead of our own implementation... That would simply not work to
the fact that the driver wouldn't recognize the fresh formatted volume!

(So the non fashion begins)
Fix this by putting a not that valid jump into the boot sector when formatting our
partitions. That way, our volume is always regarding a FAT view point. But, instead of
putting values that mean (nearly) nothing. We should also put a dummy bootloader
displaying the user and error message, as done by dosfstools.

(So the hope begins)
This opens the way for trying to install ReactOS with MS FastFAT (doesn't work yet).


22 months ago[SC] Addendum to 4728157: Add missed values to query errors and usage output. (#387)
Serge Gautherie [Tue, 20 Feb 2018 18:45:55 +0000 (19:45 +0100)]
[SC] Addendum to 4728157: Add missed values to query errors and usage output. (#387)

22 months ago[SHELL32] CShellItem: Fix GetDisplayName and Compare
Giannis Adamopoulos [Tue, 20 Feb 2018 14:59:00 +0000 (16:59 +0200)]
[SHELL32] CShellItem: Fix GetDisplayName and Compare
The two methods were completely broken because they passed a full pidl to the parent folder (and not desktop folder).
Compile SHGetNameFromIDList to use it in CShellItem but don't export it.

22 months ago[SHELL32] CShellItem: Implement BindToHandler and improve GetAttributes based on...
Giannis Adamopoulos [Tue, 20 Feb 2018 14:31:28 +0000 (16:31 +0200)]
[SHELL32] CShellItem: Implement BindToHandler and improve GetAttributes based on wine
Fixes lots of tests.

22 months ago[SHELL32] CShellItem: Fix return value of Compare method
Giannis Adamopoulos [Tue, 20 Feb 2018 12:36:31 +0000 (14:36 +0200)]
[SHELL32] CShellItem: Fix return value of Compare method

22 months ago[SHELL32] CDefaultContextMenu: Implement GetCommandString
Giannis Adamopoulos [Tue, 20 Feb 2018 11:05:59 +0000 (13:05 +0200)]
[SHELL32] CDefaultContextMenu: Implement GetCommandString

22 months ago[SHELL32] Fix a couple of tests
Giannis Adamopoulos [Tue, 20 Feb 2018 09:48:40 +0000 (11:48 +0200)]
[SHELL32] Fix a couple of tests

22 months ago[SHELL32] shellpath: sync a part of _SHGetDefaultValue with wine
Giannis Adamopoulos [Tue, 20 Feb 2018 08:58:14 +0000 (10:58 +0200)]
[SHELL32] shellpath: sync a part of _SHGetDefaultValue with wine
on 32bit builds CSIDL_PROGRAM_FILESX86 is treated as CSIDL_PROGRAM_FILES and on wow64 builds CSIDL_PROGRAM_FILES gets treated as CSIDL_PROGRAM_FILESX86

22 months ago[SHELL32] Fix some test failures
Giannis Adamopoulos [Mon, 19 Feb 2018 01:23:15 +0000 (03:23 +0200)]
[SHELL32] Fix some test failures

22 months ago[REACTOS] Fix a number of Get/SetWindowsLong*Ptr* issues and use GWLP_* instead of...
Timo Kreuzer [Mon, 5 Feb 2018 01:42:14 +0000 (02:42 +0100)]
[REACTOS] Fix a number of Get/SetWindowsLong*Ptr* issues and use GWLP_* instead of GWL_* where appropriate.

22 months ago[WIN32K] Implement NtUserSetWindowLongPtr for 64 bit builds
Timo Kreuzer [Fri, 29 Dec 2017 09:46:19 +0000 (10:46 +0100)]
[WIN32K] Implement NtUserSetWindowLongPtr for 64 bit builds
Also fix return type of NtUserQueryWindow and type of WND::dwUserData and the value for bAnsi in SetWindowLongPtrA

22 months ago[RTL][XDK][KERNERL32_WINETEST] Import wine actctx changes from 3.2-37c98396
Mark Jansen [Mon, 19 Feb 2018 21:23:39 +0000 (22:23 +0100)]
[RTL][XDK][KERNERL32_WINETEST] Import wine actctx changes from 3.2-37c98396
This adds support for reading the trustInfo (requestedExecutionLevel),
and the compatibility (supportedOs) sections.

22 months ago[RAPPS] Various fixes
Mark Jansen [Sun, 18 Feb 2018 14:27:08 +0000 (15:27 +0100)]
[RAPPS] Various fixes
- Ask the user if they want to continue on cab certificate problems
- Fix memory leaks in failure paths
- Properly disable caching

22 months ago[SNDREC32] it-IT.rc: add a missing new line
Giannis Adamopoulos [Mon, 19 Feb 2018 00:03:35 +0000 (02:03 +0200)]
[SNDREC32] it-IT.rc: add a missing new line

22 months ago[SHELL32] CFSFolder: Fix some tests for GetAttributesOf
Giannis Adamopoulos [Sun, 18 Feb 2018 23:59:30 +0000 (01:59 +0200)]
[SHELL32] CFSFolder: Fix some tests for GetAttributesOf

22 months ago[SERVICES] Update a drivers status properly
Eric Kohl [Sun, 18 Feb 2018 17:47:42 +0000 (18:47 +0100)]
[SERVICES] Update a drivers status properly

- ScmUnloadDriver: Handle failed unload properly.
- ScmGetDriverStatus: A driver is running when its driver object was found. Otherwise it has been stopped.
- ScmControlDriver: Check a drivers status before and after unloading.


22 months ago[COMCTL32] Export GetWindowSubclass by name.
Mark Jansen [Sun, 18 Feb 2018 22:04:45 +0000 (23:04 +0100)]
[COMCTL32] Export GetWindowSubclass by name.

22 months ago[NTOSKRNL] Fix mismatching spinlock release in CcPerformReadAhead()
Pierre Schweitzer [Sun, 18 Feb 2018 18:32:08 +0000 (19:32 +0100)]
[NTOSKRNL] Fix mismatching spinlock release in CcPerformReadAhead()

22 months ago[KMTESTS:CC] Addendum to 3fe0e28: use ok_irql.
Pierre Schweitzer [Sun, 18 Feb 2018 13:50:29 +0000 (14:50 +0100)]
[KMTESTS:CC] Addendum to 3fe0e28: use ok_irql.


22 months ago[KMTESTS:IO] Fix a Clang-Cl warning about NameLength 380/head
Serge Gautherie [Sun, 18 Feb 2018 13:06:23 +0000 (14:06 +0100)]
[KMTESTS:IO] Fix a Clang-Cl warning about NameLength

"warning: variable 'NameLength' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]"


22 months ago[KMTESTS:IO] Correctly free name in IoFilesystem's TestAllInformation.
Thomas Faber [Sun, 18 Feb 2018 13:05:10 +0000 (14:05 +0100)]
[KMTESTS:IO] Correctly free name in IoFilesystem's TestAllInformation.

Spotted by Serge Gautherie.

22 months ago[KMTESTS:NPFS] Fix 2 Clang-Cl warnings about ShareAccess
Serge Gautherie [Tue, 13 Feb 2018 12:05:35 +0000 (13:05 +0100)]
[KMTESTS:NPFS] Fix 2 Clang-Cl warnings about ShareAccess

"warning: variable 'ShareAccess' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]"


22 months ago[KMTESTS:CC] Add IRQL tests for CcCopyRead showing that a spinlock is held during...
Pierre Schweitzer [Sun, 18 Feb 2018 12:58:01 +0000 (13:58 +0100)]
[KMTESTS:CC] Add IRQL tests for CcCopyRead showing that a spinlock is held during Cc IO operations.


22 months ago[HAL] Eliminate tail calls from HalpHardwareInterruptLevel. CORE-14076 178/head
Thomas Faber [Sun, 18 Feb 2018 11:51:16 +0000 (12:51 +0100)]
[HAL] Eliminate tail calls from HalpHardwareInterruptLevel. CORE-14076

22 months ago[HAL] Eliminate tail calls from HalpDispatchInterrupt[2]. CORE-14076
Thomas Faber [Sun, 18 Feb 2018 11:50:54 +0000 (12:50 +0100)]
[HAL] Eliminate tail calls from HalpDispatchInterrupt[2]. CORE-14076

22 months ago[HAL] Eliminate tail calls from HalEndSystemInterrupt. CORE-14076
Thomas Faber [Sun, 18 Feb 2018 11:49:24 +0000 (12:49 +0100)]
[HAL] Eliminate tail calls from HalEndSystemInterrupt. CORE-14076

22 months ago[HAL] Create a macro for the HalpEndSoftwareInterrupt to allow reuse. CORE-14076
Thomas Faber [Sun, 18 Feb 2018 11:42:18 +0000 (12:42 +0100)]
[HAL] Create a macro for the HalpEndSoftwareInterrupt to allow reuse. CORE-14076

22 months ago[HAL] Convert HalpEndSoftwareInterrupt2 to fastcall. CORE-14076
Thomas Faber [Sun, 11 Feb 2018 10:33:16 +0000 (11:33 +0100)]
[HAL] Convert HalpEndSoftwareInterrupt2 to fastcall. CORE-14076

22 months ago[RAPPS] Some fixes to our completely broken cert pinning attempt.
Mark Jansen [Sun, 18 Feb 2018 11:56:33 +0000 (12:56 +0100)]
[RAPPS] Some fixes to our completely broken cert pinning attempt.
- We should not open a new connection to request a certificate.
- Update the issuer / subject for the LE certificate.
- User proper types.
- Require all fields that we check to be present.

Without checking the public key or the entire certificate it's still not secure, but we are a step closer.
Dedicated to Joachim Henze

22 months ago[NTOSKRNL] Don't make CcScheduleReadAhead() too noisy
Pierre Schweitzer [Sun, 18 Feb 2018 10:30:51 +0000 (11:30 +0100)]
[NTOSKRNL] Don't make CcScheduleReadAhead() too noisy

22 months ago[WIN32K:NTUSER] Safely handle allocation failure in IntCloneMenu. CORE-14222 366/head
Thomas Faber [Thu, 1 Feb 2018 10:08:14 +0000 (11:08 +0100)]
[WIN32K:NTUSER] Safely handle allocation failure in IntCloneMenu. CORE-14222

22 months ago[WIN32K:NTUSER] Avoid allocating an extra item in IntCloneMenuItems. CORE-14222
Thomas Faber [Thu, 1 Feb 2018 10:07:39 +0000 (11:07 +0100)]
[WIN32K:NTUSER] Avoid allocating an extra item in IntCloneMenuItems. CORE-14222