reactos.git
6 years ago[KMTESTS:MM]
Thomas Faber [Tue, 2 May 2017 09:02:10 +0000 (09:02 +0000)]
[KMTESTS:MM]
Add some more tests for physical memory sections:
- Show that any alignment for SectionOffset/ViewSize is allowed. It will get automatically fixed up to page alignment
- Show that kernel mode can map views beyond the highest physical page, but user mode cannot
CORE-13113

svn path=/trunk/; revision=74446

6 years ago[NTOS:IO]
Thomas Faber [Tue, 2 May 2017 08:18:30 +0000 (08:18 +0000)]
[NTOS:IO]
- Print the error status and message in IoRaiseInformationalHardError
CORE-13174 #resolve

svn path=/trunk/; revision=74445

6 years ago[CMD]
Pierre Schweitzer [Mon, 1 May 2017 21:14:38 +0000 (21:14 +0000)]
[CMD]
Fix and simplify implementation of "IF EXIST":
- Don't make any difference between wildcard search and normal search
- This fixes handling DOS devices search (ie, IF EXIST C:\ReactOS\NUL now works)
- This fixes handling pagefile.sys without requiring specifing rights
- Also fix handling directory search, terminated with a \

CORE-11784

svn path=/trunk/; revision=74444

6 years ago[COMCTL32] Fix use of uninitialized variable.
Giannis Adamopoulos [Mon, 1 May 2017 18:56:03 +0000 (18:56 +0000)]
[COMCTL32] Fix use of uninitialized variable.

svn path=/trunk/; revision=74443

6 years ago[INTL]
Eric Kohl [Mon, 1 May 2017 17:05:31 +0000 (17:05 +0000)]
[INTL]
Added initialization of IDC_CURRENCYGRPNUM.
Patch by Katayama Hirofumi MZ.
CORE-10170

svn path=/trunk/; revision=74442

6 years ago[BROWSEUI] Don't leak the image lists created by CAddressBand and CToolsBand.
Giannis Adamopoulos [Mon, 1 May 2017 13:43:22 +0000 (13:43 +0000)]
[BROWSEUI] Don't leak the image lists created by CAddressBand and CToolsBand.

svn path=/trunk/; revision=74441

6 years ago[COMCTL32] -ImageList: Don't leak the DC returned by saturate_image.
Giannis Adamopoulos [Mon, 1 May 2017 13:40:57 +0000 (13:40 +0000)]
[COMCTL32] -ImageList: Don't leak the DC returned by saturate_image.

svn path=/trunk/; revision=74440

6 years ago[TRANSLATION]
Eric Kohl [Mon, 1 May 2017 13:09:31 +0000 (13:09 +0000)]
[TRANSLATION]
Japanese NLS info.
Patch by Katayama Hirofumi MZ.
CORE-13164

svn path=/trunk/; revision=74439

6 years ago[COMCTL32] -Rebar: Fix a region handle leak when themes are enabled.
Giannis Adamopoulos [Mon, 1 May 2017 12:44:24 +0000 (12:44 +0000)]
[COMCTL32] -Rebar: Fix a region handle leak when themes are enabled.

svn path=/trunk/; revision=74438

6 years ago[EXPLORER] CTrayClockWnd: Fix a leak of font handles. CORE-13155
Giannis Adamopoulos [Mon, 1 May 2017 09:35:03 +0000 (09:35 +0000)]
[EXPLORER] CTrayClockWnd: Fix a leak of font handles. CORE-13155

svn path=/trunk/; revision=74437

6 years ago[NTOS:IO]
Thomas Faber [Sun, 30 Apr 2017 19:24:53 +0000 (19:24 +0000)]
[NTOS:IO]
- Fix some extremely broken casts

svn path=/trunk/; revision=74436

6 years ago[WIN32K]
Thomas Faber [Sun, 30 Apr 2017 18:41:56 +0000 (18:41 +0000)]
[WIN32K]
- Check for null members when cleaning up DCs and brushes. Fixes crashes in some failure cases when running out of GDI handles.
CORE-13155

svn path=/trunk/; revision=74435

6 years ago[INTL]
Eric Kohl [Sun, 30 Apr 2017 15:39:41 +0000 (15:39 +0000)]
[INTL]
- Get rid of alloca, malloc and free.
- Always check the return values of HeapAlloc.
- Rename fUserLocaleChanged to bUserLocaleChanged and fGeoIdChanged to bGeoIdChanged.
- Use WCHAR instead of TCHAR.
- Fix indentation and coding style.
- Remove setupreg.c because it is an unused copy of misc.c.

svn path=/trunk/; revision=74434

6 years ago[LOCALSPL] [SPOOLSV] [WINSPOOL]
Colin Finck [Sun, 30 Apr 2017 15:12:53 +0000 (15:12 +0000)]
[LOCALSPL] [SPOOLSV] [WINSPOOL]
- Refactor the code returning PRINTER_INFO_* yet another time to support both EnumPrinters and GetPrinter calls.
- Implement support for PRINTER_INFO_1 through PRINTER_INFO_9 as well as the mostly unknown PRINTER_INFO_STRESS (level 0) structure and return as much information as we can.
- Implement GetPrinterW / LocalGetPrinter.

The Printers Shell folder in Explorer now shows our "Dummy Printer on LPT1" and we pass all 291 winspool:EnumPrinters API tests :)

svn path=/trunk/; revision=74433

6 years ago[KERNEL32_APITEST]
Pierre Schweitzer [Sun, 30 Apr 2017 11:43:04 +0000 (11:43 +0000)]
[KERNEL32_APITEST]
- Refactor a bit tests, to split more logically tests
- Fix a bug in tests
- Add new tests for MountMgr showing our storage stack doesn't behave as expected

svn path=/trunk/; revision=74432

6 years ago[BOOTDATA]
Eric Kohl [Sat, 29 Apr 2017 17:17:10 +0000 (17:17 +0000)]
[BOOTDATA]
Make service display names and descriptions translatable.
CORE-11855

svn path=/trunk/; revision=74431

6 years ago[CDFS]
Pierre Schweitzer [Fri, 28 Apr 2017 19:32:44 +0000 (19:32 +0000)]
[CDFS]
Fix returned data handling on directory enumeration.
Patch by Giannis Adamopoulos

CORE-13143

svn path=/trunk/; revision=74430

6 years ago[COMCTL32] -Add v5 and v6 manifests in livecd.
Giannis Adamopoulos [Fri, 28 Apr 2017 17:11:46 +0000 (17:11 +0000)]
[COMCTL32] -Add v5 and v6 manifests in livecd.

svn path=/trunk/; revision=74429

6 years ago[NtGDI]
James Tabor [Thu, 27 Apr 2017 19:20:09 +0000 (19:20 +0000)]
[NtGDI]
- Use internal function for setting brush origin. Related to CORE-13110.

svn path=/trunk/; revision=74422

6 years ago[NtGDI]
James Tabor [Thu, 27 Apr 2017 17:53:03 +0000 (17:53 +0000)]
[NtGDI]
- Update DC attributes while internally setting brush origin. Related to CORE-13110.

svn path=/trunk/; revision=74421

6 years ago[WIN32SS] Fix returning an uninitialized variable. Patch by Victor Martinez Calvo...
Mark Jansen [Thu, 27 Apr 2017 15:37:08 +0000 (15:37 +0000)]
[WIN32SS] Fix returning an uninitialized variable. Patch by Victor Martinez Calvo. CID 1341417, CORE-11027 #comment Thanks!

svn path=/trunk/; revision=74420

6 years ago[GDI32]
Thomas Faber [Thu, 27 Apr 2017 08:59:29 +0000 (08:59 +0000)]
[GDI32]
- Fix last error value returned from GdiSelectPen for invalid DCs. Fixes the last test failure in gdi32:gdiobj. Patch by Katayama Hirofumi MZ.
CORE-13132 #resolve

svn path=/trunk/; revision=74419

6 years ago[EVENTVWR]
Thomas Faber [Thu, 27 Apr 2017 00:23:04 +0000 (00:23 +0000)]
[EVENTVWR]
- Avoid two cases of uninitialized variable use in GetEventUserName. Based on a patch by Víctor Martínez Calvo. CID 1401250
CORE-12798 #resolve

svn path=/trunk/; revision=74418

6 years ago[EVENTVWR]
Thomas Faber [Thu, 27 Apr 2017 00:17:08 +0000 (00:17 +0000)]
[EVENTVWR]
- Make user name caching actually work
CORE-12798

svn path=/trunk/; revision=74417

6 years ago[CMD]: Improvements for the CHCP command.
Hermès Bélusca-Maïto [Wed, 26 Apr 2017 22:29:07 +0000 (22:29 +0000)]
[CMD]: Improvements for the CHCP command.
- Display the informative CP-change message on stdout, using the *output* code page (and not the input CP);
- Correctly update the local codepage cache;
- Display the informative CP-change message when the CP change succeeded;
- Add source comments + informative TODO for what remains to be done.

svn path=/trunk/; revision=74416

6 years ago[BOOTDATA]
Eric Kohl [Wed, 26 Apr 2017 21:21:02 +0000 (21:21 +0000)]
[BOOTDATA]
Make the timezone names translatable.
CORE-11855

svn path=/trunk/; revision=74415

6 years ago[KERNEL32]: Add/update localized codepage display names.
Hermès Bélusca-Maïto [Wed, 26 Apr 2017 20:31:54 +0000 (20:31 +0000)]
[KERNEL32]: Add/update localized codepage display names.
- Slightly update the description of CP 28599;
- Add descriptions for CPs 28600, 28603, 28604 and 28606;
- Add CP 856 "OEM - Hebrew PC" (which differs from OEM Hebrew CP 862).
Note that while we also have codepages 424, 878 and 1006, I don't add their description because:
- CP 424 is actually CP 20424 "IBM EBCDIC - Hebrew" on Windows (documented in the resource files);
- CP 878 is actually CP 20866 "Russian - KOI8" on Windows (documented in the resource files);
- CP 1006 seems to be "IBM Arabic" according to Wine, but I don't know its corresponding number on Windows.

svn path=/trunk/; revision=74414

6 years ago[KERNEL32]: Little improvements/fixes for GetCPInfoExW and GetGeoInfoW:
Hermès Bélusca-Maïto [Wed, 26 Apr 2017 17:38:57 +0000 (17:38 +0000)]
[KERNEL32]: Little improvements/fixes for GetCPInfoExW and GetGeoInfoW:
- Rework GetLocalisedText helper such that it looks more like LoadStringW. Also, if the string is not found (either because there is no associated string table, or because its resource length is zero), then return zero.
  Otherwise we return the correct number of characters copied into the user buffer, not counting the NULL terminator.
  This fixes the blank strings showing in the list of codepage user-friendly names in the console properties dialog.
- Simplify the code of NLS_GetGeoFriendlyName: we can directly use the user-provided buffer to retrieve the string.
Addendum to r65157.
CORE-13130 #resolve

svn path=/trunk/; revision=74413

6 years ago[KERNEL32]: Add the Brunei in the list of localized countries.
Hermès Bélusca-Maïto [Wed, 26 Apr 2017 17:10:51 +0000 (17:10 +0000)]
[KERNEL32]: Add the Brunei in the list of localized countries.
Translators, please localize the name!

svn path=/trunk/; revision=74412

6 years ago[UXTHEME] -Fix some resource leaks.
Giannis Adamopoulos [Wed, 26 Apr 2017 13:55:19 +0000 (13:55 +0000)]
[UXTHEME] -Fix some resource leaks.

svn path=/trunk/; revision=74411

6 years ago[COMMAND]: Disable COMMAND.COM debugging messages by default.
Hermès Bélusca-Maïto [Wed, 26 Apr 2017 13:41:43 +0000 (13:41 +0000)]
[COMMAND]: Disable COMMAND.COM debugging messages by default.
Disable again this #define if you want to get the dbg messages back.
CORE-10710

svn path=/trunk/; revision=74410

6 years ago[USBOHCI]
Thomas Faber [Wed, 26 Apr 2017 10:54:34 +0000 (10:54 +0000)]
[USBOHCI]
- Not building before committing is also a hack
CORE-9224

svn path=/trunk/; revision=74409

6 years ago[USBEHCI][USBOHCI]
Thomas Faber [Wed, 26 Apr 2017 10:53:32 +0000 (10:53 +0000)]
[USBEHCI][USBOHCI]
- Touch the virtual address of DMA buffers before calling MmGetPhysicalAddress on them. This ensures page directories are correctly set up for the current process context, and fixes random DMA operation failures ("MM:MmGetPhysicalAddressFailed"). This is not a hack -- using MmGetPhysicalAddress for DMA in the first place is.
CORE-9224 #resolve

svn path=/trunk/; revision=74408

6 years ago[UXTHEME] -Implement the tab background texture. NOTE: A hack was used to go around...
Giannis Adamopoulos [Wed, 26 Apr 2017 09:28:35 +0000 (09:28 +0000)]
[UXTHEME] -Implement the tab background texture. NOTE: A hack was used to go around the problem that SetBrushOrgEx doesn't really work. CORE-12978

svn path=/trunk/; revision=74407

6 years ago[COMCTL32]
Giannis Adamopoulos [Tue, 25 Apr 2017 11:19:22 +0000 (11:19 +0000)]
[COMCTL32]
- Button, Trakbar: Send WM_CTLCOLORBTN or WM_CTLCOLORSTATIC and use their return value to paint the control despite the fact that DrawThemeParentBackground was called as well.
Part of the fix for CORE-12978

svn path=/trunk/; revision=74406

6 years ago[CONSOLE.CPL]: Simplify some parts of font.c code.
Hermès Bélusca-Maïto [Mon, 24 Apr 2017 17:01:07 +0000 (17:01 +0000)]
[CONSOLE.CPL]: Simplify some parts of font.c code.
- Use a helper function "AddFontToList" to add font names into the font list;
- Use string-safe functions where needed.

svn path=/trunk/; revision=74405

6 years ago[WIN32K:ENG]
Thomas Faber [Mon, 24 Apr 2017 16:28:04 +0000 (16:28 +0000)]
[WIN32K:ENG]
- In PDEVOBJ_vRefreshModeList, restore the current mode pointer, ppdev->pdmwDev, to a valid value.
CORE-13097 #resolve

svn path=/trunk/; revision=74404

6 years ago[USER32]
Thomas Faber [Mon, 24 Apr 2017 15:04:00 +0000 (15:04 +0000)]
[USER32]
Fix heap corruption in EnumDisplaySettingsExA/W:
- Do not overwrite the user-provided buffer size in dmDriverExtra
- Fix broken pointer arithmetic
CORE-13097

svn path=/trunk/; revision=74403

6 years ago[ACCESS]: Fix french el-typo, noticed by Kyle Katarn. Thanks!
Hermès Bélusca-Maïto [Mon, 24 Apr 2017 11:17:10 +0000 (11:17 +0000)]
[ACCESS]: Fix french el-typo, noticed by Kyle Katarn. Thanks!
CORE-12482

svn path=/trunk/; revision=74402

6 years ago[WININET]
Thomas Faber [Mon, 24 Apr 2017 10:07:39 +0000 (10:07 +0000)]
[WININET]
- Silence Firefox/Safari debug spam
CORE-12853 CORE-12128 CORE-11135

svn path=/trunk/; revision=74401

6 years ago[NTOS:MM]
Thomas Faber [Mon, 24 Apr 2017 09:45:03 +0000 (09:45 +0000)]
[NTOS:MM]
- In MiFlushTbAndCapture, only print a fixme if we actually need to do something.
CORE-12074 #resolve

svn path=/trunk/; revision=74400

6 years ago[CONSOLE]
Thomas Faber [Mon, 24 Apr 2017 07:19:41 +0000 (07:19 +0000)]
[CONSOLE]
- Fix build
CORE-12451

svn path=/trunk/; revision=74399

6 years ago[CONSOLE.CPL]: Addendum to r74397: Fix a cast.
Hermès Bélusca-Maïto [Mon, 24 Apr 2017 00:32:10 +0000 (00:32 +0000)]
[CONSOLE.CPL]: Addendum to r74397: Fix a cast.

svn path=/trunk/; revision=74398

6 years ago[CONSOLE.CPL]: Add a list of available code pages in the console properties dialog.
Hermès Bélusca-Maïto [Mon, 24 Apr 2017 00:24:34 +0000 (00:24 +0000)]
[CONSOLE.CPL]: Add a list of available code pages in the console properties dialog.
Display a list of available code pages, as done on Windows (NT/2k/2k3/Vista/7/8, when a CJK language is selected, and as always done on Windows 10 for all languages).
But contrary to Windows, do not limit this list to only CJK + CP-437 codepages, but list *all* the available CPs, retrieved from the registry. These CPs are also those available when using the "chcp" or "mode con cp" commands.
And contrary to Windows (where this is done only for the general console properties), always allow the user to view or change the code page even from the console properties dialog.

[CONSRV]: Support changing the current code page from the console properties dialog.

CORE-12451

svn path=/trunk/; revision=74397

6 years ago[SYSETUP]
Eric Kohl [Sun, 23 Apr 2017 21:56:36 +0000 (21:56 +0000)]
[SYSETUP]
Update the shown date and time on the Date and Time page until the user changes the date or time.
CORE-11896

svn path=/trunk/; revision=74396

6 years ago[CRYPTNET]
Thomas Faber [Sun, 23 Apr 2017 17:59:25 +0000 (17:59 +0000)]
[CRYPTNET]
- Fix ROS-Diff. Spotted by CRLF.
CORE-13117 #resolve

svn path=/trunk/; revision=74395

6 years ago[SERVMAN]
Eric Kohl [Sun, 23 Apr 2017 17:39:26 +0000 (17:39 +0000)]
[SERVMAN]
- Make a copy of the service list where service and display name strings are separately allocated. We need this to update the service names rather than reload the list when the display name is changed.
- Write the display name, description or binary path to the registry when the user changed them.
- Disable the Edit button after it has been clicked.
- Do not add the service name to the argument vector in the call to StartServiceW. Services.exe already add the service name to the vector.
CORE-12743

svn path=/trunk/; revision=74394

6 years ago[LOCALSPL]
Colin Finck [Sun, 23 Apr 2017 15:00:26 +0000 (15:00 +0000)]
[LOCALSPL]
Implement all corner cases of handling the Name parameter in EnumPrinters. This can be done in a common way for all levels.
Fixes more tests.

svn path=/trunk/; revision=74393

6 years ago[NTOSKRNL] CcPurgeCacheSection: Check if SharedCacheMap is NULL. Change suggested...
Giannis Adamopoulos [Sun, 23 Apr 2017 11:12:48 +0000 (11:12 +0000)]
[NTOSKRNL] CcPurgeCacheSection: Check if SharedCacheMap is NULL. Change suggested by ThFabba. CORE-13115

svn path=/trunk/; revision=74392

6 years ago[NTOS:MM]
Thomas Faber [Sun, 23 Apr 2017 09:38:45 +0000 (09:38 +0000)]
[NTOS:MM]
- In NtMapViewOfSection, check for address alignment after validating the handles. This fixes the tests from the previous commit, but is also necessary because information about the section object is necessary to avoid the alignment checks for physical memory sections.
CORE-13113

svn path=/trunk/; revision=74391

6 years ago[KMTESTS:MM]
Thomas Faber [Sun, 23 Apr 2017 08:10:46 +0000 (08:10 +0000)]
[KMTESTS:MM]
- Show that NtMapViewOfSection validates section and process handles before checking base address alignment
CORE-13113

svn path=/trunk/; revision=74390

6 years ago[NTOS:MM]
Thomas Faber [Sun, 23 Apr 2017 07:24:44 +0000 (07:24 +0000)]
[NTOS:MM]
- Check for ROS section object before accessing the AllocationAttributes member in NtMapViewOfSection, since ARM3 sections use a different structure.
CORE-13113

svn path=/trunk/; revision=74389

6 years ago[ACPPAGE] Implement custom compatibility mode selection + Expand paths CORE-10375
Mark Jansen [Sat, 22 Apr 2017 17:11:52 +0000 (17:11 +0000)]
[ACPPAGE] Implement custom compatibility mode selection + Expand paths CORE-10375

svn path=/trunk/; revision=74388

6 years ago[ACPPAGE] Update translations based on slayer. CORE-10375
Mark Jansen [Sat, 22 Apr 2017 15:20:25 +0000 (15:20 +0000)]
[ACPPAGE] Update translations based on slayer. CORE-10375
Translators, please check your language, some text was changed!

svn path=/trunk/; revision=74387

6 years ago[KMTESTS:MM]
Thomas Faber [Fri, 21 Apr 2017 08:08:57 +0000 (08:08 +0000)]
[KMTESTS:MM]
- Enable MEM_RESERVED test in SimpleErrorChecks() since it no longer asserts. Patch by Serge Gautherie.
ROSTESTS-109 #resolve

svn path=/trunk/; revision=74386

6 years ago[INPUT.CPL]
Hermès Bélusca-Maïto [Fri, 21 Apr 2017 00:22:39 +0000 (00:22 +0000)]
[INPUT.CPL]
- Remove an unneeded header inclusion;
- Fix a sizeof invocation;
- RegEnumKeyExW and RegEnumValueW take their fourth parameter (size of key / value name, resp.) as a size in number of *characters* (and not in number of bytes);
- Add a missing RegCloseKey call in LocaleList_Create.

svn path=/trunk/; revision=74385

6 years ago[NTOS:KE]
Thomas Faber [Thu, 20 Apr 2017 17:36:40 +0000 (17:36 +0000)]
[NTOS:KE]
- Reset DebugDpcTime before calling timer DPC routines. Avoids spurious "DPC routine > 1 sec" break-ins.

svn path=/trunk/; revision=74384

6 years ago[NTOS:MM]
Thomas Faber [Thu, 20 Apr 2017 08:58:45 +0000 (08:58 +0000)]
[NTOS:MM]
- Avoid reference leaks in failure cases of MmCreateCacheSection
CORE-6931

svn path=/trunk/; revision=74383

6 years ago[VGADDI]
Thomas Faber [Thu, 20 Apr 2017 07:30:01 +0000 (07:30 +0000)]
[VGADDI]
- Fix buffer overflow in DIB_BltFromVGA. A byte fits two pixels.

svn path=/trunk/; revision=74382

6 years ago[TRANSLATION]
Eric Kohl [Wed, 19 Apr 2017 22:10:00 +0000 (22:10 +0000)]
[TRANSLATION]
Romanian resources maintenance
Patch by Ștefan Fulea.
CORE-13099

svn path=/trunk/; revision=74381

6 years ago[SHELL32] Fix for BuildPathsList, this solves some problems showing while copying...
Mark Jansen [Wed, 19 Apr 2017 18:45:33 +0000 (18:45 +0000)]
[SHELL32] Fix for BuildPathsList, this solves some problems showing while copying folders. Patch by 'Gleb'. CORE-8434

svn path=/trunk/; revision=74380

6 years ago[SHELL32] -CDesktopBrowser: Clone the pidl passed to SHOpenNewFrame as it will later...
Giannis Adamopoulos [Wed, 19 Apr 2017 16:24:59 +0000 (16:24 +0000)]
[SHELL32] -CDesktopBrowser: Clone the pidl passed to SHOpenNewFrame as it will later free it itself. This was masked by a hacky cast.

svn path=/trunk/; revision=74379

6 years ago[NTOS:MM]
Thomas Faber [Wed, 19 Apr 2017 14:40:53 +0000 (14:40 +0000)]
[NTOS:MM]
- Never use special pool for prototype PTEs. Avoids "(PointerPte >= (PMMPTE)MmPagedPoolStart) && (PointerPte <= (PMMPTE)MmPagedPoolEnd)" assertion failure in MiDecrementShareCount.
CORE-11474

svn path=/trunk/; revision=74378

6 years ago[KERNEL32_WINETEST]
Thomas Faber [Wed, 19 Apr 2017 14:08:51 +0000 (14:08 +0000)]
[KERNEL32_WINETEST]
- Improve the test_GetVolumePathNamesForVolumeNameW hack to avoid a stack buffer underrun.
CORE-11474

svn path=/trunk/; revision=74377

6 years ago[OPENGL32]
Thomas Faber [Wed, 19 Apr 2017 13:16:30 +0000 (13:16 +0000)]
[OPENGL32]
- Fix uninitialized variable use in IntGetIcdData
CORE-11474

svn path=/trunk/; revision=74376

6 years ago[KMTESTS:OB]
Thomas Faber [Wed, 19 Apr 2017 12:21:57 +0000 (12:21 +0000)]
[KMTESTS:OB]
- After ObCreateObject+ObInsertObject a handle close is enough to destroy the object, so do not dereference it in addition. Fixes use after free.
CORE-11474

svn path=/trunk/; revision=74375

6 years ago[KMTESTS:NPFS]
Thomas Faber [Wed, 19 Apr 2017 11:46:34 +0000 (11:46 +0000)]
[KMTESTS:NPFS]
- Remove tests that cause pool buffer overflows. NtQueryVolumeInformationFile does not validate buffer length for kernel mode callers, so passing an invalid length is not a good test.
CORE-11474

svn path=/trunk/; revision=74374

6 years ago[WS2_32][DNSAPI]
Thomas Faber [Wed, 19 Apr 2017 11:14:18 +0000 (11:14 +0000)]
[WS2_32][DNSAPI]
- Avoid stack buffer overflow in ParseV4Address
CORE-11474

svn path=/trunk/; revision=74373

6 years ago[GDI32]
Thomas Faber [Wed, 19 Apr 2017 10:33:58 +0000 (10:33 +0000)]
[GDI32]
- Use the number of WCHARs, not the number of ANSI chars in GetCharABCWidthsA. Fixes stack corruption when running gdi32_winetest:font
CORE-11474

svn path=/trunk/; revision=74372

7 years ago[VARIOUS]
Eric Kohl [Tue, 18 Apr 2017 17:47:08 +0000 (17:47 +0000)]
[VARIOUS]
Updating Turkish Translation
Patch by Erdem Ersoy.
CORE-12362

svn path=/trunk/; revision=74371

7 years ago[USER32]
Thomas Faber [Tue, 18 Apr 2017 14:31:33 +0000 (14:31 +0000)]
[USER32]
- In RealSystemParametersInfoA/SPI_GETDESKWALLPAPER, write the ansi wallpaper path directly into the user's buffer instead of using an allocation (and overrunning it). Fixes crash when running user32_winetest:sysparams with DPH.
Tangential to CORE-13097

svn path=/trunk/; revision=74370

7 years ago[USER32] -CallWindowProc: Call PreWndProc and PostWndProc hooks for dialog messages...
Giannis Adamopoulos [Tue, 18 Apr 2017 12:35:57 +0000 (12:35 +0000)]
[USER32] -CallWindowProc: Call PreWndProc and PostWndProc hooks for dialog messages if the message is not hooked for PreDefDlgProc and PostDefDlgProc.

svn path=/trunk/; revision=74369

7 years ago[CONCFG]: Addendum for r74366: Initialize the console settings information codepage...
Hermès Bélusca-Maïto [Mon, 17 Apr 2017 23:31:48 +0000 (23:31 +0000)]
[CONCFG]: Addendum for r74366: Initialize the console settings information codepage with the current OEM codepage, and read the optional console "CodePage" DWORD registry setting.
CORE-12451

svn path=/trunk/; revision=74368

7 years ago[CONCFG]: Use 'Success' boolean variable instead of an obscure 'RetVal'.
Hermès Bélusca-Maïto [Mon, 17 Apr 2017 23:28:41 +0000 (23:28 +0000)]
[CONCFG]: Use 'Success' boolean variable instead of an obscure 'RetVal'.

svn path=/trunk/; revision=74367

7 years ago[CONSOLE.CPL]: Paint the text samples using the correct character set (derived from...
Hermès Bélusca-Maïto [Mon, 17 Apr 2017 23:26:07 +0000 (23:26 +0000)]
[CONSOLE.CPL]: Paint the text samples using the correct character set (derived from the current code page).
This e.g. fixes display for the backslash symbol in CJK languages (that should appear as the Chinese "yuan" / Japanese "yen" currency symbol ¥, or the Korean "won" currency symbol ₩).
CORE-12451

svn path=/trunk/; revision=74366

7 years ago[CONSOLE.CPL]: Add support for Asian fonts & CJK codepage in the console properties...
Hermès Bélusca-Maïto [Mon, 17 Apr 2017 23:21:13 +0000 (23:21 +0000)]
[CONSOLE.CPL]: Add support for Asian fonts & CJK codepage in the console properties dialog.
Based on a patch by Katayama Hirofumi MZ.
CORE-12451

svn path=/trunk/; revision=74365

7 years ago[AT]
Eric Kohl [Mon, 17 Apr 2017 22:28:42 +0000 (22:28 +0000)]
[AT]
Applied hotfix for russian translation.
Patch by Sergey Stopkin.
CORE-12961

svn path=/trunk/; revision=74364

7 years ago[NEWDEV]
Eric Kohl [Mon, 17 Apr 2017 22:20:44 +0000 (22:20 +0000)]
[NEWDEV]
When the driver installation fails, set the CONFIGFLAG_FAILEDINSTALL flag only if the user checked the 'Do not show this dialog anymore' checkbox.
CORE-13095

svn path=/trunk/; revision=74363

7 years ago[NETID]
Eric Kohl [Mon, 17 Apr 2017 21:05:02 +0000 (21:05 +0000)]
[NETID]
Load, display and store the computer description.
Patch by Grzegorz Araminowicz.
- Moved most of the code into separate functions and got rid of its deeply nested structure.
- Added some notification code, so that the Apply button gets enabled when the user changes the description.
CORE-12337

svn path=/trunk/; revision=74362

7 years ago[KMTESTS:MM]
Thomas Faber [Mon, 17 Apr 2017 20:37:26 +0000 (20:37 +0000)]
[KMTESTS:MM]
- Add some missing newlines and skip()s

svn path=/trunk/; revision=74361

7 years ago[WIN32K]
Thomas Faber [Mon, 17 Apr 2017 20:25:55 +0000 (20:25 +0000)]
[WIN32K]
Fix automatic resolution change when resizing the VirtualBox window. Based on a patch by Ismael Ferreras Morezuelas.
- Provide a function, PDEVOBJ_vRefreshModeList, to reload the list of display modes
- Call PDEVOBJ_vRefreshModeList from UserEnumDisplaySettings to get an updated list of modes each time
CORE-6742 #resolve

svn path=/trunk/; revision=74360

7 years ago[WIN32K:ENG]
Thomas Faber [Mon, 17 Apr 2017 19:44:32 +0000 (19:44 +0000)]
[WIN32K:ENG]
- Split populating the display mode list out from EngpRegisterGraphicsDevice, into its own function, EngpPopulateDeviceModeList. Based on a patch by Ismael Ferreras Morezuelas.
CORE-6742

svn path=/trunk/; revision=74359

7 years ago[NTOS:CC]
Thomas Faber [Mon, 17 Apr 2017 18:37:12 +0000 (18:37 +0000)]
[NTOS:CC]
- Respect the TruncateSize parameter in CcUninitializeCacheMap. Avoids "freeing dirty VACB" messages for cache views beyond the end of the file.
CORE-12893 #resolve

svn path=/trunk/; revision=74358

7 years ago[NTOS:CC]
Thomas Faber [Mon, 17 Apr 2017 18:13:17 +0000 (18:13 +0000)]
[NTOS:CC]
- Simplify CcSetFileSizes by using CcPurgeCacheSection
CORE-12893

svn path=/trunk/; revision=74357

7 years ago[CONSOLE.CPL]: Code formatting only (in preparation of a subsequent commit).
Hermès Bélusca-Maïto [Mon, 17 Apr 2017 17:45:18 +0000 (17:45 +0000)]
[CONSOLE.CPL]: Code formatting only (in preparation of a subsequent commit).

svn path=/trunk/; revision=74356

7 years ago[NTOS:CC]
Thomas Faber [Mon, 17 Apr 2017 17:29:10 +0000 (17:29 +0000)]
[NTOS:CC]
- Implement CcPurgeCacheSection
CORE-12893

svn path=/trunk/; revision=74355

7 years ago[FASTFAT]
Thomas Faber [Mon, 17 Apr 2017 16:54:28 +0000 (16:54 +0000)]
[FASTFAT]
- On rename/move, flush parent directory data from cache instead of purging it.
CORE-12893

svn path=/trunk/; revision=74354

7 years ago[WIN32SS] Add full name support in FontFamilyFillInfo. Patch by Katayama Hirofumi...
Mark Jansen [Mon, 17 Apr 2017 16:08:38 +0000 (16:08 +0000)]
[WIN32SS] Add full name support in FontFamilyFillInfo. Patch by Katayama Hirofumi MZ. CORE-10876

svn path=/trunk/; revision=74353

7 years ago[WIN32SS] Add extra logging to failed SURFACE_AllocSurface calls. CORE-13036
Mark Jansen [Mon, 17 Apr 2017 15:48:56 +0000 (15:48 +0000)]
[WIN32SS] Add extra logging to failed SURFACE_AllocSurface calls. CORE-13036

svn path=/trunk/; revision=74352

7 years ago[ISOHYBRID]
Colin Finck [Mon, 17 Apr 2017 13:49:46 +0000 (13:49 +0000)]
[ISOHYBRID]
Don't include inttypes.h, which isn't available on MSVC < 2013. Add the 4 needed typedefs to reactos_support_code.h instead.
Fixes CORE-13031

svn path=/trunk/; revision=74351

7 years ago[WINSPOOL]
Colin Finck [Mon, 17 Apr 2017 13:40:51 +0000 (13:40 +0000)]
[WINSPOOL]
Added tests for some more basic and newly discovered corner cases of EnumPrintersW.

svn path=/trunk/; revision=74350

7 years ago[SERVMAN]
Eric Kohl [Mon, 17 Apr 2017 12:48:51 +0000 (12:48 +0000)]
[SERVMAN]
Track changes to the general and and recovery pages.
CORE-12743

svn path=/trunk/; revision=74349

7 years agoAvoid attempts to reinstall a driver on reboot when a previous attempt has already...
Eric Kohl [Mon, 17 Apr 2017 11:34:08 +0000 (11:34 +0000)]
Avoid attempts to reinstall a driver on reboot when a previous attempt has already failed.

[NEWDEV]
Set the CONFIGFLAG_FAILEDINSTALL flag in the new hardware wizards welcome page and remove it only when the driver was successfully installed.

[UMPNPMGR]
Do not invoke the device installer if the devices CONFIGFLAG_FAILEDINSTALL flag is set.

svn path=/trunk/; revision=74348

7 years ago[BROWSEUI] Port some IAutoComplete changes from wine + fix a memory leak. This allows...
Mark Jansen [Mon, 17 Apr 2017 09:35:08 +0000 (09:35 +0000)]
[BROWSEUI] Port some IAutoComplete changes from wine + fix a memory leak. This allows the dropdown to show with ACO_AUTOSUGGEST and an empty input.

svn path=/trunk/; revision=74347

7 years ago[BROWSEUI] -Remove a couple of lines that shouldn't have been committed.
Giannis Adamopoulos [Mon, 17 Apr 2017 09:15:45 +0000 (09:15 +0000)]
[BROWSEUI] -Remove a couple of lines that shouldn't have been committed.

svn path=/trunk/; revision=74346

7 years ago[BROWSEUI] -CBandSiteMenu: Add preliminary support for adding and removing bands...
Giannis Adamopoulos [Mon, 17 Apr 2017 09:02:49 +0000 (09:02 +0000)]
[BROWSEUI] -CBandSiteMenu: Add preliminary support for adding and removing bands in the taskbar. If a class was registered in the CATID_DeskBand category it will be shown in the menu and selecting it can add it or remove it from the taskbar. Showing the two built in ones (quick launch and desktop) is not implemented yet.

svn path=/trunk/; revision=74345

7 years ago[WINMINE]
Eric Kohl [Sun, 16 Apr 2017 22:42:38 +0000 (22:42 +0000)]
[WINMINE]
Fix vertical aligment of the digits in mines.bmp.
Patch by Andre Semaki.
CORE-12777

svn path=/trunk/; revision=74344

7 years ago[SHELL]
Eric Kohl [Sun, 16 Apr 2017 22:00:46 +0000 (22:00 +0000)]
[SHELL]
Update russian translation.
Patch by amber.
CORE-12525

svn path=/trunk/; revision=74343

7 years ago[MEDIA/RAPPS]
Eric Kohl [Sun, 16 Apr 2017 21:57:41 +0000 (21:57 +0000)]
[MEDIA/RAPPS]
Update russian translation.
Patch by amber.
CORE-12525

svn path=/trunk/; revision=74342

7 years ago[OPENGLCFG]
Eric Kohl [Sun, 16 Apr 2017 21:53:37 +0000 (21:53 +0000)]
[OPENGLCFG]
Add russain translation.
Patch by amber.
CORE-12525

svn path=/trunk/; revision=74341