reactos.git
2 months ago[NTUSER] Release WinSta->spklList at IntWinStaObjectDelete (#4593)
Katayama Hirofumi MZ [Tue, 2 Aug 2022 01:46:37 +0000 (10:46 +0900)]
[NTUSER] Release WinSta->spklList at IntWinStaObjectDelete (#4593)

Call UserAssignmentUnlock((PVOID*)&WinSta->spklList); in IntWinStaObjectDelete function.
CORE-11700

2 months ago[NTUSER] Improve WINSTATION_OBJECT compatibility (#4591)
Katayama Hirofumi MZ [Sun, 31 Jul 2022 01:25:07 +0000 (10:25 +0900)]
[NTUSER] Improve WINSTATION_OBJECT compatibility (#4591)

- Modify WINSTATION_OBJECT structure with inserting struct tagKL *spklList member.
- Add some C_ASSERT(offsetof(WINSTATION_OBJECT, ...) == ...);.
CORE-18252

2 months ago[SECLOGON][ADVAPI] CreateProcessWithLogonW: Return process information to the caller
Eric Kohl [Sat, 23 Jul 2022 23:08:13 +0000 (01:08 +0200)]
[SECLOGON][ADVAPI] CreateProcessWithLogonW: Return process information to the caller

2 months ago[IMM32] Follow-up of #4588 (ffbdb7d)
Katayama Hirofumi MZ [Sat, 23 Jul 2022 03:42:54 +0000 (12:42 +0900)]
[IMM32] Follow-up of #4588 (ffbdb7d)

CORE-11700

2 months ago[IMM32][USER32] ImmPutImeMenuItemsIntoMappedFile (#4588)
Katayama Hirofumi MZ [Fri, 22 Jul 2022 20:58:17 +0000 (05:58 +0900)]
[IMM32][USER32] ImmPutImeMenuItemsIntoMappedFile (#4588)

Implement inter-process menu item retrieving.
CORE-11700

2 months ago[NTOS:KDBG] Nuke KdbEnter and KdbpCliModuleLoaded
Timo Kreuzer [Wed, 20 Jul 2022 18:31:57 +0000 (20:31 +0200)]
[NTOS:KDBG] Nuke KdbEnter and KdbpCliModuleLoaded

They are not used anymore. Also clean up some obsolete prototypes.

2 months ago[SETUP] Don't default to MP builds, when KDBG is enabled
Timo Kreuzer [Sun, 17 Jul 2022 17:31:38 +0000 (19:31 +0200)]
[SETUP] Don't default to MP builds, when KDBG is enabled

The reason is that KDBG and the MP kernel don't like each other much and crash hard, causing VBox to shut down.

2 months ago[NTOS:KDBG] Add KdbpPrintUnicodeString
Timo Kreuzer [Sun, 17 Jul 2022 17:17:18 +0000 (19:17 +0200)]
[NTOS:KDBG] Add KdbpPrintUnicodeString

Calling normal unicode functions is not allowed at IRQL > APC_LEVEL, so calling _vsnprintf with unicode parameters from KDBG is invalid.

2 months ago[KDBG] Fix x64 KDBG
Timo Kreuzer [Sun, 26 Jan 2020 17:59:05 +0000 (18:59 +0100)]
[KDBG] Fix x64 KDBG

2 months ago[NDK] Add missing x64 unwind definitions
Timo Kreuzer [Tue, 19 Jul 2022 06:05:31 +0000 (08:05 +0200)]
[NDK] Add missing x64 unwind definitions

2 months ago[CMLIB] Don't redefine PAGED_CODE() to nothing in cmlib.h except for cmlib_host
Timo Kreuzer [Sun, 17 Jul 2022 09:34:27 +0000 (11:34 +0200)]
[CMLIB] Don't redefine PAGED_CODE() to nothing in cmlib.h except for cmlib_host

This header is included by ntoskrnl which effectively disabled all PAGED_CODE checks since 2015. Thanks Alex.
Instead define _BLDR_ when building cmlib, which will avoid trying to import KeGetCurrentIrql()

2 months ago[MAIN] Improve mouse UI icons (#4583)
Katayama Hirofumi MZ [Tue, 19 Jul 2022 11:50:54 +0000 (20:50 +0900)]
[MAIN] Improve mouse UI icons (#4583)

- Replace IDI_MOUSE_SPEED icon.
- Add and use IDI_MOUSE_HIDE icon for "Hide pointer while typing".
CORE-10728

2 months ago[SYSDM] Don't use magic number (ja-JP)
Katayama Hirofumi MZ [Tue, 19 Jul 2022 04:05:07 +0000 (13:05 +0900)]
[SYSDM] Don't use magic number (ja-JP)

2 months ago[EXPLORER] Fix assertion failure on start button (#4581)
Katayama Hirofumi MZ [Mon, 18 Jul 2022 13:20:25 +0000 (22:20 +0900)]
[EXPLORER] Fix assertion failure on start button (#4581)

CORE-18024

2 months ago[CONSOLE] Improve Japanese translation (ja-JP)
Katayama Hirofumi MZ [Mon, 18 Jul 2022 12:46:15 +0000 (21:46 +0900)]
[CONSOLE] Improve Japanese translation (ja-JP)

2 months ago[APPWIZ] Improve Japanese translation (ja-JP)
Katayama Hirofumi MZ [Mon, 18 Jul 2022 12:44:25 +0000 (21:44 +0900)]
[APPWIZ] Improve Japanese translation (ja-JP)

2 months ago[INTL] Improve Japanese translation (ja-JP)
Katayama Hirofumi MZ [Mon, 18 Jul 2022 12:39:29 +0000 (21:39 +0900)]
[INTL] Improve Japanese translation (ja-JP)

2 months ago[SYSDM] Improve Japanese translation (ja-JP)
Katayama Hirofumi MZ [Mon, 18 Jul 2022 12:01:05 +0000 (21:01 +0900)]
[SYSDM] Improve Japanese translation (ja-JP)

2 months ago[CRT] Add round and roundf and add it to msvcrtex to make clang v14 happy
Timo Kreuzer [Fri, 15 Jul 2022 16:51:20 +0000 (18:51 +0200)]
[CRT] Add round and roundf and add it to msvcrtex to make clang v14 happy

2 months ago[GITHUB] Fix LLVM version for the clang-cl build (#4578)
Victor Perevertkin [Sat, 16 Jul 2022 13:10:56 +0000 (16:10 +0300)]
[GITHUB] Fix LLVM version for the clang-cl build (#4578)

2 months ago[NTOS:KE/x64] Handle user faults in KiGeneralProtectionFaultHandler
Timo Kreuzer [Sat, 26 Jun 2021 16:49:47 +0000 (18:49 +0200)]
[NTOS:KE/x64] Handle user faults in KiGeneralProtectionFaultHandler

2 months ago[NTDLL_APITEST] Add test for some user mode exceptions
Timo Kreuzer [Sat, 26 Oct 2019 14:44:57 +0000 (16:44 +0200)]
[NTDLL_APITEST] Add test for some user mode exceptions

2 months ago[CMLIB][NTOS:CM] Deduplicate other common definitions between CMLIB and the NTOS CM
George Bișoc [Sun, 10 Jul 2022 12:35:53 +0000 (14:35 +0200)]
[CMLIB][NTOS:CM] Deduplicate other common definitions between CMLIB and the NTOS CM

Addendum to commit 8c2454e (r70605). Credits and courtesy go to Hermès BÉLUSCA - MAÏTO.

CORE-10802 CORE-10793

2 months ago[NTOS:MM] Fix VADs being inserted even though the quota would exceed
Tuur Martens [Wed, 29 Jun 2022 08:49:05 +0000 (10:49 +0200)]
[NTOS:MM] Fix VADs being inserted even though the quota would exceed

Since we were charging the pool quota after the VAD insertion,
if the quota charge failed, the VAD would still have been inserted.
This commit attempts to resolve this issue by charging quota
before inserting the VAD thus allowing the quota charge to fail early.

Addendum to 884356a0. CORE-18028

3 months ago[NTOSKRNL] Fix a bug in MiDeleteVirtualAddresses
Timo Kreuzer [Sat, 2 Jul 2022 15:46:41 +0000 (17:46 +0200)]
[NTOSKRNL] Fix a bug in MiDeleteVirtualAddresses

When a PDE gets empty, we skip the address to the next PDE boundary, which might introduce an AddressGap, which wasn't handled before.

3 months ago[DISKPART] Fix magic values in CreateLogicalPartition() and CreatePrimaryPartition()
Eric Kohl [Sun, 3 Jul 2022 12:09:35 +0000 (14:09 +0200)]
[DISKPART] Fix magic values in CreateLogicalPartition() and CreatePrimaryPartition()

3 months ago[WIN32K:ENG] EngAlphaBlend(): Release EnterLeaveSource on error (#4560)
Serge Gautherie [Sat, 2 Jul 2022 09:30:03 +0000 (11:30 +0200)]
[WIN32K:ENG] EngAlphaBlend(): Release EnterLeaveSource on error (#4560)

Part of CORE-11156

Co-authored-by: Carlo Bramini <carlo.bramix@libero.it>
3 months ago[EXPLORER] Fix taskbar icon display problem (#4538)
Thamatip Chitpong [Thu, 30 Jun 2022 13:10:47 +0000 (20:10 +0700)]
[EXPLORER] Fix taskbar icon display problem (#4538)

- Use SMTO_NOTIMEOUTIFNOTHUNG to get the icon with least timeout.
- Replace GCL_* consts with GCLP_* since we're using GetClassLongPtr.

Now the icon is correctly displayed for control panel applets.

CORE-18137

3 months ago[NTOS:SE] Properly handle dynamic counters in token 4555/head
George Bișoc [Tue, 21 Jun 2022 20:02:22 +0000 (22:02 +0200)]
[NTOS:SE] Properly handle dynamic counters in token

On current master, ReactOS faces these problems:

- ObCreateObject charges both paged and non paged pool a size of TOKEN structure, not the actual dynamic contents of WHAT IS inside a token. For paged pool charge the size is that of the dynamic area (primary group + default DACL if any). This is basically what DynamicCharged is for.
For the non paged pool charge, the actual charge is that of TOKEN structure upon creation. On duplication and filtering however, the paged pool charge size is that of the inherited dynamic charged space from an existing token whereas the non paged pool size is that of the calculated token body
length for the new duplicated/filtered token. On current master, we're literally cheating the kernel by charging the wrong amount of quota not taking into account the dynamic contents which they come from UM.

- Both DynamicCharged and DynamicAvailable are not fully handled (DynamicAvailable is pretty much poorly handled with some cases still to be taking into account). DynamicCharged is barely handled, like at all.

- As a result of these two points above, NtSetInformationToken doesn't check when the caller wants to set up a new default token DACL or primary group if the newly DACL or the said group exceeds the dynamic charged boundary. So what happens is that I'm going to act like a smug bastard fat politician and whack
the primary group and DACL of an token however I want to, because why in the hell not? In reality no, the kernel has to punish whoever attempts to do that, although we currently don't.

- The dynamic area (aka DynamicPart) only picks up the default DACL but not the primary group as well. Generally the dynamic part is composed of primary group and default DACL, if provided.

In addition to that, we aren't returning the dynamic charged and available area in token statistics. SepComputeAvailableDynamicSpace helper is here to accommodate that. Apparently Windows is calculating the dynamic available area rather than just querying the DynamicAvailable field directly from the token.
My theory regarding this is like the following: on Windows both TokenDefaultDacl and TokenPrimaryGroup classes are barely used by the system components during startup (LSASS provides both a DACL and primary group when calling NtCreateToken anyway). In fact DynamicAvailable is 0 during token creation, duplication and filtering when inspecting a token with WinDBG. So
if an application wants to query token statistics that application will face a dynamic available space of 0.

3 months ago[TRACERT] Fix displaying hop address on last ping timeout
Stanislav Motylkov [Tue, 28 Jun 2022 20:36:30 +0000 (23:36 +0300)]
[TRACERT] Fix displaying hop address on last ping timeout

- Update source file header per coding rules
- Store intermediate responses to display the hop address
- Add separate function to get response stats from buffer
- Add Cleanup label to free resources in a single place
- Move local variables around to allow Cleanup goto

CORE-18232

3 months ago[FREELDR][SDK] Sync copyright years with our banner and boot logo
Stanislav Motylkov [Mon, 27 Jun 2022 18:42:01 +0000 (21:42 +0300)]
[FREELDR][SDK] Sync copyright years with our banner and boot logo

Addendum to 831e2dea. CORE-18191

3 months ago[FREELDR][SDK] Use "ReactOS Project" for consistency 4564/head
Stanislav Motylkov [Mon, 27 Jun 2022 14:20:04 +0000 (17:20 +0300)]
[FREELDR][SDK] Use "ReactOS Project" for consistency

CORE-18191

3 months ago[INF] Set manufacturer as ReactOS Project for consistency
Stanislav Motylkov [Mon, 27 Jun 2022 14:00:18 +0000 (17:00 +0300)]
[INF] Set manufacturer as ReactOS Project for consistency

Also make it non-localizable. CORE-18191

3 months ago[REACTOS] Remove references to ReactOS Foundation (#4557) 4557/head
Gary Sims [Thu, 23 Jun 2022 11:03:45 +0000 (14:03 +0300)]
[REACTOS] Remove references to ReactOS Foundation (#4557)

See https://reactos.org/wiki/ReactOS_Foundation for more information.

CORE-18191

3 months ago[PROCESSR] Fix INF file formatting only
Stanislav Motylkov [Mon, 27 Jun 2022 12:40:50 +0000 (15:40 +0300)]
[PROCESSR] Fix INF file formatting only

3 months ago[CDMAKE] Remove module 4558/head
Stanislav Motylkov [Sat, 25 Jun 2022 11:52:03 +0000 (14:52 +0300)]
[CDMAKE] Remove module

We've been using mkisofs for 5 years now and are not looking back.
- Colin Finck

3 months ago[CRT] Add missing OP_* constants in fpieee.h
Timo Kreuzer [Sun, 12 Jun 2022 18:02:19 +0000 (20:02 +0200)]
[CRT] Add missing OP_* constants in fpieee.h

3 months ago[CRT] Add emmintrin.h
Timo Kreuzer [Sun, 12 Jun 2022 18:01:16 +0000 (20:01 +0200)]
[CRT] Add emmintrin.h

Implementations are taken from clang.

3 months ago[NTOS:OB] Include the security descriptor charge when charging the paged pool quota... 4562/head
George Bișoc [Sun, 26 Jun 2022 13:44:06 +0000 (15:44 +0200)]
[NTOS:OB] Include the security descriptor charge when charging the paged pool quota of an object

On ObpChargeQuotaForObject function, the kernel will either charge the default object type charges or the specified information charges obtained from ObCreateObject API call. What happens is that if a paged pool charge is specified on ObCreateObject call the kernel will charge that
but when an object is about to be de-allocated, the amount of quota to return back to the system is the amounting of the paged pool charge specified previously by the ObCreateObject call plus the amounting of the security descriptor charge (see oblife.c / line 98).

This will result in a fatal crash with a bugcheck of QUOTA_UNDERFLOW because we are returning quota with bits of it that was never charged and that's SecurityDescriptorCharge. A QUOTA_UNDERFLOW bugcheck occurs in two following scenarios:

-- When installing Virtualbox Guest Additions and prompting the installer to reboot the system for you
-- When logging off and on back to the system and then you restart the system normally

This bug has been discovered whilst working on #4555 PR.

3 months ago[CRT] Implement portable + amd64 asm version of fabs/fabsf
Timo Kreuzer [Sat, 29 May 2021 17:40:30 +0000 (19:40 +0200)]
[CRT] Implement portable + amd64 asm version of fabs/fabsf

Note: older versions of ML64 are broken and don't understand the register form of movq.
See https://stackoverflow.com/questions/24789339/move-quadword-between-xmm-and-general-purpose-register-in-ml64

3 months ago[CRT_APITEST] Implement tests for fabs/fabsf
Timo Kreuzer [Wed, 4 Aug 2021 15:22:01 +0000 (17:22 +0200)]
[CRT_APITEST] Implement tests for fabs/fabsf

3 months ago[NTDLL_APITEST] Fix RtlGetNtProductType test
Timo Kreuzer [Sun, 26 Jun 2022 10:01:57 +0000 (12:01 +0200)]
[NTDLL_APITEST] Fix RtlGetNtProductType test

3 months ago[NTDLL_APITEST] Check whether changing the product type in the registry has an effect...
Timo Kreuzer [Sat, 3 Oct 2020 16:46:31 +0000 (18:46 +0200)]
[NTDLL_APITEST] Check whether changing the product type in the registry has an effect on RtlGetNtProductType

3 months ago[RTL] Implement dynamic function tables for x64
Timo Kreuzer [Fri, 10 Jun 2022 16:44:51 +0000 (18:44 +0200)]
[RTL] Implement dynamic function tables for x64

3 months ago[IP] AddrCountPrefixBits(): Fix loop condition (#4556)
Serge Gautherie [Sat, 25 Jun 2022 15:14:03 +0000 (17:14 +0200)]
[IP] AddrCountPrefixBits(): Fix loop condition (#4556)

Properly handle BitTest reaching 0.

CORE-18225

3 months ago[DISKPART] Support quoted command options in script files
Eric Kohl [Sat, 25 Jun 2022 13:20:40 +0000 (15:20 +0200)]
[DISKPART] Support quoted command options in script files

3 months ago[HHCTRL.OCX] Don't break WineSync. Addendum to 65d7fb1. (#4554)
Thamatip Chitpong [Tue, 21 Jun 2022 12:48:54 +0000 (19:48 +0700)]
[HHCTRL.OCX] Don't break WineSync. Addendum to 65d7fb1. (#4554)

Also minor code formatting for HH_LoadString.

3 months ago[DESK] Pass the list of all display modes to extensions 4553/head
Stanislav Motylkov [Mon, 20 Jun 2022 01:52:04 +0000 (04:52 +0300)]
[DESK] Pass the list of all display modes to extensions

Also implement mode switching from adapter advanced settings.

3 months ago[DESKADP][DESKMON] Notify property sheet that DWLP_MSGRESULT is set
Stanislav Motylkov [Sun, 19 Jun 2022 23:06:37 +0000 (02:06 +0300)]
[DESKADP][DESKMON] Notify property sheet that DWLP_MSGRESULT is set

When FALSE is returned, Apply button ignores validation result
and becomes disabled after clicking as if settings were applied.
Fix it by setting the return value to TRUE.

See https://docs.microsoft.com/en-us/windows/win32/controls/psn-apply

3 months ago[REGEDIT] Fix issue at Find registry key (#4341)
Jose Carlos Jesus [Sun, 19 Jun 2022 19:57:30 +0000 (20:57 +0100)]
[REGEDIT] Fix issue at Find registry key (#4341)

- If we dont select a item as a starting point to search from, we need to set
  pszValueName to the first value name in current subkey.

- Check pszSubKey length before calling RegFindRecurse.

- Set focus to subkey when we search for it.

3 months ago[HHCTRL.OCX] Add help viewer window icon and default title (#4541)
Thamatip Chitpong [Sun, 19 Jun 2022 19:22:28 +0000 (02:22 +0700)]
[HHCTRL.OCX] Add help viewer window icon and default title (#4541)

3 months ago[TASKMGR] Process page: Fix DevicePathToDosPath (#4537)
Thamatip Chitpong [Sun, 19 Jun 2022 18:52:06 +0000 (01:52 +0700)]
[TASKMGR] Process page: Fix DevicePathToDosPath (#4537)

- Fix DevicePathToDosPath, don't use the same in-out buffer.
- Also simplify functions related to 59dcec1

Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
3 months ago[NTDLL_APITEST] NtQueryInformationToken: write tests for TokenGroupsAndPrivileges 4550/head
George Bișoc [Sat, 18 Jun 2022 19:41:50 +0000 (21:41 +0200)]
[NTDLL_APITEST] NtQueryInformationToken: write tests for TokenGroupsAndPrivileges

3 months ago[NTOS:SE] NtQueryInformationToken: implement TokenGroupsAndPrivileges
George Bișoc [Sun, 19 Jun 2022 10:39:23 +0000 (12:39 +0200)]
[NTOS:SE] NtQueryInformationToken: implement TokenGroupsAndPrivileges

TokenGroupsAndPrivileges is the younger sister of two TokenGroups and TokenPrivileges classes. In its purpose there's no huge substantial differences apart that this class comes with its own structure, TOKEN_GROUPS_AND_PRIVILEGES, and that this structure comes with extra information.

3 months ago[DISKPART] Print proper file system information for the FILESYSTEMS command
Eric Kohl [Sun, 19 Jun 2022 13:40:08 +0000 (15:40 +0200)]
[DISKPART] Print proper file system information for the FILESYSTEMS command

3 months agoModified WINESYNC.txt to show individual tests for msxml3 and update for schema
Doug Lyons [Fri, 15 Oct 2021 15:36:21 +0000 (10:36 -0500)]
Modified WINESYNC.txt to show individual tests for msxml3 and update for schema

3 months agoFix winetests/msxml3/schema.c crashes and sync to Wine-6.14
Doug Lyons [Thu, 14 Oct 2021 23:34:18 +0000 (18:34 -0500)]
Fix winetests/msxml3/schema.c crashes and sync to Wine-6.14

3 months ago[WINESYNC]: reg is now in sync with wine-staging wine-6.23 4298/head
Thomas Csovcsity [Mon, 17 Jan 2022 17:47:50 +0000 (18:47 +0100)]
[WINESYNC]: reg is now in sync with wine-staging wine-6.23

Used winesync.py script, commits which needed obious adjustments have explicit
note in commit message, that it is manually adjusted. Internationalization is
skipped while automated sync and done in last manual step.

Additonal manual adjustments to compile in ros are in this commit:
- wcsupr -> _wcsupr
- only 3 arguments for swprintf, instead of 4 in wine
- disable tests for "/reg:32" and "/reg:64", because they fail on w2k3

Manually addjusted base/applications/cmdutils/reg/lang/zh-CN.rc while rebase to
actuall master (4a66cbb224804317cb4bea32c10838f43a820a70) on 19.06.2022

3 months ago[WINESYNC] reg: Use the standard va_list instead of __ms_va_list.
winesync [Mon, 17 Jan 2022 17:47:46 +0000 (18:47 +0100)]
[WINESYNC] reg: Use the standard va_list instead of __ms_va_list.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 942f9f71575d4a53ae032360e03f1297be1319f7 by Alexandre Julliard <julliard@winehq.org>

3 months ago[WINESYNC] reg: Support use of registry views in the 'copy' operation.
winesync [Mon, 17 Jan 2022 17:47:39 +0000 (18:47 +0100)]
[WINESYNC] reg: Support use of registry views in the 'copy' operation.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50962
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 04d52eb83fa5c37cfe1100f435e36c2f78918338 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Test use of registry views when copying registry data.
winesync [Mon, 17 Jan 2022 17:47:39 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Test use of registry views when copying registry data.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id d92f26ed1264ec80f97c0a45a59b986f0b9cae38 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Support use of registry views when exporting registry data.
winesync [Mon, 17 Jan 2022 17:47:38 +0000 (18:47 +0100)]
[WINESYNC] reg: Support use of registry views when exporting registry data.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id fcf79426147adf0d9f1d80b0cf24d0b6abd8bf59 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Use correct file and line arguments with delete_file().
winesync [Mon, 17 Jan 2022 17:47:38 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Use correct file and line arguments with delete_file().

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 0b5ba1d0be04f7c6bc0e53e9a28984cf2941b4bc by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Split 'export' syntax tests into a separate function.
winesync [Mon, 17 Jan 2022 17:47:38 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Split 'export' syntax tests into a separate function.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 959ea6677ea0571c5042a5ec5bec33fb5a5f1dc6 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Test use of registry views when exporting registry data.
winesync [Mon, 17 Jan 2022 17:47:38 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Test use of registry views when exporting registry data.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id fee692178cebd33220027ad6038f6acd8185b77f by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Add registry view syntax tests for the 'import' operation.
winesync [Mon, 17 Jan 2022 17:47:38 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Add registry view syntax tests for the 'import' operation.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 49cde0995827b24aa9c1ef1b6a0372797f4166e0 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Support use of registry views in the 'import' command.
winesync [Mon, 17 Jan 2022 17:47:38 +0000 (18:47 +0100)]
[WINESYNC] reg: Support use of registry views in the 'import' command.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 0c71a9879d894e4b82de2909c9c44e36c0bbb35e by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Test use of registry views when importing keys and values.
winesync [Mon, 17 Jan 2022 17:47:37 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Test use of registry views when importing keys and values.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id f2ce614d85091500c071f9b7234f17d5d6418727 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Split 'import' syntax tests into a separate function.
winesync [Mon, 17 Jan 2022 17:47:37 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Split 'import' syntax tests into a separate function.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id e3d14e66f71193faeb532c28b5b5565d5ea9b12f by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Support use of registry views in the 'query' operation.
winesync [Mon, 17 Jan 2022 17:47:37 +0000 (18:47 +0100)]
[WINESYNC] reg: Support use of registry views in the 'query' operation.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 8eef4a873513cca9ffea61fb225fa8a9c8ac784d by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Check all error codes in delete_tree() before returning.
winesync [Mon, 17 Jan 2022 17:47:37 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Check all error codes in delete_tree() before returning.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 48c73868720606ab62ae089ee3b9c978736bd530 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Test use of registry views when querying registry values.
winesync [Mon, 17 Jan 2022 17:47:37 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Test use of registry views when querying registry values.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 45955658e18b65d3af701885e2cfa58bd0c95ceb by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Don't verify key deletion after calling delete_tree().
winesync [Mon, 17 Jan 2022 17:47:37 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Don't verify key deletion after calling delete_tree().

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 3186a0046336e82a2e8133f8a5958e6250c6fe61 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Verify key opening and key deletion in delete_tree().
winesync [Mon, 17 Jan 2022 17:47:37 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Verify key opening and key deletion in delete_tree().

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 5115e51adb103f023600269ddc1833386fcc1e79 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Test use of registry views with the 'query' operation.
winesync [Mon, 17 Jan 2022 17:47:37 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Test use of registry views with the 'query' operation.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 76b30097525f755f572d835b0187d9496941d985 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Split 'query' syntax tests into a separate function.
winesync [Mon, 17 Jan 2022 17:47:36 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Split 'query' syntax tests into a separate function.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id a899d743c585fe8004c41f12cf0a080ebe622fd1 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Support use of registry views when deleting registry keys.
winesync [Mon, 17 Jan 2022 17:47:36 +0000 (18:47 +0100)]
[WINESYNC] reg: Support use of registry views when deleting registry keys.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 31f070f7d3e312942d72e774a4a7dbd21b655a31 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Support use of registry views when deleting registry values.
winesync [Mon, 17 Jan 2022 17:47:36 +0000 (18:47 +0100)]
[WINESYNC] reg: Support use of registry views when deleting registry values.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 8d42cb9c1ca72e02b8961d6703aaa2e3ddfda5e2 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Test deletion of keys and values using registry views.
winesync [Mon, 17 Jan 2022 17:47:36 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Test deletion of keys and values using registry views.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 556121b1cafc2182edaeb7354caf46375205bef7 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Remove duplicate test from test_registry_view_wow64().
winesync [Mon, 17 Jan 2022 17:47:36 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Remove duplicate test from test_registry_view_wow64().

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 8ad9c21b056d9f3119c363e0f7e56198985d5b08 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Modify delete_tree() to support the use of registry views.
winesync [Mon, 17 Jan 2022 17:47:36 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Modify delete_tree() to support the use of registry views.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id d790c593490bfb363cf34ab2d00dddbaf04ddd15 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Move 'delete' syntax tests into a separate function.
winesync [Mon, 17 Jan 2022 17:47:36 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Move 'delete' syntax tests into a separate function.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 7c9f372480511cba8abd90ed04480911d96036de by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Support the use of registry views during the 'add' operation.
winesync [Mon, 17 Jan 2022 17:47:36 +0000 (18:47 +0100)]
[WINESYNC] reg: Support the use of registry views during the 'add' operation.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 304b80a9b5a6ed128dd8a89e22f05b99142310cd by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Test key and value creation in 32-bit and 64-bit registry views.
winesync [Mon, 17 Jan 2022 17:47:36 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Test key and value creation in 32-bit and 64-bit registry views.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 24d0d6f524d6c51cc5d8c909bf6cd942d6ae443d by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Modify add_key() to support key creation in registry views.
winesync [Mon, 17 Jan 2022 17:47:35 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Modify add_key() to support key creation in registry views.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 0d60749c218ae76645006e6273fc2f6a5ea87a58 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Update delete_value() declaration to deconstify 'const HKEY'.
winesync [Mon, 17 Jan 2022 17:47:35 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Update delete_value() declaration to deconstify 'const HKEY'.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id ff0445a5de192b2984bb558ac54e7f4d54e96129 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Modify verify_key_nonexist() to support registry views.
winesync [Mon, 17 Jan 2022 17:47:35 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Modify verify_key_nonexist() to support registry views.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 9780dfc01a460264b6088fe23eada214c21441bd by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Modify verify_key() to support opening of registry views.
winesync [Mon, 17 Jan 2022 17:47:35 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Modify verify_key() to support opening of registry views.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id fdceb5ed7e5ce058cf9a64564e116f1bbe42d5ea by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Update reg_open() and reg_open_() definitions.
winesync [Mon, 17 Jan 2022 17:47:35 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Update reg_open() and reg_open_() definitions.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 0eb85504b4b9bdeef8a402d39024e20ad99789a0 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Modify delete_key() to support use of RegDeleteKeyEx().
winesync [Mon, 17 Jan 2022 17:47:35 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Modify delete_key() to support use of RegDeleteKeyEx().

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id f06869199571466c989b0e75a8edfb55ad6e541a by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Test how values are overwritten when copying.
winesync [Mon, 17 Jan 2022 17:47:35 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Test how values are overwritten when copying.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 8104629672db54fcc13f05f980149d2cc4170e24 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Prompt the user to confirm whether they want to overwrite existing...
winesync [Mon, 17 Jan 2022 17:47:14 +0000 (18:47 +0100)]
[WINESYNC] reg: Prompt the user to confirm whether they want to overwrite existing values when copying a key.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48000
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id aeeda123b1185e6d6f6c975354fe567c4573502e by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg/tests: Test whether the 'copy' command copies user-defined key classes.
winesync [Mon, 17 Jan 2022 17:47:14 +0000 (18:47 +0100)]
[WINESYNC] reg/tests: Test whether the 'copy' command copies user-defined key classes.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 664f8b638d421540e73b4e046a9aa5e66f8cc4ff by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Fail if the source and destination keys are the same when copying.
winesync [Mon, 17 Jan 2022 17:43:11 +0000 (18:43 +0100)]
[WINESYNC] reg: Fail if the source and destination keys are the same when copying.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 0abc002a3e232be3445241e435ef17ac89d6c947 by Hugh McMaster <hugh.mcmaster@outlook.com>

manual adjustment needed

3 months ago[WINESYNC] reg: Support recursion in the 'copy' command.
winesync [Mon, 17 Jan 2022 17:43:11 +0000 (18:43 +0100)]
[WINESYNC] reg: Support recursion in the 'copy' command.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 8d9a228e99e1252a0d82c88e6a64635548c478a6 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Partially implement the 'copy' command.
winesync [Mon, 17 Jan 2022 17:43:11 +0000 (18:43 +0100)]
[WINESYNC] reg: Partially implement the 'copy' command.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id b1ccb87d9debb1a07e35263a76b6e34a7dd6ee49 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Group resource IDs by source location.
winesync [Mon, 17 Jan 2022 17:42:07 +0000 (18:42 +0100)]
[WINESYNC] reg: Group resource IDs by source location.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 8f997a8b9b75320449711d3b05241b5f1f580ac3 by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Remove two unused string resources.
winesync [Mon, 17 Jan 2022 17:40:42 +0000 (18:40 +0100)]
[WINESYNC] reg: Remove two unused string resources.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id e4f3d51fdde4b762d2317ce7b2aa140ac030989b by Hugh McMaster <hugh.mcmaster@outlook.com>

3 months ago[WINESYNC] reg: Fail if one or more arguments follow a help switch.
winesync [Sun, 16 Jan 2022 20:22:50 +0000 (21:22 +0100)]
[WINESYNC] reg: Fail if one or more arguments follow a help switch.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id 6c466296a7629487930d4d6e4fa7d7ae66a7bf61 by Hugh McMaster <hugh.mcmaster@outlook.com>

manual adjustment needed

3 months ago[WINESYNC] reg: Add initial support for the 'copy' command.
winesync [Sun, 16 Jan 2022 20:21:18 +0000 (21:21 +0100)]
[WINESYNC] reg: Add initial support for the 'copy' command.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
wine commit id ac32dd8abcdd93f5428ba93c8aff7f0bb5a7c2f2 by Hugh McMaster <hugh.mcmaster@outlook.com>

manual adjustment needed