13 months ago|CMAKE] Use ExternalProject for host-tools build
Jérôme Gardou [Thu, 22 Oct 2020 06:47:06 +0000 (08:47 +0200)]
|CMAKE] Use ExternalProject for host-tools build

13 months ago[APISETS] Revert 'Try to fix build of both case of MSVC AND CLANG'
Katayama Hirofumi MZ [Thu, 22 Oct 2020 00:18:32 +0000 (09:18 +0900)]
[APISETS] Revert 'Try to fix build of both case of MSVC AND CLANG'

13 months ago[APISETS] Try to fix build of both case of MSVC AND CLANG
Katayama Hirofumi MZ [Thu, 22 Oct 2020 00:07:15 +0000 (09:07 +0900)]
[APISETS] Try to fix build of both case of MSVC AND CLANG

13 months ago[INCLUDE] Use HeapAlloc/HeapFree in layout.h
Katayama Hirofumi MZ [Wed, 21 Oct 2020 23:07:32 +0000 (08:07 +0900)]
[INCLUDE] Use HeapAlloc/HeapFree in layout.h


13 months ago[SHELL32] Resizable for SHBrowseForFolder (#3299)
Katayama Hirofumi MZ [Wed, 21 Oct 2020 13:25:16 +0000 (22:25 +0900)]
[SHELL32] Resizable for SHBrowseForFolder (#3299)

Make the dialog box of SHBrowseForFolder function resizable. CORE-17341

13 months ago[PARPORT] Fix I/O port length check
Victor Perevertkin [Wed, 21 Oct 2020 12:24:10 +0000 (15:24 +0300)]
[PARPORT] Fix I/O port length check
The Standard Parallel Port (SPP) has 3 registers, not 4: data, status, control
This fixes the driver on the Compaq N600c laptop

13 months ago[NTOSKRNL] Completely disable optimizations when using GDB
Jérôme Gardou [Wed, 21 Oct 2020 10:32:54 +0000 (12:32 +0200)]
[NTOSKRNL] Completely disable optimizations when using GDB

13 months agoApply suggestions from code review
Jérôme Gardou [Fri, 16 Oct 2020 13:57:20 +0000 (15:57 +0200)]
Apply suggestions from code review

Beautification and clarity

Co-authored-by: Victor Perevertkin <>
Co-authored-by: Hermès BÉLUSCA - MAÏTO <>
13 months agoApply suggestions from code review
Jérôme Gardou [Fri, 16 Oct 2020 06:41:35 +0000 (08:41 +0200)]
Apply suggestions from code review

Style fixes

Co-authored-by: Hermès BÉLUSCA - MAÏTO <>
Co-authored-by: Victor Perevertkin <>
13 months ago[CMAKE] Get rid of add_compile_flags
Jérôme Gardou [Mon, 21 Sep 2020 10:16:02 +0000 (12:16 +0200)]
[CMAKE] Get rid of add_compile_flags

Use add_compile_options and the like instead

13 months ago[CMAKE] Get rid of replace_compiler_option macro
Jérôme Gardou [Fri, 18 Sep 2020 14:54:21 +0000 (16:54 +0200)]
[CMAKE] Get rid of replace_compiler_option macro

This is not used anymore

13 months ago[CMAKE] Use -ffile-prefix-map for GCC builds
Jérôme Gardou [Fri, 18 Sep 2020 14:19:46 +0000 (16:19 +0200)]
[CMAKE] Use -ffile-prefix-map for GCC builds

And also simplify the __RELFILE__ macro definition for the other cases

13 months ago[CMAKE] Get rid of add_compile_flags_language macro
Jérôme Gardou [Fri, 18 Sep 2020 14:18:24 +0000 (16:18 +0200)]
[CMAKE] Get rid of add_compile_flags_language macro

in favor of add_compile_options and the like with generator expressions
Also take this as an opportunity to remove the C++11 standard hack, GCC 8 now defaults to C++14

13 months ago[CMAKE] Get rid of replace_compile_flags
Jérôme Gardou [Fri, 18 Sep 2020 09:49:18 +0000 (11:49 +0200)]
[CMAKE] Get rid of replace_compile_flags

Introduce a finer-grained remove_target_compile_option instead

13 months ago[CMAKE] Get rid of replace_compile_flags_language macro
Jérôme Gardou [Fri, 18 Sep 2020 09:12:49 +0000 (11:12 +0200)]
[CMAKE] Get rid of replace_compile_flags_language macro

It was only used in the set_cpp macro

13 months ago[CMAKE] Introduce the atl_classes interface library
Jérôme Gardou [Fri, 18 Sep 2020 09:08:58 +0000 (11:08 +0200)]
[CMAKE] Introduce the atl_classes interface library

This takes care of adding the relvant include directory and the _ATL_NO_EXCEPTIONS define, if needed

13 months ago[CMAKE] Allow INTERFACE libraries for MSVC IDEs
Jérôme Gardou [Thu, 15 Oct 2020 09:47:03 +0000 (11:47 +0200)]
[CMAKE] Allow INTERFACE libraries for MSVC IDEs

13 months ago[CMAKE] Get rid of the set_cpp macro
Jérôme Gardou [Fri, 18 Sep 2020 07:34:18 +0000 (09:34 +0200)]
[CMAKE] Get rid of the set_cpp macro

Instead of messing with global variables and the like, we introduce two target properties:
 - WITH_CXX_EXCEPTIONS: if you want to use C++ exceptions
 - WITH_CXX_RTTI: if you need RTTI in your module
You can use the newly introduced set_target_cpp_properties function, with WITH_EXCEPTIONS and WITH_RTTI arguments
We also introduce two libraries :
 - cpprt: for C++ runtime routines
 - cppstl: for the C++ standard template library

NB: On GCC, this requires to create imported libraries with the related built-in libraries:libsupc++, limingwex, libstdc++

Finally, we manage the relevant flags with the ad-hoc generator expressions

So, if you don't need exceptions, nor RTTI, nor use any runtime at all: you simply have nothing else to do than add your C++ file to your module

13 months ago[CMAKE] CMakeParseArguments is not needed anymore, cmake_parse_arguments is a builtin...
Jérôme Gardou [Thu, 17 Sep 2020 08:05:02 +0000 (10:05 +0200)]
[CMAKE] CMakeParseArguments is not needed anymore, cmake_parse_arguments is a builtin since CMake 3.5

13 months agoRevert "[NTOS/MM] Initialize process Working set and start implementing adding entrie...
Jérôme Gardou [Tue, 20 Oct 2020 13:56:53 +0000 (15:56 +0200)]
Revert "[NTOS/MM] Initialize process Working set and start implementing adding entries to it"

This reverts commit 5abc016401a59dfb60944ea1fc8ea5ed27f7f087.
Not ready for prime time

13 months agoRevert "[NTOS/MM]
Jérôme Gardou [Tue, 20 Oct 2020 13:56:21 +0000 (15:56 +0200)]
Revert "[NTOS/MM]
     - Fix PFNs tracing
     - Add private pages to the process working set"

This reverts commit 4c5351bf55527a35bce09446420dd7296eedbe99.
Not ready for prime time

13 months ago[CMAKE] Add target-level dependency between ntdll_apitest and load_notifications
Jérôme Gardou [Tue, 20 Oct 2020 07:32:00 +0000 (09:32 +0200)]
[CMAKE] Add target-level dependency between ntdll_apitest and load_notifications

13 months ago[CMAKE] Use explicit path for "custom.dll" dependency
Jérôme Gardou [Tue, 20 Oct 2020 07:06:26 +0000 (09:06 +0200)]
[CMAKE] Use explicit path for "custom.dll" dependency

13 months ago[CMAKE] Fix generation of UTF-16 inf file
Jérôme Gardou [Tue, 20 Oct 2020 07:05:47 +0000 (09:05 +0200)]
[CMAKE] Fix generation of UTF-16 inf file

13 months ago[NTOS/MM]
Jérôme Gardou [Fri, 16 Oct 2020 13:27:07 +0000 (15:27 +0200)]
 - Fix PFNs tracing
 - Add private pages to the process working set

13 months ago[NTOS/MM] Initialize process Working set and start implementing adding entries to it
Jérôme Gardou [Thu, 15 Oct 2020 11:09:39 +0000 (13:09 +0200)]
[NTOS/MM] Initialize process Working set and start implementing adding entries to it

13 months ago[USETUP] Work around GCC's complaints (will be fixed properly later on).
Hermès Bélusca-Maïto [Mon, 19 Oct 2020 23:26:49 +0000 (01:26 +0200)]
[USETUP] Work around GCC's complaints (will be fixed properly later on).

13 months ago[USETUP][SETUPLIB] Continue hiding the FAT32 format in the format list, but take...
Hermès Bélusca-Maïto [Mon, 19 Oct 2020 21:49:26 +0000 (23:49 +0200)]
[USETUP][SETUPLIB] Continue hiding the FAT32 format in the format list, but take it into account anyway later on.

The formatter will select it anyway as soon as the partition size
permits it. We make it available internally however so as to "emulate"
FMIFS functionality.

Now rely on the partition filesystem for InstallVBRToPartition() instead
of the unreliable and deprecated partition type.

13 months ago[SETUPLIB] Code re-organization in bootsup.c and fsutil.c.
Hermès Bélusca-Maïto [Sat, 17 Oct 2020 18:29:47 +0000 (20:29 +0200)]
[SETUPLIB] Code re-organization in bootsup.c and fsutil.c.

- Move the actual VBR bootcode installation helpers into fsutil.c
  (they depend on the selected filesystem).

- Introduce InstallBootCodeToDisk() and InstallBootCodeToFile()
  and bootcode.c helpers, in order to replace the several functions
  that were duplicating the same code.

13 months ago[SETUPLIB] Move the filesystem recognition helpers to their own file.
Hermès Bélusca-Maïto [Sun, 11 Oct 2020 21:42:02 +0000 (23:42 +0200)]
[SETUPLIB] Move the filesystem recognition helpers to their own file.

13 months ago[FREELDR] Add variable for default text color 3301/head
Stanislav Motylkov [Fri, 16 Oct 2020 21:46:06 +0000 (00:46 +0300)]
[FREELDR] Add variable for default text color

On PC/AT-compatible machines it's Gray, and on NEC PC-98 series it's White.

13 months ago[FREELDR] Use BIOS font and accelerated text drawing on NEC PC-98
Stanislav Motylkov [Fri, 16 Oct 2020 21:32:38 +0000 (00:32 +0300)]
[FREELDR] Use BIOS font and accelerated text drawing on NEC PC-98

Both features are switchable via global variables.

13 months ago[NTOSKRNL] include/config.h: Sync it to current code (#3263)
Serge Gautherie [Sat, 17 Oct 2020 16:09:11 +0000 (18:09 +0200)]
[NTOSKRNL] include/config.h: Sync it to current code (#3263)

* SERIALIZE_DBGPRINT: Removed on c15e04c (r18078).
* ENABLE_VALIDATE_POOL: Removed on 5899e14 (r42249).
* TAG_STATISTICS_TRACKING: Removed on 5899e14 (r42249).
* POOL_DEBUG_APIS: Removed on 5899e14 (r42249).
* R_RZ: Removed on 7d21cf7 (r48999).
* R_STACK: Removed on 7d21cf7 (r48999).
* WHOLE_PAGE_ALLOCATIONS: Removed on b431563 (r17306).

13 months ago[BASESRV] Use the correct value for the last parameter of a CsrValidateMessageBuffer...
Hermès Bélusca-Maïto [Sat, 17 Oct 2020 14:55:56 +0000 (16:55 +0200)]
[BASESRV] Use the correct value for the last parameter of a CsrValidateMessageBuffer() call.

13 months ago[NTOS:IO] Some fixes for IoRaiseHardError(). (#3302) 3302/head
Hermès Bélusca-Maïto [Sat, 10 Oct 2020 15:41:44 +0000 (17:41 +0200)]
[NTOS:IO] Some fixes for IoRaiseHardError(). (#3302)

- Fix buggy retrieval of the current calling Irp->Tail.Overlay.Thread.

- The 4th argument (KernelRoutine) to the KeInitializeApc() is **NOT**
  optional; however its 5th argument (RundownRoutine) is.
  So use the mandatory routine for freeing the allocated APC instead.
  We don't use the rundown routine yet.

- Check whether the ExAllocatePoolWithTag() call failed or not before
  queueing the allocated APC.

13 months ago[NTOS:EX] ExUuidCreate(): Correctly fill Uuid->Data4
Serge Gautherie [Wed, 9 Sep 2020 01:46:56 +0000 (03:46 +0200)]
[NTOS:EX] ExUuidCreate(): Correctly fill Uuid->Data4


Co-authored-by: Nguyen Trung Khanh <>
13 months ago[BROWSEUI] Implement CLSID_ACListISF (#3298)
Katayama Hirofumi MZ [Sat, 17 Oct 2020 08:49:24 +0000 (17:49 +0900)]
[BROWSEUI] Implement CLSID_ACListISF (#3298)

Implement enumeration of IShellFolder items of auto-completion. CORE-9281

13 months ago[SCSIPORT] Split scsiport.c file into several ones, prepare for the refactoring
Victor Perevertkin [Sat, 17 Oct 2020 01:06:36 +0000 (04:06 +0300)]
[SCSIPORT] Split scsiport.c file into several ones, prepare for the refactoring


13 months ago[SETUPLIB] Fix some copy-pasta comments, no code changes
Stanislav Motylkov [Fri, 16 Oct 2020 21:48:30 +0000 (00:48 +0300)]
[SETUPLIB] Fix some copy-pasta comments, no code changes

13 months ago[FASTFAT] Ensure that deferred write IRP contexts are not touched. CORE-17328 3292/head
Thomas Faber [Sun, 11 Oct 2020 13:02:26 +0000 (15:02 +0200)]
[FASTFAT] Ensure that deferred write IRP contexts are not touched. CORE-17328

Cc may decide to process deferred writes any time, so the context might
already be freed by the time we return from CcDeferWrite.
Also mark the IRP as pending, since we're going to return STATUS_PENDING.

13 months ago[NTOS] Consistently use MUTANT_INCREMENT.
Thomas Faber [Fri, 16 Oct 2020 14:09:08 +0000 (16:09 +0200)]
[NTOS] Consistently use MUTANT_INCREMENT.

Spotted by Hermès.

13 months ago[CDROM_NEW] Import Microsoft CDROM class driver from GitHub
Victor Perevertkin [Fri, 16 Oct 2020 01:37:10 +0000 (04:37 +0300)]
[CDROM_NEW] Import Microsoft CDROM class driver from GitHub

The source code is licensed under MS-PL license, taken from Windows Driver Samples
repository (microsoft/Windows-driver-samples@master/storage/class/cdrom/)
Synched with commit 96eb96dfb613e4c745db6bd1f53a92fe7e2290fc
The driver is written for Windows 10 and uses KMDF so we compile it with ntoskrnl_vista
and wdf01000 statically linked (for wdf01000 this will likely be changed in future)


13 months ago[ACPICA] Update to version 20200925. CORE-17170
Thomas Faber [Fri, 9 Oct 2020 07:19:55 +0000 (09:19 +0200)]
[ACPICA] Update to version 20200925. CORE-17170

13 months ago[ACPICA] Update to version 20200717. CORE-17170
Thomas Faber [Sun, 6 Sep 2020 10:29:37 +0000 (12:29 +0200)]
[ACPICA] Update to version 20200717. CORE-17170

13 months ago[RAPPS] Update Hebrew (he-IL) translation (#3297)
Omer I.S [Thu, 15 Oct 2020 14:12:50 +0000 (17:12 +0300)]
[RAPPS] Update Hebrew (he-IL) translation (#3297)

13 months ago[NTOS:MM] Acquire PsLoadedModuleResource when walking PsLoadedModuleList. CORE-16449
Thomas Faber [Thu, 15 Oct 2020 11:42:13 +0000 (13:42 +0200)]
[NTOS:MM] Acquire PsLoadedModuleResource when walking PsLoadedModuleList. CORE-16449

13 months ago[NTOS:MM] Acquire MmSystemLoadLock in MiFindInitializationCode. CORE-16449
Thomas Faber [Thu, 15 Oct 2020 11:40:42 +0000 (13:40 +0200)]
[NTOS:MM] Acquire MmSystemLoadLock in MiFindInitializationCode. CORE-16449

We might otherwise free the INIT section for an image that's in the
process of being loaded by Mm.

13 months ago[OLE32_WINETEST] Fix build with lower optimization level
Jérôme Gardou [Thu, 15 Oct 2020 09:53:11 +0000 (11:53 +0200)]
[OLE32_WINETEST] Fix build with lower optimization level

13 months ago[WINED3D] Fix build with lower optimization levels
Jérôme Gardou [Thu, 15 Oct 2020 09:36:01 +0000 (11:36 +0200)]
[WINED3D] Fix build with lower optimization levels

13 months ago[UDFS] Fix build with lower optimization level
Jérôme Gardou [Thu, 15 Oct 2020 09:29:09 +0000 (11:29 +0200)]
[UDFS] Fix build with lower optimization level

13 months ago[BOOTDATA] Update display names for the GMT+0 time zones.
Hermès Bélusca-Maïto [Tue, 13 Oct 2020 16:17:34 +0000 (18:17 +0200)]
[BOOTDATA] Update display names for the GMT+0 time zones.

Following advice from

13 months ago[BOOTDATA] Update some time zones for Russia.
Hermès Bélusca-Maïto [Tue, 13 Oct 2020 16:04:02 +0000 (18:04 +0200)]
[BOOTDATA] Update some time zones for Russia.

- Move Novosibirsk to GMT+07:00 (was GMT+06:00 previously).
- Move Magadan to GMT+11:00 (was GMT+10:00 previously).
- Add Omsk time zone GMT+06:00
- Add Tomsk time zone GMT+07:00

13 months ago[NTUSER] Fix Shell Hook HSHELL_WINDOWCREATED (#3294)
Katayama Hirofumi MZ [Tue, 13 Oct 2020 07:37:52 +0000 (16:37 +0900)]

Fix Shell Hook and reduce failures of shell32_apitest ShellHook testcase. Fix the condition of notifying shell hook HSHELL_WINDOWCREATED in ntuser/winpos.c. CORE-17330

13 months ago[FASTFAT] Fix create for DOT and DOT-DOT leaving bad directory entry (#3241) 3241/head
Doug Lyons [Sat, 26 Sep 2020 22:39:15 +0000 (17:39 -0500)]
[FASTFAT] Fix create for DOT and DOT-DOT leaving bad directory entry (#3241)

13 months ago[BOOTDATA] Comment out vgaoem.fon (#3291)
Adam Słaboń [Mon, 12 Oct 2020 11:48:49 +0000 (13:48 +0200)]
[BOOTDATA] Comment out vgaoem.fon (#3291)

This font has been added in 383ea7d and then disabled from builds in 4cd2a93 due to regressions it was causing.
Also disable it in registry to not break NTLDR boot again.

13 months ago[SHELL32_APITEST] Add ShellHook testcase (#3289)
Katayama Hirofumi MZ [Mon, 12 Oct 2020 00:52:21 +0000 (09:52 +0900)]
[SHELL32_APITEST] Add ShellHook testcase (#3289)

Add a testcase named ShellHook for shell hook. This testcase will test HSHELL_WINDOWCREATED especially. HSHELL_WINDOWCREATED affects display of task bar panes. CORE-17330

13 months ago[CMD] Fix a typo in filename completion (#3293)
chirsz [Sun, 11 Oct 2020 19:57:08 +0000 (03:57 +0800)]
[CMD] Fix a typo in filename completion (#3293)

Fix filename completion that could cause a incorrect result when the path
contains "dots". (See also HBelusca@d12169b.)
See CORE-8623 and CORE-1901 (bug introduced in r25896 / 54cf74f).

For example:

- The current directory is `C:\Documents and Settings\Administrator\`, and you
  input `".` and press TAB. The completion result would be `".Administrator"`,
  which even does not exist.

- You input "some(file).ext", and you remove the final quote (or the quote
  and "ext") and you attempt to complete the file name.

- Import two additional fixes from HBelusca@a826730: Fix the search ordering
  in the comparisons between szSearch1, szSearch2 and szSearch3.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <>
13 months ago[RAPPS] Re-add support for icons named after the ini file 3194/head
Mark Jansen [Wed, 30 Sep 2020 17:24:52 +0000 (19:24 +0200)]
[RAPPS] Re-add support for icons named after the ini file

13 months ago[RAPPS] Fix certificate pinning error displaying garbage
Mark Jansen [Wed, 30 Sep 2020 17:24:10 +0000 (19:24 +0200)]
[RAPPS] Fix certificate pinning error displaying garbage

13 months ago[RAPPS] Bump the rapps user agent version
Mark Jansen [Wed, 30 Sep 2020 17:23:55 +0000 (19:23 +0200)]
[RAPPS] Bump the rapps user agent version

13 months ago[RAPPS] Update rapps DB location to the new database
Mark Jansen [Sun, 20 Sep 2020 20:12:19 +0000 (22:12 +0200)]
[RAPPS] Update rapps DB location to the new database

13 months ago[RAPPS] Delete icons and temp screenshot when cleaning up the db
Mark Jansen [Sun, 6 Sep 2020 21:14:37 +0000 (23:14 +0200)]
[RAPPS] Delete icons and temp screenshot when cleaning up the db

13 months ago[RAPPS] Add directory extraction capabilities for the .cab file
Mark Jansen [Sun, 6 Sep 2020 21:14:11 +0000 (23:14 +0200)]
[RAPPS] Add directory extraction capabilities for the .cab file

13 months ago[RAPPS] Add support for a rapps db with the file:/// scheme
Mark Jansen [Sun, 6 Sep 2020 21:13:21 +0000 (23:13 +0200)]
[RAPPS] Add support for a rapps db with the file:/// scheme
This makes it easier to test locally

13 months ago[PSDK] Add some argument names
Mark Jansen [Sun, 6 Sep 2020 15:50:29 +0000 (17:50 +0200)]
[PSDK] Add some argument names

13 months ago[GDI32] Prevent double initialization in GdiProcessSetup
Mark Jansen [Fri, 9 Oct 2020 12:28:32 +0000 (14:28 +0200)]
[GDI32] Prevent double initialization in GdiProcessSetup
Found with Application Verifier :)

13 months ago[README] Improving the readability of the stability warning (#3287)
Alexander Rechitskiy [Sat, 10 Oct 2020 23:40:48 +0000 (02:40 +0300)]
[README] Improving the readability of the stability warning (#3287)

Now the warning looks and reads better than a huge chunk of text in bold and italics at once.

13 months ago[PSDK] dsrole.h: Define DSROLE_PRIMARY_DS_READONLY (#3288)
Serge Gautherie [Sat, 10 Oct 2020 20:27:07 +0000 (22:27 +0200)]
[PSDK] dsrole.h: Define DSROLE_PRIMARY_DS_READONLY (#3288)

13 months ago[SMSS] Use RTL string-safe functions in critical places. Add validity checks for... 2704/head
Hermès Bélusca-Maïto [Thu, 30 Apr 2020 16:42:16 +0000 (18:42 +0200)]
[SMSS] Use RTL string-safe functions in critical places. Add validity checks for returned NtQueryValueKey() data. (#2704)

- Not all the wcscpy() / swprintf() calls have been converted to their
  string-safe equivalents. Instead I used the string-safe functions only
  for places where strings of unknown length were copied into fixed-size
  internal buffers. On the contrary, for known-fixed-length strings being
  copied or numbers being converted to string representations in large
  enough buffers, I kept the original function calls.

- Verify the registry data that has been returned by NtQueryValueKey():
  * When expecting (not multi) strings, check whether the data type is
    either REG_SZ or REG_EXPAND_SZ.
  * When expecting DWORD values, check whether the data type is
    REG_DWORD and whether the data length is (greater or) equal to

13 months ago[FONTS] Improve vgaoem.fon compatibilities by Fony
Katayama Hirofumi MZ [Sat, 10 Oct 2020 13:54:39 +0000 (22:54 +0900)]
[FONTS] Improve vgaoem.fon compatibilities by Fony

I have edited the font file vgaoem.fon with Fony application.
I adjusted the bitmap and the metrics.
The font name was "XFreeVGA" but now I renamed it as "Terminal".

(C) AJCD 1995 (C) 2009 grischka (C) khmz.

13 months ago[FONTS] Add CORE-* comments into CMakeLists.txt
Katayama Hirofumi MZ [Sat, 10 Oct 2020 13:53:04 +0000 (22:53 +0900)]
[FONTS] Add CORE-* comments into CMakeLists.txt


13 months ago[INPORT] Add driver for bus mouse devices (#3173) 3173/head
Dmitry Borisov [Sun, 13 Sep 2020 11:42:48 +0000 (17:42 +0600)]
[INPORT] Add driver for bus mouse devices (#3173)

It adds basic input support for:
- Standard Bus Mouse
- Standard InPort Mouse
- Logitech Bus Mouse
- Microsoft Bus Mouse
- Microsoft InPort Mouse
- NEC PC-98 Bus Mouse

Untested on PC/AT, but should work.

13 months ago[NTOS:PNP] Install mouse driver on NEC PC-98 series (#3173)
Dmitry Borisov [Sun, 13 Sep 2020 11:36:40 +0000 (17:36 +0600)]
[NTOS:PNP] Install mouse driver on NEC PC-98 series (#3173)

The current implementation of device tree enumeration does not distinguish
between possible identifier strings. This change is not a hack,
NT 5.2 still creates a new device node for this hardware ID.
The entire function should be rewritten to match Windows implementation.

13 months ago[INF] Remove duplicated manufacturer names (#3173)
Dmitry Borisov [Tue, 22 Sep 2020 19:58:58 +0000 (01:58 +0600)]
[INF] Remove duplicated manufacturer names (#3173)

[BOOTDATA] Change the computer name to ensure naming consistency

13 months ago[FONTS] Disable vgaoem.fon to fix font display problems
Katayama Hirofumi MZ [Sat, 10 Oct 2020 12:09:59 +0000 (21:09 +0900)]
[FONTS] Disable vgaoem.fon to fix font display problems

The vgaoem.fon font file was added at 383ea7d.
But adding vgaoem.fon made a regression in font display on FireFox 48.
So, we temporarily disable this font file.


13 months ago[FONTS] Make vgaoem.fon monospaced in settings
Katayama Hirofumi MZ [Sat, 10 Oct 2020 12:05:09 +0000 (21:05 +0900)]
[FONTS] Make vgaoem.fon monospaced in settings

The font file vgaoem.fon was not monospaced in font file settings.

13 months ago[SYSSETUP] fr-FR: Change keyboard accelerator for Owner Organization field (#3282)
Serge Gautherie [Thu, 8 Oct 2020 20:41:33 +0000 (22:41 +0200)]
[SYSSETUP] fr-FR: Change keyboard accelerator for Owner Organization field (#3282)

'S' is already used for Next ('Suivant') button.

13 months ago[GFLAGS] ModifyStatus(): Remove a remnant HeapFree() (#3283)
Serge Gautherie [Thu, 8 Oct 2020 20:39:31 +0000 (22:39 +0200)]
[GFLAGS] ModifyStatus(): Remove a remnant HeapFree() (#3283)

Addendum to ec62127. CORE-17325

13 months ago[NTOS:MM] Print debugging information in case CORE-16449 happens.
Thomas Faber [Thu, 8 Oct 2020 06:39:21 +0000 (08:39 +0200)]
[NTOS:MM] Print debugging information in case CORE-16449 happens.

14 months ago[BOOTDATA][FONTS] Add vgaoem.fon font (#3272)
Adam Słaboń [Tue, 6 Oct 2020 14:39:14 +0000 (16:39 +0200)]
[BOOTDATA][FONTS] Add vgaoem.fon font (#3272)

Converted from the XFree vga.bdf font.
This is needed for Vista+ x64 Winload. ReactOS x64 now boots with Vista x64 Winload out of the box (like Windows Server 2003 x64).
Tested with winload.exe from Vista x64 RTM (6.0.6000.16386) and winload.efi from Server 2008 x64 Beta 3 (6.0.6001.16497).

14 months ago[BROWSEUI] Remove '\1' from AutoComplete list (#3264)
Katayama Hirofumi MZ [Tue, 6 Oct 2020 08:44:20 +0000 (17:44 +0900)]
[BROWSEUI] Remove '\1' from AutoComplete list (#3264)

Delete "backslash one" (indicates SW_ values) from auto-completion list. CORE-9281

14 months ago[BOOTDATA] Comment out biosinfo.inf (#3266)
Adam Słaboń [Mon, 5 Oct 2020 21:20:03 +0000 (23:20 +0200)]
[BOOTDATA] Comment out biosinfo.inf (#3266)

This entry is unused as there is no biosinfo.inf anywhere yet, and it only breaks boot with NTLDR.

14 months ago[WINLOGON] Display the shutdown message popup dialog on the current input desktop... 3259/head
Hermès Bélusca-Maïto [Sat, 3 Oct 2020 23:31:31 +0000 (01:31 +0200)]
[WINLOGON] Display the shutdown message popup dialog on the current input desktop. (#3259)

Display the shutdown message popup dialog on the current input desktop,
and periodically monitor for any change of the input desktop. When the
latter changes, close the dialog and recreate it on the new input desktop.

In addition, retain the current dialog position and restore it when the
dialog is recreated on the new desktop.

14 months ago[WINLOGON] Minor formatting only.
Hermès Bélusca-Maïto [Sat, 3 Oct 2020 23:01:46 +0000 (01:01 +0200)]
[WINLOGON] Minor formatting only.

Add also original author's name (from original PR #458).

14 months ago[NTDLL:CSR] Perform more thorough validation of the parameters in CsrAllocateCaptureB...
Hermès Bélusca-Maïto [Mon, 5 Oct 2020 00:15:14 +0000 (02:15 +0200)]
[NTDLL:CSR] Perform more thorough validation of the parameters in CsrAllocateCaptureBuffer().

Complements commit 7e2db773.

- Validate the argument count.

- Validate the total buffer size: the total size of the header plus
  the pointer-offset array and the provided buffer, together with
  the alignment padding for each argument, must be less than MAXLONG
  aligned to 4-byte boundary.

14 months ago[NTDLL:CSR] Fix a bug in the calculation of the capture buffer size in CsrAllocateCap...
Hermès Bélusca-Maïto [Mon, 5 Oct 2020 00:01:52 +0000 (02:01 +0200)]
[NTDLL:CSR] Fix a bug in the calculation of the capture buffer size in CsrAllocateCaptureBuffer().

Take the alignment padding for each argument into account, **BEFORE**
doing the final size alignment on a 4-byte boundary. Thus, the capture
buffer size value is properly aligned, and passes the validation tests
on the server side (in CSRSRV!CsrCaptureArguments), see commit 7e2db773.

This bug was put in evidence in x64 builds where the memory alignments
were more tight than in the x86 builds.

14 months ago[BROWSEUI] Fix assertion in CACLCustomMRU::AddMRUString
Hirofumi Katayama [Sun, 4 Oct 2020 23:49:42 +0000 (08:49 +0900)]
[BROWSEUI] Fix assertion in CACLCustomMRU::AddMRUString


14 months ago[SHLWAPI] Fix parameter ordering at call of AutoComplete_AdaptFlags
Hirofumi Katayama [Sun, 4 Oct 2020 23:47:21 +0000 (08:47 +0900)]
[SHLWAPI] Fix parameter ordering at call of AutoComplete_AdaptFlags


14 months ago[SHELL32][BROWSEUI] Fix usage of ILGetDisplayNameEx
Mark Jansen [Sun, 13 Sep 2020 13:03:24 +0000 (15:03 +0200)]
[SHELL32][BROWSEUI] Fix usage of ILGetDisplayNameEx

14 months ago[BROWSEUI] Show virtual folders in the log for SHOpenFolderWindow
Mark Jansen [Sun, 13 Sep 2020 13:02:43 +0000 (15:02 +0200)]
[BROWSEUI] Show virtual folders in the log for SHOpenFolderWindow

14 months ago[BROWSEUI] Update the current directory before creating a view
Mark Jansen [Sun, 13 Sep 2020 12:30:04 +0000 (14:30 +0200)]
[BROWSEUI] Update the current directory before creating a view
This way, when the view asks for a directory _during creation_ it
does not get either an old, or an invalid directory

14 months ago[BROWSEUI] Remove refactoring leftovers
Mark Jansen [Sun, 13 Sep 2020 12:29:17 +0000 (14:29 +0200)]
[BROWSEUI] Remove refactoring leftovers

14 months ago[WDMAUD.DRV] Revert "Workaround multiple issues with AC97 driver from rapps"
Joachim Henze [Sat, 3 Oct 2020 14:39:13 +0000 (16:39 +0200)]
[WDMAUD.DRV] Revert "Workaround multiple issues with AC97 driver from rapps"

This reverts commit 0.4.15-dev-791-g

It was a workaround just. To bypass sysaudio. It had a very positive effect on
our playback performance, but using the different codepaths did also lead to
regressions, that I have no idea how to address, therefore I think it's my
personal responsibility to revert it. I guess it's better to improve on the
code-paths that we intend to use finally, instead of fixing what will
be dead paths in the future.

The revert will fix:
- CORE-17277 crash of dsound:duplex on "GCCLin_x86 on Test VBox"
- CORE-17278 crash of dsound:capture on "GCCLin_x86 on Test VBox"
- CORE-17285 Realtek HD Audio does no longer work in ReactOS

But ofc now we will suffer again from very severe things that the hack could workaround:
- CORE-13202 Unhandled exception from wdmaud.drv when recording sound in Scratch 1.4 leads to app-crash
- CORE-13488 A deadlock in "DiabloII" character selection screen and "The Lion King II"
- CORE-8726/CORE-9986/CORE-16564 AC97 driver from rapps will need reboot-orgies again, does not longer
  work in the same session that we installed the driver
- CORE-9981 "DosBox + Commander Keen6" totally garbled sound output instead of music
    "ScummVM 2.0 with Monkey Island 2" totally garbled sound output instead of music
- the test execution times of "GCCLin_x86 on Test VBox" will almost double

14 months ago[COMCTL32] Button.c Fix CORE-17260
Joachim Henze [Sat, 3 Oct 2020 13:38:02 +0000 (15:38 +0200)]
[COMCTL32] Button.c Fix CORE-17260

Press'n'Hold of a button, then leaving the button rect
should redraw the button in unpressed state

Thanks to JIRA user 'I_kill_Bugs' for perfecting
my initial experiments to fix that.

It regressed by 0.4.9-dev-719-g

No need to sync anything with Wine, their code is
correct on Wine head. The bug was in ros specific diff.

14 months ago[NTOS:MM] Fail on SizeOfRawData overflow. CORE-17284 3245/head
Thomas Faber [Sun, 27 Sep 2020 15:48:33 +0000 (17:48 +0200)]
[NTOS:MM] Fail on SizeOfRawData overflow. CORE-17284

Fixes the corresponding tests in ntdll_apitest:NtMapViewOfSection.
Also add a TODO for the remaining test failures.

14 months ago[NTOS:MM] VirtualSize overrides SizeOfRawData when mapping PE files. CORE-17284
Thomas Faber [Sun, 27 Sep 2020 14:43:19 +0000 (16:43 +0200)]
[NTOS:MM] VirtualSize overrides SizeOfRawData when mapping PE files. CORE-17284

This fixes the related failures in ntdll_apitest:NtMapViewOfSection
as well as loading of OrgPlayer's DragDrop.ocx.

14 months ago[NTDLL_APITEST] Add test for an image file where SizeOfRawData > VirtualSize. CORE...
Thomas Faber [Sun, 27 Sep 2020 14:42:29 +0000 (16:42 +0200)]
[NTDLL_APITEST] Add test for an image file where SizeOfRawData > VirtualSize. CORE-17284

14 months ago[NTDLL:LDR] Fail if section creation fails in LdrpCreateDllSection. CORE-17284
Thomas Faber [Sun, 27 Sep 2020 14:41:34 +0000 (16:41 +0200)]
[NTDLL:LDR] Fail if section creation fails in LdrpCreateDllSection. CORE-17284

Otherwise we'd call ZwQuerySection on an invalid handle and get:
(ntoskrnl/mm/section.c:4320) Failed to reference section: 0xc0000008

Also correctly check DllCharacteristics: If the argument is missing, the
file is _not_ a system file, i.e. we should check for restrictions.

14 months ago[TCPIP] Add NULL checks in DispTdiQueryInformation. CORE-12274 2972/head
Thomas Brogan [Mon, 27 Jul 2020 21:08:00 +0000 (00:08 +0300)]
[TCPIP] Add NULL checks in DispTdiQueryInformation. CORE-12274

Add additional NULL checks to DispTdiQueryInformation,

Co-authored-by: Peter Hater <>
14 months ago[BROWSEUI] Accept TypedURLs to CLSID_ACLCustomMRU (#3250)
Katayama Hirofumi MZ [Fri, 2 Oct 2020 12:27:23 +0000 (21:27 +0900)]
[BROWSEUI] Accept TypedURLs to CLSID_ACLCustomMRU (#3250)

Related to #3249. IACLCustomMRU has a special case of TypedURLs. The TypedURLs key consists of the registry values of "url1", "url2", "url3" etc instead of "MRUList", "a", "b" etc. CORE-9281