Pierre Schweitzer [Sat, 2 Mar 2019 09:29:26 +0000 (10:29 +0100)]
[NTOSKRNL] Add a test for ExUuidCreate
Eric Kohl [Fri, 1 Mar 2019 21:01:14 +0000 (22:01 +0100)]
[SNDVOL32] In record mode, rename the 'Mute' autocheckbox to 'Select', turn it into a checkbox and make it behave like a radiobutton.
Pierre Schweitzer [Wed, 27 Feb 2019 20:12:32 +0000 (21:12 +0100)]
[NTOSKRNL] Rewrite/fix our UUID generation implementation
So that it matches Windows behavior
Also implement ExUuidCreate that will generate UUID version 1
The implementation is based on the RFC 4122
Pierre Schweitzer [Wed, 27 Feb 2019 08:02:30 +0000 (09:02 +0100)]
[NTOSKRNL] Introduce the UUID_CACHED_VALUES_STRUCT structure
Source: https://blog.48bits.com/el-codigo-ntoskvinci/
Pierre Schweitzer [Wed, 27 Feb 2019 07:54:48 +0000 (08:54 +0100)]
[NTOSKRNL] UuidMutex -> ExpUuidLock
Bișoc George [Sun, 24 Feb 2019 15:40:02 +0000 (16:40 +0100)]
[OSK] Implement "Use Click Sound" feature
- Implement the save/load handler for this feature
- Check the "Use Click Sound" item state accordingly depending if it's enabled or disabled
- Use PlaySoundW() to play the wave sound file from resource
- Add the WAV sound click file. The work is made thanks to Midori Mizuno
Thomas Faber [Wed, 27 Feb 2019 14:02:38 +0000 (15:02 +0100)]
[HDAUDBUS] Wait until the correct number of responses was received. CORE-15465
We previously only gave the device a hard-coded amount of time to respond,
which could lead to interpreting the contents of uninitialized memory as
a response. This would lead to an unreasonably large number of audio function
groups being detected.
A KSEMAPHORE mirrors what Haiku uses here, though it may not be the optimal
synchronization primitive for this case under Windows.
Thomas Faber [Wed, 27 Feb 2019 13:34:23 +0000 (14:34 +0100)]
[HDAUDBUS] Handle responses in a DPC instead of the ISR.
Thomas Faber [Wed, 27 Feb 2019 14:02:23 +0000 (15:02 +0100)]
[HDAUDBUS] Fix a DPRINT.
Thomas Faber [Wed, 27 Feb 2019 09:51:02 +0000 (10:51 +0100)]
[HDAUDBUS] Prevent overflow of the AudioGroups array. CORE-14153 CORE-15465
This protects against crashing in case of faulty/malicious hardware,
but also works around a bug in HDA_SendVerbs that causes it to return
invalid data, thereby suggesting more groups than are actually present.
Bișoc George [Tue, 26 Feb 2019 14:49:47 +0000 (15:49 +0100)]
[SNDVOL32] Small Italian translation update
Thomas Faber [Sun, 24 Feb 2019 11:29:34 +0000 (12:29 +0100)]
[HDAUDBUS] Implement HDA_Unload. Stub HDA_Power and HDA_SystemControl.
Thomas Faber [Mon, 25 Feb 2019 00:56:25 +0000 (01:56 +0100)]
[HDAUDBUS] Correctly mask register values.
See https://github.com/haiku/haiku/blob/master/src/add-ons/kernel/drivers/audio/hda/hda_controller.cpp
and https://github.com/haiku/haiku/blob/master/src/add-ons/kernel/drivers/audio/hda/driver.h#L118-L140
This fixes various device reset failures and probably other issues.
Thomas Faber [Mon, 25 Feb 2019 12:47:14 +0000 (13:47 +0100)]
[HDAUDBUS] Implement PDO removal. CORE-14617
Thomas Faber [Sun, 24 Feb 2019 13:33:41 +0000 (14:33 +0100)]
[HDAUDBUS] Implement FDO removal. CORE-14617
Thomas Faber [Sun, 24 Feb 2019 11:23:45 +0000 (12:23 +0100)]
[HDAUDBUS] Use IoForwardIrpSynchronously instead of HDA_SyncForwardIrp.
Thomas Faber [Mon, 25 Feb 2019 11:48:54 +0000 (12:48 +0100)]
[HDAUDBUS] Forward FDO requests instead of completing them.
Thomas Faber [Sat, 23 Feb 2019 20:52:21 +0000 (21:52 +0100)]
[HDAUDBUS] Use a switch for minor function codes.
Thomas Faber [Sat, 23 Feb 2019 20:50:05 +0000 (21:50 +0100)]
[HDAUDBUS] Split FDO/PDO PNP handling into separate functions.
Thomas Faber [Sat, 23 Feb 2019 08:55:57 +0000 (09:55 +0100)]
[HDAUDBUS] Minor fixes:
* Add some forward-declarations
* Add some annotations
* Improve a DPRINT
Pierre Schweitzer [Mon, 25 Feb 2019 21:33:31 +0000 (22:33 +0100)]
[MSAFD] Don't leak event while querying/setting socket options
Pierre Schweitzer [Mon, 25 Feb 2019 21:30:01 +0000 (22:30 +0100)]
[MSAFD] Implement socket options SO_SNDBUF and SO_RCVBUF
Pierre Schweitzer [Mon, 25 Feb 2019 21:28:18 +0000 (22:28 +0100)]
[AFD_APITEST] Add apitest for AFD window size options
Pierre Schweitzer [Mon, 25 Feb 2019 21:27:00 +0000 (22:27 +0100)]
[AFD] Don't allow caller to set broken values to window sizes
This will avoid 0-sized allocations, or -1-sized allocations.
So far, it's maxed by hard value stored in TCPIP.sys. I believe
this is not right and would deserve a true fix
Pierre Schweitzer [Mon, 25 Feb 2019 21:25:03 +0000 (22:25 +0100)]
[AFD] Add default window sizes on socket creation
Mark Jansen [Sat, 23 Feb 2019 15:24:21 +0000 (16:24 +0100)]
[XDK] Remove _M_AMD64 special case
Mark Jansen [Mon, 11 Feb 2019 21:45:48 +0000 (22:45 +0100)]
[APPHELP] Implement SdbRegisterDatabase[Ex]
CORE-11301
Mark Jansen [Mon, 11 Feb 2019 21:44:30 +0000 (22:44 +0100)]
[APPHELP][APPHELP_APITEST] Implement SdbGetDatabaseInformation
CORE-11301
Mark Jansen [Sun, 6 Jan 2019 16:51:55 +0000 (17:51 +0100)]
[APPHELP] Implement ShimDumpCache and ShimFlushCache
These functions simply call into the Base* functions,
having a prototype that is compatible with rundll32
CORE-11301
Mark Jansen [Thu, 3 Jan 2019 22:24:54 +0000 (23:24 +0100)]
[SDB] Initial SdbRegisterDatabase stubs
CORE-11301
Mark Jansen [Fri, 23 Jun 2017 19:47:36 +0000 (21:47 +0200)]
[APPHELP_APITEST] Add a test for shim database registration
CORE-11301
Stanislav Motylkov [Mon, 25 Feb 2019 10:41:41 +0000 (13:41 +0300)]
[MODULES][WALLPAPERS] Fix build (#1375)
Some file names still contained space instead of underline. Addendum to
0760802.
Luo Yufan [Sun, 24 Feb 2019 23:36:53 +0000 (07:36 +0800)]
[TRANSLATION] Update Chinese and Traditional Chinese translations. (#1369)
Pierre Schweitzer [Sun, 24 Feb 2019 20:25:39 +0000 (21:25 +0100)]
[MSAFD] Make WSPSetSockOpt() SO_RCVBUF stub return success
Timo Kreuzer [Sun, 24 Feb 2019 12:24:26 +0000 (13:24 +0100)]
[NTOS::Mm] Fix inverted check in MiWriteProtectSystemImage
Dylan Navas [Sun, 24 Feb 2019 17:08:26 +0000 (14:08 -0300)]
[MODULES] Fix CMakeLists.txt for wallpapers module. (#1294)
* Add all wallpapers to the ISO and can look how enable the module in ReadMe.txt
* Remove blanks in name.
* Moving to folder with same wallpaper style.
* Adding and updating CMakeLists.txt.
* Update ReadMe.txt.
Serge Gautherie [Sun, 24 Feb 2019 16:53:39 +0000 (17:53 +0100)]
[KMTEST] Fix 3 Clang-Cl warnings about Status and Callbacks (#502)
* 1 "warning: variable 'Status' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]"
* 2 "warning: comparison of unsigned expression < 0 is always false [-Wtautological-unsigned-zero-compare]"
* Use a consistent type for "i" and fix a comment
* Also update licence header.
CORE-14306
Eric Kohl [Sun, 24 Feb 2019 16:15:13 +0000 (17:15 +0100)]
[MMSYS] Volume page: Initialize the volume trackbar before it might be disabled because the tick marks must be visible on a disabled trackbar.
Eric Kohl [Sun, 24 Feb 2019 15:56:55 +0000 (16:56 +0100)]
[MMSYS] Sounds page: Update the 'Play' button and the current item in the 'Program events' treeview when a sound is selected or deselected.
Eric Kohl [Sun, 24 Feb 2019 15:12:55 +0000 (16:12 +0100)]
[SNDVOL32] Disable only the 'Play' button, when no audio device is avaiblable.
Stanislav Motylkov [Sat, 23 Feb 2019 21:44:12 +0000 (00:44 +0300)]
[MSGINA] Add bar bitmap to logon and shutdown dialogs
Stanislav Motylkov [Sat, 23 Feb 2019 20:52:22 +0000 (23:52 +0300)]
[MSGINA] Improve Ctrl-Alt-Del invitation window
Stanislav Motylkov [Sat, 23 Feb 2019 20:34:22 +0000 (23:34 +0300)]
[MSGINA] Implement rotation bar animation
Based on initial work by Bisoc George. Rotation bar image by Zcooger. CORE-15215
Eric Kohl [Sun, 24 Feb 2019 14:35:36 +0000 (15:35 +0100)]
[MMSYS] Disable the 'Low' and 'High' text of the volume trackbar and the 'Place volume icon in the taskbar' checkbox when no sound device is available.
Raul Tambre [Sun, 24 Feb 2019 09:37:42 +0000 (11:37 +0200)]
[WINLOGON] Fix fallback keyboard layout flags
Eric Kohl [Sun, 24 Feb 2019 11:50:37 +0000 (12:50 +0100)]
[SNDVOL32] Advanced Controls dialog: Implemented the Bass and Treble trackbars.
Please check if they are working correctly. I have no way to check them myself.
Eric Kohl [Sat, 23 Feb 2019 16:26:48 +0000 (17:26 +0100)]
[SNDVOL32] Remove trailing whitespace
Eric Kohl [Sat, 23 Feb 2019 16:21:25 +0000 (17:21 +0100)]
[SNDVOL32] Resize the dialog and groupbox when there are two 'Other Controls'
Pierre Schweitzer [Sat, 23 Feb 2019 12:34:28 +0000 (13:34 +0100)]
[WS2_32] Use SEH in WSCGetProviderPath()
Eric Kohl [Sat, 23 Feb 2019 11:51:14 +0000 (12:51 +0100)]
[SNDVOL32] Advanced Controls dialog: Initialize the Other Controls
Pierre Schweitzer [Sat, 23 Feb 2019 09:57:06 +0000 (10:57 +0100)]
[WS2_32] Implement WSCGetProviderPath()
Eric Kohl [Fri, 22 Feb 2019 22:33:47 +0000 (23:33 +0100)]
[SNDVOL32] Advanced controls dialog: Remove the TBS_AUTOTICKS style from the trackbars and initialize them properly.
Eric Kohl [Thu, 21 Feb 2019 21:26:58 +0000 (22:26 +0100)]
[SNDVOL32] Move the advanced controls dialog to a separate file and update its title on creation.
Serge Gautherie [Wed, 20 Feb 2019 21:16:16 +0000 (22:16 +0100)]
[NDK] Fix 'DeletedChidren' typo (#1367)
On behalf of Vadim Galyant.
CORE-15769
Pierre Schweitzer [Wed, 20 Feb 2019 20:01:46 +0000 (21:01 +0100)]
[VIDEOPRT] Don't return uninitialized memory
Mark Jansen [Tue, 19 Feb 2019 20:32:51 +0000 (23:32 +0300)]
[SNDVOL32] Fix parsing dialog icons
Stanislav Motylkov [Tue, 19 Feb 2019 13:51:39 +0000 (16:51 +0300)]
[SNDVOL32] Add left and right balance icons
Thomas Faber [Wed, 20 Feb 2019 11:21:03 +0000 (12:21 +0100)]
[NTOS:PNP] Correctly respect data size in PnpRegSzToString. CORE-15766
Spotted by Vadim Galyant.
Thomas Faber [Wed, 20 Feb 2019 11:03:03 +0000 (12:03 +0100)]
[NTDLL_APITEST] Show that registry strings can be longer than MAXUSHORT.
Stanislav Motylkov [Tue, 19 Feb 2019 12:54:38 +0000 (15:54 +0300)]
[SNDVOL32] Add Russian translation
Addendum to
fe5c50e and
e6be187.
Michael Fritscher [Fri, 1 Feb 2019 19:14:00 +0000 (22:14 +0300)]
[FREELDR] PXE: Fix network packet size
1024 bytes should fit into a single network packet. CORE-15706
Eric Kohl [Mon, 18 Feb 2019 23:01:18 +0000 (00:01 +0100)]
[SNDVOL32] Add the 'Advanced Controls for Volume Control' dialog. It does nothing useful yet.
Mark Jansen [Sun, 17 Feb 2019 19:46:47 +0000 (20:46 +0100)]
[MSI] Prevent uninitialized variable usage
Mark Jansen [Sun, 17 Feb 2019 19:46:24 +0000 (20:46 +0100)]
[MSI] Do not leak rootkey
Mark Jansen [Sat, 16 Feb 2019 17:35:08 +0000 (18:35 +0100)]
[SHELL32] Abort change notifications on a nullptr
CORE-15703
Eric Kohl [Sun, 17 Feb 2019 23:58:28 +0000 (00:58 +0100)]
[SNDVOL32] Implement the dialog resize code for the 'Advanced Controls' menu item and prepare for clicks on the 'Advanced' button.
Eric Kohl [Sun, 17 Feb 2019 13:04:39 +0000 (14:04 +0100)]
[SNDVOL32] Fix the window height issue when the line selection changes and implement the 'Advanced Controls' menu item.
CORE-9108 CORE-15751
Thomas Faber [Sun, 17 Feb 2019 08:58:28 +0000 (09:58 +0100)]
[RTL] Fix GCC build.
Thomas Faber [Fri, 15 Feb 2019 18:43:25 +0000 (19:43 +0100)]
[ACPI] Update ACPICA library to version
20190215.
Thomas Faber [Sun, 3 Feb 2019 15:55:04 +0000 (16:55 +0100)]
[COMCTL32] Check for NULL pointer when handling BCM_GETIDEALSIZE.
Fixes crash in comctl32_winetest:button.
Thomas Faber [Sun, 3 Feb 2019 15:41:29 +0000 (16:41 +0100)]
[COMCTL32] Add NULL checks to SetWindowSubclass.
Imports Wine commit
04847e68f87 by Sven Baars.
Fixes crash in comctl32_winetest:subclass.
Thomas Faber [Sun, 3 Feb 2019 12:57:21 +0000 (13:57 +0100)]
[RTL] Protect pointer validity check in RtlFreeHeap with SEH.
Fixes crash in kernel32_winetest:heap.
Hermès Bélusca-Maïto [Sun, 17 Feb 2019 00:10:27 +0000 (01:10 +0100)]
[CMLIB] Assign a signature to the in-memory HHIVE registry hive structure. CORE-15753
Makes the `!reg hivelist` WinDbg command working in ReactOS.
Dedicated to Mark Jansen.
See for more details:
https://webcache.googleusercontent.com/search?q=cache:fmHJX9eFGkkJ:https://blogs.technet.microsoft.com/ganand/archive/2008/01/05/internal-structures-of-the-windows-registry.aspx
and
http://moyix.blogspot.com/2008/02/enumerating-registry-hives.html
Hermès Bélusca-Maïto [Sun, 17 Feb 2019 00:07:56 +0000 (01:07 +0100)]
[CMLIB] Minor code style changes only: Use slightly more explicit signature #define names so that we know to which hive structure they correspond.
Hermès Bélusca-Maïto [Sat, 16 Feb 2019 23:54:59 +0000 (00:54 +0100)]
[NTOS:CM] Set and reset the CMHIVE HiveIsLoading flag adequately. Fix an assertion in CmFlushKey() and reset the CMHIVE ViewLockOwner when releasing the view lock.
Eric Kohl [Sat, 16 Feb 2019 19:36:46 +0000 (20:36 +0100)]
[SNDVOL32] AUTORADIOBUTTONs are AUTORADIOBUTTONs, not PUSHBUTTONs
Eric Kohl [Sat, 16 Feb 2019 18:22:57 +0000 (19:22 +0100)]
[SNDVOL32] Change the menu item prefix from IDC to IDM
Mark Jansen [Sat, 16 Feb 2019 14:07:49 +0000 (15:07 +0100)]
[WIN32K:NTUSER] Do not try to reposition an off-screen menu as if it were a popup menu
CORE-15733
Pierre Schweitzer [Sat, 16 Feb 2019 13:12:01 +0000 (14:12 +0100)]
[KERNEL32] Stub SetThreadErrorMode()
Now, Steam crashes because of the stub of GetSystemTimePreciseAsFileTime
CORE-14966
Eric Kohl [Sat, 16 Feb 2019 12:54:46 +0000 (13:54 +0100)]
[SNDVOL32] Enable the balance and volume trackbars only if the line has a volume fader control.
Pierre Schweitzer [Sat, 16 Feb 2019 12:46:40 +0000 (13:46 +0100)]
[MSAFD] Add an initial implementation of SIO_GET_EXTENSION_FUNCTION_POINTER IOCTL
Also stub the related functions the IOCTL will return, namely: WSAID_ACCEPTEX,
WSAID_CONNECTEX, WSAID_DISCONNECTEX, WSAID_GETACCEPTEXSOCKADDRS
This will allow Steam client not to fail in an ASSERT
related to the Steam client PlatformSocketsInit function.
Even though, this doesn't fix Steam running on ReactOS since its UI requires
a Windows 7 API from Kernel32: SetThreadErrorMode().
Nota: its crash got fixed thanks to the Wine sync done recently.
CORE-14966
Eric Kohl [Sat, 16 Feb 2019 11:57:19 +0000 (12:57 +0100)]
[SNDVOL32] Disable the Mute checkbox for all lines that do not have a mute switch control
Pierre Schweitzer [Sat, 16 Feb 2019 09:01:50 +0000 (10:01 +0100)]
[E1000] Remove useless null check
CID 512827
Pierre Schweitzer [Sat, 16 Feb 2019 08:58:44 +0000 (09:58 +0100)]
[E1000] Don't attempt to free uninitialized pointer
CID
1442660
Katayama Hirofumi MZ [Sat, 16 Feb 2019 08:27:25 +0000 (17:27 +0900)]
msgdump.h undocumented drag & drop support (#1359)
In sdk/include/reactos/msgdump.h, support Drag & Drop undocumented messages.
Pierre Schweitzer [Sat, 16 Feb 2019 08:05:15 +0000 (09:05 +0100)]
[IPHLPAPI] Properly handle GetModuleBaseName failure
CID
1442662,
1442663
Pierre Schweitzer [Sat, 16 Feb 2019 08:00:06 +0000 (09:00 +0100)]
[IPHLPAPI] Check pointers when returning module info from specific connection
Pierre Schweitzer [Sat, 16 Feb 2019 07:48:08 +0000 (08:48 +0100)]
[IPHLPAPI] Remove dead code
CID 513306,
1442673,
1442697
Pierre Schweitzer [Thu, 14 Feb 2019 09:48:32 +0000 (10:48 +0100)]
[FASTFAT] On volume open, update share access if volume was already open
It was never updated afterwards, leading to a totally loss of share
access information amongst callers.
Pierre Schweitzer [Thu, 14 Feb 2019 09:12:31 +0000 (10:12 +0100)]
[VFATLIB] Don't forcibly delete LFN when not in RW mode
Bișoc George [Wed, 13 Feb 2019 14:22:28 +0000 (15:22 +0100)]
[USETUP] Check the status value of BuildInstallPaths() (#1349)
Julian Kirsch [Wed, 13 Feb 2019 12:12:52 +0000 (13:12 +0100)]
[NSLOOKUP] Fix crash in case of no network connectivity (#1354)
Prevent nslookup.exe from crashing when executed in a ROS VM with no network
interfaces. This is due to a NULL pointer dereference occurring if
`GetNetworkParams` in `main` fails with an error other than
`ERROR_BUFFER_OVERFLOW`. In this case, `pNetInfo` remains initialized to
NULL, causing `strncpy` to crash.
Bișoc George [Wed, 13 Feb 2019 12:11:17 +0000 (13:11 +0100)]
[CRYPTEXT] Add Romanian & Italian translations (#1352)
Bișoc George [Wed, 13 Feb 2019 12:10:54 +0000 (13:10 +0100)]
[OSK] Romanian & Italian translations update (#1353)
Andrew Cook [Wed, 13 Feb 2019 08:33:10 +0000 (19:33 +1100)]
[RAMDISK] Fix unterminated query table
Timo Kreuzer [Sun, 3 Feb 2019 23:06:35 +0000 (00:06 +0100)]
[CRT] Implement thread/fiber safe support for MSVC and Clang-CL
This is the most trivial (but also most efficient) implementation possible. Should be good enough for now.
Timo Kreuzer [Sun, 3 Feb 2019 22:36:49 +0000 (23:36 +0100)]
[CRT] Use alias names for rot functions when compiling with Clang-CL
Clang-CL does not support #pragma function like CL. The alternative to this approach is to disable all intrinsics for this single source file, but that is not trivial to do, as it can only be done by removing a compiler switch, which we have no CMake support for. Therefore this solution is simpler and as good.
Timo Kreuzer [Sun, 3 Feb 2019 18:57:30 +0000 (19:57 +0100)]
[MVDM] hack-fix Clang-CL build
Timo Kreuzer [Sun, 3 Feb 2019 17:25:04 +0000 (18:25 +0100)]
[CPPRT] Implement __std_terminate wrapper for Clang-CL
Timo Kreuzer [Sun, 3 Feb 2019 17:04:03 +0000 (18:04 +0100)]
[NDK] Fix INIT_SECTION for Clang (use the GCC definition)