Thomas Faber [Sun, 15 Feb 2015 09:29:32 +0000 (09:29 +0000)]
[KMTESTS:KE]
- Enable KeSpinLock test that apparently never made it into testlist.c for some reason?
svn path=/trunk/; revision=66277
Johannes Anderwald [Sun, 15 Feb 2015 09:03:08 +0000 (09:03 +0000)]
[INF]
- add wdmaudio.inf
svn path=/trunk/; revision=66276
Hermès Bélusca-Maïto [Sun, 15 Feb 2015 02:07:23 +0000 (02:07 +0000)]
[WINLOGON][USER32]
Fix the explanations of how Windows/ReactOS should shut down (it's winlogon itself that calls NtShutdownSystem, not something else; that story about "SMSS API #1" concerns the SMSS API SmpSessionCompleteApi called by the helper function SmSessionComplete which is in turn called by CSRSS function CsrDereferenceNtSession, when all win32 processes are gone, as it should).
The webpage http://www.reactos.org/wiki/ShutdownProcess should be corrected for.
[USER32]
Whitespace fixes for winstation code.
svn path=/trunk/; revision=66275
Timo Kreuzer [Sun, 15 Feb 2015 00:26:41 +0000 (00:26 +0000)]
[NTOSKRNL]
Demote the "HACK: RemainingAccess = 0x%08lx DesiredAccess = 0x%08lx\n" from DPRINT1 to DPRINT, since it's massively spamming the log.
See CORE-9184
svn path=/trunk/; revision=66274
Timo Kreuzer [Sun, 15 Feb 2015 00:05:50 +0000 (00:05 +0000)]
[WIN32K]
In NtGdiGetDIBitsInternal limit the size of what is being copied back to to usermode to the cjMaxInfo parameter. Fixes crash of Firefox when downloading files.
CORE-8895 #resolve
svn path=/trunk/; revision=66273
Pierre Schweitzer [Sat, 14 Feb 2015 20:55:47 +0000 (20:55 +0000)]
[NTFS]
Query the value of NtfsMftZoneReservation on mount.
Not used yet.
CORE-8725
svn path=/trunk/; revision=66272
Hermès Bélusca-Maïto [Sat, 14 Feb 2015 19:56:04 +0000 (19:56 +0000)]
[SHELL32]
- magic_value--;
- Don't assign a desktop background colour by default. So that we can get the safe-mode background working (in safe mode), while having the default desktop background colours in normal situations.
Patch by Giannis.
svn path=/trunk/; revision=66271
Thomas Faber [Sat, 14 Feb 2015 19:14:32 +0000 (19:14 +0000)]
[RTL]
- Implement RtlIpv4StringToAddressExW. Patch by Mark Jansen.
CORE-6490
svn path=/trunk/; revision=66270
Timo Kreuzer [Sat, 14 Feb 2015 19:07:36 +0000 (19:07 +0000)]
[DRIVERS]
Fix a few MSVC warnings
svn path=/trunk/; revision=66269
Timo Kreuzer [Sat, 14 Feb 2015 18:58:52 +0000 (18:58 +0000)]
[CMAKE]
Disable MSVC linker warning LNK4078 (multiple sections found with different attributes) for INIT sections.
svn path=/trunk/; revision=66268
Timo Kreuzer [Sat, 14 Feb 2015 17:04:42 +0000 (17:04 +0000)]
[PSDK]
Add #ifdef include guards to winnt.h. RC doesn't seem to support #pragma once and emits a redefinition warning, since with RC we first include winnt.h without STRICT defined, then again from windef.h with STRICT defined.
svn path=/trunk/; revision=66267
Timo Kreuzer [Sat, 14 Feb 2015 15:44:44 +0000 (15:44 +0000)]
[CMAKE]
- Disable warning C4800: forcing value to bool 'true' or 'false' (performance warning). This is emitted when assigning an integer value to a C++ bool, which is always true (1) or false (0), so assigning an integer to it, will result in an implicit comparison against 0. But "fixing" this warning by adding an explicit comparison ("bool f = (i != 0);") will actually result in LESS efficient code (for whatever reasons). So this warning can be considered entirely useless and counter productive.
- Remove C4018 (signed/unsigned mismatch) from the TODO in the disable list. A comparison between an unsigned and a signed value will very likely result in wrong behavior and can easily cause hard to spot security bugs (e.g. when doing overflow checks). It is also often easy to fix.
svn path=/trunk/; revision=66266
Pierre Schweitzer [Sat, 14 Feb 2015 15:41:44 +0000 (15:41 +0000)]
[NTFS]
NtfsMoonWalkID():
- Do not allow opening a file by ID if it's not in use any longer
- Do not attempt to create the full path, if an error occured during walk
svn path=/trunk/; revision=66265
Pierre Schweitzer [Sat, 14 Feb 2015 15:35:35 +0000 (15:35 +0000)]
[NTFS]
Simplify the implementation of the "Open by ID" feature of our driver.
Instead of creating singleton FCB not linked to the rest of FS tree, just walk the whole path down, to recreate it.
This doesn't make nfi work properly though. Will investigate more.
CORE-8725
svn path=/trunk/; revision=66264
Timo Kreuzer [Sat, 14 Feb 2015 14:28:02 +0000 (14:28 +0000)]
[SPEC2DEF]
Silence warning about ignored C++ redirections
svn path=/trunk/; revision=66263
Timo Kreuzer [Sat, 14 Feb 2015 14:07:50 +0000 (14:07 +0000)]
[GDI32_APITEST]
Add additional tests for CreateBitmap and fix a test.
Patch by Victor Martinez
ROSTESTS-56 #resolve
svn path=/trunk/; revision=66262
David Quintana [Sat, 14 Feb 2015 14:00:24 +0000 (14:00 +0000)]
[BROWSEUI]
* Convert some leftover DbgPrints to TRACEs and ERRs.
svn path=/trunk/; revision=66261
Timo Kreuzer [Sat, 14 Feb 2015 13:24:54 +0000 (13:24 +0000)]
[GDI32_APITEST]
Fix GCC build
svn path=/trunk/; revision=66260
Timo Kreuzer [Sat, 14 Feb 2015 13:19:02 +0000 (13:19 +0000)]
[GDI32_APITEST]
Add tests for OffsetRgn, PaintRgn and FrameRgn, fix 1BPP DIB creation in InitStuff()
svn path=/trunk/; revision=66259
Thomas Faber [Sat, 14 Feb 2015 12:59:16 +0000 (12:59 +0000)]
[COM_APITEST]
- Add classes found in Wine's shell32_classes.idl and browseui_classes.idl
svn path=/trunk/; revision=66258
Thomas Faber [Sat, 14 Feb 2015 12:03:58 +0000 (12:03 +0000)]
[PACKAGES]
- Copy libwinpthread-1.dll if present instead of forcing the use of a specific set of GnuTLS binaries. Partially reverts r66110. Should fix testbot problems (mshtml_winetest:events in particular).
CORE-9167
svn path=/trunk/; revision=66257
Timo Kreuzer [Sat, 14 Feb 2015 11:25:02 +0000 (11:25 +0000)]
[GDI32_APITEST]
Fix InitStuff(), declare the 32 bpp DIB array 2 dimensional and make it 8x8 in size.
svn path=/trunk/; revision=66256
Timo Kreuzer [Sat, 14 Feb 2015 11:09:31 +0000 (11:09 +0000)]
[CMAKE]
Fix the fix. (tm)
svn path=/trunk/; revision=66255
Timo Kreuzer [Sat, 14 Feb 2015 11:01:58 +0000 (11:01 +0000)]
[CMAKE]
Fix bugs in start/end_module_group, found by Jérôme.
svn path=/trunk/; revision=66254
Pierre Schweitzer [Sat, 14 Feb 2015 08:02:08 +0000 (08:02 +0000)]
[IPHLPAPI]
Add the missing loop iterator in GetAdaptersAddresses().
This fixes infinite loop, and fixes Firefox 3.6 boot.
CORE-9051 #resolve #comment Fixed in r66253
svn path=/trunk/; revision=66253
Hermès Bélusca-Maïto [Sat, 14 Feb 2015 05:27:55 +0000 (05:27 +0000)]
[WINLOGON]
- Reshuffle a bit some code.
- Never fail if the kill-COM-processes thread fails to be created.
- WlxLogoff GINA callback *must* be called *after* our logoff handling (with HandleLogoff). This is what happens on Windows (just add breakpoints on ExitWindowsEx and on WlxIsLogoffOk and WlxLogoff, and enable winlogon tracing).
[WIN32K]
Rename a flag to something more meaningful, and fix a flag filtering bug: lParams = wParam & something; ---> lParams = lParam & something; (the wParam is used for something else).
Part 12/X
CORE-8322
svn path=/trunk/; revision=66252
Timo Kreuzer [Fri, 13 Feb 2015 20:20:52 +0000 (20:20 +0000)]
[ROSTESTS]
Create rostests module group. You can now compile rostests with "ninja rostests". Dedicated to Colin.
svn path=/trunk/; revision=66251
Timo Kreuzer [Fri, 13 Feb 2015 20:19:51 +0000 (20:19 +0000)]
[CMAKE]
Add support for "module groups". These are meta targets that automatically include all targets using set_module_type() that are included between start_module_group(name) and end_module_group().
svn path=/trunk/; revision=66250
Hermès Bélusca-Maïto [Fri, 13 Feb 2015 16:19:14 +0000 (16:19 +0000)]
[CONSRV]: Remove unused commented DtbgIsDesktopVisible.
svn path=/trunk/; revision=66249
Hermès Bélusca-Maïto [Fri, 13 Feb 2015 16:16:28 +0000 (16:16 +0000)]
[BASESRV]: Only SHUTDOWN_NORETRY can be set via Get/SetProcessShutdownParameters APIs.
svn path=/trunk/; revision=66248
Johannes Anderwald [Fri, 13 Feb 2015 15:03:45 +0000 (15:03 +0000)]
[IPHLPAPI]
- hackplement GetExtendedTcpTable class TCP_TABLE_OWNER_PID_ALL
- fixes XAMPP control panel startup
svn path=/trunk/; revision=66247
Johannes Anderwald [Fri, 13 Feb 2015 14:58:05 +0000 (14:58 +0000)]
[PSDK]
- add MIB_TCPROW_OWNER_PID, MIB_TCPTABLE_OWNER_PID types
svn path=/trunk/; revision=66246
James Tabor [Fri, 13 Feb 2015 13:45:11 +0000 (13:45 +0000)]
[NtUser]
- Fix wine msg:test_SendMessageTimeout. Do not allow the message to pass on after a timeout.
svn path=/trunk/; revision=66245
James Tabor [Fri, 13 Feb 2015 13:39:57 +0000 (13:39 +0000)]
[NtUser]
- Use a real timer for caret. This should cleanup message testing from those random system timer messages. See CORE-7447.
svn path=/trunk/; revision=66244
Thomas Faber [Fri, 13 Feb 2015 10:11:50 +0000 (10:11 +0000)]
[WIN32K:NTUSER]
- Assert sanity of object reference counts in UserReferenceObject, UserDereferenceObject and UserDeleteObject. If you hit a cLockObj < 0x10000 assertion failure, you found yourself a use after free (RtlFreeHeap will put a LIST_ENTRY in this location, so a freed item has a kernel pointer there).
See CORE-8703 for an example.
svn path=/trunk/; revision=66243
Thomas Faber [Fri, 13 Feb 2015 09:06:00 +0000 (09:06 +0000)]
[GDI32_APITEST]
- Fix stack buffer overflow in InitPerBitDepth
ROSTESTS-147 #resolve
svn path=/trunk/; revision=66242
James Tabor [Fri, 13 Feb 2015 01:03:38 +0000 (01:03 +0000)]
[NtUser]
- This should fix dialog breakage due to r66237.
svn path=/trunk/; revision=66241
Hermès Bélusca-Maïto [Thu, 12 Feb 2015 23:35:58 +0000 (23:35 +0000)]
[WINLOGON]
- Implement KillComProcesses that just kills with force and without any notification back to winlogon, any remaining app that is still alive even if we asked before to kill apps (it's just the aim of this function, not more).
- Fix internal flags according to WinDbg sessions with Win2k3 + tracing checked build winlogon (testing logoff/shutdown/reboot from winlogon itself and when using the "shutdown" command).
- FIXME: Manage EWX_FORCE flag in winlogon...
[WINSRV]
Fix a DPRINT.
[WIN32K]
- Introduce a NotifyLogon function to manage winlogon notifications (when we shutdown and "end" shutdown steps, or cancel it).
- Fix some flags settings.
Part 11/X
CORE-8322
-------
This is a test:
!error !rot13 !reebe !ebg13 !error !rot13 !reebe !ebg13
svn path=/trunk/; revision=66240
James Tabor [Thu, 12 Feb 2015 23:10:10 +0000 (23:10 +0000)]
[NtUser]
- Fix dialog breakage due to r66237.
svn path=/trunk/; revision=66239
James Tabor [Thu, 12 Feb 2015 21:33:43 +0000 (21:33 +0000)]
[NtUser]
- Fix wine msg.c:test_quit_message tests.
svn path=/trunk/; revision=66238
James Tabor [Thu, 12 Feb 2015 21:28:39 +0000 (21:28 +0000)]
[NtUser]
- Reorder Destroy and Free window, getting close to how wine does it. Still more work is needed.
svn path=/trunk/; revision=66237
Timo Kreuzer [Thu, 12 Feb 2015 09:18:20 +0000 (09:18 +0000)]
[WIN32K]
Initialize EBRUSHOBJ.psoMask in EBRUSHOBJ_vInit. Should fix CORE-9165
svn path=/trunk/; revision=66236
Thomas Faber [Thu, 12 Feb 2015 09:14:52 +0000 (09:14 +0000)]
[NTOS:MM]
- Set aside some additional system PTEs if special pool is enabled
CORE-8680
svn path=/trunk/; revision=66235
James Tabor [Thu, 12 Feb 2015 00:17:41 +0000 (00:17 +0000)]
[NtUser]
- Fix the results from the new API CreateWindowEx tests. Message sequence and isolating each job Destroy and Free perform will come later. Refer to CORE-8703. This may not fix the crash while in wine test User32:msg.c.
- Dedicated to Thomas Faber.
- Fix build window list using threads. The link list works okay for locking but for tracking thread windows, use the snapshot method.
svn path=/trunk/; revision=66234
James Tabor [Wed, 11 Feb 2015 23:53:08 +0000 (23:53 +0000)]
[ApiTest]
- Add Thomas Faber API test from CORE-8703.
svn path=/trunk/; revision=66233
Timo Kreuzer [Wed, 11 Feb 2015 21:36:01 +0000 (21:36 +0000)]
[MESA]
Partly sync find_value() with MESA 10.4.4. Fixes endless loop when GoogleEarth is started. GoogleEarth now loads and displays the earth, but it doesn't handle any input and makes the entire GUI hang.
svn path=/trunk/; revision=66232
Timo Kreuzer [Wed, 11 Feb 2015 21:35:48 +0000 (21:35 +0000)]
[WIN32K]
Implement support for hatch brush masks.
svn path=/trunk/; revision=66231
Timo Kreuzer [Wed, 11 Feb 2015 21:35:09 +0000 (21:35 +0000)]
[WIN32K]
Fix handling of mask bitmap in NtGdiMaskBlt
svn path=/trunk/; revision=66230
Timo Kreuzer [Wed, 11 Feb 2015 21:34:42 +0000 (21:34 +0000)]
[WIN32K]
- Handle the case where we have a masked ROP, but no mask surface in EngBitBlt
- Alloc ROPs with a mask in EngPaint
Fixes ASSERT when GoogleEarth is launched.
svn path=/trunk/; revision=66229
Timo Kreuzer [Wed, 11 Feb 2015 21:34:11 +0000 (21:34 +0000)]
[WIN32K]
Add minimal infrastructure for handling pattern brush masks.
svn path=/trunk/; revision=66228
Timo Kreuzer [Wed, 11 Feb 2015 21:33:50 +0000 (21:33 +0000)]
[WIN32K]
Improve naming of some BRUSH fields and set the correct fields to the correct values (ulStyle was not for the brush style, but the hatch style!)
svn path=/trunk/; revision=66227
Timo Kreuzer [Wed, 11 Feb 2015 21:33:24 +0000 (21:33 +0000)]
[WIN32K]
- Make sure PENs and BRUSHes are properly initialized.
- Fix BRUSHATTR allocation
- enable BRUSHATTR deallocation
- Remove some obsolete defines
svn path=/trunk/; revision=66226
Timo Kreuzer [Wed, 11 Feb 2015 21:32:54 +0000 (21:32 +0000)]
[WIN32K]
Fix ROP2 value coming from user mode before using it.
svn path=/trunk/; revision=66225
Timo Kreuzer [Wed, 11 Feb 2015 21:32:24 +0000 (21:32 +0000)]
[WIN32K]
Simplify ROP4_USES_* macros
svn path=/trunk/; revision=66224
Hermès Bélusca-Maïto [Wed, 11 Feb 2015 20:12:30 +0000 (20:12 +0000)]
[WIN32K]: Fix an insecure user buffer reading/writing. Caught by Thomas Faber, thanks!
CORE-8322
svn path=/trunk/; revision=66223
Thomas Faber [Wed, 11 Feb 2015 11:06:12 +0000 (11:06 +0000)]
[SHELL32]
- Show a confirmation dialog when emptying the recycle bin. Patch by Robert Naumann, with some modifications by me.
CORE-9006 #resolve
svn path=/trunk/; revision=66222
Timo Kreuzer [Tue, 10 Feb 2015 22:33:19 +0000 (22:33 +0000)]
[GDI32_APITEST]
Add more tests for MaskBlt
svn path=/trunk/; revision=66221
Timo Kreuzer [Tue, 10 Feb 2015 22:31:17 +0000 (22:31 +0000)]
[GDI32_APITEST]
Add more helper code
svn path=/trunk/; revision=66220
Daniel Reimer [Tue, 10 Feb 2015 21:02:11 +0000 (21:02 +0000)]
[BROWSEUI]
Fix german layout to... look better.
svn path=/trunk/; revision=66219
Thomas Faber [Tue, 10 Feb 2015 20:29:54 +0000 (20:29 +0000)]
[GDI32_APITEST]
- Fix flakiness in GetDIBits test
svn path=/trunk/; revision=66218
Hermès Bélusca-Maïto [Tue, 10 Feb 2015 18:27:34 +0000 (18:27 +0000)]
[CONSRV]: Fix a DPRINT.
svn path=/trunk/; revision=66217
Aleksandar Andrejevic [Tue, 10 Feb 2015 17:29:26 +0000 (17:29 +0000)]
[FAST486]
Implement Fast486FpuMultiply properly.
svn path=/trunk/; revision=66216
Daniel Reimer [Tue, 10 Feb 2015 02:03:35 +0000 (02:03 +0000)]
[BROWSEUI]
German update.
(Is it possible that our browseui is not even similar to the one from Win 5.2?)
svn path=/trunk/; revision=66215
Daniel Reimer [Mon, 9 Feb 2015 23:25:49 +0000 (23:25 +0000)]
[BROWSEUI]
Sync all languages with the once more not synced English one... Every language has a different state and no one sees that if the new strings are not added in there. At least add the English original. Thx for understanding.
DIALOG -> DIALOGEX
svn path=/trunk/; revision=66214
Giannis Adamopoulos [Mon, 9 Feb 2015 22:31:53 +0000 (22:31 +0000)]
Fix build on unix hosts
svn path=/trunk/; revision=66213
Giannis Adamopoulos [Mon, 9 Feb 2015 22:29:23 +0000 (22:29 +0000)]
[BROWSEUI]
- Implement CProgressDialog based on wine
- Patch by Huw Campbell, improved by me
CORE-4476
svn path=/trunk/; revision=66212
Thomas Faber [Mon, 9 Feb 2015 19:59:59 +0000 (19:59 +0000)]
[INCLUDE]
- Fix CListView::HitTest. Fixes stack corruption when dragging files on the desktop.
CORE-9143 #resolve
svn path=/trunk/; revision=66211
Thomas Faber [Mon, 9 Feb 2015 19:04:42 +0000 (19:04 +0000)]
[USER32]
- In ICO_ExtractIconExW, don't try to return two icons if only one was requested. Fixes stack corruption.
CORE-9142 #resolve
svn path=/trunk/; revision=66210
Giannis Adamopoulos [Sun, 8 Feb 2015 23:47:11 +0000 (23:47 +0000)]
[COM_APITEST]
- Test the interfaces exposed by CLSID_ProgressDialog
CORE-4476
svn path=/trunk/; revision=66209
Thomas Faber [Sun, 8 Feb 2015 14:22:26 +0000 (14:22 +0000)]
[DDK]
- Add additional list entry checks that can be optionally enabled by defining EXTRA_KERNEL_LIST_ENTRY_CHECKS. These checks warn against attempts to remove items from an empty list, which can easily be an error (and is trivial to avoid where it's not).
- Enable these checks by default for ReactOS code
CORE-8419 #resolve
svn path=/trunk/; revision=66208
Thomas Faber [Sun, 8 Feb 2015 14:15:45 +0000 (14:15 +0000)]
[NTOS]
- Avoid removing list entry if the list is empty in IopUnQueueIrpFromThread
CORE-8419
svn path=/trunk/; revision=66207
Thomas Faber [Sun, 8 Feb 2015 13:22:06 +0000 (13:22 +0000)]
[DDK]
- Add list entry security checks equivalent to those in current WDKs. This is useful for ROS because it detects memory corruption very quickly.
CORE-8419
svn path=/trunk/; revision=66206
Eric Kohl [Sun, 8 Feb 2015 11:49:58 +0000 (11:49 +0000)]
[NTOSKRNL]
Implement NtSaveMergedKeys and its backend CmSaveMergedKeys.
svn path=/trunk/; revision=66205
Thomas Faber [Sun, 8 Feb 2015 10:57:47 +0000 (10:57 +0000)]
[DDK]
- Add RtlFailFast and FAST_FAIL_* codes
CORE-8419
svn path=/trunk/; revision=66204
Johannes Anderwald [Sun, 8 Feb 2015 08:11:51 +0000 (08:11 +0000)]
[PORTCLS]
- fix crash / assert triggered with cwawdm driver
- fix irp leak
- CORE 7822
svn path=/trunk/; revision=66203
Hermès Bélusca-Maïto [Sun, 8 Feb 2015 00:54:22 +0000 (00:54 +0000)]
[WINSRV]: Remove some deprecated code, keep other parts for reusage later on; cleanup SrvExitWindowsEx. If you enable the NotifyAndTerminateProcess call, you get a basic win32 process termination. This is now where the real work starts: do not kill CSRSS nor Winlogon, do not kill processes from other sessions, etc... Deal with console apps; display timeout dialog, and focus on the app that blocks shutdown by switching to the correct desktop. And we MUST NOT use user32 desktop APIs for switching to the different desktops, but we need to directly call win32k!! (for reasons that will appear later on; not implemented at the moment). Giannis, I will need your help for that!
Part 10/X
CORE-8322
svn path=/trunk/; revision=66202
Thomas Faber [Sun, 8 Feb 2015 00:00:30 +0000 (00:00 +0000)]
[SPEC2DEF]
- Don't warn about symbols that should be private on MSVC builds. Link already does this.
CORE-8445
svn path=/trunk/; revision=66201
Thomas Faber [Sat, 7 Feb 2015 23:54:15 +0000 (23:54 +0000)]
[CMAKE]
- Support NO_PRIVATE_WARNINGS parameter when invoking spec2def to suppress warnings about symbols that should be private
- Disable such warnings for msxml3, ole32 and rsaenh
CORE-8445
svn path=/trunk/; revision=66200
Hermès Bélusca-Maïto [Sat, 7 Feb 2015 21:42:26 +0000 (21:42 +0000)]
[SPEC2DEF]: Display the -private exports warning *only* when making import libs.
CORE-8445 #comment -private warning only displayed for import libs.
svn path=/trunk/; revision=66199
Thomas Faber [Sat, 7 Feb 2015 21:20:15 +0000 (21:20 +0000)]
[SPEC2DEF]
- Remove space before colon in error messages
svn path=/trunk/; revision=66198
Hermès Bélusca-Maïto [Sat, 7 Feb 2015 20:46:27 +0000 (20:46 +0000)]
[WINLOGON]
- Add DPRINTs to monitor how shutdown goes on (obviously they will go away when shutdown on ROS will be working).
- Add dumb handler for LN_LOGOFF_CANCELED message (unused for now...)
[WIN32K]: DPRINTs added for monitoring shutdown.
[WINSRV]: Start to plugin the whole thing (using pieces of Alex' shutdown patch):
- We need to use a "shutdown" loop (for UserThreadInitiateShutdown win32k call) for being able to cancel shuts down (not implemented yet).
- Add the "magic" call to CsrShutdownProcesses that calls the Shutdown callback of each CSR server for each Win32 process (these are those callbacks that do the real job of terminating the apps, displaying the "Kill the app" dialog, etc...). In few words, the old (disabled) code of InternalExitReactos need to go into those shutdown callbacks (but this is for other commits!).
Part 9/X
CORE-8322 #comment Continue plugging in the shutdown code (from Alex' patch) in WINSRV with adaptations into WINLOGON (+ adding DPRINTs for controlling the whole thing).
svn path=/trunk/; revision=66197
Amine Khaldi [Sat, 7 Feb 2015 19:14:42 +0000 (19:14 +0000)]
[WIN32K:INCLUDES] Some formatting fixes. NFC.
svn path=/trunk/; revision=66196
Timo Kreuzer [Sat, 7 Feb 2015 17:51:20 +0000 (17:51 +0000)]
[WIN32K]
Fix the ROP code passed to IntEngStretchBlt from NtGdiStretchDIBitsInternal. Fixes crash of Nimbus Notes installer.
CORE-9048 #resolve
svn path=/trunk/; revision=66195
Hermès Bélusca-Maïto [Sat, 7 Feb 2015 16:19:57 +0000 (16:19 +0000)]
[WIN32k:includes] Whitespace fixes.
svn path=/trunk/; revision=66194
Timo Kreuzer [Sat, 7 Feb 2015 15:52:18 +0000 (15:52 +0000)]
[FREELDR]
- #ifdef DBG -> #if DBG
- #if 0 DbgDumpMemoryMap()
svn path=/trunk/; revision=66193
Hermès Bélusca-Maïto [Sat, 7 Feb 2015 15:26:42 +0000 (15:26 +0000)]
[WINLOGON][WIN32K]
Move the shutdown privilege check from winlogon to win32k (function "UserInitiateShutdown") as it should be done.
[WIN32K]
- Introduce the pair of UserInitiateShutdown/UserEndShutdown calls that should be called when WINSRV starts a shutdown (and when it finishes it). In particular it is in UserInitiateShutdown that we need to check whether the caller has the rights to perform a shutdown (it should also have a valid window station).
- Remove the ROS-specific TWOPARAM_ROUTINE_EXITREACTOS call that is traded for Win2k3-compatible call to UserInitiateShutdown.
[WINSRV]
Hackfix our current ExitWindowsEx functionality (based on a patch by Alex made against r46050 for win32csr) to make it "compatible" with the improvements in win32k: impersonate the caller and call the UserInitiateShutdown win32k system call (instead of the TWOPARAM_ROUTINE_EXITREACTOS). More will come later on.
[USER32]
Win32k can require performing shutdown in an asynchronous way (needed also on WINSRV side) so we need to put all the code in a worker thread.
Part 8/X (part 6 was r65693 and part 7 was r66186).
CORE-8322 #comment Start to add Alex' win32csr shutdown patch in WINSRV; fixes for winlogon and additions to win32k.
svn path=/trunk/; revision=66192
Timo Kreuzer [Sat, 7 Feb 2015 15:05:04 +0000 (15:05 +0000)]
[MKHIVE]
Add back CmpAllocate prototype. Fixes MSVC warnings.
svn path=/trunk/; revision=66191
Giannis Adamopoulos [Sat, 7 Feb 2015 14:42:39 +0000 (14:42 +0000)]
[SHELL32]
- Get rid of IDD_FILE_COPY dialog. It was never used, never completed and windows don't really have such a dialog.
- Remove SHShowFileOperationDialog which was never completed. This will be replaced shortly with a working solution by Huw Davies
svn path=/trunk/; revision=66190
Thomas Faber [Sat, 7 Feb 2015 13:24:29 +0000 (13:24 +0000)]
[RTL]
- Implement RtlIpv4StringToAddressW. Dedicated to Jérôme. Thanks to the countless reviewers.
CORE-6490
svn path=/trunk/; revision=66189
Thomas Faber [Sat, 7 Feb 2015 11:11:37 +0000 (11:11 +0000)]
[WIN32K]
- Do not use an uninitialized variable in UserSetProcessWindowStation. Feel free to fix this properly
svn path=/trunk/; revision=66188
Thomas Faber [Sat, 7 Feb 2015 10:07:24 +0000 (10:07 +0000)]
[RTL]
- Implement RtlIpv4StringToAddressA and RtlIpv4StringToAddressExA using their -W counterparts
CORE-6490
svn path=/trunk/; revision=66187
Hermès Bélusca-Maïto [Sat, 7 Feb 2015 01:18:40 +0000 (01:18 +0000)]
[WINLOGON][WIN32K]: Tend towards Win2k3-compatible winlogon logoff/shutdown messaging. Something that needs to be fixed is that it is not winlogon that checks whether the app requesting the shutdown has the correct rights, but it is win32k. I temporarily disable this check in winlogon (it's not as if we introduced a security breach in ReactOS ^^)
svn path=/trunk/; revision=66186
Hermès Bélusca-Maïto [Fri, 6 Feb 2015 23:29:09 +0000 (23:29 +0000)]
[WINSRV]: Remove a long standing hack (added 4 years ago) that is now useless.
CORE-5138 #comment Hack from r51460 finally removed.
svn path=/trunk/; revision=66185
James Tabor [Fri, 6 Feb 2015 21:17:10 +0000 (21:17 +0000)]
[User32]
- Patch by Huw Davies : Merge the blitting of the centered and non-centered cases.
svn path=/trunk/; revision=66184
James Tabor [Fri, 6 Feb 2015 21:07:59 +0000 (21:07 +0000)]
[WineTests|User32]
- Sync Combo to wine head. Patch by Huw Davies : Make the combo's listbox a topmost window. See CORE-5186 for prior report.
svn path=/trunk/; revision=66183
James Tabor [Fri, 6 Feb 2015 20:57:45 +0000 (20:57 +0000)]
[User32]
- Patch by Piotr Caban : Only store dialog focus when window is hidden or inactive. Only use DIALOGINFO-> hwndFocus to store last focus of inactive windows.
svn path=/trunk/; revision=66182
James Tabor [Fri, 6 Feb 2015 20:56:57 +0000 (20:56 +0000)]
[WineTests|User32]
- Sync Dialog to wine head.
svn path=/trunk/; revision=66181
Jérôme Gardou [Fri, 6 Feb 2015 10:49:04 +0000 (10:49 +0000)]
[KMTEST/TCPIP]
- Add tests checking for TDI_CONNECT behaviour.
svn path=/trunk/; revision=66180
Hermès Bélusca-Maïto [Fri, 6 Feb 2015 01:21:45 +0000 (01:21 +0000)]
[FREELDR]
- For now, only activate custom ReactOS boot on non-x86 builds.
- Fix INI section item list initialization before using it! Fixes custom ReactOS boots (ie. remove an invalid heap free). Now custom ReactOS boots work!
svn path=/trunk/; revision=66179
Hermès Bélusca-Maïto [Fri, 6 Feb 2015 00:07:23 +0000 (00:07 +0000)]
[SHELL32]
- Fix registry value retrieval with RegGetValue (RRF_RT_REG_EXPAND_SZ has a non-obvious functioning: it should be used with NO_EXPAND flag. Otherwise use RRF_RT_REG_SZ to retrieve REG_SZ values, or REG_EXPAND_SZ values with automatic expansion as expected). CORE-9001 #resolve #comment Fixed, thanks for reporting!
- Fix whitespace.
svn path=/trunk/; revision=66178