2 years agoFix the MSVC version of ldexp filling up the FPU stack and bailing out with #IND...
Colin Finck [Fri, 1 Mar 2019 16:49:03 +0000 (17:49 +0100)]
Fix the MSVC version of ldexp filling up the FPU stack and bailing out with #IND after a few calls. Additionally, add it back to libcntpr.

MSVC was previously given a "result" variable to copy the fscale result from st(0). This led to another "fld" FPU stack push at the very end without popping the source value from the FPU stack.
Moreover, this copy isn't even needed: A simple "fstp st(1)" at the end pops an element from the FPU stack while effectively storing the result in st(0), the register used for returning a double value.
This problem didn't affect GCC, as it is only given the "fscale" instruction and does all necessary stack operations itself.

However, looking into the CRT sources, I found many other i386 implementations with inline assembly suffering from the same problem.
Fortunately, they have been replaced by pure assembly implementations a while ago, so it's time to finally remove them.
ldexp would have also been a candidate for a pure assembly implementation, but the required check for NaN and setting errno (verified on Win2003) already outweighs the benefits.
And we cannot just do a NaN check with FUCOMI as this is an i686/pentiumpro instruction while we're still targeting i586/pentium.

I'm also using this opportunity to clean up the ldexp.c header and only put in the remaining contributors as returned by "git blame".

Thanks to NightWolve1975 for reporting the problem! (

2 years ago[DCOMLAUNCH] Add a DcomLaunch service stub
Pierre Schweitzer [Sun, 3 Mar 2019 13:21:46 +0000 (14:21 +0100)]
[DCOMLAUNCH] Add a DcomLaunch service stub

This stub is responsible for providing the UUID seed to the kernel.
For now, it generates a purely random seed - MAC address support
is to be added.
Because it's purely random seed and local the machine (not tied
to the MAC address) it's made so that ExUuidCreate keeps returning
RPC_NT_UUID_LOCAL_ONLY. It won't fix failing test for now.

Nota: this service shouldn't exist as it. It should be implemented
though rpcss DLL for both rpcss service (network service) and
dcomlaunch service (local system service).
Because rpcss is EXE based and wine-synced for now, I prefered
stubbing a new service. This will have to be changed at some point.

2 years ago[SHELL32] Update all languages RCs to fix possible text truncation CORE-15765
Joachim Henze [Sun, 3 Mar 2019 01:23:34 +0000 (02:23 +0100)]
[SHELL32] Update all languages RCs to fix possible text truncation CORE-15765

IDD_BROWSE_FOR_FOLDER displays text controlled by the calling applications in
IDC_BROWSE_FOR_FOLDER_TITLE. Its old height could lead to text truncation
for existing 3rd party apps.
The new height value for IDC_BROWSE_FOR_FOLDER_TITLE
was inspired by IDC with the same from dialog IDD_BROWSE_FOR_FOLDER_NEW.
I could change all languages to the same height,
as dimensions of the dialog and surrounding controls were same.

2 years ago[MSI] In dialogs show titlebar buttons CORE-15301
Joachim Henze [Sun, 3 Mar 2019 00:26:59 +0000 (01:26 +0100)]
[MSI] In dialogs show titlebar buttons CORE-15301

Import the Wine fix;h=84e6b331918d57f39e20a3063b67eb7fc0876288
Many thanks to the fixes author Fabian Maurer.

2 years ago[TASKMGR] Update german rc to avoid text truncation in status-bar CORE-15615
Joachim Henze [Sat, 2 Mar 2019 23:46:23 +0000 (00:46 +0100)]
[TASKMGR] Update german rc to avoid text truncation in status-bar CORE-15615

which became a necessity after the second field was reduced in width
by commit 0.4.12-dev-363-g

2 years ago[SETUPAPI] Implement CM_Next_Range()
Eric Kohl [Sat, 2 Mar 2019 19:52:52 +0000 (20:52 +0100)]
[SETUPAPI] Implement CM_Next_Range()

2 years ago[COVERITY][SETUPAPI] Release the blocks of memory when done
Bișoc George [Fri, 1 Mar 2019 19:24:18 +0000 (20:24 +0100)]
[COVERITY][SETUPAPI] Release the blocks of memory when done

pRange variable allocates blocks of memory from the heap by HeapAlloc() although this resource is never freed afterwards.


2 years agoUse GDI Batch for PatBlt
jimtabor [Sat, 2 Mar 2019 17:30:21 +0000 (11:30 -0600)]
Use GDI Batch for PatBlt

This should increase speed a bit. Makes a good argument to use
PolyPatBlt for more than one call.
PolyPatBlt is not fully tested yet.

2 years ago[NTOSKRNL] Fix MSVC2010 build
Pierre Schweitzer [Sat, 2 Mar 2019 10:10:37 +0000 (11:10 +0100)]
[NTOSKRNL] Fix MSVC2010 build

2 years ago[NTOSKRNL] Fix ClockDiff aka fix MSVC build
Pierre Schweitzer [Sat, 2 Mar 2019 09:45:34 +0000 (10:45 +0100)]
[NTOSKRNL] Fix ClockDiff aka fix MSVC build

2 years ago[NTOSKRNL] Add a test for ExUuidCreate
Pierre Schweitzer [Sat, 2 Mar 2019 09:29:26 +0000 (10:29 +0100)]
[NTOSKRNL] Add a test for ExUuidCreate

2 years ago[SNDVOL32] In record mode, rename the 'Mute' autocheckbox to 'Select', turn it into...
Eric Kohl [Fri, 1 Mar 2019 21:01:14 +0000 (22:01 +0100)]
[SNDVOL32] In record mode, rename the 'Mute' autocheckbox to 'Select', turn it into a checkbox and make it behave like a radiobutton.

2 years ago[NTOSKRNL] Rewrite/fix our UUID generation implementation
Pierre Schweitzer [Wed, 27 Feb 2019 20:12:32 +0000 (21:12 +0100)]
[NTOSKRNL] Rewrite/fix our UUID generation implementation
So that it matches Windows behavior
Also implement ExUuidCreate that will generate UUID version 1

The implementation is based on the RFC 4122

2 years ago[NTOSKRNL] Introduce the UUID_CACHED_VALUES_STRUCT structure
Pierre Schweitzer [Wed, 27 Feb 2019 08:02:30 +0000 (09:02 +0100)]


2 years ago[NTOSKRNL] UuidMutex -> ExpUuidLock
Pierre Schweitzer [Wed, 27 Feb 2019 07:54:48 +0000 (08:54 +0100)]
[NTOSKRNL] UuidMutex -> ExpUuidLock

2 years ago[OSK] Implement "Use Click Sound" feature
Bișoc George [Sun, 24 Feb 2019 15:40:02 +0000 (16:40 +0100)]
[OSK] Implement "Use Click Sound" feature

- Implement the save/load handler for this feature
- Check the "Use Click Sound" item state accordingly depending if it's enabled or disabled
- Use PlaySoundW() to play the wave sound file from resource
- Add the WAV sound click file. The work is made thanks to Midori Mizuno

2 years ago[HDAUDBUS] Wait until the correct number of responses was received. CORE-15465
Thomas Faber [Wed, 27 Feb 2019 14:02:38 +0000 (15:02 +0100)]
[HDAUDBUS] Wait until the correct number of responses was received. CORE-15465

We previously only gave the device a hard-coded amount of time to respond,
which could lead to interpreting the contents of uninitialized memory as
a response. This would lead to an unreasonably large number of audio function
groups being detected.

A KSEMAPHORE mirrors what Haiku uses here, though it may not be the optimal
synchronization primitive for this case under Windows.

2 years ago[HDAUDBUS] Handle responses in a DPC instead of the ISR.
Thomas Faber [Wed, 27 Feb 2019 13:34:23 +0000 (14:34 +0100)]
[HDAUDBUS] Handle responses in a DPC instead of the ISR.

2 years ago[HDAUDBUS] Fix a DPRINT.
Thomas Faber [Wed, 27 Feb 2019 14:02:23 +0000 (15:02 +0100)]

2 years ago[HDAUDBUS] Prevent overflow of the AudioGroups array. CORE-14153 CORE-15465
Thomas Faber [Wed, 27 Feb 2019 09:51:02 +0000 (10:51 +0100)]
[HDAUDBUS] Prevent overflow of the AudioGroups array. CORE-14153 CORE-15465

This protects against crashing in case of faulty/malicious hardware,
but also works around a bug in HDA_SendVerbs that causes it to return
invalid data, thereby suggesting more groups than are actually present.

2 years ago[SNDVOL32] Small Italian translation update
Bișoc George [Tue, 26 Feb 2019 14:49:47 +0000 (15:49 +0100)]
[SNDVOL32] Small Italian translation update

2 years ago[HDAUDBUS] Implement HDA_Unload. Stub HDA_Power and HDA_SystemControl. 1377/head
Thomas Faber [Sun, 24 Feb 2019 11:29:34 +0000 (12:29 +0100)]
[HDAUDBUS] Implement HDA_Unload. Stub HDA_Power and HDA_SystemControl.

2 years ago[HDAUDBUS] Correctly mask register values.
Thomas Faber [Mon, 25 Feb 2019 00:56:25 +0000 (01:56 +0100)]
[HDAUDBUS] Correctly mask register values.


This fixes various device reset failures and probably other issues.

2 years ago[HDAUDBUS] Implement PDO removal. CORE-14617
Thomas Faber [Mon, 25 Feb 2019 12:47:14 +0000 (13:47 +0100)]
[HDAUDBUS] Implement PDO removal. CORE-14617

2 years ago[HDAUDBUS] Implement FDO removal. CORE-14617
Thomas Faber [Sun, 24 Feb 2019 13:33:41 +0000 (14:33 +0100)]
[HDAUDBUS] Implement FDO removal. CORE-14617

2 years ago[HDAUDBUS] Use IoForwardIrpSynchronously instead of HDA_SyncForwardIrp.
Thomas Faber [Sun, 24 Feb 2019 11:23:45 +0000 (12:23 +0100)]
[HDAUDBUS] Use IoForwardIrpSynchronously instead of HDA_SyncForwardIrp.

2 years ago[HDAUDBUS] Forward FDO requests instead of completing them.
Thomas Faber [Mon, 25 Feb 2019 11:48:54 +0000 (12:48 +0100)]
[HDAUDBUS] Forward FDO requests instead of completing them.

2 years ago[HDAUDBUS] Use a switch for minor function codes.
Thomas Faber [Sat, 23 Feb 2019 20:52:21 +0000 (21:52 +0100)]
[HDAUDBUS] Use a switch for minor function codes.

2 years ago[HDAUDBUS] Split FDO/PDO PNP handling into separate functions.
Thomas Faber [Sat, 23 Feb 2019 20:50:05 +0000 (21:50 +0100)]
[HDAUDBUS] Split FDO/PDO PNP handling into separate functions.

2 years ago[HDAUDBUS] Minor fixes:
Thomas Faber [Sat, 23 Feb 2019 08:55:57 +0000 (09:55 +0100)]
[HDAUDBUS] Minor fixes:
* Add some forward-declarations
* Add some annotations
* Improve a DPRINT

2 years ago[MSAFD] Don't leak event while querying/setting socket options
Pierre Schweitzer [Mon, 25 Feb 2019 21:33:31 +0000 (22:33 +0100)]
[MSAFD] Don't leak event while querying/setting socket options

2 years ago[MSAFD] Implement socket options SO_SNDBUF and SO_RCVBUF
Pierre Schweitzer [Mon, 25 Feb 2019 21:30:01 +0000 (22:30 +0100)]
[MSAFD] Implement socket options SO_SNDBUF and SO_RCVBUF

2 years ago[AFD_APITEST] Add apitest for AFD window size options
Pierre Schweitzer [Mon, 25 Feb 2019 21:28:18 +0000 (22:28 +0100)]
[AFD_APITEST] Add apitest for AFD window size options

2 years ago[AFD] Don't allow caller to set broken values to window sizes
Pierre Schweitzer [Mon, 25 Feb 2019 21:27:00 +0000 (22:27 +0100)]
[AFD] Don't allow caller to set broken values to window sizes

This will avoid 0-sized allocations, or -1-sized allocations.
So far, it's maxed by hard value stored in TCPIP.sys. I believe
this is not right and would deserve a true fix

2 years ago[AFD] Add default window sizes on socket creation
Pierre Schweitzer [Mon, 25 Feb 2019 21:25:03 +0000 (22:25 +0100)]
[AFD] Add default window sizes on socket creation

2 years ago[XDK] Remove _M_AMD64 special case 1358/head
Mark Jansen [Sat, 23 Feb 2019 15:24:21 +0000 (16:24 +0100)]
[XDK] Remove _M_AMD64 special case

2 years ago[APPHELP] Implement SdbRegisterDatabase[Ex]
Mark Jansen [Mon, 11 Feb 2019 21:45:48 +0000 (22:45 +0100)]
[APPHELP] Implement SdbRegisterDatabase[Ex]

2 years ago[APPHELP][APPHELP_APITEST] Implement SdbGetDatabaseInformation
Mark Jansen [Mon, 11 Feb 2019 21:44:30 +0000 (22:44 +0100)]
[APPHELP][APPHELP_APITEST] Implement SdbGetDatabaseInformation

2 years ago[APPHELP] Implement ShimDumpCache and ShimFlushCache
Mark Jansen [Sun, 6 Jan 2019 16:51:55 +0000 (17:51 +0100)]
[APPHELP] Implement ShimDumpCache and ShimFlushCache
These functions simply call into the Base* functions,
having a prototype that is compatible with rundll32

2 years ago[SDB] Initial SdbRegisterDatabase stubs
Mark Jansen [Thu, 3 Jan 2019 22:24:54 +0000 (23:24 +0100)]
[SDB] Initial SdbRegisterDatabase stubs

2 years ago[APPHELP_APITEST] Add a test for shim database registration
Mark Jansen [Fri, 23 Jun 2017 19:47:36 +0000 (21:47 +0200)]
[APPHELP_APITEST] Add a test for shim database registration

2 years ago[MODULES][WALLPAPERS] Fix build (#1375)
Stanislav Motylkov [Mon, 25 Feb 2019 10:41:41 +0000 (13:41 +0300)]
[MODULES][WALLPAPERS] Fix build (#1375)

Some file names still contained space instead of underline. Addendum to 0760802.

2 years ago[TRANSLATION] Update Chinese and Traditional Chinese translations. (#1369)
Luo Yufan [Sun, 24 Feb 2019 23:36:53 +0000 (07:36 +0800)]
[TRANSLATION] Update Chinese and Traditional Chinese translations. (#1369)

2 years ago[MSAFD] Make WSPSetSockOpt() SO_RCVBUF stub return success
Pierre Schweitzer [Sun, 24 Feb 2019 20:25:39 +0000 (21:25 +0100)]
[MSAFD] Make WSPSetSockOpt() SO_RCVBUF stub return success

2 years ago[NTOS::Mm] Fix inverted check in MiWriteProtectSystemImage
Timo Kreuzer [Sun, 24 Feb 2019 12:24:26 +0000 (13:24 +0100)]
[NTOS::Mm] Fix inverted check in MiWriteProtectSystemImage

2 years ago[MODULES] Fix CMakeLists.txt for wallpapers module. (#1294)
Dylan Navas [Sun, 24 Feb 2019 17:08:26 +0000 (14:08 -0300)]
[MODULES] Fix CMakeLists.txt for wallpapers module. (#1294)

* Add all wallpapers to the ISO and can look how enable the module in ReadMe.txt
* Remove blanks in name.
* Moving to folder with same wallpaper style.
* Adding and updating CMakeLists.txt.
* Update ReadMe.txt.

2 years ago[KMTEST] Fix 3 Clang-Cl warnings about Status and Callbacks (#502)
Serge Gautherie [Sun, 24 Feb 2019 16:53:39 +0000 (17:53 +0100)]
[KMTEST] Fix 3 Clang-Cl warnings about Status and Callbacks (#502)

* 1 "warning: variable 'Status' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]"
* 2 "warning: comparison of unsigned expression < 0 is always false [-Wtautological-unsigned-zero-compare]"
* Use a consistent type for "i" and fix a comment
* Also update licence header.


2 years ago[MMSYS] Volume page: Initialize the volume trackbar before it might be disabled becau...
Eric Kohl [Sun, 24 Feb 2019 16:15:13 +0000 (17:15 +0100)]
[MMSYS] Volume page: Initialize the volume trackbar before it might be disabled because the tick marks must be visible on a disabled trackbar.

2 years ago[MMSYS] Sounds page: Update the 'Play' button and the current item in the 'Program...
Eric Kohl [Sun, 24 Feb 2019 15:56:55 +0000 (16:56 +0100)]
[MMSYS] Sounds page: Update the 'Play' button and the current item in the 'Program events' treeview when a sound is selected or deselected.

2 years ago[SNDVOL32] Disable only the 'Play' button, when no audio device is avaiblable.
Eric Kohl [Sun, 24 Feb 2019 15:12:55 +0000 (16:12 +0100)]
[SNDVOL32] Disable only the 'Play' button, when no audio device is avaiblable.

2 years ago[MSGINA] Add bar bitmap to logon and shutdown dialogs
Stanislav Motylkov [Sat, 23 Feb 2019 21:44:12 +0000 (00:44 +0300)]
[MSGINA] Add bar bitmap to logon and shutdown dialogs

2 years ago[MSGINA] Improve Ctrl-Alt-Del invitation window
Stanislav Motylkov [Sat, 23 Feb 2019 20:52:22 +0000 (23:52 +0300)]
[MSGINA] Improve Ctrl-Alt-Del invitation window

2 years ago[MSGINA] Implement rotation bar animation
Stanislav Motylkov [Sat, 23 Feb 2019 20:34:22 +0000 (23:34 +0300)]
[MSGINA] Implement rotation bar animation

Based on initial work by Bisoc George. Rotation bar image by Zcooger. CORE-15215

2 years ago[MMSYS] Disable the 'Low' and 'High' text of the volume trackbar and the 'Place volum...
Eric Kohl [Sun, 24 Feb 2019 14:35:36 +0000 (15:35 +0100)]
[MMSYS] Disable the 'Low' and 'High' text of the volume trackbar and the 'Place volume icon in the taskbar' checkbox when no sound device is available.

2 years ago[WINLOGON] Fix fallback keyboard layout flags
Raul Tambre [Sun, 24 Feb 2019 09:37:42 +0000 (11:37 +0200)]
[WINLOGON] Fix fallback keyboard layout flags

2 years ago[SNDVOL32] Advanced Controls dialog: Implemented the Bass and Treble trackbars.
Eric Kohl [Sun, 24 Feb 2019 11:50:37 +0000 (12:50 +0100)]
[SNDVOL32] Advanced Controls dialog: Implemented the Bass and Treble trackbars.

Please check if they are working correctly. I have no way to check them myself.

2 years ago[SNDVOL32] Remove trailing whitespace
Eric Kohl [Sat, 23 Feb 2019 16:26:48 +0000 (17:26 +0100)]
[SNDVOL32] Remove trailing whitespace

2 years ago[SNDVOL32] Resize the dialog and groupbox when there are two 'Other Controls'
Eric Kohl [Sat, 23 Feb 2019 16:21:25 +0000 (17:21 +0100)]
[SNDVOL32] Resize the dialog and groupbox when there are two 'Other Controls'

2 years ago[WS2_32] Use SEH in WSCGetProviderPath()
Pierre Schweitzer [Sat, 23 Feb 2019 12:34:28 +0000 (13:34 +0100)]
[WS2_32] Use SEH in WSCGetProviderPath()

2 years ago[SNDVOL32] Advanced Controls dialog: Initialize the Other Controls
Eric Kohl [Sat, 23 Feb 2019 11:51:14 +0000 (12:51 +0100)]
[SNDVOL32] Advanced Controls dialog: Initialize the Other Controls

2 years ago[WS2_32] Implement WSCGetProviderPath()
Pierre Schweitzer [Sat, 23 Feb 2019 09:57:06 +0000 (10:57 +0100)]
[WS2_32] Implement WSCGetProviderPath()

2 years ago[SNDVOL32] Advanced controls dialog: Remove the TBS_AUTOTICKS style from the trackbar...
Eric Kohl [Fri, 22 Feb 2019 22:33:47 +0000 (23:33 +0100)]
[SNDVOL32] Advanced controls dialog: Remove the TBS_AUTOTICKS style from the trackbars and initialize them properly.

2 years ago[SNDVOL32] Move the advanced controls dialog to a separate file and update its title...
Eric Kohl [Thu, 21 Feb 2019 21:26:58 +0000 (22:26 +0100)]
[SNDVOL32] Move the advanced controls dialog to a separate file and update its title on creation.

2 years ago[NDK] Fix 'DeletedChidren' typo (#1367)
Serge Gautherie [Wed, 20 Feb 2019 21:16:16 +0000 (22:16 +0100)]
[NDK] Fix 'DeletedChidren' typo (#1367)

On behalf of Vadim Galyant.

2 years ago[VIDEOPRT] Don't return uninitialized memory
Pierre Schweitzer [Wed, 20 Feb 2019 20:01:46 +0000 (21:01 +0100)]
[VIDEOPRT] Don't return uninitialized memory

2 years ago[SNDVOL32] Fix parsing dialog icons
Mark Jansen [Tue, 19 Feb 2019 20:32:51 +0000 (23:32 +0300)]
[SNDVOL32] Fix parsing dialog icons

2 years ago[SNDVOL32] Add left and right balance icons
Stanislav Motylkov [Tue, 19 Feb 2019 13:51:39 +0000 (16:51 +0300)]
[SNDVOL32] Add left and right balance icons

2 years ago[NTOS:PNP] Correctly respect data size in PnpRegSzToString. CORE-15766
Thomas Faber [Wed, 20 Feb 2019 11:21:03 +0000 (12:21 +0100)]
[NTOS:PNP] Correctly respect data size in PnpRegSzToString. CORE-15766

Spotted by Vadim Galyant.

2 years ago[NTDLL_APITEST] Show that registry strings can be longer than MAXUSHORT.
Thomas Faber [Wed, 20 Feb 2019 11:03:03 +0000 (12:03 +0100)]
[NTDLL_APITEST] Show that registry strings can be longer than MAXUSHORT.

2 years ago[SNDVOL32] Add Russian translation
Stanislav Motylkov [Tue, 19 Feb 2019 12:54:38 +0000 (15:54 +0300)]
[SNDVOL32] Add Russian translation

Addendum to fe5c50e and e6be187.

2 years ago[FREELDR] PXE: Fix network packet size
Michael Fritscher [Fri, 1 Feb 2019 19:14:00 +0000 (22:14 +0300)]
[FREELDR] PXE: Fix network packet size

1024 bytes should fit into a single network packet. CORE-15706

2 years ago[SNDVOL32] Add the 'Advanced Controls for Volume Control' dialog. It does nothing...
Eric Kohl [Mon, 18 Feb 2019 23:01:18 +0000 (00:01 +0100)]
[SNDVOL32] Add the 'Advanced Controls for Volume Control' dialog. It does nothing useful yet.

2 years ago[MSI] Prevent uninitialized variable usage
Mark Jansen [Sun, 17 Feb 2019 19:46:47 +0000 (20:46 +0100)]
[MSI] Prevent uninitialized variable usage

2 years ago[MSI] Do not leak rootkey
Mark Jansen [Sun, 17 Feb 2019 19:46:24 +0000 (20:46 +0100)]
[MSI] Do not leak rootkey

2 years ago[SHELL32] Abort change notifications on a nullptr
Mark Jansen [Sat, 16 Feb 2019 17:35:08 +0000 (18:35 +0100)]
[SHELL32] Abort change notifications on a nullptr

2 years ago[SNDVOL32] Implement the dialog resize code for the 'Advanced Controls' menu item...
Eric Kohl [Sun, 17 Feb 2019 23:58:28 +0000 (00:58 +0100)]
[SNDVOL32] Implement the dialog resize code for the 'Advanced Controls' menu item and prepare for clicks on the 'Advanced' button.

2 years ago[SNDVOL32] Fix the window height issue when the line selection changes and implement...
Eric Kohl [Sun, 17 Feb 2019 13:04:39 +0000 (14:04 +0100)]
[SNDVOL32] Fix the window height issue when the line selection changes and implement the 'Advanced Controls' menu item.

CORE-9108 CORE-15751

2 years ago[RTL] Fix GCC build.
Thomas Faber [Sun, 17 Feb 2019 08:58:28 +0000 (09:58 +0100)]
[RTL] Fix GCC build.

2 years ago[ACPI] Update ACPICA library to version 20190215.
Thomas Faber [Fri, 15 Feb 2019 18:43:25 +0000 (19:43 +0100)]
[ACPI] Update ACPICA library to version 20190215.

2 years ago[COMCTL32] Check for NULL pointer when handling BCM_GETIDEALSIZE.
Thomas Faber [Sun, 3 Feb 2019 15:55:04 +0000 (16:55 +0100)]
[COMCTL32] Check for NULL pointer when handling BCM_GETIDEALSIZE.

Fixes crash in comctl32_winetest:button.

2 years ago[COMCTL32] Add NULL checks to SetWindowSubclass.
Thomas Faber [Sun, 3 Feb 2019 15:41:29 +0000 (16:41 +0100)]
[COMCTL32] Add NULL checks to SetWindowSubclass.

Imports Wine commit 04847e68f87 by Sven Baars.

Fixes crash in comctl32_winetest:subclass.

2 years ago[RTL] Protect pointer validity check in RtlFreeHeap with SEH.
Thomas Faber [Sun, 3 Feb 2019 12:57:21 +0000 (13:57 +0100)]
[RTL] Protect pointer validity check in RtlFreeHeap with SEH.

Fixes crash in kernel32_winetest:heap.

2 years ago[CMLIB] Assign a signature to the in-memory HHIVE registry hive structure. CORE-15753
Hermès Bélusca-Maïto [Sun, 17 Feb 2019 00:10:27 +0000 (01:10 +0100)]
[CMLIB] Assign a signature to the in-memory HHIVE registry hive structure. CORE-15753

Makes the `!reg hivelist` WinDbg command working in ReactOS.

Dedicated to Mark Jansen.

See for more details:

2 years ago[CMLIB] Minor code style changes only: Use slightly more explicit signature #define...
Hermès Bélusca-Maïto [Sun, 17 Feb 2019 00:07:56 +0000 (01:07 +0100)]
[CMLIB] Minor code style changes only: Use slightly more explicit signature #define names so that we know to which hive structure they correspond.

2 years ago[NTOS:CM] Set and reset the CMHIVE HiveIsLoading flag adequately. Fix an assertion...
Hermès Bélusca-Maïto [Sat, 16 Feb 2019 23:54:59 +0000 (00:54 +0100)]
[NTOS:CM] Set and reset the CMHIVE HiveIsLoading flag adequately. Fix an assertion in CmFlushKey() and reset the CMHIVE ViewLockOwner when releasing the view lock.

Eric Kohl [Sat, 16 Feb 2019 19:36:46 +0000 (20:36 +0100)]

2 years ago[SNDVOL32] Change the menu item prefix from IDC to IDM
Eric Kohl [Sat, 16 Feb 2019 18:22:57 +0000 (19:22 +0100)]
[SNDVOL32] Change the menu item prefix from IDC to IDM

2 years ago[WIN32K:NTUSER] Do not try to reposition an off-screen menu as if it were a popup... menu_alignment 1360/head
Mark Jansen [Sat, 16 Feb 2019 14:07:49 +0000 (15:07 +0100)]
[WIN32K:NTUSER] Do not try to reposition an off-screen menu as if it were a popup menu

2 years ago[KERNEL32] Stub SetThreadErrorMode()
Pierre Schweitzer [Sat, 16 Feb 2019 13:12:01 +0000 (14:12 +0100)]
[KERNEL32] Stub SetThreadErrorMode()

Now, Steam crashes because of the stub of GetSystemTimePreciseAsFileTime


2 years ago[SNDVOL32] Enable the balance and volume trackbars only if the line has a volume...
Eric Kohl [Sat, 16 Feb 2019 12:54:46 +0000 (13:54 +0100)]
[SNDVOL32] Enable the balance and volume trackbars only if the line has a volume fader control.

2 years ago[MSAFD] Add an initial implementation of SIO_GET_EXTENSION_FUNCTION_POINTER IOCTL
Pierre Schweitzer [Sat, 16 Feb 2019 12:46:40 +0000 (13:46 +0100)]

Also stub the related functions the IOCTL will return, namely: WSAID_ACCEPTEX,

This will allow Steam client not to fail in an ASSERT
related to the Steam client PlatformSocketsInit function.

Even though, this doesn't fix Steam running on ReactOS since its UI requires
a Windows 7 API from Kernel32: SetThreadErrorMode().

Nota: its crash got fixed thanks to the Wine sync done recently.


2 years ago[SNDVOL32] Disable the Mute checkbox for all lines that do not have a mute switch...
Eric Kohl [Sat, 16 Feb 2019 11:57:19 +0000 (12:57 +0100)]
[SNDVOL32] Disable the Mute checkbox for all lines that do not have a mute switch control

2 years ago[E1000] Remove useless null check
Pierre Schweitzer [Sat, 16 Feb 2019 09:01:50 +0000 (10:01 +0100)]
[E1000] Remove useless null check

CID 512827

2 years ago[E1000] Don't attempt to free uninitialized pointer
Pierre Schweitzer [Sat, 16 Feb 2019 08:58:44 +0000 (09:58 +0100)]
[E1000] Don't attempt to free uninitialized pointer

CID 1442660

2 years agomsgdump.h undocumented drag & drop support (#1359)
Katayama Hirofumi MZ [Sat, 16 Feb 2019 08:27:25 +0000 (17:27 +0900)]
msgdump.h undocumented drag & drop support (#1359)

In sdk/include/reactos/msgdump.h, support Drag & Drop undocumented messages.

2 years ago[IPHLPAPI] Properly handle GetModuleBaseName failure
Pierre Schweitzer [Sat, 16 Feb 2019 08:05:15 +0000 (09:05 +0100)]
[IPHLPAPI] Properly handle GetModuleBaseName failure

CID 14426621442663

2 years ago[IPHLPAPI] Check pointers when returning module info from specific connection
Pierre Schweitzer [Sat, 16 Feb 2019 08:00:06 +0000 (09:00 +0100)]
[IPHLPAPI] Check pointers when returning module info from specific connection

2 years ago[IPHLPAPI] Remove dead code
Pierre Schweitzer [Sat, 16 Feb 2019 07:48:08 +0000 (08:48 +0100)]
[IPHLPAPI] Remove dead code

CID 513306, 14426731442697

2 years ago[FASTFAT] On volume open, update share access if volume was already open
Pierre Schweitzer [Thu, 14 Feb 2019 09:48:32 +0000 (10:48 +0100)]
[FASTFAT] On volume open, update share access if volume was already open

It was never updated afterwards, leading to a totally loss of share
access information amongst callers.

2 years ago[VFATLIB] Don't forcibly delete LFN when not in RW mode
Pierre Schweitzer [Thu, 14 Feb 2019 09:12:31 +0000 (10:12 +0100)]
[VFATLIB] Don't forcibly delete LFN when not in RW mode