reactos.git
3 years ago[EVENTVWR] Additions for the Event Viewer.
Hermès Bélusca-Maïto [Tue, 17 Apr 2018 21:01:45 +0000 (23:01 +0200)]
[EVENTVWR] Additions for the Event Viewer.
CORE-11637, CORE-12269

- Implement support for remote connections to NT computers to view their
  event logs (and the event logs settings). For the moment the remote
  computer name specification is is only available via the command-line.
  Note that the paths to the event log files need also to be translated
  to network-share format.
- Implement loading and saving the settings of the event viewer.
- Implement showing/hiding the events description pane, the ListView
  grid, and whether or not to save the EventViewer settings.
- Handle hypertext link click handling for the RichEdit edit box of the
  events description dialog.

3 years ago[EVENTVWR] Code style only.
Hermès Bélusca-Maïto [Tue, 17 Apr 2018 20:43:47 +0000 (22:43 +0200)]
[EVENTVWR] Code style only.

3 years ago[NTOSKRNL] Properly reset VACB on free
Pierre Schweitzer [Sat, 14 Apr 2018 09:13:12 +0000 (11:13 +0200)]
[NTOSKRNL] Properly reset VACB on free

CID 1434271

3 years ago[NTOSKRNL] Drop the VACB lock.
Pierre Schweitzer [Sun, 8 Apr 2018 17:09:36 +0000 (19:09 +0200)]
[NTOSKRNL] Drop the VACB lock.
This has have several benefits for ReactOS Cc:
- It helps reducing potential deadlocks situations in Cc
- It speeds up ReactOS by reducing locks
- It gets us a bit closer to Windows VACB

CORE-14349

3 years ago[NTOSKRNL] Use interlocked operations when dealing with map count.
Pierre Schweitzer [Sun, 8 Apr 2018 16:58:15 +0000 (18:58 +0200)]
[NTOSKRNL] Use interlocked operations when dealing with map count.

CORE-14349

3 years ago[NTOSKRNL] Map the VACB in kernel space before inserting it in lists.
Pierre Schweitzer [Sun, 8 Apr 2018 16:45:38 +0000 (18:45 +0200)]
[NTOSKRNL] Map the VACB in kernel space before inserting it in lists.
The avoids race conditions where attempts to read from disk to
not fully initialized VACB were performed.
Also, added more debug prints in such situations.

CORE-14349

3 years ago[NTOSKRNL] Add extra sanity checks for VACB lists.
Pierre Schweitzer [Sun, 8 Apr 2018 16:34:00 +0000 (18:34 +0200)]
[NTOSKRNL] Add extra sanity checks for VACB lists.
We now always initialize list members from the VACB
and make sure the list entry has properly been removed
from the list before free.

CORE-14349

3 years ago[NTOS:MM] Do not map two pages into hyperspace in MiCopyFromUserPage. CORE-14548
Thomas Faber [Sun, 15 Apr 2018 17:42:18 +0000 (19:42 +0200)]
[NTOS:MM] Do not map two pages into hyperspace in MiCopyFromUserPage. CORE-14548

Doing this is not only wrong because it acquires the same spinlock twice,
it also completely breaks the TLB flushing logic in MiMapPageInHyperSpace.
If the PTE with Offset 1 is still valid when a wrap-around to 0 happens,
the TLB flush on wrap-around will not clear the entry for this previous page.
After another loop around all hyperspace pages, page 1 is re-used but its
TLB entry has not been flushed, which may result into incorrect translation.

3 years ago[ZIPFLDR] Add Chinese(Simplified) translation
Li Keqing [Sun, 15 Apr 2018 12:45:31 +0000 (20:45 +0800)]
[ZIPFLDR] Add Chinese(Simplified) translation

3 years ago[NET] Implement the options in the NET CONFIG SERVER command
Eric Kohl [Sun, 15 Apr 2018 13:32:01 +0000 (15:32 +0200)]
[NET] Implement the options in the NET CONFIG SERVER command

3 years ago[ZIPFLDR] Add French translation
Pierre Schweitzer [Sun, 15 Apr 2018 08:56:00 +0000 (10:56 +0200)]
[ZIPFLDR] Add French translation

3 years ago[WINLOGON] Romanian translation update
Bișoc George [Sat, 14 Apr 2018 15:29:55 +0000 (17:29 +0200)]
[WINLOGON] Romanian translation update

3 years ago[TRANSLATION][ZIPFLDR] Added Estonian translation
Joann Mõndresku [Sat, 14 Apr 2018 18:19:39 +0000 (21:19 +0300)]
[TRANSLATION][ZIPFLDR] Added Estonian translation

3 years ago[ZIPFLDR] Implement Romanian resource translation 476/head
Bișoc George [Sun, 8 Apr 2018 18:28:28 +0000 (20:28 +0200)]
[ZIPFLDR] Implement Romanian resource translation

3 years ago[ZIPFLDR] Implement Italian resource translation
Bișoc George [Sun, 8 Apr 2018 16:38:19 +0000 (18:38 +0200)]
[ZIPFLDR] Implement Italian resource translation

3 years ago[ZIPFLDR] Typo fix on constant
Bișoc George [Sun, 8 Apr 2018 15:31:29 +0000 (17:31 +0200)]
[ZIPFLDR] Typo fix on constant

3 years ago[ZIPFLDR] Support for multiple languages interface
Bișoc George [Sun, 8 Apr 2018 15:15:24 +0000 (17:15 +0200)]
[ZIPFLDR] Support for multiple languages interface

3 years ago[NETMSG] Add netmsg resource dll with some lmerr messages
Eric Kohl [Sat, 14 Apr 2018 16:31:14 +0000 (18:31 +0200)]
[NETMSG] Add netmsg resource dll with some lmerr messages

3 years ago[NET] Add help text for the NET GROUP command and improve the NET LOCALGROUP help...
Eric Kohl [Sat, 14 Apr 2018 12:54:50 +0000 (14:54 +0200)]
[NET] Add help text for the NET GROUP command and improve the NET LOCALGROUP help text

3 years ago[KERNEL32] FlsAlloc(): Add a missing '\n' to a DPRINT1()
Serge Gautherie [Sun, 8 Apr 2018 21:44:35 +0000 (23:44 +0200)]
[KERNEL32] FlsAlloc(): Add a missing '\n' to a DPRINT1()

3 years ago[SHELL32] Sync CShellDispatch and family with wine. 490/head
Mark Jansen [Fri, 13 Apr 2018 20:59:04 +0000 (22:59 +0200)]
[SHELL32] Sync CShellDispatch and family with wine.
Incorporates work from Ivan Rodionov.
CORE-12955

3 years ago[SC] Don't leak service status info on success
Pierre Schweitzer [Sat, 14 Apr 2018 13:38:12 +0000 (15:38 +0200)]
[SC] Don't leak service status info on success

CID 1434266

3 years ago[NET] Add help text for the NET LOCALGROUP command
Eric Kohl [Sat, 14 Apr 2018 11:23:37 +0000 (13:23 +0200)]
[NET] Add help text for the NET LOCALGROUP command

3 years ago[VFATLIB] Simplify in-memory boot sector copy.
Pierre Schweitzer [Sat, 14 Apr 2018 10:05:32 +0000 (12:05 +0200)]
[VFATLIB] Simplify in-memory boot sector copy.
So that, coverity is happy again.
NFC

CID 143423014342331434238143424314342461434272

3 years ago[NTFS] When reading $I30 attribute fails, stop the rename operation.
Pierre Schweitzer [Sat, 14 Apr 2018 09:39:33 +0000 (11:39 +0200)]
[NTFS] When reading $I30 attribute fails, stop the rename operation.

This makes the function return the error instead of continuing and
performing use-after-frees operations.
This is likely to be a forgotten return!

CID 14342541434268

3 years ago[EVENTLOG] Register .evt file extension so that we can open event log files from...
Hermès Bélusca-Maïto [Fri, 13 Apr 2018 21:46:32 +0000 (23:46 +0200)]
[EVENTLOG] Register .evt file extension so that we can open event log files from the shell.

Take also the opportunity to fix a problematic "%1" in wordpad.exe command line.

3 years ago[HAL] Reset the stack pointer to the stack frame when calling second-entry interrupt...
Thomas Faber [Fri, 13 Apr 2018 06:48:57 +0000 (08:48 +0200)]
[HAL] Reset the stack pointer to the stack frame when calling second-entry interrupt handlers. CORE-14449

Because we can encounter pending interrupts repeatedly,
HalpEndSoftwareInterrupt and HalEndSystemInterrupt already clean up the stack
space for their arguments (done for CORE-11123/CORE-14076).
However these functions are called from C functions such as KiInterruptDispatch
and HalpDispatchInterrupt2[ndEntry]. These callers also use up stack space,
and it is unknown how much.
To fix this, we simply reset the stack pointer to the location of the trap
frame, which is where it points during a first-level dispatch. This cleans
up the stack usage of any callers higher up, and is okay because a return
will happen through the trap frame anyway.

Dedicated to Pierre.

3 years ago[EVENTVWR] Additions to the Event Viewer.
Hermès Bélusca-Maïto [Thu, 12 Apr 2018 22:52:25 +0000 (00:52 +0200)]
[EVENTVWR] Additions to the Event Viewer.

- Don't hardcode a buffer length in ExpandEnvironmentStringsW() call.
- If no file name is associated to a log (ErrorLog->FileName == NULL),
  don't try to attempt looking at its file properties. This also allows
  avoiding a crash in the FindFirstFileW() call under certain conditions
  on Windows.

3 years ago[NTDLL] Allow shimdata to override the process manifest. 485/head
Mark Jansen [Tue, 10 Apr 2018 22:18:17 +0000 (00:18 +0200)]
[NTDLL] Allow shimdata to override the process manifest.

3 years ago[SDB][APPHELP] Add ShimVersionNT data tags + read them in SdbPackAppCompatData
Mark Jansen [Tue, 10 Apr 2018 22:05:41 +0000 (00:05 +0200)]
[SDB][APPHELP] Add ShimVersionNT data tags + read them in SdbPackAppCompatData

3 years ago[APPHELP_APITEST] Add tests for Data tags
Mark Jansen [Tue, 10 Apr 2018 20:40:27 +0000 (22:40 +0200)]
[APPHELP_APITEST] Add tests for Data tags

3 years ago[APPHELP] Implement SdbQueryData[Ex][TagID]
Mark Jansen [Tue, 10 Apr 2018 20:42:03 +0000 (22:42 +0200)]
[APPHELP] Implement SdbQueryData[Ex][TagID]

3 years ago[XML2SDB] Add support for DATA in Layers.
Mark Jansen [Tue, 10 Apr 2018 20:39:29 +0000 (22:39 +0200)]
[XML2SDB] Add support for DATA in Layers.

3 years ago[USER32] Fix compilation when USE_VERSIONED_CLASSES is not defined
Joachim Henze [Thu, 12 Apr 2018 15:57:38 +0000 (17:57 +0200)]
[USER32] Fix compilation when USE_VERSIONED_CLASSES is not defined

Variable 'Status' would be set but not used otherwise in this case.
This commit will not fix or improve CORE-13278,
but was spotted when having a look at that.

3 years ago[EVENTVWR] Add support for a command-line for the Event Log Viewer.
Hermès Bélusca-Maïto [Thu, 12 Apr 2018 00:45:37 +0000 (02:45 +0200)]
[EVENTVWR] Add support for a command-line for the Event Log Viewer.
CORE-12269

- Add support for '/?' and '/l:' switches. The former displays usage
  information. The latter allows to specify an event log file to load.
  Also one can specify the computer name from which one wants to
  retrieve events for display (work in progress).
- In EnumEventsThread(), move around the code that updates the
  application title and status bar, so that the selected event log name
  and loading status is always displayed first, while loading itself is
  in progress.

3 years ago[EVENTVWR] Enhancements to the event log viewer.
Hermès Bélusca-Maïto [Thu, 12 Apr 2018 00:32:37 +0000 (02:32 +0200)]
[EVENTVWR] Enhancements to the event log viewer.

- Initialize hwndMainWindow as it can be used before it is properly
  initialized with an existing window handle.
- Transform ShowLastWin32Error() to a more generic ShowWin32Error().
- Use iswdigit() instead of isdigit().
- Add extra heap buffer cleanup.
- Split OpenUserEventLog() in two: OpenUserEventLog() that displays
  an open-file dialog, and OpenUserEventLogFile() that does the real
  work of allocating internal structures and opening the log file using
  the event-log service. We also check that the file really exists
  before proceeding further.
- Force treeview repaint when *children* items are inserted, because
  otherwise the expand/collapse buttons do not display next to parent
  items (this problem happens on Windows too).
- Reshuffle the resource string IDs.

3 years ago[NET] Replace remaining hard-coded strings by string resources for the NET STATISTICS...
Eric Kohl [Wed, 11 Apr 2018 22:58:30 +0000 (00:58 +0200)]
[NET] Replace remaining hard-coded strings by string resources for the NET STATISTICS command.

3 years ago[WIN32SS][NTDDRAW] Fix ddraw palette regression CORE-13714
Joachim Henze [Wed, 11 Apr 2018 13:39:54 +0000 (15:39 +0200)]
[WIN32SS][NTDDRAW] Fix ddraw palette regression CORE-13714

This nice patch of Jerome Gardou improves palette
when VBEMP & inbuilt Mesa is used for
Diablo II, MS Age Of Empires 1, Anno 1602
to the state we had in SVN r75060 and below.

We already committed this fix into 0.4.8-release before.

3 years ago[KERNEL32/STRING] Sync sortkey.c with Wine Staging 3.3. CORE-14434
Amine Khaldi [Wed, 11 Apr 2018 11:49:52 +0000 (12:49 +0100)]
[KERNEL32/STRING] Sync sortkey.c with Wine Staging 3.3. CORE-14434

3 years ago[KERNEL32/STRING] Sync lcformat.c with Wine Staging 3.3. CORE-14434
Amine Khaldi [Wed, 11 Apr 2018 11:48:50 +0000 (12:48 +0100)]
[KERNEL32/STRING] Sync lcformat.c with Wine Staging 3.3. CORE-14434

3 years ago[KERNEL32/STRING] Sync format_msg.c with Wine Staging 3.3. CORE-14434
Amine Khaldi [Wed, 11 Apr 2018 11:47:12 +0000 (12:47 +0100)]
[KERNEL32/STRING] Sync format_msg.c with Wine Staging 3.3. CORE-14434

3 years ago[KERNEL32/STRING] Sync fold.c with Wine Staging 3.3. CORE-14434
Amine Khaldi [Wed, 11 Apr 2018 11:45:42 +0000 (12:45 +0100)]
[KERNEL32/STRING] Sync fold.c with Wine Staging 3.3. CORE-14434

3 years ago[KERNEL32] Missed this file. Fixes build.
Amine Khaldi [Wed, 11 Apr 2018 11:44:23 +0000 (12:44 +0100)]
[KERNEL32] Missed this file. Fixes build.

3 years ago[KERNEL32/STRING] Import digitmap.c from, and sync casemap.c with, Wine Staging 3...
Amine Khaldi [Wed, 11 Apr 2018 11:39:39 +0000 (12:39 +0100)]
[KERNEL32/STRING] Import digitmap.c from, and sync casemap.c with, Wine Staging 3.3. CORE-14434

3 years ago[KERNEL32/WINE] Sync res.c with Wine Staging 3.3. CORE-14434
Amine Khaldi [Wed, 11 Apr 2018 11:36:44 +0000 (12:36 +0100)]
[KERNEL32/WINE] Sync res.c with Wine Staging 3.3. CORE-14434

3 years ago[KERNEL32/WINE] Sync profile.c with Wine Staging 3.3. CORE-14434
Amine Khaldi [Wed, 11 Apr 2018 11:32:54 +0000 (12:32 +0100)]
[KERNEL32/WINE] Sync profile.c with Wine Staging 3.3. CORE-14434

3 years ago[KERNEL32/WINE] Sync lzexpand.c with Wine Staging 3.3. CORE-14434
Amine Khaldi [Wed, 11 Apr 2018 11:30:53 +0000 (12:30 +0100)]
[KERNEL32/WINE] Sync lzexpand.c with Wine Staging 3.3. CORE-14434

3 years ago[WIDL] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Wed, 11 Apr 2018 11:29:04 +0000 (12:29 +0100)]
[WIDL] Sync with Wine Staging 3.3. CORE-14434

3 years ago[UNICODE] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Wed, 11 Apr 2018 11:25:43 +0000 (12:25 +0100)]
[UNICODE] Sync with Wine Staging 3.3. CORE-14434

3 years ago[TRANSLATION] Polish translation update for drwtsn32, winlogon and usersrv. (#475)
Adam Słaboń [Tue, 10 Apr 2018 20:54:34 +0000 (22:54 +0200)]
[TRANSLATION] Polish translation update for drwtsn32, winlogon and usersrv. (#475)

3 years ago[TRANSLATION][SHELL32] Corrected mistakes
Joann Mõndresku [Tue, 10 Apr 2018 15:25:48 +0000 (18:25 +0300)]
[TRANSLATION][SHELL32] Corrected mistakes

3 years ago[NET] Improve the NET STATISTICS command
Eric Kohl [Tue, 10 Apr 2018 19:32:30 +0000 (21:32 +0200)]
[NET] Improve the NET STATISTICS command

- Add resource strings for the NET STATISTICS SERVER command.
- Convert and display the 'statistics since' time.

3 years ago[TRANSLATION][MEDIA] Polish translation update (#479)
Paweł Cholewa [Tue, 10 Apr 2018 13:50:03 +0000 (15:50 +0200)]
[TRANSLATION][MEDIA] Polish translation update (#479)

3 years ago[RTL] actctx: Use the new RosGetProcessCompatVersion. 419/head
Mark Jansen [Mon, 9 Apr 2018 16:55:59 +0000 (18:55 +0200)]
[RTL] actctx: Use the new RosGetProcessCompatVersion.

3 years ago[NTDLL] Check the process manifest at startup for a compatibility section.
Mark Jansen [Sat, 13 Jan 2018 20:32:48 +0000 (21:32 +0100)]
[NTDLL] Check the process manifest at startup for a compatibility section.

3 years agoFix build
Giannis Adamopoulos [Sun, 8 Apr 2018 22:42:17 +0000 (01:42 +0300)]
Fix build

3 years ago[RTL] actctx.c: Use an alternative implicit activation context when an application...
Giannis Adamopoulos [Sun, 8 Apr 2018 19:28:29 +0000 (22:28 +0300)]
[RTL] actctx.c: Use an alternative implicit activation context when an application is built for latest windows versions.
Instead of loading systemcompatible.manifest as the implicit activation context, load forwardcompatible.manifest
Add a new assembly containing all apisets called ReactOS.Apisets and make it a dependency to forwardcompatible.manifest

3 years ago[RTL] Fixes for supportedOS close elements.
Mark Jansen [Sun, 8 Apr 2018 22:01:30 +0000 (00:01 +0200)]
[RTL] Fixes for supportedOS close elements.
Imported from wine
f8cca44: ntdll: Allow closing tags for 'supportedOS' elements.
697d4a7: ntdll: Allow explicitly specified asm.v2 namespace for "trustInfo".

3 years ago[NET] Add the NET STATISTICS command
Eric Kohl [Sun, 8 Apr 2018 18:04:11 +0000 (20:04 +0200)]
[NET] Add the NET STATISTICS command

3 years ago[CMAKE] Use configuration-specific names for files generated by CMake. 474/head
Thomas Faber [Sun, 8 Apr 2018 16:31:27 +0000 (18:31 +0200)]
[CMAKE] Use configuration-specific names for files generated by CMake.

Fixes configuring with VSSolution.

3 years ago[KERNEL32_VISTA] This function now comes from rtlfuncs.h
Mark Jansen [Sun, 8 Apr 2018 15:47:43 +0000 (17:47 +0200)]
[KERNEL32_VISTA] This function now comes from rtlfuncs.h

3 years ago[APISETS] Update the script to take the current newline setting into account.
Mark Jansen [Sun, 8 Apr 2018 09:10:11 +0000 (11:10 +0200)]
[APISETS] Update the script to take the current newline setting into account.

3 years ago[KERNEL32_VISTA] Export InitializeCriticalSectionEx.
Mark Jansen [Sun, 8 Apr 2018 09:09:54 +0000 (11:09 +0200)]
[KERNEL32_VISTA] Export InitializeCriticalSectionEx.

3 years ago[KERNEL32] Implement FlsAlloc/FlsFree based on Wine's implementation. 472/head
Mark Jansen [Sat, 7 Apr 2018 21:41:53 +0000 (23:41 +0200)]
[KERNEL32] Implement FlsAlloc/FlsFree based on Wine's implementation.

3 years ago[USERSRV] HardError: Fix compilation warning; fix few comments; fix the default empty...
Hermès Bélusca-Maïto [Sun, 8 Apr 2018 14:15:56 +0000 (16:15 +0200)]
[USERSRV] HardError: Fix compilation warning; fix few comments; fix the default empty window title string.

3 years ago[ZIPFLDR] Typo fix
Bișoc George [Sun, 8 Apr 2018 09:34:13 +0000 (11:34 +0200)]
[ZIPFLDR] Typo fix

3 years ago[EXPLORER] Implement the feature of cleanly shutting down the explorer shell when...
Hermès Bélusca-Maïto [Sat, 7 Apr 2018 22:33:23 +0000 (00:33 +0200)]
[EXPLORER] Implement the feature of cleanly shutting down the explorer shell when cancelling the shutdown-dialog while pressing the CTRL-ALT-SHIFT keys.

See the feature description in https://msdn.microsoft.com/en-us/library/windows/desktop/cc144064(v=vs.85).aspx
and the additional observations reported in CORE-14358 .

3 years ago[EXPLORER] Remove trailing whitespace.
Hermès Bélusca-Maïto [Sat, 7 Apr 2018 22:32:11 +0000 (00:32 +0200)]
[EXPLORER] Remove trailing whitespace.

3 years ago[MSGINA] Add the shutdown reason dialog but keep it disabled by default
Eric Kohl [Sat, 7 Apr 2018 18:47:10 +0000 (20:47 +0200)]
[MSGINA] Add the shutdown reason dialog but keep it disabled by default

3 years ago[BOOTDATA] Remove 'debugout.sys' mention since this driver has been removed in r26032...
Hermès Bélusca-Maïto [Sat, 7 Apr 2018 20:13:20 +0000 (22:13 +0200)]
[BOOTDATA] Remove 'debugout.sys' mention since this driver has been removed in r26032 (ad07a1e5).

3 years ago[EXPLORER] Remove double 'return' statement. Determining whether it should be HTBORDE...
Hermès Bélusca-Maïto [Sat, 7 Apr 2018 17:06:04 +0000 (19:06 +0200)]
[EXPLORER] Remove double 'return' statement. Determining whether it should be HTBORDER or HTCLIENT is left as an exercise to the reader.
Spotted by 'mudhead'. CORE-14528

3 years ago[USERSRV] Hard-error improvements 7/7 446/head
Hermès Bélusca-Maïto [Fri, 23 Mar 2018 22:50:50 +0000 (23:50 +0100)]
[USERSRV] Hard-error improvements 7/7

- Use a more descriptive "unknown hard error" string than Windows' one.
- Improve the computation of the buffer size for the hard error message
  by using _vscwprintf() instead of just "guessing" which size the fully
  printf'ed message could be.

3 years ago[USERSRV] Hard-error improvements 6/7
Hermès Bélusca-Maïto [Sat, 24 Mar 2018 22:07:35 +0000 (23:07 +0100)]
[USERSRV] Hard-error improvements 6/7

Make UserpFormatMessages() return the possible timeout for the hard error; use it when displaying the hard error message boxes.

3 years ago[USERSRV] Hard-error improvements 5/7 - Implement STATUS_SERVICE_NOTIFICATION handling.
Hermès Bélusca-Maïto [Mon, 19 Mar 2018 01:22:20 +0000 (02:22 +0100)]
[USERSRV] Hard-error improvements 5/7 - Implement STATUS_SERVICE_NOTIFICATION handling.

- In UserpCaptureStringParameters(), always capture the parameter
  strings with a terminating NULL. Also, no need to convert them to
  ANSI if they are used with a STATUS_SERVICE_NOTIFICATION message.
- Determine within UserpFormatMessages() the message box flags to be
  used, either from the message parameters (if STATUS_SERVICE_NOTIFICATION)
  or from the proposed response options and message status severity.
  These flags are then used by both UserpShowInformationBalloon()/UserpShellHardError()
  and by UserpMessageBox().
- Improve Message validation (especially for STATUS_SERVICE_NOTIFICATION).
- Try to display the hard error status number if it's an unknown one.

3 years ago[USERSRV] Hard-error improvements 4/7
Hermès Bélusca-Maïto [Sat, 24 Mar 2018 21:47:50 +0000 (22:47 +0100)]
[USERSRV] Hard-error improvements 4/7

- Make UserpFormatMessages() always succeed by falling back on
  static string buffers if allocating large string buffers fail due to
  lack of memory. Then the hard error popups will have truncated
  strings, but at least something will be displayed instead of nothing,
  thus alerting the user that something went wrong anyway.
- Simplify a bit the code by moving the NtOpenProcess(),
  UserpCaptureStringParameters() and UserpFreeStringParameters() calls
  inside UserpFormatMessages(). This also allows simplifying its
  prototype.

3 years ago[USERSRV] Hard-error improvements 3/7
Hermès Bélusca-Maïto [Sun, 4 Mar 2018 16:38:06 +0000 (17:38 +0100)]
[USERSRV] Hard-error improvements 3/7

- Cache localized hard error message components: the status severity,
  the system process name and the unhandled exception debug strings.
- Try not to fail too much. In particular, don't fail if a string could
  not be correctly captured in UserpCaptureStringParameters() (we then
  use a default empty string). The next aim is to make UserpFormatMessages()
  not failing at all.
- Use RtlStringCbPrintf(Ex)W where possible so that one can use counted
  (and not NULL-terminated) UNICODE_STRINGs where possible. This allows
  using counted resource strings without having to allocate memory.
- If available, prepend the window title of the application that
  triggered the hard error to the hard error message box caption.

3 years ago[USERSRV] Hard-error improvements 2/7 - More failure path handling.
Hermès Bélusca-Maïto [Sun, 4 Mar 2018 16:39:44 +0000 (17:39 +0100)]
[USERSRV] Hard-error improvements 2/7 - More failure path handling.

In particular do not always fail as soon as there is an error, because they may be the sign of an OS problem and this is precisely in this case that we want to display a hard-error.

3 years ago[USERSRV] Hard-error improvements 1/7
Hermès Bélusca-Maïto [Sat, 24 Mar 2018 20:26:20 +0000 (21:26 +0100)]
[USERSRV] Hard-error improvements 1/7

- Use hard-error captions depending on the status code severity.
- Improve handling of the STATUS_UNHANDLED_EXCEPTION error. Start
  implementing the display of the dialog button descriptions ("OK" to
  terminate the application; "Cancel" to debug the application).
- Add support for the "ErrorMode" and "ShellErrorMode" registry values
  under HKLM\System\CurrentControlSet\Control\Windows.
- Use MessageBoxTimeoutW() in UserpMessageBox() to support different
  message box timeouts.
- Log hard errors into the System event log.

3 years ago[NDK] Increase MAXIMUM_HARDERROR_PARAMETERS for Win2k3 compatibility.
Hermès Bélusca-Maïto [Sat, 17 Feb 2018 15:25:44 +0000 (16:25 +0100)]
[NDK] Increase MAXIMUM_HARDERROR_PARAMETERS for Win2k3 compatibility.

3 years ago[RAPPS] Introduce 'SizeBytes' DB entry and use it for display
Alexander Shaposhnikov [Sat, 7 Apr 2018 16:17:22 +0000 (19:17 +0300)]
[RAPPS] Introduce 'SizeBytes' DB entry and use it for display

This will allow us to reduce the DB size a little by avoiding
duplication for each and every entry.
Original patch by JIRA user "swyter"

CORE-10310

3 years ago[ZIPFLDR] Register the shell extension. 451/head
Mark Jansen [Fri, 29 Dec 2017 22:45:47 +0000 (23:45 +0100)]
[ZIPFLDR] Register the shell extension.
CORE-7684

3 years ago[ZIPFLDR] Initial implementation.
Mark Jansen [Fri, 29 Dec 2017 22:45:02 +0000 (23:45 +0100)]
[ZIPFLDR] Initial implementation.
Icon by Jared Smudde
CORE-7684

3 years ago[ZLIB] Add minizip as library.
Mark Jansen [Tue, 3 Apr 2018 20:15:20 +0000 (22:15 +0200)]
[ZLIB] Add minizip as library.
CORE-7684

3 years ago[SHELL32_APITEST] Show that our current SHCreateFileExtractIconW is incorrect.
Mark Jansen [Tue, 27 Mar 2018 17:58:43 +0000 (19:58 +0200)]
[SHELL32_APITEST] Show that our current SHCreateFileExtractIconW is incorrect.
CORE-14082

3 years ago[SHELL32] Partially implement SHCreateFileExtractIconW
Mark Jansen [Tue, 27 Mar 2018 17:57:00 +0000 (19:57 +0200)]
[SHELL32] Partially implement SHCreateFileExtractIconW
CORE-14082

3 years ago[SHELL32] Initial partial IShellFolderViewCB implementation.
Mark Jansen [Mon, 18 Dec 2017 22:27:05 +0000 (23:27 +0100)]
[SHELL32] Initial partial IShellFolderViewCB implementation.

3 years ago[APISETS] Add the initial set of auto-generated files. 468/head
Mark Jansen [Sat, 7 Apr 2018 01:24:12 +0000 (03:24 +0200)]
[APISETS] Add the initial set of auto-generated files.
CORE-13231

3 years ago[APISETS] Introduce a script that will generate apisets based on wine apisets.
Mark Jansen [Sat, 7 Apr 2018 01:24:07 +0000 (03:24 +0200)]
[APISETS] Introduce a script that will generate apisets based on wine apisets.
Functions that are present in ReactOS will be forwarded, the rest stubbed.
CORE-13231

3 years ago[SDK] Remove some unused includes in stubs.h
Mark Jansen [Sat, 7 Apr 2018 01:23:56 +0000 (03:23 +0200)]
[SDK] Remove some unused includes in stubs.h
CORE-13231

3 years ago[NTOS:CC] Use UNIMPLEMENTED_ONCE instead of custom code
Serge Gautherie [Thu, 22 Feb 2018 14:31:04 +0000 (15:31 +0100)]
[NTOS:CC] Use UNIMPLEMENTED_ONCE instead of custom code

- Rewrite e319f85e67b1d057fb1c0d0449a6756fa0d459ba.

3 years ago[SDK:REACTOS] Define UNIMPLEMENTED_ONCE for "!DBG && _MSC_VER" too
Serge Gautherie [Thu, 22 Feb 2018 14:26:10 +0000 (15:26 +0100)]
[SDK:REACTOS] Define UNIMPLEMENTED_ONCE for "!DBG && _MSC_VER" too

- Addendum to 81eb3bbceb518c331f3d8e4754ad61adc0e94d33.
- Merge "_MSC_VER" and "!_MSC_VER" cases, to prevent such a mistake.

3 years ago[NTOSKRNL] Fix IopValidateID using uninitialized var, reset SeparatorsCount in the...
Mark Jansen [Thu, 5 Apr 2018 20:06:31 +0000 (22:06 +0200)]
[NTOSKRNL] Fix IopValidateID using uninitialized var, reset SeparatorsCount in the MultiSz case.

3 years ago[REACTOS] Fix 64 bit build (#465)
Timo Kreuzer [Tue, 3 Apr 2018 21:13:17 +0000 (15:13 -0600)]
[REACTOS] Fix 64 bit build (#465)

* [HAL] Simplify HalpReboot() and make it portable
* [NTOS:MM] Cast constant to PVOID
* [BINPATCH] Fix 64 bit build
* [VFDDRV] Fix 64 bit build and buffer overruns
* [USBOHCI] Fix structure alignment issues
* [ATL_APITEST] Fix 64 bit build
* [XDK] Update unwind structures in winnt.h
* [NTDLL_APITEST] Fix 64 bit build
* [NTDLL_WINETEST] Fix 64 bit build
* [TFTPD] Fix x64 build
* [USBPORT] Fix a C_ASSERT
* [DSOUND] Fix x64 build
* [HAL] Remove obsolete GetPteAddress() macro

3 years ago[MSGINA] Fix the SAS dialog
Eric Kohl [Tue, 3 Apr 2018 20:32:10 +0000 (22:32 +0200)]
[MSGINA] Fix the SAS dialog
- Make the "Press Crtl-Alt-Delete..." text control as wide as possible so that the text will fit in one line for all languages.
- Make the albaninan SAS dialog look like the SAS dialog for the other languages.

3 years ago[XINPUT1_3_WINETEST] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Tue, 3 Apr 2018 12:52:18 +0000 (13:52 +0100)]
[XINPUT1_3_WINETEST] Sync with Wine Staging 3.3. CORE-14434

3 years ago[WSCRIPT_WINETEST] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Tue, 3 Apr 2018 12:51:45 +0000 (13:51 +0100)]
[WSCRIPT_WINETEST] Sync with Wine Staging 3.3. CORE-14434

3 years ago[WS2_32_WINETEST] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Tue, 3 Apr 2018 12:51:13 +0000 (13:51 +0100)]
[WS2_32_WINETEST] Sync with Wine Staging 3.3. CORE-14434

3 years ago[WINMM_WINETEST] Sync with Wine Staging 3.3. CORE-14434
Amine Khaldi [Tue, 3 Apr 2018 12:50:40 +0000 (13:50 +0100)]
[WINMM_WINETEST] Sync with Wine Staging 3.3. CORE-14434

3 years ago[USER32_WINETEST] Sync everything except win.c with Wine Staging 3.3. CORE-14434
Amine Khaldi [Tue, 3 Apr 2018 12:49:56 +0000 (13:49 +0100)]
[USER32_WINETEST] Sync everything except win.c with Wine Staging 3.3. CORE-14434

3 years ago[PSDK] Add some missing WDA_NONE and WDA_MONITOR. CORE-14434
Amine Khaldi [Tue, 3 Apr 2018 12:48:43 +0000 (13:48 +0100)]
[PSDK] Add some missing WDA_NONE and WDA_MONITOR. CORE-14434