reactos.git
4 years ago[LOADCONFIG_APITEST] Tell GCC that the .def is not just included for fun,
Mark Jansen [Sat, 18 Apr 2020 13:18:19 +0000 (15:18 +0200)]
[LOADCONFIG_APITEST] Tell GCC that the .def is not just included for fun,
but that it should actually use it.

4 years ago[REGEDIT] Fix tree view popup menu issues
Eric Kohl [Sun, 19 Apr 2020 13:12:59 +0000 (15:12 +0200)]
[REGEDIT] Fix tree view popup menu issues

Move the tree view popup menu code from the childwindow to the framewindow.

CORE-16887

4 years ago[KDGDB] Allow kdgdb to continue when hit by a first-chance exception.
Sylvain Deverre [Sun, 19 Apr 2020 12:20:58 +0000 (14:20 +0200)]
[KDGDB] Allow kdgdb to continue when hit by a first-chance exception.

When gdb receives a fault, it converts it to "signal", and send "C"
command to server to transfer the signal it couldn't handle.

On ReactOS (and Windows ?) side, we tell KD API that we continue with an
error code, so the exception handler can be called.

This is useful when playing with gflags, especially +soe, with KDGDB.

4 years ago[CMAKE] Fix SEPARATE_DBG build on GCC
Sylvain Deverre [Sun, 19 Apr 2020 10:59:54 +0000 (12:59 +0200)]
[CMAKE] Fix SEPARATE_DBG build on GCC

4 years ago[NETSHELL] CORE-16903 RC Overhaul all languages
Joachim Henze [Sun, 19 Apr 2020 00:58:59 +0000 (02:58 +0200)]
[NETSHELL] CORE-16903 RC Overhaul all languages

DD_LAN_NETSTATUS & IDD_LAN_NETSTATUSADVANCED

Reason for the change:
-dlgs sizes did differ (between langs and also within same lang)
-groupboxes sizes did differ (between langs and also within same lang)
-tabbing through both dlgs looked poorly therefore in almost all langs
 (margin and groupbox jumping)
-in some languages we had truncation
-in some languages we had unintended scaling for the icon
-after the change all controls and dlgs have the exact same size for all languages,
I managed to achieve the common detominator for
everything that looks good in all languages and guarantees to not introduce any truncation

Only exception is the icons horizontal position which may require individual tweaking!

4 years ago[TRANSLATION] New Portuguese translation (#2588)
Jose Carlos Jesus [Sat, 18 Apr 2020 21:49:35 +0000 (22:49 +0100)]
[TRANSLATION] New Portuguese translation (#2588)

* [TRANSLATION] New PT translation to inetcpl

* [TRANSLATION] Fix SUBLANG in file cpl/joy/lang/pt-PT.rc to SUBLAG_NEUTRAL

* [TRANSLATION] New PT translation to cpl/mmsys/lang/pt-PT.rc

* [TRANSLATION] Fix SUBLANG in cryptui_Pt.rc file

4 years ago[COMDLG32] Polish translation dialog layout fix (#2570)
Piotr Hetnarowicz [Sat, 18 Apr 2020 17:21:15 +0000 (19:21 +0200)]
[COMDLG32] Polish translation dialog layout fix (#2570)

4 years ago[OLEACC] Polish translation update (#2569)
Piotr Hetnarowicz [Sat, 18 Apr 2020 17:20:45 +0000 (19:20 +0200)]
[OLEACC] Polish translation update (#2569)

4 years ago[OLEDLG] Polish translation dialog fix (#2568)
Piotr Hetnarowicz [Sat, 18 Apr 2020 17:20:29 +0000 (19:20 +0200)]
[OLEDLG] Polish translation dialog fix (#2568)

4 years ago[TIMEDATE] Polish translation update (#2567)
Piotr Hetnarowicz [Sat, 18 Apr 2020 17:19:52 +0000 (19:19 +0200)]
[TIMEDATE] Polish translation update (#2567)

4 years ago[TASKKILL] Polish translation update (#2566)
Piotr Hetnarowicz [Sat, 18 Apr 2020 17:19:31 +0000 (19:19 +0200)]
[TASKKILL] Polish translation update (#2566)

4 years ago[SERVMAN] CORE-16879 fr-FR Update
Joachim Henze [Sat, 18 Apr 2020 14:38:59 +0000 (16:38 +0200)]
[SERVMAN] CORE-16879 fr-FR Update

Avoid text truncation and realign controls.

4 years ago[SERVMAN] CORE-16879 RC en-US & de-DE Pixel Tweaking
Joachim Henze [Sat, 18 Apr 2020 13:34:04 +0000 (15:34 +0200)]
[SERVMAN] CORE-16879 RC en-US & de-DE Pixel Tweaking

The left x-margin was inconsistent within 'General'-tab
and tabbing through multiple tabs looked unprofessional
because 'General'-tab had much smaller left-margin.

4 years ago[SERVMAN] RC Update All languages
Joachim Henze [Sat, 18 Apr 2020 12:14:55 +0000 (14:14 +0200)]
[SERVMAN] RC Update All languages

Align a treeviews horizontal and vertical size
to exactly fit its neighbor treeview in last
tab 'Dependencies'.
Slightly related to CORE-16879.

4 years ago[INETCPL][SERVMAN] French translation update (#2572)
Kyle Katarn [Sat, 18 Apr 2020 11:21:37 +0000 (13:21 +0200)]
[INETCPL][SERVMAN] French translation update (#2572)

CORE-16900

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
4 years ago [INETCPL] French translation update #2571
Kyle Katarn [Sat, 18 Apr 2020 10:16:58 +0000 (12:16 +0200)]
 [INETCPL] French translation update #2571

CORE-16900

4 years ago[NOTEPAD] Fix missing french 'About notepad' menu item translation
Eric Kohl [Sat, 18 Apr 2020 09:28:42 +0000 (11:28 +0200)]
[NOTEPAD] Fix missing french 'About notepad' menu item translation

CORE-16886

4 years ago[REGEIT] Fix inconsistent menu state for 'Permissions'
Eric Kohl [Sat, 18 Apr 2020 07:59:41 +0000 (09:59 +0200)]
[REGEIT] Fix inconsistent menu state for 'Permissions'

- Disable the 'Permissions' item in the main menu, when 'My Computer' is selected.
- Enable the 'Permissions' item in the tree view context menu.

CORE-16889

4 years ago[REGEDIT] Add a special popup menu for the tree view root item
Eric Kohl [Sat, 18 Apr 2020 06:52:24 +0000 (08:52 +0200)]
[REGEDIT] Add a special popup menu for the tree view root item

CORE-16888

4 years ago[REGEDIT] CORE-16892 fr-FR Translation update
Joachim Henze [Fri, 17 Apr 2020 23:59:39 +0000 (01:59 +0200)]
[REGEDIT] CORE-16892 fr-FR Translation update

Fix 3 text truncations in search-dlg

4 years ago[NETID] CORE-16594 fr-FR Avoid text truncations
Joachim Henze [Fri, 17 Apr 2020 23:26:09 +0000 (01:26 +0200)]
[NETID] CORE-16594 fr-FR Avoid text truncations

4 years ago[MMSYS] CORE-16881 fr-FR "Save As" button too narrow
Joachim Henze [Fri, 17 Apr 2020 22:45:32 +0000 (00:45 +0200)]
[MMSYS] CORE-16881 fr-FR "Save As" button too narrow

4 years ago[FREELDR] Fix typos and PC-98 boot (#2564)
Dmitry Borisov [Fri, 17 Apr 2020 18:27:20 +0000 (00:27 +0600)]
[FREELDR] Fix typos and PC-98 boot (#2564)

- INT 18h, AH=A0h doesn't exist, it was meant to be AH=0Ah. Thanks to SimK (@simk98l) on twitter for bug reporting and fix.
- Adress -> Address.

4 years ago[RAPPS] Use _beginthreadex instead of CreateThread (#2552)
He Yang [Fri, 17 Apr 2020 17:27:16 +0000 (12:27 -0500)]
[RAPPS] Use _beginthreadex instead of CreateThread (#2552)

4 years ago[SDK][HOST-TOOLS] Add load_config workaround for gcc builds 2542/head
Mark Jansen [Mon, 13 Apr 2020 10:20:47 +0000 (12:20 +0200)]
[SDK][HOST-TOOLS] Add load_config workaround for gcc builds
Since binutils can not add this, we re-introduce pefixup.
It searches for the exported symbol '_load_config_used',
and uses that to fill out the LOAD_CONFIG directory in the PE header

4 years ago[DBGHELPHOST] Add IMAGE_DIRECTORY_ENTRY_LOAD_CONFIG
Mark Jansen [Mon, 13 Apr 2020 09:27:21 +0000 (11:27 +0200)]
[DBGHELPHOST] Add IMAGE_DIRECTORY_ENTRY_LOAD_CONFIG

4 years ago[LDR] Add initial LOAD_CONFIG support
Mark Jansen [Sun, 12 Apr 2020 14:24:28 +0000 (16:24 +0200)]
[LDR] Add initial LOAD_CONFIG support

4 years ago[LOADCONFIG_APITEST] Add apitest using the load config section
Mark Jansen [Sat, 11 Apr 2020 20:30:47 +0000 (22:30 +0200)]
[LOADCONFIG_APITEST] Add apitest using the load config section
For now, the only test is related to a user trace stack db.
The entire test application is disabled for gcc,
since it is unable to generate this load config info.
The stacktrace test is disabled until it is implemented.

4 years ago[APITEST][NTDLL] Implement RtlGetNtProductType testcase (#2489)
Bișoc George [Fri, 17 Apr 2020 10:47:09 +0000 (12:47 +0200)]
[APITEST][NTDLL] Implement RtlGetNtProductType testcase (#2489)

4 years ago[UTILMAN] Move most of the code in a library (#2530)
Bișoc George [Fri, 17 Apr 2020 10:42:47 +0000 (12:42 +0200)]
[UTILMAN] Move most of the code in a library (#2530)

Windows XP and Server 2003 Utility Manager has a dedicated library for the resources and other stuff. Utility Manager is just a simple process that loads it. Hence create a library for the program, UManDlg.dll, and move the resources and other stuff there.

In addition to that, use ExtractIconW to get the icon resource from the program (the DLL doesn't share icons by default) and remove the icon resource from the "About" dialog window. Also change the encoding type of other translation files to UTF-8 (which were previously set with UTF-8 with BOM).

4 years ago[COMCTL32] Implement a simple version of snap to grid for listview
Charles Ambrye [Wed, 15 Apr 2020 16:02:00 +0000 (09:02 -0700)]
[COMCTL32] Implement a simple version of snap to grid for listview

4 years ago[SHELL32] Pass LVA_SNAPTOGRID to listview when 'Line up Icons' is selected
Charles Ambrye [Wed, 15 Apr 2020 16:01:09 +0000 (09:01 -0700)]
[SHELL32] Pass LVA_SNAPTOGRID to listview when 'Line up Icons' is selected

4 years ago[COMCTL32] Do not allow user to move icons when in auto-arrange mode
Charles Ambrye [Wed, 15 Apr 2020 15:59:18 +0000 (08:59 -0700)]
[COMCTL32] Do not allow user to move icons when in auto-arrange mode

4 years ago[BROWSEUI] CORE-16810 de-DE Translation of "Search Results" titlebar
Joachim Henze [Fri, 17 Apr 2020 07:43:40 +0000 (09:43 +0200)]
[BROWSEUI] CORE-16810 de-DE Translation of "Search Results" titlebar

4 years ago[NETID] Update Polish translation (#2559)
Piotr Hetnarowicz [Thu, 16 Apr 2020 21:25:03 +0000 (23:25 +0200)]
[NETID] Update Polish translation (#2559)

Co-authored-by: Adam Słaboń <asaillen456esx@gmail.com>
4 years ago[SHUTDOWN] Update Polish translation (#2557)
Piotr Hetnarowicz [Thu, 16 Apr 2020 19:48:16 +0000 (21:48 +0200)]
[SHUTDOWN] Update Polish translation (#2557)

4 years ago[CHARMAP] Update Polish translation (#2555)
Piotr Hetnarowicz [Thu, 16 Apr 2020 19:47:51 +0000 (21:47 +0200)]
[CHARMAP] Update Polish translation (#2555)

4 years ago[DEVMGR] Polish translation update (#2554)
Piotr Hetnarowicz [Thu, 16 Apr 2020 17:25:01 +0000 (19:25 +0200)]
[DEVMGR] Polish translation update (#2554)

4 years ago[attrib] pl-pl lang update
Piotr Hetnarowicz [Thu, 16 Apr 2020 14:59:48 +0000 (16:59 +0200)]
[attrib] pl-pl lang update

4 years ago[cmd] pl-pl update
Piotr Hetnarowicz [Thu, 16 Apr 2020 15:46:15 +0000 (17:46 +0200)]
[cmd] pl-pl update

4 years ago[SYSSETUP] Update authors page in second stage setup
Stanislav Motylkov [Thu, 16 Apr 2020 15:46:31 +0000 (18:46 +0300)]
[SYSSETUP] Update authors page in second stage setup

Fix layout issues in different languages. CORE-16874

4 years ago[CMAKE] Replace custom functions to built-in ones
Victor Perevertkin [Thu, 16 Apr 2020 12:59:38 +0000 (15:59 +0300)]
[CMAKE] Replace custom functions to built-in ones
add_target_compile_definitions -> target_compile_definitions
add_target_compile_flags -> target_compile_options
add_target_include_directories -> target_include_directories

4 years ago[BROWSEUI] Fix build. Addendum to ac29d29.
Stanislav Motylkov [Thu, 16 Apr 2020 11:16:48 +0000 (14:16 +0300)]
[BROWSEUI] Fix build. Addendum to ac29d29.

CORE-16810

4 years ago[BROWSEUI] Localize "Search Results" shell folder name
Stanislav Motylkov [Thu, 16 Apr 2020 11:10:24 +0000 (14:10 +0300)]
[BROWSEUI] Localize "Search Results" shell folder name

Also update French and Russian translations. CORE-16810

4 years ago[SHELL32] Update Russian translation
Stanislav Motylkov [Thu, 16 Apr 2020 10:40:49 +0000 (13:40 +0300)]
[SHELL32] Update Russian translation

CORE-16873

4 years ago[SHELL32] Update Polish translation (#2364) 2364/head
Piotr Hetnarowicz [Thu, 20 Feb 2020 12:36:41 +0000 (13:36 +0100)]
[SHELL32] Update Polish translation (#2364)

4 years ago[WINLOGON] Update Polish translation (#2363) 2363/head
Piotr Hetnarowicz [Thu, 20 Feb 2020 09:03:14 +0000 (10:03 +0100)]
[WINLOGON] Update Polish translation (#2363)

4 years ago[MSGINA] Update Polish translation (#2362) 2362/head
Piotr Hetnarowicz [Thu, 20 Feb 2020 07:55:36 +0000 (08:55 +0100)]
[MSGINA] Update Polish translation (#2362)

Co-Authored-By: Adam Słaboń <asaillen456esx@gmail.com>
4 years ago[ZIPFLDR] Update Polish translation (#2351) 2351/head
Piotr Hetnarowicz [Sat, 15 Feb 2020 07:01:33 +0000 (08:01 +0100)]
[ZIPFLDR] Update Polish translation (#2351)

4 years ago[APPWIZ] Update Polish translation (#2337) 2337/head
Piotr Hetnarowicz [Wed, 12 Feb 2020 17:24:36 +0000 (18:24 +0100)]
[APPWIZ] Update Polish translation (#2337)

4 years ago[WALLPAPER] Rename Soft Blue to Mizu (#1945)
Foxlet [Wed, 15 Apr 2020 23:37:17 +0000 (19:37 -0400)]
[WALLPAPER] Rename Soft Blue to Mizu (#1945)

Cleanup of filenames to match the Mizu theme.

4 years ago[SFC][SFC_OS] Add stubs to exported functions (#2431)
Oleg Dubinskiy [Wed, 15 Apr 2020 23:06:22 +0000 (02:06 +0300)]
[SFC][SFC_OS] Add stubs to exported functions (#2431)

- Also remove extra whitespace between function names and their arguments in sfc.
- Required by userenv.dll, win32k.sys, and others from Windows Server 2003 and also by some MS installers like Windows Media Encoder 7.1 installer. Now they should not fail due to that functions.

CORE-16458

4 years ago[WINSTA] Add some missing stubs (#2307)
Oleg Dubinskiy [Wed, 15 Apr 2020 22:50:22 +0000 (01:50 +0300)]
[WINSTA] Add some missing stubs (#2307)

Add stubs for WinStationCanLogonProceed() and _WinStationOpenSessionDirectory() functions to make winlogon from Windows Server 2003 happy.

CORE-15392 CORE-16458

4 years ago[KSECDD] Improve GetSecurityUserInfo stub (#2438)
Doug Lyons [Wed, 15 Apr 2020 22:32:47 +0000 (17:32 -0500)]
[KSECDD] Improve GetSecurityUserInfo stub (#2438)

- Fix UNIMPLEMENTED_DBGBREAK seen using FileMon
- Add SAL2 Annotations and remove unneeded comments
- Return NULL pointer

CORE-15186

4 years ago[CHARMAP] Updates to behaviour and UI (#2543)
Charles Ambrye [Wed, 15 Apr 2020 21:31:16 +0000 (14:31 -0700)]
[CHARMAP] Updates to behaviour and UI (#2543)

Purpose
~=~=~=~

This pull request updates charmap to look a bit better (removes gap at bottom of the window), removes the blank space character (0x0020) from the charmap, and also modifies the behaviour of when a larger glyph is rendered (allowing the user to select a new glyph by holding down the mouse button). This better mimics the charmap.exe that is bundled by Microsoft.

Proposed changes
~=~=~=~=~=~=~=~=

- Remove gap where the advanced button is normally rendered when compiled with REMOVE_ADVANCED (which is the default behaviour).
- Skip over the blank space character.
- Change behaviour of rendering large glyphs to allow mouse move, and to hide on double click.
- Optimize search for glyph under the mouse by using the cellSize instead of PtInRect.

* [CHARMAP] Resize the window slightly when compiled with REMOVE_ADVANCED to avoid deadspace at the bottom of the window

* [CHARMAP] Skip over the non-printable characters by starting with character ' ' + 1

* [CHARMAP] Instead of iterating over every cell, simply compute the cell x and y using the CellSize

Modify behaviour of charmap to allow large character render on mouse move, only hiding the larger character on double click.

4 years ago[SHELL32][BROWSEUI] Update Russian translation
Stanislav Motylkov [Wed, 15 Apr 2020 21:10:12 +0000 (00:10 +0300)]
[SHELL32][BROWSEUI] Update Russian translation

Addendum to 033f0d9. CORE-16866

4 years ago[CSRSRV] Addendum to e3a70662: Fix build.
Hermès Bélusca-Maïto [Wed, 15 Apr 2020 13:53:47 +0000 (15:53 +0200)]
[CSRSRV] Addendum to e3a70662: Fix build.

Since indeeed the memcpy/move type of functions usually don't operate on
pointers to 'volatile' data, don't make ClientCaptureBuffer volatile.
Instead when retrieving the values of its 'Size' and 'PointerCount'
members (see the SEH block), use the so-called technique of "volatile
glasses" [1], where the pointer will be explicitly casted to "volatile TYPE*"
where needed.

[1]: https://docs.microsoft.com/archive/blogs/itgoestoeleven/why-your-user-mode-pointer-captures-are-probably-broken

4 years ago[SHELL32] CORE-12294 File & folder properties dialog fr-FR & de-DE resource
Joachim Henze [Wed, 15 Apr 2020 12:45:48 +0000 (14:45 +0200)]
[SHELL32] CORE-12294 File & folder properties dialog fr-FR & de-DE resource

Avoids text truncation for french
Improves checkboxes alignment for german

4 years ago[CSRSRV] CsrCaptureArguments(): Tell the compiler the contents ClientCaptureBuffer...
Hermès Bélusca-Maïto [Wed, 15 Apr 2020 12:07:25 +0000 (14:07 +0200)]
[CSRSRV] CsrCaptureArguments(): Tell the compiler the contents ClientCaptureBuffer points to has a volatile character.

See https://docs.microsoft.com/fr-fr/archive/blogs/itgoestoeleven/why-your-user-mode-pointer-captures-are-probably-broken
for more details.

Since the contents of ClientCaptureBuffer is in the shared memory, the
client could modify it while it is being probed and captured, and so we
have to avoid any potential compiler optimizations regarding the
captured "Length = ClientCaptureBuffer->Size" and
"PointerCount = ClientCaptureBuffer->PointerCount" values.

4 years ago[TRANSLATION] Spanish minor fixes (#2547)
Julen Urizar Compains [Wed, 15 Apr 2020 11:27:36 +0000 (13:27 +0200)]
[TRANSLATION] Spanish minor fixes (#2547)

Translations for:
- Applications: clipbrd, dxdiag, rapps,
- cmdutils: attrib, find, help, label, reg, xcopy
- usetup
- dlls: browseui, shell32, syssetup

- Add Spanish translation for Accesibility Utility (utilman).

Update for the "Choose product options" strings in syssetup:

Originally "ProductType" and "ProductSuite" (typesetted without spaces) were the registry value names where these settings would go, but since it's meaningless to show these values it's better instead to use human-readable names with correct translation and spacing.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
4 years ago[IPHLPAPI] GetAdaptersAddresses(): Add 1 free() in ERROR_NO_DATA case (#2526)
Serge Gautherie [Wed, 15 Apr 2020 11:05:54 +0000 (13:05 +0200)]
[IPHLPAPI] GetAdaptersAddresses(): Add 1 free() in ERROR_NO_DATA case (#2526)

And fix 4 comments.
Follow-up to 68d94581.

4 years ago[SYSSETUP] Added a flag for mandatory password (#2500)
Erkin Alp Güney [Wed, 15 Apr 2020 10:50:36 +0000 (13:50 +0300)]
[SYSSETUP] Added a flag for mandatory password (#2500)

Use a human-readable #define flag 'PASSWORDS_MANDATORY' instead of the #if 0.
See also CORE-8038.

4 years ago[README.WINE] Fix 'User32' typo and add winetests/winmm. CORE-16441 (#2525)
Serge Gautherie [Wed, 15 Apr 2020 10:48:54 +0000 (12:48 +0200)]
[README.WINE] Fix 'User32' typo and add winetests/winmm. CORE-16441 (#2525)

CORE-16441

4 years ago[SDK][PSDK] Add a version check for DiskGeometryGetPartition and DiskGeometryGetDetec...
Bișoc George [Wed, 15 Apr 2020 10:47:01 +0000 (12:47 +0200)]
[SDK][PSDK] Add a version check for DiskGeometryGetPartition and DiskGeometryGetDetect and add a missing member to PARTITION_INFORMATION_EX structure (#2541)

DiskGeometryGetPartition() and DiskGeometryGetDetect() are guarded in NTDDI_VERSION for version checking as they differ between Windows XP and Server 2003. In conjunction to that, the PARTITION_INFORMATION_EX structure has "IsServicePartition" as member which is missing in the current NT IOCTL Disk interface header.

4 years ago[ZIPFLDR] Fix FriendlyTypeName registry value (#2548)
Stanislav Motylkov [Tue, 14 Apr 2020 15:20:18 +0000 (18:20 +0300)]
[ZIPFLDR] Fix FriendlyTypeName registry value (#2548)

It should be a value inside CompressedFolder key, not a subkey.

4 years ago[ZIPFLDR] Add Russian translation (#2548)
Stanislav Motylkov [Tue, 14 Apr 2020 15:12:48 +0000 (18:12 +0300)]
[ZIPFLDR] Add Russian translation (#2548)

4 years ago[SHELL32] Add Russian translation (#2548)
Stanislav Motylkov [Tue, 14 Apr 2020 15:12:30 +0000 (18:12 +0300)]
[SHELL32] Add Russian translation (#2548)

CORE-16866

4 years ago[THEMES][LUNAR] Add bitmaps for quick launch toolbar (#2549)
Adam Słaboń [Wed, 15 Apr 2020 10:37:54 +0000 (12:37 +0200)]
[THEMES][LUNAR] Add bitmaps for quick launch toolbar (#2549)

4 years ago[FREELDR][INSTALL][FDEBUG] Include FreeLDR tools in LiveCD and HybridCD (#2550)
Adam Słaboń [Wed, 15 Apr 2020 10:37:21 +0000 (12:37 +0200)]
[FREELDR][INSTALL][FDEBUG] Include FreeLDR tools in LiveCD and HybridCD (#2550)

It might be useful to have them on LiveCD/HybridCD as well.

4 years ago[CSRSRV] Improve validation of CSR API Message's capture buffers.
Hermès Bélusca-Maïto [Tue, 14 Apr 2020 23:58:08 +0000 (01:58 +0200)]
[CSRSRV] Improve validation of CSR API Message's capture buffers.

- Improve capture buffer validation in CsrCaptureArguments(), by
  implementing the checks done by Windows 2003 (NT 5.2) described
  in section "Server-Side Validation and Capture" of the article
  https://www.geoffchappell.com/studies/windows/win32/csrsrv/api/apireqst/capture_header.htm

- In CsrReleaseCapturedArguments(), protect the data copy back into
  the client buffer within a SEH block.

4 years ago[CSRSRV] CsrCaptureArguments() and CsrReleaseCapturedArguments(): Use better names...
Hermès Bélusca-Maïto [Tue, 14 Apr 2020 21:07:42 +0000 (23:07 +0200)]
[CSRSRV] CsrCaptureArguments() and CsrReleaseCapturedArguments(): Use better names for the capture buffers.

Rename inaccurate names 'LocalCaptureBuffer' and 'RemoteCaptureBuffer'
into 'ClientCaptureBuffer' and 'ServerCaptureBuffer' respectively.
(Recall: CSRSRV is the 'Server', and any app doing LPC calls to it is
the 'Client'.)

4 years ago[CSRSRV] Protect the Server DLL entrypoint calls under SEH.
Hermès Bélusca-Maïto [Tue, 14 Apr 2020 20:58:22 +0000 (22:58 +0200)]
[CSRSRV] Protect the Server DLL entrypoint calls under SEH.

4 years ago[CSRSRV] Only when CSRSRV is compiled in debugging mode, should we display debugging...
Hermès Bélusca-Maïto [Tue, 14 Apr 2020 20:53:49 +0000 (22:53 +0200)]
[CSRSRV] Only when CSRSRV is compiled in debugging mode, should we display debugging messages and support debug breakpoints.

Also, trigger the less fatal breakpoints only if CSRSS/CSRSRV is being
debugged (the 'BeingDebugged' flag is set in the current PEB). This will
avoid any unhandled breakpoint exceptions when testing/fuzzing running
debug builds of ReactOS without any debugger attached.

4 years ago[CSRSRV] s/LPWSTR/PWSTR/ as the former is not NT type.
Hermès Bélusca-Maïto [Tue, 14 Apr 2020 20:38:51 +0000 (22:38 +0200)]
[CSRSRV] s/LPWSTR/PWSTR/ as the former is not NT type.

4 years ago[SYSDM.CPL] fr-FR Resize & Reposition 3 buttons CORE-16595
Joachim Henze [Mon, 13 Apr 2020 23:34:34 +0000 (01:34 +0200)]
[SYSDM.CPL] fr-FR Resize & Reposition 3 buttons CORE-16595

to avoid text truncation of the button
"Environment Variables"

4 years ago[CONSRV] Move process-initialization-specific functions from handle.c into console.c .
Hermès Bélusca-Maïto [Mon, 13 Apr 2020 21:24:55 +0000 (23:24 +0200)]
[CONSRV] Move process-initialization-specific functions from handle.c into console.c .

- Move ConSrvInitHandlesTable() & rename it ConSrvInitProcessHandles()
  since its purpose is to initialize the standard input, output and
  error handles for a console process.

- Move ConSrvAllocateConsole(), ConSrvInheritConsole() and
  ConSrvRemoveConsole().

4 years ago[DXDIAG] fr-FR Translation Addendum CORE-12477 part 3/3
Joachim Henze [Mon, 13 Apr 2020 22:42:33 +0000 (00:42 +0200)]
[DXDIAG] fr-FR Translation Addendum CORE-12477 part 3/3

Leave english strings untouched regarding space before colon.
Thanks to HBelusca for review as well.
I hope next one translating these will take care still.

4 years ago[DXDIAG] fr-FR Translation Addendum CORE-12477
Joachim Henze [Mon, 13 Apr 2020 22:06:48 +0000 (00:06 +0200)]
[DXDIAG] fr-FR Translation Addendum CORE-12477

Addendum to 0.4.14-dev-1405-g
dcc6dcb0bd6cb076fabe6fe0a45f9556eed1b379

Readd all spaces before the colons that I removed,
as that is a french speciality and was correct,
and also add some more of those that were missing even
before my commit (was inconsistent).

Thanks to Serge Gautherie, Thomas Faber and hpoussin
for the review.

4 years ago[MSPAINT] fr-FR Translate some menu items CORE-12357
Joachim Henze [Mon, 13 Apr 2020 21:27:52 +0000 (23:27 +0200)]
[MSPAINT] fr-FR Translate some menu items CORE-12357

4 years ago[MSCTF_WINETEST] Skip crashing test when it fails
Mark Jansen [Mon, 13 Apr 2020 20:44:56 +0000 (22:44 +0200)]
[MSCTF_WINETEST] Skip crashing test when it fails
CORE-16797

4 years ago[DXDIAG] Less text truncation for all languages
Joachim Henze [Mon, 13 Apr 2020 20:43:37 +0000 (22:43 +0200)]
[DXDIAG] Less text truncation for all languages

Manually Tweaked fr-FR the most, see CORE-12477
Manually Tweaked de-DE enlarged a buttons size
For All Languages harmonized " :"->":"

For All Languages harmonized the maximized available space
for dynamic strings in 2nd tab right side from 100->120

4 years ago[WINDOWSCODECS] Avoid buffer underflow in TiffFrameDecode_ReadTile. CORE-16796
Thomas Faber [Mon, 13 Apr 2020 15:55:00 +0000 (17:55 +0200)]
[WINDOWSCODECS] Avoid buffer underflow in TiffFrameDecode_ReadTile. CORE-16796

4 years agoFix build.
Hermès Bélusca-Maïto [Mon, 13 Apr 2020 16:10:54 +0000 (18:10 +0200)]
Fix build.

4 years ago[CONSRV] Convenience fixes.
Hermès Bélusca-Maïto [Sun, 12 Apr 2020 17:03:30 +0000 (19:03 +0200)]
[CONSRV] Convenience fixes.

- Simplify screen-buffers initialization.
- Get rid of this CONSOLE_SCREEN_BUFFER_VTBL virtual table.
- Move ConsoleInput to a proper header.

4 years ago[SHELL32] No french translation from "right click drag'n'drop"
Eric Kohl [Mon, 13 Apr 2020 13:41:13 +0000 (15:41 +0200)]
[SHELL32] No french translation from "right click drag'n'drop"

CORE-16815

4 years ago[SHELL32] Fix missing french translation for "Command prompt here"
Eric Kohl [Mon, 13 Apr 2020 13:27:47 +0000 (15:27 +0200)]
[SHELL32] Fix missing french translation for "Command prompt here"

CORE-16855

4 years ago[DEVMGR] Do not add the 'Resources' page to the device properties if the device does...
Eric Kohl [Mon, 13 Apr 2020 10:33:58 +0000 (12:33 +0200)]
[DEVMGR] Do not add the 'Resources' page to the device properties if the device does not have any resources

4 years ago[IPCONFIG] Improvements to ipconfig
Eric Kohl [Mon, 13 Apr 2020 09:25:09 +0000 (11:25 +0200)]
[IPCONFIG] Improvements to ipconfig

- Simplify the cleanup-code in ShowInfo
- Print the 'Primary DNS suffix' and the 'DNS Suffix Search List'
- Move the /registerdns message into its own function

4 years ago[SHELL32] Follow-up No.3 of #2539
Katayama Hirofumi MZ [Mon, 13 Apr 2020 04:19:12 +0000 (13:19 +0900)]
[SHELL32] Follow-up No.3 of #2539

Improve a comment in CreateNotificationParamAndSend.
CORE-13950

4 years ago[SHELL32] Follow-up No.2 of #2539
Katayama Hirofumi MZ [Mon, 13 Apr 2020 04:06:15 +0000 (13:06 +0900)]
[SHELL32] Follow-up No.2 of #2539

Improve tracing message in CChangeNotifyBroker::BrokerNotification.
CORE-13950

4 years ago[SHELL32] Follow-up of #2539
Katayama Hirofumi MZ [Mon, 13 Apr 2020 01:41:26 +0000 (10:41 +0900)]
[SHELL32] Follow-up of #2539

Improve comment. CORE-13950

4 years ago[SHELL32] Shell notify rework for simplicity and readability (#2539)
Katayama Hirofumi MZ [Mon, 13 Apr 2020 01:36:24 +0000 (10:36 +0900)]
[SHELL32] Shell notify rework for simplicity and readability (#2539)

Shell change notification has been implemented in #2432. But as @yagoulas said, source code structure is in mess. We improved simplicity and human readability of our source code.
- Move wine/changenotify.c code into changenotify.c and shelldesktop/CChangeNotify.cpp.
- Simplify code and rename the identifiers and add many comments. CORE-13950

4 years ago[WINMM] Fix crashing winetest
Mark Jansen [Sun, 12 Apr 2020 23:41:02 +0000 (01:41 +0200)]
[WINMM] Fix crashing winetest
CORE-16795
CORE-16806

4 years ago[BOOTDATA] Add FsType into default unattend.inf template
Victor Perevertkin [Sun, 12 Apr 2020 14:23:17 +0000 (17:23 +0300)]
[BOOTDATA] Add FsType into default unattend.inf template

4 years ago[CONSRV] Introduce a set of macros CON_API / CON_API_NOCONSOLE for wrapping around...
Hermès Bélusca-Maïto [Sun, 12 Apr 2020 10:45:31 +0000 (12:45 +0200)]
[CONSRV] Introduce a set of macros CON_API / CON_API_NOCONSOLE for wrapping around the repetitive prologue/epilogue of every console CSR API entrypoint.

All the per-API message structure unpacking and console validation done
with ConSrvGetConsole() is now automatically generated using the macros,
so that the actual implementation of each API can be done independently
of how the console object is obtained.

This could also allow reusing these API implementations with a different
mechanism for obtaining the console without changing anything in them.

4 years ago[TRAVIS] Fix inconsistent git clone depth in CI
Saibamen [Sun, 12 Apr 2020 13:36:07 +0000 (15:36 +0200)]
[TRAVIS] Fix inconsistent git clone depth in CI

4 years ago[PSDK] fix typedef PLSA_AP_CALL_PACKAGE_PASSTHROUGH (ntsecpkg.h)
Andreas Maier [Sat, 11 Apr 2020 21:05:37 +0000 (23:05 +0200)]
[PSDK] fix typedef PLSA_AP_CALL_PACKAGE_PASSTHROUGH (ntsecpkg.h)

4 years ago[TIMEDATE] Pervent running multiple NTP updates at once
Eric Kohl [Sun, 12 Apr 2020 11:11:33 +0000 (13:11 +0200)]
[TIMEDATE] Pervent running multiple NTP updates at once

- Run the NTP uptate from a separate thread
- Do not accept another update until the current one has finished

CORE-16835

4 years ago[User32] Return Default Window Procedure for WM_DEVICECHANGE
James Tabor [Sat, 11 Apr 2020 22:58:38 +0000 (17:58 -0500)]
[User32] Return Default Window Procedure for WM_DEVICECHANGE

See CORE-16492.

4 years ago[User32] Implement Device Event Message handler
James Tabor [Sat, 11 Apr 2020 22:41:26 +0000 (17:41 -0500)]
[User32] Implement Device Event Message handler

Need a way to send WM_DEVICECHANGE from the Service manager application.
Next step is to process it in the Client/Server Run-time Subsystem.
See CORE-16492.