reactos.git
4 years ago[NTOSKRNL]
Pierre Schweitzer [Thu, 26 May 2016 11:50:42 +0000 (11:50 +0000)]
[NTOSKRNL]
On CcInitializeCacheMap() call, keep track of the PinAccess value so that we can later check it on pinning.
It shouldn't be set to FALSE when the user attempts to perform pinning

CORE-11310

svn path=/trunk/; revision=71404

4 years ago[USER32]: Remove a leftover from r59868.
Hermès Bélusca-Maïto [Thu, 26 May 2016 00:53:54 +0000 (00:53 +0000)]
[USER32]: Remove a leftover from r59868.

svn path=/trunk/; revision=71403

4 years ago[KERNEL32]: Indentation fix only.
Hermès Bélusca-Maïto [Wed, 25 May 2016 20:49:40 +0000 (20:49 +0000)]
[KERNEL32]: Indentation fix only.

svn path=/trunk/; revision=71402

4 years ago[APPHELP_APITEST] Remove some code duplication.
Mark Jansen [Wed, 25 May 2016 17:22:47 +0000 (17:22 +0000)]
[APPHELP_APITEST] Remove some code duplication.

svn path=/trunk/; revision=71400

4 years ago[KERNEL32]
David Quintana [Wed, 25 May 2016 14:47:02 +0000 (14:47 +0000)]
[KERNEL32]
* Return TRUE from SetThreadStackGuarantee. Allows .NET 2.0 setup to complete and consequently allows some .net apps to work in ReactOS. Patch by the self-proclaimed Master of The Universe, Samuel Serapión.

svn path=/trunk/; revision=71399

4 years ago[NTOS:EX]
Thomas Faber [Wed, 25 May 2016 10:27:17 +0000 (10:27 +0000)]
[NTOS:EX]
- Use the calling thread instead of the passed-in thread to validate APC status in ExReleaseResourceForThreadLite. The latter can be user-set and might not be a KTHREAD at all.
CORE-11315 #resolve

svn path=/trunk/; revision=71398

4 years ago[NTDLL]
Hermès Bélusca-Maïto [Tue, 24 May 2016 19:57:29 +0000 (19:57 +0000)]
[NTDLL]
Add exports for RtlOemStringToUnicodeSize, RtlUnicodeStringToAnsiSize and RtlUnicodeStringToOemSize as redirections to suitable Rtlx*** functions, as done in our ntoskrnl (and as on Windows either).
This should fix MSYS2 start on ReactOS.
CORE-10459 #comment Please retest!

svn path=/trunk/; revision=71397

4 years ago[CRT] Partially sync strtoi64 with Wine Staging 1.9.9. Patch by Samuel Serapión CORE...
Mark Jansen [Tue, 24 May 2016 19:27:57 +0000 (19:27 +0000)]
[CRT] Partially sync strtoi64 with Wine Staging 1.9.9. Patch by Samuel Serapión CORE-11174 #resolve #comment Thanks!

svn path=/trunk/; revision=71396

4 years ago[KMTESTS]
Pierre Schweitzer [Tue, 24 May 2016 08:13:17 +0000 (08:13 +0000)]
[KMTESTS]
Add test for ExSetResourceOwnerPointer() and ExReleaseResourceForThreadLite()

CORE-11310

svn path=/trunk/; revision=71395

4 years ago[SERVICES]
Eric Kohl [Mon, 23 May 2016 21:48:32 +0000 (21:48 +0000)]
[SERVICES]
- RChangeServiceConfigA/W: Modify or delete password secrets.
[ADVAPI32]
- ChangeServiceConfigA, CreateServiceA: Convert passwords to Unicode before passing them to the remote functions.

svn path=/trunk/; revision=71394

4 years ago[NTOSKRNL]
Pierre Schweitzer [Mon, 23 May 2016 21:14:49 +0000 (21:14 +0000)]
[NTOSKRNL]
Fix misleading comment

svn path=/trunk/; revision=71393

4 years ago[NTOSKRNL]
Pierre Schweitzer [Mon, 23 May 2016 19:47:39 +0000 (19:47 +0000)]
[NTOSKRNL]
In Cc, replace the Vacb mutex by a Bcb resource.
Note that the resource is still placed in the Vacb by it belongs to the Bcb.
This is required to really implement CcSetBcbOwnerPointer().

CORE-11310

svn path=/trunk/; revision=71387

4 years ago[SERVICES]
Eric Kohl [Mon, 23 May 2016 15:02:37 +0000 (15:02 +0000)]
[SERVICES]
RCreateServiceW: Store a given password as a secret.

svn path=/trunk/; revision=71386

4 years ago[ADVAPI32]
Eric Kohl [Mon, 23 May 2016 13:53:24 +0000 (13:53 +0000)]
[ADVAPI32]
Implement LogonUserEx[A/W].

svn path=/trunk/; revision=71385

4 years ago[ADVAPI32]: Implement all the Elf*** event log APIs as wrappers around the correspond...
Hermès Bélusca-Maïto [Mon, 23 May 2016 02:03:49 +0000 (02:03 +0000)]
[ADVAPI32]: Implement all the Elf*** event log APIs as wrappers around the corresponding RPC calls, and the Win32 APIs just become calls to the Elf*** APIs.

svn path=/trunk/; revision=71384

4 years ago[IDL]: Whitespace fixes only.
Hermès Bélusca-Maïto [Sun, 22 May 2016 22:20:25 +0000 (22:20 +0000)]
[IDL]: Whitespace fixes only.

svn path=/trunk/; revision=71383

4 years ago[RTL]
Thomas Faber [Sun, 22 May 2016 22:11:54 +0000 (22:11 +0000)]
[RTL]
- Return the ACE pointer from RtlFirstFreeAce also if it is at the end of the ACL buffer.
CORE-11304 #resolve

svn path=/trunk/; revision=71382

4 years ago[APPHELP][APPHELP_APITEST] Add more db tests and implement SdbGetDatabaseVersion...
Mark Jansen [Sun, 22 May 2016 20:39:41 +0000 (20:39 +0000)]
[APPHELP][APPHELP_APITEST] Add more db tests and implement SdbGetDatabaseVersion. CORE-10367

svn path=/trunk/; revision=71381

4 years ago[APPHELP][APPHELP_APITEST] Implement most of sdbread and sdbwrite, mainly the work...
Mark Jansen [Sun, 22 May 2016 20:27:02 +0000 (20:27 +0000)]
[APPHELP][APPHELP_APITEST] Implement most of sdbread and sdbwrite, mainly the work of Mislav Blaževic, with some small additions from me. CORE-10367

svn path=/trunk/; revision=71380

4 years ago[SETUPAPI]
Thomas Faber [Sun, 22 May 2016 19:09:49 +0000 (19:09 +0000)]
[SETUPAPI]
- Fix Buffer overflow in FixupServiceBinaryPath

svn path=/trunk/; revision=71379

4 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 22 May 2016 19:00:55 +0000 (19:00 +0000)]
[EVENTVWR]
- Fix the flags used in LoadLibraryEx calls for loading DLLs as resource files.
- Use a nice flag (FORMAT_MESSAGE_MAX_WIDTH_MASK) in FormatMessage calls so that no useless extra newlines are appended to the message strings that are recovered.
  This is especially useful when some strings as localized event log names are retrieved to be displayed in the menu (amongst other things)...
  This fixes CORE-8915 and fixes also the presentation of some event descriptions.
- Fix BuildLogList.

svn path=/trunk/; revision=71378

4 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 22 May 2016 17:17:33 +0000 (17:17 +0000)]
[EVENTVWR]
- Set window parent for different MessageBox calls.
- Add a notice in ShowStatusMessageThread concerning a potential bug.
- Rename strings "Save Protocol" into "Save Event Log"; adjust translations in this regard.

svn path=/trunk/; revision=71377

4 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 22 May 2016 16:19:55 +0000 (16:19 +0000)]
[EVENTVWR]
- Fix a typo in the "loading, wait" dialog.
- Use a RichEdit control for the detailed event description text, so that we can have for free clickable URLs.
- Use "Courier New" as the font for the event data text, so that we can have finer grained control over the font size...

svn path=/trunk/; revision=71376

4 years ago[PSDK]
Pierre Schweitzer [Sun, 22 May 2016 13:22:52 +0000 (13:22 +0000)]
[PSDK]
Define STATUS_FILE_LOCKED_WITH_ONLY_READERS and STATUS_FILE_LOCKED_WITH_WRITERS

CORE-11295

svn path=/trunk/; revision=71375

4 years ago[EVENTVWR]
Eric Kohl [Sun, 22 May 2016 12:15:30 +0000 (12:15 +0000)]
[EVENTVWR]
Display event data properly.

svn path=/trunk/; revision=71374

4 years ago[SCHANNEL]
Thomas Faber [Sun, 22 May 2016 10:56:22 +0000 (10:56 +0000)]
[SCHANNEL]
- Set received length to zero when the receive result is MBEDTLS_ERR_SSL_PEER_CLOSE_NOTIFY instead of pretending we got data
CORE-11285 #resolve

svn path=/trunk/; revision=71373

4 years ago[SCHANNEL]
Thomas Faber [Sun, 22 May 2016 10:53:23 +0000 (10:53 +0000)]
[SCHANNEL]
- Correctly check for ROS_SCHAN_IS_BLOCKING
CORE-11285

svn path=/trunk/; revision=71372

4 years ago[UNIATA]
Thomas Faber [Sun, 22 May 2016 10:25:24 +0000 (10:25 +0000)]
[UNIATA]
- When handling CD READ_CAPACITY requests in AtapiInterrupt__, fully rewind the DataBuffer instead of relying on the last read length. Fixes crash on first stage boot in KVM.
CORE-11286 #resolve
CORE-11296

svn path=/trunk/; revision=71371

4 years ago[VFATLIB]
Pierre Schweitzer [Sun, 22 May 2016 07:56:45 +0000 (07:56 +0000)]
[VFATLIB]
Update the amount of FAT entries taking into account that the first two are reserved and thus not usable.

Patch by Wim Hueskes

CORE-11283 #resolve #comment Committed in r71370, thanks for your patch!

svn path=/trunk/; revision=71370

4 years ago[SYSSETUP]
Pierre Schweitzer [Sun, 22 May 2016 07:56:23 +0000 (07:56 +0000)]
[SYSSETUP]
Update acknowledgements regarding imported FSDs in ReactOS.

Thanks Matt Wu and Mark Harmstone for your great work!

svn path=/trunk/; revision=71369

4 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 22 May 2016 00:34:40 +0000 (00:34 +0000)]
[EVENTVWR]
- Fix the window styles of the edit boxes in the event details dialog.
- Refactor some parts of the code to reduce the level of code indentation.
- Replace malloc/free by their Win32 counterparts HeapAlloc/HeapFree.
- When caching the full contents of a given event log, don't load at this point the event text/data. Only load those when opening the event details dialog.

svn path=/trunk/; revision=71368

4 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sat, 21 May 2016 21:44:14 +0000 (21:44 +0000)]
[EVENTVWR]
- Finish to convert the app to full unicode;
- Don't hardcode buffer lengths in function calls;
- Remove useless #pragma incantation;
- Whitespace fix.

svn path=/trunk/; revision=71367

4 years ago[FREELDR]: Increase again the number of BIOS memory descriptors to 80.
Hermès Bélusca-Maïto [Sat, 21 May 2016 16:12:31 +0000 (16:12 +0000)]
[FREELDR]: Increase again the number of BIOS memory descriptors to 80.
CORE-11247 #comment Please retest.

svn path=/trunk/; revision=71366

4 years ago[SAMSRV]
Eric Kohl [Sat, 21 May 2016 15:05:49 +0000 (15:05 +0000)]
[SAMSRV]
Implement SamrGetDomainPasswordInformation.

svn path=/trunk/; revision=71365

4 years ago[SAMSRV]
Eric Kohl [Sat, 21 May 2016 13:12:53 +0000 (13:12 +0000)]
[SAMSRV]
Add LM_OWF_PASSWORD and NT_OWF_PASSWORD types and use them.
See MS-NRPC sections 2.2.1.1.1 to 2.2.1.1.4.

svn path=/trunk/; revision=71364

4 years ago[NETSHELL]
Pierre Schweitzer [Sat, 21 May 2016 09:40:18 +0000 (09:40 +0000)]
[NETSHELL]
Update French translation

CORE-10955

svn path=/trunk/; revision=71363

4 years ago[MBEDTLS][SCHANNEL] Export mbedtls_ssl_config_free and use it. Patch by Peter Hater...
Mark Jansen [Fri, 20 May 2016 17:09:56 +0000 (17:09 +0000)]
[MBEDTLS][SCHANNEL] Export mbedtls_ssl_config_free and use it. Patch by Peter Hater. CORE-11270 #resolve #comment Thanks!

svn path=/trunk/; revision=71362

4 years ago[SDK][CMAKE] The CMake folder is part of our SDK. CORE-9111
Amine Khaldi [Fri, 20 May 2016 16:06:48 +0000 (16:06 +0000)]
[SDK][CMAKE] The CMake folder is part of our SDK. CORE-9111

svn path=/trunk/; revision=71361

4 years ago[TASKMGR] improvement german: too long string in statusbar - Patch by Joachim Henze.
Robert Naumann [Thu, 19 May 2016 22:41:08 +0000 (22:41 +0000)]
[TASKMGR] improvement german: too long string in statusbar - Patch by Joachim Henze.

svn path=/trunk/; revision=71360

4 years ago[SDK/INCLUDE]: Fix a typo in ntstatus.mc (Debuger --> Debugger).
Hermès Bélusca-Maïto [Thu, 19 May 2016 22:18:11 +0000 (22:18 +0000)]
[SDK/INCLUDE]: Fix a typo in ntstatus.mc (Debuger --> Debugger).

svn path=/trunk/; revision=71359

4 years ago[SDK/INCLUDE]: Fix ntstatus.mc: extra end-line whitespace and erroneous newlines...
Hermès Bélusca-Maïto [Thu, 19 May 2016 21:22:41 +0000 (21:22 +0000)]
[SDK/INCLUDE]: Fix ntstatus.mc: extra end-line whitespace and erroneous newlines at the end of the messages.

svn path=/trunk/; revision=71358

4 years ago[AFD]
Thomas Faber [Thu, 19 May 2016 21:17:18 +0000 (21:17 +0000)]
[AFD]
- Don't overwrite values in a completed IRP in ReceiveActivity
CORE-11276 #resolve

svn path=/trunk/; revision=71357

4 years ago[NETSHELL]
Eric Kohl [Thu, 19 May 2016 13:42:37 +0000 (13:42 +0000)]
[NETSHELL]
- Provide a common struct for the network setup data.
- Remember the typical/custom setup decision in order to return to the proper previous page when we click the 'Back' button on the domain page.
- Rename network setup page functions in a consistent way.
CORE-10955

svn path=/trunk/; revision=71356

4 years ago[SERVICES]
Thomas Faber [Thu, 19 May 2016 13:01:04 +0000 (13:01 +0000)]
[SERVICES]
- On service stop, set Service->lpImage to NULL after calling ScmDereferenceServiceImage, so the same image is not dereferenced again on service deletion
- Do not call ScmDereferenceServiceImage in CreateServiceListEntry, as the service should never have an image there
CORE-11273 #resolve

svn path=/trunk/; revision=71355

4 years ago[ACPI]
Thomas Faber [Thu, 19 May 2016 10:15:15 +0000 (10:15 +0000)]
[ACPI]
- Correctly double-null-terminate hardware IDs
CORE-11271 #resolve

svn path=/trunk/; revision=71354

4 years ago[NETSHELL]
Hermès Bélusca-Maïto [Wed, 18 May 2016 21:49:31 +0000 (21:49 +0000)]
[NETSHELL]
Addendum to r71348:
Fix MSVC build: "netshell\lang/de-DE.rc(87) : warning RC2182 : duplicate dialog control ID 3501" . Both IDC_NETWORK_TYPICAL and IDC_NETWORK_CUSTOM setup wizard pages had this same ID.
Obviously, GCC didn't catch this error. But the generated code would not have worked as expected.

CORE-10955 #comment [~milawynsrealm], please retest with r71353.

svn path=/trunk/; revision=71353

4 years agoTest commit to fix the nightmare caused by "previous" r71352.
Colin Finck [Wed, 18 May 2016 17:01:01 +0000 (17:01 +0000)]
Test commit to fix the nightmare caused by "previous" r71352.
See https://reactos.org/archives/public/ros-dev/2016-May/017845.html

svn path=/trunk/; revision=71352

4 years ago[SHELL32] Addendum to r71343: Remove some unneeded checks. The handles are initialize...
Robert Naumann [Wed, 18 May 2016 10:12:13 +0000 (10:12 +0000)]
[SHELL32] Addendum to r71343: Remove some unneeded checks. The handles are initialized as NULL so they will never be true

svn path=/trunk/; revision=71351

4 years ago[TASKMGR] Use the correct title string for create new task dialog. Spotted by Jared...
Robert Naumann [Wed, 18 May 2016 08:30:45 +0000 (08:30 +0000)]
[TASKMGR] Use the correct title string for create new task dialog. Spotted by Jared Smudde. CORE-11129

svn path=/trunk/; revision=71350

4 years ago[ROSAPPS/RDESKTOP]: Fix an heresy in the code.
Hermès Bélusca-Maïto [Tue, 17 May 2016 22:44:47 +0000 (22:44 +0000)]
[ROSAPPS/RDESKTOP]: Fix an heresy in the code.

svn path=/trunk/; revision=71349

4 years ago[SYSSETUP/NETSHELL]
Eric Kohl [Tue, 17 May 2016 22:38:58 +0000 (22:38 +0000)]
[SYSSETUP/NETSHELL]
2nd Stage Network Setup
Patch by Lee Schroeder and Eric Kohl.
- Move Lees 2nd stage network setup wizard code to netshell. It gets called by syssetup via NetSetupRequestWizardPages().
- Add code to syssetup which calls NetSetupRequestWizardPages and inserts the retrieved wizard pages into the setup wizard.
- Prevent a font handle leak by storing the bold font handle in the SetuData.

CORE-10955 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71348

4 years ago[PSDK] now the ICurrentWorkingDirectory interface is actually an interface.
Mark Jansen [Mon, 16 May 2016 18:50:14 +0000 (18:50 +0000)]
[PSDK] now the ICurrentWorkingDirectory interface is actually an interface.

svn path=/trunk/; revision=71347

4 years ago[NETAPI32]
Eric Kohl [Mon, 16 May 2016 18:34:52 +0000 (18:34 +0000)]
[NETAPI32]
Add NetGetAnyDCName stub.
CORE-11261 #comment Please test again!

svn path=/trunk/; revision=71346

4 years ago[BROWSEUI_APITEST] Add tests for ACListISF, a class used for autocompletion. CORE...
Mark Jansen [Mon, 16 May 2016 18:03:09 +0000 (18:03 +0000)]
[BROWSEUI_APITEST] Add tests for ACListISF, a class used for autocompletion. CORE-9281
- Add tests for ACListISF.
- Change the SHExplorerParseCmdLine test to use GetProcAddress instead of relying on the import (it's not there anymore in NT 6.0+)

svn path=/trunk/; revision=71345

4 years ago[PSDK] Add missing definitions for IACList2 Options. CORE-9281
Mark Jansen [Mon, 16 May 2016 17:59:10 +0000 (17:59 +0000)]
[PSDK] Add missing definitions for IACList2 Options. CORE-9281

svn path=/trunk/; revision=71344

4 years ago[SHELL32] - Implement a skeleton DlgProc for the folder options general dialog
Robert Naumann [Mon, 16 May 2016 11:58:31 +0000 (11:58 +0000)]
[SHELL32] - Implement a skeleton DlgProc for the folder options general dialog
- show icons depending on button states in folder options general dialog

svn path=/trunk/; revision=71343

4 years ago[BOOTDATA]
Daniel Reimer [Mon, 16 May 2016 11:11:22 +0000 (11:11 +0000)]
[BOOTDATA]
Fix autorun.inf on LiveCD and HybridCD linking to a non existent welcome.exe. HybridCD now links to the correct folder to welcome.exe and LiveCD just opens the readme.txt
https://www.reactos.org/forum/viewtopic.php?f=2&t=15406

svn path=/trunk/; revision=71342

4 years ago[REGSRV32] accept '-' as command line delimiter symbol as well
Christoph von Wittich [Mon, 16 May 2016 07:17:45 +0000 (07:17 +0000)]
[REGSRV32] accept '-' as command line delimiter symbol as well

svn path=/trunk/; revision=71340

4 years ago[NTOS][NDK][RTL]: Move the SEM_xxx flags and their corresponding RTL flags around...
Hermès Bélusca-Maïto [Sun, 15 May 2016 22:40:34 +0000 (22:40 +0000)]
[NTOS][NDK][RTL]: Move the SEM_xxx flags and their corresponding RTL flags around so that they can be accessed in kernel code. I'll need them soon.

svn path=/trunk/; revision=71339

4 years ago[NTOS][USERSRV]: Both hard-error message box options "OptionOkNoWait" and "OptionCanc...
Hermès Bélusca-Maïto [Sun, 15 May 2016 22:32:17 +0000 (22:32 +0000)]
[NTOS][USERSRV]: Both hard-error message box options "OptionOkNoWait" and "OptionCancelTryContinue" are valid!

svn path=/trunk/; revision=71338

4 years ago[USERSRV]: Code formatting.
Hermès Bélusca-Maïto [Sun, 15 May 2016 22:29:23 +0000 (22:29 +0000)]
[USERSRV]: Code formatting.

svn path=/trunk/; revision=71337

4 years ago[NTOS]: Remove hardcoded constants; fix a comment; move some code around to reduce...
Hermès Bélusca-Maïto [Sun, 15 May 2016 22:23:14 +0000 (22:23 +0000)]
[NTOS]: Remove hardcoded constants; fix a comment; move some code around to reduce the level of code indentation.

svn path=/trunk/; revision=71336

4 years ago[DHCPD]
Pierre Schweitzer [Sun, 15 May 2016 17:45:10 +0000 (17:45 +0000)]
[DHCPD]
Plug leaks

svn path=/trunk/; revision=71335

4 years ago[COM_APITEST] Add ICurrentWorkingDirectory for CORE-9281
Mark Jansen [Sun, 15 May 2016 14:45:01 +0000 (14:45 +0000)]
[COM_APITEST] Add ICurrentWorkingDirectory for CORE-9281

svn path=/trunk/; revision=71334

4 years ago[PSDK] Add missing ICurrentWorkingDirectory definition. CORE-9281
Mark Jansen [Sun, 15 May 2016 10:31:15 +0000 (10:31 +0000)]
[PSDK] Add missing ICurrentWorkingDirectory definition. CORE-9281

svn path=/trunk/; revision=71333

4 years ago[SHELL] Addendum to r71328, correct one german resource id.
Mark Jansen [Sun, 15 May 2016 10:25:47 +0000 (10:25 +0000)]
[SHELL] Addendum to r71328, correct one german resource id.

svn path=/trunk/; revision=71332

4 years ago[NTOS][MUP]: Use the correct constant for the PriorityBoost parameter in the IoComple...
Hermès Bélusca-Maïto [Sun, 15 May 2016 00:18:44 +0000 (00:18 +0000)]
[NTOS][MUP]: Use the correct constant for the PriorityBoost parameter in the IoCompleteRequest calls.

svn path=/trunk/; revision=71331

4 years ago[DRIVERS][NTOSKRNL]
Hermès Bélusca-Maïto [Sun, 15 May 2016 00:16:31 +0000 (00:16 +0000)]
[DRIVERS][NTOSKRNL]
Don't use PWORK_QUEUE_ITEM casts in ExQueueWorkItem calls, but use the explicit underlaying work queue item object instead.

svn path=/trunk/; revision=71330

4 years ago[PROGMAN]
Hermès Bélusca-Maïto [Thu, 12 May 2016 22:36:05 +0000 (22:36 +0000)]
[PROGMAN]
Implement drag&drop support for program items. A similar functionality can be implemented later in our shell32/explorer, based on this code.
We do here better than Windows' progman since we can select and move more than one icon.
Note that if you test it on ReactOS you will see nice bugs coming from our (well, Wine's) comctl32.dll xD :P

svn path=/trunk/; revision=71329

4 years ago[SHELL] Change the icon controls of the folder-options general page to static ones...
Robert Naumann [Thu, 12 May 2016 21:26:55 +0000 (21:26 +0000)]
[SHELL] Change the icon controls of the folder-options general page to static ones. Also give them and the radio buttons some meaningfull identifiers. Big thanks to our flying dutchman ;)

svn path=/trunk/; revision=71328

4 years ago[PROGMAN]
Hermès Bélusca-Maïto [Thu, 12 May 2016 21:12:40 +0000 (21:12 +0000)]
[PROGMAN]
- Fix the icon chooser dialog: icon enumeration, icon list cleanup... Similar fixes should also be ported to our shell32 icon list dialog code!
- Remove erroneous LBS_SORT style from the icon list box.

svn path=/trunk/; revision=71327

4 years ago[PROGMAN]
Hermès Bélusca-Maïto [Thu, 12 May 2016 19:54:53 +0000 (19:54 +0000)]
[PROGMAN]
- Load the main icon in a global variable (we use it at different places).
- Use the main icon for the shell-about dialog.

svn path=/trunk/; revision=71325

4 years ago[PROGMAN]: Use a ListView to list program items. On systems that support it (aka...
Hermès Bélusca-Maïto [Thu, 12 May 2016 19:45:26 +0000 (19:45 +0000)]
[PROGMAN]: Use a ListView to list program items. On systems that support it (aka. Vista+), enable ListView theming.

svn path=/trunk/; revision=71324

4 years ago[PROGMAN] Fix PCH build.
Amine Khaldi [Thu, 12 May 2016 16:32:35 +0000 (16:32 +0000)]
[PROGMAN] Fix PCH build.

svn path=/trunk/; revision=71322

4 years ago[USETUP]
Eric Kohl [Thu, 12 May 2016 16:18:32 +0000 (16:18 +0000)]
[USETUP]
Pressing F3-Enter during setup behaves wrong sometimes.
Patch by Wim Hueskes.
CORE-11231 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71321

4 years ago[USETUP]
Eric Kohl [Thu, 12 May 2016 15:30:49 +0000 (15:30 +0000)]
[USETUP]
Debug output in usetup.
Patch by Wim Hueskes.
CORE-11230 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71320

4 years ago[TELNET]
Eric Kohl [Thu, 12 May 2016 14:44:25 +0000 (14:44 +0000)]
[TELNET]
Updating Turkish Translation.
Patch by Erdem Ersoy.
CORE-11226 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71319

4 years ago[EXPLORER]
Thomas Faber [Thu, 12 May 2016 12:14:42 +0000 (12:14 +0000)]
[EXPLORER]
- Avoid activating windows when updating their size and position
CORE-11217

svn path=/trunk/; revision=71318

4 years ago[PROGMAN]: Commit 90% of the work I did on progman since its first inclusion in React...
Hermès Bélusca-Maïto [Wed, 11 May 2016 22:21:53 +0000 (22:21 +0000)]
[PROGMAN]: Commit 90% of the work I did on progman since its first inclusion in ReactOS: this concerns upgrading its user interface code from Wine's Win3.11-compatible code to WinNT-compatible code.
As this is *recovered* code from what I had in my local trunk before my HDD crash that occurred last month, this is almost pure code without most of the comments (this especially concerns the MAIN_LoadSettings function).
The 10% code that is not restored yet concerns the reader/writer code for program group files, and it will be committed separately later. This (missing) code is the core of progman; without it progrman does nothing interesting apart from displaying its main window (and its utility dialogs).

svn path=/trunk/; revision=71317

4 years ago[I8042PRT]
Thomas Faber [Wed, 11 May 2016 12:30:12 +0000 (12:30 +0000)]
[I8042PRT]
- Don't access device control IRPs after handing them off to a worker routine that has potentially already freed them.
CORE-11229 #resolve

svn path=/trunk/; revision=71316

4 years ago[BTRFS]
Pierre Schweitzer [Tue, 10 May 2016 21:08:50 +0000 (21:08 +0000)]
[BTRFS]
Cherry pick d71baf195715601212a2043f153400a964da6a18: Don't remove an entry list twice in add_to_space_list()

This avoids linked list entry twice removal

CORE-11057

svn path=/trunk/; revision=71315

4 years ago[BTRFS]
Pierre Schweitzer [Tue, 10 May 2016 21:07:56 +0000 (21:07 +0000)]
[BTRFS]
Cherry pick aa04ca0ea4cadb0c70ff6d659916cc98b7b02c27: uninit: don't free roots before FCBs are freed

This avoids use-after-free on shutdown

svn path=/trunk/; revision=71314

4 years ago[SHELL32] Improve a list view header. Patch by Jared Smudde. CORE-11151
Robert Naumann [Tue, 10 May 2016 20:48:39 +0000 (20:48 +0000)]
[SHELL32] Improve a list view header. Patch by Jared Smudde. CORE-11151

svn path=/trunk/; revision=71313

4 years ago[APPHELP] Remove imagehlp.dll dependency. CORE-10367
Mark Jansen [Tue, 10 May 2016 20:42:37 +0000 (20:42 +0000)]
[APPHELP] Remove imagehlp.dll dependency. CORE-10367

svn path=/trunk/; revision=71312

4 years ago[FASTFAT]
Thomas Faber [Tue, 10 May 2016 18:29:06 +0000 (18:29 +0000)]
[FASTFAT]
- Fix a use after free in VfatFlushVolume
CORE-11224 #resolve

svn path=/trunk/; revision=71311

4 years ago[UNIATA] Fix uninitialized variable usage. Patch by 'Alter'. CORE-11157 #resolve...
Mark Jansen [Tue, 10 May 2016 18:15:35 +0000 (18:15 +0000)]
[UNIATA] Fix uninitialized variable usage. Patch by 'Alter'. CORE-11157 #resolve #comment Thanks!

svn path=/trunk/; revision=71309

4 years ago[IPHLPAPI]
Thomas Faber [Tue, 10 May 2016 17:53:36 +0000 (17:53 +0000)]
[IPHLPAPI]
- Don't use uninitialized values in AllocateAndGet*TableFromStack functions. CID 716757
- Free buffers on failure
CORE-11227 #resolve

svn path=/trunk/; revision=71308

4 years ago[HAL]
Thomas Faber [Tue, 10 May 2016 15:03:56 +0000 (15:03 +0000)]
[HAL]
- Create a wrapper version of HalpEndSoftwareInterrupt that frees its stack before calling the noreturn version of the next software interrupt handler. Fixes excessive stack usage when DPCs are queued in quick succession.
CORE-11123 #resolve

svn path=/trunk/; revision=71307

4 years ago[IPHLPAPI]
Thomas Faber [Tue, 10 May 2016 13:59:41 +0000 (13:59 +0000)]
[IPHLPAPI]
- Fix memory leaks in getInterfaceInfoSet (CIDs 716370 and 716371)
- Fix a benign uninitialized variable use (CID 500783)
CORE-11224 #resolve

svn path=/trunk/; revision=71306

4 years ago[IPHLPAPI]
Thomas Faber [Tue, 10 May 2016 13:42:57 +0000 (13:42 +0000)]
[IPHLPAPI]
- Tabs to spaces. No code changes.

svn path=/trunk/; revision=71305

4 years ago[NTOS:MM]
Thomas Faber [Tue, 10 May 2016 11:47:05 +0000 (11:47 +0000)]
[NTOS:MM]
- Keep track of physical pages allocated for special pool, and respect the initially calculated MiSpecialPagesNonPagedMaximum

svn path=/trunk/; revision=71304

4 years ago[CONSOLE.CPL]: Fix a test condition. Reviewed by Thomas Faber; initially patched...
Hermès Bélusca-Maïto [Mon, 9 May 2016 22:06:27 +0000 (22:06 +0000)]
[CONSOLE.CPL]: Fix a test condition. Reviewed by Thomas Faber; initially patched by Victor Martinez Calvo Should fix CID 1322302 "Fix an use after free".
Please reanalyze with Coverity :)
CORE-11179

svn path=/trunk/; revision=71303

4 years ago[TEST]
Sylvain Petreolle [Mon, 9 May 2016 20:57:35 +0000 (20:57 +0000)]
[TEST]

svn path=/trunk/; revision=71302

4 years ago[USBHUB]
Thomas Faber [Mon, 9 May 2016 17:44:16 +0000 (17:44 +0000)]
[USBHUB]
- Fix memory leak in failure case of CreateDeviceIds. Patch by Víctor Martínez Calvo. CID 1102364
CORE-11208 #resolve

svn path=/trunk/; revision=71301

4 years ago[SHELL32]
Eric Kohl [Mon, 9 May 2016 15:11:25 +0000 (15:11 +0000)]
[SHELL32]
Improvements to the file types property page:
- Always show the selected file type.
- Set the focus to the listview control when the file types page gets activated.
- Enable/disable the Delete button for the initial file type selection too.

svn path=/trunk/; revision=71300

4 years ago[NETAPI32]
Eric Kohl [Mon, 9 May 2016 10:26:55 +0000 (10:26 +0000)]
[NETAPI32]
Prevent dereferencing null-pointers.

svn path=/trunk/; revision=71299

4 years ago[BTRFS]
Thomas Faber [Mon, 9 May 2016 09:10:13 +0000 (09:10 +0000)]
[BTRFS]
- Fix warnings

svn path=/trunk/; revision=71298

4 years ago[NTOS:SE]
Thomas Faber [Mon, 9 May 2016 08:49:18 +0000 (08:49 +0000)]
[NTOS:SE]
- In SepPropagateAcl, gracefully handle unknown ACE types by simply copying them.
CORE-10694 #resolve

svn path=/trunk/; revision=71296

4 years ago[SHELL32]
Thomas Faber [Mon, 9 May 2016 08:12:00 +0000 (08:12 +0000)]
[SHELL32]
- Fix uninitialized return value in _SHGetDefaultValue. CID 1322231
CORE-11213 #resolve

svn path=/trunk/; revision=71295

4 years agoZeroMemory expects buffer size in bytes
Christoph von Wittich [Mon, 9 May 2016 08:01:49 +0000 (08:01 +0000)]
ZeroMemory expects buffer size in bytes

svn path=/trunk/; revision=71294