reactos.git
3 years ago[KERNEL32_APITEST]: Add basic tests for lstrlenA/W, focusing on its special handling...
Hermès Bélusca-Maïto [Mon, 6 Mar 2017 19:14:27 +0000 (19:14 +0000)]
[KERNEL32_APITEST]: Add basic tests for lstrlenA/W, focusing on its special handling of the NULL pointer.
We detect that the NULL pointer is handled separately because no exception is generated, contrary to when the function is called with truly invalid pointers.
I thank Mark for having mentioned the vectored exception handling to me, needed to catch first-chance exceptions.

svn path=/trunk/; revision=74118

3 years ago[PSDK][NDK]: Add AddVectoredContinueHandler, RemoveVectoredContinueHandler, and RtlRe...
Hermès Bélusca-Maïto [Mon, 6 Mar 2017 19:04:17 +0000 (19:04 +0000)]
[PSDK][NDK]: Add AddVectoredContinueHandler, RemoveVectoredContinueHandler, and RtlRemoveVectoredExceptionHandler, RtlAddVectoredContinueHandler and RtlRemoveVectoredContinueHandler to our headers.

svn path=/trunk/; revision=74117

3 years ago[NtUser]
James Tabor [Mon, 6 Mar 2017 18:28:03 +0000 (18:28 +0000)]
[NtUser]
- Remove scroll bar search that sends another WM_NCCALCSIZE message. Use wine as an example. See CORE-12827.

svn path=/trunk/; revision=74116

3 years ago[MKISOFS]
Colin Finck [Sun, 5 Mar 2017 22:54:33 +0000 (22:54 +0000)]
[MKISOFS]
Update mkisofs to schily-2017-02-16, which comes with the following fixes:
- Fix null termination in libschily's Win32 implementation of opendir (submitted upstream by me).
  The bug was triggered when building an ISO from a directory instead of a graft-points (.lst) file.
- Prevent -duplicates-once from being used together with -cache-inodes. These options exclude each other.

svn path=/trunk/; revision=74112

3 years ago[OLEAUT32_WINETEST] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:51:44 +0000 (21:51 +0000)]
[OLEAUT32_WINETEST] Sync with Wine Staging 2.2. CORE-12823

svn path=/trunk/; revision=74111

3 years ago[OLEAUT32] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:50:37 +0000 (21:50 +0000)]
[OLEAUT32] Sync with Wine Staging 2.2. CORE-12823

43c59f0 oleaut32: Accept DISP_E_PARAMNOTFOUND for missing optional parameters in ITypeInfo::Invoke implementation. (v3)
a4f9840 oleaut32: Fix calling function with instance and VARIANT return type. (v2)
78ee7f5 oleaut32: Standardize the heap_xxx() functions.
9e54ae7 oleaut32: Return proper interface pointers.
655af6d oleaut32: Fix OleTranslateColor spec file entry.

svn path=/trunk/; revision=74110

3 years ago[RICHED20_WINETEST] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:44:19 +0000 (21:44 +0000)]
[RICHED20_WINETEST] Sync with Wine Staging 2.2. CORE-12823

svn path=/trunk/; revision=74109

3 years ago[RICHED20] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:43:39 +0000 (21:43 +0000)]
[RICHED20] Sync with Wine Staging 2.2. CORE-12823

440b921 riched20: Return proper interface pointers.
e63cea5 riched20: A spelling fix in a comment.
9f37f6a riched20: Check for NULL in fnTextSrv_TxSetText and add test.

svn path=/trunk/; revision=74108

3 years ago[INETCOMM_WINETEST] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:37:58 +0000 (21:37 +0000)]
[INETCOMM_WINETEST] Sync with Wine Staging 2.2. CORE-12823

svn path=/trunk/; revision=74107

3 years ago[INETCOMM] I guess I asked too much from svn when I renamed the existing file and...
Amine Khaldi [Sun, 5 Mar 2017 21:36:38 +0000 (21:36 +0000)]
[INETCOMM] I guess I asked too much from svn when I renamed the existing file and then added a new one with the same name as the old.

svn path=/trunk/; revision=74106

3 years ago[INETCOMM] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:33:13 +0000 (21:33 +0000)]
[INETCOMM] Sync with Wine Staging 2.2. CORE-12823

51e1a08 inetcomm: Return S_FALSE if no data is returned in IInternetProtocol::Read.
0672bfa inetcomm: Added support for decoding quoted-printable data.
07af9d0 inetcomm: Added mhtml binding tests.
cf8e259 inetcomm: Added support for binding mhtml protocol handler.
3f644cb inetcomm: Added IInternetProtocolInfo::CombineUrl implementation.
37792a2 inetcomm: Added MimeOleObjectFromMoniker semi-stub implementation.
242cbb1 inetcomm: Added tests reading MHTML page as MIME message.
eb0bd22 inetcomm: Removed unneeded type check in init_content_type.
56dc246 inetcomm: Read content encoding from MIME header.
dec243f inetcomm: Don't include headers in data stream in create_sub_body.
3ccba10 inetcomm: Properly handle boundary in the beginning of body stream in create_body_offset_list.
9c01a94 inetcomm: Use relative seek in copy_headers_to_buf.
915acd6 inetcomm: Added support for decoding base64 in IMimeBody::GetData.
0b80666 inetcomm: Return a new instance of stream in IMimeBody::GetData.
393512d inetcomm: Don't restore base stream position in sub stream Read.
bb5056e inetcomm: Moved sub_stream_t implementation before MimeBody implementation.
a1d0c6d inetcomm: Added COM aggregation support to MimeHtmlProtocol object.
fe3e5b9 inetcomm: Added IInternetProtocolInfo stub implementation.
6832273 inetcomm: Added MimeHtmlProtocol stub implementation.
d5d9aa3 inetcomm: Register mhtml protocol handler.

svn path=/trunk/; revision=74105

3 years ago[PSDK] Update mimeole.idl. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:29:40 +0000 (21:29 +0000)]
[PSDK] Update mimeole.idl. CORE-12823

svn path=/trunk/; revision=74104

3 years ago[NTOS:OB]
Eric Kohl [Sun, 5 Mar 2017 21:28:10 +0000 (21:28 +0000)]
[NTOS:OB]
- Define and use a pool tag for directory security descriptors.
- Use a custom security descriptor to create the KernelObjects directory.

svn path=/trunk/; revision=74103

3 years ago[CRYPT32_WINETEST] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:22:31 +0000 (21:22 +0000)]
[CRYPT32_WINETEST] Sync with Wine Staging 2.2. CORE-12823

svn path=/trunk/; revision=74102

3 years ago[CRYPT32] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:21:36 +0000 (21:21 +0000)]
[CRYPT32] Sync with Wine Staging 2.2. CORE-12823

a7d1d77 crypt32: Recognize sha256/384/512 KEY OIDs.
e376123 crypt32: Remove unused parameter and dead code.
254eb21 crypt32: Fix wrong Base64 trailer WCHAR constants.
a2f2de1 crypt32: CryptStringToBinary accepts any header.
552820a crypt32: Fix Base64 issues in CryptStringToBinary.
e353ab6 crypt32: Base64 header requires a space.

svn path=/trunk/; revision=74101

3 years ago[PSDK] Update wincrypt.h. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:19:15 +0000 (21:19 +0000)]
[PSDK] Update wincrypt.h. CORE-12823

svn path=/trunk/; revision=74100

3 years ago[GDIPLUS_WINETEST] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:16:17 +0000 (21:16 +0000)]
[GDIPLUS_WINETEST] Sync with Wine Staging 2.2. CORE-12823

svn path=/trunk/; revision=74099

3 years ago[GDIPLUS] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:15:16 +0000 (21:15 +0000)]
[GDIPLUS] Sync with Wine Staging 2.2. CORE-12823

818b141 gdiplus: Add support for more image color formats.
f8f0a35 gdiplus: Implement GdipInitializePalette. (v2)
973bba9 gdiplus: Ignore an externally set DC clipping region.
650b8d0 gdiplus: Ignore an externally set DC origin.
e100661 gdiplus: Add GdipCreateHBITMAPFromBitmap tests when bitmap bits are locked.
b58276a gdiplus: Reimplement GdipCreateHBITMAPFromBitmap so it can work on locked bitmaps.
5673d82 gdiplus: GpBitmap can be only locked once, get rid of numlocks field.
0eaaa15 gdiplus: Make GpBitmap->bitmapbits access thread safe.
4e685eb gdiplus: Added GdipGetCustomLineCapType().
36bb9d9 gdiplus: Fix some spec file entries.
f870708 gdiplus: Make some GdipDraw*Path() functions static.
046fc19 gdiplus: Fix memory leak in format_string_callback error path.
5018594 gdiplus: Create the FontFamily before checking for duplicates.
0d6a4b0 gdiplus: Don't include rotated fonts in the installed font collection.

svn path=/trunk/; revision=74098

3 years ago[PSDK] Update wincodec.idl. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:08:10 +0000 (21:08 +0000)]
[PSDK] Update wincodec.idl. CORE-12823

svn path=/trunk/; revision=74097

3 years ago[PSDK] Update gdiplusenums.h and gdiplusflat.h. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:06:16 +0000 (21:06 +0000)]
[PSDK] Update gdiplusenums.h and gdiplusflat.h. CORE-12823

svn path=/trunk/; revision=74096

3 years ago[OLE32_WINETEST] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:03:59 +0000 (21:03 +0000)]
[OLE32_WINETEST] Sync with Wine Staging 2.2. CORE-12823

svn path=/trunk/; revision=74095

3 years ago[OLE32] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 21:03:00 +0000 (21:03 +0000)]
[OLE32] Sync with Wine Staging 2.2. CORE-12823

23607d0 ole32: Implement returning a name in IEnumSTATPROPSTG.
5cf1db5 ole32: Support reading VT_BOOL, VT_R8 and VT_I8 into propery storage.
591c9c8 ole32: Correctly parse unicode property storage dictionaries.
93a8ede ole32: Add a __WINE_ALLOC_SIZE attribute to heap_alloc().
182fad8 ole32: Call GetClipboardFormatName with the correct parameters.
e31dd0f ole32: Use a HWND_MESSAGE window for the clipboard.
c85eaae ole32: Only trace a clipboard format name if it has one.
77e566a ole32: Don't set zero-size clipboard data, this no longer works.

svn path=/trunk/; revision=74094

3 years ago[COMDLG32_WINETEST] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 20:57:57 +0000 (20:57 +0000)]
[COMDLG32_WINETEST] Sync with Wine Staging 2.2. CORE-12823

svn path=/trunk/; revision=74093

3 years ago[COMDLG32] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 20:57:05 +0000 (20:57 +0000)]
[COMDLG32] Sync with Wine Staging 2.2. CORE-12823

e07d20f comdlg32: Don't crash if an IShellFolder could not be created.
bd1b3c1 comdlg32: Use localized "Path does not exist" string.
1707df3 comdlg32: Delay OleInitialize() until after file dialog window is created.
6c4aaf7 comdlg32: Always use original Open File dialog template.
eff2ecc comdlg32: Avoid some superfluous pointer casts.

svn path=/trunk/; revision=74092

3 years ago[COMCTL32_WINETEST] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 20:53:49 +0000 (20:53 +0000)]
[COMCTL32_WINETEST] Sync with Wine Staging 2.2. CORE-12823

svn path=/trunk/; revision=74091

3 years ago[COMCTL32] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 20:52:24 +0000 (20:52 +0000)]
[COMCTL32] Sync with Wine Staging 2.2. CORE-12823

cc055c4 comctl32: Add support for PSPCB_ADDREF/PSPCB_RELEASE callback notifications. (v2)
83cde06 comctl32/propsheet: Implement PSM_SETHEADERSUBTITLE.
ce9c06b comctl32/propsheet: Implement PSM_SETHEADERTITLE.
1a750f7 comctl32/propsheet: Add helpers to do string duplication.
14a6c98 comctl32/pager: Don't block window size changes.
a6661ba comctl32/propsheet: Added PSM_INSERTPAGE implementation.
34dd326 comctl32/propsheet: Only use header bitmap when asked for it.
6eafebe comctl32/propsheet: Force wizard header if any of pages has title/subtitle.
70c9a96 comctl32: Fix some more spec file entries.
2dd0fb8 comctl32: Correctly set the colour table for ILC_COLOR4 and ILC_COLOR8 imagelists.
a0e73a1 comctl32/syslink: Don't use exported StrCmpNIW().
970029b comctl32/toolbar: Fix TB_SETDRAWTEXTFLAGS handler.
99913e8 comctl32: Fix some spec file entries.
9d404dd comctl32/propsheet: Double size of a template buffer passed to PSCB_PRECREATE.
bb1d68e comctl32/trackbar: Fix TBM_SETRANGEMAX handling when new limit is less than current min boundary.
26067cc comctl32/toolbar: Protect from NULL pointer access in TB_GETBUTTONINFOW handler.
a6aabe0 comctl32/trackbar: Update thumb unconditionally on TBM_SETTICFREQ.
c7c8994 comctl32: Recompute the text width if necessary.
3ed6ba5 comctl32: Set the text and bkgnd colours to the default before the item pre-paint notification.
8915404 comctl32: Use wine_dbgstr_point in TRACES.

svn path=/trunk/; revision=74090

3 years ago[PSDK] Add missing PSPCB_ADDREF. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 20:49:12 +0000 (20:49 +0000)]
[PSDK] Add missing PSPCB_ADDREF. CORE-12823

svn path=/trunk/; revision=74089

3 years ago[MSI_WINETEST] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 20:45:43 +0000 (20:45 +0000)]
[MSI_WINETEST] Sync with Wine Staging 2.2. CORE-12823

svn path=/trunk/; revision=74088

3 years ago[MSI] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 20:45:25 +0000 (20:45 +0000)]
[MSI] Sync with Wine Staging 2.2. CORE-12823

fe50dbf msi: Do not sign extend after multiplying.
c659222 msi: Fix some spec file entries.
167de42 msi: Make reg_get_{multi}sz() static.
f5e4dad msi: Fix handling of NULL buffer in MsiGetProductPropertyW() (Coverity).
3b5b3ef msi: Fix MSIREG_OpenUserComponentsKey and MSIREG_DeleteUpgradeCodesKey for Wow64.
5ac0242 msi: Correctly size packagecode as it's an unsquashed guid.

svn path=/trunk/; revision=74087

3 years ago[RPCRT4_WINETEST] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 20:43:17 +0000 (20:43 +0000)]
[RPCRT4_WINETEST] Sync with Wine Staging 2.2. CORE-12823

svn path=/trunk/; revision=74086

3 years ago[RPCRT4] Sync with Wine Staging 2.2. CORE-12823
Amine Khaldi [Sun, 5 Mar 2017 20:42:41 +0000 (20:42 +0000)]
[RPCRT4] Sync with Wine Staging 2.2. CORE-12823

b85c2f7 rpcrt4: Fix some spec file entries.
042b41d rpcrt4: Avoid potential overflow in rpcrt4_protseq_ncacn_np_open_endpoint.
c32cd11 rpcrt4: Acquire new credential handle for each connection.
da05dfd rpcrt4: Store security package name in rpc_server_registered_auth_info.
f8450fa rpcrt4: Handle NULL binding in RpcBindingInqAuthClient{,Ex}.

svn path=/trunk/; revision=74085

3 years ago[UXTHME] Implement drawing themed text with shadows.
Giannis Adamopoulos [Sun, 5 Mar 2017 19:34:01 +0000 (19:34 +0000)]
[UXTHME] Implement drawing themed text with shadows.

svn path=/trunk/; revision=74083

3 years ago[FREELDR]
Thomas Faber [Sun, 5 Mar 2017 11:24:31 +0000 (11:24 +0000)]
[FREELDR]
- "ReactOS Medium" isn't a trademark or anything, no need to capitalize it

svn path=/trunk/; revision=74077

3 years ago[COMCTL32] -Slightly improve the hack.
Giannis Adamopoulos [Sun, 5 Mar 2017 10:26:57 +0000 (10:26 +0000)]
[COMCTL32] -Slightly improve the hack.

svn path=/trunk/; revision=74076

3 years ago[COMCTL32] -Remove a debug print that is no longer needed.
Giannis Adamopoulos [Sun, 5 Mar 2017 09:42:29 +0000 (09:42 +0000)]
[COMCTL32] -Remove a debug print that is no longer needed.

svn path=/trunk/; revision=74075

3 years ago[COMCTL32] - A button with the style BS_DEFPUSHBUTTON is drawn as defaulted instead...
Giannis Adamopoulos [Sun, 5 Mar 2017 09:35:12 +0000 (09:35 +0000)]
[COMCTL32] - A button with the style BS_DEFPUSHBUTTON is drawn as defaulted instead of normal.

svn path=/trunk/; revision=74074

3 years ago[COMCTL32] -Make the lautus hack a bit more strict.
Giannis Adamopoulos [Sun, 5 Mar 2017 09:14:12 +0000 (09:14 +0000)]
[COMCTL32] -Make the lautus hack a bit more strict.

svn path=/trunk/; revision=74073

3 years ago[COMCTL32] Ha^^Fix the size of the start button for lautus so as it gets the same...
Giannis Adamopoulos [Sun, 5 Mar 2017 09:09:30 +0000 (09:09 +0000)]
[COMCTL32] Ha^^Fix the size of the start button for lautus so as it gets the same size with our shell in ros and windows.

svn path=/trunk/; revision=74072

3 years ago[USER32]: Use RtlInitEmptyUnicodeString where needed. Fix CID 1401230 and CID 701428...
Hermès Bélusca-Maïto [Sun, 5 Mar 2017 01:20:40 +0000 (01:20 +0000)]
[USER32]: Use RtlInitEmptyUnicodeString where needed. Fix CID 1401230 and CID 701428 in the process.

svn path=/trunk/; revision=74071

3 years ago[USER32]: Trim trailing whitespace + few code style changes only.
Hermès Bélusca-Maïto [Sun, 5 Mar 2017 01:19:07 +0000 (01:19 +0000)]
[USER32]: Trim trailing whitespace + few code style changes only.

svn path=/trunk/; revision=74070

3 years ago[NTOS:LPC]
Thomas Faber [Sun, 5 Mar 2017 00:55:50 +0000 (00:55 +0000)]
[NTOS:LPC]
- Implement the early exit case (e.g. on connection refused) in NtAcceptConnectPort
CORE-12145

svn path=/trunk/; revision=74069

3 years ago[WS2_32]
Hermès Bélusca-Maïto [Sun, 5 Mar 2017 00:40:22 +0000 (00:40 +0000)]
[WS2_32]
- Fix pointers verification in WSALookupServiceNextW and WSALookupServiceNextA;
- In WSALookupServiceNextA: Perform extra checks to see whether we failed the first local buffer allocation, and if so, retrieve the needed size by calling a first time WSALookupServiceNextW, then reallocate the temp buffer and redo a WSALookupServiceNextW call (if it still fails, then we bail out).
  CID 513448.

svn path=/trunk/; revision=74068

3 years ago[WS2_32]: Fix the crash in ws2_32 reported in CORE-12852, that happens when opening...
Hermès Bélusca-Maïto [Sun, 5 Mar 2017 00:24:08 +0000 (00:24 +0000)]
[WS2_32]: Fix the crash in ws2_32 reported in CORE-12852, that happens when opening e.g. Word 2010 for the first time (when it asks for registration):
- Check whether WsNcLoadProvider really succeeded in loading a provider in WsNcGetCatalogFromProviderId, and return appropriate error code.
- In WsNqLookupServiceBegin, initialize CatalogEntry to NULL prior to calling WsNcGetCatalogFromProviderId, and check for success or failure of WsNqAddProvider (and fail in accordance).

svn path=/trunk/; revision=74067

3 years ago[WS2_32]
Hermès Bélusca-Maïto [Sat, 4 Mar 2017 23:55:30 +0000 (23:55 +0000)]
[WS2_32]
- Let require explicit semicolons when using the Ws***(Un)Lock macros (and thus remove the semicolon from their definition).

svn path=/trunk/; revision=74066

3 years ago[UXTHEME]: Handle WM_NCACTIVATE only when the window has a themed caption (it's not...
Giannis Adamopoulos [Sat, 4 Mar 2017 22:33:21 +0000 (22:33 +0000)]
[UXTHEME]: Handle WM_NCACTIVATE only when the window has a themed caption (it's not like windows with classic borders and no caption need to be redrawn to reflect that they get or lose the active state). Fixes the classic border drawn on deactivation in the taskbar. Found by Sylvain Deverre. CORE-12887

svn path=/trunk/; revision=74065

3 years ago[NTDLL] Implement some basic shim engine integration. CORE-10368
Mark Jansen [Sat, 4 Mar 2017 20:34:36 +0000 (20:34 +0000)]
[NTDLL] Implement some basic shim engine integration. CORE-10368

svn path=/trunk/; revision=74064

3 years ago[NTDLL] Fix RtlDecodeSystemPointer for usage inside ntdll. CORE-10368
Mark Jansen [Sat, 4 Mar 2017 20:32:12 +0000 (20:32 +0000)]
[NTDLL] Fix RtlDecodeSystemPointer for usage inside ntdll. CORE-10368

svn path=/trunk/; revision=74063

3 years ago[APPHELP] Fix a possible read past the buffer in SdbpIsPathOnRemovableMedia.
Mark Jansen [Sat, 4 Mar 2017 20:29:46 +0000 (20:29 +0000)]
[APPHELP] Fix a possible read past the buffer in SdbpIsPathOnRemovableMedia.

svn path=/trunk/; revision=74062

3 years ago[APPHELP_APITEST] Check which parts of apphelp accept NT paths
Mark Jansen [Sat, 4 Mar 2017 20:27:39 +0000 (20:27 +0000)]
[APPHELP_APITEST] Check which parts of apphelp accept NT paths

svn path=/trunk/; revision=74061

3 years ago[NTOS:CM]
Eric Kohl [Sat, 4 Mar 2017 19:48:27 +0000 (19:48 +0000)]
[NTOS:CM]
CmpSecurityMethod:
- Lock and unlock the Hive and the KCB.
- Fail, if we try to access a key that has been marked for deletion.

svn path=/trunk/; revision=74060

3 years ago[USER32]
Thomas Faber [Sat, 4 Mar 2017 19:02:30 +0000 (19:02 +0000)]
[USER32]
- Fix overflow check in SetScrollRange. CID 731535
CORE-12763 #resolve

svn path=/trunk/; revision=74059

3 years ago[USER32_APITEST]
Thomas Faber [Sat, 4 Mar 2017 18:34:35 +0000 (18:34 +0000)]
[USER32_APITEST]
- Add a test for SetScrollRange
CORE-12763

svn path=/trunk/; revision=74058

3 years ago[DESK] Fix Font Smoothing Dropdown Field. Patch by Katayama Hirofumi MZ CORE-12568
Robert Naumann [Sat, 4 Mar 2017 18:12:42 +0000 (18:12 +0000)]
[DESK] Fix Font Smoothing Dropdown Field. Patch by Katayama Hirofumi MZ CORE-12568

svn path=/trunk/; revision=74057

3 years ago[ACPICA]
Thomas Faber [Sat, 4 Mar 2017 16:54:26 +0000 (16:54 +0000)]
[ACPICA]
- Update to version 20170303
CORE-12885

svn path=/trunk/; revision=74056

3 years ago[BOOTDATA]
Thomas Faber [Sat, 4 Mar 2017 16:29:51 +0000 (16:29 +0000)]
[BOOTDATA]
- Support integrating Intel's DC21x4 network card driver (for Hyper-V/VirtualPC) into our ISOs until we have our own.
CORE-8724

svn path=/trunk/; revision=74055

3 years ago[NTOS:OB]
Eric Kohl [Sat, 4 Mar 2017 16:02:06 +0000 (16:02 +0000)]
[NTOS:OB]
Create a custom security descriptor for the global DosDevices directory.

svn path=/trunk/; revision=74054

3 years ago[NTOS:PNP]
Thomas Faber [Sat, 4 Mar 2017 16:01:59 +0000 (16:01 +0000)]
[NTOS:PNP]
- Make device instance paths unique if necessary (by adding the parent ID prefix), regardless of the return status from IRP_MN_QUERY_ID/BusQueryInstanceID. Support for this IRP is optional in most cases, and a failure status just indicates no instance id information is needed by the driver stack.
Major thanks to Vadim Galyant for debugging this and identifying the root cause.
CORE-12732 CORE-12818 CORE-12745 CORE-12733 CORE-12717 CORE-12735

svn path=/trunk/; revision=74053

3 years ago[NTOS:PNP]
Thomas Faber [Sat, 4 Mar 2017 15:17:30 +0000 (15:17 +0000)]
[NTOS:PNP]
- Use UNICODE_STRINGs in IopCreateDeviceInstancePath instead of messing around with unsafe string functions and stack buffers

svn path=/trunk/; revision=74052

3 years ago[FASTFAT]
Thomas Faber [Sat, 4 Mar 2017 14:48:05 +0000 (14:48 +0000)]
[FASTFAT]
- Avoid use after free in vfatDestroyFCB

svn path=/trunk/; revision=74051

3 years ago[NTOS:SE]
Eric Kohl [Sat, 4 Mar 2017 14:38:13 +0000 (14:38 +0000)]
[NTOS:SE]
Add a missing ACE(SeAliasAdminsSid / GENERIC_ALL) to the SePublicDefaultDacl ACL. This fixes a kmtest:ObSecurity failure.

svn path=/trunk/; revision=74050

3 years ago[NTOS:PNP]
Thomas Faber [Sat, 4 Mar 2017 13:50:55 +0000 (13:50 +0000)]
[NTOS:PNP]
Fix IopGetParentIdPrefix:
- Do not include null terminator in UNICODE_STRING::Length
- Use pool tagging
- Use strsafe printf
- Avoid a magic number

svn path=/trunk/; revision=74049

3 years ago[NTOS:PNP]
Thomas Faber [Sat, 4 Mar 2017 13:20:25 +0000 (13:20 +0000)]
[NTOS:PNP]
- Improve use of local variables in IopCreateDeviceInstancePath and IopActionInterrogateDeviceStack
- Improve debug prints in IopCreateDeviceInstancePath. By Vadim Galyant
- Fix formatting in IopGetParentIdPrefix

svn path=/trunk/; revision=74048

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 4 Mar 2017 11:34:13 +0000 (11:34 +0000)]
[FASTFAT]
When un/locking a volume, also handle VPB state

svn path=/trunk/; revision=74047

3 years ago[WIN32K]
Kamil Hornicek [Sat, 4 Mar 2017 10:37:00 +0000 (10:37 +0000)]
[WIN32K]
- GreGetDIBitsInternal:
- Prevent an access violation in DIB_FreeConvertedBitmapInfo by initializing the bit count before calling DIB_ConvertBitmapInfo and setting clrUsed.
- Validate input parameters and return correct values - only return number of scan lines if bits are not null and bpp is not zero. Otherwise return 1 on success.
- We now pass more gdi32:GetDIBits and gdi32:bitmap tests.
CORE-9270

svn path=/trunk/; revision=74046

3 years ago[WS2_32]
Hermès Bélusca-Maïto [Sat, 4 Mar 2017 01:09:28 +0000 (01:09 +0000)]
[WS2_32]
- Turn the "!memcmp(ptr1, ptr2, sizeof(GUID))" into IsEqualGUID(ptr1, ptr2) macro calls (aka. make code readable);
  this also allowed me to discover a logical bug in the GUID comparison in WsNcUpdateNamespaceList.
- Fix few comments, and rename some goto labels to make their meaning clearer (they are not only taken for error code paths,
  but also on regular path, for cleanup before returning from the function).
CORE-12880

svn path=/trunk/; revision=74045

3 years ago[WS2_32]: More fixes:
Hermès Bélusca-Maïto [Sat, 4 Mar 2017 00:35:02 +0000 (00:35 +0000)]
[WS2_32]: More fixes:
- Perform success checks in WsAsyncCheckAndInitThread, in particular, check whether Context is correctly allocated,
  and check whether the WsAsyncThread was correctly started up. In case of failure, perform the necessary cleanup,
  including calling WSACleanup().
- Check also the returned error code of WSAStartup. Fixes CID 1101934.
- Fix logic mess-up in WsNqLookupServiceNext when updating NsQuery->ActiveProvider;
- Fix copy-pasta errors (using 'lpafpProtocols' instead of 'lpcsaBuffer') in CopyQuerySetIndirectA and CopyQuerySetIndirectW,
  that triggered CID 513446 + CID 513447 (CopyQuerySetIndirectA), and CID 513444 + CID 513445 (CopyQuerySetIndirectW).
- Check for 'lpdwBufferLength' pointer validity in WSALookupServiceNextW;
- Check for 'lpdwBufferLength' and 'lpqsResults' pointers validity in WSALookupServiceNextA, and dereference lpdwBufferLength only afterwards.
- Check for return value of RegCreateKeyEx in WsOpenRegistryRoot(), fixes CID 715923.

svn path=/trunk/; revision=74044

3 years ago[WS2_32]
Hermès Bélusca-Maïto [Fri, 3 Mar 2017 23:47:26 +0000 (23:47 +0000)]
[WS2_32]
- Check for NULL pointers after HeapAlloc calls, in the constructor functions, before initializing members of created objects;
- Add a bunch of missing HeapFree in the corresponding destructor functions.
  In particular, fix the root cause of CID 1401152 in WsTpDelete: missing HeapFree call.
CORE-12880

svn path=/trunk/; revision=74043

3 years ago[WS2_32]: Addendum to r74041: Forgot these changes too. CORE-12880
Hermès Bélusca-Maïto [Fri, 3 Mar 2017 23:34:47 +0000 (23:34 +0000)]
[WS2_32]: Addendum to r74041: Forgot these changes too. CORE-12880

svn path=/trunk/; revision=74042

3 years ago[WS2_32]: Cosmetic changes first, before real fixes - CORE-12880 :
Hermès Bélusca-Maïto [Fri, 3 Mar 2017 23:31:32 +0000 (23:31 +0000)]
[WS2_32]: Cosmetic changes first, before real fixes - CORE-12880 :
- Use IsListEmpty where needed;
- Initialize NextEntry using Catalog->ProtocolList after the lock on the catalog has been acquired;
- Rearrange WsNqLookupServiceNext to reduce the code indent level; also, convert the construct "if (var) { do { ... } while (var); }" into a mere "while (var) { ... }";
- WsNqPreviousProvider: the "next" provider is the previous one...;
- WsNqAddProvider: Use a more standard name for the boolean return value;
- Fix the annotation of MapUnicodeQuerySetToAnsi;
- Factor out setting the SetLastError WSALookupServiceBeginA.

svn path=/trunk/; revision=74041

3 years ago[FONTS] Add Libre Franklin Font v4.0.15
Robert Naumann [Fri, 3 Mar 2017 22:07:00 +0000 (22:07 +0000)]
[FONTS] Add Libre Franklin Font v4.0.15
[USETUP] Add Font Substitutions for Franklin Gothic and MS Trebuchet CORE-12878 CORE-12877

Now Luna uses better fonts but the font styles are still not used.

svn path=/trunk/; revision=74040

3 years ago[SHELL32]
Kamil Hornicek [Fri, 3 Mar 2017 16:20:03 +0000 (16:20 +0000)]
[SHELL32]
- Always set the default value in SetDefaultHandler, otherwise it's impossible to create a default association if the key for some reason already exists. This is consistent with what Windows does.

svn path=/trunk/; revision=74039

3 years ago[UXTHEME]: Use SendMessage to notify windows that the theme has changed. This needs...
Giannis Adamopoulos [Fri, 3 Mar 2017 14:35:19 +0000 (14:35 +0000)]
[UXTHEME]: Use SendMessage to notify windows that the theme has changed. This needs a proper test. Makes it possible for SetWindowTheme with empty parameters to have effect immediately in the same way the tests for BCM_GETIDEALSIZE use it. Fixes the BCM_GETIDEALSIZE tests when run with an active theme.

svn path=/trunk/; revision=74038

3 years ago[COMCTL32]: Fix all tests for BCM_GETIDEALSIZE that we have so far. (It still returns...
Giannis Adamopoulos [Fri, 3 Mar 2017 13:56:49 +0000 (13:56 +0000)]
[COMCTL32]: Fix all tests for BCM_GETIDEALSIZE that we have so far. (It still returns a wrong result for the start button with lautus).

svn path=/trunk/; revision=74037

3 years ago[COMCTL32_APITEST]: Simplify tests to not depend on internals of CreateWindow (creati...
Giannis Adamopoulos [Fri, 3 Mar 2017 13:54:56 +0000 (13:54 +0000)]
[COMCTL32_APITEST]: Simplify tests to not depend on internals of CreateWindow (creating buttons as top level windows and testing their sizes complicates stuff without reason).

svn path=/trunk/; revision=74036

3 years ago[COMCTL32_APITEST]: Add a few more tests.
Giannis Adamopoulos [Fri, 3 Mar 2017 11:30:06 +0000 (11:30 +0000)]
[COMCTL32_APITEST]: Add a few more tests.

svn path=/trunk/; revision=74035

3 years ago[COMCTL32_APITEST]: Make some tests more strict and add tests for all button types.
Giannis Adamopoulos [Fri, 3 Mar 2017 11:22:20 +0000 (11:22 +0000)]
[COMCTL32_APITEST]: Make some tests more strict and add tests for all button types.

svn path=/trunk/; revision=74034

3 years ago[WS2_32]: Remove trailing whitespace.
Hermès Bélusca-Maïto [Fri, 3 Mar 2017 00:13:40 +0000 (00:13 +0000)]
[WS2_32]: Remove trailing whitespace.

svn path=/trunk/; revision=74033

3 years ago[NTDLL] Some style changes for RtlNtPathNameToDosPathName as suggested by Thomas...
Mark Jansen [Thu, 2 Mar 2017 21:51:22 +0000 (21:51 +0000)]
[NTDLL] Some style changes for RtlNtPathNameToDosPathName as suggested by Thomas and Hermes. CORE-12847

svn path=/trunk/; revision=74032

3 years ago[NTDLL] Add implementation for RtlNtPathNameToDosPathName. CORE-12847 #resolve
Mark Jansen [Thu, 2 Mar 2017 21:29:38 +0000 (21:29 +0000)]
[NTDLL] Add implementation for RtlNtPathNameToDosPathName. CORE-12847 #resolve

svn path=/trunk/; revision=74031

3 years ago[NTDLL_APITEST] Add tests for RtlNtPathNameToDosPathName. CORE-12847
Mark Jansen [Thu, 2 Mar 2017 20:43:09 +0000 (20:43 +0000)]
[NTDLL_APITEST] Add tests for RtlNtPathNameToDosPathName. CORE-12847

svn path=/trunk/; revision=74030

3 years ago[NTDLL] Implement RtlpEnsureBufferSize. Patch by Hermes Belusca-Maito. CORE-11990
Mark Jansen [Thu, 2 Mar 2017 20:40:21 +0000 (20:40 +0000)]
[NTDLL] Implement RtlpEnsureBufferSize. Patch by Hermes Belusca-Maito. CORE-11990
Some small changes by me.

svn path=/trunk/; revision=74029

3 years ago[NTDLL_APITEST] Add tests for RtlpEnsureBufferSize. CORE-11990
Mark Jansen [Thu, 2 Mar 2017 20:38:58 +0000 (20:38 +0000)]
[NTDLL_APITEST] Add tests for RtlpEnsureBufferSize. CORE-11990

svn path=/trunk/; revision=74028

3 years ago[DISK]
Pierre Schweitzer [Thu, 2 Mar 2017 20:03:55 +0000 (20:03 +0000)]
[DISK]
Fix size checking for IOCTL_DISK_GET_DRIVE_GEOMETRY_EX, and only copy what's possible to fit in the buffer.
Also, make the code a bit more readable.

CORE-12858

svn path=/trunk/; revision=74027

3 years ago[DISK]
Pierre Schweitzer [Thu, 2 Mar 2017 19:39:07 +0000 (19:39 +0000)]
[DISK]
Fix return code when buffer is too small, as exposed in r74025.

CORE-12858

svn path=/trunk/; revision=74026

3 years ago[KERNEL32_APITEST]
Pierre Schweitzer [Thu, 2 Mar 2017 19:33:25 +0000 (19:33 +0000)]
[KERNEL32_APITEST]
Add tests for DeviceIoControl. These are mainly used to test our storage stack

CORE-12858

svn path=/trunk/; revision=74025

3 years ago[NTOS:PNP]
Thomas Faber [Thu, 2 Mar 2017 13:42:04 +0000 (13:42 +0000)]
[NTOS:PNP]
- Move generation of the device instance path into its own function

svn path=/trunk/; revision=74024

3 years ago[NTOS:PNP]
Thomas Faber [Thu, 2 Mar 2017 09:39:40 +0000 (09:39 +0000)]
[NTOS:PNP]
- Avoid memory leaks in IopActionInterrogateDeviceStack. Noticed by Vadim Galyant.
CORE-12732

svn path=/trunk/; revision=74023

3 years ago[UXTHEME] -Fix parsing negative integers. Improves the situation of the start button...
Giannis Adamopoulos [Thu, 2 Mar 2017 08:24:20 +0000 (08:24 +0000)]
[UXTHEME] -Fix parsing negative integers. Improves the situation of the start button with Lautus.

svn path=/trunk/; revision=74022

3 years ago[UMPNPMGR]
Eric Kohl [Wed, 1 Mar 2017 21:52:20 +0000 (21:52 +0000)]
[UMPNPMGR]
Fix a property id for a call to NtPlugPlayControl().

svn path=/trunk/; revision=74021

3 years ago[SCHEDSVC]
Eric Kohl [Wed, 1 Mar 2017 21:48:15 +0000 (21:48 +0000)]
[SCHEDSVC]
Set service status to SERVICE_STOP_PENDING before setting it to SERVICE_STOPPED.

svn path=/trunk/; revision=74020

3 years ago[USETUP]
Eric Kohl [Wed, 1 Mar 2017 20:46:24 +0000 (20:46 +0000)]
[USETUP]
Fix unbootable system after recreating the boot partition
Patch by Wim Hueskens.
CORE-11232 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=74019

3 years ago[USER32]: Now for the real fix: Initialize lpLibFileName and pCtx in User32CreateWind...
Hermès Bélusca-Maïto [Wed, 1 Mar 2017 19:36:51 +0000 (19:36 +0000)]
[USER32]: Now for the real fix: Initialize lpLibFileName and pCtx in User32CreateWindowEx prior to calling ClassNameToVersion.
This avoid passing invalid parameters to VersionRegisterClass (and subsequent functions) afterwards.
Fix suggested by Mark Jansen, thanks!
CORE-12855

svn path=/trunk/; revision=74018

3 years ago[USER32]: Fix formatting in User32CreateWindowEx, no code changes.
Hermès Bélusca-Maïto [Wed, 1 Mar 2017 19:23:27 +0000 (19:23 +0000)]
[USER32]: Fix formatting in User32CreateWindowEx, no code changes.

svn path=/trunk/; revision=74017

3 years ago[NTOS:FORMATTING]
Thomas Faber [Wed, 1 Mar 2017 19:07:13 +0000 (19:07 +0000)]
[NTOS:FORMATTING]
- Fix spacing in IopActionInterrogateDeviceStack. No code changes.

svn path=/trunk/; revision=74016

3 years ago[NtUser]
James Tabor [Wed, 1 Mar 2017 16:51:13 +0000 (16:51 +0000)]
[NtUser]
- Move functions around.

svn path=/trunk/; revision=74015

3 years ago[USBSTOR]
Thomas Faber [Wed, 1 Mar 2017 13:51:18 +0000 (13:51 +0000)]
[USBSTOR]
- Fix error check in USBSTOR_SelectConfigurationAndInterface. CID 515249

svn path=/trunk/; revision=74014

3 years ago[NTOS:IO]
Thomas Faber [Wed, 1 Mar 2017 13:10:52 +0000 (13:10 +0000)]
[NTOS:IO]
- Avoid event leak in NtQueryInformationFile. CID 716584

svn path=/trunk/; revision=74013

3 years ago[COMCTL32] -Add initial implementation for BCM_GETIDEALSIZE and support to draw butto...
Giannis Adamopoulos [Wed, 1 Mar 2017 11:49:59 +0000 (11:49 +0000)]
[COMCTL32] -Add initial implementation for BCM_GETIDEALSIZE and support to draw buttons with image lists. This is still WIP and needs tons of new tests. Crappy themes will be displayed like crap for now.

svn path=/trunk/; revision=74012

3 years ago[ACPICA]
Thomas Faber [Wed, 1 Mar 2017 11:36:19 +0000 (11:36 +0000)]
[ACPICA]
- Update to version 20170119, since the February version needs more work.
CORE-12833 #resolve

svn path=/trunk/; revision=74011

3 years ago[MSACM32]
Thomas Faber [Wed, 1 Mar 2017 10:54:59 +0000 (10:54 +0000)]
[MSACM32]
- Free session driver instance using the correct heap. Fixes crash in msacm32_winetest.
- Remove obsolete diff file

svn path=/trunk/; revision=74010