Thomas Faber [Thu, 19 Feb 2015 12:55:57 +0000 (12:55 +0000)]
[KMTESTS:RTL]
- Add some simple tests for RtlRaiseStatus to the RtlException test
- Add missing volatile in (disabled) stack overflow test that caused an infinite loop on GCC builds
CORE-8773
svn path=/trunk/; revision=66351
James Tabor [Thu, 19 Feb 2015 02:03:53 +0000 (02:03 +0000)]
[NtUser]
- Fix wine msg test_SetParent tests. See CORE-7447. Show owned pop up code was added for later testing.
svn path=/trunk/; revision=66350
Jérôme Gardou [Wed, 18 Feb 2015 21:27:40 +0000 (21:27 +0000)]
[CRYPT32]
- Addenratum to r64026: Merge the certificate stores for real.
CORE-5675 #resolve
svn path=/trunk/; revision=66349
Pierre Schweitzer [Wed, 18 Feb 2015 19:52:04 +0000 (19:52 +0000)]
[ROSAUTOTESTS]
Remove redundant GetTickCount() call
svn path=/trunk/; revision=66348
Thomas Faber [Wed, 18 Feb 2015 13:18:30 +0000 (13:18 +0000)]
[GDI32_APITEST]
- Refactor EnumFontFamilies test to be more generic, and check for some common expected system fonts. This shows that EnumFontFamilies behaves correctly, but that we're missing the System font in the enumeration.
CORE-9222
svn path=/trunk/; revision=66347
Thomas Faber [Wed, 18 Feb 2015 11:44:01 +0000 (11:44 +0000)]
[MSXML3_WINETEST]
- Re-enable test_save
CORE-6738 ROSTESTS-82
svn path=/trunk/; revision=66346
Thomas Faber [Wed, 18 Feb 2015 11:20:37 +0000 (11:20 +0000)]
[GDIPLUS_WINETESTS]
- Re-enable test_font_metrics, test_logfont and test_fontfamily.
CORE-6660
ROSTESTS-79 CORE-6643 #resolve
- Skip test_font_substitution instead.
ROSTESTS-154
svn path=/trunk/; revision=66345
Thomas Faber [Wed, 18 Feb 2015 10:50:00 +0000 (10:50 +0000)]
[GDIPLUS_WINETEST]
- Re-enable test_string_functions
CORE-6659 ROSTESTS-78 #resolve
svn path=/trunk/; revision=66344
Thomas Faber [Wed, 18 Feb 2015 10:06:46 +0000 (10:06 +0000)]
[WININET_WINETEST]
- Re-enable test_cert_struct in test_secure_connection
ROSTESTS-121 #resolve
svn path=/trunk/; revision=66343
Jérôme Gardou [Tue, 17 Feb 2015 20:41:51 +0000 (20:41 +0000)]
[WIN32SS/NTGDI]
- Reject bits data early in SetBitmapBits when it's clear that they can't fit in the destination bitmap.
Fixes ugly Office 2007 rulers showing garbage.
svn path=/trunk/; revision=66342
Jérôme Gardou [Tue, 17 Feb 2015 20:41:47 +0000 (20:41 +0000)]
[NTOS/SE]
- Properly dereference thread object in NtOpenThreadTokenEx
svn path=/trunk/; revision=66341
Jérôme Gardou [Tue, 17 Feb 2015 20:41:40 +0000 (20:41 +0000)]
[NTOS]
- Properly close handle thread when failing to start it.
svn path=/trunk/; revision=66340
Thomas Faber [Tue, 17 Feb 2015 18:37:24 +0000 (18:37 +0000)]
[PSDK]
- Move OFN_DONTADDTORECENT and OFN_ENABLEINCLUDENOTIFY to commdlg.h where they belong
svn path=/trunk/; revision=66339
Thomas Faber [Tue, 17 Feb 2015 18:23:06 +0000 (18:23 +0000)]
[WMIUTILS]
- The dll belongs in system32\wbem; make it so. Spotted by Robert Naumann.
CORE-9212
svn path=/trunk/; revision=66338
Jérôme Gardou [Tue, 17 Feb 2015 15:08:54 +0000 (15:08 +0000)]
[WS2_32]
- Do not free resources at process termination.
- Free the provider catalog after the handle table, since the latter references the former.
svn path=/trunk/; revision=66337
Jérôme Gardou [Tue, 17 Feb 2015 15:08:47 +0000 (15:08 +0000)]
[RTL/DPH]
- Do not merge memory blocks if they don't belong to the same VM "region" (ie not allocated from the same NtAllocateVirtualMemory call)
Fixes failures of ZwProtectVirtualMemory calls.
Bugs see DPH rollin', they hatin'
svn path=/trunk/; revision=66336
Thomas Faber [Tue, 17 Feb 2015 15:07:56 +0000 (15:07 +0000)]
[WMIUTILS]
- Import from Wine 1.7.27 (or your choice of any later version)
CORE-9212 #resolve
svn path=/trunk/; revision=66335
Jérôme Gardou [Tue, 17 Feb 2015 14:19:05 +0000 (14:19 +0000)]
[NTOSKRNL/MM]
- MiIsEntireRangeCommitted: Ensure the PTE we are checking is really faulted in.
- Prefer MiPteToPde and MiPdeToPte (which should really be called MiFirstPteInPde) instead of MiAddressToPte and MiPteToAddress
Fixes weird failed ASSERT in page fault handler when using DPH.
svn path=/trunk/; revision=66334
Thomas Faber [Tue, 17 Feb 2015 12:59:22 +0000 (12:59 +0000)]
[EXPLORER]
- Load default application icon and display it in the taskbar for windows that have no icon. Fixes "GetIconInfo failed" debug prints all over the place (and looks prettier).
CORE-9211 #resolve
svn path=/trunk/; revision=66333
James Tabor [Tue, 17 Feb 2015 08:25:43 +0000 (08:25 +0000)]
[NtUser]
- Fix wine msg test_SetFocus tests. Use send message for WM_WINDOWPOSCHANGING. If nothing has been drawn and the no position changed bits set, set no Z order and no redraw. See CORE-7447.
svn path=/trunk/; revision=66332
Thomas Faber [Tue, 17 Feb 2015 08:08:04 +0000 (08:08 +0000)]
[WIN32K:NTUSER]
- Remove unneeded casts, fix format specifiers, and clarify some logic in co_MsqSendMessage
svn path=/trunk/; revision=66331
James Tabor [Tue, 17 Feb 2015 06:42:27 +0000 (06:42 +0000)]
[User32]
- Add missing wParam for hooks. See CORE-7447.
svn path=/trunk/; revision=66330
Jérôme Gardou [Mon, 16 Feb 2015 22:40:15 +0000 (22:40 +0000)]
[RSHELL]
- Fix use after free (and spanish style issues ;-) )
svn path=/trunk/; revision=66329
Jérôme Gardou [Mon, 16 Feb 2015 22:33:15 +0000 (22:33 +0000)]
[EXPLORER]
- Prperly initialize members in CStartMenu constructor.
svn path=/trunk/; revision=66328
Jérôme Gardou [Mon, 16 Feb 2015 22:33:08 +0000 (22:33 +0000)]
[RSHELL]
- Do not free invalid data.
See MSDN SHBindToParent documentation for details.
svn path=/trunk/; revision=66327
Jérôme Gardou [Mon, 16 Feb 2015 21:15:55 +0000 (21:15 +0000)]
[NTDLL_APITEST]
- Add tests showing windows behaviour in case of stack overflow.
svn path=/trunk/; revision=66326
Jérôme Gardou [Mon, 16 Feb 2015 21:15:27 +0000 (21:15 +0000)]
[NTDLL_APITEST]
- Add tests showing how NtAllocateVirtualMemory and NtQueryVirtualMemory work together
svn path=/trunk/; revision=66325
Jérôme Gardou [Mon, 16 Feb 2015 21:13:36 +0000 (21:13 +0000)]
[KERNEL32]
- Fix mixed arguments.
CORE-9201 #resolve
CORE-9124 #comment Please retest
svn path=/trunk/; revision=66324
Jérôme Gardou [Mon, 16 Feb 2015 21:12:51 +0000 (21:12 +0000)]
[KERNEL32]
Revert r64525 - Always allocate a guard page at the bottom of the stack.
svn path=/trunk/; revision=66323
Daniel Reimer [Mon, 16 Feb 2015 20:44:12 +0000 (20:44 +0000)]
... ANSI vs UTF-8... sorry
svn path=/trunk/; revision=66322
Daniel Reimer [Mon, 16 Feb 2015 20:27:29 +0000 (20:27 +0000)]
[SERVICES]
German translation & Small fix I think which should be right for English ^^
svn path=/trunk/; revision=66321
Thomas Faber [Mon, 16 Feb 2015 16:17:22 +0000 (16:17 +0000)]
[BOOTCDREGTEST]
- Add /n switch to rosautotest invocation to see how much of a difference it makes on testbot
svn path=/trunk/; revision=66320
Eric Kohl [Mon, 16 Feb 2015 15:33:34 +0000 (15:33 +0000)]
[NTOSKRNL]
NtQueryInformationFile: Implement the FileModeInformation case according to 'File System Internals' page 485.
svn path=/trunk/; revision=66319
Thomas Faber [Mon, 16 Feb 2015 14:55:39 +0000 (14:55 +0000)]
[ROSAUTOTEST]
- Add /n option to suppress console output. May or may not help to speed up testbot runs, but can't hurt to have in here.
svn path=/trunk/; revision=66318
Pierre Schweitzer [Mon, 16 Feb 2015 13:40:13 +0000 (13:40 +0000)]
[WMISVC]
Silence a DPRINT
svn path=/trunk/; revision=66317
Thomas Faber [Mon, 16 Feb 2015 13:17:04 +0000 (13:17 +0000)]
[ROSAUTOTEST]
- Abstract unidirectional anonymous pipes into a CPipe class
- Abstract a process with redirected output into a CPipedProcess class
- Use these abstractions to avoid polling for output from test processes. Instead, use blocking read operations to yield the CPU while waiting for data.
ROSTESTS-144 #resolve
svn path=/trunk/; revision=66316
Eric Kohl [Mon, 16 Feb 2015 11:52:43 +0000 (11:52 +0000)]
[SERVICES]
Remove unused prototype.
svn path=/trunk/; revision=66315
Eric Kohl [Mon, 16 Feb 2015 11:47:40 +0000 (11:47 +0000)]
[SERVICES]
Replace hard-coded strings by string resources.
svn path=/trunk/; revision=66314
Thomas Faber [Mon, 16 Feb 2015 09:11:13 +0000 (09:11 +0000)]
[PSDK]
- Add missing OUT_SCREEN_OUTLINE_PRECIS, OUT_PS_ONLY_PRECIS & CLIP_DFA_DISABLE definitions aka fix build
svn path=/trunk/; revision=66313
Thomas Faber [Mon, 16 Feb 2015 09:06:45 +0000 (09:06 +0000)]
[GDI32_WINETEST]
- Sync to Wine 1.7.36
- Properly disable test_dib_formats. ROSTESTS-152, CORE-5922
- Fix skip message in test_mono_bitmap not to point to a resolved bug. ROSTESTS-153, CORE-5922
- Re-enable font tests that were left skipped even though the associated bug is correctly marked as resolved. ROSTESTS-8
svn path=/trunk/; revision=66312
Thomas Faber [Mon, 16 Feb 2015 07:37:19 +0000 (07:37 +0000)]
[USER32_WINETEST]
- Re-enable test_shell_window
ROSTESTS-23
svn path=/trunk/; revision=66311
James Tabor [Mon, 16 Feb 2015 03:32:46 +0000 (03:32 +0000)]
[Win32ss]
- Fix wine msg:test_winevents.
- Fix global hooks while sending to same process different thread. Yes, interesting.
- Fix event hooks, use posting (faster) instead of sending. This fixed a problem while sending to the same thread.
svn path=/trunk/; revision=66310
James Tabor [Mon, 16 Feb 2015 03:16:01 +0000 (03:16 +0000)]
[NtUser]
- This fixes use after free linking in the message system. See CORE-9173. Dedicated to Thomas Faber.
svn path=/trunk/; revision=66309
Hermès Bélusca-Maïto [Sun, 15 Feb 2015 23:55:52 +0000 (23:55 +0000)]
[KERNEL32][NTUSER]: Shut up some dprints.
CORE-9186
svn path=/trunk/; revision=66308
Eric Kohl [Sun, 15 Feb 2015 23:06:30 +0000 (23:06 +0000)]
[NTOSKRNL]
NtQueryInformationFile: Implement FileAccessInformation and FileAlignmentInformation cases according to 'File System Internals' page 485.
svn path=/trunk/; revision=66307
Hermès Bélusca-Maïto [Sun, 15 Feb 2015 22:57:40 +0000 (22:57 +0000)]
[WINSRV]
- Part 2/2 of SrvLogon (see r66303): load the per-user shutdown timeouts.
- Retrieve those per-user shutdown timeouts from the registry when the user logs on, adapted from Alex' shutdown patch plus existing code.
- Commit the main part of shutdown code (finally!), still unfinished yet:
* Need to switch to the desktop where the hanging GUI app's window is present,
* Need to deal with apps from other users
* What about SYSTEM processes?
* What about console processes?
- Reuse the old timeout code.
- Fix the sending of WM_QUERYENDSESSION and WM_ENDSESSION messages (this is done by win32k directly; for that winsrv needs just to send one WM_CLIENTSHUTDOWN message with the correct wParam parameter).
Part 13/X
CORE-8322 #comment Big commit in revision 66306!
svn path=/trunk/; revision=66306
Hermès Bélusca-Maïto [Sun, 15 Feb 2015 22:29:50 +0000 (22:29 +0000)]
[NTOS]: Less "magic" indices.
svn path=/trunk/; revision=66305
Thomas Faber [Sun, 15 Feb 2015 22:20:34 +0000 (22:20 +0000)]
[NTOS]
- In ExpReleaseOrWaitForKeyedEvent, always restore previous values for ETHREAD::KeyedWaitValue and ETHREAD::KeyedWaitChain, as these fields have alternative meanings outside of keyed events
- Add missing list walk in ExpReleaseOrWaitForKeyedEvent
- In Nt(WaitFor|Release)KeyedEvent, refuse keys that are not two-byte aligned as shown by Wine tests
- Don't forget to set KTHREAD::Process on thread creation
Fixes hang when running ntdll_winetest:om as well as failing tests.
ROSTESTS-118 #resolve
svn path=/trunk/; revision=66304
Hermès Bélusca-Maïto [Sun, 15 Feb 2015 21:56:03 +0000 (21:56 +0000)]
[USER32]
Implement SrvLogon (client-side), called by the SetWindowStationUser API (called by winlogon) when a user logs-on (or off).
See also http://www.openrce.org/reference_library/win32_call_chains/2003SP1/USER32/SetWindowStationUser and http://www.openrce.org/reference_library/win32_call_chains/2003SP1/USER32/Logon for details.
Part 1/2
svn path=/trunk/; revision=66303
Thomas Faber [Sun, 15 Feb 2015 18:20:59 +0000 (18:20 +0000)]
[ADVAPI32_WINETEST]
- Skip over service timeout tests because they take too long. This is not a bug, the tests are completing successfully -- however they are designed to cause service manager timeouts and take two minutes in doing so. Testbot time is too valuable to do this on every commit.
ROSTESTS-151
svn path=/trunk/; revision=66302
David Quintana [Sun, 15 Feb 2015 18:05:34 +0000 (18:05 +0000)]
[SHELL32]
* Include enumeration of hidden files in the default shell view, until we have a proper way of toggling it.
CORE-9192
svn path=/trunk/; revision=66301
Thomas Faber [Sun, 15 Feb 2015 17:57:34 +0000 (17:57 +0000)]
[TDILIB][IPHLPAPI][WSHTCPIP]
- Request only the access rights that are actually required in openTcpFile. Fixes many should-be access denied errors originating from netshell. While this doesn't fix the root cause of CORE-9172, it is a required step if we ever want netshell to work for non-Admin users.
CORE-9172
svn path=/trunk/; revision=66300
Thomas Faber [Sun, 15 Feb 2015 17:54:41 +0000 (17:54 +0000)]
[OLEAUT32_WINETEST]
- Re-enable test_apm and test_enhmetafile.
ROSTESTS-2
svn path=/trunk/; revision=66299
Thomas Faber [Sun, 15 Feb 2015 17:50:18 +0000 (17:50 +0000)]
[URLMON_WINETEST]
- Re-enable protocol test.
ROSTESTS-38
svn path=/trunk/; revision=66298
Hermès Bélusca-Maïto [Sun, 15 Feb 2015 17:28:41 +0000 (17:28 +0000)]
[MSISERVER]: Fix few things after commits 66278 and 66279.
[WMISVC]: Add RPCSS dependency (ok it's not really used now since wmisvc is a stub, but it's for the future).
svn path=/trunk/; revision=66297
Pierre Schweitzer [Sun, 15 Feb 2015 17:22:13 +0000 (17:22 +0000)]
[BOOTDATA]
Add missing quote.
Spotted by Hermès
svn path=/trunk/; revision=66296
Pierre Schweitzer [Sun, 15 Feb 2015 17:19:57 +0000 (17:19 +0000)]
[WMISVC]
Add a stub for the "Windows Management Infrastructure" service.
This helps the Intel PRO eth card installer to go a bit farther
svn path=/trunk/; revision=66295
Sylvain Petreolle [Sun, 15 Feb 2015 16:41:08 +0000 (16:41 +0000)]
Remove duplicated flag KLF_SETFORPROCESS.
Patch by Kudratov Olimjon.
CORE-8545
svn path=/trunk/; revision=66294
Timo Kreuzer [Sun, 15 Feb 2015 16:18:18 +0000 (16:18 +0000)]
[FRAMEDYN]
Fix copypasta in the spec file
svn path=/trunk/; revision=66293
Hermès Bélusca-Maïto [Sun, 15 Feb 2015 16:11:08 +0000 (16:11 +0000)]
Forgot those files too.
svn path=/trunk/; revision=66292
Hermès Bélusca-Maïto [Sun, 15 Feb 2015 16:08:36 +0000 (16:08 +0000)]
[WINSRV]: Remove the now-unneeded switch-app dialog that was moved to user32 since revision 51459.
svn path=/trunk/; revision=66291
Sylvain Petreolle [Sun, 15 Feb 2015 15:49:33 +0000 (15:49 +0000)]
Fix sysfile association.
Patch by Kudratov Olimjon.
CORE-8545
svn path=/trunk/; revision=66290
Thomas Faber [Sun, 15 Feb 2015 15:42:00 +0000 (15:42 +0000)]
[INF]
- Save inf files as UTF-8 in SVN, convert them to UTF-16 at build time as needed.
CORE-8221
svn path=/trunk/; revision=66289
Thomas Faber [Sun, 15 Feb 2015 15:21:52 +0000 (15:21 +0000)]
[SHELL32]
- Rename "Insert" to "Paste" in CDefaultContextMenu
svn path=/trunk/; revision=66288
Timo Kreuzer [Sun, 15 Feb 2015 14:39:02 +0000 (14:39 +0000)]
[FRAMEDYN]
Fix compilation on x64
svn path=/trunk/; revision=66287
Timo Kreuzer [Sun, 15 Feb 2015 11:24:52 +0000 (11:24 +0000)]
[LIBS]
Fix some MSVC warnings (and potential bugs) regarding signed/unsigned comparison.
svn path=/trunk/; revision=66286
Timo Kreuzer [Sun, 15 Feb 2015 11:22:29 +0000 (11:22 +0000)]
[PSDK]
Add _SH_ to processor definitions, fix some processor #ifdefs
Patch by Yuntian Zhang
CORE-7946 #resolve
svn path=/trunk/; revision=66285
Timo Kreuzer [Sun, 15 Feb 2015 11:21:31 +0000 (11:21 +0000)]
[SHELL32]
Fix prototype of COpenWithDialog::NoOpenDlgProc. DLGPROCs return INT_PTR, not BOOL. Fixes amd64 build.
svn path=/trunk/; revision=66284
Timo Kreuzer [Sun, 15 Feb 2015 11:13:30 +0000 (11:13 +0000)]
[KDVBOX]
Fix amd64 build
svn path=/trunk/; revision=66283
Timo Kreuzer [Sun, 15 Feb 2015 11:10:09 +0000 (11:10 +0000)]
[FREELDR]
Fix non-x86 build
svn path=/trunk/; revision=66282
Thomas Faber [Sun, 15 Feb 2015 10:23:21 +0000 (10:23 +0000)]
[KMTESTS]
- Add KmtGetSystemRoutineAddress and use it to avoid importing functions that are not available in some versions of Windows. This allows running kmtests on Windows XP SP3 (and probably Server 2003 SP0/SP2). Note that failures on XP are still not valid bugs, this is purely for convenience! Dedicated to Jérôme.
ROSTESTS-150
svn path=/trunk/; revision=66281
James Tabor [Sun, 15 Feb 2015 10:14:18 +0000 (10:14 +0000)]
[User32]
- Move notify window event to a better location for passing wine msg:test_winevents. See CORE-7447.
svn path=/trunk/; revision=66280
Pierre Schweitzer [Sun, 15 Feb 2015 10:02:57 +0000 (10:02 +0000)]
[BOOTDATA]
Errm...
Spotted by Giannis
svn path=/trunk/; revision=66279
Pierre Schweitzer [Sun, 15 Feb 2015 09:59:29 +0000 (09:59 +0000)]
[BOOTDATA]
msiexec can be used as a service (and might be required by some MSIs)
svn path=/trunk/; revision=66278
Thomas Faber [Sun, 15 Feb 2015 09:29:32 +0000 (09:29 +0000)]
[KMTESTS:KE]
- Enable KeSpinLock test that apparently never made it into testlist.c for some reason?
svn path=/trunk/; revision=66277
Johannes Anderwald [Sun, 15 Feb 2015 09:03:08 +0000 (09:03 +0000)]
[INF]
- add wdmaudio.inf
svn path=/trunk/; revision=66276
Hermès Bélusca-Maïto [Sun, 15 Feb 2015 02:07:23 +0000 (02:07 +0000)]
[WINLOGON][USER32]
Fix the explanations of how Windows/ReactOS should shut down (it's winlogon itself that calls NtShutdownSystem, not something else; that story about "SMSS API #1" concerns the SMSS API SmpSessionCompleteApi called by the helper function SmSessionComplete which is in turn called by CSRSS function CsrDereferenceNtSession, when all win32 processes are gone, as it should).
The webpage http://www.reactos.org/wiki/ShutdownProcess should be corrected for.
[USER32]
Whitespace fixes for winstation code.
svn path=/trunk/; revision=66275
Timo Kreuzer [Sun, 15 Feb 2015 00:26:41 +0000 (00:26 +0000)]
[NTOSKRNL]
Demote the "HACK: RemainingAccess = 0x%08lx DesiredAccess = 0x%08lx\n" from DPRINT1 to DPRINT, since it's massively spamming the log.
See CORE-9184
svn path=/trunk/; revision=66274
Timo Kreuzer [Sun, 15 Feb 2015 00:05:50 +0000 (00:05 +0000)]
[WIN32K]
In NtGdiGetDIBitsInternal limit the size of what is being copied back to to usermode to the cjMaxInfo parameter. Fixes crash of Firefox when downloading files.
CORE-8895 #resolve
svn path=/trunk/; revision=66273
Pierre Schweitzer [Sat, 14 Feb 2015 20:55:47 +0000 (20:55 +0000)]
[NTFS]
Query the value of NtfsMftZoneReservation on mount.
Not used yet.
CORE-8725
svn path=/trunk/; revision=66272
Hermès Bélusca-Maïto [Sat, 14 Feb 2015 19:56:04 +0000 (19:56 +0000)]
[SHELL32]
- magic_value--;
- Don't assign a desktop background colour by default. So that we can get the safe-mode background working (in safe mode), while having the default desktop background colours in normal situations.
Patch by Giannis.
svn path=/trunk/; revision=66271
Thomas Faber [Sat, 14 Feb 2015 19:14:32 +0000 (19:14 +0000)]
[RTL]
- Implement RtlIpv4StringToAddressExW. Patch by Mark Jansen.
CORE-6490
svn path=/trunk/; revision=66270
Timo Kreuzer [Sat, 14 Feb 2015 19:07:36 +0000 (19:07 +0000)]
[DRIVERS]
Fix a few MSVC warnings
svn path=/trunk/; revision=66269
Timo Kreuzer [Sat, 14 Feb 2015 18:58:52 +0000 (18:58 +0000)]
[CMAKE]
Disable MSVC linker warning LNK4078 (multiple sections found with different attributes) for INIT sections.
svn path=/trunk/; revision=66268
Timo Kreuzer [Sat, 14 Feb 2015 17:04:42 +0000 (17:04 +0000)]
[PSDK]
Add #ifdef include guards to winnt.h. RC doesn't seem to support #pragma once and emits a redefinition warning, since with RC we first include winnt.h without STRICT defined, then again from windef.h with STRICT defined.
svn path=/trunk/; revision=66267
Timo Kreuzer [Sat, 14 Feb 2015 15:44:44 +0000 (15:44 +0000)]
[CMAKE]
- Disable warning C4800: forcing value to bool 'true' or 'false' (performance warning). This is emitted when assigning an integer value to a C++ bool, which is always true (1) or false (0), so assigning an integer to it, will result in an implicit comparison against 0. But "fixing" this warning by adding an explicit comparison ("bool f = (i != 0);") will actually result in LESS efficient code (for whatever reasons). So this warning can be considered entirely useless and counter productive.
- Remove C4018 (signed/unsigned mismatch) from the TODO in the disable list. A comparison between an unsigned and a signed value will very likely result in wrong behavior and can easily cause hard to spot security bugs (e.g. when doing overflow checks). It is also often easy to fix.
svn path=/trunk/; revision=66266
Pierre Schweitzer [Sat, 14 Feb 2015 15:41:44 +0000 (15:41 +0000)]
[NTFS]
NtfsMoonWalkID():
- Do not allow opening a file by ID if it's not in use any longer
- Do not attempt to create the full path, if an error occured during walk
svn path=/trunk/; revision=66265
Pierre Schweitzer [Sat, 14 Feb 2015 15:35:35 +0000 (15:35 +0000)]
[NTFS]
Simplify the implementation of the "Open by ID" feature of our driver.
Instead of creating singleton FCB not linked to the rest of FS tree, just walk the whole path down, to recreate it.
This doesn't make nfi work properly though. Will investigate more.
CORE-8725
svn path=/trunk/; revision=66264
Timo Kreuzer [Sat, 14 Feb 2015 14:28:02 +0000 (14:28 +0000)]
[SPEC2DEF]
Silence warning about ignored C++ redirections
svn path=/trunk/; revision=66263
Timo Kreuzer [Sat, 14 Feb 2015 14:07:50 +0000 (14:07 +0000)]
[GDI32_APITEST]
Add additional tests for CreateBitmap and fix a test.
Patch by Victor Martinez
ROSTESTS-56 #resolve
svn path=/trunk/; revision=66262
David Quintana [Sat, 14 Feb 2015 14:00:24 +0000 (14:00 +0000)]
[BROWSEUI]
* Convert some leftover DbgPrints to TRACEs and ERRs.
svn path=/trunk/; revision=66261
Timo Kreuzer [Sat, 14 Feb 2015 13:24:54 +0000 (13:24 +0000)]
[GDI32_APITEST]
Fix GCC build
svn path=/trunk/; revision=66260
Timo Kreuzer [Sat, 14 Feb 2015 13:19:02 +0000 (13:19 +0000)]
[GDI32_APITEST]
Add tests for OffsetRgn, PaintRgn and FrameRgn, fix 1BPP DIB creation in InitStuff()
svn path=/trunk/; revision=66259
Thomas Faber [Sat, 14 Feb 2015 12:59:16 +0000 (12:59 +0000)]
[COM_APITEST]
- Add classes found in Wine's shell32_classes.idl and browseui_classes.idl
svn path=/trunk/; revision=66258
Thomas Faber [Sat, 14 Feb 2015 12:03:58 +0000 (12:03 +0000)]
[PACKAGES]
- Copy libwinpthread-1.dll if present instead of forcing the use of a specific set of GnuTLS binaries. Partially reverts r66110. Should fix testbot problems (mshtml_winetest:events in particular).
CORE-9167
svn path=/trunk/; revision=66257
Timo Kreuzer [Sat, 14 Feb 2015 11:25:02 +0000 (11:25 +0000)]
[GDI32_APITEST]
Fix InitStuff(), declare the 32 bpp DIB array 2 dimensional and make it 8x8 in size.
svn path=/trunk/; revision=66256
Timo Kreuzer [Sat, 14 Feb 2015 11:09:31 +0000 (11:09 +0000)]
[CMAKE]
Fix the fix. (tm)
svn path=/trunk/; revision=66255
Timo Kreuzer [Sat, 14 Feb 2015 11:01:58 +0000 (11:01 +0000)]
[CMAKE]
Fix bugs in start/end_module_group, found by Jérôme.
svn path=/trunk/; revision=66254
Pierre Schweitzer [Sat, 14 Feb 2015 08:02:08 +0000 (08:02 +0000)]
[IPHLPAPI]
Add the missing loop iterator in GetAdaptersAddresses().
This fixes infinite loop, and fixes Firefox 3.6 boot.
CORE-9051 #resolve #comment Fixed in r66253
svn path=/trunk/; revision=66253
Hermès Bélusca-Maïto [Sat, 14 Feb 2015 05:27:55 +0000 (05:27 +0000)]
[WINLOGON]
- Reshuffle a bit some code.
- Never fail if the kill-COM-processes thread fails to be created.
- WlxLogoff GINA callback *must* be called *after* our logoff handling (with HandleLogoff). This is what happens on Windows (just add breakpoints on ExitWindowsEx and on WlxIsLogoffOk and WlxLogoff, and enable winlogon tracing).
[WIN32K]
Rename a flag to something more meaningful, and fix a flag filtering bug: lParams = wParam & something; ---> lParams = lParam & something; (the wParam is used for something else).
Part 12/X
CORE-8322
svn path=/trunk/; revision=66252