Pierre Schweitzer [Mon, 6 May 2013 08:10:53 +0000 (08:10 +0000)]
[KMTESTS:FSRTL]
Add more tests for MCBs
svn path=/trunk/; revision=58961
Pierre Schweitzer [Sun, 5 May 2013 22:31:17 +0000 (22:31 +0000)]
[RTL]
Finally reenable RtlAcquirePrivilege and RtlReleasePrivilege now that they are fixed.
[KERNEL32]
Remove the hacks in SetSystemTime() and SetLocalTime() now that RtlAcquirePrivilege is working properly.
[SYSSETUP]
Remove the hack for privileges in SetSystemLocalTime() now that SetLocalTime() can properly acquire needed privilege.
CORE-7168 #comment Fixed with r58960 #resolve
svn path=/trunk/; revision=58960
Pierre Schweitzer [Sun, 5 May 2013 22:19:54 +0000 (22:19 +0000)]
[RTL]
When we are impersonating, also set the flag, so that on release, we can kill it.
This hopefully fixes 2nd stage and the whole mess it was causing in privileges.
svn path=/trunk/; revision=58959
Pierre Schweitzer [Sun, 5 May 2013 20:19:23 +0000 (20:19 +0000)]
[RTL]
Properly define the loop for privileges adjustement.
Spotted & fixed by Thomas.
svn path=/trunk/; revision=58955
Pierre Schweitzer [Sun, 5 May 2013 20:01:14 +0000 (20:01 +0000)]
[KERNEL32]
Also "fix" hack of RtlAcquirePrivilege in SetSystemTime(). Spotted by Thomas.
Note for syssetup/rtl/kernel32 devs:
Make it crystal clear that this is a hack and has to be deleted once RAP is fine.
Also note that for SetLocalTime() and 2nd stage, syssetup acquires the privilege itself
in SetSystemLocalTime() before calling SetLocalTime().
This will also have to be deleted once RAP is working fine. Otherwise it will keep failing:
it is not possible to acquire a privilege already held.
svn path=/trunk/; revision=58953
Pierre Schweitzer [Sun, 5 May 2013 19:24:25 +0000 (19:24 +0000)]
[RTL]
Don't allocate an extra privilege entry when not required.
Still doesn't fix issue.
svn path=/trunk/; revision=58949
Pierre Schweitzer [Sun, 5 May 2013 17:32:00 +0000 (17:32 +0000)]
[RTL]
Add a few DPRINTs.
Fix a bug where last status was overrided in case of failure.
Still commented out...
svn path=/trunk/; revision=58946
Pierre Schweitzer [Sun, 5 May 2013 16:38:41 +0000 (16:38 +0000)]
[KERNEL32]
If you workaround RtlAcquirePrivilege, do it properly!
Will prevent bad address freeing...
svn path=/trunk/; revision=58945
Thomas Faber [Sun, 5 May 2013 15:04:49 +0000 (15:04 +0000)]
[HIDCLASS]
- Don't return inconsistent status values from HidClass_DeviceControl
svn path=/trunk/; revision=58944
Johannes Anderwald [Sun, 5 May 2013 14:51:27 +0000 (14:51 +0000)]
[HID]
- Fix bug in irp completion handler
CORE-7069
svn path=/trunk/; revision=58943
Johannes Anderwald [Sun, 5 May 2013 14:43:39 +0000 (14:43 +0000)]
[LIBUSB]
- Remove useless debug prints, which violate the spec
- Fix identation
CORE-7009
svn path=/trunk/; revision=58942
Sylvain Petreolle [Sun, 5 May 2013 13:09:46 +0000 (13:09 +0000)]
[FUSION]
Remove baseaddress to fix address conflicts.
Reenable creation of InstallRoot .NET key in its REG_SZ form.
svn path=/trunk/; revision=58941
Thomas Faber [Sun, 5 May 2013 12:18:49 +0000 (12:18 +0000)]
[KMTESTS:MM]
- Fix 64-bit warnings. Patch by Nikolay Borisov.
ROSTESTS-112 #resolve
svn path=/trunk/; revision=58940
Hermès Bélusca-Maïto [Sun, 5 May 2013 10:18:52 +0000 (10:18 +0000)]
[CDMAKE]
Reset the "volume expiration date" and the "volume effective date". They are not used.
See http://wiki.osdev.org/ISO_9660#The_Primary_Volume_Descriptor for more information.
svn path=/trunk/; revision=58939
Pierre Schweitzer [Sun, 5 May 2013 09:55:32 +0000 (09:55 +0000)]
[RTL]
Comment out RtlAcquirePrivilege & RtlReleasePrivilege for the moment.
It appears we are overflowing memory and thus corrupting registry, that breaks ReactOS install.
To be investigated...
svn path=/trunk/; revision=58938
Pierre Schweitzer [Sun, 5 May 2013 09:30:12 +0000 (09:30 +0000)]
[RTL]
Implement RtlAcquirePrivilege and RtlReleasePrivilege.
Reviewed by Aleksey
svn path=/trunk/; revision=58937
Timo Kreuzer [Sun, 5 May 2013 09:02:36 +0000 (09:02 +0000)]
{RTL]
- Implement RtlFillMemoryUlonglong
- Add missing bitmap64.c
- Fix 64bit bitmap code
svn path=/trunk/; revision=58936
Eric Kohl [Sun, 5 May 2013 00:53:25 +0000 (00:53 +0000)]
[MSV1_0]
Add token data from the old logon code.
svn path=/trunk/; revision=58934
Eric Kohl [Sun, 5 May 2013 00:39:58 +0000 (00:39 +0000)]
[LSASRV]
Free additional data returned by calls to LsaApLogonUser/Ex/2.
svn path=/trunk/; revision=58933
Hermès Bélusca-Maïto [Sat, 4 May 2013 22:15:26 +0000 (22:15 +0000)]
[CDMAKE]
ISO images generated by cdmake have invalid time and date.
Patch by Aleksandar Andrejevic, aka. [TheFlash]
CORE-7163 #resolve #comment Committed in revision r58932, thanks for the patch ;)
svn path=/trunk/; revision=58932
Hermès Bélusca-Maïto [Sat, 4 May 2013 21:03:27 +0000 (21:03 +0000)]
[CONSRV]
Add heap diagnostic flags for the ConSrvHeap.
svn path=/trunk/; revision=58931
Amine Khaldi [Sat, 4 May 2013 20:43:16 +0000 (20:43 +0000)]
[PSDK]
* Add NT_CONSOLE_PROPS and NT_FE_CONSOLE_PROPS and fix EXP_SZ_LINK.
* Add SHELL_LINK_INFO_* and some Shell Link Extra Data structures (for IShellLinkDataList).
[USERINIT][CPLS][DLLS]
* Add the now necessary wincon.h inclusion.
* Brought to you by Dominik Hornung.
CORE-7162 #resolve #comment Committed in r58930. Danke !
svn path=/trunk/; revision=58930
Amine Khaldi [Sat, 4 May 2013 20:42:43 +0000 (20:42 +0000)]
[CRT]
* Annotate sys/utime.h.
svn path=/trunk/; revision=58929
Amine Khaldi [Sat, 4 May 2013 20:21:53 +0000 (20:21 +0000)]
[FUSION_WINETEST]
* Sync with Wine 1.5.26.
svn path=/trunk/; revision=58928
Amine Khaldi [Sat, 4 May 2013 20:21:39 +0000 (20:21 +0000)]
[FUSION]
* Sync with Wine 1.5.26.
svn path=/trunk/; revision=58927
Hermès Bélusca-Maïto [Sat, 4 May 2013 19:28:36 +0000 (19:28 +0000)]
[CONSRV]
Hack: To try to uncover a heap corruption in CONSRV, use our own heap instead of the (default) CSR heap, so that we won't corrupt it and obtain strange bugs thrown by memory allocation in csrsrv.
Thanks to Aleksandar Andrejevic, aka. [TheFlash] for having seen that.
See CORE-7157 for more information.
svn path=/trunk/; revision=58926
Hermès Bélusca-Maïto [Sat, 4 May 2013 15:31:19 +0000 (15:31 +0000)]
[CONSRV]
Be sure to use our local heap instead of the current application heap, to store the console title.
To simplify the code, I introduced helper functions based on well-known Rtl functions.
svn path=/trunk/; revision=58925
Jérôme Gardou [Sat, 4 May 2013 15:26:48 +0000 (15:26 +0000)]
[NTDLL_APITEST]
* Add tests for NtProtectVirtualMemory
svn path=/trunk/; revision=58924
Hermès Bélusca-Maïto [Sat, 4 May 2013 14:29:51 +0000 (14:29 +0000)]
Code formatting only
svn path=/trunk/; revision=58923
Hermès Bélusca-Maïto [Sat, 4 May 2013 14:27:09 +0000 (14:27 +0000)]
[CSRSRV]
- Code simplification.
- Remove unneeded casts.
- Fix comments.
svn path=/trunk/; revision=58922
Olaf Siejka [Sat, 4 May 2013 14:18:45 +0000 (14:18 +0000)]
[TRANSLATION]
- turkish translation update by Erdem Ersoy: CORE-7133;
- czech translation update by Radek Liska: CORE-6953;
- added polish translation of hostname;
svn path=/trunk/; revision=58921
Hermès Bélusca-Maïto [Sat, 4 May 2013 14:04:35 +0000 (14:04 +0000)]
Code reorganization only.
svn path=/trunk/; revision=58920
Pierre Schweitzer [Sat, 4 May 2013 09:23:52 +0000 (09:23 +0000)]
[KERNEL32]
Parameters of RtlAcquirePrivilege are not booleans
svn path=/trunk/; revision=58919
Thomas Faber [Sat, 4 May 2013 08:39:05 +0000 (08:39 +0000)]
[ATL]
- Simplify CComObject code. Fix warnings. Patch by Katayama Hirofumi MZ.
CORE-7105 #resolve
svn path=/trunk/; revision=58918
Thomas Faber [Sat, 4 May 2013 08:10:58 +0000 (08:10 +0000)]
[WININET_WINETEST]
- Hackfix hanging test. There's no benefit in having testbot take longer.
ROSTESTS-73 #comment Temporary timeout added in r58917 to prevent hanging.
svn path=/trunk/; revision=58917
Pierre Schweitzer [Fri, 3 May 2013 19:31:03 +0000 (19:31 +0000)]
[NTOSKRNL]
Prevent potential double free in loop.
Fixes CID 732510
svn path=/trunk/; revision=58916
Jérôme Gardou [Fri, 3 May 2013 18:28:34 +0000 (18:28 +0000)]
[PSDK]
* Add complete definition of KEY_INFORMATION_CLASS
[DDK]
* Add KEY_NAME_INFORMATION structure declaration
svn path=/trunk/; revision=58915
Jérôme Gardou [Fri, 3 May 2013 16:44:31 +0000 (16:44 +0000)]
[ADVAPI32]
- SEH-ize access to the data buffer in RegSetValueExW.
Fixes winetest crash
svn path=/trunk/; revision=58914
Amine Khaldi [Fri, 3 May 2013 09:57:19 +0000 (09:57 +0000)]
[WIN32SS]
* Plug a leak in IntGdiAddFontResource(). Original fix by Katayama Hirofumi MZ with one more instance covered by Timo Kreuzer.
* Return 0 instead of status in the file mapping failure path. By Timo Kreuzer.
svn path=/trunk/; revision=58913
Amine Khaldi [Thu, 2 May 2013 17:09:34 +0000 (17:09 +0000)]
[CRT]
* Annotate tchar.h.
svn path=/trunk/; revision=58912
Amine Khaldi [Thu, 2 May 2013 14:21:18 +0000 (14:21 +0000)]
[CRT]
* Annotate memory.h.
svn path=/trunk/; revision=58911
Pierre Schweitzer [Thu, 2 May 2013 08:04:12 +0000 (08:04 +0000)]
[NTOSKRNL]
This is C, use VOID
Spotted by Thomas Faber
svn path=/trunk/; revision=58910
Eric Kohl [Wed, 1 May 2013 21:54:40 +0000 (21:54 +0000)]
[NET]
Clean-up the new functions.
This should have been done by the author of the patch!
svn path=/trunk/; revision=58908
Eric Kohl [Wed, 1 May 2013 21:29:49 +0000 (21:29 +0000)]
[LSASRV]
Implement logon token creation code.
svn path=/trunk/; revision=58907
Pierre Schweitzer [Wed, 1 May 2013 20:53:15 +0000 (20:53 +0000)]
[NTOSKRNL]
Implement post stack overflow functions (i.e. FsRtlPostStackOverflow() and FsRtlPostPagingFileStackOverflow())
svn path=/trunk/; revision=58906
Amine Khaldi [Wed, 1 May 2013 16:00:36 +0000 (16:00 +0000)]
[IEFRAME]
* Fix the Home button label. Brought to you by Andre Guibert de Bruet.
CORE-7144 #resolve #comment Thanks !
svn path=/trunk/; revision=58901
Eric Kohl [Wed, 1 May 2013 13:44:24 +0000 (13:44 +0000)]
[INCLUDE]
Add missing LSA_TOKEN_INFORMATION_NULL and LSA_TOKEN_INFORMATION_V1 types.
svn path=/trunk/; revision=58900
Pierre Schweitzer [Wed, 1 May 2013 10:54:02 +0000 (10:54 +0000)]
[NTOSKRNL]
Make post stack overflow functions use the same (unimplemented) helper function
svn path=/trunk/; revision=58899
Amine Khaldi [Wed, 1 May 2013 10:00:06 +0000 (10:00 +0000)]
[NET]
* Fix MSVC build.
svn path=/trunk/; revision=58898
Pierre Schweitzer [Wed, 1 May 2013 09:10:34 +0000 (09:10 +0000)]
[NTOSKRNL]
Patch by Aleksey Bragin (he's not aware yet!):
Also implement FsRtlIs*InExpression prologue in FsRtlIsDbcsInExpression (adapted from Aleksey's work on FsRtlIsNameInExpression)
Also added support for Dbcs chars in it
svn path=/trunk/; revision=58897
Cameron Gutman [Tue, 30 Apr 2013 09:33:40 +0000 (09:33 +0000)]
[LWIP]
- Call tcp_shutdown() two different times for TX|RX shutdown to avoid the tcp_close() problem entirely
- Forcefully close the socket in LibTCPCloseCallback (not optimal, but good enough)
svn path=/trunk/; revision=58896
Cameron Gutman [Tue, 30 Apr 2013 08:16:29 +0000 (08:16 +0000)]
[LWIP]
- Don't define mem_trim() to realloc() because mem_trim() must never move the buffer pointer
- Fix realloc() which was completely broken
- Properly handle a TX|RX shutdown
svn path=/trunk/; revision=58895
Ziliang Guo [Tue, 30 Apr 2013 02:57:30 +0000 (02:57 +0000)]
[NET]
Implementation of pause, continue, and help commands for net service application. Patch by theflash.
Core-7131 #resolve
svn path=/trunk/; revision=58894
Hermès Bélusca-Maïto [Mon, 29 Apr 2013 23:49:52 +0000 (23:49 +0000)]
[HOSTNAME]
Unicodify and add localization support.
Patch by Lee Schroeder, simplified by me.
CORE-7142 #resolve #comment Committed in revision r58893, thanks!
[REGEDIT]
"Neutralize" common resources.
svn path=/trunk/; revision=58893
Jérôme Gardou [Mon, 29 Apr 2013 16:17:46 +0000 (16:17 +0000)]
[NTOSKRNL/V86VDM]
- Merge the EFLAGS register instead of overwriting it when restoring it from a POPF call.
svn path=/trunk/; revision=58892
Amine Khaldi [Mon, 29 Apr 2013 12:24:39 +0000 (12:24 +0000)]
[LWIP]
* Update to 1.4.1. Brought to you by Samuel Serapion.
CORE-7140
svn path=/trunk/; revision=58891
Aleksey Bragin [Mon, 29 Apr 2013 10:28:58 +0000 (10:28 +0000)]
[FSRTL]
- Reformat the code for better readability. Sacrifice 80 chars max line width in favor of a readable code (sorry, but when the indentation eats 12 chars, formulas for calculating sizes are hard to fit into less than 70 chars, and they become totally unreadable).
svn path=/trunk/; revision=58890
Aleksey Bragin [Mon, 29 Apr 2013 10:10:44 +0000 (10:10 +0000)]
[FSRTL]
- Start bringing sanity to FSRTL Large MCB implementation:
* Get rid of the GET_LIST_HEAD macro and define a proper private struct to access its members. That's much more flexible,and that's how it's usually done in hundreds of other places in the kernel. Otherwise we might just forget about structs and invent macros to access individual virtual fields in a byte array :)
* Going through the code (first, preliminary pass) and putting helper debug prints, especially when the code does not work as expected.
* Move variables definitions to the beginning of the function (thus get rid of up to local vars being redifined up to 3x times within a single function).
svn path=/trunk/; revision=58889
Cameron Gutman [Mon, 29 Apr 2013 10:01:39 +0000 (10:01 +0000)]
[NDIS]
- Queue the miniport worker only after a previous operation has completed
CORE-5734 #resolve #comment Fixed in r58888
svn path=/trunk/; revision=58888
Giannis Adamopoulos [Sun, 28 Apr 2013 20:53:57 +0000 (20:53 +0000)]
[win32k]
- Initialize SM_CXSCREEN and SM_CYSCREEN metrics in co_IntInitializeDesktopGraphics
- Also move some code from IntCreatePrimarySurface to co_IntInitializeDesktopGraphics
svn path=/trunk/; revision=58887
Olaf Siejka [Sun, 28 Apr 2013 11:07:07 +0000 (11:07 +0000)]
[TRANSLATION]
- turkish translation update by Erdem Ersoy: CORE-7025,CORE-7032,CORE-7033,CORE-7034,CORE-7071;
- italian translation update by Paolo Devoti: CORE-7122;
- use the same notepad caption title as in Windows 2003 for AHK test compatibility, patch by Edijs Kolesnikovics: CORE-7023;
- added polish translation of samsrv and wlanconf, updated polish translation of rapps, msgina, consrv, console and desk;
- convert msgina to compile resources for a defined language;
svn path=/trunk/; revision=58882
Thomas Faber [Sun, 28 Apr 2013 09:58:55 +0000 (09:58 +0000)]
[SHELL32]
- Use SHELL_LINK_HEADER instead of defining a local structure. Patch by Dominik Hornung (dominikhornung at gmx dot de).
CORE-7099
svn path=/trunk/; revision=58881
Thomas Faber [Sun, 28 Apr 2013 09:49:09 +0000 (09:49 +0000)]
[PSDK]
- Add SHELL_LINK_HEADER structure. Update SHELL_LINK_DATA_FLAGS. Patch by Dominik Hornung (dominikhornung at gmx dot de).
CORE-7099
svn path=/trunk/; revision=58880
Thomas Faber [Sun, 28 Apr 2013 09:09:57 +0000 (09:09 +0000)]
[BROWSEUI]
- Remove weird broken Get/SetWindowLongPtr wrapper functions (by Katayama Hirofumi MZ)
- Fix some casts
- Remove unnecessary ROS_Headers define
svn path=/trunk/; revision=58879
Thomas Faber [Sun, 28 Apr 2013 08:42:22 +0000 (08:42 +0000)]
[BROWSEUI:FORMATTING]
- Use spaces instead of tabs
svn path=/trunk/; revision=58878
Thomas Faber [Sun, 28 Apr 2013 07:49:41 +0000 (07:49 +0000)]
[BROWSEUI:FORMATTING]
- Improve coding style (break long lines, use C++ casts, add comments, ...). Patch by Katayama Hirofumi MZ.
COTE-7121
svn path=/trunk/; revision=58877
Hermès Bélusca-Maïto [Sat, 27 Apr 2013 21:46:02 +0000 (21:46 +0000)]
[KDCOM]
Add resource files for KDCOM and compile them.
svn path=/trunk/; revision=58876
Sylvain Petreolle [Sat, 27 Apr 2013 19:33:31 +0000 (19:33 +0000)]
[MKHIVE]
Set proper parent for registry keys.
Patch by theflash < theflash at sdf dot lonestar dot org >
CORE-7128 #resolve
svn path=/trunk/; revision=58875
Thomas Faber [Sat, 27 Apr 2013 18:33:50 +0000 (18:33 +0000)]
[KMTESTS:MM]
- Add tests for ZwAllocateVirtualMemory, ZwCreateSection, ZwMapViewOfSection. Patch by Nikolay Borisov (nib9 at aber dot ac dot uk).
- Some tests are currently skipped because they crash or assert on ROS: See ROSTESTS-107, ROSTESTS-108, ROSTESTS-109, ROSTESTS-110.
ROSTESTS-105 #resolve
svn path=/trunk/; revision=58874
Thomas Faber [Sat, 27 Apr 2013 18:18:17 +0000 (18:18 +0000)]
[KMTESTS]
- Implement a mechanism for kmtests to retrieve information from user-mode. Patch by Nikolay Borisov (nib9 at aber dot ac dot uk).
- Currently supported function: QueryVirtualMemory
ROSTESTS-96 #resolve
svn path=/trunk/; revision=58873
Amine Khaldi [Sat, 27 Apr 2013 14:56:43 +0000 (14:56 +0000)]
[DINPUT]
* Add missing psdk dependency for the dinput data formats library.
svn path=/trunk/; revision=58872
Amine Khaldi [Sat, 27 Apr 2013 13:53:29 +0000 (13:53 +0000)]
[CMAKE]
* Don't set a default list of linked libraries, let us decide that ourselves. Fixes the recent VS build issues.
svn path=/trunk/; revision=58871
Sylvain Petreolle [Sat, 27 Apr 2013 12:37:33 +0000 (12:37 +0000)]
Import CredMarshalCredential and CredIsMarshaledCredential from wine.
ROSTESTS-97 #resolve
svn path=/trunk/; revision=58870
Amine Khaldi [Sat, 27 Apr 2013 09:40:27 +0000 (09:40 +0000)]
[SHELL32]
* Silence a compiler warning. Spotted by Thomas Faber.
svn path=/trunk/; revision=58869
Thomas Faber [Sat, 27 Apr 2013 09:15:24 +0000 (09:15 +0000)]
[ADVAPI32]
- Properly stub some commonly used safer functions
CORE-6942 #resolve
svn path=/trunk/; revision=58868
Thomas Faber [Sat, 27 Apr 2013 09:12:20 +0000 (09:12 +0000)]
[ADVAPI32_APITEST]
- Add basic parameter tests for SaferIdentifyLevel
CORE-6942
svn path=/trunk/; revision=58867
Thomas Faber [Sat, 27 Apr 2013 09:01:02 +0000 (09:01 +0000)]
[PSDK]
- Replace winsafer.h with a usable version
CORE-6942
svn path=/trunk/; revision=58866
Thomas Faber [Sat, 27 Apr 2013 08:18:15 +0000 (08:18 +0000)]
[BOOTDATA]
- Add Themes folder during setup. Patch by Lee Schroeder.
CORE-6987 #resolve
svn path=/trunk/; revision=58865
Thomas Faber [Sat, 27 Apr 2013 07:44:28 +0000 (07:44 +0000)]
[KMTESTS:FSRTL]
- Rework FsRtlExpression test to be more maintainable by using a table. Patch by Víctor Martínez Calvo, a few comments by me.
CORE-7108 #resolve
svn path=/trunk/; revision=58864
Amine Khaldi [Fri, 26 Apr 2013 23:05:51 +0000 (23:05 +0000)]
[SHELL32]
* Fix the FVM_AUTO handing in CDefView::SetCurrentViewMode. Brought to you by Victor Martinez.
CORE-7126 #resolve
svn path=/trunk/; revision=58863
Amine Khaldi [Fri, 26 Apr 2013 22:31:07 +0000 (22:31 +0000)]
[HAL]
* Account for the asm source files in all the HAL flavors. Should fix compiling them with VS (which regressed recently).
svn path=/trunk/; revision=58862
Sylvain Petreolle [Fri, 26 Apr 2013 14:15:28 +0000 (14:15 +0000)]
[HIVESFT]
Fix opening of http,https and gopher URLs.
svn path=/trunk/; revision=58861
Amine Khaldi [Fri, 26 Apr 2013 12:10:27 +0000 (12:10 +0000)]
[SHELL32]
* Sync CommandLineToArgvW with Wine 1.5.26. Fixes issues spotted by Victor Martinez.
CORE-7125 #resolve
svn path=/trunk/; revision=58860
Thomas Faber [Fri, 26 Apr 2013 09:31:12 +0000 (09:31 +0000)]
[KMTESTS:FSRTL]
- Enable running FsRtlMcb by hand
svn path=/trunk/; revision=58859
Pierre Schweitzer [Fri, 26 Apr 2013 06:47:42 +0000 (06:47 +0000)]
[NTOSKRNL]
Disable FsRtlMcb for the moment, as they crash, don't provide any useful and prevent the VBox testbot to properly run
svn path=/trunk/; revision=58858
Hermès Bélusca-Maïto [Thu, 25 Apr 2013 23:16:19 +0000 (23:16 +0000)]
Fix a check.
svn path=/trunk/; revision=58857
Hermès Bélusca-Maïto [Thu, 25 Apr 2013 23:13:58 +0000 (23:13 +0000)]
[ADVAPI32-SERVICES]
- Apply changes from http://code.reactos.org/cru/CR-30
- If an event object already exists, CreateEvent returns a valid handle to it. So that, if the returned handle is NULL, then automatically we are sure that it doesn't exist. Therefore remove unneeded checks.
svn path=/trunk/; revision=58856
Amine Khaldi [Thu, 25 Apr 2013 23:04:00 +0000 (23:04 +0000)]
[SHELL32]
* Sync SH{Register,Revoke}DragDrop with Wine 1.5.26.
svn path=/trunk/; revision=58855
Amine Khaldi [Thu, 25 Apr 2013 22:52:34 +0000 (22:52 +0000)]
[SHELL32]
* Sync DoEnvironmentSubst{A,W} with Wine 1.5.26. Fixes issues spotted by Victor Martinez.
CORE-7124 #resolve
svn path=/trunk/; revision=58854
Hermès Bélusca-Maïto [Thu, 25 Apr 2013 22:20:00 +0000 (22:20 +0000)]
[PSDK]
Clarify the meaning of the parameters of MAKEWORD/MAKELONG
svn path=/trunk/; revision=58853
Jérôme Gardou [Thu, 25 Apr 2013 21:29:59 +0000 (21:29 +0000)]
[NTOSKRNL]
- Handle VME for the PUSHF and POPF instruction in virtual mode
- There is no reason to set interrupt flag when handling POPF
- Fix a typo in POPF case : mask out the right variable
See http://www.rcollins.org/articles/vme1/ for reference
svn path=/trunk/; revision=58852
Amine Khaldi [Thu, 25 Apr 2013 15:54:45 +0000 (15:54 +0000)]
[NTOSKRNL]
* Make sure that BaseAddress is at 64-k boundary in NtMapViewOfSection(). Fixes a couple NtMapViewOfSection tests.
* Brought to you by Zhan Jianyu (aka larmbr) with review and improvement by Timo.
CORE-7118 #resolve #comment A slightly improved fix was committed in r58851. Thanks ;)
svn path=/trunk/; revision=58851
Aleksey Bragin [Thu, 25 Apr 2013 14:15:10 +0000 (14:15 +0000)]
[RTL]
- Apply similar fixes as in 58848 to RtlGetElementGenericTable (no need to make too fancy predecrements if they work incorrectly in this case when do/while loops were unnecessary at all).
svn path=/trunk/; revision=58850
Pierre Schweitzer [Thu, 25 Apr 2013 10:08:05 +0000 (10:08 +0000)]
[KMTESTS:FSRTL]
Fix copy/paste mistakes
svn path=/trunk/; revision=58849
Aleksey Bragin [Wed, 24 Apr 2013 22:56:43 +0000 (22:56 +0000)]
[RTL]
- Do not set result variable NodeOrParent in RtlpFindGenericTableNodeOrParent in case the generic table is empty, just returning TableEmptyTree is enough.
- Fix improper enumeration of generic tables nodes. The way they were done previously clearly shows that noone was actually testing these APIs and a simple mistake (do/while instead of while loop) led to a NULL pointer access. Thanks to Pierre for developing MCB tests which revealed this problem.
Rephrasing Vladimir Lenin: "Test, test and again test!"
svn path=/trunk/; revision=58848
Pierre Schweitzer [Wed, 24 Apr 2013 20:36:33 +0000 (20:36 +0000)]
[NTOSKRNL]
Reimplement (yes, once more...) all the DOS wildcards in FsRtlIs*InExpression().
This time with a better understanding of MSDN (doc can be sometimes quite cryptic...).
Which means that now the functions are passing all the tests and are even simpler.
svn path=/trunk/; revision=58847
Timo Kreuzer [Wed, 24 Apr 2013 20:28:45 +0000 (20:28 +0000)]
[NTOSKRNL/AMD64]
- Add more required feature bits
- Initialize the PAT MSR
- Enable NX in EFER MSR
svn path=/trunk/; revision=58846
Giannis Adamopoulos [Wed, 24 Apr 2013 17:51:44 +0000 (17:51 +0000)]
[videoprt]
- Improve some debug messages
svn path=/trunk/; revision=58845
Pierre Schweitzer [Wed, 24 Apr 2013 16:59:23 +0000 (16:59 +0000)]
[NTOSKRNL]
Really implement support for DOS_QM in FsRtlIs*InExpression()
Should fix some tests
svn path=/trunk/; revision=58844
Sylvain Petreolle [Wed, 24 Apr 2013 16:46:52 +0000 (16:46 +0000)]
[SYSSETUP]
Register ieframe during 2nd stage.
svn path=/trunk/; revision=58843