Amine Khaldi [Thu, 17 Nov 2016 22:21:35 +0000 (22:21 +0000)]
[BOOTDATA] Add FIPSAlgorithmPolicy registry value for bcrypt tests.
svn path=/trunk/; revision=73262
Amine Khaldi [Thu, 17 Nov 2016 22:13:28 +0000 (22:13 +0000)]
[BCRYPT] Sync with Wine Staging 1.9.23. The mbedtls code paths are brought to you by Peter Hater. CORE-12409
svn path=/trunk/; revision=73261
Amine Khaldi [Thu, 17 Nov 2016 22:09:11 +0000 (22:09 +0000)]
[MBEDTLS] Export some needed functions for bcrypt. By Peter Hater.
svn path=/trunk/; revision=73260
Amine Khaldi [Thu, 17 Nov 2016 22:07:42 +0000 (22:07 +0000)]
[PSDK] Update bcrypt.h. CORE-12409
svn path=/trunk/; revision=73259
Amine Khaldi [Thu, 17 Nov 2016 22:06:10 +0000 (22:06 +0000)]
[AVIFIL32_WINETEST] Sync with Wine Staging 1.9.23. CORE-12409
svn path=/trunk/; revision=73258
Amine Khaldi [Thu, 17 Nov 2016 22:05:29 +0000 (22:05 +0000)]
[AVIFIL32] Sync with Wine Staging 1.9.23. CORE-12409
svn path=/trunk/; revision=73257
Amine Khaldi [Thu, 17 Nov 2016 22:03:51 +0000 (22:03 +0000)]
[QUARTZ] Sync with Wine Staging 1.9.23. CORE-12409
svn path=/trunk/; revision=73256
Amine Khaldi [Thu, 17 Nov 2016 22:02:00 +0000 (22:02 +0000)]
[DMUSIC] Sync with Wine Staging 1.9.23. CORE-12409
svn path=/trunk/; revision=73255
Amine Khaldi [Thu, 17 Nov 2016 22:00:07 +0000 (22:00 +0000)]
[DINPUT_WINETEST] Sync with Wine Staging 1.9.23. CORE-12409
svn path=/trunk/; revision=73254
Amine Khaldi [Thu, 17 Nov 2016 21:59:05 +0000 (21:59 +0000)]
[D3DRM_WINETEST] Sync with Wine Staging 1.9.23. CORE-12409
svn path=/trunk/; revision=73253
Amine Khaldi [Thu, 17 Nov 2016 21:57:53 +0000 (21:57 +0000)]
[DINPUT] Sync with Wine Staging 1.9.23. CORE-12409
svn path=/trunk/; revision=73252
Amine Khaldi [Thu, 17 Nov 2016 21:56:53 +0000 (21:56 +0000)]
[PSDK] Add missing DI_WRITEPROTECT and DIPROP_PRODUCTNAME.
svn path=/trunk/; revision=73251
Amine Khaldi [Thu, 17 Nov 2016 21:52:34 +0000 (21:52 +0000)]
[D3DRM] Sync with Wine Staging 1.9.23. CORE-12409
svn path=/trunk/; revision=73250
Amine Khaldi [Thu, 17 Nov 2016 21:43:18 +0000 (21:43 +0000)]
[AMSTREAM] Sync with Wine Staging 1.9.23. CORE-12409
svn path=/trunk/; revision=73249
Colin Finck [Thu, 17 Nov 2016 21:30:45 +0000 (21:30 +0000)]
[WINSPOOL_APITEST]
GetPrintProcessorDirectory.c: fix 4 error messages (s/cbNeeded/cbTemp/).
By Serge Gautherie
svn path=/trunk/; revision=73248
Colin Finck [Thu, 17 Nov 2016 21:24:07 +0000 (21:24 +0000)]
[WINPRINT_APITEST]
Load all functions to test dynamically from either winprint.dll in the Print Processor Directory (for ReactOS and NT6) or localspl.dll in the system path (for NT5).
Should fix winprint_apitest on ReactOS and Windows Server 2003.
svn path=/trunk/; revision=73247
Mark Jansen [Thu, 17 Nov 2016 20:47:23 +0000 (20:47 +0000)]
[CMD] Wait for the spawned application to exit while executing a batch script. Patch by Joachim Henze. CORE-12402
svn path=/trunk/; revision=73246
Mark Jansen [Thu, 17 Nov 2016 19:50:45 +0000 (19:50 +0000)]
[SHELL32] Don't crash on an empty shortcut. CORE-12331 #resolve
svn path=/trunk/; revision=73245
Giannis Adamopoulos [Thu, 17 Nov 2016 14:51:02 +0000 (14:51 +0000)]
[PSDK] - shlobj.h: Add some flags that are needed to let shell32 compile.
svn path=/trunk/; revision=73244
Giannis Adamopoulos [Thu, 17 Nov 2016 14:35:19 +0000 (14:35 +0000)]
[SHELL32]
- CDefaultContextMenu: Add rudimentary support for callbacks so as to let folders have item specific commands and remove all item specific code from this class.
- Implement context menu callbacks for CFSFolder, CRegFolder, CDrivesFolder in order to let them handle the properties item and let the CDrivesFolder add and handle the Format item itself.
svn path=/trunk/; revision=73243
Amine Khaldi [Thu, 17 Nov 2016 13:46:36 +0000 (13:46 +0000)]
[WLANAPI_APITEST] Bring these tests back home.
svn path=/trunk/; revision=73242
Peter Hater [Thu, 17 Nov 2016 12:57:32 +0000 (12:57 +0000)]
[MSAFD] Fix WSPSelect heap corruption and don't repeat sockets if they are in different fd_sets.
CORE-12324
svn path=/trunk/; revision=73241
Amine Khaldi [Thu, 17 Nov 2016 11:56:16 +0000 (11:56 +0000)]
[NOTEPAD] Fix a typo. Spotted by Laur Florin. CORE-12405
svn path=/trunk/; revision=73240
Colin Finck [Wed, 16 Nov 2016 14:59:01 +0000 (14:59 +0000)]
[LOCALSPL_APITEST]
Fix some NULL vs. INVALID_HANDLE_VALUE checks.
Now localspl_apitest.exe should properly quit when it cannot find its DLL.
svn path=/trunk/; revision=73239
Colin Finck [Wed, 16 Nov 2016 08:54:54 +0000 (08:54 +0000)]
[WINSPOOL_APITEST]
Add tests for GetPrintProcessorDirectoryA and another one for GetPrintProcessorDirectoryW.
Tested against Windows Server 2003 SP2.
Step 1 for CORE-12399
svn path=/trunk/; revision=73238
Giannis Adamopoulos [Tue, 15 Nov 2016 20:14:56 +0000 (20:14 +0000)]
[SHELL32]
- Implement filling in needed keys passed to CDefFolderMenu_Create2.
- CDefaultContextMenu: Remove the code that filled the array of keys as this is now moved to the implementation of the shell folder.
svn path=/trunk/; revision=73237
Giannis Adamopoulos [Tue, 15 Nov 2016 14:25:05 +0000 (14:25 +0000)]
[SHELL32] - Accept NULL pidl in CRegFolder::GetDisplayNameOf. CORE-12317
svn path=/trunk/; revision=73236
Giannis Adamopoulos [Tue, 15 Nov 2016 14:08:57 +0000 (14:08 +0000)]
[SHELL32_APITEST] - Add a test for CShellDesktop to show what breaks the select folder dialog.
svn path=/trunk/; revision=73235
Hermès Bélusca-Maïto [Mon, 14 Nov 2016 18:57:18 +0000 (18:57 +0000)]
[LSASRV]: Revert part of r73233: GetModuleHandle(NULL) retrieves the exe module in which the dll is loaded, not the dll instance itself. (an alternative might be to use the hinstance from DllMain...). Thanks Thomas for having pointed this to me.
svn path=/trunk/; revision=73234
Hermès Bélusca-Maïto [Mon, 14 Nov 2016 16:19:22 +0000 (16:19 +0000)]
[LSASRV]
- No need to hardcode the name of the dll in the GetModuleHandleW call;
- Use ARRAYSIZE instead of hardcoding string buffer sizes;
- When initializing the "Network Sid", use the correct localized string.
svn path=/trunk/; revision=73233
Hermès Bélusca-Maïto [Mon, 14 Nov 2016 16:17:42 +0000 (16:17 +0000)]
[LSASRV]
- Remove trailing whitespace;
- Tabs --> Spaces;
- Don't always hardcode parameters sizeofs;
- Use ARRAYSIZE where applicable;
- Use UNICODE_NULL
svn path=/trunk/; revision=73232
Peter Hater [Mon, 14 Nov 2016 14:10:48 +0000 (14:10 +0000)]
[MSAFD] When out of band data is inlined, calling WSPRecv/WSPRecvFrom with flag MSG_OOB is invalid, return WSAEINVAL. CORE-12104
svn path=/trunk/; revision=73231
Amine Khaldi [Mon, 14 Nov 2016 11:18:11 +0000 (11:18 +0000)]
[LOCALMON] Russian translation by Nikolay Burshtyn aka amber. CORE-12363
svn path=/trunk/; revision=73230
Amine Khaldi [Mon, 14 Nov 2016 10:58:53 +0000 (10:58 +0000)]
[LOCALMON] Italian translation by Carlo Bramini. CORE-12363
svn path=/trunk/; revision=73229
Mark Jansen [Sun, 13 Nov 2016 18:11:14 +0000 (18:11 +0000)]
[ADVAPI32][ADVAPI32_APITEST] Fix incorrect parameter output uncovered by CORE-12333 #comment Please retest!
svn path=/trunk/; revision=73228
Thomas Faber [Sun, 13 Nov 2016 16:42:16 +0000 (16:42 +0000)]
[KMTESTS:MM]
- Skip NtCreateSection tests since they hang on testbot.
ROSTESTS-248
svn path=/trunk/; revision=73227
Amine Khaldi [Sun, 13 Nov 2016 15:31:39 +0000 (15:31 +0000)]
[DRIVERS] Spelling fixes by Josh Soref. CORE-12286
svn path=/trunk/; revision=73226
Thomas Faber [Sun, 13 Nov 2016 14:54:06 +0000 (14:54 +0000)]
[WS2_32_APITEST]
- Skip nonblocking tests since they hang on testbot
ROSTESTS-247
svn path=/trunk/; revision=73225
Thomas Faber [Sun, 13 Nov 2016 12:19:05 +0000 (12:19 +0000)]
[KMTESTS:RTL]
- Silence a GCC5+ warning
CORE-11794
svn path=/trunk/; revision=73224
Thomas Faber [Sun, 13 Nov 2016 11:51:02 +0000 (11:51 +0000)]
[ATL]
- Don't return values from void functions.
CORE-11794
svn path=/trunk/; revision=73223
Pierre Schweitzer [Sun, 13 Nov 2016 10:33:23 +0000 (10:33 +0000)]
[EXPLORER]
Translate last bits of the task parameters in French.
CORE-12385
svn path=/trunk/; revision=73221
Thomas Faber [Sun, 13 Nov 2016 10:19:22 +0000 (10:19 +0000)]
[CMAKE]
- Use CMake 3.4's <INCLUDES> rule variable in addition to <FLAGS>.
CORE-12373 #resolve
svn path=/trunk/; revision=73220
Thomas Faber [Sun, 13 Nov 2016 09:57:30 +0000 (09:57 +0000)]
[CMAKE]
- We require automatic generation of phony targets for now. Set the corresponding CMake 3.3+ policy (CMP0058).
CORE-12373
svn path=/trunk/; revision=73219
Amine Khaldi [Sat, 12 Nov 2016 22:59:55 +0000 (22:59 +0000)]
[WINSPOOL] Properly export GetPrinterDriverDirectoryA as a stub. CORE-12375
svn path=/trunk/; revision=73218
Amine Khaldi [Sat, 12 Nov 2016 22:32:14 +0000 (22:32 +0000)]
[WINSPOOL] Properly export GetPrintProcessorDirectoryA as a stub. CORE-12375
svn path=/trunk/; revision=73217
Amine Khaldi [Sat, 12 Nov 2016 21:53:33 +0000 (21:53 +0000)]
[DLLS] Spelling fixes by Josh Soref. CORE-12286
svn path=/trunk/; revision=73216
Amine Khaldi [Sat, 12 Nov 2016 20:53:49 +0000 (20:53 +0000)]
[BOOT] Spelling fixes by Josh Soref. CORE-12286
svn path=/trunk/; revision=73215
Amine Khaldi [Sat, 12 Nov 2016 20:24:07 +0000 (20:24 +0000)]
[TIMEDATE] Make the custom clock control aware of the theming. By Carlo Bramini. CORE-12079
svn path=/trunk/; revision=73214
Giannis Adamopoulos [Sat, 12 Nov 2016 15:38:33 +0000 (15:38 +0000)]
[SHELL32_APITEST] -Test the IPersistFolder3 interface of CFSFolder.
svn path=/trunk/; revision=73213
Giannis Adamopoulos [Sat, 12 Nov 2016 14:54:12 +0000 (14:54 +0000)]
[SHELL32_APITEST]
- Add tests for the Initialize method for CDesktopFolder and CDrivesFolder.
- Add tests for CFSFolder to see how it behaves whhile not initialized.
svn path=/trunk/; revision=73212
Thomas Faber [Sat, 12 Nov 2016 14:52:58 +0000 (14:52 +0000)]
[PSEH3]
- Avoid trying to disable 'declaration after statement' warnings in C++
CORE-11794
svn path=/trunk/; revision=73211
Thomas Faber [Sat, 12 Nov 2016 12:43:02 +0000 (12:43 +0000)]
[SHELL32_APITEST]
- Don't compare a pointer to S_OK
CORE-11794
svn path=/trunk/; revision=73210
Thomas Faber [Sat, 12 Nov 2016 12:23:49 +0000 (12:23 +0000)]
[MSWSOCK]
- Remove broken 'inline' specifiers
CORE-11794
svn path=/trunk/; revision=73209
Pierre Schweitzer [Sat, 12 Nov 2016 09:24:09 +0000 (09:24 +0000)]
[SNDREC32]
Don't double free buffers in case of failure
svn path=/trunk/; revision=73208
Hermès Bélusca-Maïto [Sat, 12 Nov 2016 01:29:05 +0000 (01:29 +0000)]
[EVENTVWR]: Fix translation for "Information" event type: it is really in singular, not plural.
svn path=/trunk/; revision=73207
Hermès Bélusca-Maïto [Fri, 11 Nov 2016 23:32:29 +0000 (23:32 +0000)]
[MSVCRT]: Implement and export _wtof, based on Wine and existing code; patch by Amine Khaldi.
CORE-12335 #resolve
CORE-9312 #comment Please retest with r73206
svn path=/trunk/; revision=73206
Hermès Bélusca-Maïto [Fri, 11 Nov 2016 21:37:09 +0000 (21:37 +0000)]
[MSAFD]
- In C, void functions should better have 'VOID' mentioned in their prototypes.
- Simplify GetCurrentTimeInSeconds code.
svn path=/trunk/; revision=73205
Hermès Bélusca-Maïto [Fri, 11 Nov 2016 21:25:02 +0000 (21:25 +0000)]
[MSAFD]: Addendum to r73203.
svn path=/trunk/; revision=73204
Hermès Bélusca-Maïto [Fri, 11 Nov 2016 21:19:13 +0000 (21:19 +0000)]
[MSAFD]: Convert tabs to spaces.
svn path=/trunk/; revision=73203
Pierre Schweitzer [Fri, 11 Nov 2016 18:16:43 +0000 (18:16 +0000)]
[NTOSKRNL]
Don't redefine RTL_NUMBER_OF
svn path=/trunk/; revision=73202
Christoph von Wittich [Fri, 11 Nov 2016 14:21:55 +0000 (14:21 +0000)]
[PSDK] small fixes for dns headers
svn path=/trunk/; revision=73201
Pierre Schweitzer [Fri, 11 Nov 2016 10:44:51 +0000 (10:44 +0000)]
[KMTESTS:MM]
Bugfix for IRP_MJ_SET_INFORMATION/FileEndOfFileInformation: really set the information. The test still works fine in Windows and still fails hard in ReactOS.
svn path=/trunk/; revision=73200
Pierre Schweitzer [Thu, 10 Nov 2016 21:17:21 +0000 (21:17 +0000)]
[NTOSKRNL]
In MmCreateDataFileSection(), when maximum size is higher than file size, don't deal with its allocation size, just move EOF.
This was shown by NtCreateSection() tests.
svn path=/trunk/; revision=73199
Pierre Schweitzer [Thu, 10 Nov 2016 21:02:48 +0000 (21:02 +0000)]
[KMTESTS:MM]
Add tests for the NtCreateSection functions which mimic some of the behavior that can be exposed by FSDs (late init, too small files, and so on).
It was designed in W2K3.
svn path=/trunk/; revision=73198
Peter Hater [Thu, 10 Nov 2016 17:55:00 +0000 (17:55 +0000)]
[MSAFD] Implement SO_CONNECT_TIME. CORE-12104
svn path=/trunk/; revision=73197
Thomas Faber [Thu, 10 Nov 2016 15:34:25 +0000 (15:34 +0000)]
[HOST-TOOLS]
- Fix some GCC6 warnings
svn path=/trunk/; revision=73196
Peter Hater [Thu, 10 Nov 2016 15:13:19 +0000 (15:13 +0000)]
[WS2_32_APITESTS] Add nonblocking tests
svn path=/trunk/; revision=73195
Peter Hater [Thu, 10 Nov 2016 15:00:44 +0000 (15:00 +0000)]
[WS2_32_APITESTS] Add more WSAAsync tests
svn path=/trunk/; revision=73194
Peter Hater [Thu, 10 Nov 2016 14:23:49 +0000 (14:23 +0000)]
[WS2_32_APITEST] Use test.winehq.org insteadof reactos.org. These days main reactos page is too big.
svn path=/trunk/; revision=73193
Peter Hater [Thu, 10 Nov 2016 11:15:14 +0000 (11:15 +0000)]
[MSAFD] Fix for WSPStringToAddressA/W wine tests. CORE-12104
svn path=/trunk/; revision=73192
Thomas Faber [Thu, 10 Nov 2016 11:04:29 +0000 (11:04 +0000)]
[FASTFAT]
- Generate LFNs for files containing non-ASCII characters in their names.
CORE-8617 #resolve
svn path=/trunk/; revision=73191
Thomas Faber [Thu, 10 Nov 2016 10:18:25 +0000 (10:18 +0000)]
[NTDLL_APITEST]
- Add tests for RtlIsNameLegalDOS8Dot3 and RtlUpcaseUnicodeStringToCountedOemString with the ® sign.
CORE-8617
svn path=/trunk/; revision=73190
Giannis Adamopoulos [Thu, 10 Nov 2016 09:34:14 +0000 (09:34 +0000)]
[SHELL32] - CStartMenu: Add missing checks for failure and make some checks noisy. CORE-12300
svn path=/trunk/; revision=73189
Giannis Adamopoulos [Thu, 10 Nov 2016 08:10:28 +0000 (08:10 +0000)]
[SHELL32] - CMenuBand: Don't accept a NULL shell folder in SetShellFolder. Should fix a test and possibly CORE-12300.
svn path=/trunk/; revision=73188
Giannis Adamopoulos [Thu, 10 Nov 2016 08:05:13 +0000 (08:05 +0000)]
[SHELL32]
- Make some checks for failure in CDefView and CDefaultContextMenu noisy.
svn path=/trunk/; revision=73187
Mark Jansen [Wed, 9 Nov 2016 23:23:50 +0000 (23:23 +0000)]
and of course also rename the test itself...
svn path=/trunk/; revision=73186
Mark Jansen [Wed, 9 Nov 2016 23:18:23 +0000 (23:18 +0000)]
Rename shlexec.cpp to ShellExecuteEx.cpp as suggested by Thomas.
svn path=/trunk/; revision=73185
Thomas Faber [Wed, 9 Nov 2016 22:55:16 +0000 (22:55 +0000)]
[PROPSYS_WINETEST]
- Fix VS2010 build
svn path=/trunk/; revision=73184
Mark Jansen [Wed, 9 Nov 2016 22:24:42 +0000 (22:24 +0000)]
addendum to r73180 (aka, fix the build)
svn path=/trunk/; revision=73183
Mark Jansen [Wed, 9 Nov 2016 22:18:33 +0000 (22:18 +0000)]
[SHELL32] Automatically add the .exe extension for App Paths in ShellExecuteEx. Patch by Yaroslav Veremenko. CORE-12049
svn path=/trunk/; revision=73182
Hermès Bélusca-Maïto [Wed, 9 Nov 2016 22:14:20 +0000 (22:14 +0000)]
[EVENTVWR]: Adjust some menu keyboard shortcuts.
svn path=/trunk/; revision=73181
Mark Jansen [Wed, 9 Nov 2016 22:13:26 +0000 (22:13 +0000)]
[SHELL32_APITEST] Add some tests for ShellExecuteEx showing extension completion with the App Paths registry key. Patch by Yaroslav Veremenko. CORE-12049
svn path=/trunk/; revision=73180
Christoph von Wittich [Wed, 9 Nov 2016 21:29:09 +0000 (21:29 +0000)]
[PSDK] fix DNS_RECORDW definition
svn path=/trunk/; revision=73179
Hermès Bélusca-Maïto [Wed, 9 Nov 2016 18:03:19 +0000 (18:03 +0000)]
[EXPLORER]: Add missing keyboard shortcuts for some commands.
svn path=/trunk/; revision=73178
Peter Hater [Wed, 9 Nov 2016 12:05:48 +0000 (12:05 +0000)]
[MSAFD] Fix possible memory corruption in WSPIoctl. Brought to you by Andreas Maier aka andy-123. Thanks.
CORE-12322
svn path=/trunk/; revision=73177
Peter Hater [Wed, 9 Nov 2016 11:49:55 +0000 (11:49 +0000)]
[MSAFD] Minor changes. Code style fixes. tabs->spaces. CORE-12104
svn path=/trunk/; revision=73176
Giannis Adamopoulos [Tue, 8 Nov 2016 23:38:42 +0000 (23:38 +0000)]
[BROWSEUI]
- CAddressBand: Call the SetOwner method with NULL parameter to CAddressEditBox to let it know that it should deinitialize.
- CAddressEditBox: Release the connection with the browse window and release the pointer to the site during deinitialization.
- CInternetToolbar: Destroy the toolbar and release pointers when CloseDW method gets called.
- CBaseBar: Destroy the window when SetClient is called with NULL parameter.
- CToolbarProxy: Add a Destroy method to release resources because we hold a pointer to the CInternetToolbar.
- CShellBrowser: When storing the pointer to the new basebar add a new reference because we directly change the pointer in the smart pointer and not the smart pointer itself. Destroy the toolbar proxy and properly release all references to containted objects. Also expect the reference count of the shell view to reach zero after the internet toolbar gets freed because it also keeps a reference.
This should fix all the leaking objects and windows when closing the shell browser. It should also fix CORE-12066.
svn path=/trunk/; revision=73175
Christoph von Wittich [Tue, 8 Nov 2016 12:27:55 +0000 (12:27 +0000)]
[PSDK] add some missing DNS structures, add incomplete dnsrslvr.idl
svn path=/trunk/; revision=73174
Christoph von Wittich [Tue, 8 Nov 2016 11:33:54 +0000 (11:33 +0000)]
[PSDK] disable SAL for WIDL as well
svn path=/trunk/; revision=73173
Thomas Faber [Tue, 8 Nov 2016 09:40:05 +0000 (09:40 +0000)]
[USETUP]
- Critical errors are worth a debug print
CORE-11819
svn path=/trunk/; revision=73172
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 20:41:24 +0000 (20:41 +0000)]
[NTOS]: Fix MmPt and DOPE tags.
svn path=/trunk/; revision=73171
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 15:51:56 +0000 (15:51 +0000)]
[NTOS:IO]: IopCreateDriver(): Set the returned DriverObject value only in case of success.
svn path=/trunk/; revision=73170
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 15:48:34 +0000 (15:48 +0000)]
[TCPIP]
- Enable logging now that IoWriteErrorLogEntry works.
- Check for log event size before calling IoAllocateErrorLogEntry.
- Reduce code indentation in the logging function.
svn path=/trunk/; revision=73169
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 13:57:11 +0000 (13:57 +0000)]
[NTOS:IO]: An improvement for the total log size check (addendum to r73167).
svn path=/trunk/; revision=73168
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 13:29:09 +0000 (13:29 +0000)]
[NTOS:IO][INCLUDES][EVENTLOG]: Fix support for event logging through the "ErrorLogPort" LPC. See the details in CORE-12301 #resolve
svn path=/trunk/; revision=73167
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 12:35:09 +0000 (12:35 +0000)]
[NTOS:LPC]
- Capture the ServerView/ClientView *only* when those pointers are not NULL.
- Fix a LpcRequest vs. CapturedLpcRequest in a call to LpcpMoveMessage. Caught by Thomas. CORE-7371 CR-100
svn path=/trunk/; revision=73166
Peter Hater [Mon, 7 Nov 2016 08:50:31 +0000 (08:50 +0000)]
[MSAFD] Implement SOL_SOCKET/SO_ERROR. CORE-12104
svn path=/trunk/; revision=73165
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 01:24:24 +0000 (01:24 +0000)]
[NTOS:LPC]
- Fix the usage, or add support (for NtSecureConnectPort based on patches by Alexander Andrejevic, and for NtReplyPort, NtReplyWaitReceivePortEx, NtListenPort by me) for capturing user-mode parameters and using SEH in LPC functions.
CORE-7371 #resolve
- Make NtSecureConnectPort call SeQueryInformationToken, now that the latter is implemented since r73122.
- Fix ObDereferenceObject usage for Port vs. ClientPort in NtSecureConnectPort.
- ObCloseHandle certainly needs to be called with the actual 'PreviousMode'.
svn path=/trunk/; revision=73164
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 01:06:24 +0000 (01:06 +0000)]
[NTOS:LPC]: Fix the function prototypes (reference: Process Hacker + how the parameters are used in the code).
[NOTS][NDK]: Fix whitespace in header files.
[XDK]: Define PORT_MAXIMUM_MESSAGE_LENGTH before actually using it in the different IO_ERROR_LOG_xxx #defines, for consistency purposes.
svn path=/trunk/; revision=73163
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 00:55:34 +0000 (00:55 +0000)]
[NTOS:LPC]: Improve the lisibility of some functions:
- Group together the local parameters used for capturing user variables;
- Add some space between the list of parameters and the beginning of the code proper;
- Rename some variables or move some code to make some different functions look more similar (helps in finding functionality-similar functions in the code);
- Improve some comments;
- Whitespace fixes;
- Few code formatting.
- Use a ExFreePoolWithTag instead of ExFreePool, but otherwise no other functional code changes.
svn path=/trunk/; revision=73162