Hervé Poussineau [Sun, 7 May 2006 14:52:32 +0000 (14:52 +0000)]
Add common cleanup block in SetupDiBuildClassInfoListExW, SetupDiClassGuidsFromNameExW, SetupDiClassNameFromGuidExW, SetupDiGetClassDescriptionExW, SETUP_CreateDevListFromEnumerator, SETUP_CreateDevList, SetupDiGetClassDevsExW, CreateClassKey, SetupDiOpenDeviceInfoW
svn path=/trunk/; revision=21831
Hervé Poussineau [Sun, 7 May 2006 14:02:00 +0000 (14:02 +0000)]
In case of error, Reg* functions set the output handle to NULL. Don't rely on it to be INVALID_HANDLE_VALUE
This commit is related to bug 1455
svn path=/trunk/; revision=21830
Hervé Poussineau [Sun, 7 May 2006 13:35:44 +0000 (13:35 +0000)]
Replace some casts by CONTAINING_RECORD macro
Fix handle leak in SetupDiOpenClassRegKeyExW
svn path=/trunk/; revision=21829
Eric Kohl [Sun, 7 May 2006 12:48:45 +0000 (12:48 +0000)]
Fix timeout handling.
svn path=/trunk/; revision=21828
Hervé Poussineau [Sun, 7 May 2006 12:09:01 +0000 (12:09 +0000)]
Fix a broken cast (thanks w3seek)
svn path=/trunk/; revision=21827
Hervé Poussineau [Sun, 7 May 2006 12:00:55 +0000 (12:00 +0000)]
Fix error handling in SETUP_CreateInterfaceList (memory/handles leak)
Implement DIGCF_PRESENT flag in SetupDiGetClassDevsExW
Add more error codes mapping from CR_* to ERROR_*
svn path=/trunk/; revision=21826
Eric Kohl [Sun, 7 May 2006 11:14:41 +0000 (11:14 +0000)]
Update Indentation (tab->4spaces).
svn path=/trunk/; revision=21825
Alex Ionescu [Sun, 7 May 2006 10:52:14 +0000 (10:52 +0000)]
- Fix build.
svn path=/trunk/; revision=21824
Hervé Poussineau [Sun, 7 May 2006 09:32:56 +0000 (09:32 +0000)]
Fix buffer overflow (spotted by Detlef Riekenberg in wine-devel ML)
svn path=/trunk/; revision=21823
Aleksey Bragin [Sun, 7 May 2006 09:23:22 +0000 (09:23 +0000)]
[AUDIT]
kernel32.dll
- Eric Kohl states that mailslot.c and npipe.c are clean: "They implement simple interfaces to the mailslot and named pipe file system drivers and don't contain any tainted code."
svn path=/trunk/; revision=21822
Magnus Olsen [Sun, 7 May 2006 09:12:37 +0000 (09:12 +0000)]
merges HEL_SetCooperativeLevel and HAL_SetCooperativeLevel to MAIN_SetCooperativeLevel
the new desgin allown us to use HEL as callbacks, we need change all HEL calls to the new desgin now
svn path=/trunk/; revision=21821
Magnus Olsen [Sun, 7 May 2006 08:41:26 +0000 (08:41 +0000)]
Try again move to new redesign but now we take one step at time
svn path=/trunk/; revision=21820
Magnus Olsen [Sun, 7 May 2006 08:26:40 +0000 (08:26 +0000)]
revert last commit it bsd the ddraw in some case
svn path=/trunk/; revision=21819
Art Yerkes [Sun, 7 May 2006 07:45:17 +0000 (07:45 +0000)]
Fix printing of adapter address. Just a silly thing for debugging.
svn path=/trunk/; revision=21818
Magnus Olsen [Sun, 7 May 2006 07:43:50 +0000 (07:43 +0000)]
Start remove old desgin of HEL to the new desgin, it will redues the code size, for we will use same code to call HAL in HEL, basic we need write the Dd* functions, it can be done two way, 1. Create a Hel driver in kmode or try write it in user mode. I will try write it in user mode.
svn path=/trunk/; revision=21817
Eric Kohl [Sun, 7 May 2006 07:33:40 +0000 (07:33 +0000)]
Simplified the access to FCBs and CCBs.
svn path=/trunk/; revision=21816
Eric Kohl [Sat, 6 May 2006 20:04:30 +0000 (20:04 +0000)]
The MSFS_MAILSLOT struct is actually an FCB (File Control Block). Rename it accordingly and store pointers to it in FileObject->FsContext.
svn path=/trunk/; revision=21815
Eric Kohl [Sat, 6 May 2006 15:39:42 +0000 (15:39 +0000)]
Set direct io flag of the device object.
svn path=/trunk/; revision=21814
Eric Kohl [Sat, 6 May 2006 15:37:40 +0000 (15:37 +0000)]
The MSFS_FCB struct is actually a CCB (Context Control Block) instead of an FCB (File Control Block). Rename it accordingly and store pointers to it in FileObject->FsContext2 instead of FileObject->FsContext.
svn path=/trunk/; revision=21813
Hervé Poussineau [Sat, 6 May 2006 14:36:52 +0000 (14:36 +0000)]
Code cleanup:
- Move IRP_MJ_CREATE, IRP_MJ_CLOSE and IRP_MJ_CLEANUP to fdo.c and pdo.c
- Implement IRP_MJ_PNP / IRP_MN_QUERY_BUS_INFORMATION for PDOs
- IRP_MJ_POWER now returns STATUS_NOT_SUPPORTED instead of STATUS_SUCCESS
- Replace STDCALL by NTAPI
- Delete useless white space
=> USB keyboard and mice are working, even if they require one reboot after the installation of the USB controller
svn path=/trunk/; revision=21812
Johannes Anderwald [Sat, 6 May 2006 11:26:27 +0000 (11:26 +0000)]
* enable advanced mouse options in apply
thnx Christoph_Vw
svn path=/trunk/; revision=21811
Johannes Anderwald [Sat, 6 May 2006 11:10:27 +0000 (11:10 +0000)]
* ident code
* enable apply button when slider pos change
svn path=/trunk/; revision=21810
Christoph von Wittich [Fri, 5 May 2006 21:55:27 +0000 (21:55 +0000)]
-lock the year edit control
svn path=/trunk/; revision=21809
Aleksey Bragin [Fri, 5 May 2006 18:13:26 +0000 (18:13 +0000)]
- SVN maintenance (set eol-style to native)
svn path=/trunk/; revision=21808
Aleksey Bragin [Fri, 5 May 2006 17:46:05 +0000 (17:46 +0000)]
Move OBJ_NAME_PATH_SEPARATOR to ndk/obtypes.h (inspired by w3seek). Should make applying NDK patch easier.
svn path=/trunk/; revision=21807
Peter Ward [Fri, 5 May 2006 17:16:05 +0000 (17:16 +0000)]
Fixed build.
- Changed strcpyW to wcscpy.
svn path=/trunk/; revision=21806
Aleksey Bragin [Fri, 5 May 2006 15:40:59 +0000 (15:40 +0000)]
[AUDIT]
drivers/network/wshtcpip
- Authors are Casper Hornstrup and Arthur Yerks
- Implemented functions are documented in OSR, MSDN and Google finds lots of links
- Result: Clean
svn path=/trunk/; revision=21805
Maarten Bosma [Fri, 5 May 2006 15:36:25 +0000 (15:36 +0000)]
[AUDIT]
Elf Loader
- KJK::Hyperion says it's clean
- ELF loader does not exist in Windows(R).
svn path=/trunk/; revision=21804
Christoph von Wittich [Fri, 5 May 2006 15:35:56 +0000 (15:35 +0000)]
*added year selection box
*display current time
svn path=/trunk/; revision=21803
Maarten Bosma [Fri, 5 May 2006 15:31:16 +0000 (15:31 +0000)]
[AUDIT]
Obviously clean since it does not exist in windows and comes from freebsd.
svn path=/trunk/; revision=21802
Andrew Munger [Fri, 5 May 2006 15:10:59 +0000 (15:10 +0000)]
"More efficient" IsPowerOf2 from Myria (myriachan at cox dot net).
svn path=/trunk/; revision=21801
Aleksey Bragin [Fri, 5 May 2006 15:09:57 +0000 (15:09 +0000)]
[AUDIT]
wshirda.dll
- Code is just a set of stubs
- Headers/defs/rc is definately clean
svn path=/trunk/; revision=21800
Aleksey Bragin [Fri, 5 May 2006 14:56:16 +0000 (14:56 +0000)]
[AUDIT]
ntoskrnl/mm/pe.c
- KJK::Hyperion says it's clean
- There are references to original specs
- Windows PE loader is completely different
svn path=/trunk/; revision=21799
Aleksey Bragin [Fri, 5 May 2006 14:10:47 +0000 (14:10 +0000)]
[AUDIT]
ws2help.dll
- Code is just a set of stubs
- Headers/defs/rc is definately clean
svn path=/trunk/; revision=21798
Hervé Poussineau [Fri, 5 May 2006 10:12:59 +0000 (10:12 +0000)]
Legacy device objects created for USB keyboard and mouse support should be treated as FDOs, not PDOs.
svn path=/trunk/; revision=21797
Johannes Anderwald [Thu, 4 May 2006 20:30:22 +0000 (20:30 +0000)]
resources for the keyboard control panel applet
svn path=/trunk/; revision=21796
Johannes Anderwald [Thu, 4 May 2006 05:31:53 +0000 (05:31 +0000)]
fix build on linux plattforms
svn path=/trunk/; revision=21795
Magnus Olsen [Thu, 4 May 2006 05:23:54 +0000 (05:23 +0000)]
Bug : 1452 : patch from w3seek, some xlate obj fixes for indexed palettes, should fix a hack introduced in r21292
svn path=/trunk/; revision=21794
Johannes Anderwald [Wed, 3 May 2006 16:17:12 +0000 (16:17 +0000)]
implement notepad view status bar -
TODO: update caret position on arrow key/mouse scroll events
svn path=/trunk/; revision=21793
Johannes Anderwald [Wed, 3 May 2006 15:06:09 +0000 (15:06 +0000)]
set double click speed with latest slider pos
svn path=/trunk/; revision=21792
Hervé Poussineau [Wed, 3 May 2006 14:42:28 +0000 (14:42 +0000)]
Don't call IoRaiseHardError at DISPATCH_LEVEL
svn path=/trunk/; revision=21791
Johannes Anderwald [Wed, 3 May 2006 14:34:01 +0000 (14:34 +0000)]
fix compiling with gcc4
patch from w3seek
svn path=/trunk/; revision=21790
Hervé Poussineau [Wed, 3 May 2006 14:26:43 +0000 (14:26 +0000)]
Cleanup in SetupGetInfFileListW:
- Better arguments check
- Rename pFileSpecification to pFullFileName
- Fix some possible buffer overflows spotted by w3seek
svn path=/trunk/; revision=21789
Johannes Anderwald [Wed, 3 May 2006 14:09:39 +0000 (14:09 +0000)]
added missing constanst #define SPI_GETMOUSECLICKLOCK 0x101E
#define SPI_SETMOUSECLICKLOCK 0x101F
svn path=/trunk/; revision=21788
Hervé Poussineau [Wed, 3 May 2006 13:56:12 +0000 (13:56 +0000)]
Don't double free buffer in case of error
svn path=/trunk/; revision=21787
Johannes Anderwald [Wed, 3 May 2006 13:45:22 +0000 (13:45 +0000)]
halfplemented mouse control panel applet
svn path=/trunk/; revision=21786
Johannes Anderwald [Wed, 3 May 2006 11:23:57 +0000 (11:23 +0000)]
mouse control panel applet resources
svn path=/trunk/; revision=21785
Johannes Anderwald [Wed, 3 May 2006 11:18:07 +0000 (11:18 +0000)]
small msvc compiling fix
svn path=/trunk/; revision=21784
Aleksey Bragin [Wed, 3 May 2006 10:57:26 +0000 (10:57 +0000)]
[AUDIT]
- w3seek says this file is derived from Wine and doesn't contain any possibly unclean code
svn path=/trunk/; revision=21783
Aleksey Bragin [Wed, 3 May 2006 10:55:46 +0000 (10:55 +0000)]
- Bug 1447: Patch by Thomas Weidenmueller "Use SEH for some lstring functions, partly adapted from WINE"
WaxDragon tested this patch and confirmed it works fine.
svn path=/trunk/; revision=21782
Aleksey Bragin [Wed, 3 May 2006 10:48:38 +0000 (10:48 +0000)]
- Bug 1450: Patch by Thomas Weidenmueller "Some window class fixes"
This patch makes registering the "Abiword" window class succeed. However, Abiword now crashes with a stack overflow recursively delivering the WM_NOTIFYFORMAT message to a subclassed rebar control...
svn path=/trunk/; revision=21781
Aleksey Bragin [Wed, 3 May 2006 10:35:11 +0000 (10:35 +0000)]
- Bug 1451: Patch by Thomas Weidenmueller:
System controls, such as comboboxes and listboxes are always unicode, even when
created with CreateWindowExA. Therefore, ansi messages need to be converted to
unicode and vice versa when sent to these windows. This patch fixes some(!) of these issues! Not all control messages are handled!
svn path=/trunk/; revision=21780
Andrew Munger [Wed, 3 May 2006 04:17:50 +0000 (04:17 +0000)]
Move callproc code into own file and reduce unneccessary system calls to dereference them.
It doesn't fix any bugs but improves performance a bit.
Patch from w3seek, bug 1445.
svn path=/trunk/; revision=21779
Christoph von Wittich [Tue, 2 May 2006 22:45:35 +0000 (22:45 +0000)]
updated french translation patch by usurp
fixes bug 1441
svn path=/trunk/; revision=21778
Ged Murphy [Tue, 2 May 2006 21:11:36 +0000 (21:11 +0000)]
Got carried away ;)
svn path=/trunk/; revision=21777
Ged Murphy [Tue, 2 May 2006 21:01:43 +0000 (21:01 +0000)]
- convert the screensaver to tchar and build as unicode.
- gets around the ANSI bug in the config dialog
svn path=/trunk/; revision=21776
Magnus Olsen [Tue, 2 May 2006 17:53:04 +0000 (17:53 +0000)]
remove unsuse files after some redesign of ddraw
svn path=/trunk/; revision=21770
Magnus Olsen [Tue, 2 May 2006 08:15:50 +0000 (08:15 +0000)]
fix the build
svn path=/trunk/; revision=21769
Magnus Olsen [Tue, 2 May 2006 08:09:47 +0000 (08:09 +0000)]
implement add and release ref
svn path=/trunk/; revision=21768
Aleksey Bragin [Mon, 1 May 2006 21:33:26 +0000 (21:33 +0000)]
- Patch by Thomas Weidenmueller: Adds a workaround for buggy installshield installers (which crash without this patch)
- Fixes e.g. ATI Catalyst 5.5 installer and some other
svn path=/trunk/; revision=21763
Christoph von Wittich [Mon, 1 May 2006 17:24:38 +0000 (17:24 +0000)]
updated resource files
svn path=/trunk/; revision=21761
Magnus Olsen [Mon, 1 May 2006 10:04:59 +0000 (10:04 +0000)]
Working on a redesign of whole directdraw interface
frist commit of many
svn path=/trunk/; revision=21760
Hervé Poussineau [Sun, 30 Apr 2006 19:17:32 +0000 (19:17 +0000)]
Add kbdclass and mouclass as upper filter for keyboard and mouse devices.
Install i8042prt driver, even if it is not plug&play compliant at the moment
svn path=/trunk/; revision=21759
Eric Kohl [Sun, 30 Apr 2006 12:10:31 +0000 (12:10 +0000)]
Improvement to the r21757 patch.
svn path=/trunk/; revision=21758
Eric Kohl [Sun, 30 Apr 2006 07:47:07 +0000 (07:47 +0000)]
An attempt to read from a not-yet-connected pipe must fail. This fixes a Wine testcase.
svn path=/trunk/; revision=21757
Hervé Poussineau [Sat, 29 Apr 2006 11:11:29 +0000 (11:11 +0000)]
Add pciide.sys/pciidex.sys to bootcd
svn path=/trunk/; revision=21756
Eric Kohl [Sat, 29 Apr 2006 07:39:13 +0000 (07:39 +0000)]
Set file object flag FO_NAMED_PIPE upon named pipe creation.
svn path=/trunk/; revision=21755
Eric Kohl [Sat, 29 Apr 2006 07:35:41 +0000 (07:35 +0000)]
Set file object flag FO_MAILSLOT upon mailslot creation.
svn path=/trunk/; revision=21754
Hervé Poussineau [Fri, 28 Apr 2006 21:10:49 +0000 (21:10 +0000)]
Lighter implementation of SetupGetInfFileListW
svn path=/trunk/; revision=21753
Ged Murphy [Fri, 28 Apr 2006 15:43:45 +0000 (15:43 +0000)]
fix build
svn path=/trunk/; revision=21752
Christoph von Wittich [Fri, 28 Apr 2006 15:34:58 +0000 (15:34 +0000)]
added a PopupMenu with Add and Delete functions in screensaver.c
svn path=/trunk/; revision=21751
Christoph von Wittich [Fri, 28 Apr 2006 06:00:23 +0000 (06:00 +0000)]
fixed a typo
svn path=/trunk/; revision=21750
Christoph von Wittich [Fri, 28 Apr 2006 05:46:44 +0000 (05:46 +0000)]
-redesigned the screensaver dialog
-removed add and delete buttons (these function should be placed in a context menu instead)
other rc files than english and german have to be updated accordingly
svn path=/trunk/; revision=21749
Christoph von Wittich [Fri, 28 Apr 2006 00:09:33 +0000 (00:09 +0000)]
transparent screen picture
svn path=/trunk/; revision=21748
Ged Murphy [Thu, 27 Apr 2006 20:40:09 +0000 (20:40 +0000)]
revert the my computer icon. mf's original is prefered
svn path=/trunk/; revision=21747
Ged Murphy [Wed, 26 Apr 2006 22:44:26 +0000 (22:44 +0000)]
- allow start menu selection to loop when using the keyboard
- patch by Andreas Bjerkeholt (harteex@gmail.com)
svn path=/trunk/; revision=21745
Magnus Olsen [Wed, 26 Apr 2006 05:06:22 +0000 (05:06 +0000)]
[AUDIT] after looking through code no signs of reverse engineering were found.
BUG 1432 patch from w3seek : Get tools/cabman compile with gcc4
svn path=/trunk/; revision=21744
Magnus Olsen [Wed, 26 Apr 2006 04:59:24 +0000 (04:59 +0000)]
[AUDIT] after looking through code no signs of reverse engineering were found.
BUG 1437 patch from w3seek : SMSS: Fix using uninitialized variable
svn path=/trunk/; revision=21743
Magnus Olsen [Wed, 26 Apr 2006 04:49:11 +0000 (04:49 +0000)]
[AUDIT] after looking through code no signs of reverse engineering were found.
BUG 1436 patch from w3seek : SMSS: make \SystemRoot\System32 the current directory for started subsystems
svn path=/trunk/; revision=21742
Hervé Poussineau [Tue, 25 Apr 2006 22:22:22 +0000 (22:22 +0000)]
Complete IRP_MJ_CREATE, IRP_MJ_CLOSE, IRP_MJ_CLEANUP
Use correct buffer when filling read request. Use SEH when needed
Correctly propagate DO_BUFFERED_IO, DO_DIRECT_IO and FILE_DEVICE_SECURE_OPEN flags
svn path=/trunk/; revision=21741
Ged Murphy [Tue, 25 Apr 2006 21:47:16 +0000 (21:47 +0000)]
fix build
svn path=/trunk/; revision=21740
Andrew Munger [Tue, 25 Apr 2006 01:31:00 +0000 (01:31 +0000)]
21728 broke the release build, use an #ifndef instead.
svn path=/trunk/; revision=21738
Ged Murphy [Mon, 24 Apr 2006 21:36:08 +0000 (21:36 +0000)]
delete sneaky file
svn path=/trunk/; revision=21737
Ged Murphy [Mon, 24 Apr 2006 21:32:54 +0000 (21:32 +0000)]
match the regedit icons to the shell32 ones.
svn path=/trunk/; revision=21736
Ged Murphy [Mon, 24 Apr 2006 21:31:41 +0000 (21:31 +0000)]
match the explorer icons to the shell32 ones.
svn path=/trunk/; revision=21735
Ged Murphy [Mon, 24 Apr 2006 20:26:02 +0000 (20:26 +0000)]
[AUDIT]
sysdm.cpl
Clear formatted Win32 API code fully documented on MSDN.
svn path=/trunk/; revision=21734
Ged Murphy [Mon, 24 Apr 2006 19:09:33 +0000 (19:09 +0000)]
- The start of a revamp of the UI. This is still not yet finished, but I'm committing anyway as it's looks much better already.
- Added a vast amount of resources for shell32. Resources now follow the Windows naming method for compatability with themes (one day).
- Removed the old Wine icons out of the .rc file and each icon is now stored in binary for easy maintenance.
- Many more icons to come for other libs (e.g. comctl32) plus separate programs, followed by the toolbars then moving onto other areas.
- I have some documentation to keep track of the Windows v ReactOS icons, including resource names, if anyone needs to work with it or is just generally nosey :)
svn path=/trunk/; revision=21733
Andrew Munger [Mon, 24 Apr 2006 18:32:35 +0000 (18:32 +0000)]
Create the pagefile at the root of the drive by default. Now when you install to an alternate %systemroot%, you can still have a page file.
svn path=/trunk/; revision=21732
Maarten Bosma [Mon, 24 Apr 2006 18:32:21 +0000 (18:32 +0000)]
Sorry did set DebugPort to COM1
svn path=/trunk/; revision=21731
Maarten Bosma [Mon, 24 Apr 2006 10:54:06 +0000 (10:54 +0000)]
Set Freeloader timeout to 0 for release builds.
svn path=/trunk/; revision=21728
Hervé Poussineau [Mon, 24 Apr 2006 10:51:34 +0000 (10:51 +0000)]
Add some defines
svn path=/trunk/; revision=21727
Magnus Olsen [Sun, 23 Apr 2006 17:31:07 +0000 (17:31 +0000)]
patch from w3seek : create smss with a current directory (system path), Otherwise the current directory for all early processes will be NULL. Fixes some inf installation issues reported by Herve.
svn path=/trunk/; revision=21725
Hervé Poussineau [Sun, 23 Apr 2006 11:41:59 +0000 (11:41 +0000)]
Fully implement SetupDiGetDriverInfoDetailW
svn path=/trunk/; revision=21720
Saveliy Tretiakov [Sun, 23 Apr 2006 08:58:28 +0000 (08:58 +0000)]
[AUDIT]
\trunk\reactos\drivers\filesystems\np (Unlocked)
Eric Kohl confirmed npfs is clean.
svn path=/trunk/; revision=21717
Saveliy Tretiakov [Sun, 23 Apr 2006 08:56:14 +0000 (08:56 +0000)]
[AUDIT]
\trunk\reactos\drivers\filesystems\ms (Unlocked)
Eric Kohl confirmed mailslot filesystem is clean.
svn path=/trunk/; revision=21716
Saveliy Tretiakov [Sun, 23 Apr 2006 08:52:45 +0000 (08:52 +0000)]
[AUDIT]
\trunk\reactos\drivers\filesystems\fs_rec (audit)
Eric Kohl confirmed fs_rec is clean. Inspired by Bo Branten's file system recognizer.
svn path=/trunk/; revision=21715
Hervé Poussineau [Sun, 23 Apr 2006 08:46:25 +0000 (08:46 +0000)]
Fix little bug in mouse detection
Create unnamed FDOs
Read only registry parameters which make sense
Start to read mouse only when receiving IRP_MN_START_DEVICE
Cleanup of code
svn path=/trunk/; revision=21714
Hervé Poussineau [Sun, 23 Apr 2006 08:44:06 +0000 (08:44 +0000)]
[AUDIT]
\trunk\reactos\drivers\input\sermouse (Unlocked)
I (the author) confirmed sermouse is clean.
svn path=/trunk/; revision=21713
Hervé Poussineau [Sat, 22 Apr 2006 18:00:47 +0000 (18:00 +0000)]
Don't tell we succeeded IOCTL_KEYBOARD_QUERY_INDICATORS and IOCTL_KEYBOARD_QUERY_INDICATOR_TRANSLATION, as it is not true.
Fixes bug 1408
svn path=/trunk/; revision=21711
Saveliy Tretiakov [Sat, 22 Apr 2006 16:36:21 +0000 (16:36 +0000)]
[AUDIT]
\trunk\reactos\drivers\filesystems\cdfs (Unlocked)
Eric Kohl confirmed cdfs is clean. Based on vfatc code and iso-9660 documentation.
svn path=/trunk/; revision=21710