Pierre Schweitzer [Thu, 16 Aug 2018 16:54:23 +0000 (18:54 +0200)]
[NTOSKRNL] Don't need all access for file object
Pierre Schweitzer [Thu, 16 Aug 2018 16:49:55 +0000 (18:49 +0200)]
[NTOSKRNL] Add a check commented out for now.
It's to be enabled once page file handling is moved to ARM3
Pierre Schweitzer [Thu, 16 Aug 2018 16:40:23 +0000 (18:40 +0200)]
[NTOSKRNL] MmTotalCommitLimit and MmTotalCommitLimitMaximum are in pages, not bytes
Oleksandr Shaposhnikov [Thu, 16 Aug 2018 15:11:53 +0000 (18:11 +0300)]
[CONFIGURE] Added support for new VS 19.15.x
Timo Kreuzer [Sun, 4 Feb 2018 12:30:47 +0000 (13:30 +0100)]
[NTOS:MM] Make SLIST handling for kernel stacks portable
Kernel stacks that re freed, can be placed on an SLIST for quick reuse. The old code was using a member of the PFN of the last stack page as the SLIST_ENTRY. This relies on the following (non-portable) assumptions:
- A stack always has a PTE associated with it.
- This PTE has a PFN associated with it.
- The PFN has an empty field that can be re-used as an SLIST_ENTRY.
- The PFN has another field that points back to the PTE, which then can be used to get the stack base.
Specifically: On x64 the PFN field is not 16 bytes aligned, so it cannot be used as an SLIST_ENTRY. (In a "usermode kernel" the other assumptions are also invalid).
The new code does what Windows does (and which seems absolutely obvious to do): Place the SLIST_ENTRY directly on the stack.
Timo Kreuzer [Sun, 4 Feb 2018 19:07:17 +0000 (20:07 +0100)]
[NTOS:SE] Fix SeSetSecurityDescriptorInfoEx to prevent pool corruption on x64
Getequ [Thu, 16 Aug 2018 14:10:41 +0000 (21:10 +0700)]
[ADVAPI32][SHELL32][DESK.CPL] Kill copy-paste of RegLoadMUIString. (#748)
RegLoadMUIStringW/A is part of advapi32.dll . shell32.dll and desk.cpl contained exact line-by-line copy of that function.
Serge Gautherie [Thu, 16 Aug 2018 13:10:24 +0000 (15:10 +0200)]
[NTOS:MM] Update a DPRINT string (#760)
CORE-12729
Katayama Hirofumi MZ [Thu, 16 Aug 2018 12:38:46 +0000 (21:38 +0900)]
[FONT][WIN32SS] Support MS symbol encoding (#759)
This commit adds support for the MS symbol encoding (FT_ENCODING_MS_SYMBOL) in our font engine.
It also fixes the display of the Anastasia font. And replacing our Marlett font with Windows' Marlett font is also fixed.
CORE-13269, CORE-14907
Thomas Faber [Thu, 16 Aug 2018 12:10:35 +0000 (14:10 +0200)]
[USBPORT] Fix 64 bit warnings.
Thomas Faber [Thu, 16 Aug 2018 12:10:15 +0000 (14:10 +0200)]
[USBPORT] Specify the correct length for the root hub's hub descriptor.
Thomas Faber [Wed, 15 Aug 2018 10:49:42 +0000 (12:49 +0200)]
[USBPORT] Remove an unnecessary check in USBPORT_AllocateBandwidthUSB2. CID
1434261
Thomas Faber [Wed, 15 Aug 2018 10:22:02 +0000 (12:22 +0200)]
[USBPORT] Remove an unnecessary check in USB2_ConvertFrame. CID
1434244
Thomas Faber [Wed, 15 Aug 2018 10:20:01 +0000 (12:20 +0200)]
[USBPORT] Accept negative BusTime in USB2_MoveTtEndpoint. CID
1434226
Thomas Faber [Sun, 12 Aug 2018 13:47:12 +0000 (15:47 +0200)]
[WIN32K:NTUSER] Fix type confusion in MsgMemorySize.
Pierre Schweitzer [Thu, 16 Aug 2018 12:04:27 +0000 (14:04 +0200)]
[NTOSKRNL] Start making our MMPAGING_FILE struct look like the real one
Pierre Schweitzer [Thu, 16 Aug 2018 11:50:16 +0000 (13:50 +0200)]
[NTOSKRNL] Store page file sizes in pages, not in bytes
Pierre Schweitzer [Thu, 16 Aug 2018 11:41:16 +0000 (13:41 +0200)]
[NTOSKRNL] Store page file minimum size and use it to prevent page file shrinking
Pierre Schweitzer [Thu, 16 Aug 2018 10:42:34 +0000 (12:42 +0200)]
[NTOSKRNL] Page files don't have an init size, but a minimum size
NFC
Pierre Schweitzer [Thu, 16 Aug 2018 10:39:24 +0000 (12:39 +0200)]
[NTOSKRNL] Drop the MmPagingFile spin lock in favor of a guarded mutex
Pierre Schweitzer [Thu, 16 Aug 2018 10:16:39 +0000 (12:16 +0200)]
[NTOSKRNL] Drop the alloc map from page file
It was making no sense, and implemented in a broken way
that couldn't have worked if code path was used.
Pierre Schweitzer [Thu, 16 Aug 2018 09:58:58 +0000 (11:58 +0200)]
[NTOSKRNL] Stub page file extension support
Katayama Hirofumi MZ [Wed, 15 Aug 2018 17:50:19 +0000 (02:50 +0900)]
[WIN32SS] Fix DrawText wrt DT_CALCRECT | DT_VCENTER (#745)
The test program: https://jira.reactos.org/secure/attachment/47925/TnB3.zip
CORE-14896
Stanislav Motylkov [Sat, 11 Aug 2018 09:56:08 +0000 (12:56 +0300)]
[SYSDM] Use single string control for system version
Katayama Hirofumi MZ [Wed, 15 Aug 2018 16:32:17 +0000 (01:32 +0900)]
[SYSSETUP] Fix the button sizes of theme selection dialog (#746)
CORE-14896
Mike Swanson [Tue, 14 Aug 2018 23:10:55 +0000 (16:10 -0700)]
Remove unnecessary executable bits
Denis Malikov [Wed, 15 Aug 2018 15:05:03 +0000 (22:05 +0700)]
[WIN32SS][USER] fixing couple typos for WINVER >= 0x600
CORE-12596
Pierre Schweitzer [Wed, 15 Aug 2018 14:38:56 +0000 (16:38 +0200)]
[BTRFS] Leak the root stream file object on mount.
For whatever (unknown) reason yet, this stream file object
seems to be deleted when still in use while installing
ReactOS on BtrFS partition, leading to use after free.
So, quick and dirty hack: leak it to prevent deletion.
CORE-13769
Pierre Schweitzer [Wed, 15 Aug 2018 14:35:05 +0000 (16:35 +0200)]
[BTRFS] Allow driver to start at first stage when no hive is present.
Contrary to upstream, we will ignore failure when opening registry
and will keep going.
CORE-13769
Mark Jansen [Wed, 1 Aug 2018 20:15:51 +0000 (22:15 +0200)]
[APPHELP_APITEST] Fix rc dependency.
As pointed out by Thomas.
Mark Jansen [Sun, 29 Jul 2018 17:45:13 +0000 (19:45 +0200)]
[RTL][KERNEL32] Add a comment indicating we need SEH in RtlImageNtHeaderEx
CORE-14532
CORE-14857
Mark Jansen [Sun, 29 Jul 2018 15:40:42 +0000 (17:40 +0200)]
[LDR] Guard some sections where we grab a lock.
CORE-14532
Mark Jansen [Sat, 14 Apr 2018 19:00:18 +0000 (21:00 +0200)]
[NTDLL_APITEST] Show behavior with exceptions in DllMain.
CORE-14532
Mark Jansen [Sun, 29 Jul 2018 15:13:42 +0000 (17:13 +0200)]
[LDR] Add debug logging when we encountered an exception in dll/tls callbacks.
CORE-14532
Mark Jansen [Sun, 8 Apr 2018 19:51:20 +0000 (21:51 +0200)]
[LDR] Protect calls from LdrpCallInitRoutine and LdrpCallTlsInitializers with SEH.
CORE-14532
Pierre Schweitzer [Mon, 13 Aug 2018 06:29:17 +0000 (08:29 +0200)]
[NTOSKRNL] Don't use anonymus allocations for MM objects
Pierre Schweitzer [Mon, 13 Aug 2018 06:24:39 +0000 (08:24 +0200)]
[NTOSKRNL] Keep page file name along the page file and free it on shutdown
Pierre Schweitzer [Mon, 13 Aug 2018 06:23:44 +0000 (08:23 +0200)]
[NTOSKRNL] Dereference page file objects in MM shutdown phase 1
Hack the call the MM shutdown phase 1
Pierre Schweitzer [Mon, 13 Aug 2018 05:52:05 +0000 (07:52 +0200)]
[NTOSKRNL] Close page files (and delete them!) on shutdown
Pierre Schweitzer [Mon, 13 Aug 2018 05:42:57 +0000 (07:42 +0200)]
[NTOSKRNL] Stub MM shutdown
Eric Kohl [Sun, 12 Aug 2018 20:19:05 +0000 (22:19 +0200)]
[UMPNPMGR] Partially implement ReenumerateDeviceInstance which is needed by the Lenovo T400 network driver installer
Stanislav Motylkov [Tue, 31 Jul 2018 15:57:58 +0000 (18:57 +0300)]
[SYSTEMINFO] Fix various bugs and add SMBIOS support
Katayama Hirofumi MZ [Sun, 12 Aug 2018 13:12:13 +0000 (22:12 +0900)]
[WIN32SS][FONT] Fix font metrics (#713)
Fix vertical alignment and Aspect penalty; improve font penalty system; fixes for Wine tests.
This is an update of #706. See CORE-11536 for more details.
The display of the following programs is fixed:
- Total Commander 8.52 setup: font displayed too large - CORE-11620.
- Effective File Search 6.8.1 german localization text rendering issues - CORE-14378.
- Font garbage in register splash screen in Foxit Reader 7.1.5 - CORE-9767.
- Calipers-1 is not displayed correctly - CORE-14302.
- Some MSI-installers draw their dialogs too large (example: Click-N-Type Virtual Keyboard 3.03.0412) - CORE-13161.
- Irfanview 4.50: font in zoom combobox displayed too large - CORE-14396.
- Rufus: The window and controls are displayed larger than necessary - CORE-14461.
Eric Kohl [Sun, 12 Aug 2018 12:13:26 +0000 (14:13 +0200)]
[NETAPI32] Add DFS RPC interface and some DFS stubs
Stanislav Motylkov [Sun, 12 Aug 2018 09:11:39 +0000 (12:11 +0300)]
[DXDIAG] Fix wrapped controls in russian translation
Stanislav Motylkov [Fri, 3 Aug 2018 21:22:49 +0000 (00:22 +0300)]
[DXDIAG] Minor code style fixes
Stanislav Motylkov [Tue, 31 Jul 2018 15:52:09 +0000 (18:52 +0300)]
[DXDIAG] Fix blank system and BIOS values
CORE-5961 #resolve
Stanislav Motylkov [Tue, 31 Jul 2018 15:48:32 +0000 (18:48 +0300)]
[SDK] Add user-mode DMI/SMBIOS helper library
CORE-5961
Katayama Hirofumi MZ [Sun, 12 Aug 2018 09:23:16 +0000 (18:23 +0900)]
[MSPAINT] Fix interpretation of command line (#707)
Pierre Schweitzer [Sun, 12 Aug 2018 08:05:25 +0000 (10:05 +0200)]
[KMTESTS:MM] Properly clean up files
This fixes driver unloading on Windows.
ROSTESTS-266
Pierre Schweitzer [Sat, 11 Aug 2018 21:34:08 +0000 (23:34 +0200)]
[NTOSKRNL] Misc fixes:
- Rename page file struct to MMPAGING_FILE
- Increment page files count after current page file was put in the list
Pierre Schweitzer [Sat, 11 Aug 2018 21:19:58 +0000 (23:19 +0200)]
[NTOSKRNL] Rename PagingFileList to MmPagingFile and make insertion simpler
Pierre Schweitzer [Sat, 11 Aug 2018 21:07:53 +0000 (23:07 +0200)]
[NTOSKRNL] Remove useless define
Pierre Schweitzer [Sat, 11 Aug 2018 20:47:58 +0000 (22:47 +0200)]
[NTOSKRNL] Replace the alloc map by a bitmap
Pierre Schweitzer [Sat, 11 Aug 2018 20:06:41 +0000 (22:06 +0200)]
[NTOSKRNL] Drop unused field
Pierre Schweitzer [Sat, 11 Aug 2018 16:37:31 +0000 (18:37 +0200)]
[NTOSKRNL] Revert r4668 (yeah, that was 15y ago)
It's hardly understandable and doesn't really makes sense.
Furthermore, it breaks compatibility with 3rd party FSD that
don't implement such FSCTL.
Obviously, Windows doesn't do this.
Pierre Schweitzer [Fri, 10 Aug 2018 06:40:02 +0000 (08:40 +0200)]
[NTOSKRNL] Restrict rights on the page file
Pierre Schweitzer [Fri, 10 Aug 2018 06:01:31 +0000 (08:01 +0200)]
[NTOSKRNL] Deny page file creation on floppy disk
Pierre Schweitzer [Fri, 10 Aug 2018 05:50:16 +0000 (07:50 +0200)]
[NTOSKRNL] Properly open a page file and set appropriate attributes
Pierre Schweitzer [Thu, 9 Aug 2018 19:13:08 +0000 (21:13 +0200)]
[NTOSKRNL] Check that caller has appropriate right before creating page file
Eric Kohl [Sat, 11 Aug 2018 20:25:30 +0000 (22:25 +0200)]
[DLLHOST] Add dllhost to make the device driver extractor for my Lenovo T400 happy
Katayama Hirofumi MZ [Fri, 10 Aug 2018 13:37:37 +0000 (22:37 +0900)]
[WIN32SS][FONT] Fix the system logical stock font data (#709)
This fixes the stock font data to improve font selection.
CORE-14885
Katayama Hirofumi MZ [Fri, 10 Aug 2018 11:25:50 +0000 (20:25 +0900)]
[SHELL32] Fix a careless mistake of ShellExecCmdLine (#737)
CORE-14886
Katayama Hirofumi MZ [Wed, 18 Jul 2018 20:02:49 +0000 (05:02 +0900)]
[CONSRV] Implement support for file/directory drag-and-drop (#692).
CORE-14833
Serge Gautherie [Wed, 4 Jul 2018 01:42:04 +0000 (03:42 +0200)]
[REACTOS] Improve how some ASSERTMSG() message values are printed: enforce ending "\n".
NB: Not touching calls in "third-party" code: class and classpnp.
Serge Gautherie [Mon, 2 Jul 2018 09:45:01 +0000 (11:45 +0200)]
[CMLIB] Simplify an ASSERTMSG() as an ASSERT().
Hermès Bélusca-Maïto [Wed, 8 Aug 2018 19:37:22 +0000 (21:37 +0200)]
[BOOTLIB] Fix the implementation of RtlAssert() ('Message' can be NULL, and fix the printing of ANSI string). Fix also the implementation of DbgPrint().
Serge Gautherie [Thu, 21 Jun 2018 03:05:50 +0000 (05:05 +0200)]
[REACTOS] RtlAssert(): use "%lu" as LineNumber format.
Hermès Bélusca-Maïto [Wed, 8 Aug 2018 18:45:39 +0000 (20:45 +0200)]
[CONSRV] Minor code re-organization.
Hermès Bélusca-Maïto [Wed, 8 Aug 2018 18:38:41 +0000 (20:38 +0200)]
[CONSRV] Add a PasteText() helper function and use it.
Thomas Faber [Wed, 8 Aug 2018 17:58:56 +0000 (19:58 +0200)]
[HAL] Remove misleading debug prints about USB controllers.
Hermès Bélusca-Maïto [Tue, 7 Aug 2018 17:40:06 +0000 (19:40 +0200)]
[CMD] Small translation update.
Bișoc George [Tue, 7 Aug 2018 18:31:56 +0000 (20:31 +0200)]
[TRANSLATION][WMIC] Add Italian translation
Eric Kohl [Tue, 7 Aug 2018 20:56:33 +0000 (22:56 +0200)]
[WLNOTIFY] Add sens service stubs
Serge Gautherie [Fri, 2 Feb 2018 23:19:18 +0000 (00:19 +0100)]
[NTOSKRNL] Round memory size up, "debug log" part
Assumed to better match actual physical RAM size.
CORE-12321
Jared Smudde [Tue, 7 Aug 2018 11:22:03 +0000 (06:22 -0500)]
[BOOTDATA] Change the default open command for HTA files to open in Wine Internet Explorer. (#719)
It's a shortcut from implementing the function in mshtml but it works.
Also add an edit option to the right click menu.
Hermès Bélusca-Maïto [Mon, 6 Aug 2018 20:36:14 +0000 (22:36 +0200)]
[CMD] Add speed-optimized checks for dot-directories "." and ".." .
Adapted from PR #592 by Katayama Hirofumi MZ.
Hermès Bélusca-Maïto [Mon, 6 Aug 2018 19:46:38 +0000 (21:46 +0200)]
[CMD] Fix the way the DIR-command pattern is interpreted when it contains paths or filenames with trailing dots.
Particular DIR commands like: "DIR .", "DIR .." now work as expected,
and we also correctly fix the behavior for files without extension,
that r38746 (
2b06cfc0) originally tried to fix but broke the previous
examples.
Therefore "DIR *." and "DIR noextfile." work too.
Pathological cases like "DIR \...", "DIR \...\.", "DIR ..\...\.." and
the like (and with more than 3 dots) now work as expected.
Adapted from PR #592 by Katayama Hirofumi MZ, but with extended bugfixing.
CORE-13961
Hermès Bélusca-Maïto [Mon, 6 Aug 2018 19:22:27 +0000 (21:22 +0200)]
[CMD] Code formatting; use LPCTSTR where possible; use a MAX_PATH sized dircmd buffer.
Katayama Hirofumi MZ [Mon, 25 Jun 2018 00:53:45 +0000 (09:53 +0900)]
[CMD] Create a DirNodeCleanup() helper for cleanup and simplify code (adapted from PR #592).
Hermès Bélusca-Maïto [Sun, 29 Jul 2018 23:36:43 +0000 (01:36 +0200)]
[CMD] Fix French translation.
Mark Jansen [Sun, 5 Aug 2018 20:14:44 +0000 (22:14 +0200)]
[NTOSKRNL] Fix a nullptr dereference in IopStartDevice
Hermès Bélusca-Maïto [Mon, 6 Aug 2018 15:30:21 +0000 (17:30 +0200)]
[WINLOGON] Hack-fix for CORE-14877 ; see commit
bcec1fd6.
Hermès Bélusca-Maïto [Mon, 6 Aug 2018 15:29:34 +0000 (17:29 +0200)]
[WINLOGON][MSGINA] Fix typo.
Eric Kohl [Sun, 5 Aug 2018 18:02:22 +0000 (20:02 +0200)]
[SYSSETUP] SetupStartService: Wait until the service is running
Eric Kohl [Sun, 5 Aug 2018 14:16:53 +0000 (16:16 +0200)]
[ADVAPI32] Add parameter checks to LogonUserExW and initialize the token handle.
Eric Kohl [Sun, 5 Aug 2018 13:57:03 +0000 (15:57 +0200)]
[NETAPI32] Implement I_NetServerSetServiceBits()
Eric Kohl [Sun, 5 Aug 2018 13:36:48 +0000 (15:36 +0200)]
[NETAPI32] Add annotations and move NetUseGetInfo to a better location.
Eric Kohl [Sun, 5 Aug 2018 13:04:01 +0000 (15:04 +0200)]
[SRVSVC] Set and retrieve service bits and rename unknown functions
- Service bits are set by NetrServerSetServiceBits and can be retrieved by NetrServerGetInfo.
- The real name of function 42 is NetrServerSetServiceBitsEx and the real name of function 47 is NetrDfsSetServerInfo.
Katayama Hirofumi MZ [Sun, 5 Aug 2018 11:39:17 +0000 (20:39 +0900)]
[SHELL32] Fix handling of multiple parameters in the 'Run' dialog (#665)
The "Run" dialog failed when multiple parameters wee specified.
We use instead a newly-created ShellExecCmdLine() helper function to fix the problem (as found via API-tracing on Windows).
Note that ShellExecCmdLine() starts to be exported with Vista+.
- Implement ShellExecCmdLine() function in shell32.
- Add URL support.
- Fix RunDlgProc function in shell32.
- Add a testcase for ShellExecCmdLine() function.
CORE-14790
Thomas Faber [Sun, 5 Aug 2018 10:57:25 +0000 (12:57 +0200)]
[MSCONFIG] Fix buffer overflow when handling long service command lines.
Mark Jansen [Thu, 2 Aug 2018 20:36:17 +0000 (22:36 +0200)]
[ZIPFLDR] Add 'Extract All' to individual item context menu.
Mark Jansen [Thu, 2 Aug 2018 19:36:54 +0000 (21:36 +0200)]
[ZIPFLDR] Add 'Extract All' menu item to the folder context menu.
Mark Jansen [Fri, 3 Aug 2018 18:45:20 +0000 (20:45 +0200)]
[ATL] Fix the CComQIIDPtr template.
Mark Jansen [Sat, 21 Apr 2018 22:00:34 +0000 (00:00 +0200)]
[ZIPFLDR] Implement RouteTheCall, so that applications can 'launch' zip files
Denis Malikov [Sun, 4 Feb 2018 15:59:21 +0000 (22:59 +0700)]
[HAL] Add NT6-compatible version of HalpMapPhysicalMemory64 and HalpUnmapVirtualAddress
Eric Kohl [Sat, 4 Aug 2018 23:05:52 +0000 (01:05 +0200)]
[LSASRV] Implement and call the policy change notification routine
Eric Kohl [Sat, 4 Aug 2018 20:17:52 +0000 (22:17 +0200)]
[LSASRV][SECUR32] Implement LsaRegisterPolicyChangeNotification and LsaUnregisterPolicyChangeNotification
Timo Kreuzer [Sat, 7 Jul 2018 14:09:03 +0000 (16:09 +0200)]
[REACTOS] Fix 64 bit issues
Timo Kreuzer [Mon, 23 Apr 2018 09:42:32 +0000 (11:42 +0200)]
[DLLS] Fix 64 bit issues