Hermès Bélusca-Maïto [Fri, 2 Feb 2018 20:48:18 +0000 (21:48 +0100)]
[CONUTILS] Fix and improve the documentation for "outstream" and "utils", addendum to
f982d77.
Hermès Bélusca-Maïto [Thu, 1 Feb 2018 23:35:08 +0000 (00:35 +0100)]
[CONUTILS] Diverse improvements: start doxygenating and add some resource messsage helper functions.
- Start to doxygenate the library, focusing in great details on the
functions of the "outstream" module.
- Add a K32LoadStringEx function that expands (K32)LoadString by
allowing a LanguageId parameter to be able to load strings from other
languages than the current one.
- Add "ConResMsg*" helper functions to be able to (format and) print
message strings with inserts that come *NOT* from a message table (as
usual) *BUT* from resource string tables.
Will be helpful for CORE-14265 in particular.
[CMD] Fix the call to ConMsgPrintfV().
Pierre Schweitzer [Thu, 1 Feb 2018 07:35:27 +0000 (08:35 +0100)]
[NTOSKRNL] Add an helper for marking a VACB clean (ie, not dirty).
CORE-14263
Luo Yufan [Thu, 1 Feb 2018 01:50:29 +0000 (09:50 +0800)]
[TRANSLATION] Simplified Chinese translations updated. (#348)
Pierre Schweitzer [Wed, 31 Jan 2018 20:28:40 +0000 (21:28 +0100)]
[NTOSKRNL] Don't let CcWriteVirtualAddress() deal with VACB dirty status
CORE-14263
Stanislav Motylkov [Wed, 24 Jan 2018 13:32:51 +0000 (16:32 +0300)]
[IPHLPAPI_APITEST] Add tests for IcmpSendEcho
Stanislav Motylkov [Tue, 23 Jan 2018 21:28:55 +0000 (00:28 +0300)]
[IPHLPAPI] Fix IcmpSendEcho output when host is not reachable
- Add missing error code to DDK/NDIS
- Fix error code in IP driver
- Patch MSAFD to reply correct WSA error code
- Fix IcmpSendEcho function
- Fix returning error code in ICMP_ECHO_REPLY (see MSDN)
- Fix returning host address (using GetBestInterface and GetIpAddrTable functions)
- Fix GetBestRoute function (it is used by GetBestInterface)
Relates to #318 and CORE-14241
Stanislav Motylkov [Wed, 31 Jan 2018 15:05:45 +0000 (18:05 +0300)]
[SHELL32] Fix file and folder properties dialogs
CORE-12755
David Quintana [Wed, 31 Jan 2018 17:12:57 +0000 (18:12 +0100)]
[NTOSKRNL] Fix CcIdleDelay initializer for old msvc versions (#339)
[NTOSKRNL] Fix initialization of CcIdleDelay for msvc builds (fixes boot).
* Introduce a macro to initialize LARGE_INTEGERs in a consistent way.
Thomas Faber [Wed, 31 Jan 2018 11:34:41 +0000 (12:34 +0100)]
[WIN32K:NTGDI] Fix more uses of RtlCreateUnicodeString. CORE-14271
Addendum to
7f687154a0fe47826d8047f1a4f9cfd93414d45f. Spotted by Hermès.
Doug Lyons [Tue, 16 Jan 2018 15:40:03 +0000 (16:40 +0100)]
[TIMEDATE] Correctly set the time when using the "Update now" button. CORE-14167
Thomas Faber [Wed, 31 Jan 2018 10:47:39 +0000 (11:47 +0100)]
[SHELLMENU] Add missing psdk dependency.
Trevor Thompson [Sun, 10 Dec 2017 10:35:10 +0000 (11:35 +0100)]
[CMAKE] Add some fool-proofing to configure.cmd related to MSVS:
-VSSolution switch now outputs to a dedicated folder if running from source directory.
-Give an error if the user is trying to mix ninja and VSSolution in the same output directory.
-In a MingW environment, give an error on VSSolution switch and give a warning on RTC switch.
-Fix -DNEW_STYLE_BUILD=0 option.
-Ensure the source path doesn't contain any spaces.
-Issue a warning if passed an invalid switch.
-Don't announce completion if there were errors.
-Make end message specific for VSSolution.
-Replace redundant exit commands with quit label, as suggested by HBelusca.
Thomas Faber [Wed, 31 Jan 2018 09:23:44 +0000 (10:23 +0100)]
[KMTESTS:TCPIP] Fix ok() messages.
Thomas Faber [Wed, 31 Jan 2018 09:26:24 +0000 (10:26 +0100)]
[WIN32K:NTGDI] Correctly interpret RtlCreateUnicodeString return value. CORE-14271
Thomas Faber [Sun, 28 Jan 2018 12:42:13 +0000 (13:42 +0100)]
[NTOS:CM] Correctly interpret RtlCreateUnicodeString return value. CORE-14271
Hermès Bélusca-Maïto [Mon, 16 Oct 2017 21:58:23 +0000 (23:58 +0200)]
[CONUTILS] Split stream.c into input and output stream modules.
As code grows, this will allow for better maintenance of the console
stream code. In particular the input stream module will contain special
code for handling TTYs, and this is something not all console programs
will need. Having this code in a separate module will allow for the linker
to possibly remove this code when it is unused.
Luo Yufan [Tue, 30 Jan 2018 20:49:40 +0000 (04:49 +0800)]
[TRANSLATION] Simplified Chinese translation improved. (#346)
Katayama Hirofumi MZ [Tue, 30 Jan 2018 19:36:59 +0000 (04:36 +0900)]
[SHIMGVW] Enable zooming
* merge ZoomIn and ZoomOut functions
* NULL to hbrBackground
* use GET_X_LPARAM and GET_Y_LPARAM for WM_MOUSEWHEEL
Joachim Henze [Tue, 30 Jan 2018 17:42:21 +0000 (18:42 +0100)]
[EXPLORER] Pixel-perfect x-margins surrounding the clock
To look like XP/2k3.
Relies on
d11e7af5f2539c417e980ba1b3a622f8da450603
CORE-14272
Jared Smudde [Tue, 30 Jan 2018 17:07:09 +0000 (11:07 -0600)]
[NETCFGX] Rename 'Network connection' to 'Network Connection'. (#345)
English capitalization fix. It should look a little better both in the system tray and in the Network Connections folder.
Daniel Reimer [Mon, 29 Jan 2018 22:43:34 +0000 (23:43 +0100)]
[CAROOTS] Update certificates to Mozilla Certdata 28.01.18 (#338)
Timo Kreuzer [Sun, 28 Jan 2018 16:05:15 +0000 (17:05 +0100)]
Revert "[OLEAUT32] Sync with Wine 3.0. CORE-14225"
This reverts commit
13fd286c1840f80c0fca1dbfedd600a0f8a4478b.
The "sync" zapped a lot of fixes, in particular 64 bit compatibility.
Bișoc George [Mon, 29 Jan 2018 21:33:22 +0000 (22:33 +0100)]
[TRANSLATION][CLIPBRD] Italian translation implemented (#344)
Stanislav Motylkov [Mon, 29 Jan 2018 18:27:03 +0000 (21:27 +0300)]
[DESK.CPL] Fix dialog appearance in 640x480 resolution
CORE-14274
Mark Jansen [Mon, 29 Jan 2018 16:57:19 +0000 (17:57 +0100)]
[ACPPAGE] Visualize custom layers
Mark Jansen [Sat, 27 Jan 2018 16:41:58 +0000 (17:41 +0100)]
[ACPPAGE] Hide shims handled by the main ui.
Giannis Adamopoulos [Mon, 29 Jan 2018 20:32:17 +0000 (22:32 +0200)]
[EXPLORER] Improve the width of the taskbar clock
Don't take into account TRAY_CLOCK_WND_SPACING_X twice
Increase TRAY_CLOCK_WND_SPACING_X
Giannis Adamopoulos [Mon, 29 Jan 2018 19:50:33 +0000 (21:50 +0200)]
[EXPLORER] Center the text of the clock
CTrayClockWnd: Fix the calculation that centered the text of the clock.
CTrayNotifyWnd: Restore the 1 pixel margin between the clock and the pager.
Joachim Henze [Mon, 29 Jan 2018 18:15:50 +0000 (19:15 +0100)]
[EXPLORER] Tweak x-margins surrounding the clock
To look more like XP/2k3.
Not pixel-perfect yet, that would require asymmetric margins.
CORE-14272
Bișoc George [Mon, 29 Jan 2018 17:23:52 +0000 (18:23 +0100)]
[TRACERT] Translation for Italian and Romanian language (#333)
Luo Yufan [Mon, 29 Jan 2018 17:21:20 +0000 (01:21 +0800)]
[TRANSLATION] Update Simplified Chinese Translations of SHELL32 and USRMGR (#340)
Giannis Adamopoulos [Mon, 29 Jan 2018 16:13:22 +0000 (18:13 +0200)]
[EXPLORER] Fix showing the lock status in the taskbar popup menu
Joann Mõndresku [Mon, 29 Jan 2018 16:03:27 +0000 (18:03 +0200)]
[TRANSLATION] Various translations to Estonian (#329)
Estonian translations for shell + explorer, cpl files (access, appwiz, desk, timedate), devmgr, browseui, comctl32, aclui, avifil32, comdlg32 and credui.
Giannis Adamopoulos [Mon, 29 Jan 2018 15:51:06 +0000 (17:51 +0200)]
[COMCTL32] toolbar: Use szBarPadding.cy as the default top margin
Giannis Adamopoulos [Mon, 29 Jan 2018 15:28:29 +0000 (17:28 +0200)]
[EXPLORER] CNotifyToolbar: Set TBMETRICS::cxBarPad and TBMETRICS::cyBarPad
MSDN says that these values are not used but apparently they are used as a padding around the buttons.
This helps to center the buttons in the notification area.
Alexander Shaposhnikov [Mon, 29 Jan 2018 14:09:04 +0000 (16:09 +0200)]
[CONTRIBUTING] Update .gitmessage template
Alexander Shaposhnikov [Sat, 27 Jan 2018 22:51:48 +0000 (00:51 +0200)]
[CONTRIBUTING] Add a commit template and a paragraph about it
This template defines a general commit style, and will be most
helpful for newcomers. I will be using it personally :)
Giannis Adamopoulos [Sun, 28 Jan 2018 22:27:45 +0000 (00:27 +0200)]
[EXPLORER] CTrayWindow: Draw the sizer only when the taskbar is not locked.
Giannis Adamopoulos [Sun, 28 Jan 2018 20:38:48 +0000 (22:38 +0200)]
[EXPLORER] CTrayNotifyWnd: Fix resizing when the clock is hidden
Giannis Adamopoulos [Sun, 28 Jan 2018 20:04:34 +0000 (22:04 +0200)]
[EXPLORER] CTrayNotifyWnd: Only update the requested dimension when handling TNWM_GETMINIMUMSIZE.
Giannis Adamopoulos [Sun, 28 Jan 2018 17:20:12 +0000 (19:20 +0200)]
[EXPLORER] CTaskSwitchWnd: Implement getting the setting for grouping tasks. This doesn't work yet but the setting does get stored in m_IsGroupingEnabled. TSWM_ENABLEGROUPING is not needed.
Giannis Adamopoulos [Sun, 28 Jan 2018 16:59:18 +0000 (18:59 +0200)]
[EXPLORER] CTrayClockWnd: Implement showing and hiding seconds or the whole clock from the properties window.
Giannis Adamopoulos [Sun, 28 Jan 2018 12:21:45 +0000 (14:21 +0200)]
[EXPLORER] -Make CSysPagerWnd, CTaskSwitchWnd, CTrayClockWnd and CTrayNotifyWnd proper com objects so that their lifetime is managed properly.
Alex Ionescu [Sun, 28 Jan 2018 15:29:43 +0000 (16:29 +0100)]
[ROSLOAD]: Fix NX enabling
[ROSLOAD]: The IA32_MISC_ENABLE MSR bit actually _disables_ NX, so
diabling the bit _enables_ NX.
[ROSLOAD]: The MSR_XD_ENABLE_MASK is for the _high_ DWORD of the MSR
(bit 34), not the low.
[ROSLOAD]: Fix printf.
[ENVIRON/ROSLOAD]: Switch to CPU_INFO structure instead of blindly using
INT[4]. Revealed a bug in the PAE detection which was reading out of
bounds.
Alex Ionescu [Sun, 28 Jan 2018 12:24:20 +0000 (13:24 +0100)]
[ROSLOAD] Initial support for launching OS Loader Entrypoint and returning from it
[ENVIRON]: Implement BlArchGetCpuVendor
[ROSLOAD]: Stub OslPrepareTarget, OslExecuteTransition
[ROSLOAD]: Implement OslpMain
Pierre Schweitzer [Sun, 28 Jan 2018 10:55:40 +0000 (11:55 +0100)]
[NTOSKRNL] Drop ROS_DEFERRED_WRITE_CONTEXT in favor of DEFERRED_WRITE
that was introduced in
d3e0eb2.
CORE-14235
Pierre Schweitzer [Sun, 28 Jan 2018 10:09:21 +0000 (11:09 +0100)]
[NTOSKRNL] Misc fixes to Cc:
- CcUnpinDataForThread() only release VACB when the last BCB reference is gone. This avoids having a valid BCB with an invalid VACB
- CcRosMarkDirtyVacb() will only accept non-dirty VACB now. This avoids a major bug where a an already dirty VACB was over-dereferenced
- Thanks to previous point, simplify CcRosUnmapVacb(), CcRosReleaseVacb() implementation
- And only set VACB dirty once in CcSetDirtyPinnedData()
- Add a few sanity checks
With that I can again install ReactOS with 128MB RAM :-).
CORE-14263
CORE-14268
Thomas Faber [Sun, 28 Jan 2018 09:34:21 +0000 (10:34 +0100)]
[NDK] Add DEFERRED_WRITE structure for Cc. CORE-14235
Consistently use CSHORT for NodeTypeCode/NodeByteSize while we're at it.
Thomas Faber [Fri, 26 Jan 2018 12:56:06 +0000 (13:56 +0100)]
[NTOS:MM] Assert MmLocateMemoryAreaByAddress return value to satisfy Coverity. CID 701289
Thomas Faber [Fri, 26 Jan 2018 12:45:53 +0000 (13:45 +0100)]
[NTOS:PS] Check for rundown success in PsReferenceProcessFilePointer. CID 514553
Eric Kohl [Sat, 27 Jan 2018 23:57:58 +0000 (00:57 +0100)]
[SERVICES] Do not delete running services.
CORE-14260
Pierre Schweitzer [Sat, 27 Jan 2018 21:02:01 +0000 (22:02 +0100)]
[NTOSKRNL] Fix MSVC build?
Pierre Schweitzer [Sat, 27 Jan 2018 20:51:33 +0000 (21:51 +0100)]
[NTOSKRNL] Hello CcIdleDelay :-)
(Good link for the interested reader: https://msdn.microsoft.com/en-us/library/
bb742613.aspx)
Serge Gautherie [Sat, 27 Jan 2018 19:54:26 +0000 (20:54 +0100)]
[SC] print.c: Minor code improvements. (#324)
- Plus: Update license header.
- Re-use PrintServiceStatus(), as SERVICE_STATUS_PROCESS is in fact an extension of SERVICE_STATUS.
- Use the "SERVICE_*" defines, not magic numbers.
Giannis Adamopoulos [Fri, 26 Jan 2018 23:27:24 +0000 (01:27 +0200)]
[EXPLORER] CTrayNotifyWnd: Simplify how it interacts with its parent and children. Clean up.
Pierre Schweitzer [Sat, 27 Jan 2018 17:37:34 +0000 (18:37 +0100)]
[NTOSKRNL] On file cache deletion, only manipulate VACB once locked.
Should help avoiding race conditions with lazy write.
CORE-14263
Mark Jansen [Sat, 27 Jan 2018 17:10:50 +0000 (18:10 +0100)]
[ACPPAGE] Improve the compatibility tab (#332)
- Use the tab title from the corresponding dialog resource caption string.
- Fix some translations, and complete the french one.
- Use DialogBoxParamW and MAKEINTRESOURCEW (with W).
Stanislav Motylkov [Sat, 27 Jan 2018 15:25:51 +0000 (18:25 +0300)]
[TRANSLATION] Add and fix translations for ping and tracert (#331)
Hermès Bélusca-Maïto [Sat, 27 Jan 2018 15:07:17 +0000 (16:07 +0100)]
[EVTLIB] Make the header C++ compatible.
Hermès Bélusca-Maïto [Sat, 27 Jan 2018 15:00:44 +0000 (16:00 +0100)]
[CONUTILS] Fix macro definition.
Hermès Bélusca-Maïto [Sat, 27 Jan 2018 14:48:59 +0000 (15:48 +0100)]
[CONUTILS] Make the headers C++ compatible.
Mark Jansen [Wed, 24 Jan 2018 21:43:35 +0000 (22:43 +0100)]
[SDB] Define the layers GetShortPathNameNT4 and GetDiskFreeSpace2GB
Mark Jansen [Wed, 24 Jan 2018 21:41:56 +0000 (22:41 +0100)]
[SHIMENG] Parse and apply [AppCompat] Flags.
Mark Jansen [Wed, 24 Jan 2018 21:35:12 +0000 (22:35 +0100)]
[XML2SDB] Parse Flags.
Mark Jansen [Thu, 25 Jan 2018 20:39:01 +0000 (21:39 +0100)]
[SHIMENG] Change SE_InstallBeforeInit loglevel.
Ercan Ersoy [Sun, 14 Jan 2018 15:14:25 +0000 (18:14 +0300)]
[STOBJECT] Change Turkish translation.
Ercan Ersoy [Sun, 14 Jan 2018 15:11:06 +0000 (18:11 +0300)]
[NTOBJSHEX] Change Turkish translation.
Ercan Ersoy [Sun, 14 Jan 2018 15:09:15 +0000 (18:09 +0300)]
[NETSHELL] Change Turkish translation.
Ercan Ersoy [Sun, 14 Jan 2018 15:07:24 +0000 (18:07 +0300)]
[NETSHELL] Change Turkish translation.
Ercan Ersoy [Sun, 14 Jan 2018 14:59:35 +0000 (17:59 +0300)]
[DESKADP] Change Turkish translation.
Ercan Ersoy [Sun, 14 Jan 2018 14:57:29 +0000 (17:57 +0300)]
[ACPPAGE] Change Turkish translation.
Ercan Ersoy [Sun, 14 Jan 2018 14:52:22 +0000 (17:52 +0300)]
[DESKMON] Change Turkish translation.
Ercan Ersoy [Sun, 14 Jan 2018 14:43:04 +0000 (17:43 +0300)]
[FONTEXT] Translate to Turkish.
Change fontext.rc file and add lang/tr-TR.rc file
Pierre Schweitzer [Sat, 27 Jan 2018 13:30:05 +0000 (14:30 +0100)]
[TRANSLATION] Fix a few bits in shortcuts French translation.
Adam Słaboń [Sat, 27 Jan 2018 12:21:22 +0000 (13:21 +0100)]
[TRANSLATION] Polish translation update (#328)
Pierre Schweitzer [Sat, 27 Jan 2018 12:01:45 +0000 (13:01 +0100)]
[TRACERT] Add French translation
Pierre Schweitzer [Sat, 27 Jan 2018 11:49:14 +0000 (12:49 +0100)]
[PING] Complete French translation
Pierre Schweitzer [Sat, 27 Jan 2018 09:57:50 +0000 (10:57 +0100)]
[NTOSKRNL] When marking a VACB dirty on unmap/unpin, use CcRosMarkDirtyVacb().
This should help reducing race conditions with lazy writer, and thus reduce random BSODs.
CORE-14263
Serge Gautherie [Sat, 27 Jan 2018 09:50:10 +0000 (10:50 +0100)]
[KMTEST] TcpIpConnect: Fix harmless typos (#299)
- 1 s/ok_bool_true/ok/, overkill though harmless.
- 1 s/ntohs/htons/, typo though harmless.
ROSTESTS-274
Dmitry Bagdanov [Fri, 26 Jan 2018 15:46:35 +0000 (22:46 +0700)]
[CABMAN] Move CCFDATAStorage class to a separate file
Dmitry Bagdanov [Fri, 26 Jan 2018 15:44:14 +0000 (22:44 +0700)]
[CABMAN] Remove _WIN32 ifdef's
Giannis Adamopoulos [Thu, 18 Jan 2018 17:01:35 +0000 (19:01 +0200)]
[GDIPLUS] Add it to winsxs.
[NTDLL_APITEST] Remove a hack for gdiplus
Giannis Adamopoulos [Thu, 18 Jan 2018 14:56:16 +0000 (16:56 +0200)]
[NTDLL_APITEST] Remove one of the hacks for the implicit activation context.
Giannis Adamopoulos [Thu, 18 Jan 2018 14:53:59 +0000 (16:53 +0200)]
[RTL] actctx: Implement the implicit activation context
Serge Gautherie [Fri, 26 Jan 2018 23:34:21 +0000 (00:34 +0100)]
[FREELDR] FreeLdr debug.h does not care about NDEBUG. (#201)
- Remove all "#define NDEBUG".
toehead2001 [Fri, 26 Jan 2018 21:30:15 +0000 (21:30 +0000)]
[SNDVOL32] Fix controls' offset (#280)
CORE-9108
Katayama Hirofumi MZ [Fri, 26 Jan 2018 21:23:00 +0000 (06:23 +0900)]
[GDI32_APITEST] Add GetTextMetrics tests to gdi32_apitest (#307)
CORE-13840
Serge Gautherie [Sat, 13 Jan 2018 14:41:49 +0000 (15:41 +0100)]
[FREELDR] i386vid.c: Downgrade/Improve 3 false ERR() to WARN(). CORE-13496
Silence harmless errors, which can be reported at every boot.
Joann Mõndresku [Fri, 26 Jan 2018 18:14:17 +0000 (20:14 +0200)]
[TRANSLATION] Estonian translation for Notepad & Paint
Added Estonian translation for the common base applications Notepad and MS Paint. These are the initial translations, and are subject to change, as they may not be the most perfect.
Stanislav Motylkov [Fri, 26 Jan 2018 18:38:47 +0000 (21:38 +0300)]
[PING] Fix error handling and response address decoding (#318)
- Host/net unreachable error should be obtained from EchoReply->Status
- Use GetNameInfoW to decode actual response addresses (borrowed from tracert code)
CORE-14241 #resolve
Stanislav Motylkov [Fri, 26 Jan 2018 18:37:43 +0000 (21:37 +0300)]
[TRACERT] Improve error handling and output (#319)
- Correctly interpret network error codes
- Add output for generic transmit failure
CORE-14242 #resolve
Pierre Schweitzer [Fri, 26 Jan 2018 09:50:13 +0000 (10:50 +0100)]
[NTOSKRNL] Simplify (and speedup!) CcCanIWrite() using the dirty pages count in cache map.
Pierre Schweitzer [Fri, 26 Jan 2018 09:40:05 +0000 (10:40 +0100)]
[NTOSKRNL] Store the total dirty pages per shared cache map in it.
Pierre Schweitzer [Thu, 25 Jan 2018 20:56:19 +0000 (21:56 +0100)]
[NTOSKRNL] Allow pinned dirty VACB to be lazy written.
This is an addition to
07e6e9c.
Also, fix a cppcheck warning (so minor!).
CORE-14249
Pierre Schweitzer [Thu, 25 Jan 2018 12:47:00 +0000 (13:47 +0100)]
[NTOSKRNL] Contrary to WinDBG !filecache, we don't display CONTROL_AREA but shared cache map
Pierre Schweitzer [Wed, 24 Jan 2018 21:03:23 +0000 (22:03 +0100)]
[NTOSKRNL] Fix MSVC build?
Pierre Schweitzer [Wed, 24 Jan 2018 20:45:37 +0000 (21:45 +0100)]
[NTOSKRNL] Implement (it's a bit raw for now!) the !filecache command in KDBG
Pierre Schweitzer [Wed, 24 Jan 2018 20:24:05 +0000 (21:24 +0100)]
[NTOSKRNL] Link all the shared cache map together.
Serge Gautherie [Fri, 22 Dec 2017 22:52:47 +0000 (23:52 +0100)]
[ATL_APITEST] CComObject.cpp: Fix output test name copypasta.