reactos.git
4 years ago[BTRFS]
Pierre Schweitzer [Tue, 10 May 2016 21:08:50 +0000 (21:08 +0000)]
[BTRFS]
Cherry pick d71baf195715601212a2043f153400a964da6a18: Don't remove an entry list twice in add_to_space_list()

This avoids linked list entry twice removal

CORE-11057

svn path=/trunk/; revision=71315

4 years ago[BTRFS]
Pierre Schweitzer [Tue, 10 May 2016 21:07:56 +0000 (21:07 +0000)]
[BTRFS]
Cherry pick aa04ca0ea4cadb0c70ff6d659916cc98b7b02c27: uninit: don't free roots before FCBs are freed

This avoids use-after-free on shutdown

svn path=/trunk/; revision=71314

4 years ago[SHELL32] Improve a list view header. Patch by Jared Smudde. CORE-11151
Robert Naumann [Tue, 10 May 2016 20:48:39 +0000 (20:48 +0000)]
[SHELL32] Improve a list view header. Patch by Jared Smudde. CORE-11151

svn path=/trunk/; revision=71313

4 years ago[APPHELP] Remove imagehlp.dll dependency. CORE-10367
Mark Jansen [Tue, 10 May 2016 20:42:37 +0000 (20:42 +0000)]
[APPHELP] Remove imagehlp.dll dependency. CORE-10367

svn path=/trunk/; revision=71312

4 years ago[FASTFAT]
Thomas Faber [Tue, 10 May 2016 18:29:06 +0000 (18:29 +0000)]
[FASTFAT]
- Fix a use after free in VfatFlushVolume
CORE-11224 #resolve

svn path=/trunk/; revision=71311

4 years ago[UNIATA] Fix uninitialized variable usage. Patch by 'Alter'. CORE-11157 #resolve...
Mark Jansen [Tue, 10 May 2016 18:15:35 +0000 (18:15 +0000)]
[UNIATA] Fix uninitialized variable usage. Patch by 'Alter'. CORE-11157 #resolve #comment Thanks!

svn path=/trunk/; revision=71309

4 years ago[IPHLPAPI]
Thomas Faber [Tue, 10 May 2016 17:53:36 +0000 (17:53 +0000)]
[IPHLPAPI]
- Don't use uninitialized values in AllocateAndGet*TableFromStack functions. CID 716757
- Free buffers on failure
CORE-11227 #resolve

svn path=/trunk/; revision=71308

4 years ago[HAL]
Thomas Faber [Tue, 10 May 2016 15:03:56 +0000 (15:03 +0000)]
[HAL]
- Create a wrapper version of HalpEndSoftwareInterrupt that frees its stack before calling the noreturn version of the next software interrupt handler. Fixes excessive stack usage when DPCs are queued in quick succession.
CORE-11123 #resolve

svn path=/trunk/; revision=71307

4 years ago[IPHLPAPI]
Thomas Faber [Tue, 10 May 2016 13:59:41 +0000 (13:59 +0000)]
[IPHLPAPI]
- Fix memory leaks in getInterfaceInfoSet (CIDs 716370 and 716371)
- Fix a benign uninitialized variable use (CID 500783)
CORE-11224 #resolve

svn path=/trunk/; revision=71306

4 years ago[IPHLPAPI]
Thomas Faber [Tue, 10 May 2016 13:42:57 +0000 (13:42 +0000)]
[IPHLPAPI]
- Tabs to spaces. No code changes.

svn path=/trunk/; revision=71305

4 years ago[NTOS:MM]
Thomas Faber [Tue, 10 May 2016 11:47:05 +0000 (11:47 +0000)]
[NTOS:MM]
- Keep track of physical pages allocated for special pool, and respect the initially calculated MiSpecialPagesNonPagedMaximum

svn path=/trunk/; revision=71304

4 years ago[CONSOLE.CPL]: Fix a test condition. Reviewed by Thomas Faber; initially patched...
Hermès Bélusca-Maïto [Mon, 9 May 2016 22:06:27 +0000 (22:06 +0000)]
[CONSOLE.CPL]: Fix a test condition. Reviewed by Thomas Faber; initially patched by Victor Martinez Calvo Should fix CID 1322302 "Fix an use after free".
Please reanalyze with Coverity :)
CORE-11179

svn path=/trunk/; revision=71303

4 years ago[TEST]
Sylvain Petreolle [Mon, 9 May 2016 20:57:35 +0000 (20:57 +0000)]
[TEST]

svn path=/trunk/; revision=71302

4 years ago[USBHUB]
Thomas Faber [Mon, 9 May 2016 17:44:16 +0000 (17:44 +0000)]
[USBHUB]
- Fix memory leak in failure case of CreateDeviceIds. Patch by Víctor Martínez Calvo. CID 1102364
CORE-11208 #resolve

svn path=/trunk/; revision=71301

4 years ago[SHELL32]
Eric Kohl [Mon, 9 May 2016 15:11:25 +0000 (15:11 +0000)]
[SHELL32]
Improvements to the file types property page:
- Always show the selected file type.
- Set the focus to the listview control when the file types page gets activated.
- Enable/disable the Delete button for the initial file type selection too.

svn path=/trunk/; revision=71300

4 years ago[NETAPI32]
Eric Kohl [Mon, 9 May 2016 10:26:55 +0000 (10:26 +0000)]
[NETAPI32]
Prevent dereferencing null-pointers.

svn path=/trunk/; revision=71299

4 years ago[BTRFS]
Thomas Faber [Mon, 9 May 2016 09:10:13 +0000 (09:10 +0000)]
[BTRFS]
- Fix warnings

svn path=/trunk/; revision=71298

4 years ago[NTOS:SE]
Thomas Faber [Mon, 9 May 2016 08:49:18 +0000 (08:49 +0000)]
[NTOS:SE]
- In SepPropagateAcl, gracefully handle unknown ACE types by simply copying them.
CORE-10694 #resolve

svn path=/trunk/; revision=71296

4 years ago[SHELL32]
Thomas Faber [Mon, 9 May 2016 08:12:00 +0000 (08:12 +0000)]
[SHELL32]
- Fix uninitialized return value in _SHGetDefaultValue. CID 1322231
CORE-11213 #resolve

svn path=/trunk/; revision=71295

4 years agoZeroMemory expects buffer size in bytes
Christoph von Wittich [Mon, 9 May 2016 08:01:49 +0000 (08:01 +0000)]
ZeroMemory expects buffer size in bytes

svn path=/trunk/; revision=71294

4 years ago[WS2_32_NEW]
Thomas Faber [Mon, 9 May 2016 07:49:58 +0000 (07:49 +0000)]
[WS2_32_NEW]
- Use the correct size of ServiceBuffer in getnameinfo. Patch by Víctor Martínez Calvo. CID 716150
CORE-11214 #resolve

svn path=/trunk/; revision=71293

4 years ago[WS2_32_NEW]
Thomas Faber [Mon, 9 May 2016 07:34:46 +0000 (07:34 +0000)]
[WS2_32_NEW]
- Add missing null termination for the line buffer in GetProtoGetNextEnt. Patch by Víctor Martínez Calvo. CID 716700
CORE-11218 #resolve

svn path=/trunk/; revision=71292

4 years ago[SHELL32]
Thomas Faber [Mon, 9 May 2016 07:22:59 +0000 (07:22 +0000)]
[SHELL32]
- Fix check for GCS_VALIDATE in CDefaultContextMenu::GetCommandString. Patch by Jared Smudde.
CORE-11183

svn path=/trunk/; revision=71291

4 years ago[APPHELP] Addendum to r71226, fix some failing testcases of SdbGetFileAttributes...
Mark Jansen [Sun, 8 May 2016 20:43:59 +0000 (20:43 +0000)]
[APPHELP] Addendum to r71226, fix some failing testcases of SdbGetFileAttributes + make it more robust. CORE-10367
- Work around a ROS bug (CORE-11206) by doing some better bounds checking.
- Silence a VAD warning by checking for NULL instead of blindly passing mem to NtUnmapViewOfSection
- Rewrite module type lookup code to use an enum and to return the found header.

svn path=/trunk/; revision=71290

4 years ago[NTDLL_APITEST] Show that NtMapViewOfSection does not properly NULL out the remainder...
Mark Jansen [Sun, 8 May 2016 17:01:15 +0000 (17:01 +0000)]
[NTDLL_APITEST] Show that NtMapViewOfSection does not properly NULL out the remainder of the mapped memory. CORE-11206

svn path=/trunk/; revision=71289

4 years agoAdd the AHK tests as an optional module.
Sylvain Petreolle [Sun, 8 May 2016 15:01:46 +0000 (15:01 +0000)]
Add the AHK tests as an optional module.
ONLINE-567

svn path=/trunk/; revision=71288

4 years ago[KSFILTER]: We may need to check the result of KspScanBus call here. To see whether...
Hermès Bélusca-Maïto [Sun, 8 May 2016 14:53:14 +0000 (14:53 +0000)]
[KSFILTER]: We may need to check the result of KspScanBus call here. To see whether we need to do that, add an assert. If hit then we know KspScanBus can fail and some proper failure code will be needed.

svn path=/trunk/; revision=71287

4 years ago[KSFILTER]: Return from KsCreateBusEnumObject() when scanning the bus fails. By Victo...
Hermès Bélusca-Maïto [Sun, 8 May 2016 14:35:50 +0000 (14:35 +0000)]
[KSFILTER]: Return from KsCreateBusEnumObject() when scanning the bus fails. By Victor Martinez Calvo.
CID 1322294
CORE-11201 #resolve

svn path=/trunk/; revision=71286

4 years ago[BOOTLIB]: Fix EtfspGetDirentNameLength loops. By Victor Martinez Calvo.
Hermès Bélusca-Maïto [Sun, 8 May 2016 14:28:06 +0000 (14:28 +0000)]
[BOOTLIB]: Fix EtfspGetDirentNameLength loops. By Victor Martinez Calvo.
CID 1341138
CORE-11178 #resolve

svn path=/trunk/; revision=71285

4 years ago[USETUP]: Fix typo in SectorCount.QuadPart calculation (and add ULONGLONG casts).
Hermès Bélusca-Maïto [Sun, 8 May 2016 13:50:38 +0000 (13:50 +0000)]
[USETUP]: Fix typo in SectorCount.QuadPart calculation (and add ULONGLONG casts).
By Victor Martinez Calvo.
CORE-11205 #resolve

svn path=/trunk/; revision=71284

4 years ago[TELNET]: Move around the resource files, in order to add the ability to localize...
Hermès Bélusca-Maïto [Sun, 8 May 2016 13:46:16 +0000 (13:46 +0000)]
[TELNET]: Move around the resource files, in order to add the ability to localize telnet.
By Robert Naumann.
CORE-10717 #resolve #comment Thanks!

svn path=/trunk/; revision=71283

4 years ago[TELNET]: Correctly show the icon.
Hermès Bélusca-Maïto [Sun, 8 May 2016 13:37:18 +0000 (13:37 +0000)]
[TELNET]: Correctly show the icon.
By Henry Tang Ih and Robert Naumann.
CORE-10717

svn path=/trunk/; revision=71282

4 years ago[RTL]
Thomas Faber [Sun, 8 May 2016 08:07:11 +0000 (08:07 +0000)]
[RTL]
- In RtlpGrowBlockInPlace, copy the heap block's user value if the old block has the HEAP_ENTRY_EXTRA_PRESENT flag, instead of looking at the flags of the following block (where this will never be set).
CORE-11196 #resolve

svn path=/trunk/; revision=71279

4 years ago[NTDLL_APITEST]
Thomas Faber [Sun, 8 May 2016 08:03:50 +0000 (08:03 +0000)]
[NTDLL_APITEST]
- Add a test for heap user values and flags when using RtlReAllocateHeap in-place
CORE-11196

svn path=/trunk/; revision=71278

4 years ago[CONSRV]: Use cmd's terminal icon that doesn't include crazy sizes.
Hermès Bélusca-Maïto [Sat, 7 May 2016 23:17:09 +0000 (23:17 +0000)]
[CONSRV]: Use cmd's terminal icon that doesn't include crazy sizes.

svn path=/trunk/; revision=71277

4 years ago[PROGMAN]: Add some icons (will be used later).
Hermès Bélusca-Maïto [Sat, 7 May 2016 23:14:43 +0000 (23:14 +0000)]
[PROGMAN]: Add some icons (will be used later).

svn path=/trunk/; revision=71276

4 years ago[SHELL32]
Eric Kohl [Sat, 7 May 2016 21:59:00 +0000 (21:59 +0000)]
[SHELL32]
Improvements to the file type property page:
- Read the EditFlags value for each file type from the registry.
- Sort the file type list by extension and description.
- Do not add a file type to the list if the FTA_Exclude flag is set for the file type.
- Disable the delete button if the FTA_NoRemove flag is set fot the file type.
- Set the FTA_Exclude flag for the dllfiles, lnkfiles and piffiles file types.
- Set the FTA_NoRemove flag for the batfile, cmdfile, comfile and exefile file types.

svn path=/trunk/; revision=71275

4 years ago[RAPPS]
Daniel Reimer [Sat, 7 May 2016 15:17:21 +0000 (15:17 +0000)]
[RAPPS]
FTP direct links are bad for ROS.

svn path=/trunk/; revision=71274

4 years ago[RAPPS]
Daniel Reimer [Sat, 7 May 2016 13:01:25 +0000 (13:01 +0000)]
[RAPPS]
Fix changed SHA1, fix broken downloads. Have fun 0.4.1 testers ^^

svn path=/trunk/; revision=71273

4 years ago[UDFS] Avoid double free in UDFLoadLogicalVolInt. Patch by Víctor Martínez Calvo...
Mark Jansen [Sat, 7 May 2016 11:50:03 +0000 (11:50 +0000)]
[UDFS] Avoid double free in UDFLoadLogicalVolInt. Patch by Víctor Martínez Calvo. CID 1322300 CORE-11181 #resolve
#comment Thanks!

svn path=/trunk/; revision=71272

4 years ago[KBDTOOL] Handle failure to parse scancodes. Patch by Víctor Martínez Calvo. CID...
Mark Jansen [Sat, 7 May 2016 10:22:45 +0000 (10:22 +0000)]
[KBDTOOL] Handle failure to parse scancodes. Patch by Víctor Martínez Calvo. CID 1341307 CORE-11177 #resolve
#comment Thanks!

svn path=/trunk/; revision=71271

4 years ago[FASTFAT]
Pierre Schweitzer [Fri, 6 May 2016 21:06:31 +0000 (21:06 +0000)]
[FASTFAT]
In case we're performing an in-place move (ie, in the same directory), if short name matches before and after, keep it.

This avoids that a file with long file name sees its short name changing on normally 'non-effect' renames.
For instance, in case of case-change only rename, short name will now be preserved.

See ya, you 7y old bug :-)

CORE-3875 #resolve #comment Fixed with r71270

svn path=/trunk/; revision=71270

4 years ago[IERNONCE]
Sylvain Petreolle [Fri, 6 May 2016 20:20:02 +0000 (20:20 +0000)]
[IERNONCE]
Add the romanian resource to the repository.
CORE-11111 #resolve
Fix build.

svn path=/trunk/; revision=71269

4 years ago[USETUP]
Eric Kohl [Fri, 6 May 2016 20:17:20 +0000 (20:17 +0000)]
[USETUP]
Fix serious path localization issue.
Patch by Wim Hueskes.
CORE-9656 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71268

4 years ago[TRANSLATION]
Eric Kohl [Fri, 6 May 2016 14:41:41 +0000 (14:41 +0000)]
[TRANSLATION]
Updating Turkish Translation.
Patch by Erdem Ersoy.
CORE-11130 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71267

4 years ago[TRANSLATION]
Eric Kohl [Fri, 6 May 2016 14:30:53 +0000 (14:30 +0000)]
[TRANSLATION]
Romanian resources maintenance.
Patch by Ștefan Fulea.
CORE-11111 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71266

4 years ago[BTRFS]
Pierre Schweitzer [Thu, 5 May 2016 17:26:47 +0000 (17:26 +0000)]
[BTRFS]
Upgrade the WinBtrfs to release 0.4.

CORE-11172 #resolve #Committed in r71265

svn path=/trunk/; revision=71265

4 years ago[NTOSKRNL_VISTA]
Pierre Schweitzer [Thu, 5 May 2016 16:58:16 +0000 (16:58 +0000)]
[NTOSKRNL_VISTA]
Implement FsRtlValidateReparsePointBuffer().

CORE-11172

svn path=/trunk/; revision=71264

4 years ago[NTOSKRNL] Fix NtApphelpCacheControl image lookup failure return codes when validatin...
Mark Jansen [Thu, 5 May 2016 14:13:29 +0000 (14:13 +0000)]
[NTOSKRNL] Fix NtApphelpCacheControl image lookup failure return codes when validating file times.
Also silence some debug outputs in the normal usage flow.

svn path=/trunk/; revision=71263

4 years agofix the build for msvc (2013?) users.
Mark Jansen [Thu, 5 May 2016 12:43:57 +0000 (12:43 +0000)]
fix the build for msvc (2013?) users.

svn path=/trunk/; revision=71262

4 years ago[NTOSKRNL][NTDLL_APITEST] Fix error returned from NtCreateSection when opening an...
Mark Jansen [Thu, 5 May 2016 12:06:07 +0000 (12:06 +0000)]
[NTOSKRNL][NTDLL_APITEST] Fix error returned from NtCreateSection when opening an empty file. CORE-11166

svn path=/trunk/; revision=71261

4 years ago[BTRFS]
Pierre Schweitzer [Thu, 5 May 2016 06:48:56 +0000 (06:48 +0000)]
[BTRFS]
Mark the CORE-11057 fix as local change.

CORE-11172

svn path=/trunk/; revision=71260

4 years ago[FREELDR] fix copypasta
Christoph von Wittich [Wed, 4 May 2016 08:28:44 +0000 (08:28 +0000)]
[FREELDR] fix copypasta
CORE-11161

svn path=/trunk/; revision=71259

4 years ago[UNIATA] Fix PCH.
Amine Khaldi [Tue, 3 May 2016 22:23:02 +0000 (22:23 +0000)]
[UNIATA] Fix PCH.

svn path=/trunk/; revision=71255

4 years ago[UNIATA]
Aleksey Bragin [Tue, 3 May 2016 21:16:08 +0000 (21:16 +0000)]
[UNIATA]
- Update to 0.46d7.

CORE-11157

svn path=/trunk/; revision=71252

4 years ago[WINTRUST_WINETEST] Import Wine Staging commit bdb15cf (WinVerifyTrust tests), by...
Mark Jansen [Tue, 3 May 2016 19:29:39 +0000 (19:29 +0000)]
[WINTRUST_WINETEST] Import Wine Staging commit bdb15cf (WinVerifyTrust tests), by Sebastian Lackner & Me CORE-10923

svn path=/trunk/; revision=71248

4 years ago[KERNEL32]
Pierre Schweitzer [Tue, 3 May 2016 17:58:28 +0000 (17:58 +0000)]
[KERNEL32]
The onliner:
- Move to next entry by applying the offset to the previous entry, and not to the first entry

This fixes enumerating ADS from files with 3+ streams. Previously, doing dir /R in a directory would have lead to a cmd crash.

CORE-11164 #resolve #comment Fixed by r71245

svn path=/trunk/; revision=71245

4 years ago[SHELL32]
Giannis Adamopoulos [Tue, 3 May 2016 17:10:09 +0000 (17:10 +0000)]
[SHELL32]
- Remove a debug message that should have been removed before committing.
- Also fix a test failure.

svn path=/trunk/; revision=71244

4 years ago[SHELL32]
Giannis Adamopoulos [Tue, 3 May 2016 14:36:04 +0000 (14:36 +0000)]
[SHELL32]
- Move recyclebin static lib in the shell32 folder and name it shellrecyclebin alongside shelldesktop and shellmenu static libs.

svn path=/trunk/; revision=71243

4 years ago[SHELL32]
Giannis Adamopoulos [Tue, 3 May 2016 13:47:16 +0000 (13:47 +0000)]
[SHELL32]
- CDesktopFolder: Avoid doing any operation with pidls. Use the internal fs folders instead.

svn path=/trunk/; revision=71242

4 years ago[WIN32K:NTUSER]
Thomas Faber [Tue, 3 May 2016 12:50:35 +0000 (12:50 +0000)]
[WIN32K:NTUSER]
- Desktops should keep a reference to their parent window station
CORE-11124

svn path=/trunk/; revision=71240

4 years ago[WIN32K:NTUSER]
Thomas Faber [Tue, 3 May 2016 12:38:41 +0000 (12:38 +0000)]
[WIN32K:NTUSER]
- In IntDesktopObjectDelete, correctly handle the case where pDeskInfo could not be allocated
CORE-11124

svn path=/trunk/; revision=71239

4 years ago[WIN32K:NTUSER]
Thomas Faber [Tue, 3 May 2016 12:24:28 +0000 (12:24 +0000)]
[WIN32K:NTUSER]
- Fix indentation. No functional changes.

svn path=/trunk/; revision=71238

4 years ago[SHELL32]
Giannis Adamopoulos [Tue, 3 May 2016 09:15:36 +0000 (09:15 +0000)]
[SHELL32]
- lnk files are .. files so don't pretend that CDrivesFolder and CControlPanelFolder can contain lnk files.
- Don't create a full pidl just to parse it right away (which is a costly operation) when an IShellLink is queried from a folder.
- Fix a bug in CDesktopFolder::GetDisplayNameOf that was exposed by changes above.

svn path=/trunk/; revision=71237

4 years ago[REG_WINETEST]
Thomas Faber [Mon, 2 May 2016 20:30:59 +0000 (20:30 +0000)]
[REG_WINETEST]
- Addendum to r71232: we no longer need to skip this test.
ROSTESTS-200

svn path=/trunk/; revision=71236

4 years ago[USER32]
Pierre Schweitzer [Mon, 2 May 2016 17:45:42 +0000 (17:45 +0000)]
[USER32]
Import Wine commit:
bfb7e167cb399dbba0a889b797bc11ece8b9e687, Check bounds before dereferencing.

svn path=/trunk/; revision=71235

4 years ago[COMDLG32]
Pierre Schweitzer [Mon, 2 May 2016 17:45:39 +0000 (17:45 +0000)]
[COMDLG32]
Import Wine commit:
d288d8d333f6faea9d64a0af944f125663a449d8, Check for overflow before dereferencing.

svn path=/trunk/; revision=71234

4 years ago[SHELL32]
Giannis Adamopoulos [Mon, 2 May 2016 13:50:13 +0000 (13:50 +0000)]
[SHELL32]
- Fix loading shortcut icons. The previous code passed a full pidl to GetUIObjectOf which is really wrong.
CORE-11158

svn path=/trunk/; revision=71233

4 years ago[NTOS:CM]
Thomas Faber [Mon, 2 May 2016 13:19:44 +0000 (13:19 +0000)]
[NTOS:CM]
- Correctly handle NULL Data with nonzero DataSize in NtSetValueKey
ROSTESTS-200 #resolve

svn path=/trunk/; revision=71232

4 years ago[User32]
James Tabor [Mon, 2 May 2016 02:46:03 +0000 (02:46 +0000)]
[User32]
- Patch by Herschel Ralston : Fix scroll bar glitch. See CORE-3923 and CORE-11155.

svn path=/trunk/; revision=71231

4 years ago[APPHELP][APPHELP_APITEST] Add some apphelp GUID helper functions + tests to be used...
Mark Jansen [Sun, 1 May 2016 21:43:30 +0000 (21:43 +0000)]
[APPHELP][APPHELP_APITEST] Add some apphelp GUID helper functions + tests to be used later on. CORE-10367
- SdbGetStandardDatabaseGUID
- SdbGUIDFromString
- SdbGUIDToString
- SdbIsNullGUID

svn path=/trunk/; revision=71230

4 years ago[NTFS]
Pierre Schweitzer [Sun, 1 May 2016 20:16:08 +0000 (20:16 +0000)]
[NTFS]
Cherry pick a change from r71224 by Trevor:
- Don't fail too early in NtfsCreateFile() when requesting write/supersede operation. This allows already setting appropriate error in certain cases and making the driver more consistent

svn path=/trunk/; revision=71229

4 years ago[NTFS]
Pierre Schweitzer [Sun, 1 May 2016 20:13:26 +0000 (20:13 +0000)]
[NTFS]
This has nothing to do in a NTFS driver

svn path=/trunk/; revision=71228

4 years ago[SHELL32]
Giannis Adamopoulos [Sun, 1 May 2016 19:54:23 +0000 (19:54 +0000)]
[SHELL32]
- Remove IExtractIconA_Constructor and rename IExtractIconW_Constructor to GenericExtractIcon_CreateInstance which will handle both A and W.
- Make GenericExtractIcon_CreateInstance accept a pointer to a IShellFolder and a simple pidl.
- Avoid using SHGetPathFromIDListW. Use ILGetDisplayNameExW instead. May make loading icons for folders and exe files slightly faster as it does fewer I/O and less allocations.

svn path=/trunk/; revision=71227

4 years ago[APPHELP][APPHELP_APITEST] Add SdbGetFileAttributes + tests, based on the work of...
Mark Jansen [Sun, 1 May 2016 19:12:06 +0000 (19:12 +0000)]
[APPHELP][APPHELP_APITEST] Add SdbGetFileAttributes + tests, based on the work of Mislav Blažević CORE-10367
- Implement SdbGetFileAttributes (based on the work of Mislav Blažević)
- Add tests for SdbGetFileAttributes

svn path=/trunk/; revision=71226

4 years ago[SHELL32]
Giannis Adamopoulos [Sun, 1 May 2016 19:05:32 +0000 (19:05 +0000)]
[SHELL32]
- Disentangle icon extraction for control panel. Add CCPLExtractIcon_CreateInstance and isolate control panel handling in CControlPanelFolder.cpp.

svn path=/trunk/; revision=71225

4 years ago[DHCPCSVC]
Pierre Schweitzer [Sun, 1 May 2016 13:36:15 +0000 (13:36 +0000)]
[DHCPCSVC]
Properly end variadic args enumeration

svn path=/trunk/; revision=71223

4 years ago[SHELL32]
Pierre Schweitzer [Sun, 1 May 2016 13:27:11 +0000 (13:27 +0000)]
[SHELL32]
Don't use uninit var

svn path=/trunk/; revision=71222

4 years ago[KS]
Pierre Schweitzer [Sun, 1 May 2016 08:25:22 +0000 (08:25 +0000)]
[KS]
- Don't leak memory in KspValidateConnectRequest(), patch by Victor Martinez
- Also compute connect medium ID string only twice (could be even computed once) instead of doing so in each loop iteration

CORE-11099 #resolve #comment Committed in r71221

svn path=/trunk/; revision=71221

4 years ago[SHELL32] Properly track RC file dependencies. CORE-9806
Amine Khaldi [Sat, 30 Apr 2016 16:21:23 +0000 (16:21 +0000)]
[SHELL32] Properly track RC file dependencies. CORE-9806

svn path=/trunk/; revision=71220

4 years ago[PSDK]
Pierre Schweitzer [Sat, 30 Apr 2016 16:12:49 +0000 (16:12 +0000)]
[PSDK]
Add missing definition

svn path=/trunk/; revision=71219

4 years ago[SHELL32]
Giannis Adamopoulos [Sat, 30 Apr 2016 15:30:59 +0000 (15:30 +0000)]
[SHELL32]
- Get rid of CPrintersExtractIconW and add CPrintersExtractIconW_CreateInstane which creates and initializes CExtractIcon.
- Also add CNetFolderExtractIcon_CreateInstance and CRecyclerExtractIcon_CreateInstance.

svn path=/trunk/; revision=71217

4 years ago[SHELL32_APITEST]
Thomas Faber [Sat, 30 Apr 2016 15:06:57 +0000 (15:06 +0000)]
[SHELL32_APITEST]
- Add a test for SHParseDisplayName
CORE-10434

svn path=/trunk/; revision=71216

4 years agofix the build.
Mark Jansen [Sat, 30 Apr 2016 14:33:57 +0000 (14:33 +0000)]
fix the build.

svn path=/trunk/; revision=71215

4 years agoTry to fix build.
Giannis Adamopoulos [Sat, 30 Apr 2016 14:09:33 +0000 (14:09 +0000)]
Try to fix build.

svn path=/trunk/; revision=71214

4 years ago[SHELL32]
Giannis Adamopoulos [Sat, 30 Apr 2016 14:05:10 +0000 (14:05 +0000)]
[SHELL32]
- Add an overload of SHSetStrRet which loads strings by default from shell32.
- Remove some dead code fomr CDrivesFolder.

svn path=/trunk/; revision=71213

4 years ago[SHELL32]
Giannis Adamopoulos [Sat, 30 Apr 2016 12:52:17 +0000 (12:52 +0000)]
[SHELL32]
- Accept parsing paths like "C:". Also simplify CDrivesFolder::ParseDisplayName a bit.
Note: trying to run "c:" from the run dialog doesn't have the right result due to a bug in ShellExecute.

svn path=/trunk/; revision=71212

4 years ago[FASTFAT]
Pierre Schweitzer [Sat, 30 Apr 2016 08:20:00 +0000 (08:20 +0000)]
[FASTFAT]
Update the FCB cached dir entry in case of a rename.

CORE-11150 #resolve #comment Fixed in r71209

svn path=/trunk/; revision=71209

4 years ago[SHELL32] German layout improvements in the folder options dialog. By Joachim Henze...
Amine Khaldi [Tue, 26 Apr 2016 21:17:25 +0000 (21:17 +0000)]
[SHELL32] German layout improvements in the folder options dialog. By Joachim Henze. CORE-11143

svn path=/trunk/; revision=71208

4 years ago[ACPI]
Thomas Faber [Tue, 26 Apr 2016 18:29:42 +0000 (18:29 +0000)]
[ACPI]
- Fix a broken status check in Bus_StartFdo. Spotted by willok.

svn path=/trunk/; revision=71207

4 years ago[CLASSPNP] Use NT_ASSERTMSGW instead of ASSERTMSGW.
Amine Khaldi [Mon, 25 Apr 2016 22:47:45 +0000 (22:47 +0000)]
[CLASSPNP] Use NT_ASSERTMSGW instead of ASSERTMSGW.

svn path=/trunk/; revision=71206

4 years ago[CLASSPNP] Addendum to r71183.
Amine Khaldi [Mon, 25 Apr 2016 22:39:15 +0000 (22:39 +0000)]
[CLASSPNP] Addendum to r71183.

svn path=/trunk/; revision=71205

4 years ago[CONFIGURE]
Sylvain Petreolle [Sun, 24 Apr 2016 22:40:53 +0000 (22:40 +0000)]
[CONFIGURE]
Addendum to r69601:
host-tools are "no longer required" but actually still exist.
Add the CMakeCache cleanup for them.

svn path=/trunk/; revision=71204

4 years ago[BTRFS]
Pierre Schweitzer [Sun, 24 Apr 2016 19:58:15 +0000 (19:58 +0000)]
[BTRFS]
Don't remove an entry list twice in add_to_space_list().

This fixes a BSOD when trying to create a new file on a Btrfs volume.

Already sent upstream. Delayed due to inactivity.

CORE-11057 #resolve #comment Fixed with r71202

svn path=/trunk/; revision=71202

4 years ago[CDMAKE]
Sylvain Petreolle [Sun, 24 Apr 2016 18:59:33 +0000 (18:59 +0000)]
[CDMAKE]
Don't check for extension length on Joliet images.
Encountered with AHK binaries.

ONLINE-567

svn path=/trunk/; revision=71201

4 years ago[APPHELP][APPHELP_APITEST] Update SdbTagToString tests to check all known tags CORE...
Mark Jansen [Sun, 24 Apr 2016 17:19:09 +0000 (17:19 +0000)]
[APPHELP][APPHELP_APITEST] Update SdbTagToString tests to check all known tags CORE-10367
- Add a list of hardcoded tags, for all versions up to win7 they are checked against windows.
- Update SdbTagToString with a few missing strings
- Hardcode the used version to Win7 for now, as backporting these strings would not make much sense.

svn path=/trunk/; revision=71200

4 years ago[NDIS]
Sylvain Petreolle [Sun, 24 Apr 2016 15:50:25 +0000 (15:50 +0000)]
[NDIS]
Revert r71188

svn path=/trunk/; revision=71199

4 years agoNothing to see here.
Mark Jansen [Sun, 24 Apr 2016 13:27:22 +0000 (13:27 +0000)]
Nothing to see here.

svn path=/trunk/; revision=71198

4 years ago[APPHELP][APPHELP_APITEST] Add SdbTagToString + test by Mislav Blažević CORE-10367
Mark Jansen [Sun, 24 Apr 2016 13:05:00 +0000 (13:05 +0000)]
[APPHELP][APPHELP_APITEST] Add SdbTagToString + test by Mislav Blažević CORE-10367

svn path=/trunk/; revision=71197

4 years ago[SYSSETUP]
Eric Kohl [Sun, 24 Apr 2016 11:29:40 +0000 (11:29 +0000)]
[SYSSETUP]
Rename SetAccountDomain to SetAccountsDomainSid and export it.

svn path=/trunk/; revision=71194