reactos.git
3 years ago[SNDREC32]
Pierre Schweitzer [Sat, 12 Nov 2016 09:24:09 +0000 (09:24 +0000)]
[SNDREC32]
Don't double free buffers in case of failure

svn path=/trunk/; revision=73208

3 years ago[EVENTVWR]: Fix translation for "Information" event type: it is really in singular...
Hermès Bélusca-Maïto [Sat, 12 Nov 2016 01:29:05 +0000 (01:29 +0000)]
[EVENTVWR]: Fix translation for "Information" event type: it is really in singular, not plural.

svn path=/trunk/; revision=73207

3 years ago[MSVCRT]: Implement and export _wtof, based on Wine and existing code; patch by Amine...
Hermès Bélusca-Maïto [Fri, 11 Nov 2016 23:32:29 +0000 (23:32 +0000)]
[MSVCRT]: Implement and export _wtof, based on Wine and existing code; patch by Amine Khaldi.
CORE-12335 #resolve
CORE-9312 #comment Please retest with r73206

svn path=/trunk/; revision=73206

3 years ago[MSAFD]
Hermès Bélusca-Maïto [Fri, 11 Nov 2016 21:37:09 +0000 (21:37 +0000)]
[MSAFD]
- In C, void functions should better have 'VOID' mentioned in their prototypes.
- Simplify GetCurrentTimeInSeconds code.

svn path=/trunk/; revision=73205

3 years ago[MSAFD]: Addendum to r73203.
Hermès Bélusca-Maïto [Fri, 11 Nov 2016 21:25:02 +0000 (21:25 +0000)]
[MSAFD]: Addendum to r73203.

svn path=/trunk/; revision=73204

3 years ago[MSAFD]: Convert tabs to spaces.
Hermès Bélusca-Maïto [Fri, 11 Nov 2016 21:19:13 +0000 (21:19 +0000)]
[MSAFD]: Convert tabs to spaces.

svn path=/trunk/; revision=73203

3 years ago[NTOSKRNL]
Pierre Schweitzer [Fri, 11 Nov 2016 18:16:43 +0000 (18:16 +0000)]
[NTOSKRNL]
Don't redefine RTL_NUMBER_OF

svn path=/trunk/; revision=73202

3 years ago[PSDK] small fixes for dns headers
Christoph von Wittich [Fri, 11 Nov 2016 14:21:55 +0000 (14:21 +0000)]
[PSDK] small fixes for dns headers

svn path=/trunk/; revision=73201

3 years ago[KMTESTS:MM]
Pierre Schweitzer [Fri, 11 Nov 2016 10:44:51 +0000 (10:44 +0000)]
[KMTESTS:MM]
Bugfix for IRP_MJ_SET_INFORMATION/FileEndOfFileInformation: really set the information. The test still works fine in Windows and still fails hard in ReactOS.

svn path=/trunk/; revision=73200

3 years ago[NTOSKRNL]
Pierre Schweitzer [Thu, 10 Nov 2016 21:17:21 +0000 (21:17 +0000)]
[NTOSKRNL]
In MmCreateDataFileSection(), when maximum size is higher than file size, don't deal with its allocation size, just move EOF.
This was shown by NtCreateSection() tests.

svn path=/trunk/; revision=73199

3 years ago[KMTESTS:MM]
Pierre Schweitzer [Thu, 10 Nov 2016 21:02:48 +0000 (21:02 +0000)]
[KMTESTS:MM]
Add tests for the NtCreateSection functions which mimic some of the behavior that can be exposed by FSDs (late init, too small files, and so on).
It was designed in W2K3.

svn path=/trunk/; revision=73198

3 years ago[MSAFD] Implement SO_CONNECT_TIME. CORE-12104
Peter Hater [Thu, 10 Nov 2016 17:55:00 +0000 (17:55 +0000)]
[MSAFD] Implement SO_CONNECT_TIME. CORE-12104

svn path=/trunk/; revision=73197

3 years ago[HOST-TOOLS]
Thomas Faber [Thu, 10 Nov 2016 15:34:25 +0000 (15:34 +0000)]
[HOST-TOOLS]
- Fix some GCC6 warnings

svn path=/trunk/; revision=73196

3 years ago[WS2_32_APITESTS] Add nonblocking tests
Peter Hater [Thu, 10 Nov 2016 15:13:19 +0000 (15:13 +0000)]
[WS2_32_APITESTS] Add nonblocking tests

svn path=/trunk/; revision=73195

3 years ago[WS2_32_APITESTS] Add more WSAAsync tests
Peter Hater [Thu, 10 Nov 2016 15:00:44 +0000 (15:00 +0000)]
[WS2_32_APITESTS] Add more WSAAsync tests

svn path=/trunk/; revision=73194

3 years ago[WS2_32_APITEST] Use test.winehq.org insteadof reactos.org. These days main reactos...
Peter Hater [Thu, 10 Nov 2016 14:23:49 +0000 (14:23 +0000)]
[WS2_32_APITEST] Use test.winehq.org insteadof reactos.org. These days main reactos page is too big.

svn path=/trunk/; revision=73193

3 years ago[MSAFD] Fix for WSPStringToAddressA/W wine tests. CORE-12104
Peter Hater [Thu, 10 Nov 2016 11:15:14 +0000 (11:15 +0000)]
[MSAFD] Fix for WSPStringToAddressA/W wine tests. CORE-12104

svn path=/trunk/; revision=73192

3 years ago[FASTFAT]
Thomas Faber [Thu, 10 Nov 2016 11:04:29 +0000 (11:04 +0000)]
[FASTFAT]
- Generate LFNs for files containing non-ASCII characters in their names.
CORE-8617 #resolve

svn path=/trunk/; revision=73191

3 years ago[NTDLL_APITEST]
Thomas Faber [Thu, 10 Nov 2016 10:18:25 +0000 (10:18 +0000)]
[NTDLL_APITEST]
- Add tests for RtlIsNameLegalDOS8Dot3 and RtlUpcaseUnicodeStringToCountedOemString with the ® sign.
CORE-8617

svn path=/trunk/; revision=73190

3 years ago[SHELL32] - CStartMenu: Add missing checks for failure and make some checks noisy...
Giannis Adamopoulos [Thu, 10 Nov 2016 09:34:14 +0000 (09:34 +0000)]
[SHELL32] - CStartMenu: Add missing checks for failure and make some checks noisy. CORE-12300

svn path=/trunk/; revision=73189

3 years ago[SHELL32] - CMenuBand: Don't accept a NULL shell folder in SetShellFolder. Should...
Giannis Adamopoulos [Thu, 10 Nov 2016 08:10:28 +0000 (08:10 +0000)]
[SHELL32] - CMenuBand: Don't accept a NULL shell folder in SetShellFolder. Should fix a test and possibly CORE-12300.

svn path=/trunk/; revision=73188

3 years ago[SHELL32]
Giannis Adamopoulos [Thu, 10 Nov 2016 08:05:13 +0000 (08:05 +0000)]
[SHELL32]
- Make some checks for failure in CDefView and CDefaultContextMenu noisy.

svn path=/trunk/; revision=73187

3 years agoand of course also rename the test itself...
Mark Jansen [Wed, 9 Nov 2016 23:23:50 +0000 (23:23 +0000)]
and of course also rename the test itself...

svn path=/trunk/; revision=73186

3 years agoRename shlexec.cpp to ShellExecuteEx.cpp as suggested by Thomas.
Mark Jansen [Wed, 9 Nov 2016 23:18:23 +0000 (23:18 +0000)]
Rename shlexec.cpp to ShellExecuteEx.cpp as suggested by Thomas.

svn path=/trunk/; revision=73185

3 years ago[PROPSYS_WINETEST]
Thomas Faber [Wed, 9 Nov 2016 22:55:16 +0000 (22:55 +0000)]
[PROPSYS_WINETEST]
- Fix VS2010 build

svn path=/trunk/; revision=73184

3 years agoaddendum to r73180 (aka, fix the build)
Mark Jansen [Wed, 9 Nov 2016 22:24:42 +0000 (22:24 +0000)]
addendum to r73180 (aka, fix the build)

svn path=/trunk/; revision=73183

3 years ago[SHELL32] Automatically add the .exe extension for App Paths in ShellExecuteEx. Patch...
Mark Jansen [Wed, 9 Nov 2016 22:18:33 +0000 (22:18 +0000)]
[SHELL32] Automatically add the .exe extension for App Paths in ShellExecuteEx. Patch by Yaroslav Veremenko. CORE-12049

svn path=/trunk/; revision=73182

3 years ago[EVENTVWR]: Adjust some menu keyboard shortcuts.
Hermès Bélusca-Maïto [Wed, 9 Nov 2016 22:14:20 +0000 (22:14 +0000)]
[EVENTVWR]: Adjust some menu keyboard shortcuts.

svn path=/trunk/; revision=73181

3 years ago[SHELL32_APITEST] Add some tests for ShellExecuteEx showing extension completion...
Mark Jansen [Wed, 9 Nov 2016 22:13:26 +0000 (22:13 +0000)]
[SHELL32_APITEST] Add some tests for ShellExecuteEx showing extension completion with the App Paths registry key. Patch by Yaroslav Veremenko. CORE-12049

svn path=/trunk/; revision=73180

3 years ago[PSDK] fix DNS_RECORDW definition
Christoph von Wittich [Wed, 9 Nov 2016 21:29:09 +0000 (21:29 +0000)]
[PSDK] fix DNS_RECORDW definition

svn path=/trunk/; revision=73179

3 years ago[EXPLORER]: Add missing keyboard shortcuts for some commands.
Hermès Bélusca-Maïto [Wed, 9 Nov 2016 18:03:19 +0000 (18:03 +0000)]
[EXPLORER]: Add missing keyboard shortcuts for some commands.

svn path=/trunk/; revision=73178

3 years ago[MSAFD] Fix possible memory corruption in WSPIoctl. Brought to you by Andreas Maier...
Peter Hater [Wed, 9 Nov 2016 12:05:48 +0000 (12:05 +0000)]
[MSAFD] Fix possible memory corruption in WSPIoctl.  Brought to you by Andreas Maier aka andy-123. Thanks.
CORE-12322

svn path=/trunk/; revision=73177

3 years ago[MSAFD] Minor changes. Code style fixes. tabs->spaces. CORE-12104
Peter Hater [Wed, 9 Nov 2016 11:49:55 +0000 (11:49 +0000)]
[MSAFD] Minor changes. Code style fixes. tabs->spaces. CORE-12104

svn path=/trunk/; revision=73176

3 years ago[BROWSEUI]
Giannis Adamopoulos [Tue, 8 Nov 2016 23:38:42 +0000 (23:38 +0000)]
[BROWSEUI]
- CAddressBand: Call the SetOwner method with NULL parameter to CAddressEditBox to let it know that it should deinitialize.
- CAddressEditBox: Release the connection with the browse window and release the pointer to the site during deinitialization.
- CInternetToolbar: Destroy the toolbar and release pointers when CloseDW method gets called.
- CBaseBar: Destroy the window when SetClient is called with NULL parameter.
- CToolbarProxy: Add a Destroy method to release resources because we hold a pointer to the CInternetToolbar.
- CShellBrowser: When storing the pointer  to the new basebar add a new reference because we directly change the pointer in the smart pointer and not the smart pointer itself. Destroy the toolbar proxy and properly release all references to containted objects. Also expect the reference count of the shell view to reach zero after the internet toolbar gets freed because it also keeps a reference.

This should fix all the leaking objects and windows when closing the shell browser. It should also fix CORE-12066.

svn path=/trunk/; revision=73175

3 years ago[PSDK] add some missing DNS structures, add incomplete dnsrslvr.idl
Christoph von Wittich [Tue, 8 Nov 2016 12:27:55 +0000 (12:27 +0000)]
[PSDK] add some missing DNS structures, add incomplete dnsrslvr.idl

svn path=/trunk/; revision=73174

3 years ago[PSDK] disable SAL for WIDL as well
Christoph von Wittich [Tue, 8 Nov 2016 11:33:54 +0000 (11:33 +0000)]
[PSDK] disable SAL for WIDL as well

svn path=/trunk/; revision=73173

3 years ago[USETUP]
Thomas Faber [Tue, 8 Nov 2016 09:40:05 +0000 (09:40 +0000)]
[USETUP]
- Critical errors are worth a debug print
CORE-11819

svn path=/trunk/; revision=73172

3 years ago[NTOS]: Fix MmPt and DOPE tags.
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 20:41:24 +0000 (20:41 +0000)]
[NTOS]: Fix MmPt and DOPE tags.

svn path=/trunk/; revision=73171

3 years ago[NTOS:IO]: IopCreateDriver(): Set the returned DriverObject value only in case of...
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 15:51:56 +0000 (15:51 +0000)]
[NTOS:IO]: IopCreateDriver(): Set the returned DriverObject value only in case of success.

svn path=/trunk/; revision=73170

3 years ago[TCPIP]
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 15:48:34 +0000 (15:48 +0000)]
[TCPIP]
- Enable logging now that IoWriteErrorLogEntry works.
- Check for log event size before calling IoAllocateErrorLogEntry.
- Reduce code indentation in the logging function.

svn path=/trunk/; revision=73169

3 years ago[NTOS:IO]: An improvement for the total log size check (addendum to r73167).
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 13:57:11 +0000 (13:57 +0000)]
[NTOS:IO]: An improvement for the total log size check (addendum to r73167).

svn path=/trunk/; revision=73168

3 years ago[NTOS:IO][INCLUDES][EVENTLOG]: Fix support for event logging through the "ErrorLogPor...
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 13:29:09 +0000 (13:29 +0000)]
[NTOS:IO][INCLUDES][EVENTLOG]: Fix support for event logging through the "ErrorLogPort" LPC. See the details in CORE-12301 #resolve

svn path=/trunk/; revision=73167

3 years ago[NTOS:LPC]
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 12:35:09 +0000 (12:35 +0000)]
[NTOS:LPC]
- Capture the ServerView/ClientView *only* when those pointers are not NULL.
- Fix a LpcRequest vs. CapturedLpcRequest in a call to LpcpMoveMessage. Caught by Thomas. CORE-7371 CR-100

svn path=/trunk/; revision=73166

3 years ago[MSAFD] Implement SOL_SOCKET/SO_ERROR. CORE-12104
Peter Hater [Mon, 7 Nov 2016 08:50:31 +0000 (08:50 +0000)]
[MSAFD] Implement SOL_SOCKET/SO_ERROR. CORE-12104

svn path=/trunk/; revision=73165

3 years ago[NTOS:LPC]
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 01:24:24 +0000 (01:24 +0000)]
[NTOS:LPC]
- Fix the usage, or add support (for NtSecureConnectPort based on patches by Alexander Andrejevic, and for NtReplyPort, NtReplyWaitReceivePortEx, NtListenPort by me) for capturing user-mode parameters and using SEH in LPC functions.
CORE-7371 #resolve
- Make NtSecureConnectPort call SeQueryInformationToken, now that the latter is implemented since r73122.
- Fix ObDereferenceObject usage for Port vs. ClientPort in NtSecureConnectPort.
- ObCloseHandle certainly needs to be called with the actual 'PreviousMode'.

svn path=/trunk/; revision=73164

3 years ago[NTOS:LPC]: Fix the function prototypes (reference: Process Hacker + how the paramete...
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 01:06:24 +0000 (01:06 +0000)]
[NTOS:LPC]: Fix the function prototypes (reference: Process Hacker + how the parameters are used in the code).
[NOTS][NDK]: Fix whitespace in header files.
[XDK]: Define PORT_MAXIMUM_MESSAGE_LENGTH before actually using it in the different IO_ERROR_LOG_xxx #defines, for consistency purposes.

svn path=/trunk/; revision=73163

3 years ago[NTOS:LPC]: Improve the lisibility of some functions:
Hermès Bélusca-Maïto [Mon, 7 Nov 2016 00:55:34 +0000 (00:55 +0000)]
[NTOS:LPC]: Improve the lisibility of some functions:
- Group together the local parameters used for capturing user variables;
- Add some space between the list of parameters and the beginning of the code proper;
- Rename some variables or move some code to make some different functions look more similar (helps in finding functionality-similar functions in the code);
- Improve some comments;
- Whitespace fixes;
- Few code formatting.
- Use a ExFreePoolWithTag instead of ExFreePool, but otherwise no other functional code changes.

svn path=/trunk/; revision=73162

3 years ago[SHELL32]
Giannis Adamopoulos [Sun, 6 Nov 2016 23:34:22 +0000 (23:34 +0000)]
[SHELL32]
- CShellLink: Zero the pointer to mDropTarget by releasing the smart pointer instead of just releasing the object. This lead to a crash every time CShellLink::DragLeave was called.
CORE-11956

svn path=/trunk/; revision=73161

3 years ago[SHELL32]
Giannis Adamopoulos [Sun, 6 Nov 2016 22:25:02 +0000 (22:25 +0000)]
[SHELL32]
- SHOpenFolderAndSelectItems: Take into account buggy applications like firefox that like to pass full pidls in a PCUITEMID_CHILD_ARRAY.

svn path=/trunk/; revision=73160

3 years ago[SHELL32]
Giannis Adamopoulos [Sun, 6 Nov 2016 21:51:46 +0000 (21:51 +0000)]
[SHELL32]
- Hackplement SHOpenFolderAndSelectItems by using the /select parameter of explorer.exe and selecting only the first of the requested items.
- Implement the "Find Target" button in the properties dialog of shortcuts to use SHOpenFolderAndSelectItems so as we can test it.
Based on the patch of Joachim Henze (reactosfanboy).
CORE-9367

svn path=/trunk/; revision=73159

3 years ago[SHELL32]
Giannis Adamopoulos [Sun, 6 Nov 2016 20:47:21 +0000 (20:47 +0000)]
[SHELL32]
- CDefView: Correct the check for SVSI_EDIT because SVSI_EDIT implies SVSI_SELECT. This actualyl fixes SVSI_SELECT to not cause a rename.

[BROWSEUI]
- ExplorerMessageLoop: Implement the /select parameter for explorer.

svn path=/trunk/; revision=73158

3 years ago[SHELL32]
Giannis Adamopoulos [Sun, 6 Nov 2016 20:13:17 +0000 (20:13 +0000)]
[SHELL32]
- CDesktopBrowser: The flags that SHOpenNewFrame takes are the same that SHExplorerParseCmdLine returns, not the SBSP_ ones.

[BROWSEUI]
- Move the hack to fill the parsed pidl if none was found to SHCreateFromDesktop.
- Convert the SH_EXPLORER_CMDLINE_FLAG_E flag to a SBSP_EXPLOREMODE and pass it to the CShellBrowser.

svn path=/trunk/; revision=73157

3 years ago[COM_APITEST]
Giannis Adamopoulos [Sun, 6 Nov 2016 18:04:58 +0000 (18:04 +0000)]
[COM_APITEST]
- The new interfaces are not registered in the registry
- Add a few interfaces that were discovered for CLSID_Printers and CLSID_QueryAssociations.

svn path=/trunk/; revision=73156

3 years ago[COM_APITEST]
Giannis Adamopoulos [Sun, 6 Nov 2016 17:17:57 +0000 (17:17 +0000)]
[COM_APITEST]
- Test for the undocumented interfaces that were added recently.

svn path=/trunk/; revision=73155

3 years ago[SHLGUID_UNDOC.H] -Add several undocumented interfaces taken from http://www.geoffcha...
Giannis Adamopoulos [Sun, 6 Nov 2016 15:47:35 +0000 (15:47 +0000)]
[SHLGUID_UNDOC.H] -Add several undocumented interfaces taken from geoffchappell.com/studies/windows/shell/shell32/interfaces/index.htm

svn path=/trunk/; revision=73154

3 years ago[KMTESTS]
Thomas Faber [Sun, 6 Nov 2016 15:26:39 +0000 (15:26 +0000)]
[KMTESTS]
- Complete IRPs with STATUS_INVALID_DEVICE_REQUEST by default.
CORE-12295 #resolve

svn path=/trunk/; revision=73153

3 years ago[EVTLIB]: Don't spam the log with "add new record" lines.
Hermès Bélusca-Maïto [Sun, 6 Nov 2016 15:26:20 +0000 (15:26 +0000)]
[EVTLIB]: Don't spam the log with "add new record" lines.

svn path=/trunk/; revision=73152

3 years ago[MKISOFS]
Thomas Faber [Sun, 6 Nov 2016 14:57:13 +0000 (14:57 +0000)]
[MKISOFS]
- Fix build with VS2010 and 2012
CORE-11988

svn path=/trunk/; revision=73151

3 years ago[USBAUDIO]
Johannes Anderwald [Sun, 6 Nov 2016 13:59:39 +0000 (13:59 +0000)]
[USBAUDIO]
- partly implement GetDataRangeIndexForFormat

svn path=/trunk/; revision=73150

3 years ago[PSEH]
Thomas Faber [Sun, 6 Nov 2016 11:49:19 +0000 (11:49 +0000)]
[PSEH]
- Correctly restore the old frame pointer when unwinding in _except_handler3.
CORE-12283 #resolve

svn path=/trunk/; revision=73149

3 years ago[KMTESTS:RTL]
Thomas Faber [Sun, 6 Nov 2016 09:31:09 +0000 (09:31 +0000)]
[KMTESTS:RTL]
- Add a test checking stack frame correctness in a nested __finally handler
CORE-12283

svn path=/trunk/; revision=73148

3 years ago[SHELL32]
Giannis Adamopoulos [Sat, 5 Nov 2016 19:55:29 +0000 (19:55 +0000)]
[SHELL32]
- Only specific shell folders are supposed to return their display name. Consequently, only CRegFolder reads the registry now to get the display name of items.

svn path=/trunk/; revision=73147

3 years ago[ASM]
Thomas Faber [Sat, 5 Nov 2016 18:34:44 +0000 (18:34 +0000)]
[ASM]
- Addendum to r73145 aka fix build

svn path=/trunk/; revision=73146

3 years ago[PSEH]
Thomas Faber [Sat, 5 Nov 2016 18:33:50 +0000 (18:33 +0000)]
[PSEH]
- Make _except_handler3 human-readable
CORE-12283

svn path=/trunk/; revision=73145

3 years ago[CRT]
Thomas Faber [Sat, 5 Nov 2016 18:27:30 +0000 (18:27 +0000)]
[CRT]
- Avoid 'except' as a variable name in math.h, for compatibility with SEH tests

svn path=/trunk/; revision=73144

3 years ago[ADVAPI32] Set REG_NONE type in RegQueryValueExW with certain failure cases. Patch...
Mark Jansen [Sat, 5 Nov 2016 17:46:30 +0000 (17:46 +0000)]
[ADVAPI32] Set REG_NONE type in RegQueryValueExW with certain failure cases. Patch by Victor Martinez Calvo. CORE-9666 #resolve #comment Thanks!

svn path=/trunk/; revision=73143

3 years ago[ADVAPI32_APITEST] Add tests for RegQueryValueExW. Patch by Victor Martinez Calvo...
Mark Jansen [Sat, 5 Nov 2016 17:43:24 +0000 (17:43 +0000)]
[ADVAPI32_APITEST] Add tests for RegQueryValueExW. Patch by Victor Martinez Calvo. ROSTESTS-171 #resolve #comment Thanks!

svn path=/trunk/; revision=73142

3 years ago[MKISOFS] Silence progress spam.
Mark Jansen [Sat, 5 Nov 2016 17:28:00 +0000 (17:28 +0000)]
[MKISOFS] Silence progress spam.

svn path=/trunk/; revision=73141

3 years ago[SHELL32]
Giannis Adamopoulos [Sat, 5 Nov 2016 17:04:15 +0000 (17:04 +0000)]
[SHELL32]
- Make most dll dependencies to be delay loaded just like windows.

svn path=/trunk/; revision=73140

3 years ago[SHELL32]
Giannis Adamopoulos [Sat, 5 Nov 2016 16:45:41 +0000 (16:45 +0000)]
[SHELL32]
- Add missing resource strings for the description of some shell folders.

svn path=/trunk/; revision=73139

3 years ago[USBAUDIO]
Johannes Anderwald [Sat, 5 Nov 2016 16:38:59 +0000 (16:38 +0000)]
[USBAUDIO]
- store remaining audio bytes in a common buffer, which will be sent on next request
- fixes some of audio distortion issues

svn path=/trunk/; revision=73138

3 years ago[SHELL32]
Giannis Adamopoulos [Sat, 5 Nov 2016 16:33:24 +0000 (16:33 +0000)]
[SHELL32]
- Properly add Printers folder in Control Panel.
CORE-12193

svn path=/trunk/; revision=73137

3 years ago[SHELL32] Improve the choose icon dialog. Patch by Jared Smudde, edited by me. CORE...
Mark Jansen [Sat, 5 Nov 2016 16:12:09 +0000 (16:12 +0000)]
[SHELL32] Improve the choose icon dialog. Patch by Jared Smudde, edited by me. CORE-11792 #resolve
Translators, please check this dialog in your language, some text is changed!

svn path=/trunk/; revision=73136

3 years ago[CRT]
Thomas Faber [Sat, 5 Nov 2016 16:05:02 +0000 (16:05 +0000)]
[CRT]
- Remove SEH code that's duplicated in the pseh library.
CORE-12283

svn path=/trunk/; revision=73135

3 years ago[SHELL32]
Giannis Adamopoulos [Sat, 5 Nov 2016 15:05:00 +0000 (15:05 +0000)]
[SHELL32]
CDesktopBrowser: Forward the parameters pased in CDesktopBrowser::BrowseObject to SHOpenNewFrame. Thus the same parameters are eventually passed to CShellBrowser::Initialize.

[BROWSEUI]
CShellBrowser: Handle SBSP_EXPLOREMODE flag so as to show the tree view when the user selects the Explore option from the context menu.

svn path=/trunk/; revision=73134

3 years ago[BASE] Spelling fixes by Josh Soref. CORE-12286
Amine Khaldi [Sat, 5 Nov 2016 14:55:55 +0000 (14:55 +0000)]
[BASE] Spelling fixes by Josh Soref. CORE-12286

svn path=/trunk/; revision=73133

3 years ago[BROWSEUI]
Giannis Adamopoulos [Sat, 5 Nov 2016 14:40:55 +0000 (14:40 +0000)]
[BROWSEUI]
- CShellBrowser: Add some checks for failures that we re missing.
- CAddressEditBox: Add some checks for failures that we re missing.
- SHCreateFromDesktop: Actually create the proxy desktop window when needed and keep its handle and prefer it when we try to find the proxy desktop window.
- Wake the message queue of the proxy desktop after a browser thread exits so the proxy desktop can exit when the last browser thread exits.
- Add a hack to prefer to show my documents if we ended up trying to open a browser window with a NULL pidl. This is a hack that is needed because SHExplorerParseCmdLine is broken.
- Finally this fixes using "explorer /separate" and also fixes the separate process to exit when the last browser gets closed (this fix also applies to filebrowser.exe which no longer lives forever).
CORE-12168

svn path=/trunk/; revision=73132

3 years ago[BROWSEUI]
Giannis Adamopoulos [Sat, 5 Nov 2016 00:09:51 +0000 (00:09 +0000)]
[BROWSEUI]
- CAddressEditBox: Implement handling relative paths in the addressbar of explore in addition to absolute paths.

svn path=/trunk/; revision=73130

3 years ago[BROWSEUI]
Giannis Adamopoulos [Fri, 4 Nov 2016 23:56:02 +0000 (23:56 +0000)]
[BROWSEUI]
- CShellBrowser: Add a standard ShellObjectCreatorInit constructor and make its initializer take a pidl and flags.
- Move BrowserThreadProc to desktopipc.cpp where the lifetime of the browser thread will be managed.

svn path=/trunk/; revision=73129

3 years ago[SHELL32]
Giannis Adamopoulos [Fri, 4 Nov 2016 23:11:29 +0000 (23:11 +0000)]
[SHELL32]
- Implement comparing child items in CompareIDs method of our IShellFolder immplementation in shell32 as this is the expected behaviour according to tests and documentation.
- This was removed after each folder got its own implementation (we used a single one from wine that did handle it).
May fix CORE-12106.

svn path=/trunk/; revision=73128

3 years ago[SDK]
Johannes Anderwald [Fri, 4 Nov 2016 18:38:07 +0000 (18:38 +0000)]
[SDK]
- fix build
- thanks learn_more

svn path=/trunk/; revision=73127

3 years ago[SDK]
Johannes Anderwald [Fri, 4 Nov 2016 18:14:40 +0000 (18:14 +0000)]
[SDK]
- add newline

svn path=/trunk/; revision=73126

3 years ago[SDK]
Johannes Anderwald [Fri, 4 Nov 2016 18:12:00 +0000 (18:12 +0000)]
[SDK]
- add prototypes

svn path=/trunk/; revision=73125

3 years ago[USBAUDIO]
Johannes Anderwald [Fri, 4 Nov 2016 18:07:44 +0000 (18:07 +0000)]
[USBAUDIO]
- fix buffer calculation for usb headsets
- usb headsets now partially work with usbaudio in win2k3

svn path=/trunk/; revision=73124

3 years ago[MSAFD] Check params on WSAAceept. CORE-12104
Peter Hater [Fri, 4 Nov 2016 18:03:15 +0000 (18:03 +0000)]
[MSAFD] Check params on WSAAceept. CORE-12104

svn path=/trunk/; revision=73123

3 years ago[NTOS]
Hermès Bélusca-Maïto [Fri, 4 Nov 2016 17:52:32 +0000 (17:52 +0000)]
[NTOS]
- accesschk.c: Remove redundant SepAccessCheck/SepAccessCheckEx pair of private functions; instead just rename SepAccessCheckEx into SepAccessCheck and use it directly in the code. NOTE: SepAccessCheck is *incomplete* (in particular it doesn't retrieve the information needed to initialize the 'Privileges' parameter).
- sid.c: Comments formatting fix.
- token.c:
  * Finish to implement SeQueryInformationToken . This function is really the same as NtQueryInformationToken but without all the stuff needed for user-mode buffer access protection.
  * Some code simplifications in NtQueryInformationToken.
  I need this to fix a "FIXME: Use SeQueryInformationToken" in some code I'm also fixing (& commit later).

[NDK]: Fix parameter types and add annotations to RtlCopySidAndAttributesArray.

[KMTESTS:NTOS_SE]
- Reenable the 'SeQueryInfoToken' test.
- Show that SeQueryInformationToken doesn't support 4 token information classes, which are supported only by NtQueryInformationToken.
- Fix calling of SeAccessCheck. In particular the 'Privileges' parameter is not allocated by the caller, but instead is allocated by SeAccessCheck *and* returned to the caller (who then must free the buffer using SeFreePrivileges). This fixes the encountered BSODs that leaded to disabling preventively the test in r59178.
- Minor code cleaning.

svn path=/trunk/; revision=73122

3 years ago[SHELL32_APITEST]
Giannis Adamopoulos [Fri, 4 Nov 2016 17:31:53 +0000 (17:31 +0000)]
[SHELL32_APITEST]
- Add extensive tests for SHParseDisplayName. I tried to add as many as possible  but this list of tests is still incomplete. In the meantime I discovered interesting stuff like the "shell:system" path which if you enter in the run dialog will open the system32 folder. I tried to test parsing protocols like ftp paths but couldn't find wht it should look like yet. Afaik all protocol except for the shell protocol like the one mentioned before should be parsed by CInternet class as noted in the appropriate comment in the tests.

svn path=/trunk/; revision=73121

3 years ago[MSAFD] Disable setting blocking mode if there are WSPAsyncSelect or WSPEventSelect...
Peter Hater [Fri, 4 Nov 2016 09:38:21 +0000 (09:38 +0000)]
[MSAFD] Disable setting blocking mode if there are WSPAsyncSelect or WSPEventSelect pending calls. CORE-12104

svn path=/trunk/; revision=73120

3 years ago[NETCFGX] Compensate for the proper widths until we have sane font support. Suggestio...
Amine Khaldi [Fri, 4 Nov 2016 09:28:44 +0000 (09:28 +0000)]
[NETCFGX] Compensate for the proper widths until we have sane font support. Suggestion by Jim, patch by Doug Lyons. CORE-12094

svn path=/trunk/; revision=73117

3 years ago[NTOSKRNL]
Pierre Schweitzer [Thu, 3 Nov 2016 21:49:55 +0000 (21:49 +0000)]
[NTOSKRNL]
In IoWritePartitionTableEx(), don't return STATUS_SUCCESS when we cannot write GPT to higher partitions count than space available; return STATUS_INVALID_PARAMETER.

svn path=/trunk/; revision=73114

3 years ago[DISK]
Pierre Schweitzer [Thu, 3 Nov 2016 21:38:56 +0000 (21:38 +0000)]
[DISK]
Don't overflow when computing disk size.
Patch by Vort.

CORE-12261

svn path=/trunk/; revision=73113

3 years ago[NTOSKRNL]
Pierre Schweitzer [Thu, 3 Nov 2016 21:13:30 +0000 (21:13 +0000)]
[NTOSKRNL]
For now, disable broken code in FstubReadPartitionTableEFI(). In its current state, it wrongly assumes backup GPT is broken and thus attempts to fix main GPT (?!).
Furthermore, it appears Windows 2K3 doesn't perform such checks, nor such GPT rewritings in FstubReadPartitionTableEFI().

CORE-12261

svn path=/trunk/; revision=73112

3 years ago[WHOAMI]: Use the conutils (stream) library for console output (see also r65894).
Hermès Bélusca-Maïto [Thu, 3 Nov 2016 16:30:48 +0000 (16:30 +0000)]
[WHOAMI]: Use the conutils (stream) library for console output (see also r65894).
CORE-8965 CORE-10504

svn path=/trunk/; revision=73111

3 years ago[CONUTILS]: Remove that overengineered splitted library stuff, and just rely on the...
Hermès Bélusca-Maïto [Thu, 3 Nov 2016 15:47:45 +0000 (15:47 +0000)]
[CONUTILS]: Remove that overengineered splitted library stuff, and just rely on the splitting of the source code files instead. This is simpler and does the same job as I wanted to do initially (thanks Amine and Thomas for the feedback).
CORE-10504 #resolve
[APPS]: Use again just the conutils library.
The effect of these two modifications above is to partly revert r73024 (the code splitting remains on the contrary).
[CMAKE]: Remove the "evil workaround" (revert r73027). See CORE-12206 for more details.

svn path=/trunk/; revision=73110

3 years ago[TCPIP] Always copy back bind IP in connection. Spotted by Thomas. Thanks
Peter Hater [Thu, 3 Nov 2016 14:53:00 +0000 (14:53 +0000)]
[TCPIP] Always copy back bind IP in connection. Spotted by Thomas. Thanks
CORE-12152

svn path=/trunk/; revision=73109

3 years ago[USETUP]
Thomas Faber [Thu, 3 Nov 2016 14:14:19 +0000 (14:14 +0000)]
[USETUP]
- A fatal error when creating the install directory is worth a DPRINT1
CORE-11819

svn path=/trunk/; revision=73108

3 years ago[USBAUDIO]
Johannes Anderwald [Thu, 3 Nov 2016 13:44:01 +0000 (13:44 +0000)]
[USBAUDIO]
- frequencies may appear unsorted, handle that

svn path=/trunk/; revision=73107

3 years ago[USBAUDIO]
Johannes Anderwald [Thu, 3 Nov 2016 13:26:45 +0000 (13:26 +0000)]
[USBAUDIO]
- include controls from logical channels
- process selector unit descriptors
- automatic gain is KSNODETYPE_AGC

svn path=/trunk/; revision=73106

3 years ago[BOOTDATA]: Fix the indentation of the file(..) commands, noted by Thomas.
Hermès Bélusca-Maïto [Wed, 2 Nov 2016 21:49:50 +0000 (21:49 +0000)]
[BOOTDATA]: Fix the indentation of the file(..) commands, noted by Thomas.

svn path=/trunk/; revision=73105

3 years ago[BOOTDATA]: Diverse improvements for mkisofs support and ISO image configuration:
Hermès Bélusca-Maïto [Wed, 2 Nov 2016 21:43:46 +0000 (21:43 +0000)]
[BOOTDATA]: Diverse improvements for mkisofs support and ISO image configuration:
- Make our build system create the required empty directory for mkisofs, instead. (It's not the purpose of the SVN to hold special files/directories just to make host tools happy; instead it's the job of the buld system to create them.)
- Place the boot files (catalog & co.) preferably at the beginning of the ISO image (it makes ISO image analysis easier, and is back-compatible with cdmake & oscdimg & windows ISOs): use the build system to generate the mkisofs sorting file. See the CMakeLists.txt for more details.
- Set in one place the ISO manufacturer & volume name strings so that it makes easier to bulk-change them (and makes features like CORE-12233 a bit easier to maintain).
- The EFI image must be set up with no emulation mode! (See section "12.3.2.1 ISO-9660 and El Torito" of the UEFI spec v2.4 errata B, for example).

[MKISOFS]: Add some useful offline documentation.

CORE-11988

svn path=/trunk/; revision=73104