reactos.git
6 weeks ago[WIN32SS:GDI] Add a sanity assert
Victor Perevertkin [Mon, 13 Sep 2021 20:37:34 +0000 (23:37 +0300)]
[WIN32SS:GDI] Add a sanity assert

6 weeks ago[KERNEL32] FindFirstFileExW: fix syscall buffer alignment
Victor Perevertkin [Mon, 13 Sep 2021 18:13:14 +0000 (21:13 +0300)]
[KERNEL32] FindFirstFileExW: fix syscall buffer alignment

NtQueryDirectoryFile required the FileInformation buffer to be
ULONG-aligned. Declare the aligned buffer explicitly.

6 weeks ago[CMAKE] Fix invalid usage of list()
Victor Perevertkin [Mon, 13 Sep 2021 17:13:40 +0000 (20:13 +0300)]
[CMAKE] Fix invalid usage of list()

list() functions expects numerical indices for modification operations
and silently converts everything else to a number (old behaviour).

CMake 3.21 now checks this and throws a warning

6 weeks ago[CMAKE] Replace custom scripts in compilerflags with standard ones
Victor Perevertkin [Mon, 13 Sep 2021 16:51:08 +0000 (19:51 +0300)]
[CMAKE] Replace custom scripts in compilerflags with standard ones

- add_target_link_flags changed to target_link_options
- add_target_property changed to set_property(... APPEND ...)

6 weeks ago[IMM32] Undefine IMS_... constants
Katayama Hirofumi MZ [Tue, 14 Sep 2021 00:47:44 +0000 (09:47 +0900)]
[IMM32] Undefine IMS_... constants

CORE-11700

6 weeks ago[SDK][INCLUDE] Remove period (.) from comment 'Non SDK DCE types.' in undocuser.h
Katayama Hirofumi MZ [Mon, 13 Sep 2021 04:56:30 +0000 (13:56 +0900)]
[SDK][INCLUDE] Remove period (.) from comment 'Non SDK DCE types.' in undocuser.h

6 weeks ago[IMM32] Rewrite ImmConfigureIMEA/W (#3956)
Katayama Hirofumi MZ [Mon, 13 Sep 2021 03:47:15 +0000 (12:47 +0900)]
[IMM32] Rewrite ImmConfigureIMEA/W (#3956)

- Rewrite ImmConfigureIMEA and ImmConfigureIMEW functions.
- Add IMS_... macros for WM_IME_SYSTEM message, into <undocuser.h>.
- Delete useless strdupAtoW and strdupWtoA inline functions.
CORE-11700

6 weeks ago[TRANSLATION] Replace '\r\n' by '\n' from displayed strings, when possible.
Hermès Bélusca-Maïto [Mon, 13 Sep 2021 01:19:00 +0000 (03:19 +0200)]
[TRANSLATION] Replace '\r\n' by '\n' from displayed strings, when possible.

6 weeks ago[FORMATTING] Remove trailing whitespace. Addendum to 34593d93.
Hermès Bélusca-Maïto [Mon, 13 Sep 2021 01:33:14 +0000 (03:33 +0200)]
[FORMATTING] Remove trailing whitespace. Addendum to 34593d93.

Excluded: 3rd-party code (incl. wine) and most of the win32ss.

6 weeks ago[FORMATTING][TRANSLATION] Remove trailing whitespace. Addendum to 34593d93.
Hermès Bélusca-Maïto [Sun, 12 Sep 2021 22:52:19 +0000 (00:52 +0200)]
[FORMATTING][TRANSLATION] Remove trailing whitespace. Addendum to 34593d93.

Excluded: 3rd-party code (incl. wine).

6 weeks ago[TRANSLATION] Fix instances of strings with trailing whitespace before newlines.
Hermès Bélusca-Maïto [Sun, 12 Sep 2021 17:59:05 +0000 (19:59 +0200)]
[TRANSLATION] Fix instances of strings with trailing whitespace before newlines.

6 weeks ago[REACTOS] Fix some instances of DPRINTs with trailing whitespace before newlines.
Hermès Bélusca-Maïto [Sun, 12 Sep 2021 17:49:54 +0000 (19:49 +0200)]
[REACTOS] Fix some instances of DPRINTs with trailing whitespace before newlines.

6 weeks ago[REGEDIT] Fix "tr-TR.rc:68: unrecognized escape sequence" error.
Hermès Bélusca-Maïto [Sun, 12 Sep 2021 17:52:25 +0000 (19:52 +0200)]
[REGEDIT] Fix "tr-TR.rc:68: unrecognized escape sequence" error.

6 weeks ago[KBDHID] Fix returned Status for IOCTL_KEYBOARD_QUERY_*
Eric Kohl [Sun, 12 Sep 2021 21:36:18 +0000 (23:36 +0200)]
[KBDHID] Fix returned Status for IOCTL_KEYBOARD_QUERY_*

Addendum to 6249d5ede31ee6ba81f8b0cde94f5c8f875fd9a.

6 weeks ago[NTUSER] Improve Themed Scrollbars by Minimizing Updates (#3953)
Doug Lyons [Sun, 12 Sep 2021 20:54:46 +0000 (15:54 -0500)]
[NTUSER] Improve Themed Scrollbars by Minimizing Updates (#3953)

This fixes regressions CORE-17754 and CORE-17755 which regressed by
0.4.15-dev-3086-g 236649c626f97c68a9d0a6709a1bb342681b2aa0

6 weeks ago[NTOS:KD64,KE] IRQL is automatically adjusted during calls to KdEnterDebugger() and... 3942/head
Hermès Bélusca-Maïto [Sun, 5 Sep 2021 00:48:20 +0000 (02:48 +0200)]
[NTOS:KD64,KE] IRQL is automatically adjusted during calls to KdEnterDebugger() and KdExitDebugger(). (#3942)
Addendum to 608032bd and 835c3023.

The IRQL is actually raised by KeFreezeExecution() and lowered by
KeThawExecution(), always to HIGH_IRQL on MP systems, or if necessary
on UP. These functions are called respectively by KdEnterDebugger()
and KdExitDebugger().

6 weeks ago[NTOS:KD64] First unlock the KD port then lower the IRQL, instead of doing the revers...
Hermès Bélusca-Maïto [Sun, 5 Sep 2021 00:44:20 +0000 (02:44 +0200)]
[NTOS:KD64] First unlock the KD port then lower the IRQL, instead of doing the reverse. (#3942)

This properly reverses the operation of first raising the IRQL before
locking the KD port.

6 weeks ago[NTOS:KD64] KdPollBreakIn(): Use the KeRestoreInterrupts() inline.
Hermès Bélusca-Maïto [Sun, 5 Sep 2021 00:47:43 +0000 (02:47 +0200)]
[NTOS:KD64] KdPollBreakIn(): Use the KeRestoreInterrupts() inline.

6 weeks ago[MBEDTLS] Update to version 2.16.11. CORE-17326
Thomas Faber [Sun, 12 Sep 2021 00:15:13 +0000 (20:15 -0400)]
[MBEDTLS] Update to version 2.16.11. CORE-17326

6 weeks ago[MBEDTLS] Update to version 2.16.10. CORE-17326
Thomas Faber [Sun, 12 Sep 2021 00:10:32 +0000 (20:10 -0400)]
[MBEDTLS] Update to version 2.16.10. CORE-17326

6 weeks ago[MBEDTLS] Update to version 2.7.19. CORE-17252
Thomas Faber [Sun, 12 Sep 2021 00:10:19 +0000 (20:10 -0400)]
[MBEDTLS] Update to version 2.7.19. CORE-17252

6 weeks ago[MBEDTLS] Update to version 2.7.18. CORE-17252
Thomas Faber [Sat, 11 Sep 2021 23:54:15 +0000 (19:54 -0400)]
[MBEDTLS] Update to version 2.7.18. CORE-17252

6 weeks ago[MBEDTLS] Update to version 2.7.17. CORE-17252
Thomas Faber [Sat, 11 Sep 2021 23:41:25 +0000 (19:41 -0400)]
[MBEDTLS] Update to version 2.7.17. CORE-17252

6 weeks ago[KBDHID] IOCTL_KEYBOARD_QUERY_ATTRIBUTES: Return proper KEYBOARD_ATTRIBUTES buffer...
Eric Kohl [Sun, 12 Sep 2021 14:33:02 +0000 (16:33 +0200)]
[KBDHID] IOCTL_KEYBOARD_QUERY_ATTRIBUTES: Return proper KEYBOARD_ATTRIBUTES buffer size

6 weeks ago[CMD] tr-TR.rc Fix compiler warning CORE-17763
Joachim Henze [Sun, 12 Sep 2021 14:16:43 +0000 (16:16 +0200)]
[CMD] tr-TR.rc Fix compiler warning CORE-17763

GCC8.4.0 dbg warned about:
[675/1849] Building RC object base/shell/cmd/CMakeFiles/cmd.dir/cmd.rc.obj
In file included from C:/ros/reactos/base/shell/cmd/cmd.rc:87:
C:/ros/reactos/base/shell/cmd/lang/tr-TR.rc:349:61: warning: backslash and newline separated by space

I guess somebody made the checks more strict recently,
because that bug was existing for longer already without
generating any warning for me.

6 weeks ago[NTOS:SE] Use the captured security descriptor when access checking
George Bișoc [Sun, 12 Sep 2021 14:07:44 +0000 (16:07 +0200)]
[NTOS:SE] Use the captured security descriptor when access checking

When performing access security check, use the security descriptor that we've captured it to determine based on that descriptor if the client can be granted access or not.

6 weeks ago[KBDHID] Implement IOCTL_KEYBOARD_QUERY_INDICATOR_TRANSLATION
Eric Kohl [Sun, 12 Sep 2021 12:40:26 +0000 (14:40 +0200)]
[KBDHID] Implement IOCTL_KEYBOARD_QUERY_INDICATOR_TRANSLATION

6 weeks agoKBDHID: IOCTL_KEYBOARD_QUERY_* calls must return STATUS_BUFFER_TOO_SMALL if the outpu...
Eric Kohl [Sun, 12 Sep 2021 12:33:15 +0000 (14:33 +0200)]
KBDHID: IOCTL_KEYBOARD_QUERY_* calls must return STATUS_BUFFER_TOO_SMALL if the output buffer is too small

6 weeks ago[TRANSLATION] Add and improve Turkish (tr-TR) translation (#3561) 3561/head
Süleyman Poyraz [Mon, 29 Mar 2021 13:53:43 +0000 (16:53 +0300)]
[TRANSLATION] Add and improve Turkish (tr-TR) translation (#3561)

Reviewed-by: Can Taşan <ctasan99@hotmail.com>
Reviewed-by: Ercan Ersoy <ercanersoy@ercanersoy.net>
Signed-off-by: Süleyman Poyraz <zaryob.dev@gmail.com>
6 weeks ago[FASTFAT_NEW] "Fix" Flags bitfield to avoid RTC error
Timo Kreuzer [Sat, 14 Aug 2021 13:34:46 +0000 (15:34 +0200)]
[FASTFAT_NEW] "Fix" Flags bitfield to avoid RTC error

Since VS 16.11 the compiler sometimes emits calls to _RTC_UninitUse, when parts of a bitfield are initialized (See https://developercommunity.visualstudio.com/t/Broken-runtime-checks-with-CL-19293013/1503629). Fix this by using an ULONG instead of a bitfield.
Note: The structure uses a 24 bit bitfield plus an UCHAR, which is supposed to form a 32 bit field, but that doesn't work anyway.

6 weeks ago[ACPICA] Update to version 20210730. CORE-17760
Thomas Faber [Sat, 11 Sep 2021 02:19:51 +0000 (22:19 -0400)]
[ACPICA] Update to version 20210730. CORE-17760

6 weeks ago[ACPICA] Update to version 20210604. CORE-17760
Thomas Faber [Sat, 11 Sep 2021 02:15:19 +0000 (22:15 -0400)]
[ACPICA] Update to version 20210604. CORE-17760

6 weeks ago[ACPICA] Update to version 20210331. CORE-17760
Thomas Faber [Sat, 11 Sep 2021 02:12:00 +0000 (22:12 -0400)]
[ACPICA] Update to version 20210331. CORE-17760

6 weeks ago[ACPICA] Update to version 20210105. CORE-17760
Thomas Faber [Sat, 11 Sep 2021 01:59:41 +0000 (21:59 -0400)]
[ACPICA] Update to version 20210105. CORE-17760

6 weeks ago[DSOUND] Don't force status to failure by default in primarybuffer_SetFormat (#3911) 3911/head
Oleg Dubinskiy [Sun, 15 Aug 2021 14:06:56 +0000 (17:06 +0300)]
[DSOUND] Don't force status to failure by default in primarybuffer_SetFormat (#3911)

Don't force HRESULT status to DSERR_BUFFERLOST by default in primarybuffer_SetFormat function.
Assign to it S_OK instead, as done in current Wine:
https://source.winehq.org/git/wine.git/blob/a8583acae9548e6340d8400ec7710136cd061ab2:/dlls/dsound/primary.c#l440

That variable is already set to failure in other appropriate place, when this is indeed needed:
https://git.reactos.org/?p=reactos.git;a=blob;h=b04a526929e4e817ff63aa652530e5901a3253a6;f=dll/directx/wine/dsound/primary.c#l511

The assigned failure status caused executing failure handling code even when the fail actually didn't happen.
In particular, DSOUND_ReopenDevice failed on waveOutOpen call when calling this was not needed.
After my changes, it's called only when needed, i. e., only when the actual failure happens
Otherwise, if all goes good, that code is not called, so the data is transfered successfully and the function is working correctly.
It fixes non-working playback in QMMP 0.11.1 (via DirectSound ouput plugin) and AIMP 3.10 and newer versions.
Also it improves the DirectSound test results from MS DxDiag: now all 4 available tests are passing successfully, instead of only 2.
Other dsound issues also might be fixed as well.

CORE-10907 CORE-14783

6 weeks ago[IMM32] Restructure! (Retry) (#3952)
Katayama Hirofumi MZ [Fri, 10 Sep 2021 14:39:15 +0000 (23:39 +0900)]
[IMM32] Restructure! (Retry) (#3952)

The imm.c file became big and bloated, so we split the source file. CORE-11700
- Split the IMM32 code and do formatting.

6 weeks ago[SYSSETUP] Fix en-US translation. Add en-GB translation (#3950)
PopuriAO29 [Fri, 10 Sep 2021 11:10:25 +0000 (18:10 +0700)]
[SYSSETUP] Fix en-US translation. Add en-GB translation (#3950)

The British language wasn't included here, so I have corrected some texts that were in American English.

Also fixed one string that uses British English language.

6 weeks ago[DESK] Correction for English (United Kingdom) translation (#3949)
PopuriAO29 [Thu, 9 Sep 2021 22:48:41 +0000 (05:48 +0700)]
[DESK] Correction for English (United Kingdom) translation (#3949)

The word "personalize" should be "personalise" in British English.

6 weeks ago[NTOS:SE] Explicitly check the auto inherit flags right away 3947/head
George Bișoc [Wed, 8 Sep 2021 16:25:50 +0000 (18:25 +0200)]
[NTOS:SE] Explicitly check the auto inherit flags right away

As we now have the SEF_* flags declared within the SDK we can simply check for such flags directly wihout having to check for the hard-coded flag values.

6 weeks ago[XDK][KMTESTS:SE] Move the auto inherit ACE flags in the right place
George Bișoc [Wed, 8 Sep 2021 16:17:41 +0000 (18:17 +0200)]
[XDK][KMTESTS:SE] Move the auto inherit ACE flags in the right place

These bit flags are documented in CreatePrivateObjectSecurityEx API routine call in MSDN and their reasonable location should be XDK (NTIFS section more or less) and not Kernel tests suite (KMTESTs). Also assign these flags the right values.

https://docs.microsoft.com/en-us/windows/win32/api/securitybaseapi/nf-securitybaseapi-createprivateobjectsecurityex

6 weeks ago[ARM] Fix some compilation errors for ARM 3948/head
Stanislav Motylkov [Thu, 9 Sep 2021 15:56:32 +0000 (18:56 +0300)]
[ARM] Fix some compilation errors for ARM

CORE-17634 CORE-17604

6 weeks ago[IMM32] ValidateHwndNoErr(): Apply ReactOS-specific handle table array fixup. (#3937) 3937/head
Hermès Bélusca-Maïto [Tue, 7 Sep 2021 20:05:54 +0000 (22:05 +0200)]
[IMM32] ValidateHwndNoErr(): Apply ReactOS-specific handle table array fixup. (#3937)
CORE-17741

This function (which should belong to the user32 helpers) depends on the
internal format of the USER handles table, that is ReactOS-specific. Its
pointer value is stored in the win32k/user32 shared info section, and
thus cannot be converted to user-space and stored back into that section.
Therefore it needs to be retrieved and manually converted when the function
is called.

6 weeks ago[WIN32SS:NTUSER][USER32] NtUserProcessConnect() should return pointers in user client...
Hermès Bélusca-Maïto [Wed, 1 Sep 2021 23:11:19 +0000 (01:11 +0200)]
[WIN32SS:NTUSER][USER32] NtUserProcessConnect() should return pointers in user client-space. (#3937)

- Do the kernel/server --> user/client-space pointers conversion within
  NtUserProcessConnect(), instead of having the callers of this function
  doing this job.
  This makes the behaviour Windows-compatible.

  NOTE: the gHandleEntries pointer is ReactOS-specific!

- Drop the g_ulSharedDelta global, just use instead gSharedInfo.ulSharedDelta.

- Add extra documentation aspects for NtUserProcessConnect() that are
  not yet implemented in ReactOS.

6 weeks ago[WIN32SS:NTUSER] Update the definition of SHAREDINFO and fix the definition of FNID_L...
Hermès Bélusca-Maïto [Wed, 1 Sep 2021 23:05:46 +0000 (01:05 +0200)]
[WIN32SS:NTUSER] Update the definition of SHAREDINFO and fix the definition of FNID_LAST. (#3937)

6 weeks ago[WIN32KNT_APITEST] Add more tests for NtUserProcessConnect() (#3937)
Hermès Bélusca-Maïto [Sat, 4 Sep 2021 17:53:09 +0000 (19:53 +0200)]
[WIN32KNT_APITEST] Add more tests for NtUserProcessConnect() (#3937)

Show that NtUserProcessConnect() should return pointers in user client-space.

6 weeks ago[CRT_APITEST] Add tests for __i64tod/u64tod/i64tos/u64tos on ARM (#3866) 3866/head
Stanislav Motylkov [Wed, 8 Sep 2021 22:14:44 +0000 (01:14 +0300)]
[CRT_APITEST] Add tests for __i64tod/u64tod/i64tos/u64tos on ARM (#3866)

CORE-17713 CORE-17706 CORE-17604

6 weeks ago[CRT/ARM] Integer to float conversion implementation (#3866)
Roman Masanin [Wed, 28 Jul 2021 18:16:04 +0000 (21:16 +0300)]
[CRT/ARM] Integer to float conversion implementation (#3866)

CORE-17713 CORE-17706 CORE-17604

6 weeks ago[CRT_APITEST] Fix __fto64 test according to MS CRT behavior on x86 and x64
Stanislav Motylkov [Wed, 8 Sep 2021 21:56:03 +0000 (00:56 +0300)]
[CRT_APITEST] Fix __fto64 test according to MS CRT behavior on x86 and x64

Addendum to 99ba9846. CORE-17703 CORE-17604

6 weeks ago[CRT_APITEST] Add missing static CRT tests on ARM
Stanislav Motylkov [Wed, 8 Sep 2021 17:10:11 +0000 (20:10 +0300)]
[CRT_APITEST] Add missing static CRT tests on ARM

Addendum to c23ce9df. CORE-17604

6 weeks ago[MPR] Fix copy paste error when converting hex char to int.
Robert Naumann [Wed, 8 Sep 2021 16:59:08 +0000 (18:59 +0200)]
[MPR] Fix copy paste error when converting hex char to int.

Wine Commit 63737942a06183f6b2e7fa8f95a07c918c9bf29b
Original patch by Sergei Abramov. CORE-13863

6 weeks ago[CRT_APITEST] Do not test functions that are missing on ARM
Stanislav Motylkov [Wed, 8 Sep 2021 16:28:59 +0000 (19:28 +0300)]
[CRT_APITEST] Do not test functions that are missing on ARM

Addendum to 5f548654. ROSTESTS-374 CORE-17604

7 weeks ago[CRT/ARM] Floating point control functions implementation (#3870) 3870/head
Roman Masanin [Sun, 1 Aug 2021 14:30:41 +0000 (17:30 +0300)]
[CRT/ARM] Floating point control functions implementation (#3870)

Implement controlfp, statusfp, fpreset, clearfp. CORE-17757 CORE-17604

7 weeks ago[SETUPLIB] Default to "ReactOS (Debug)" boot entry on debug builds, instead of "ReactOS".
Hermès Bélusca-Maïto [Tue, 7 Sep 2021 20:25:34 +0000 (22:25 +0200)]
[SETUPLIB] Default to "ReactOS (Debug)" boot entry on debug builds, instead of "ReactOS".

7 weeks ago[TRANSLATION] Improvements to Portuguese (pt-PT) translation (#3842) 3842/head
Jose Carlos Jesus [Thu, 24 Jun 2021 17:36:36 +0000 (18:36 +0100)]
[TRANSLATION] Improvements to Portuguese (pt-PT) translation (#3842)

- [CALCS] Add Portuguese (pt-PT) translation
- [COMCTL32] Improve Portuguese (pt-PT) translation
- [COMDLG32] Improve Portuguese (pt-PT) translation
- [ACLUI] Improve Portuguese (pt-PT) translation
- [DEVMGR] Fix typos and improve pt-PT translation
- [SYSDM] Fix typos and improve pt-PT translation
- [CPL] Readjust objects position to fit all text

Signed-off-by: Jose Carlos Jesus <zecarlos1957@hotmail.com>
7 weeks ago[TRANSLATION] Update Portuguese (pt-PT) translation (#3876) 3876/head
Gabriel Aguiar [Tue, 3 Aug 2021 12:30:33 +0000 (13:30 +0100)]
[TRANSLATION] Update Portuguese (pt-PT) translation (#3876)

Co-authored-by: Gabriel Aguiar <fgygh5804@gmail.com>
Reviewed-by: Joachim Henze <Joachim.Henze@reactos.org>
Reviewed-by: Jose Carlos Jesus <zecarlos1957@hotmail.com>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
Signed-off-by: Gabriel Aguiar <fgsoftwarestudio@gmail.com>
7 weeks ago[GDI32] Fix Meta file packing recursion issues.
James Tabor [Mon, 6 Sep 2021 23:37:24 +0000 (18:37 -0500)]
[GDI32] Fix Meta file packing recursion issues.

TextOut was looping back adding additional EMR packet to the meta file.

7 weeks ago[GDI32] Do not fail on path with bitmap fonts.
James Tabor [Mon, 6 Sep 2021 22:53:35 +0000 (17:53 -0500)]
[GDI32] Do not fail on path with bitmap fonts.

Patch by Dmitry Timoshkov : ExtTextOut on a path with bitmap font
selected shouldn't fail.
This just leads to empty path generated.

7 weeks ago[NTOS:IO] Fix an ASSERT. Addendum to commit 1fd730b7.
Hermès Bélusca-Maïto [Sun, 5 Sep 2021 23:05:14 +0000 (01:05 +0200)]
[NTOS:IO] Fix an ASSERT. Addendum to commit 1fd730b7.

7 weeks ago[NTOS] Move two CODE_SEG("INIT") to a better place.
Hermès Bélusca-Maïto [Sun, 5 Sep 2021 19:05:05 +0000 (21:05 +0200)]
[NTOS] Move two CODE_SEG("INIT") to a better place.

7 weeks ago[NTOS:IO] IopInitializeDriverModule(): Set the DRVO_LEGACY_DRIVER flag if the driver... 3749/head
Hermès Bélusca-Maïto [Thu, 10 Jun 2021 23:30:40 +0000 (01:30 +0200)]
[NTOS:IO] IopInitializeDriverModule(): Set the DRVO_LEGACY_DRIVER flag if the driver is not WDM. (#3749)

7 weeks ago[REACTOS] Refactor CRegKey usage (#3779) temp
Serge Gautherie [Wed, 30 Jun 2021 22:08:33 +0000 (00:08 +0200)]
[REACTOS] Refactor CRegKey usage (#3779)

- [MSPAINT] ReadDWORD(): Improve 'dwValue' handling
Addendum to 3185db7 (r72158).

- [DRWTSN32] Settings_GetOutputPath(): Fix 'key' handling
Addendum to 1d10606.

- [RAPPS] Remove 2 superfluous 'CRegKey::Close()' calls
Follow-up to 42e111f.

7 weeks ago[NTDLL_APITEST] Write some NtDuplicateToken tests 3938/head
George Bișoc [Tue, 31 Aug 2021 10:36:28 +0000 (12:36 +0200)]
[NTDLL_APITEST] Write some NtDuplicateToken tests

Implement some tests for NtDuplicateToken syscall that exercises the effective only behavior when the calling thread tries to duplicate an access token but rendering it effective with enabled parts.

7 weeks ago[NTOS:SE] Implement effective token option upon duplication
George Bișoc [Tue, 31 Aug 2021 10:34:25 +0000 (12:34 +0200)]
[NTOS:SE] Implement effective token option upon duplication

This implements the EffectiveOnly option of SepDuplicateToken routine (used by NtDuplicateToken syscall and other functions alike) which makes the access token effective by removing the disabled parts like privileges and groups.

7 weeks ago[BOOTDATA] Update caroots.inf 3925/head
Mark Jansen [Sun, 22 Aug 2021 19:54:12 +0000 (21:54 +0200)]
[BOOTDATA] Update caroots.inf

* Add "Certum Trusted Root CA", "Certum EC-384 CA" (https://bugzilla.mozilla.org/show_bug.cgi?id=1707097)
* Add "ANF Secure Server Root CA" (https://bugzilla.mozilla.org/show_bug.cgi?id=1703942)
* Add "GLOBALTRUST 2020" (https://bugzilla.mozilla.org/show_bug.cgi?id=1697071)
* Add "GlobalSign Root E46", "GlobalSign Root R46" (https://bugzilla.mozilla.org/show_bug.cgi?id=1693173)
* Add "AC RAIZ FNMT-RCM SERVIDORES SEGUROS" (https://bugzilla.mozilla.org/show_bug.cgi?id=1683738)
* Add "NAVER Global Root Certification Authority" (https://bugzilla.mozilla.org/show_bug.cgi?id=1678166)
* Add "Trustwave Global ECC P384 Certification Authority", "Trustwave Global ECC P256 Certification Authority" , "Trustwave Global Certification Authority"(https://bugzilla.mozilla.org/show_bug.cgi?id=1663049)
* Add "e-Szigno Root CA 2017" (https://bugzilla.mozilla.org/show_bug.cgi?id=1645174)
* Add "Microsoft RSA Root Certificate Authority 2017", "Microsoft ECC Root Certificate Authority 2017" (https://bugzilla.mozilla.org/show_bug.cgi?id=1641716)

* Remove "LuxTrust Global Root 2" (https://bugzilla.mozilla.org/show_bug.cgi?id=1641718)
* Remove "Staat der Nederlanden Root CA - G3" (https://bugzilla.mozilla.org/show_bug.cgi?id=1687822)
* Remove "EE Certification Centre Root CA" (https://bugzilla.mozilla.org/show_bug.cgi?id=1651211)
* Remove "Trustis FPS Root CA" (https://bugzilla.mozilla.org/show_bug.cgi?id=1708307)
* Remove "Global Chambersign Root - 2008", "Chambers of Commerce Root - 2008" (https://bugzilla.mozilla.org/show_bug.cgi?id=1692094)
* Remove "Staat der Nederlanden Root CA - G2" (https://bugzilla.mozilla.org/show_bug.cgi?id=1639987)
* Remove "VeriSign Class 3 Public Primary Certification Authority - G4", "thawte Primary Root CA - G3", "thawte Primary Root CA - G2", "GeoTrust Primary Certification Authority - G3", "VeriSign Class 3 Public Primary Certification Authority - G5", "thawte Primary Root CA", "GeoTrust Primary Certification Authority", "GeoTrust Universal CA 2", "GeoTrust Universal CA", "GeoTrust Global CA" (https://bugzilla.mozilla.org/show_bug.cgi?id=1670769)
* Remove "VeriSign Universal Root Certification Authority", "GeoTrust Primary Certification Authority - G2" (https://bugzilla.mozilla.org/show_bug.cgi?id=1686854)
* Remove "OISTE WISeKey Global Root GA CA" (https://bugzilla.mozilla.org/show_bug.cgi?id=1653092)
* Remove "Taiwan GRCA" (https://bugzilla.mozilla.org/show_bug.cgi?id=1656077)
* Remove "Sonera Class 2 Root CA" (https://bugzilla.mozilla.org/show_bug.cgi?id=1710716)
* Remove "QuoVadis Root CA" (https://bugzilla.mozilla.org/show_bug.cgi?id=1710716)
* Remove "AddTrust External Root" (https://bugzilla.mozilla.org/show_bug.cgi?id=1645199)
* Remove "Verisign Class 3 Public Primary Certification Authority - G3"

CORE-17737
ROSBE-61

7 weeks ago[GITHUB] Automatically apply ROSTESTS label 3931/head
Mark Jansen [Sun, 5 Sep 2021 14:39:18 +0000 (16:39 +0200)]
[GITHUB] Automatically apply ROSTESTS label

7 weeks ago[COM_APITEST] Add mmc/certmgr tests
Mark Jansen [Thu, 26 Aug 2021 21:24:27 +0000 (23:24 +0200)]
[COM_APITEST] Add mmc/certmgr tests

CORE-16429

7 weeks ago[TRANSLATION] Add and improve Russian and Ukrainian translations
Stanislav Motylkov [Sun, 5 Sep 2021 13:22:29 +0000 (16:22 +0300)]
[TRANSLATION] Add and improve Russian and Ukrainian translations

[NETID]
- Add and improve Russian translation. Addendum to b9426a3f and c276681e.

[MACHINE.INF]
- Fix probably a machine translation. Addendum to 2d8274bd.
- Standardize some device names.
- Also add missing Ukrainian translation.

7 weeks ago[NTDLL_APITEST] Implement NtAdjustPrivilegesToken testcase 3939/head
George Bișoc [Wed, 1 Sep 2021 09:29:50 +0000 (11:29 +0200)]
[NTDLL_APITEST] Implement NtAdjustPrivilegesToken testcase

7 weeks ago[TRANSLATION] Fix minor typos and untranslated dialogs in Spanish (#3890) 3890/head
Julen Urizar Compains [Sun, 8 Aug 2021 18:11:30 +0000 (20:11 +0200)]
[TRANSLATION] Fix minor typos and untranslated dialogs in Spanish (#3890)

- usetup: New bootsector page.
- shell32: Copy and paste, and moving elements.
  Also, some strings related to the shutdown and logoff.
- Minor Spanish grammar fix - some female words and minor latin american typos.
- First revision of the .inf, that includes the translation of the Services,
  audio, processors and other drivers and minor things.

7 weeks ago[DSOUND] Improvements to DirectSound(Capture)EnumerateW (#3899) 3899/head
Oleg Dubinskiy [Wed, 11 Aug 2021 18:36:52 +0000 (21:36 +0300)]
[DSOUND] Improvements to DirectSound(Capture)EnumerateW (#3899)

Fix and improve DirectSoundEnumerateW and DirectSoundCaptureEnumerateW implementations in our dsound.

Use the Windows-compatible way to get the device name and pass it to callback.
- Don't use Wine-specific DSDRIVERDESC structure and DRV_QUERYDSOUNDDESC message, declared in sdk/include/dxsdk/dsdriver.h, whose are obsolete even in Wine for now.
- Instead, declare a new WAVEINCAPSW and WAVEOUTCAPSW structures (for input and output appropriately), call waveInGetDevCapsW and WaveOutGetDevCapsW for enumerated device ID and store retieved device name in these structures.
- Then pass them to a lpDSEnumCallbackW as well, without Ansi to Unicode conversion (since the retrieved string is Unicode already).
- Do this both for capture and playback functions.
- Addtionally, add MMSYSERR_BADDEVICEID status code to mmErr macro, because it also might be returned by waveIn/OutGetDevCapsW as well, in case of failure.
- And mark our dosund as forked, because it definitely will not be synced at least until we'll retarget to Vista or newer. Add an appropriate comment.

This fixes incorrect detection of DirectSound audio input and output devices, so now a lot of apps are able to detect it correctly, and can play the sound properly (e.g. AIMP 2.61 and IcyTower from RAPPS).

CORE-7535 CORE-10907 CORE-15324 CORE-15533 CORE-16340

7 weeks ago[CMLIB] arm64: Define PAGE_SIZE
Serge Gautherie [Mon, 24 May 2021 06:56:17 +0000 (08:56 +0200)]
[CMLIB] arm64: Define PAGE_SIZE

CORE-17518

7 weeks ago[HALX86:APIC] apic.c: Use new defines some more
Serge Gautherie [Sun, 14 Jun 2020 11:49:22 +0000 (13:49 +0200)]
[HALX86:APIC] apic.c: Use new defines some more

Follow-up to b7a149f.

7 weeks ago[BOOTDATA] livecd.ini: Fix 'APIC ACPI' typo
Serge Gautherie [Sun, 14 Jun 2020 11:49:22 +0000 (13:49 +0200)]
[BOOTDATA] livecd.ini: Fix 'APIC ACPI' typo

Addentum to 5ee0925.

7 weeks ago[SETUPLIB] CreateFreeLoaderReactOSEntries(): Fix 'VBoxDebug' typo
Serge Gautherie [Sun, 14 Jun 2020 11:49:22 +0000 (13:49 +0200)]
[SETUPLIB] CreateFreeLoaderReactOSEntries(): Fix 'VBoxDebug' typo

Match newer 84c2695.

Addendum to 69512e2 (r65813).

7 weeks ago[MSI] Fix dialog.c showing two taskbar panes on Cancel (#3861) 3861/head
Doug Lyons [Fri, 30 Jul 2021 01:56:24 +0000 (20:56 -0500)]
[MSI] Fix dialog.c showing two taskbar panes on Cancel (#3861)

Only show the main dialog pane on taskbar when executing a Cancel dialog.
Assign previous window handle as a parent when creating Cancel dialog box.

CORE-17702

7 weeks ago[UXTHEME][NTUSER] Fix flashing of scrollbar when scrolling (#3868) 3868/head
Doug Lyons [Sat, 31 Jul 2021 13:16:03 +0000 (08:16 -0500)]
[UXTHEME][NTUSER] Fix flashing of scrollbar when scrolling (#3868)

Based on a patch by I_Kill_Bugs.

7 weeks ago[TASKMGR] Handles: Get number only, skip data
Serge Gautherie [Wed, 11 Aug 2021 14:57:21 +0000 (16:57 +0200)]
[TASKMGR] Handles: Get number only, skip data

8 weeks ago[USER32][INCLUDE] Move GetImmFileName declaration from user32.h to user32p.h
Katayama Hirofumi MZ [Tue, 31 Aug 2021 04:42:54 +0000 (13:42 +0900)]
[USER32][INCLUDE] Move GetImmFileName declaration from user32.h to user32p.h

From: win32ss/user/user32/include/user32.h
To: win32ss/user/user32/include/user32p.h

CORE-11700

8 weeks ago[WDMAUD.DRV] Improve AC97 driver from rapps by defining USE_MMIXER_LIB
Joachim Henze [Mon, 30 Aug 2021 17:52:30 +0000 (19:52 +0200)]
[WDMAUD.DRV] Improve AC97 driver from rapps by defining USE_MMIXER_LIB

By taking alternative code-paths in WdmAud and bypassing Sysaudio.
This is my 2nd attempt to commit that.

Using USE_MMIXER_LIB relies on those 2 previous patches:
0.4.15-dev-765-g b8e936a57b4770e133772cf2dd66f30671a1524b CORE17214 (#3148) wdmaud-racecondition-fix and
0.4.15-dev-796-g a27f0debca4c0fe8cd916d2406124f9d30ae5dbe CORE17276 winmm:mixer-testbot-crash-fix

Defining USE_MMIXER_LIB will fix/improve:
- the test execution times of "GCCLin_x86 on Test VBox" will be dramatically improve (iirc by ~10-15min)
- CORE-8726/CORE-9986/CORE-16564 AC97 driver from rapps will work in the same session that the driver is installed, not a single reboot is needed anymore
- CORE13202 Unhandled exception from wdmaud.drv when recording sound in Scratch 1.4 leads to app-crash (gets fixed even for older builds that did not receive 0.4.15-dev-2794-g 81f8bce yet)
- CORE-13488 A deadlock in "DiabloII" character selection screen and "The Lion King II"
- CORE-9981 "DosBox + Commander Keen6" almost 100% fixed, DosBox + Commander Keen6 properly plays music instead of garbled output,
            same improvement for "ScummVM 2.0 with Monkey Island 2"

The playback is not yet *entirely* perfect, still a few hiccups now and then, but by orders of magnitude better than before.

Defining USE_MMIXER_LIB will also have some negative aspects:
- CORE-17277 crash of dsound:duplex on "GCCLin_x86 on Test VBox" gets unhidden on the bot, but was proven to be broken even beforehand already. The driver beforehand was just not found and the tests were skipped therefore.
- CORE-17278 crash of dsound:capture on "GCCLin_x86 on Test VBox" gets unhidden on the bot, but was proven to be broken even beforehand already. The driver beforehand was just not found and the tests were skipped therefore.
- It may also have a negative impact for CORE-17285 "Realtek HD Audio" but Oleg Dubinsky accepted to tolerate that and aims to approach it differently. I will resolve that as WontFix now.

8 weeks ago[CMAKE][BOOTDATA] Fix LiveCD does not import caroots.inf into registry CORE-17739...
Julio Carchi [Mon, 30 Aug 2021 11:07:12 +0000 (06:07 -0500)]
[CMAKE][BOOTDATA] Fix LiveCD does not import caroots.inf into registry CORE-17739 CORE-17735 (#3930)

It regressed by 0.4.9-dev-82-g 6158207c318bccaf1767d1a5c1545de45beb113d

KVM https://reactos.org/testman/compare.php?ids=78729,78730 LGTM
VBox https://reactos.org/testman/compare.php?ids=78728,78731 LGTM

2 months ago[IMM32] Rewrite ImmGetContext (#3923)
Katayama Hirofumi MZ [Mon, 23 Aug 2021 21:50:39 +0000 (06:50 +0900)]
[IMM32] Rewrite ImmGetContext (#3923)

- Add ValidateHwndNoErr and Imm32GetContextEx helper functions.
- Rewrite ImmGetContext function by using the helper functions.
CORE-11700

2 months ago[USER32][IMM32] Improve User32InitializeImmEntryTable (#3918)
Katayama Hirofumi MZ [Mon, 23 Aug 2021 07:25:21 +0000 (16:25 +0900)]
[USER32][IMM32] Improve User32InitializeImmEntryTable (#3918)

- Improve User32InitializeImmEntryTable function and related.
- Complete win32ss/user/user32/include/immtable.h table.
- Delete a hack in user32.DllMain and apply my magical tricks. This will fix some access violations in IMM32.
- Add some stubs into IMM32.
CORE-11700

2 months ago[NTOS:SE] SepSinglePrivilegeCheck doesn't expect a NT status code value
George Bișoc [Sun, 22 Aug 2021 09:31:57 +0000 (11:31 +0200)]
[NTOS:SE] SepSinglePrivilegeCheck doesn't expect a NT status code value

Fix a wrong returned datatype of the function, as SepSinglePrivilegeCheck calls the internal private SepPrivilegeCheck function which returns a BOOLEAN value.

2 months ago[NTOS:SE] Annotate the remaining functions with SAL 3897/head
George Bișoc [Fri, 20 Aug 2021 09:48:19 +0000 (11:48 +0200)]
[NTOS:SE] Annotate the remaining functions with SAL

2 months ago[NTOS:SE] Document the whole subsystem in Doxygen format
George Bișoc [Wed, 11 Aug 2021 14:24:45 +0000 (16:24 +0200)]
[NTOS:SE] Document the whole subsystem in Doxygen format

And update the file comment headers.

2 months ago[WIN32KNT_APITEST] Add NtUserGetThreadState testcase (#3922)
Katayama Hirofumi MZ [Sun, 22 Aug 2021 00:02:02 +0000 (09:02 +0900)]
[WIN32KNT_APITEST] Add NtUserGetThreadState testcase (#3922)

CORE-17732, CORE-11700

2 months ago[NTUSER] Improve NtUserQueryWindow (#3915)
Katayama Hirofumi MZ [Fri, 20 Aug 2021 22:31:10 +0000 (07:31 +0900)]
[NTUSER] Improve NtUserQueryWindow (#3915)

- Improve NtUserQueryWindow function.
- Add IMC structure.
- Modify THREADINFO structure.
CORE-11700

2 months ago[IMM32] Implement ImmWINNLSGetIMEHotkey (#3919)
Katayama Hirofumi MZ [Fri, 20 Aug 2021 22:24:12 +0000 (07:24 +0900)]
[IMM32] Implement ImmWINNLSGetIMEHotkey (#3919)

- Implement ImmWINNLSGetIMEHotkey function.
- Modify imm32.spec.
CORE-11700

2 months ago[IMM32] Rewrite ImmProcessKey (#3917)
Katayama Hirofumi MZ [Fri, 20 Aug 2021 22:22:43 +0000 (07:22 +0900)]
[IMM32] Rewrite ImmProcessKey (#3917)

- Rewrite ImmProcessKey function.
- Modify win32ss/include/imetable.h.
- Modify ImmProcessKey prototype.
CORE-1170

2 months ago[INCLUDE] Move WM_IME_SYSTEM from ntuser.h to undocuser.h (#3920)
Katayama Hirofumi MZ [Wed, 18 Aug 2021 23:18:20 +0000 (08:18 +0900)]
[INCLUDE] Move WM_IME_SYSTEM from ntuser.h to undocuser.h (#3920)

CORE-11700

2 months ago[NTUSER][INCLUDE] s/TransMsg[1]/TransMsg[ANYSIZE_ARRAY]/
Katayama Hirofumi MZ [Wed, 18 Aug 2021 10:59:35 +0000 (19:59 +0900)]
[NTUSER][INCLUDE] s/TransMsg[1]/TransMsg[ANYSIZE_ARRAY]/

CORE-11700

2 months ago[NTUSER][INCLUDE] Trivial formatting of TRANSMSG and TRANSMSGLIST
Katayama Hirofumi MZ [Wed, 18 Aug 2021 10:56:47 +0000 (19:56 +0900)]
[NTUSER][INCLUDE] Trivial formatting of TRANSMSG and TRANSMSGLIST

CORE-11700

2 months ago[IMM32] s/0x400/_WIN32_WINNT_NT4/
Katayama Hirofumi MZ [Wed, 18 Aug 2021 10:53:14 +0000 (19:53 +0900)]
[IMM32] s/0x400/_WIN32_WINNT_NT4/

Don't use magic numbers. CORE-11700

2 months ago[IMM32_APITEST] s/0x287/WM_IME_SYSTEM/
Katayama Hirofumi MZ [Wed, 18 Aug 2021 10:48:18 +0000 (19:48 +0900)]
[IMM32_APITEST] s/0x287/WM_IME_SYSTEM/

Don't use magic number. CORE-11700

2 months ago[IMM32] ImmGenerateMessage and ImmTranslateMessage (#3914)
Katayama Hirofumi MZ [Tue, 17 Aug 2021 23:42:12 +0000 (08:42 +0900)]
[IMM32] ImmGenerateMessage and ImmTranslateMessage (#3914)

- Rewrite `ImmGenerateMessage` and `ImmTranslateMessage` functions.
- Rename `INPUTCONTEXTDX.bHasVKey` as `bNeedsTrans`.
- Move `TRANSMSG` structure into `ntuser.h`.
- Add `TRANSMSGLIST` structure into `ntuser.h`.
- Add `UNDETERMINESTRUCT` structure to `ddk/imm.h`.
- Modify `NtUserGetAppImeLevel` prototype.
CORE-11700

2 months ago[IMM32] Refactor Part 2
Katayama Hirofumi MZ [Mon, 16 Aug 2021 06:45:11 +0000 (15:45 +0900)]
[IMM32] Refactor Part 2

Simplify the IMM32 code by deleting middle functions.
CORE-11700

2 months ago[IMM32_APITEST] Add ImmIsUIMessage testcase (#3908)
Katayama Hirofumi MZ [Mon, 16 Aug 2021 06:35:25 +0000 (15:35 +0900)]
[IMM32_APITEST] Add ImmIsUIMessage testcase (#3908)

- Add ImmIsUIMessage testcase in IMM32_APITEST. CORE-11700

2 months ago[IMM32] Rewrite ImmIsUIMessageA/W (#3907)
Katayama Hirofumi MZ [Mon, 16 Aug 2021 06:33:51 +0000 (15:33 +0900)]
[IMM32] Rewrite ImmIsUIMessageA/W (#3907)

- Rewrite ImmIsUIMessageA and ImmIsUIMessageW functions.
- Modify HIMC and HIMCC handle types for strictness. Add typecasts.
- Add WM_IME_SYSTEM macro.
- Modify imm32.spec.
CORE-11700

2 months ago[IMM32] Rewrite ImmEnumRegisterWordA/W (#3906)
Katayama Hirofumi MZ [Mon, 16 Aug 2021 06:31:39 +0000 (15:31 +0900)]
[IMM32] Rewrite ImmEnumRegisterWordA/W (#3906)

- Rewrite ImmEnumRegisterWordA and ImmEnumRegisterWordW functions.
- Modify win32ss/include/imetable.h.
CORE-11700

2 months ago[RTL/x64] Fix a typo RtplUnwindInternal -> RtlpUnwindInternal (#3912)
Kento Oki [Mon, 16 Aug 2021 01:23:02 +0000 (10:23 +0900)]
[RTL/x64] Fix a typo RtplUnwindInternal -> RtlpUnwindInternal (#3912)