3 years ago[WIN32K:NTUSER]
Thomas Faber [Sat, 26 Aug 2017 07:31:38 +0000 (07:31 +0000)]
- Remove unnecessary thread reference in IsThreadSuspended.

svn path=/trunk/; revision=75672

3 years ago[BROWSEUI] -CAddressEditBox: Populate address bar combobox. Patch by Barrett Karish...
Giannis Adamopoulos [Fri, 25 Aug 2017 15:03:25 +0000 (15:03 +0000)]
[BROWSEUI] -CAddressEditBox: Populate address bar combobox. Patch by  Barrett Karish with improvements by me to fix leaks and add error checks. CORE-10988

svn path=/trunk/; revision=75670

3 years ago[SHELL32] -Silence two unneeded prints.
Giannis Adamopoulos [Fri, 25 Aug 2017 08:59:10 +0000 (08:59 +0000)]
[SHELL32] -Silence two unneeded prints.

svn path=/trunk/; revision=75666

3 years ago[SHELL32] -CRecycleBin: Call GetDriveTypeW with correct parameters. Now files can...
Giannis Adamopoulos [Fri, 25 Aug 2017 08:44:13 +0000 (08:44 +0000)]
[SHELL32] -CRecycleBin: Call GetDriveTypeW with correct parameters. Now files can be deleted to the recycle bin again. Patch by Serge Gautherie. CORE-12340

svn path=/trunk/; revision=75665

3 years ago[USER32_APITEST] -Add a monster of a test to check if WM_DESTROYCLIPBOARD is blocking...
Giannis Adamopoulos [Thu, 24 Aug 2017 23:08:09 +0000 (23:08 +0000)]
[USER32_APITEST] -Add a monster of a test to check if WM_DESTROYCLIPBOARD is blocking or not. Use a critical section while recording as we use a single message cache in two threads. After 50154, 50816, 50846 and 75616 changing back and forth, this test shows that 75616 is correct and making sure that it won't be changed again in the future, somehting that would break the ole clipboard.

svn path=/trunk/; revision=75663

3 years ago[User32]
James Tabor [Thu, 24 Aug 2017 22:03:01 +0000 (22:03 +0000)]
- Patch by mudhead : If the index is out of range, no error should be set, see CORE-13716.

svn path=/trunk/; revision=75661

3 years ago[NTVDM]: Fix linear 4-bpp mode. Return the status of the AC palette when the index...
Aleksandar Andrejevic [Wed, 23 Aug 2017 04:44:55 +0000 (04:44 +0000)]
[NTVDM]: Fix linear 4-bpp mode. Return the status of the AC palette when the index register is read.

svn path=/trunk/; revision=75643

3 years ago[SHELL32] -CRecycleBin: Factor out a new class called CRecyclerDropTarget, which...
Giannis Adamopoulos [Tue, 22 Aug 2017 13:50:25 +0000 (13:50 +0000)]
[SHELL32] -CRecycleBin: Factor out a new class called CRecyclerDropTarget, which will take the data object and call SHFileOperation for its contents. Add a noisy print to show the parameters passed in SHFileOperation and make it to always use DROPEFFECT_MOVE. Make CDefaultContextMenu use the new drop target in order to delete a file.

svn path=/trunk/; revision=75640

3 years ago[FS_REC]
Colin Finck [Tue, 22 Aug 2017 09:09:19 +0000 (09:09 +0000)]
Always register CDFS as a low-priority filesystem. This inserts it at the tail of the filesystem queue instead of the head, meaning UDF always takes precedence and UDF/CDFS hybrid media is properly detected as UDF.
Thanks to Pierre for the hint!

Should fix what's reported in

svn path=/trunk/; revision=75638

3 years ago[OLE32] -Recreate the clipboard window if it isn't a valid window handle. Can happen...
Giannis Adamopoulos [Tue, 22 Aug 2017 08:02:30 +0000 (08:02 +0000)]
[OLE32] -Recreate the clipboard window if it isn't a valid window handle. Can happen if the thread that first used the ole clipboard exists which also leads to the clipboard window being destroyed.

svn path=/trunk/; revision=75637

3 years ago[SHELL32] Misc fixes for CFSFolder
Giannis Adamopoulos [Mon, 21 Aug 2017 12:18:46 +0000 (12:18 +0000)]
[SHELL32] Misc fixes for CFSFolder
- GetCLSIDForFileType: Check if the shell extension is blocked by the Blocked key like wine does.
- CFSFolder::BindToObject: Remove a redundant check as _ILGetFileStructW already does the same check.
- CFSFolder::GetUIObjectOf: Do not try to load an IconHandler or an arbitrary extension for directories.
- CFSFolder::SetNameOf: Simplify and make secure by using great helpers like wcscmp and PathCombineW

svn path=/trunk/; revision=75634

3 years ago[SHELL32] -CFSFolder: Fix a couple of handle leaks.
Giannis Adamopoulos [Mon, 21 Aug 2017 09:07:41 +0000 (09:07 +0000)]
[SHELL32] -CFSFolder: Fix a couple of handle leaks.

svn path=/trunk/; revision=75633

3 years ago[FS_REC]
Colin Finck [Sun, 20 Aug 2017 15:30:59 +0000 (15:30 +0000)]
- Add a detection routine for CDFS (ISO-9660) volumes that verifies the Primary Volume Descriptor.
- Use this to also detect CDFS on disks and load the CDFS driver if it has not been loaded yet (e.g. when a bootcd/livecd flashed USB drive is inserted at boot of an installed ReactOS).
- Fix a comment in udfs.c.

svn path=/trunk/; revision=75630

3 years ago[HDAUDBUS]
Thomas Faber [Sun, 20 Aug 2017 15:02:53 +0000 (15:02 +0000)]
- Correctly disable interrupts for status change events. Fixes infinite "HDA_InterruptService c0000000" debug spam (interrupt storm) on VMware with HDAudio sound enabled.
CORE-13704 #resolve

svn path=/trunk/; revision=75629

3 years ago[BROWSEUI]: Improve the rendering of the toolbar pin buttons. By dsp8195. Sorry for...
Hermès Bélusca-Maïto [Sun, 20 Aug 2017 12:05:25 +0000 (12:05 +0000)]
[BROWSEUI]: Improve the rendering of the toolbar pin buttons. By dsp8195. Sorry for the delay!

svn path=/trunk/; revision=75628

3 years ago[SHELL32]
Eric Kohl [Sun, 20 Aug 2017 08:47:23 +0000 (08:47 +0000)]
Folder Options: Japanese TreeView translation.
Patch by Katajama Hirofumi MZ.

svn path=/trunk/; revision=75627

3 years ago[SYSSETUP]
Eric Kohl [Sun, 20 Aug 2017 08:27:16 +0000 (08:27 +0000)]
Japanese translation of Theme dialog.
Patch by Katajama Hirofumi MZ.

svn path=/trunk/; revision=75626

3 years ago[SHELL32] -CFSDropTarger: Improve the debug message that shows the first thing that...
Giannis Adamopoulos [Sat, 19 Aug 2017 15:48:47 +0000 (15:48 +0000)]
[SHELL32] -CFSDropTarger: Improve the debug message that shows the first thing that is copied or moved and where. This way we sort of know what parameters we pass to SHFileOperationW.

svn path=/trunk/; revision=75625

3 years ago[USETUP]
Colin Finck [Sat, 19 Aug 2017 14:53:54 +0000 (14:53 +0000)]
Add type 0x96 as "CDFS/ISO-9660" to our list of partition types now that our ISOs flashed to USB use it.

svn path=/trunk/; revision=75624

3 years ago[SHELL32] -CFSDropTarget: Simplyfy the code path that handles the CFSTR_SHELLIDLIST...
Giannis Adamopoulos [Sat, 19 Aug 2017 11:19:06 +0000 (11:19 +0000)]
[SHELL32] -CFSDropTarget: Simplyfy the code path that handles the CFSTR_SHELLIDLIST format. Don't use FOF_MULTIDESTFILES to keep things simple. CORE-13176

svn path=/trunk/; revision=75623

3 years ago[SHELL32] -Simplify the drop target of CRecycleBin to let the data object generate...
Giannis Adamopoulos [Sat, 19 Aug 2017 11:09:28 +0000 (11:09 +0000)]
[SHELL32] -Simplify the drop target of CRecycleBin to let the data object generate the list of names that can be passed to SHFileOperationW.

svn path=/trunk/; revision=75622

3 years ago[WINED3D] Dereference context slightly later, as seen in wine. This prevents some...
Mark Jansen [Sat, 19 Aug 2017 09:51:17 +0000 (09:51 +0000)]
[WINED3D] Dereference context slightly later, as seen in wine. This prevents some crashes while applications are starting up. (f.e. ANNO1602)

svn path=/trunk/; revision=75621

3 years ago[WLANAPI] map rpc to win error codes
Christoph von Wittich [Sat, 19 Aug 2017 06:04:08 +0000 (06:04 +0000)]
[WLANAPI] map rpc to win error codes

svn path=/trunk/; revision=75620

3 years ago[SHELL32] -CDefaultContextMenu: Correctly differentiate the copy and the cut commands.
Giannis Adamopoulos [Fri, 18 Aug 2017 17:39:34 +0000 (17:39 +0000)]
[SHELL32] -CDefaultContextMenu: Correctly differentiate the copy and the cut commands.

svn path=/trunk/; revision=75619

3 years ago[SHELL32] -CDefViewBckgrndMenu: Fix pasting in the background of a folder.
Giannis Adamopoulos [Fri, 18 Aug 2017 17:32:20 +0000 (17:32 +0000)]
[SHELL32] -CDefViewBckgrndMenu: Fix pasting in the background of a folder.

svn path=/trunk/; revision=75618

3 years ago[OLE32] Do not crash on an invalid / empty clipboard.
Mark Jansen [Fri, 18 Aug 2017 17:18:46 +0000 (17:18 +0000)]
[OLE32] Do not crash on an invalid / empty clipboard.

svn path=/trunk/; revision=75617

3 years ago[WIN32K] -NtUserEmptyClipboard: Change its behaviour to wait for WM_DESTROYCLIPBOARD...
Giannis Adamopoulos [Fri, 18 Aug 2017 17:18:17 +0000 (17:18 +0000)]
[WIN32K] -NtUserEmptyClipboard: Change its behaviour to wait for WM_DESTROYCLIPBOARD to return so it behaves like windows and our ole32 doesn't trip on its assumptions that everything works fine. A test will be written soon to prove that this is correct. CORE-12302

svn path=/trunk/; revision=75616

3 years ago[MSPAINT] Use Gdiplus::Bitmap in place of ATL::CImage to load pictures -- this un...
Benedikt Freisen [Fri, 18 Aug 2017 17:01:01 +0000 (17:01 +0000)]
[MSPAINT] Use Gdiplus::Bitmap in place of ATL::CImage to load pictures -- this un-breaks loading a picture's resolution from file

svn path=/trunk/; revision=75615

3 years ago[FTFD] Ignore NULL objects in free() wrapper
Timo Kreuzer [Fri, 18 Aug 2017 15:02:05 +0000 (15:02 +0000)]
[FTFD] Ignore NULL objects in free() wrapper

svn path=/trunk/; revision=75613

3 years ago[FTFD] Fix indentation
Timo Kreuzer [Fri, 18 Aug 2017 15:02:01 +0000 (15:02 +0000)]
[FTFD] Fix indentation

svn path=/trunk/; revision=75612

3 years ago[STOBJECT]
Eric Kohl [Fri, 18 Aug 2017 14:49:11 +0000 (14:49 +0000)]
- Add support for the hotplug icon.
- Set default menu items in the context menus.
- Use a timer to properly distinguish between a single and a double click on an icon.
- Some code cleanup.

svn path=/trunk/; revision=75611

3 years ago[NTOSKRNL] Fix 64 bit warnings about conversion in PsExitSpecialApc and PspTerminateT...
Timo Kreuzer [Fri, 18 Aug 2017 12:31:19 +0000 (12:31 +0000)]
[NTOSKRNL] Fix 64 bit warnings about conversion in PsExitSpecialApc and PspTerminateThreadByPointer

svn path=/trunk/; revision=75610

3 years agoRevert "[WIN32K] Fix probing and parameter validation in NtGdiPolyPolyDraw"
Timo Kreuzer [Fri, 18 Aug 2017 12:18:41 +0000 (12:18 +0000)]
Revert "[WIN32K] Fix probing and parameter validation in NtGdiPolyPolyDraw"

svn path=/trunk/; revision=75609

3 years ago[WIN32K] Fix probing and parameter validation in NtGdiPolyPolyDraw
Timo Kreuzer [Fri, 18 Aug 2017 11:15:54 +0000 (11:15 +0000)]
[WIN32K] Fix probing and parameter validation in NtGdiPolyPolyDraw

svn path=/trunk/; revision=75608

3 years ago[SHELL32] Shell extension support for files.
Giannis Adamopoulos [Fri, 18 Aug 2017 09:11:59 +0000 (09:11 +0000)]
[SHELL32] Shell extension support for files.
- CFSFolder: Implement binding to files, implement loading arbitrary extensions for GetUIObjectOf from the registry, implement loading IconHandler shell extensions. Use the new helper routines to simplify getting the drop target.
- Improve the shortcut icons hack.

svn path=/trunk/; revision=75607

3 years ago[NDK] Fix prototype of Nt/ZwQuerySystemInformation
Timo Kreuzer [Fri, 18 Aug 2017 08:44:08 +0000 (08:44 +0000)]
[NDK] Fix prototype of Nt/ZwQuerySystemInformation

svn path=/trunk/; revision=75606

3 years ago[NTOSKRNL] Fix memory area macros
Timo Kreuzer [Fri, 18 Aug 2017 08:42:43 +0000 (08:42 +0000)]
[NTOSKRNL] Fix memory area macros

svn path=/trunk/; revision=75605

3 years ago[STOBJECT] Fix bug that caused some resource strings not to be loaded.
Giannis Adamopoulos [Fri, 18 Aug 2017 08:38:52 +0000 (08:38 +0000)]
[STOBJECT] Fix bug that caused some resource strings not to be loaded.
- These strings need to either be in every language file or have their own resource range but since we are using the same resource ids with windows I will just duplicate them.

svn path=/trunk/; revision=75604

3 years ago[PSDK][GDIPLUS] Further work on Graphics
Benedikt Freisen [Fri, 18 Aug 2017 08:09:04 +0000 (08:09 +0000)]
[PSDK][GDIPLUS] Further work on Graphics

svn path=/trunk/; revision=75603

3 years ago[NTOSKRNL] Remove duplicate fields from MEMORY_AREA
Timo Kreuzer [Fri, 18 Aug 2017 07:13:34 +0000 (07:13 +0000)]
[NTOSKRNL] Remove duplicate fields from MEMORY_AREA

svn path=/trunk/; revision=75602

3 years ago[WIN32K] -Fix a bug with TransparentBlt when it should really ignore the alpha channe...
Giannis Adamopoulos [Thu, 17 Aug 2017 22:45:51 +0000 (22:45 +0000)]
[WIN32K] -Fix a bug with TransparentBlt when it should really ignore the alpha channel. CORE-13040. Approved by Timo.

svn path=/trunk/; revision=75601

3 years ago[UXTHEME] -Remove some dead code
Giannis Adamopoulos [Thu, 17 Aug 2017 21:31:52 +0000 (21:31 +0000)]
[UXTHEME] -Remove some dead code

svn path=/trunk/; revision=75600

3 years ago[USBHUB_NEW]
Thomas Faber [Thu, 17 Aug 2017 19:55:13 +0000 (19:55 +0000)]
- Fix interval calculation in USBH_Wait. Patch by Vadim Galyant.

svn path=/trunk/; revision=75599

3 years ago[CMIDriver]
Thomas Faber [Thu, 17 Aug 2017 19:25:32 +0000 (19:25 +0000)]
- Set svn:eol-style to CRLF for inf files. Files that end up on the iso should never have 'native' line endings.

svn path=/trunk/; revision=75598

3 years ago[SHELL32] -Simplify some coe in CShellLink.cpp
Giannis Adamopoulos [Thu, 17 Aug 2017 16:46:15 +0000 (16:46 +0000)]
[SHELL32] -Simplify some coe in CShellLink.cpp

svn path=/trunk/; revision=75597

3 years ago[SHIMENG] Enable the Application Compatibility framework by default.
Mark Jansen [Thu, 17 Aug 2017 16:42:29 +0000 (16:42 +0000)]
[SHIMENG] Enable the Application Compatibility framework by default.
- Also add disabled keys to configure the logging
- Demote a noisy print used in the shim engine.
At this point the shim engine should be functional enough to be used.
One thing that remains is creating more shims(fixes) to use, and implement more features for the already existing ones.

svn path=/trunk/; revision=75596

3 years ago[SHELL32] -AddFSClassKeysToArray: Increase the size of the buffer for the value read...
Giannis Adamopoulos [Thu, 17 Aug 2017 16:35:16 +0000 (16:35 +0000)]
[SHELL32] -AddFSClassKeysToArray: Increase the size of the buffer for the value read from the registry. There are cases when 40 are not enough.

svn path=/trunk/; revision=75595

3 years ago[ACLAYERS] Add a compatibility shim + layer for the VMWare Horizon setup.
Mark Jansen [Thu, 17 Aug 2017 16:27:56 +0000 (16:27 +0000)]
[ACLAYERS] Add a compatibility shim + layer for the VMWare Horizon setup.
This fixes the setup trying to print some debug strings.
For now the shim has to be applied manually, however the setup does not complete yet.
Patch bits & fixes by Thomas.

svn path=/trunk/; revision=75594

3 years ago[COM_APITEST] -Add tests for CLSID_AttachmentServices.
Giannis Adamopoulos [Thu, 17 Aug 2017 16:01:29 +0000 (16:01 +0000)]
[COM_APITEST] -Add tests for CLSID_AttachmentServices.

svn path=/trunk/; revision=75593

3 years ago[ADVAPI32] -RegOpenKeyExW: Call NtOpenKey again with aligned parameters if STATUS_DAT...
Giannis Adamopoulos [Thu, 17 Aug 2017 14:37:24 +0000 (14:37 +0000)]
[ADVAPI32] -RegOpenKeyExW: Call NtOpenKey again with aligned parameters if STATUS_DATATYPE_MISALIGNMENT was returned the first time. CORE-13689

svn path=/trunk/; revision=75592

3 years ago[CDFS]
Colin Finck [Thu, 17 Aug 2017 12:21:27 +0000 (12:21 +0000)]
- Add a basic CDFS filesystem library "cdfslib" for checking and formatting a CDFS volume. Checking is unimplemented and formatting not supported anyway :)
- Use this library in the new "ucdfs" DLL and that DLL in "autochk". Fixes the "Unable to verify a CDFS volume" message at boot.
- Return the right device type (FILE_DEVICE_CD_ROM or FILE_DEVICE_DISK) in when querying volume information in cdfs.sys to get the proper icon in Explorer.

svn path=/trunk/; revision=75591

3 years ago[FORMATTING]
Colin Finck [Thu, 17 Aug 2017 12:18:28 +0000 (12:18 +0000)]
Convert all tabs to spaces in ntdddisk.h

svn path=/trunk/; revision=75590

3 years ago[ADVAPI32]
Eric Kohl [Thu, 17 Aug 2017 12:11:10 +0000 (12:11 +0000)]
RegQueryInfoKey: Initializing *lpcbSecurityDescriptor before calling NtQueryKey fixes the remaining api tests.

svn path=/trunk/; revision=75589

3 years ago[NTDLL_APITEST] Test unaligned pointers for NtOpenKey
Mark Jansen [Thu, 17 Aug 2017 11:42:13 +0000 (11:42 +0000)]
[NTDLL_APITEST] Test unaligned pointers for NtOpenKey

svn path=/trunk/; revision=75588

3 years ago[ADVAPI32_APITEST] Addendum to 75585, use void pointers to work around gcc ignoring...
Mark Jansen [Thu, 17 Aug 2017 11:06:46 +0000 (11:06 +0000)]
[ADVAPI32_APITEST] Addendum to 75585, use void pointers to work around gcc ignoring pshpack1.

svn path=/trunk/; revision=75587

3 years ago- Add 0x96 as ISO9660 partition type to ntdddisk.h (from
Colin Finck [Thu, 17 Aug 2017 11:03:40 +0000 (11:03 +0000)]
- Add 0x96 as ISO9660 partition type to ntdddisk.h (from and detect it using IsRecognizedPartition.
- Make our isohybrid create an MBR with partition type 0x96.

This properly assigns a drive letter to the Live-CD and lets me boot into desktop using "qemu -hda livecd.iso".
Fixes CORE-13184

svn path=/trunk/; revision=75586

3 years ago[ADVAPI32_APITEST] Test unaligned pointers for RegOpenKeyExW.
Mark Jansen [Thu, 17 Aug 2017 10:30:10 +0000 (10:30 +0000)]
[ADVAPI32_APITEST] Test unaligned pointers for RegOpenKeyExW.

svn path=/trunk/; revision=75585

3 years ago[PSDK][GDIPLUS] Further work on wrapper classes Pen, Graphics and Brush
Benedikt Freisen [Thu, 17 Aug 2017 09:44:57 +0000 (09:44 +0000)]
[PSDK][GDIPLUS] Further work on wrapper classes Pen, Graphics and Brush

svn path=/trunk/; revision=75584

3 years ago[WIN32K] Revert an accidental change from r75566
Timo Kreuzer [Thu, 17 Aug 2017 09:39:43 +0000 (09:39 +0000)]
[WIN32K] Revert an accidental change from r75566
Fixes gdi32_winetest metafile regression

svn path=/trunk/; revision=75583

3 years ago[WIN32K] Don't call IntIsFontRenderingEnabled() while holding an exclusive GDI object...
Timo Kreuzer [Thu, 17 Aug 2017 09:08:57 +0000 (09:08 +0000)]
[WIN32K] Don't call IntIsFontRenderingEnabled() while holding an exclusive GDI object lock.
Should fix GUI hangs.

svn path=/trunk/; revision=75582

3 years ago[CDFS]
Colin Finck [Wed, 16 Aug 2017 23:12:55 +0000 (23:12 +0000)]
Fix uninitialized variable usage (why did neither MSVC nor GCC catch this?)

svn path=/trunk/; revision=75581

3 years ago[NTOS] Make the GET_HASH_ENTRY() macro return a pointer to the entry instead of the...
Timo Kreuzer [Wed, 16 Aug 2017 20:30:45 +0000 (20:30 +0000)]
[NTOS] Make the GET_HASH_ENTRY() macro return a pointer to the entry instead of the entry itself.
Implicitly it was already returning a pointer, which was then referenced using a "." instead of "->", giving the impression we were working on the returned object instead of the original data. - Convert some macros to inline functions

svn path=/trunk/; revision=75580

3 years ago[CDFS]
Colin Finck [Wed, 16 Aug 2017 20:04:55 +0000 (20:04 +0000)]
Register CDFS as a disk filesystem too in order to flash our ISOs directly to USB drives and boot from them. Also fix some DPRINTs in the course of that.

One step closer towards CORE-13184: This gets qemu -hda bootcd.iso to work.
What still doesn't work is qemu -hda livecd.iso and booting from a flashed USB drive on real hardware.
Further changes are also required in fs_rec, but this code isn't ready yet and doesn't seem to be the current blocker either.

Credits go to the entire Hackfest Team for helping on this!!

svn path=/trunk/; revision=75579

3 years ago[PSDK][GDIPLUS] Further Pen work
Benedikt Freisen [Wed, 16 Aug 2017 18:13:22 +0000 (18:13 +0000)]
[PSDK][GDIPLUS] Further Pen work

svn path=/trunk/; revision=75578

3 years ago[PSDK] Add Win10 NTDDI version defines, improve version check
Timo Kreuzer [Wed, 16 Aug 2017 17:10:06 +0000 (17:10 +0000)]
[PSDK] Add Win10 NTDDI version defines, improve version check

svn path=/trunk/; revision=75577

3 years ago[PSDK][GDIPLUS] Partly implement Pen
Benedikt Freisen [Wed, 16 Aug 2017 16:19:17 +0000 (16:19 +0000)]
[PSDK][GDIPLUS] Partly implement Pen

svn path=/trunk/; revision=75576

3 years ago[FLTMC][NFSD] Fix version definition
Timo Kreuzer [Wed, 16 Aug 2017 16:06:41 +0000 (16:06 +0000)]
[FLTMC][NFSD] Fix version definition

svn path=/trunk/; revision=75575

3 years ago[KERNEL32] Support PAGE_EXECUTE_WRITECOPY in CreateFileMappingW if OsMajorVersion...
Timo Kreuzer [Wed, 16 Aug 2017 16:06:36 +0000 (16:06 +0000)]
[KERNEL32] Support PAGE_EXECUTE_WRITECOPY in CreateFileMappingW if OsMajorVersion is 6+.

svn path=/trunk/; revision=75574

3 years ago[DELAYIMP] Use underscore symbol prefix only on x86
Timo Kreuzer [Wed, 16 Aug 2017 16:06:31 +0000 (16:06 +0000)]
[DELAYIMP] Use underscore symbol prefix only on x86

svn path=/trunk/; revision=75573

3 years ago[PSDK] Add SymSrvIsStoreW prototype to dbghelp.h
Timo Kreuzer [Wed, 16 Aug 2017 16:06:27 +0000 (16:06 +0000)]
[PSDK] Add SymSrvIsStoreW prototype to dbghelp.h

svn path=/trunk/; revision=75572

3 years ago[INTRIN.H] Add _mul128 and _umul128 prototypes and remove some obsolete ones from...
Timo Kreuzer [Wed, 16 Aug 2017 16:06:22 +0000 (16:06 +0000)]
[INTRIN.H] Add _mul128 and _umul128 prototypes and remove some obsolete ones from the MSC version.

svn path=/trunk/; revision=75571

3 years ago[FAT32] Remove duplicated print
Timo Kreuzer [Wed, 16 Aug 2017 16:06:18 +0000 (16:06 +0000)]
[FAT32] Remove duplicated print

svn path=/trunk/; revision=75570

3 years ago[SHELLDESKTOP] Add missing dependency to psdk
Timo Kreuzer [Wed, 16 Aug 2017 16:06:14 +0000 (16:06 +0000)]
[SHELLDESKTOP] Add missing dependency to psdk

svn path=/trunk/; revision=75569

3 years ago[SETUPAPI]
Eric Kohl [Wed, 16 Aug 2017 14:18:42 +0000 (14:18 +0000)]
Add stubs for the remaining range list functions.

svn path=/trunk/; revision=75568

3 years ago[WIN32K] Remove old comments
Timo Kreuzer [Wed, 16 Aug 2017 14:18:08 +0000 (14:18 +0000)]
[WIN32K] Remove old comments

svn path=/trunk/; revision=75567

3 years ago[WIN32K]
Timo Kreuzer [Wed, 16 Aug 2017 13:37:15 +0000 (13:37 +0000)]
- Refactor GreExtTextOutW to use a single exit path instead of 3
- Call MouseSafetyOnDraw* only for direct DCs

svn path=/trunk/; revision=75566

3 years ago[SETUPAPI]
Eric Kohl [Wed, 16 Aug 2017 11:45:21 +0000 (11:45 +0000)]
- Implement CMP_GetBlockedDriverInfo.
- Make sure that CMP_GetServerSideDeviceInstallFlags and CMP_WaitServicesAvailable can be called on local and remote machines.

svn path=/trunk/; revision=75565

3 years ago[FREELDR]
Colin Finck [Wed, 16 Aug 2017 10:44:15 +0000 (10:44 +0000)]
Lower MAX_DISKREADBUFFER_SIZE to let INT 13h, AH=42h only read a maximum of 127 sectors (instead of 128 previously).
This fixes USB booting into the kernel on at least Dell Latitude D531 and Lenovo ThinkPad X61.

Now CORE-13184 remains (in a VM and on real hardware, probably related to the CDFS driver)

svn path=/trunk/; revision=75564

3 years ago[PSDK][GDIPLUS] Forward NULL parameters to wrapped functions instead of blindly deref...
Benedikt Freisen [Wed, 16 Aug 2017 09:57:56 +0000 (09:57 +0000)]
[PSDK][GDIPLUS] Forward NULL parameters to wrapped functions instead of blindly dereferencing them when trying to pass a pointee's pointer member to the wrapped function

svn path=/trunk/; revision=75563

3 years ago[SETUPAPI]
Eric Kohl [Wed, 16 Aug 2017 09:44:20 +0000 (09:44 +0000)]
Implement CM_Create_Range_List and CM_Free_Range_List. Still WIP.

svn path=/trunk/; revision=75562

3 years ago[SHLWAPI] -Addendum to 75533. Pass the id offset to IContextMenu::InvokeCommand....
Giannis Adamopoulos [Tue, 15 Aug 2017 23:02:45 +0000 (23:02 +0000)]
[SHLWAPI] -Addendum to 75533. Pass the id offset to IContextMenu::InvokeCommand. Fixes launching applications from the start menu. CORE-13680

svn path=/trunk/; revision=75561

3 years ago[WIN32K] IntEngBitBlt returns BOOL, not NTSTATUS!
Timo Kreuzer [Tue, 15 Aug 2017 18:13:14 +0000 (18:13 +0000)]
[WIN32K] IntEngBitBlt returns BOOL, not NTSTATUS!
Fix usage in NtGdiSetDIBitsToDeviceInternal accordingly and get rid of NTSTATUS variable entirely.

svn path=/trunk/; revision=75553

3 years ago[ACPPAGE] Do not allow shims to be applied to files in System32/WinSxs.
Mark Jansen [Tue, 15 Aug 2017 12:37:25 +0000 (12:37 +0000)]
[ACPPAGE] Do not allow shims to be applied to files in System32/WinSxs.

svn path=/trunk/; revision=75552

3 years ago[DDK]
Thomas Faber [Tue, 15 Aug 2017 12:32:05 +0000 (12:32 +0000)]
- Fix calling convention for NDIS_PROC. Fixes stack corruption when running 3rd party network drivers
CORE-13685 #resolve

svn path=/trunk/; revision=75551

3 years ago[SHELL32] -Greatly optimize the already hacky implementations of ILIsEqual, ILIsParen...
Giannis Adamopoulos [Tue, 15 Aug 2017 12:13:19 +0000 (12:13 +0000)]
[SHELL32] -Greatly optimize the already hacky implementations of ILIsEqual, ILIsParent and ILFindChild by not using the crappy _ILSimpleGetText but the new one _ILHACKCompareSimpleIds. CORE-13681

svn path=/trunk/; revision=75550

3 years ago[ATL] Use the AtlThrow helper so we can disable exceptions by defining _ATL_NO_EXCEPTIONS
Mark Jansen [Tue, 15 Aug 2017 09:02:17 +0000 (09:02 +0000)]
[ATL] Use the AtlThrow helper so we can disable exceptions by defining _ATL_NO_EXCEPTIONS

svn path=/trunk/; revision=75549

3 years ago[EXPLORER]
Eric Kohl [Mon, 14 Aug 2017 20:43:14 +0000 (20:43 +0000)]
Improve the taskbar property sheet.
- Improve the preview images (pixel perfect).
- Improve the Japanese translation.
Patch by Katayama Hirofumi MZ.

svn path=/trunk/; revision=75548

3 years ago[VARIOUS]
Eric Kohl [Mon, 14 Aug 2017 20:14:19 +0000 (20:14 +0000)]
Mass update for Romanian resource files.
Patch by Ștefan Fulea.

svn path=/trunk/; revision=75547

3 years ago[SHIMENG] Filter shims based on the include/exclude node specified, as well as their...
Mark Jansen [Mon, 14 Aug 2017 16:34:56 +0000 (16:34 +0000)]
[SHIMENG] Filter shims based on the include/exclude node specified, as well as their presence in certain directories.
- Shims are not allowed on files from System32 / WinSxs.
- Individual shims can override this per module with includes/excludes.
- Shims can specify additional dlls to ignore or include.
- Specify a default list of dlls to be included from system32.

svn path=/trunk/; revision=75541

3 years ago[USETUP]
Thomas Faber [Mon, 14 Aug 2017 16:01:46 +0000 (16:01 +0000)]
- Include some actually useful information when printing errors

svn path=/trunk/; revision=75536

3 years ago[COMCTL32] -DrawShadowText: Don't print an error when GdiAlphaBlend fails. This can...
Giannis Adamopoulos [Mon, 14 Aug 2017 15:51:12 +0000 (15:51 +0000)]
[COMCTL32] -DrawShadowText: Don't print an error when GdiAlphaBlend fails. This can happen when the painting is outside the clip region. Some themes tend to move text elements in weird places so as just to hide them so this only causes spam.

svn path=/trunk/; revision=75535

3 years agomissing german translation and sort treeview alphabetically
Eric Kohl [Mon, 14 Aug 2017 15:40:15 +0000 (15:40 +0000)]
missing german translation and sort treeview alphabetically
Patches by: reactosfanboy and Katayama Hierofumi MZ
CORE-13674 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=75534

3 years ago[SHELL32]
Giannis Adamopoulos [Mon, 14 Aug 2017 15:25:58 +0000 (15:25 +0000)]
- CDefaultContextMenu: Make it respect the IContextMenu interface and expect menu id offsets instead of real menu ids and actually use the idCmdFirst and idCmdLast parameters in QueryContextMenu. Make the default part use and existed menu from the resources but changed accordingly so the ids of its elements can be adjusted to the next free id of the constructed menu. Rename InsertMenuItemsOfDynamicContextMenuExtension to AddShellExtensionsToMenu, DoDynamicShellExtensions to InvokeShellExt, and DoStaticShellExtensions to InvokeRegVerb. Make AddShellExtensionsToMenu and AddStaticContextMenusToMenu behave like QueryContextMenu to return the number of ids they occupy. Add two helpers SHGetMenuIdFromMenuMsg and SHSetMenuIdInMenuMsg to change the id that is contained in the lparam of WM_DRAWITEM and WM_MEASUREITEM before forwarding them.
- CDefView: When calling QueryContextMenu before using TrackPopupMenu, use 1 as the first id that will filled by the IContextMenu because we want 0 to be used as an indicator that the menu was canceled. Use SHGetMenuIdFromMenuMsg and SHSetMenuIdInMenuMsg to change the lparam of the messages forwarded to the IContextMenu accordingly.
- CDefViewBckgrndMenu: Add a hack so as to keep the code as simple as possible while respecting idCmdFirst and idCmdLast.
- CNewMenu: Remove a hack that was needed because WM_DRAWITEM didn't come with the menu id offset but with the real menu id.
- CDesktopFolder, CFSFolder: Make the callbacks avoid adding an extra separators.
After that shell extensions in menus should work better and callbacks to shell folders should really be able to add several menu items.

svn path=/trunk/; revision=75533

3 years ago[USETUP] Remove one special case for keyboard devices
Hervé Poussineau [Sun, 13 Aug 2017 13:11:43 +0000 (13:11 +0000)]
[USETUP] Remove one special case for keyboard devices

Keyboard devices must have an upperfilter (kdbclass) to work correctly. Detect these
devices using the Keyboard GUID class instead of using the inf section name.

svn path=/trunk/; revision=75532

3 years ago[MOVEFILE]
Pierre Schweitzer [Sun, 13 Aug 2017 10:15:55 +0000 (10:15 +0000)]
Open source the movefile utily that allows queueing deletion/renaming operations for the next reboot

svn path=/trunk/; revision=75531

3 years ago[ROSINTERNALS]
Pierre Schweitzer [Sat, 12 Aug 2017 20:43:53 +0000 (20:43 +0000)]
Addendum to r75529

svn path=/trunk/; revision=75530

3 years ago[ROSINTERNALS]
Pierre Schweitzer [Sat, 12 Aug 2017 20:39:12 +0000 (20:39 +0000)]
Move the sysinternals tools to their own directory: rosinternals. To be completed :-)

svn path=/trunk/; revision=75529

3 years ago[PENDMOVES]
Pierre Schweitzer [Sat, 12 Aug 2017 18:17:12 +0000 (18:17 +0000)]
Open source the PendMoves utility from Sysinternals that allow easy display of renaming/deleting operations queued for next reboot.

svn path=/trunk/; revision=75528

3 years ago[EVTLIB]: Allow specifying a memory allocation tag when freeing the allocated buffers...
Hermès Bélusca-Maïto [Fri, 11 Aug 2017 12:37:15 +0000 (12:37 +0000)]
[EVTLIB]: Allow specifying a memory allocation tag when freeing the allocated buffers (functionality similar to the Ex**WithTag kernel functions).
[EVENTLOG]: Use the previous functionality; use also the internal LogfpAlloc() / LogfpFree() functions when dealing with buffers related to event log files.

svn path=/trunk/; revision=75527

3 years ago[RAPPS] Delete uTorrent until CORE-13666 is cleared up.
Mark Jansen [Thu, 10 Aug 2017 17:09:58 +0000 (17:09 +0000)]
[RAPPS] Delete uTorrent until CORE-13666 is cleared up.

svn path=/trunk/; revision=75521