Katayama Hirofumi MZ [Tue, 24 Dec 2019 04:48:33 +0000 (13:48 +0900)]
[WIN32SS][FREETYPE][NTGDI] Clarify calculation precedence for '&' and '?'
Katayama Hirofumi MZ [Tue, 24 Dec 2019 04:29:29 +0000 (13:29 +0900)]
[MSPAINT] Use '%ld x %ld' rather than '%d x %d'
Katayama Hirofumi MZ [Tue, 24 Dec 2019 04:08:35 +0000 (13:08 +0900)]
[MSPAINT] Add const to SelectionModel::SetSrcAndDestRectFromPoints parameters
Hermès Bélusca-Maïto [Mon, 23 Dec 2019 16:58:57 +0000 (17:58 +0100)]
[BOOTVID] Correctly fix scrolling and printing when the scroll region contains the whole screen.
Addendum fixes to
ca370b49 (r52239) and
a965ca6b (r52409).
- Fix the comments to explain what is really happening.
- Fix the boundary calculations in VidDisplayString() so that we can
correctly display a character in the very last column before going
to the next line, and fix similarly the vertical boundary calculation.
- Port the fixes to the ARM code.
Hermès Bélusca-Maïto [Sun, 22 Dec 2019 13:54:33 +0000 (14:54 +0100)]
[BOOTVID] Factor out the common code that is used before setting pixels.
Hermès Bélusca-Maïto [Sun, 22 Dec 2019 13:48:57 +0000 (14:48 +0100)]
[BOOTVID] Code style fixes; Replace some 'do-while' loops by 'for' loops when it makes the code simpler.
+ Fix a potential bug in BitBlt() "4bpp blitting" in case Top == Bottom (i.e. Height == 0).
Hermès Bélusca-Maïto [Sun, 22 Dec 2019 13:09:43 +0000 (14:09 +0100)]
[BOOTVID] Replace hardcoded screen and font size numbers by #define-d values.
Hermès Bélusca-Maïto [Sun, 22 Dec 2019 12:53:17 +0000 (13:53 +0100)]
[FREELDR] Support setting up the EBP register on INT386() entry only if EBP != 0, otherwise use it only as output.
Katayama Hirofumi MZ [Mon, 23 Dec 2019 19:30:25 +0000 (04:30 +0900)]
[MSPAINT] Refactor updateCanvasAndScrollbars
Katayama Hirofumi MZ [Mon, 23 Dec 2019 19:18:40 +0000 (04:18 +0900)]
[MSPAINT] Simplify choosecolor initialization
Katayama Hirofumi MZ [Mon, 23 Dec 2019 19:16:44 +0000 (04:16 +0900)]
[MSPAINT] Simplify lfTextFont initialization
Katayama Hirofumi MZ [Mon, 23 Dec 2019 19:13:43 +0000 (04:13 +0900)]
[MSPAINT] Use hProgInstance for LoadImage
Katayama Hirofumi MZ [Mon, 23 Dec 2019 19:11:33 +0000 (04:11 +0900)]
[MSPAINT] Use correct type for custColors
Joachim Henze [Mon, 23 Dec 2019 14:07:06 +0000 (15:07 +0100)]
[APISETS] Appease regression CORE-16563 for another function
Symptom: "Far Manager main app unhandled exception when exiting"
The issue started to show with 0.4.13-dev-986-g
029b8f2cf9912b148f3e60be0472652f26a1adb9
Thanks to Mark Jansen for providing this 2nd patch.
I intend to port this back into 0.4.13RC.
Joachim Henze [Mon, 23 Dec 2019 12:26:42 +0000 (13:26 +0100)]
[APISETS] Appease regression CORE-16563
Symptom: "Far Manager main app does not longer start up"
The issue started to show with 0.4.13-dev-986-g
029b8f2cf9912b148f3e60be0472652f26a1adb9
Thanks to Mark Jansen for providing this first patch.
I intend to port this back into 0.4.13RC,
but we are not completely done with this ticket.
Katayama Hirofumi MZ [Mon, 23 Dec 2019 11:19:48 +0000 (20:19 +0900)]
[SDK][ATL] Use CStringW in CImage
Katayama Hirofumi MZ [Mon, 23 Dec 2019 10:43:20 +0000 (19:43 +0900)]
[SHIMGVW] Image Viewer transparent image fix (#2165)
If the pixel is transparent or translucent, fill the background with a checkered pattern. CORE-15287
Katayama Hirofumi MZ [Mon, 23 Dec 2019 08:05:38 +0000 (17:05 +0900)]
[UNICODE] Re-trial to fix Travis build
Katayama Hirofumi MZ [Mon, 23 Dec 2019 07:46:52 +0000 (16:46 +0900)]
[UNICODE] Trial to fix Travis build
Amine Khaldi [Sun, 22 Dec 2019 23:58:51 +0000 (00:58 +0100)]
[UNICODE] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sun, 22 Dec 2019 23:58:26 +0000 (00:58 +0100)]
[REG] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sun, 22 Dec 2019 23:58:01 +0000 (00:58 +0100)]
[CSCRIPT][WSCRIPT] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sun, 22 Dec 2019 23:57:33 +0000 (00:57 +0100)]
[LOCALUI] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sun, 22 Dec 2019 23:57:10 +0000 (00:57 +0100)]
[INETCPL] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sun, 22 Dec 2019 23:56:47 +0000 (00:56 +0100)]
[XMLLITE_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sun, 22 Dec 2019 23:56:19 +0000 (00:56 +0100)]
[XMLLITE] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sun, 22 Dec 2019 23:55:56 +0000 (00:55 +0100)]
[XINPUT1_3_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sun, 22 Dec 2019 23:55:33 +0000 (00:55 +0100)]
[WUAPI] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sun, 22 Dec 2019 23:55:08 +0000 (00:55 +0100)]
[WTSAPI32_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sun, 22 Dec 2019 23:54:46 +0000 (00:54 +0100)]
[WTSAPI32] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sun, 22 Dec 2019 23:54:23 +0000 (00:54 +0100)]
[PSDK] Update wtsapi32.h. CORE-16441
Mark Jansen [Sat, 21 Sep 2019 20:06:12 +0000 (22:06 +0200)]
[CMAKE] Update baseaddresses
Mark Jansen [Sat, 14 Dec 2019 17:28:03 +0000 (18:28 +0100)]
[SDK] Update the gen_baseaddress script
- Remove some debug leftovers
- Automatically write the correct file
Mark Jansen [Sat, 21 Sep 2019 20:03:49 +0000 (22:03 +0200)]
[GEN_BASEADDRESS] Fix the script for python 3 and update *_pe.dll entries,
as hinted by hermes
Katayama Hirofumi MZ [Sun, 22 Dec 2019 13:59:22 +0000 (22:59 +0900)]
[GDI32_APITEST] Fix GetGlyphOutline testcase (#2163)
ROSTESTS-340
Eric Kohl [Sun, 22 Dec 2019 13:40:18 +0000 (14:40 +0100)]
[DNSAPI] Set proper record flags for query results and converted records
Eric Kohl [Sun, 22 Dec 2019 11:43:23 +0000 (12:43 +0100)]
[IDL] Add missing acf files
Eric Kohl [Sun, 22 Dec 2019 10:21:04 +0000 (11:21 +0100)]
[DNSAPI][DNSRSLVR] Implement DnsGetCacheDataTable()
Eric Kohl [Sat, 21 Dec 2019 21:12:21 +0000 (22:12 +0100)]
[DNSRSLVR] Set proper flags for the hosts file entries
Katayama Hirofumi MZ [Sat, 21 Dec 2019 13:38:49 +0000 (22:38 +0900)]
[BOOTDATA][NTUSER] Fix GetSystemMetrics values (#2137)
Fix user32!GetSystemMetrics values. CORE-16547
SM_MENUDROPALIGNMENT and SM_CXSMSIZE
Mark Jansen [Sat, 14 Dec 2019 16:16:00 +0000 (17:16 +0100)]
[ATL_APITEST] Fix CComVariant test
Timo Kreuzer [Mon, 9 Dec 2019 16:16:02 +0000 (17:16 +0100)]
[APITESTS] Improve and fix tests
Timo Kreuzer [Sat, 7 Dec 2019 10:33:10 +0000 (11:33 +0100)]
[PSDK] Add versionhelpers.h
Timo Kreuzer [Fri, 29 Nov 2019 07:14:56 +0000 (08:14 +0100)]
[PSDK] Add extern "C" for c++ code in mmddk.h
Timo Kreuzer [Tue, 19 Sep 2017 09:17:12 +0000 (11:17 +0200)]
[GDI32_APITEST] Remove duplicated test in Test_CreateBitmap
Timo Kreuzer [Tue, 26 Dec 2017 15:10:16 +0000 (16:10 +0100)]
[NTDLL_APITEST] Remove duplicated test for RtlInitilizeBitMap
Timo Kreuzer [Tue, 26 Dec 2017 19:08:24 +0000 (20:08 +0100)]
[APITESTS] Add PROJECT(ApiTests) to get a separate VS solution file
Timo Kreuzer [Wed, 4 Dec 2019 15:20:18 +0000 (16:20 +0100)]
[TESTS] Instead of entirely skipping tests with ros_skip_flaky, only disable counting errors
Katayama Hirofumi MZ [Mon, 16 Dec 2019 11:37:23 +0000 (20:37 +0900)]
[USER32] Add ICO_ExtractIconExW RetPtr NULL check (#2149)
CORE-16557
Victor Perevertkin [Mon, 16 Dec 2019 00:21:28 +0000 (03:21 +0300)]
[USBOHCI] Use KeQueryTickCount for timeouts instead of KeQuerySystemTime
Victor Perevertkin [Sun, 15 Dec 2019 23:28:41 +0000 (02:28 +0300)]
[KS] Use KeQueryTickCount for timeouts instead of KeQuerySystemTime
This avoids overflow when system time is changed between calls (for example, via NTP)
Eric Kohl [Sun, 15 Dec 2019 18:53:23 +0000 (19:53 +0100)]
[NETAPI32][WKSSVC] Implement NetGetJoinInformation using the workstation service
Eric Kohl [Sun, 15 Dec 2019 17:21:11 +0000 (18:21 +0100)]
[WIDL] Fix type offset calculation for toplevel pointers to non-basetypes.
WIDL used the wrong type information when a pointer to a non-basetype is used as a functions parameter. For example, a 'wchar_t**' would be treated as a 'wchar_t*'.
This patch will be sent upstream.
Hermès Bélusca-Maïto [Sun, 15 Dec 2019 02:37:52 +0000 (03:37 +0100)]
[BLUE] Improve initialization and interfacing with INBV.
CORE-15901
This fixes display reset transition when an external module acquired
INBV ownership and then released it, similarly to what was done in
commit
0ad65796 for VIDEOPRT.
For this a backup screenbuffer is used to store the contents of the
screen just before an INBV screen acquire transition, and these contents
are restored when it is detected that INBV ownership has been released.
Also, the active text font associated with the active console code-page
is restored, as well as the cursor state and shape.
In addition, any user of BLUE.SYS is now required to explicitly issue
a new IOCTL_CONSOLE_RESET_SCREEN to either enable or disable the screen.
This allows avoiding nasty unwanted screen mode switches when a handle
to the \Device\BlueScreen device is opened but no screen mode switch was
actually wanted - This "fixes" this annoyance on ReactOS and Windows,
when these are running witha VGA-compatible video driver and one wants
to look at properties of the \Device\BlueScreen device using
Sysinternals' WinObj.
Following this, we don't need to check anymore for explicit INBV
ownership by issuing calls to InbvCheckDisplayOwnership(), but instead
we check whether the screen has beeen manually enabled using the
aforementioned IOCTL. This partly supersedes commit
8b553a4b, and allows
fixing the second bug, namely that if we start ReactOS without the
/NOGUIBOOT option (and thus, INBV is active during boot), USETUP would
not show up anything because BLUE.SYS wouldn't display anything on screen.
See CORE-15901.
[USETUP][CONSRV] Call IOCTL_CONSOLE_RESET_SCREEN to tell BlueScreen device to enable the screen.
Hermès Bélusca-Maïto [Sun, 15 Dec 2019 01:41:42 +0000 (02:41 +0100)]
[BLUE] Use ExFreePoolWithTag().
Hermès Bélusca-Maïto [Sat, 14 Dec 2019 17:22:49 +0000 (18:22 +0100)]
[BLUE] Improve includes.
Hermès Bélusca-Maïto [Sat, 14 Dec 2019 17:05:45 +0000 (18:05 +0100)]
[BLUE] Code formatting, add SAL2 annotations, and update file source headers.
Doug Lyons [Sat, 14 Dec 2019 15:51:49 +0000 (09:51 -0600)]
[CONSRV] Fix for console windows shrinking on Minimize and Restore (#2014)
CORE-14200
Thomas Faber [Sat, 14 Dec 2019 08:04:07 +0000 (09:04 +0100)]
[ACPICA] Update to version
20191213. CORE-16559
Victor Perevertkin [Fri, 13 Dec 2019 01:44:31 +0000 (04:44 +0300)]
[MSI_WINETEST] Fix build with CMake 3.9.0 and higher (attempt #2)
Victor Perevertkin [Fri, 13 Dec 2019 01:15:57 +0000 (04:15 +0300)]
[MSI_WINETEST] Fix build with CMake 3.9.0 and higher
Bișoc George [Wed, 11 Dec 2019 23:25:55 +0000 (00:25 +0100)]
[OSK] Refactor the registry configuration code (#2096)
Rewrite LoadDataFromRegistry() and SaveDataToRegistry() as function helpers. With these, we'll be able to load and save data to registry on our choice.
Bișoc George [Wed, 11 Dec 2019 23:24:20 +0000 (00:24 +0100)]
[SHELL32] Do not return -1 if a file is not valid or not found - ExtractIconEx() (#2113)
ExtractIconEx() returns the number of successfully extracted icons from a file. The routine may return 0 in case no icons could be extracted but it could also return 0 if the file is not a valid PE image file or the file couldn't be found.
PrivateExtractIcons and the internal USER32 routine, ICO_ExtractIconExW(), return -1 in such scenarios. The behaviour is correct however we do not want that ExtractIconEx() returns -1 as well as it doesn't comply with the general documentation. In such cases, simply return 0 as no successful icons have been extracted due to related file failures.
CORE-16535
Serge Gautherie [Tue, 10 Dec 2019 12:17:17 +0000 (13:17 +0100)]
[VGA_NEW] Fix 2 'MAX_USHORT' typos in commented code (#2145)
Serge Gautherie [Tue, 10 Dec 2019 12:16:46 +0000 (13:16 +0100)]
[SETUPLIB] Fix 'MAX_USHORT' typo in a comment (#2144)
Serge Gautherie [Tue, 10 Dec 2019 12:16:26 +0000 (13:16 +0100)]
[CMD] Fix 'MAX_ULONG' typo in a comment (#2143)
Jose Carlos Jesus [Tue, 10 Dec 2019 12:13:58 +0000 (12:13 +0000)]
[TRANSLATION] Update Portuguese translation (#2125)
Add translation for joy.cpl and update it for comdlg32.dll.
Serge Gautherie [Tue, 10 Dec 2019 11:37:43 +0000 (12:37 +0100)]
[CONFIGURE] Add support for 'Visual Studio 2019, v16.4' (#2147)
Katayama Hirofumi MZ [Tue, 10 Dec 2019 02:07:56 +0000 (11:07 +0900)]
[COMCTL32][USER32] Fix radio button regression (#2146)
PR #2135 (
e329e83) caused radiobutton regression. This PR will fix it.
- Clear DT_BOTTOM | DT_VCENTER flags upon calculating the button text height.
CORE-16552
jimtabor [Tue, 10 Dec 2019 01:15:49 +0000 (19:15 -0600)]
[SetupAPI] Sync to wine.
See CORE-16543.
jimtabor [Mon, 9 Dec 2019 17:19:18 +0000 (11:19 -0600)]
Merge branch 'master' of https://github.com/reactos/reactos
jimtabor [Mon, 9 Dec 2019 17:18:32 +0000 (11:18 -0600)]
[Win32SS] Fix Opaque Text Fade while in Desktop Startup
See CORE-16498.
Katayama Hirofumi MZ [Mon, 9 Dec 2019 12:16:28 +0000 (21:16 +0900)]
[WIN32SS][COMCTL32] Improve button text position (#2135)
Improve DrawText function especially DT_CALCRECT and DT_VCENTER. CORE-15478
Katayama Hirofumi MZ [Mon, 9 Dec 2019 11:55:13 +0000 (20:55 +0900)]
[KERNEL32_APITEST] Follow-up of #2131
Katayama Hirofumi MZ [Mon, 9 Dec 2019 01:50:04 +0000 (10:50 +0900)]
[NTUSER] Improve loading settings (SystemParamtersInfo) (#2139)
Fix SPI_GETSCREENSAVETIMEOUT, SPI_GETKEYBOARDSPEED and SPI_GETKEYBOARDDELAY values. CORE-16547
Tibor Lajos Füzi [Mon, 9 Dec 2019 01:09:31 +0000 (02:09 +0100)]
[TRANSLATION] Fix hungarian translation for usetup & syssetup to use formal addressing / conjugation (#2138)
Katayama Hirofumi MZ [Mon, 9 Dec 2019 01:02:50 +0000 (10:02 +0900)]
[USER32_APITEST] Add DrawText testcase (#2140)
This PR will add a testcase for user32!DrawText function. CORE-15478
Eric Kohl [Sun, 8 Dec 2019 18:18:16 +0000 (19:18 +0100)]
[WKSSVC] Implement parts of NetrJoinDomain2 to join a work group
NOTE: We can not connect to a work group yet!
Thomas Faber [Sun, 8 Dec 2019 11:52:31 +0000 (12:52 +0100)]
[LIBMPG123] Update to version 1.25.13. CORE-16550
Thomas Faber [Sun, 8 Dec 2019 11:36:30 +0000 (12:36 +0100)]
[LIBTIFF] Update to version 4.1.0. CORE-16550
Eric Kohl [Sun, 8 Dec 2019 11:46:35 +0000 (12:46 +0100)]
[NETAPI32] Add RPC binding code to remaining functions that require explicit binding
Katayama Hirofumi MZ [Sun, 8 Dec 2019 10:30:51 +0000 (19:30 +0900)]
[MEDIA][FONTS] Improve tahomabd.ttf (Latin) No.35
Tahoma Bold.
Version 0.021 khmz.
11px LATIN CAPITAL LETTER B (again).
CORE-8408
Eric Kohl [Sun, 8 Dec 2019 09:52:37 +0000 (10:52 +0100)]
[NETAPI32] Add RPC binding code to functions that require explicit binding
Katayama Hirofumi MZ [Sun, 8 Dec 2019 09:00:00 +0000 (18:00 +0900)]
[MEDIA][FONTS] Improve tahomabd.ttf (Latin) No.34
Tahoma Bold.
Version 0.020 khmz.
11px LATIN CAPITAL LETTER B.
CORE-8408
Katayama Hirofumi MZ [Sun, 8 Dec 2019 04:11:52 +0000 (13:11 +0900)]
[MMIXER_TEST] Fix build (Use %Iu for dwUser)
Katayama Hirofumi MZ [Sun, 8 Dec 2019 03:45:33 +0000 (12:45 +0900)]
[WINMM_WINETEST][SDK][INCLUDE] Try to fix MSVC winmm:generated build
Hermès Bélusca-Maïto [Sun, 8 Dec 2019 01:26:26 +0000 (02:26 +0100)]
[WINLOGON] Start the screensaver on the user desktop, since support for secure screensaver desktop is not completely implemented in Winlogon. CORE-16548
Eric Kohl [Sun, 8 Dec 2019 01:03:26 +0000 (02:03 +0100)]
[PSDK] Replace the wine version of lmjoin.h by an extended version that includes NetJoinDomain and NetUnjoinDomain.
Katayama Hirofumi MZ [Sat, 7 Dec 2019 22:58:14 +0000 (07:58 +0900)]
[SHELL32] Fix hung-up of shell32:shlfileop (#2136)
#2085 caused some failures and hung-up in shell32:shlfileop testcase. This PR will fix it.
CORE-16546
Joachim Henze [Sat, 7 Dec 2019 17:35:06 +0000 (18:35 +0100)]
[CONSRV] Speed up console txt output CORE-16187
By demoting good-path DPRINT1 to DPRINT.
HBelusca agreed.
The more important commit to solve CORE-16187 has
been done beforehand in 0.4.14-dev-553-g
1dcdb4c2d0298ee71822c1d432a30604a82bbd21
Amine Khaldi [Sat, 7 Dec 2019 12:12:15 +0000 (13:12 +0100)]
[WSHOM_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 7 Dec 2019 12:11:52 +0000 (13:11 +0100)]
[WSHOM.OCX] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 7 Dec 2019 12:11:29 +0000 (13:11 +0100)]
[WMVCORE_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 7 Dec 2019 12:11:07 +0000 (13:11 +0100)]
[WMVCORE] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 7 Dec 2019 12:10:44 +0000 (13:10 +0100)]
[PSDK] Update wmsdkidl.idl. CORE-16441
Amine Khaldi [Sat, 7 Dec 2019 12:10:23 +0000 (13:10 +0100)]
[WMIUTILS_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 7 Dec 2019 12:10:01 +0000 (13:10 +0100)]
[WMIUTILS] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 7 Dec 2019 12:09:39 +0000 (13:09 +0100)]
[WLDAP32] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 7 Dec 2019 12:09:17 +0000 (13:09 +0100)]
[WINTRUST_WINETEST] Sync with Wine Staging 4.18. CORE-16441
Amine Khaldi [Sat, 7 Dec 2019 12:08:52 +0000 (13:08 +0100)]
[WINTRUST] Sync with Wine Staging 4.18. CORE-16441