Michael Martin [Wed, 8 Sep 2010 21:30:40 +0000 (21:30 +0000)]
[ntoskrnl/po]
- When an IRP is freed in a Completion routine the return Status is STATUS_MORE_PROCESSING_REQUIRED to let IoCompleteRequest know not to do anything further with the IRP.
svn path=/trunk/; revision=48724
Eric Kohl [Wed, 8 Sep 2010 10:39:37 +0000 (10:39 +0000)]
[SCSIPORT]
Implement RequestTimerCall-Notification. This is used by uniata.
svn path=/trunk/; revision=48723
Eric Kohl [Tue, 7 Sep 2010 15:21:06 +0000 (15:21 +0000)]
[USETUP]
Allocate a drive layout buffer that is large enough to keep a primary partition table (4 partition entries) plus 26 logical drives (2 partition entries each). Total 56 partition entries. This should be enough for everybody until we support GPT partition tables. ;-)
See issue #5270 for more details.
svn path=/trunk/; revision=48722
Eric Kohl [Tue, 7 Sep 2010 15:08:29 +0000 (15:08 +0000)]
Improvements to NtAdjustPrivilegesToken part 4 (last one):
- SEH-protect all code that writes to PreviousState as it cannot be captured.
- Add a missing ObDereferenceObject and SeReleaseLuidAndAttributesArray.
svn path=/trunk/; revision=48721
Michael Martin [Tue, 7 Sep 2010 11:44:03 +0000 (11:44 +0000)]
[usb/usbhub]
- Add function for dumping the Device and Configuration Descriptors.
- Implement WaitForUsbDeviceArrivalNotification, used to send a URB transaction to the Status Change Endpoint of the RootHubs pdo. The RootHubs pdo will queue this request until a new usb device connects.
- Call above function at the end of UsbhubFdoQueryBusRelations, which will be called by the pnp manager after the hub driver creates a new child device.
- Change the URB to be allocated from the pool at IRP_MN_START_DEVICE.
- Call QueryRootHub with the RootHub Pdo and not the hub drivers DeviceObject.
- Implement selecting a configuration for the RootHub.
svn path=/trunk/; revision=48719
Michael Martin [Tue, 7 Sep 2010 09:40:53 +0000 (09:40 +0000)]
[USETUP]
- Translation updates by Pierre Schweitzer.
svn path=/trunk/; revision=48718
Eric Kohl [Tue, 7 Sep 2010 09:32:30 +0000 (09:32 +0000)]
Improvements to NtAdjustPrivilegesToken part 3:
- Simplify the privilege modification code.
svn path=/trunk/; revision=48717
Sir Richard [Tue, 7 Sep 2010 07:50:51 +0000 (07:50 +0000)]
[GDI32]: Don't destroy the heap when calling GetSystemPaletteEntries. Note to whoever wrote "//make this work": (&array[x]) is defintely not equal to (&array + x). This is why we don't use pointers-to-arrays, among other reasons.
[GDI32]: Reformat GetSystemPaletteEntries away from grotesque 5-space identation (who does that?).
[GDI32]: Optimize GetSystemPaletteEntries by not zeroing over fields that get overwritten anyway.
[GDI32]: Simplify loop control, remove not-needed local variable in GetSystemPaletteEntries.
svn path=/trunk/; revision=48716
Sir Richard [Tue, 7 Sep 2010 05:22:13 +0000 (05:22 +0000)]
[PSDK]: Get rid of unused variable.
svn path=/trunk/; revision=48715
Cameron Gutman [Tue, 7 Sep 2010 01:31:24 +0000 (01:31 +0000)]
[FREELOADER]
- Don't zero the target of an uninitialized pointer
- Thanks to arty for finding the issue
svn path=/trunk/; revision=48713
Sir Richard [Mon, 6 Sep 2010 23:55:53 +0000 (23:55 +0000)]
[WIN32K]: Fix large amount of set-but-unused variables. Most of these seemed to be old/unfinished code, however in IntGdiPaintRgn an actual bug seems to have been found.
[WIN32K]: Make IntGdiPaintRgn return the status of the operation, not always TRUE.
svn path=/trunk/; revision=48712
Timo Kreuzer [Mon, 6 Sep 2010 17:02:47 +0000 (17:02 +0000)]
[USETUP]
- When creating fresh partitions, set the HiddenSectors mamber. Fixes fat32 installation.
svn path=/trunk/; revision=48711
Eric Kohl [Mon, 6 Sep 2010 15:26:12 +0000 (15:26 +0000)]
Improvements to NtAdjustPrivilegesToken part 2:
- Check for invalid parameter combinations.
- Count privileges that will be changed before changing them.
- Return required buffer size.
- Fail if the provided buffer is too small.
See issue #5497 for more details.
svn path=/trunk/; revision=48710
Eric Kohl [Mon, 6 Sep 2010 10:24:50 +0000 (10:24 +0000)]
Translated new boot loader options and fixed a typo.
svn path=/trunk/; revision=48709
Eric Kohl [Mon, 6 Sep 2010 09:53:36 +0000 (09:53 +0000)]
fdc.inf: Fix a typo in the class guid.
hdc.inf: Add missing manufacturer string.
svn path=/trunk/; revision=48708
Eric Kohl [Mon, 6 Sep 2010 09:51:46 +0000 (09:51 +0000)]
NtAdjustPrivilegesToken: Probe and capture parameters before use.
See issue #5497 for more details.
svn path=/trunk/; revision=48707
Timo Kreuzer [Mon, 6 Sep 2010 01:46:06 +0000 (01:46 +0000)]
[USETUP]
The VBR (volume boot sector) contains a structure called BPB (bios parameter block) that describes the disk and the partition. The HiddenSectors member contains the number of the first sector of the partition. This is used by the VBR code to load the secondary sector containing additional boot code that is located at secor 14 relative to the partition start. Previously we were copying the BPB (plus additionally the OemName, which makes no sense) from the old VBR. Now Linux is a bit lame and doesn't put the correct value into the HiddenSectors field. Instead it sets it to the number of sectors per track which seems to be the default value. When now the linux partition manager decides to do a non standard partitioning, aligning the partition to 0x800, then the VBR fails to load it's 2nd sector. Fix this by correcting the value in the BPB with the value from the partition info.
See issue #2733 for more details.
svn path=/trunk/; revision=48706
Michael Martin [Sun, 5 Sep 2010 19:00:37 +0000 (19:00 +0000)]
[usb/usbhub]
- Start rewrite of usbhub driver using the old and dead usbhub driver in trunk.
- Implement QueryRootHub for sending USB request to miniport driver.
- Implement new IRP_MN_START_DEVICE.
Get the roothubs PDO and FDO and forward the start device down to start the PDO.
Get USBDI and HUB interfaces. Set all ports as returned by DCI GetExtendedHubInformation to powered and reset.
- Temporary add some usb specific defines until header is fixed.
- Fix Formatting.
svn path=/trunk/; revision=48705
Michael Martin [Sun, 5 Sep 2010 18:43:17 +0000 (18:43 +0000)]
[usb/usbehci]
- Fix flags settings for PortStatus and PortChange so that the correct flags are set when hub driver sets/requests them.
- Use FastMutex to protect access to async queue and frame list.
- For USB CONFIG DESC, Check the output buffer size before attempting to write all configuration descriptors.
- Fix a bug that caused bmRequestType to be incorret value when requesting configuration and string descriptors.
- Modify some debugging to make it easier to see debug messages from usbhub driver.
svn path=/trunk/; revision=48704
Cameron Gutman [Sun, 5 Sep 2010 17:09:18 +0000 (17:09 +0000)]
[USETUP]
- Add the option to write only the VBR so FreeLoader can easily be chain loaded by GRUB or another boot loader
- Dedicated to James Tabor :)
svn path=/trunk/; revision=48703
Timo Kreuzer [Sun, 5 Sep 2010 16:03:08 +0000 (16:03 +0000)]
Update the GAS compatible fathelp.S file to reflect the latest changes to the original file (freeldr PE conversion). This version is tested and works.
svn path=/trunk/; revision=48701
Cameron Gutman [Sat, 4 Sep 2010 20:56:19 +0000 (20:56 +0000)]
[USETUP]
- Remove code that was corrupting disk data and causing setup to fail in rare cases
- Write the MBR in all cases (Windows setup behavior too)
- We can overwrite GRUB and LILO now but we still can't boot because we have trouble reading the partition table if it was made in Linux
svn path=/trunk/; revision=48700
Sir Richard [Sat, 4 Sep 2010 08:17:17 +0000 (08:17 +0000)]
[NTOS]: Remove useless variables in kernel code that were set, but never actually used (dead code, tests, copy/pasters). If a variable was set but not used because of missing/#if'ed out code, a note was added instead.
[NTOS]: In the process, fix bugs in the Event dispatcher code that used Win32 EVENT_TYPE instead of NT KOBJECTS enumeration.
[NTOS]: Fix a bug in ObpInsertHandleCount, where the object access check was being done with the previous mode, instead of honoring the probe mode, which is defined by OBJ_FORCE_ACCESS_CHECK.
[NTOS]: Fix a bug in a section function which was always returning STATUS_SUCCESS, now it returns the result of the previous Status = function assignment. If this isn't desired, then don't check for the Status anymore.
[NTOS]: Note that MDL code does not support SkipBytes argument. If it is used, MDL could be invalid.
[NTOS]: Add checks for VerifierAllocation and set it when needed (WIP).
[NTOS]: Clarify what _WORKING_LINKER_ is, and the legal risks in continuing to use a linker that builds non-Microsoft drivers when used with headers whose EULA specify that they can only be used for Microsoft drivers.
svn path=/trunk/; revision=48692
Cameron Gutman [Thu, 2 Sep 2010 04:18:17 +0000 (04:18 +0000)]
[OSKITTCP]
- Check for a shutdown connection that we missed a few times
- Remove some junk and stop playing with flags behind oskit's back
- Fix an invalid parameter check
- Enable a check to ensure that accept doesn't get called for a socket that isn't listening
- Use the queue manipulation function instead of manually changing the queue
- Signal that we accepted/connected a socket
[IP]
- Set the network mask and destination address in TCPGetInterfaceData
svn path=/trunk/; revision=48686
Aleksey Bragin [Wed, 1 Sep 2010 13:40:35 +0000 (13:40 +0000)]
[PSDK]
- Add BS_TYPEMASK definition.
svn path=/trunk/; revision=48678
Amine Khaldi [Mon, 30 Aug 2010 13:48:40 +0000 (13:48 +0000)]
[CRT]
- Fix __MINGW_MSC_PREREQ logic.
svn path=/trunk/; revision=48657
Michael Martin [Mon, 30 Aug 2010 11:51:17 +0000 (11:51 +0000)]
Patch by Pierre Schweitzer.
[CDFS]
- Several fixes for directory information query.
- Fixed a null access memory under certain circumstances.
- Added support for media ejection.
[FASTFAT]
- Fixed calls to CcMapData(), CcPinRead().
- Fixed an endless loop in FCB management under certain circumstances.
[NTOSKRNL]
- Fixed wrong prototype for IopParseDevice().
svn path=/trunk/; revision=48654
Sir Richard [Sun, 29 Aug 2010 19:32:25 +0000 (19:32 +0000)]
[NTOS]: Add an extra layer of protection for freed nonpaged pool: write a 4-byte signature on freed blocks, and assert its valid on checked builds. Use a slightly less egocentric ASCII value than on Windows (name of the developer who wrote the first memory manager).
svn path=/trunk/; revision=48651
Sir Richard [Sun, 29 Aug 2010 19:27:58 +0000 (19:27 +0000)]
[NTOS]: Missed a bunch of codepaths, protected pool "should" work now.
svn path=/trunk/; revision=48650
Sir Richard [Sun, 29 Aug 2010 19:13:08 +0000 (19:13 +0000)]
[NTOS]: Add DRIVER_CAUGHT_MODIFYING_FREED_POOL bugcheck code.
[NTOS]: Add support for protected freed nonpaged pool. This is controlled through MmProtectFreedNonPagedPool, which is initialized based on a registry value (see cmdata.c). This is not "Special Pool", but a useful debugging feature Windows implements that we now have too, since I noticed a lot of mj's work was with freed pool access.
NB. It's 3AM and I have not tested this, it should be off in trunk by default, you'll need to try turning it on and testing it. Hope it helps.
--This line, and those low, will be ignored--
M ntoskrnl/mm/ARM3/pagfault.c
M ntoskrnl/mm/ARM3/pool.c
M include/reactos/mc/bugcodes.mc
svn path=/trunk/; revision=48649
Cameron Gutman [Sun, 29 Aug 2010 18:40:33 +0000 (18:40 +0000)]
[ACPI]
- Read and report ACPI_RESOURCE_TYPE_FIXED_MEMORY32
svn path=/trunk/; revision=48648
Michael Martin [Sun, 29 Aug 2010 17:46:18 +0000 (17:46 +0000)]
[cdfs]
- Working with Pierre Schweitzer for yet another NonPaged Pool corruption fix. When copying VolumeLabel the VolumeLabelLength is in Unicode, so theres no need to mulitply it by size of WCHAR.
svn path=/trunk/; revision=48646
Timo Kreuzer [Sun, 29 Aug 2010 08:35:54 +0000 (08:35 +0000)]
[NTOSKRNL]
Modified version of r48640:
- update the NodeHint to the root node when deleting a node
- remove this code from MmCleanProcessAddressSpace
svn path=/trunk/; revision=48642
Michael Martin [Sun, 29 Aug 2010 07:18:47 +0000 (07:18 +0000)]
[ntoskrnl]
- Revert 48640, as it was incorrect.
svn path=/trunk/; revision=48641
Michael Martin [Sun, 29 Aug 2010 07:00:52 +0000 (07:00 +0000)]
[ntoskrnl]
- When a node is removed, check the NodeHint of the table to see if it matches the one being removed. If so update the NodeHint to the PreviousNode. FIxes VAD corruption messages.
svn path=/trunk/; revision=48640
Cameron Gutman [Sun, 29 Aug 2010 03:51:21 +0000 (03:51 +0000)]
- Disable ACPI again
svn path=/trunk/; revision=48639
Cameron Gutman [Sun, 29 Aug 2010 03:48:59 +0000 (03:48 +0000)]
[NTOSKRNL]
- Fix a regression in ACPI function from r48581
- Enable ACPI for testing purposes (will be disabled next commit)
svn path=/trunk/; revision=48638
Cameron Gutman [Sun, 29 Aug 2010 02:29:10 +0000 (02:29 +0000)]
[TCPIP]
- Don't allocate pool if there is nothing in the route table
- Fixes bug 5493
svn path=/trunk/; revision=48637
Michael Martin [Sat, 28 Aug 2010 23:55:27 +0000 (23:55 +0000)]
[win32k]
- Mouse messages can be sent before the desktop is initialized. Check for this and return false if its not. FIxes assert when moving mouse before desktop is up.
svn path=/trunk/; revision=48636
Michael Martin [Sat, 28 Aug 2010 23:23:43 +0000 (23:23 +0000)]
[input/i8042prt]
- Fix a check when queuing the mouse packet. Check that the buffer size (MouseInBuffer) is not greater or equal to MouseDataQueueSize. Fixes a NonPagedPool corruption that occurs when the mouse is moved before the desktop window is up and running.
svn path=/trunk/; revision=48635
Michael Martin [Sat, 28 Aug 2010 00:26:02 +0000 (00:26 +0000)]
[ntoskrnl/ps]
- When deleting a Process remove the Process from the MmProcessList. Fixes random NonPaged Pool corruptions. Thanks aicom for assistance.
svn path=/trunk/; revision=48632
Michael Martin [Fri, 27 Aug 2010 22:18:10 +0000 (22:18 +0000)]
[ntoskrnl/ps]
- Acquire and Release RundownProtection on the Parent Pocess not the newly created Pcess when setting the SectionObject.
svn path=/trunk/; revision=48631
Timo Kreuzer [Fri, 27 Aug 2010 10:57:54 +0000 (10:57 +0000)]
[WIN32K]
- Rework EngSetPointerShape, to first allocate the neccessary surfaces, before deleting the old ones. Also check in IntShowMousePointer if a saving surface is present. This way a failure to allocate a surface will not result in a crash, but keep the old mouse pointer.
See issue #5402 for more details.
svn path=/trunk/; revision=48630
Timo Kreuzer [Fri, 27 Aug 2010 10:20:25 +0000 (10:20 +0000)]
[USER32]
- Revert r47238 as requested by Giannis: "this commit breaks any program that wants to subclass mdi client windows"
svn path=/trunk/; revision=48629
Cameron Gutman [Fri, 27 Aug 2010 04:46:04 +0000 (04:46 +0000)]
[OSKITTCP]
- Only tell the caller how much we sent/received if it completed successfully
- Set SO_DONTROUTE on accepted sockets too
- Disable the core routing code
- Make our MSS calculation much better by sharing the existing code
svn path=/trunk/; revision=48628
Colin Finck [Thu, 26 Aug 2010 18:33:46 +0000 (18:33 +0000)]
Fix building on newer Linux systems (particularly Fedora 13)
Thanks to James, Sylvain and ErVito for testing!
See http://reactos.org/pipermail/ros-dev/2010-August/013338.html for more details
svn path=/trunk/; revision=48627
Timo Kreuzer [Thu, 26 Aug 2010 15:25:33 +0000 (15:25 +0000)]
[NTOSKRNL]
- Fix to PpSetCustomTargetEvent(), not to make caller wait forever in case it provided an event it waits for
- Patch by Pierre Schweitzer
svn path=/trunk/; revision=48626
Timo Kreuzer [Thu, 26 Aug 2010 02:48:03 +0000 (02:48 +0000)]
Fix build
svn path=/trunk/; revision=48625
Cameron Gutman [Thu, 26 Aug 2010 02:29:38 +0000 (02:29 +0000)]
[OSKITTCP]
- Prevent multiple wakeups for the same event which caused nasty problems for the SEL_FIN event because we dereferenced our connection context 3 times which not only caused the connection endpoint to be freed while holding its spin lock but made the reference count negative
[TCPIP]
- Disassociate the address file from the connection endpoint before dereferencing/closing it to avoid a double dereference of the address file (not as harmful in this case as in the connection endpoint case)
[IP]
- Dereference the connection endpoint again if it was associated with an address file as the connection endpoint to fix a reference leak
svn path=/trunk/; revision=48624
Timo Kreuzer [Thu, 26 Aug 2010 02:29:19 +0000 (02:29 +0000)]
[NTDLL_APITEST]
- Add a test for RtlInitializeBitMap.
svn path=/trunk/; revision=48623
Timo Kreuzer [Wed, 25 Aug 2010 10:15:34 +0000 (10:15 +0000)]
delete old Zwcontinue test
svn path=/trunk/; revision=48622
Timo Kreuzer [Wed, 25 Aug 2010 10:15:01 +0000 (10:15 +0000)]
[ROSTESTS]
- Add wine style ntdll_apitest and move test for ZwContinue there
svn path=/trunk/; revision=48621
Timo Kreuzer [Wed, 25 Aug 2010 08:50:10 +0000 (08:50 +0000)]
Add missing files
svn path=/trunk/; revision=48620
Timo Kreuzer [Wed, 25 Aug 2010 08:48:55 +0000 (08:48 +0000)]
[APITESTS]
Convert dciman32api, user32api and wa2_32 into wine style tests
svn path=/trunk/; revision=48619
Timo Kreuzer [Wed, 25 Aug 2010 08:29:52 +0000 (08:29 +0000)]
[FASTFAT]
- "Fix for a stupid mistake"
- patch by Pierre Schweitzer
svn path=/trunk/; revision=48618
Timo Kreuzer [Tue, 24 Aug 2010 13:54:10 +0000 (13:54 +0000)]
Convert gdi32api into wine style test
svn path=/trunk/; revision=48617
Timo Kreuzer [Tue, 24 Aug 2010 05:27:39 +0000 (05:27 +0000)]
Fix copy paste error in file header
svn path=/trunk/; revision=48616
Timo Kreuzer [Tue, 24 Aug 2010 05:20:16 +0000 (05:20 +0000)]
[REGTESTS]
Add bugs_regtest. This can be used to create testcases / regression tests for already fixed bugs. I added a first test for bug 3481
svn path=/trunk/; revision=48615
Timo Kreuzer [Tue, 24 Aug 2010 05:19:31 +0000 (05:19 +0000)]
[WINGDI.H]
Add missing GetCharWidthI, GetTextExtentExPointI, GetTextExtentPointI
svn path=/trunk/; revision=48614
Cameron Gutman [Mon, 23 Aug 2010 21:11:01 +0000 (21:11 +0000)]
- Revert the change from REG_SZ to REG_MULTI_SZ because it turns out that Windows does it this same way (research fail?)
svn path=/trunk/; revision=48611
Timo Kreuzer [Mon, 23 Aug 2010 03:00:03 +0000 (03:00 +0000)]
[NTOSKRNL]
- Rewrite MiFindEmptyAddressRangeDownTree. The old implementation's "most awesome loop" duplicated both the initialization and the interation steps. It was also overcomplicated. The new implementation additionally returns the parent for the following table insertion, so this doesnt need to be done in an extra search. The return value is changed from NTSTATUS to TABLE_SEARCH_RESULT
- Modify MiInsertNode to accept a parent and TABLE_SEARCH_RESULT instead of searching for a free location.
- Modify MiCreatePebOrTeb to make use of the new features
- Handle failed allocation of the PEB/TEB
- Fixes a failed assertion that Olaf got
- I tested this code quite some time and no problems were found
svn path=/trunk/; revision=48606
Timo Kreuzer [Mon, 23 Aug 2010 01:41:56 +0000 (01:41 +0000)]
[WIN32K]
Seperate DC_vSetLayout from NtGdiSetLayout and save the old value before setting the new one.
svn path=/trunk/; revision=48605
Timo Kreuzer [Mon, 23 Aug 2010 01:39:28 +0000 (01:39 +0000)]
[WIN32K]
Move the allocation of the vis region of the DC to a later position, so that all mandatory fields are initialized before we try to delete the DC in failure case. Fixes yet another possible crash.
svn path=/trunk/; revision=48604
Timo Kreuzer [Mon, 23 Aug 2010 01:18:09 +0000 (01:18 +0000)]
[NDK]
Add LdrProcessRelocationBlockLongLong. Fixes build, sorry.
svn path=/trunk/; revision=48603
Cameron Gutman [Mon, 23 Aug 2010 01:17:41 +0000 (01:17 +0000)]
[TCPIP]
- Read the IP information from the interface key inside the Tcpip service key (confirmed on XP)
- Fix a logic error in my code (no idea how I missed it)
- Restores static IP functionality (still waiting on janderwald to fix netcfgx's DNS value writing)
svn path=/trunk/; revision=48602
Timo Kreuzer [Mon, 23 Aug 2010 01:16:42 +0000 (01:16 +0000)]
[NTDLL]
- Call LdrProcessRelocationBlockLongLong from LdrProcessRelocationBlock instead of duplicating the code
svn path=/trunk/; revision=48601
Amine Khaldi [Mon, 23 Aug 2010 00:02:06 +0000 (00:02 +0000)]
[FAULTREP]
- Fix a typo.
svn path=/trunk/; revision=48600
Timo Kreuzer [Sun, 22 Aug 2010 23:38:02 +0000 (23:38 +0000)]
[WIN32K] / [GDI32]
- GetTextExtentExPointI and GetTextExtentPointI take an array of glyph indices, not characters. Pass a flag GTEF_INDICES (This is a reactos specific definition and not exactly like on Windows XP, but the real names/values are undocumented and this is the easiest way.) to NtGdiGetTextExtent/NtGdiGetTextExtentExW and handle this flag in TextIntGetTextExtentPoint to account for this.
Fixes bug 3481
svn path=/trunk/; revision=48597
Timo Kreuzer [Sun, 22 Aug 2010 22:44:36 +0000 (22:44 +0000)]
[WIN32K]
- When doing a cleanup for a DC, check, if the default brushes are set, before dereferencing them. Fixes a possible kernel mode crash.
- Remove some obsolete casts
svn path=/trunk/; revision=48595
Cameron Gutman [Sun, 22 Aug 2010 22:22:27 +0000 (22:22 +0000)]
[DHCPCSVC]
- Write the DNS servers in a REG_MULTI_SZ value
[IPHLPAPI]
- Rewrite the registry reading code
- Use HeapFree to free memory from the allocated from heap
svn path=/trunk/; revision=48593
Amine Khaldi [Sun, 22 Aug 2010 13:25:10 +0000 (13:25 +0000)]
[PSDK]
- Improve _MSC_VER related conditions.
- Comment on #endif (for readability).
- DECLSPEC_ALIGN : moar underscores !
- Apply a consistent formatting.
svn path=/trunk/; revision=48590
Cameron Gutman [Sat, 21 Aug 2010 22:08:00 +0000 (22:08 +0000)]
[NTOSKRNL]
- Fix a typo that broke handling of DevicePropertyEnumeratorName inside IoGetDeviceProperty
svn path=/trunk/; revision=48583
Timo Kreuzer [Sat, 21 Aug 2010 22:00:50 +0000 (22:00 +0000)]
[WIN32K]
Use the object type index, not the shifted full object type to decide what to do with an object in NtGdiDeleteObjectApp. Fixes leaking derived types such as pens.
svn path=/trunk/; revision=48582
Cameron Gutman [Sat, 21 Aug 2010 21:39:53 +0000 (21:39 +0000)]
[NTOSKRNL]
- Don't overwrite the ACPI hardware key on every boot
svn path=/trunk/; revision=48581
Cameron Gutman [Sat, 21 Aug 2010 21:25:07 +0000 (21:25 +0000)]
[NTOSKRNL]
- Append the DLL name and NULL terminate the string more nicely
svn path=/trunk/; revision=48580
Timo Kreuzer [Sat, 21 Aug 2010 19:55:09 +0000 (19:55 +0000)]
[WIN32K]
- Allocate the DCs prgnVis in DC_AllocDC, instead of "on demand" in GdiSelectVisRgn and properly handle failure case. This fixes a possible crash, when running out of gdi handles.
svn path=/trunk/; revision=48579
Timo Kreuzer [Fri, 20 Aug 2010 19:24:48 +0000 (19:24 +0000)]
[WIN32K]
- co_IntTranslateMouseMessage: properly initialize *HitTest and only send WM_NCHITTEST when the message is going to be removed
- co_IntPeekMessage: Prevent possible use of uninitialized HitTest by ProcessMouseMessage()
- Patch by Jan Roeloffzen [jroeloffzen at hotmail dot com]
- Fixes bug 2139
svn path=/trunk/; revision=48576
Amine Khaldi [Fri, 20 Aug 2010 16:55:33 +0000 (16:55 +0000)]
[PSDK]
- Add missing DISPLAY_BRIGHTNESS and some related definitions.
svn path=/trunk/; revision=48575
Cameron Gutman [Fri, 20 Aug 2010 04:45:25 +0000 (04:45 +0000)]
[NTOSKRNL]
- The trailing NULL is NOT included in the string length
- IopNotifyPlugPlayNotification needs a pointer to an actual GUID not a UNICODE_STRING
- The Power Manager can now see ACPI power devices again
- ROS will now do a graceful shutdown and power off if the power button is pressed and ACPI is enabled
svn path=/trunk/; revision=48574
Cameron Gutman [Fri, 20 Aug 2010 03:08:50 +0000 (03:08 +0000)]
[ACPI]
- Do all of the work inside the DPC so we don't have IRQL issues when entering the memory manager
- This is a slight hack but we can be assured that data won't be over 24 bits unless somebody wants to push the power/sleep button over 16 million times
svn path=/trunk/; revision=48573
Cameron Gutman [Fri, 20 Aug 2010 02:27:05 +0000 (02:27 +0000)]
[NTOSKRNL]
- Shutdown the system if we receive a SYS_BUTTON_POWER event
- Register for GUID_DEVICE_LID arrival events so we can receive lid events
svn path=/trunk/; revision=48572
Cameron Gutman [Thu, 19 Aug 2010 23:26:44 +0000 (23:26 +0000)]
[NTOSKRNL]
- Add a special case to IopInitializeDevice for raw devices
- Call IopInitializeDevice to set up our device node and ready it to start
- Fixes assertions hit by ACPI and PCIX
svn path=/trunk/; revision=48570
Cameron Gutman [Thu, 19 Aug 2010 22:15:58 +0000 (22:15 +0000)]
[OSKITTCP]
- Disable routing because oskit needs to let our code do that
- Comment out the ACK hack and restore the default BSD behavior
svn path=/trunk/; revision=48569
Michael Martin [Thu, 19 Aug 2010 10:52:36 +0000 (10:52 +0000)]
[Win32k]
- For SetTimer nIDEvent can be 0 in which case return 1. Zero still needs to be used for nIDEvent when killing the timer. Fixes bug 5553.
- Modify windowless timers to use IDEvent values decrementing from the max number of windowless timers vice incrementing from 1. Done to match windows behavior.
svn path=/trunk/; revision=48568
Timo Kreuzer [Thu, 19 Aug 2010 10:03:03 +0000 (10:03 +0000)]
[NTOSKRNL]
- Add missing parentheses. Fixes "cont"
svn path=/trunk/; revision=48567
Timo Kreuzer [Thu, 19 Aug 2010 09:03:36 +0000 (09:03 +0000)]
[NTOSKRNL]
Fix handling of next instruction in kdbg.
Patch by Daniel Zimmermann, modified by Aleksey Bragin
See issue #4457 for more details.
svn path=/trunk/; revision=48566
Timo Kreuzer [Thu, 19 Aug 2010 08:50:23 +0000 (08:50 +0000)]
[NTOSKRNL]
- Implement support for /BURNMEMORY option.
- Don't stop boot on bad memory type
Patch by Jay Smith, modified by Aleksey, even more modified by me.
See issue #4957 for more details.
svn path=/trunk/; revision=48565
Cameron Gutman [Thu, 19 Aug 2010 06:25:20 +0000 (06:25 +0000)]
[NETSTAT]
- Allocate memory for the TCP table properly
- Only netstat -a should show UDP connections
- Patch by Jan Roeloffzen [jroeloffzen at hotmail dot com]
svn path=/trunk/; revision=48564
Cameron Gutman [Thu, 19 Aug 2010 06:05:35 +0000 (06:05 +0000)]
[IPHLPAPI]
- Copy our TCP table into the caller's buffer if we actually get one (not yet!)
- Return ERROR_NO_DATA if we fail to get anything from TCP/IP
- Fixes bug #4185
svn path=/trunk/; revision=48563
Timo Kreuzer [Thu, 19 Aug 2010 05:10:16 +0000 (05:10 +0000)]
[NTOSKRNL]
- Initialize the Parent member of the new Vad to NULL. This also initializes the Balance to 0 aka RtlBalancedAvlTree
Should fix the failed assertion that randomly occurs.
svn path=/trunk/; revision=48562
Cameron Gutman [Thu, 19 Aug 2010 02:41:54 +0000 (02:41 +0000)]
[IP]
- Fix a major bug in socket closure. Prior to this, a socket with pending IRPs that could not be satisfied when the socket was closed would be destroyed without completing the pending requests. Now, we check all of our IRP queues if we get a SEL_FIN signal and kill all the requests that cannot be satisfied immediately.
- Maybe it's just me but Firefox 2 seems much more responsive after this fix (like actually usable!)
svn path=/trunk/; revision=48561
Timo Kreuzer [Wed, 18 Aug 2010 23:21:15 +0000 (23:21 +0000)]
[FASTFAT]
Make our FAT driver PNP aware.
On PNP requests it should handle, it will return STATUS_NOT_IMPLEMENTED.
On the others, it will pass them to lower driver.
This is the first step outside the kernel into getting IoGetRelatedTargetDevice (and so notifications) working.
It doesn't work at the moment, as class2 doesn't handle PNP.
[NTOSKRNL]
Some fixes to IRP cancelation process:
- Renamed IopRemoveThreadIrp() to IopDisassociateThreadIrp() to match Windows 2k3
- Made dead IRP global, to make its debug easier.
- IopDisassociateThreadIrp(), Handle dead IRP at dispatch level, using IoCompletionLock.
- IopDisassociateThreadIrp(), Use the proper error code to write the entry to logs.
- IoCancelIrp(), removed non needed ASSERT, which is even not present on Windows, removed corresponding var as well.
- IoCancelIrp(), fixed parameters to KeBugCheckEx() call.
- IoCancelThreadIo() is pageable.
- IoCancelThreadIo() under Windows isn't using given thread, but using current. Do the same here.
All that stuff doesn't fix bug #5550, it comes from outside.
Patch by Pierre Schweitzer, modified by me to make it compile. If it breaks anything, don't blame me!
svn path=/trunk/; revision=48560
Timo Kreuzer [Tue, 17 Aug 2010 16:04:46 +0000 (16:04 +0000)]
[NTOSKRNL]
- Simplified IopGetRelatedTargetDevice implementation
- Added notification in case of success in NtSetVolumeInformationFile()
Patch by Pierre Schweitzer
svn path=/trunk/; revision=48559
Timo Kreuzer [Mon, 16 Aug 2010 20:18:25 +0000 (20:18 +0000)]
[NTOSKRNL]
- Fixed IoGetRequestorProcess, IoGetRequestorProcessId, IoGetRequestorSessionId
- Pass user buffer in NtNotifyChangeDirectoryFile
- Fixed magic value in IoGetPagingIoPriority
Patch by Pierre Schweitzer
svn path=/trunk/; revision=48557
Timo Kreuzer [Mon, 16 Aug 2010 01:57:09 +0000 (01:57 +0000)]
[NTDLL]
LdrPerformRelocations: Delta is a LONG_PTR rather than ULONG_PTR
See issue #5577 for more details.
svn path=/trunk/; revision=48556
Timo Kreuzer [Mon, 16 Aug 2010 01:29:13 +0000 (01:29 +0000)]
[WIN32K]
- Remove IntEngExtEscape stub. This function is completely useless. If the driver doesn't provide a DrvEscape, the function should simply fail and must return 0, not -1.
- If a NULL surface is passed, pass on NULL pso to the driver function
See issue #4563 for more details.
svn path=/trunk/; revision=48555
Timo Kreuzer [Mon, 16 Aug 2010 00:06:55 +0000 (00:06 +0000)]
[user32_winetest]
Skip 2 tests that hang on reactos. Patch by Giannis Adamopoulos
svn path=/trunk/; revision=48554
Aleksey Bragin [Sun, 15 Aug 2010 08:48:03 +0000 (08:48 +0000)]
[NTOSKRNL]
- Revert 48546. The code was correct, and there is more of same code in other places which firstly cancels the IRP and then moves to the next entry. The actual bug is somewhere else.
See issue #5550 for more details.
svn path=/trunk/; revision=48551
evb [Sat, 14 Aug 2010 18:06:19 +0000 (18:06 +0000)]
- IRP_MN_QUERY_RESOURCE_REQUIREMENTS half support now, PciQueryRequirements, PciAllocateIoRequrementsList, full implement, but PciBuildRequirementsList return 0 always for now
- Debug helpers: PciDebugPrintIoResReqList, PciDebugPrintIoResource, PciDebugCmResourceTypeToText
Now hit assert Assertion '(DeviceNode->Flags & DNF_ADDED)' failed at ntoskrnl/io/pnpmgr/pnpmgr.c line 201, too night to debug, maybe tomorow
svn path=/trunk/; revision=48550
evb [Sat, 14 Aug 2010 17:33:10 +0000 (17:33 +0000)]
- IRP_MN_QUERY_RESOURCES support for PDO (PciQueryResources, PciAllocateCmResourceList), now remain IRP_MN_QUERY_RESOURCE_REQUIREMENTS to last device stack interogration from PNPMGR
svn path=/trunk/; revision=48549