Hermès Bélusca-Maïto [Sun, 7 Jan 2018 00:35:48 +0000 (01:35 +0100)]
[REACTOS] Diverse UI improvements.
- Improve UI usage and wizard transitions (Work In Progress).
- Add interfacing code that display installation status.
- When the user attempts to cancel the installation during file copying,
pause the file copying, and restart it if the user changes it mind and
wants to continue the installation. Otherwise file copying is properly
halted.
Hermès Bélusca-Maïto [Mon, 15 Jan 2018 17:09:53 +0000 (18:09 +0100)]
[BOOTDATA][SETUPLIB][REACTOS] INF support fixes.
- BOOTDATA: Use standard INF signature string, so that they can be
opened successfully using ReactOS' or Windows' setupapi.dll with
the INF_STYLE_WIN4 style.
- SETUPLIB: Use the correct INF_STYLE_* INF styles in SpInfOpenInfFile() calls.
- REACTOS : Switch thread locale to user-specified LocaleId when calling
SetupOpenInfFileW(), so that the correct localized strings are used.
Hermès Bélusca-Maïto [Sun, 7 Jan 2018 00:35:48 +0000 (01:35 +0100)]
[SETUPLIB] Fixes and improvements for the file copying code.
- In PrepareCopyInfFile(), explicitly use AddSectionToCopyQueueCab()
to retrieve the files from the CAB INF.
Otherwise if one continued to use and rely on AddSectionToCopyQueue()
to do this job instead, bad things could happen like, re-enumerating
twice or more (and adding them to the file queue) the same files.
This is because in the new code AddSectionToCopyQueue() can be called
many times to deal with different SIF file sections. The old code then
called AddSectionToCopyQueueCab() in turn, but on the same list...
Now the steps performed are clear, and everything works as intended.
- Simplify the code that computes the full source and destination paths
for the files to be copied and directories to be created, using helper
functions.
- Compute the source file and target location from the TXTSETUP.SIF
entries in a NT-compatible manner.
Hermès Bélusca-Maïto [Sun, 7 Jan 2018 00:47:52 +0000 (01:47 +0100)]
[BOOTDATA] Use a Win2k3-compatible TXTSETUP.SIF layout for the specification of the files list.
Also add detailed documentation about the meaning of each field, obtained from:
- my own tests;
- http://www.msfn.org/board/topic/125480-txtsetupsif-syntax/
- http://www.msfn.org/board/topic/127677-txtsetupsif-layoutinf-reference/
In addition, add a spreadsheet that helps generating the files list.
Note that the files source directory is "\reactos", until we use
per-architecture directories in the installation medium.
Hermès Bélusca-Maïto [Sun, 7 Jan 2018 00:35:48 +0000 (01:35 +0100)]
[SETUPLIB][USETUP] Move all the code that performs file copying into the SETUPLIB.
Hermès Bélusca-Maïto [Sun, 28 Oct 2018 21:51:33 +0000 (22:51 +0100)]
[SETUPLIB][USETUP] Add support for setup error handling.
Katayama Hirofumi MZ [Mon, 5 Nov 2018 07:24:23 +0000 (16:24 +0900)]
[WIN32SS][FONT] Fix regression of #1004 (#1012)
Signed-off-by: Doug Lyons <douglyons@douglyons.com>
CORE-15333
Eric Kohl [Sun, 4 Nov 2018 23:22:30 +0000 (00:22 +0100)]
[SCHEDSVC] Start jobs on timeout
- Start jobs on timeout
- Add job flags to the idl file
Katayama Hirofumi MZ [Sun, 4 Nov 2018 21:03:53 +0000 (06:03 +0900)]
[WIN32SS][FONT] Fix ntmCellHeight value to usWinAscent + usWinDescent (#1010)
CORE-15331
Eric Kohl [Sun, 4 Nov 2018 17:39:13 +0000 (18:39 +0100)]
[MC] Add some messages to netmsg.dll
Eric Kohl [Sun, 4 Nov 2018 14:27:57 +0000 (15:27 +0100)]
[LSASRV] Return STATUS_DIRECTORY_SERVICE_REQUIRED for all trusted domain functions that use a policy handle and a domain name or domain SID when the machine is not a domain controller.
Eric Kohl [Sun, 4 Nov 2018 11:50:21 +0000 (12:50 +0100)]
[LSASRV] Coding style fixes
Serge Gautherie [Sat, 3 Nov 2018 13:57:24 +0000 (14:57 +0100)]
[KMTESTS:MM] Fix 'PAGE_NOACCESS' copypasta, in an error string
ROSTESTS-110
Jérôme Gardou [Fri, 2 Nov 2018 17:26:52 +0000 (18:26 +0100)]
[KMTESTS/MM] Enable again accessing forbidden memory.
Also adda test case for the PAGE_GUARD case
ROSTESTS-110
Jérôme Gardou [Fri, 2 Nov 2018 17:23:16 +0000 (18:23 +0100)]
[NTOS/MM] Properly handle page faults in regions marked with
PAGE_NOACCESS or PAGE_GUARD
ROSTESTS-110
Jérôme Gardou [Fri, 2 Nov 2018 17:20:13 +0000 (18:20 +0100)]
[NTOS/MM] Move up MmAlterViewAttributes for later use in MmNotPresentFaultSectionView
No code change
Katayama Hirofumi MZ [Fri, 2 Nov 2018 20:42:58 +0000 (05:42 +0900)]
[WIN32SS][FONT] Define IntUnicodeStringToBuffer function and use it (#1004)
- Define IntUnicodeStringToBuffer function to copy the contents of a UNICODE_STRING to a string buffer with a UNICODE_NULL correctly.
- Use it.
JIRA issue: N/A
Katayama Hirofumi MZ [Fri, 2 Nov 2018 20:37:05 +0000 (05:37 +0900)]
[WIN32SS][FONT] Improve Precision Penalty (#1006)
Thomas Faber [Fri, 2 Nov 2018 10:10:07 +0000 (11:10 +0100)]
[REACTOS] Don't include another module's PCH aka fix build.
Katayama Hirofumi MZ [Fri, 2 Nov 2018 09:53:50 +0000 (18:53 +0900)]
[WIN32SS][FONT] Add ASSERT_FREETYPE_LOCK_HELD(); in FillTMEx (#1005)
Add a assertion for locking, in FillTMEx function of freetype.c. CORE-15166
Pierre Schweitzer [Fri, 2 Nov 2018 08:34:25 +0000 (09:34 +0100)]
[SETUPAPI] Don't let LZClose() reset error code
Carlo Bramini [Fri, 2 Mar 2018 09:14:07 +0000 (10:14 +0100)]
Avoid stray temp files in failure cases of do_file_copyW. CORE-12616
Katayama Hirofumi MZ [Fri, 2 Nov 2018 07:29:18 +0000 (16:29 +0900)]
[WIN32SS][FONT] Move IntUnLockFreeType(); in ftGdiGetTextMetricsW (#1002)
Adjust timing of FreeType unlocking in ftGdiGetTextMetricsW function of "freetype.c". JIRA issue: N/A
Katayama Hirofumi MZ [Fri, 2 Nov 2018 07:28:00 +0000 (16:28 +0900)]
[WIN32SS][FONT] Add DPRINT1 and ASSERT for font resize failure (#1003)
Add DPRINT1 and ASSERT calls for font resize failure in IntRequestFontSize function. JIRA issue: N/A
Hermès Bélusca-Maïto [Thu, 1 Nov 2018 22:20:27 +0000 (23:20 +0100)]
[REACTOS] Temporarily exclude the 1st-stage GUI setup from build, until I (or someone else) finds the correct way to fix the GCC builds.
Hermès Bélusca-Maïto [Sun, 7 Jan 2018 00:35:48 +0000 (01:35 +0100)]
[SETUPLIB][USETUP] Minor improvements.
- Use adequate access flag when opening symbolic links.
- Simplify the prototype of UpdateRegistry() since now both Setup INF
handle and settings lists are inside the USETUP_DATA structure.
Hermès Bélusca-Maïto [Mon, 15 Jan 2018 17:48:51 +0000 (18:48 +0100)]
[USETUP] Improve SetupCommitFileQueueW() to make it compatible with its Win32 counterpart.
This means, call in the correct order the user callback with the correct
parameters (in particular the correct paths for file copy operations),
and check also for the callback returned value to know whether or not to
continue the file operations.
Hermès Bélusca-Maïto [Sat, 6 Jan 2018 15:47:37 +0000 (16:47 +0100)]
[SETUPLIB][REACTOS][USETUP] Further improve the interfacing with INF and File-Queue APIs.
This allows using some of the SetupApi.dll functions when SETUPLIB is
used in the (Win32) GUI 1st-stage installer "REACTOS", while using the
custom implemented NT-aware functions in "USETUP".
Hermès Bélusca-Maïto [Fri, 5 Jan 2018 01:08:59 +0000 (02:08 +0100)]
[USETUP] Improvements for the File-queues code.
- Add support for delete and move/rename operations, which are needed
for implementing ReactOS upgrading support.
- Use cabinet contexts.
- Use standard LIST_ENTRY structures for implementing the lists.
- Move the path-building hack code in SetupCommitFileQueueW() that had
been introduced in r66604 (
97bb83f) out of the file-queues code.
- Make the function prototypes compatible with win32's setupapi functions.
- Fix the format of the data passed to the custom notification handler.
- Adjust the file-copy callback to correctly use its arguments (setupapi-compatible).
Eric Kohl [Thu, 1 Nov 2018 13:50:08 +0000 (14:50 +0100)]
[UMPNPMGR] Implement PNP_DetectResourceConflict().
Joachim Henze [Tue, 30 Oct 2018 18:06:50 +0000 (19:06 +0100)]
[RICHED20] Revert ocr_reverse.cur to fix CORE-15190
Old cursor looks better.
We revert to SVN state r75865 and note the diff for Amine
so that the wrong version won't come back in the future.
Old file is just 326bytes while the one that we do not want is 33.134bytes
which means we will save some RAM as well.
Jérôme Gardou [Tue, 30 Oct 2018 16:23:42 +0000 (17:23 +0100)]
[CMAKE] Do not add any extension to separate debug symbol files (#1000)
There is no possibility for GDB to recognize them otherwise
Katayama Hirofumi MZ [Tue, 30 Oct 2018 08:24:47 +0000 (17:24 +0900)]
[WIN32SS] Fix SwitchToThisWindow for #998 (#999)
Reduce a failure in SwitchToThisWindow testcase of #998. CORE-15165
Katayama Hirofumi MZ [Tue, 30 Oct 2018 08:14:37 +0000 (17:14 +0900)]
[APITESTS] Add InSendMessage check in SwitchToThisWindow testcase (#998)
CORE-15165
Katayama Hirofumi MZ [Mon, 29 Oct 2018 23:54:40 +0000 (08:54 +0900)]
[APITESTS] Improve CloseWindow testcase (#997)
Improve the testcase for user32!CloseWindow function.
Katayama Hirofumi MZ [Mon, 29 Oct 2018 23:38:03 +0000 (08:38 +0900)]
[APITESTS] Add CloseWindow testcase (#996)
Add a testcase for user32!CloseWindow function.
Katayama Hirofumi MZ [Mon, 29 Oct 2018 23:13:05 +0000 (08:13 +0900)]
[WIN32SS] Make window foreground in SwitchToThisWindow (#995)
CORE-15165
Pierre Schweitzer [Mon, 29 Oct 2018 16:28:01 +0000 (17:28 +0100)]
[FLTMGR] Remove duplicated export
Ged Murphy [Mon, 29 Oct 2018 17:03:11 +0000 (17:03 +0000)]
[FLTMGR] Add a bit more basic code layout for filter registration
Needs implementing
Pierre Schweitzer [Mon, 29 Oct 2018 16:28:01 +0000 (17:28 +0100)]
[FLTMGR] Remove duplicated export
Ged Murphy [Mon, 29 Oct 2018 11:28:10 +0000 (11:28 +0000)]
[FLTMGR] Callers must have registered an unload routine to be allowed to unload
Ged Murphy [Mon, 29 Oct 2018 11:17:21 +0000 (11:17 +0000)]
[FLTMGR] Delete unused file
Pierre Schweitzer [Sun, 28 Oct 2018 10:24:36 +0000 (11:24 +0100)]
[FLTMGR] Stub FltReleaseFileNameInformation()
Pierre Schweitzer [Sun, 28 Oct 2018 10:23:08 +0000 (11:23 +0100)]
[FLTMGR] Stub FltGetDestinationFileNameInformation()
Pierre Schweitzer [Sun, 28 Oct 2018 10:20:29 +0000 (11:20 +0100)]
[FLTMGR] Stub FltAttachVolume()
Pierre Schweitzer [Sun, 28 Oct 2018 10:18:21 +0000 (11:18 +0100)]
[FLTMGR] Export FltCreateCommunicationPort() and FltCloseCommunicationPort()
Pierre Schweitzer [Sun, 28 Oct 2018 10:15:44 +0000 (11:15 +0100)]
[FLTMGR] Stub FltGetFileNameInformation()
Pierre Schweitzer [Sun, 28 Oct 2018 10:12:45 +0000 (11:12 +0100)]
[FLTMGR] Implement FltGetVolumeName()
Pierre Schweitzer [Sun, 28 Oct 2018 09:37:00 +0000 (10:37 +0100)]
[FLTMGR] Stub FltDetachVolume()
Pierre Schweitzer [Sun, 28 Oct 2018 09:31:53 +0000 (10:31 +0100)]
[FLTMGR] Implement FltCreateFile()
Pierre Schweitzer [Sun, 28 Oct 2018 09:26:37 +0000 (10:26 +0100)]
[FLTMGR] Stub FltCreateFileEx()
Pierre Schweitzer [Sun, 28 Oct 2018 08:35:17 +0000 (09:35 +0100)]
[FLTMGR] Export FltCloseClientPort()
Pierre Schweitzer [Sun, 28 Oct 2018 08:34:39 +0000 (09:34 +0100)]
[FLTMGR] Stub FltGetFileNameInformationUnsafe()
Pierre Schweitzer [Sun, 28 Oct 2018 08:26:12 +0000 (09:26 +0100)]
[FLTMGR] Implement FltEnumerateVolumes()
Pierre Schweitzer [Sun, 28 Oct 2018 08:10:40 +0000 (09:10 +0100)]
[FLTMGR] Export FltObjectDereference() and FltSendMessage()
Hermès Bélusca-Maïto [Mon, 14 Aug 2017 17:11:50 +0000 (17:11 +0000)]
[USETUP] Refactor the cabinet handling code to place all the global state variables into a CABINET_CONTEXT structure.
Place also all the private cabinet definitions into the .c, keeping
into the header file only the "public" structures and function prototypes.
Hermès Bélusca-Maïto [Fri, 5 Jan 2018 01:51:51 +0000 (02:51 +0100)]
[SETUPLIB][REACTOS][USETUP] Re-organize the setup state variables and some helpers.
- Move a great deal of global variables into the USETUP_DATA structure
(the SetupInf, the SetupFileQueue, the generic lists...).
- Place the common setup initialization code into an InitializeSetup()
routine, and the cleanup code into FinishSetup().
- Implement the setup-code part support for the TXTSETUP.SIF setup
source path override variables "SetupSourceDevice" and "SetupSourcePath"
(see CORE-9023); support for them in SETUPLDR will be added later.
Hermès Bélusca-Maïto [Sun, 28 Oct 2018 22:33:29 +0000 (23:33 +0100)]
[SETUPLIB] Silence noisy DPRINTs.
Pierre Schweitzer [Sun, 28 Oct 2018 21:37:59 +0000 (22:37 +0100)]
[KMTESTS:CC] Introduce a macro to test public BCB
For now, it's local, but it may be moved to some header
to be shared between tests.
Pierre Schweitzer [Sun, 28 Oct 2018 19:48:01 +0000 (20:48 +0100)]
[NTOSKRNL] Fix refcounting for BCBs
Now, we make sure that we update ref count and BCB list membership
with the BCB lock held, in a row.
This will avoid race conditions where the BCB was removed from the
list, then referenced again, leading to inconsistencies in memory
and crashes later on.
This could notably be triggered while building ReactOS on ReactOS
(one would call this a regression).
CORE-15235
Bișoc George [Sun, 28 Oct 2018 17:56:45 +0000 (18:56 +0100)]
[USRMGR] Fix a truncated text on French resource
CORE-15267
Hermès Bélusca-Maïto [Fri, 29 Dec 2017 18:37:28 +0000 (19:37 +0100)]
[SETUP:REACTOS] Populate the list of existing installations.
- In the 1st-stage GUI setup, display the list of existing discovered
NTOS installations, with its name, installation path and vendor name,
and an associated icon.
Hermès Bélusca-Maïto [Mon, 25 Dec 2017 23:50:01 +0000 (00:50 +0100)]
[SETUP:REACTOS] Add a wizard page to select which existing OS installation to upgrade.
Hermès Bélusca-Maïto [Mon, 14 Aug 2017 17:06:19 +0000 (17:06 +0000)]
[SETUP:REACTOS] Adapt the 1st-stage GUI setup to compile with the setuplib.
svn path=/branches/setup_improvements/; revision=75544
[SETUP:REACTOS] More interfacing of the 1st-stage GUI installer with the setuplib.
- Add a ConvertNtPathToWin32Path() helper function that allows converting
NT paths like: \Device\CdRom0\i386\txtsetup.sif file into a Win32 path
that the Win32 versions of the SetupApi functions (e.g. SetupOpenInfFileW)
can accept.
Note that RtlNtPathNameToDosPathName() cannot be used here because this
function only works for NT paths within the \DosDevices\ (or \??\) NTObj
directory, and not in other directories.
- Use this helper function in the implementation of SetupOpenInfFileExW.
Now the txtsetup.sif function can be loaded by setuplib *when being used*
by the 1st-stage GUI installer!
- Remove deprecated code.
svn path=/branches/setup_improvements/; revision=75668
svn path=/branches/setup_improvements/; revision=75721
svn path=/branches/setup_improvements/; revision=75750
Hermès Bélusca-Maïto [Fri, 5 Jan 2018 00:56:23 +0000 (01:56 +0100)]
[SETUPLIB][USETUP] Move the remaining (directory-creation) functions from usetup's filesup to setuplib.
They will be used later in the library.
Hermès Bélusca-Maïto [Sun, 28 Oct 2018 14:11:23 +0000 (15:11 +0100)]
[FREELDR] Silence a debug print.
Eric Kohl [Sun, 28 Oct 2018 17:12:55 +0000 (18:12 +0100)]
[SCHEDSVC] Reschedule a job after it was started
- Remove a non-recurring job from the job list after starting it.
- Remove a recurring job from the start list, calculate its next start time and insert it again.
- Calculate the timeout for the next job.
Thomas Faber [Thu, 25 Oct 2018 10:11:45 +0000 (12:11 +0200)]
[ACPICA] Update to version
20181003. CORE-15222
Thomas Faber [Thu, 25 Oct 2018 10:07:40 +0000 (12:07 +0200)]
[ACPICA] Update to version
20180531. CORE-15222
Thomas Faber [Thu, 25 Oct 2018 10:00:28 +0000 (12:00 +0200)]
[ACPICA] Update to version
20180105. CORE-15222
Thomas Faber [Thu, 25 Oct 2018 09:31:02 +0000 (11:31 +0200)]
[ACPICA] Update to version
20171215. CORE-15222
Hermès Bélusca-Maïto [Sun, 28 Jan 2018 22:14:16 +0000 (23:14 +0100)]
[SETUPLIB][USETUP] Remove the deprecated GenericListHasSingleEntry() function and use instead GetNumberOfListEntries().
- Few FIXMEs get fixed in the process.
- Add some diagnostic ASSERTs.
Hermès Bélusca-Maïto [Tue, 9 Jan 2018 01:56:00 +0000 (02:56 +0100)]
[SETUPLIB] Properly cleanup the temporary registry keys created for setting up the registry.
This includes also to remove the created symlinks.
Symlinks deletion is special, as one has to open first the symlink
itself (and not its target), then remove the "SymbolicLinkTarget" value
before really deleting the key. Of course everything must be done under
proper access rights.
Additional changes:
- Change prototype BOOLEAN CmpLinkKeyToHive(...) to NTSTATUS CreateSymLinkKey(...).
- Silence few DPRINTs.
- Document some FIXMEs that I need to inspect later on ReactOS.
- HKEY --> HANDLE.
Hermès Bélusca-Maïto [Sun, 3 Sep 2017 16:17:27 +0000 (16:17 +0000)]
[SETUPLIB][USETUP] Move the registry-update procedure into setuplib.
- It can therefore be also used by the 1st-stage GUI setup.
- Rename some function parameters to clarify what they should be.
Based on:
svn path=/branches/setup_improvements/; revision=75750
Hermès Bélusca-Maïto [Sun, 3 Sep 2017 16:03:21 +0000 (16:03 +0000)]
[USETUP] Introduce some -V functions for CONSOLE_ConOutPrintf, CONSOLE_SetStatusText and CONSOLE_SetStatusTextX.
Additions:
- Use explicit __cdecl calling convention for variadic functions.
- Fix also the whitespace in consup.h.
svn path=/branches/setup_improvements/; revision=75749
Phosphorus Moscu [Sun, 28 Oct 2018 12:21:09 +0000 (09:21 -0300)]
[README] Update to README File for git (#990)
When I click the logo it will redirect to the website.
Mark Jansen [Sun, 28 Oct 2018 12:06:27 +0000 (13:06 +0100)]
[SHELL32] Fix broken control definition
Mark Jansen [Sun, 28 Oct 2018 12:06:08 +0000 (13:06 +0100)]
[SETUPAPI] Fix broken control definition.
Mark Jansen [Sun, 21 Oct 2018 17:09:09 +0000 (19:09 +0200)]
[WIN32SS] Disable scrollbars when SIF_DISABLENOSCROLL is used
CORE-13918
Mark Jansen [Sat, 20 Oct 2018 13:38:21 +0000 (15:38 +0200)]
[KERNEL32] Directly use UnhandledExceptionFilter in BaseProcessStartup
Mark Jansen [Thu, 18 Oct 2018 20:07:37 +0000 (22:07 +0200)]
[KERNEL32] Use the default UnhandledExceptionFilter in BaseThreadStartup.
This should allow unhandled exceptions in a thread to trigger our crash reporter,
instead of killing the process directly.
Mark Jansen [Sun, 21 Oct 2018 12:46:44 +0000 (14:46 +0200)]
[DRWTSN32] Improve stack dumping
Hermès Bélusca-Maïto [Fri, 29 Dec 2017 18:37:28 +0000 (19:37 +0100)]
[SETUPLIB] Store the vendor name for each discovered NTOS installation.
Take also the opportunity to simplify a little bit the code.
Hermès Bélusca-Maïto [Fri, 5 Jan 2018 00:49:09 +0000 (01:49 +0100)]
[USETUP] Add new file-operation-related messages for deletion, moving and renaming.
Hermès Bélusca-Maïto [Sat, 30 Dec 2017 17:21:42 +0000 (18:21 +0100)]
[SETUPLIB] Remove a deprecated error number (that gets merged with ERROR_TXTSETUP_SECTION).
[USETUP] Improve usage of ERROR_TXTSETUP_SECTION and ERROR_CABINET_SECTION error codes, correctly display associated error message, and remove a deprecated string.
Hermès Bélusca-Maïto [Sat, 30 Dec 2017 17:09:37 +0000 (18:09 +0100)]
[USETUP] Remove now-redundant file (already used with SETUPLIB).
Hermès Bélusca-Maïto [Fri, 29 Dec 2017 18:09:56 +0000 (19:09 +0100)]
[SETUPLIB][USETUP] Don't store UI-related display strings in GENERIC_LIST_ENTRY-ies, + other code adaptations.
- Apart from allowing a UI cache variable that may be used when
displaying GENERIC_LIST_ENTRY-ies, do not store any display strings
associated to these list entries. They should be instead computed only
when initializing a list UI (or a combo-box or list control if the
code is used in Win32 environment).
For this matter a callback is provided to InitGenericListUi() that
does the job of computing the displayed string corresponding to a
given GENERIC_LIST_ENTRY.
- Simplify the calls to InitGenericListUi(), and refactor the
RestoreGenericListUiState() function.
- Use for-loops for iterating over GENERIC_LIST items.
- Adapt the storage data format for lists of settings items.
- The txtsetup.sif INF format specified in LoadSetupInf() should not be
INF_STYLE_WIN4 (to be investigated...).
Hermès Bélusca-Maïto [Sat, 23 Dec 2017 19:17:38 +0000 (20:17 +0100)]
[SETUPLIB][USETUP] Bring some suggestions from PR #59 in.
- Use OBJ_CASE_INSENSITIVE when initializing object attributes
(no actual reason why to keep case sensitivity there).
- Check the success of a RtlStringCchPrintfW call in EnumerateReactOSEntries().
- Explicitly check for returned STATUS_NOT_SUPPORTED from ChkdskPartition()
or FormatPartition(), and display an appropriate error message.
- Remove some left-over comments but also explain why I kept some
commented code (mainly for future reference).
Hermès Bélusca-Maïto [Sun, 24 Dec 2017 21:37:19 +0000 (22:37 +0100)]
[SETUPLIB] Improve the bootloader 'validity' checks -- Addendum to
f06734e5 (r74512).
Adapted from PR #89 by Serge Gautherie.
This should improve the situation described in CORE-12672 and CORE-4870.
Hermès Bélusca-Maïto [Fri, 22 Dec 2017 22:28:53 +0000 (23:28 +0100)]
[SETUPLIB] Improve an alternate code implementation.
Comment about the status of two '#if 0'.
[SETUPLIB] Fix some uninitialized variables (caught by clang-cl).
Also, initialize NtName->Length in return paths in ResolveArcNameManually().
Hermès Bélusca-Maïto [Mon, 4 Sep 2017 20:00:22 +0000 (20:00 +0000)]
[USETUP] Move the SetupExtractFile() function to where it is (only) used.
svn path=/branches/setup_improvements/; revision=75762
Hermès Bélusca-Maïto [Sun, 3 Sep 2017 20:05:11 +0000 (20:05 +0000)]
[SETUPLIB][USETUP] Use NT RTL String Safe functions instead of Win32-oriented ones (and remove usage of HRESULT too).
Based on:
svn path=/branches/setup_improvements/; revision=75755
svn path=/branches/setup_improvements/; revision=75757
Hermès Bélusca-Maïto [Sun, 3 Sep 2017 19:46:26 +0000 (19:46 +0000)]
[SETUPLIB][USETUP] Make the GENERIC_LIST store the items display text in UNICODE (and not in ANSI).
Only convert to ANSI when needed (e.g. in the display code for usetup).
The 1st-stage GUI setup will however use the UNICODE strings directly.
svn path=/branches/setup_improvements/; revision=75753
Hermès Bélusca-Maïto [Sun, 3 Sep 2017 19:31:36 +0000 (19:31 +0000)]
[USETUP] Whitespace fixes only.
svn path=/branches/setup_improvements/; revision=75752
Hermès Bélusca-Maïto [Sun, 3 Sep 2017 16:19:59 +0000 (16:19 +0000)]
[SETUPLIB][USETUP] Move the floppy-disk accessibility check into InstallFatBootcodeToFloppy().
svn path=/branches/setup_improvements/; revision=75751
Hermès Bélusca-Maïto [Sun, 3 Sep 2017 12:08:39 +0000 (12:08 +0000)]
[USETUP] Resources: fix a typo.
svn path=/branches/setup_improvements/; revision=75748
Hermès Bélusca-Maïto [Wed, 30 Aug 2017 11:28:52 +0000 (11:28 +0000)]
[SETUPLIB][USETUP][INPUT.CPL] MUI integration with setuplib.
[SETUPLIB] Copy the mui* files from usetup into the setuplib for later usage, and add mui.c to build.
svn path=/branches/setup_improvements/; revision=75711
[SETUPLIB][USETUP] Start massaging the MUI files and split up what concerns only the usetup "resources",
and what concerns general language parameters (in the setuplib).
It may be interesting to retrieve the language parameters
from INF file (e.g. intl.inf) (suggested by Giannis).
svn path=/branches/setup_improvements/; revision=75715
[SETUPLIB] Add the necessary headers to mui.c to be able to compile.
[USETUP] Comment out the languages that don't have any resources.
svn path=/branches/setup_improvements/; revision=75716
[SETUPLIB][USETUP] Adjust MUI and settings code.
- Re-enable settings code concerning language, keyboards & layout
in the setuplib, and remove the old code in usetup.
- Remove useless code in setuplib's mui.c.
- Rename usetup's MUI "LanguageList" into "ResourceList" so as to
avoid colliding with the "LanguageList" of setuplib.
- Add the magic CMakeLists line "add_definitions(${I18N_DEFS})" that
I forgot previously, that caused the "LanguageList" of setuplib to be empty!
The code compiles and works during my tests.
svn path=/branches/setup_improvements/; revision=75717
[SETUPLIB] Change some string pointer types & function prototypes so that the usetup-specific
"SelectedLanguageId" variable is not used in the library.
svn path=/branches/setup_improvements/; revision=75719
[SETUPLIB] Change some function prototypes so that the usetup-specific "SelectedLanguageId" variable is not used in the library.
Also, make AddEntriesFromInfSection(), DefaultProcessEntry() and the typedef PPROCESS_ENTRY_ROUTINE private again.
svn path=/branches/setup_improvements/; revision=75720
svn path=/branches/setup_improvements/; revision=75724
[USETUP] Code adaptations.
- Transform some do{}while() loops into while(){} ones, since the lists on which we work may only contain one single {NULL} element.
- Modify MUIGetOEMCodePage() call after r75719.
- Use PCWSTR where needed.
svn path=/branches/setup_improvements/; revision=75722
[USETUP] Adjust some MUI & settings calls, following the commits r75719, r75720 and r75721.
svn path=/branches/setup_improvements/; revision=75723
[INPUT.CPL] Adjust inclusion of "muifonts.h" (commit
3dbd44f) due to changes introduced in r75711 and r75715.
Eric Kohl [Sat, 27 Oct 2018 22:02:18 +0000 (00:02 +0200)]
[SCHEDSVC] Improvements to the scheduler service
Use WaitForMultipleObjects in the mail scheduler loop:
- Use events to signal service stop and job update events to the main loop.
- Use the timeout timer to start the next job.
Pierre Schweitzer [Sat, 27 Oct 2018 19:54:55 +0000 (21:54 +0200)]
[NTOSKRNL] Rewrite IoCheckEaBufferValidity() so that it's less magic
And make its coding style consistent with our rules
Katayama Hirofumi MZ [Sat, 27 Oct 2018 20:13:08 +0000 (05:13 +0900)]
[WIN32SS][NTGDI] Refactoring PATH_WidenPath (#888)
Preparation to support pen width.
Split IntGdiWidenPath function from PATH_WidenPath function.
IntGdiWidenPath is independent from DC.
CORE-2527, CORE-13534