Pierre Schweitzer [Sun, 30 Dec 2018 10:45:08 +0000 (11:45 +0100)]
[SERVICES] Define the RI_ScQueryServiceTagInfo RPC call
All the definitions are taken from ProcessHacker:
https://github.com/processhacker/processhacker/blob/master/phnt/include/subprocesstag.h
Eric Kohl [Sun, 30 Dec 2018 11:55:31 +0000 (12:55 +0100)]
[UMPNPMGR] PNP_GetDeviceList: Implement the enumeration of device instances for a given enumerator.
Timo Kreuzer [Sun, 30 Dec 2018 11:19:11 +0000 (12:19 +0100)]
[NDK][NTOS] Add global definition of INIT_FUNCTION/INIT_SECTION (#779)
* Add an NDK header to define INIT_FUNCTION/INIT_SECTION globally
* Use _declspec(allocate(x)) and _declspec(code_seg(x)) on MSVC versions that support it
* Use INIT_FUNCTION on functions only and INIT_SECTION on data only (required by MSVC)
* Place INIT_FUNCTION before the return type (required by MSVC)
* Make sure declarations and implementations share the same modifiers (required by MSVC)
* Add a global linker option to suppress warnings about defined but unused INIT section
* Merge INIT section into .text in freeldr
Eric Kohl [Sat, 29 Dec 2018 23:39:08 +0000 (00:39 +0100)]
[UMPNPMGR] PNP_GetDeviceListSize: Implement the buffer size calculation for given enumerators and take care of the terminating double Unicode null character.
Thomas Faber [Fri, 28 Dec 2018 12:39:23 +0000 (13:39 +0100)]
[WIN32K:NTUSER] Reference menus owned by a popup menu. CORE-15504
Eric Kohl [Sat, 29 Dec 2018 21:08:35 +0000 (22:08 +0100)]
[UMPNPMGR] PNP_GetDeviceList / PNP_GetDeviceListSize: Implement the buffer size calculation and device instance enumeration for a given enumerator and device name.
Pierre Schweitzer [Sat, 29 Dec 2018 21:09:52 +0000 (22:09 +0100)]
[ADVAPI32_APITEST] Unknown field isn't that unknown and should contain "1"
See processhacker source code (as reference)
Timo Kreuzer [Tue, 3 Apr 2018 19:25:04 +0000 (21:25 +0200)]
[CABMAN] Fix a problem with creating temp files on some Windows system
Mark Jansen [Sat, 29 Dec 2018 19:03:06 +0000 (20:03 +0100)]
[FONT][WIN32SS] Re-add casts for gcc
Mark Jansen [Sat, 29 Dec 2018 18:46:37 +0000 (19:46 +0100)]
[FONT][WIN32SS] Remove casts
Mark Jansen [Sat, 29 Dec 2018 18:46:14 +0000 (19:46 +0100)]
[FONT][WIN32SS] Hold the freetype lock while accessing freetype data
Mark Jansen [Sat, 29 Dec 2018 18:46:04 +0000 (19:46 +0100)]
[FONT][WIN32SS] Fix a memory leak
Mark Jansen [Sat, 29 Dec 2018 18:45:37 +0000 (19:45 +0100)]
[FONT][WIN32SS] Fix a memory leak
Mark Jansen [Sat, 29 Dec 2018 18:45:21 +0000 (19:45 +0100)]
[FONT][WIN32SS] Hold the freetype lock while accessing freetype data
Mark Jansen [Sat, 29 Dec 2018 18:45:09 +0000 (19:45 +0100)]
[FONT][WIN32SS] Hold the freetype lock while accessing freetype data
Mark Jansen [Sat, 29 Dec 2018 18:44:26 +0000 (19:44 +0100)]
[FONT][WIN32SS] Do not return an uninitialized variable
Eric Kohl [Sat, 29 Dec 2018 16:49:38 +0000 (17:49 +0100)]
[NTOS:IO] Fix indentation. No code changes.
Katayama Hirofumi MZ [Fri, 28 Dec 2018 20:55:19 +0000 (05:55 +0900)]
[APPWIZ] Show message box upon error
Pierre Schweitzer [Fri, 28 Dec 2018 19:34:48 +0000 (20:34 +0100)]
[SETUP] Add support for selecting FS type in unattended setups
By default, we still fallback to FAT if nothing asked, or if there
is an invalid input.
0 is FAT, 1 is BtrFS. This can be grown as soon as we add more IFS.
Thomas Faber [Fri, 28 Dec 2018 10:27:28 +0000 (11:27 +0100)]
[WIN32K:NTUSER] Acquire the user lock exclusively in NtUserGetSystemMenu. CORE-15512
Thomas Faber [Fri, 28 Dec 2018 10:28:43 +0000 (11:28 +0100)]
[NTDLL:LDR] Avoid passing an uninitialized variable to another function.
Katayama Hirofumi MZ [Fri, 28 Dec 2018 03:12:42 +0000 (12:12 +0900)]
[MENU][WIN32SS] Fix non-menubar menu text Y position (#1199)
CORE-15226
Mark Jansen [Thu, 27 Dec 2018 22:03:22 +0000 (23:03 +0100)]
[NTOS] When checking something for NULL, let's initialize it to NULL...
Eric Kohl [Thu, 27 Dec 2018 18:27:43 +0000 (19:27 +0100)]
[ADVAPI32] CreateProcessAsUserA/W: Partially revert an obvious case of over-engineering. Only share the common parts! Now it looks a lot better. No more stupid bUnicode!
Luo Yufan [Thu, 27 Dec 2018 07:24:24 +0000 (15:24 +0800)]
[TRANSLATION] Update Traditional Chinese translation. (#1193)
Katayama Hirofumi MZ [Thu, 27 Dec 2018 00:23:49 +0000 (09:23 +0900)]
[FONT][WIN32SS] Optimize a bit
Luo Yufan [Wed, 26 Dec 2018 20:02:23 +0000 (04:02 +0800)]
[TRANSLATION] Update Traditional Chinese translation. (#1192)
Eric Kohl [Tue, 25 Dec 2018 22:04:27 +0000 (23:04 +0100)]
[NTOS:IO] When a device has been started, create an Enum sub key to its service key and add the device instance name to the Enum sub key.
Katayama Hirofumi MZ [Tue, 25 Dec 2018 12:51:58 +0000 (21:51 +0900)]
[FONT][WIN32SS] Follow-up of #1184
Pierre Schweitzer [Tue, 25 Dec 2018 12:50:07 +0000 (13:50 +0100)]
[BTRFS] Reduce diff with upstream
CORE-15452
Pierre Schweitzer [Tue, 25 Dec 2018 12:45:41 +0000 (13:45 +0100)]
[NTOSKRNL_VISTA] Implement FsRtlGetEcpListFromIrp and FsRtlGetNextExtraCreateParameter
CORE-15452
Pierre Schweitzer [Tue, 25 Dec 2018 12:44:44 +0000 (13:44 +0100)]
[NTOSKRNL_VISTA] Implement IoGetIrpExtraCreateParameter
CORE-15452
Katayama Hirofumi MZ [Tue, 25 Dec 2018 11:41:25 +0000 (20:41 +0900)]
[FONT][WIN32SS] Refactor rendering text background (#1184)
Simplify the background filling codes. CORE-14856
Katayama Hirofumi MZ [Tue, 25 Dec 2018 09:04:21 +0000 (18:04 +0900)]
[WIN32SS] Fix RLE4 bitmap decoding (#1188)
CORE-10553, CORE-11399
Luo Yufan [Tue, 25 Dec 2018 08:28:36 +0000 (16:28 +0800)]
[TRANSLATION] Update Chinese translation. (#1187)
[REG][REACTOS][EXPLORER][APPWIZ][CONSOLE][INETCPL][INPUT]
[INTL][OPENGLCFG][TIMEDATE][DEVCPUX][COMCTL32][COMDLG32]
[MSGINA][NETCFGX][NETID][SETUPAPI][SHELL32][SYSSETUP]
Update Simplified and Traditional Chinese translations.
Eric Kohl [Mon, 24 Dec 2018 17:19:58 +0000 (18:19 +0100)]
[MC] Fix the build
Eric Kohl [Mon, 24 Dec 2018 17:10:38 +0000 (18:10 +0100)]
[MC] Fix build issue?
Eric Kohl [Mon, 24 Dec 2018 16:03:00 +0000 (17:03 +0100)]
Fix the build
Eric Kohl [Mon, 24 Dec 2018 13:39:26 +0000 (14:39 +0100)]
[NET] Add (incomplete) COMPUTER command and rename help.c to cmdHelp.c.
Luo Yufan [Mon, 24 Dec 2018 09:34:01 +0000 (17:34 +0800)]
[COMDLG32] Update Simplified Chinese translation.
Luo Yufan [Sun, 23 Dec 2018 16:21:54 +0000 (00:21 +0800)]
[COMCTL32] Update Simplified Chinese translation.
Eric Kohl [Mon, 24 Dec 2018 10:48:23 +0000 (11:48 +0100)]
[NET] Move TIME, USE, USER, VIEW and NET command syntax and help texts into a message table and add the translators names to the message file.
Eric Kohl [Mon, 24 Dec 2018 09:20:44 +0000 (10:20 +0100)]
[NET] Move START, STATISTICS and STOP command syntax and help texts into a message table.
Eric Kohl [Mon, 24 Dec 2018 00:25:30 +0000 (01:25 +0100)]
[NET] Move PAUSE, PRINT, SEND, SESSION and SHARE command syntax and help texts into a message table.
Eric Kohl [Sun, 23 Dec 2018 23:13:16 +0000 (00:13 +0100)]
[NET] Move HRELPMSG, LOVALGROUP and NAME command syntax and help texts into a message table.
Eric Kohl [Sun, 23 Dec 2018 20:41:27 +0000 (21:41 +0100)]
[NET] Move FILE, GROUP and HELP command syntax and help texts into a message table.
Hermès Bélusca-Maïto [Sun, 23 Dec 2018 20:00:56 +0000 (21:00 +0100)]
[USETUP] Add SETUP_INIT_PAGE in the list of virtual pages.
Bișoc George [Sun, 23 Dec 2018 19:46:36 +0000 (20:46 +0100)]
[OSK] Add missing welcome box resource for Estonian (#1181)
Hermès Bélusca-Maïto [Sun, 23 Dec 2018 19:28:19 +0000 (20:28 +0100)]
[USETUP] Modify the integrated user-mode PnP manager along the lines of UMPNPMGR, so that we can wait until all the queued device installations finish before continuing the installation further.
Add a corresponding please-wait page and update the translations.
Hermès Bélusca-Maïto [Sun, 23 Dec 2018 15:53:39 +0000 (16:53 +0100)]
[USETUP] Check for invalid INF handles before doing operations.
Eric Kohl [Sun, 23 Dec 2018 19:22:48 +0000 (20:22 +0100)]
[NET] Move COMPUTER, CONFIG and CONTINUE command syntax and help texts into a message table.
Pierre Schweitzer [Sun, 23 Dec 2018 17:22:57 +0000 (18:22 +0100)]
[SDK] Set proper lang IDs, aka fix build
Luo Yufan [Sun, 23 Dec 2018 16:00:09 +0000 (00:00 +0800)]
[FONTVIEW] Update Traditional Chinese translation. (#1180)
Eric Kohl [Sun, 23 Dec 2018 15:47:16 +0000 (16:47 +0100)]
[NET] Move ACCOUNTS command syntax and help text into a message table.
Pierre Schweitzer [Sun, 23 Dec 2018 13:59:42 +0000 (14:59 +0100)]
[NTOSKRNL] Set the MemoryMaker flag when executing write behind
Pierre Schweitzer [Sun, 23 Dec 2018 13:43:17 +0000 (14:43 +0100)]
[NTOSKRNL] Implement write behind in Cc
For now, this is just a split between scan and flush that
were both done during lazy scan previously.
Lazy scan shouldn't perform any write operation, but only
queue a write behind operation.
Our implementation is far from the original, as it seems
our lazy scan should queue a write behind operation per
shared cache map. Right now, we only perform global
operation.
Eric Kohl [Sun, 23 Dec 2018 13:16:53 +0000 (14:16 +0100)]
[NET] Load netmsg.dll right from the start and print some messages using netmsg.dll rather than local strings.
@Translators: Please start translating messages from netmsgmsg.mc and errorcodes.mc (located in sdk\include\reactos\mc). They will be used instead of local strings.
Hermès Bélusca-Maïto [Sun, 23 Dec 2018 13:06:03 +0000 (14:06 +0100)]
[UMPNPMGR] Use HeapReAlloc() to reallocate the PnP events buffer. Fix a memory leak in DeviceInstallThread().
Hermès Bélusca-Maïto [Sun, 23 Dec 2018 13:02:16 +0000 (14:02 +0100)]
[UMPNPMGR] Minor formatting, and enable a DPRINT1 in case NtGetPlugPlayEvent() fails and the PnpEventThread() thread unexpectedly terminates due to that.
Pierre Schweitzer [Sun, 23 Dec 2018 11:31:14 +0000 (12:31 +0100)]
[KMTESTS:CC] Fix a typo, definitely showing this code path is not used during the test
Pierre Schweitzer [Sun, 23 Dec 2018 11:10:58 +0000 (12:10 +0100)]
[NTOSKRNL] Honor files that shouldn't be lazy written
Pierre Schweitzer [Sun, 23 Dec 2018 11:04:39 +0000 (12:04 +0100)]
[KMTESTS:CC] Add tests showing a dirty VACB isn't flushed on file growing
CORE-11819
Pierre Schweitzer [Sun, 23 Dec 2018 10:08:01 +0000 (11:08 +0100)]
[NTOSKRNL] When growing a file, invalid the last VACB so that it can be refreshed
This will avoid corruption when a file size is little grown and read afterwards.
Up to now, FSD where reading 0es instead of expected data, causing corruption.
This fixes MS FastFAT not being able to mount a FAT volume in ReactOS, corrupting
the FAT.
This also fixes the CcSetFileSizes kmtest tests.
This is based on a patch by Thomas Faber.
CORE-11819
Eric Kohl [Sat, 22 Dec 2018 16:52:03 +0000 (17:52 +0100)]
[NETMSG] Fix message table include statement and build netmsg.dll.
Eric Kohl [Sat, 22 Dec 2018 16:47:39 +0000 (17:47 +0100)]
[MC] Remove some useless quotation marks from message strings.
Pierre Schweitzer [Sat, 22 Dec 2018 14:02:16 +0000 (15:02 +0100)]
[FONTSUB] Fix build²
Pierre Schweitzer [Sat, 22 Dec 2018 13:52:02 +0000 (14:52 +0100)]
[FONTSUB] Fix build
Pierre Schweitzer [Sat, 22 Dec 2018 13:36:08 +0000 (14:36 +0100)]
[KMTESTS:CC] Add a trace to identify failing tests
Luo Yufan [Sat, 22 Dec 2018 13:35:33 +0000 (21:35 +0800)]
[TRANSLATION] Update Chinese shortcut translation (#1179)
* [INF] Update Traditional Chinese translation.
* [ROSAPPS] Update Chinese translation.
* [FONTSUB] Add Traditional Chinese translation.
* [FONTSUB] Add Traditional Chinese translation.
* [FONTSUB] Update Simplified Chinese translation.
* [ROSAPPS] Update Chinese translation.
* [FONTSUB] Update Simplified Chinese translation.
Pierre Schweitzer [Sat, 22 Dec 2018 11:42:05 +0000 (12:42 +0100)]
[KMTESTS:CC] Add more tests for SetFileSizes
These are covered by Thomas' patch.
CORE-11819
Pierre Schweitzer [Sat, 22 Dec 2018 11:29:18 +0000 (12:29 +0100)]
[KMTESTS:CC] Add tests for CcSetFileSizes
These are passing in W2K3 but failing in ReactOS.
CORE-11819
Thomas Faber [Sat, 22 Dec 2018 10:29:24 +0000 (11:29 +0100)]
[USP10] Don't mix character and glyph index caches. CORE-14226
Import Wine commits by Nikolay Sivov:
*
d1e618d31da usp10: Use glyph index consistently in ScriptGetGlyphABCWidth().
*
8d018d8d1da usp10: Make sure metrics cache is used with glyph indices only.
*
eda3a3e37da usp10: Remove extra parentheses.
Fixes font display in UltraISO and GOG installers.
See also https://bugs.winehq.org/show_bug.cgi?id=44410
Serge Gautherie [Fri, 21 Dec 2018 18:20:59 +0000 (19:20 +0100)]
[NTOS:CC] CcCanIWrite(): Use BYTES_TO_PAGES(Length)
Pierre Schweitzer [Fri, 21 Dec 2018 18:16:25 +0000 (19:16 +0100)]
[IPHLPAPI_APITEST] Add tests for GetOwnerModuleFromUdpEntry
Pierre Schweitzer [Fri, 21 Dec 2018 18:15:05 +0000 (19:15 +0100)]
[SDK] Define GetOwnerModuleFromUdpEntry()
Pierre Schweitzer [Fri, 21 Dec 2018 18:05:07 +0000 (19:05 +0100)]
[IPHLPAPI_APITEST] Add tests for GetExtendedUdpTable
Oleg Dubinskiy [Fri, 21 Dec 2018 15:49:05 +0000 (17:49 +0200)]
[COMDLG32] Update Ukrainian translation for NEWFILEOPENV2ORD dialog (#1175)
Oleg Dubinskiy [Fri, 21 Dec 2018 15:48:36 +0000 (17:48 +0200)]
[COMDLG32] Update Russian translation for NEWFILEOPENV2ORD dialog (#1174)
Pierre Schweitzer [Fri, 21 Dec 2018 07:44:14 +0000 (08:44 +0100)]
[NTOSKRNL] Don't call AcquireForLazyWrite with the master lock held
This incorrect behavior was leading to a call at too high IRQL for paged code.
This was triggered by MS FastFAT.
ReleaseFromLazyWrite call was already correctly called to that regard.
CORE-11819
Serge Gautherie [Fri, 21 Dec 2018 01:53:42 +0000 (02:53 +0100)]
[D3DCOMPILER_43] Fix a MSVC-x64 warning about dxbc_init() (#1173)
"...\utils.c(561) : warning C4028: formal parameter 2 different from declaration"
Cherry-pick:
https://source.winehq.org/git/wine.git/commit/
ffe9346120ca74f193d8a31d0b6a48eb55604d2b
CORE-7538
Lee Schroeder [Thu, 20 Dec 2018 23:38:45 +0000 (16:38 -0700)]
[THEMEUI][BOOTDATA] Add the Red, White, Blue Classic Color Scheme for Classic Theme, and Localization (#1059)
Adds the 'Red, White, and Blue' Color Scheme used by the Classic Theme and adds localization for all the color schemes into themeui.dll.
Translators, please check the language files for potential copypasta errors.
Hermès Bélusca-Maïto [Thu, 20 Dec 2018 23:33:56 +0000 (00:33 +0100)]
[NTOS] Addendum to
03873aee: check that the computed size of the OEM-converted string is less than MAXUSHORT.
Serge Gautherie [Thu, 20 Dec 2018 23:27:01 +0000 (00:27 +0100)]
[LOG2LINES] Partially sync output format from command line input (#1109)
Serge Gautherie [Thu, 20 Dec 2018 23:07:24 +0000 (00:07 +0100)]
[JSCRIPT] Fix a MSVC-x64 warning about to_uint32() (#1172)
"...\jsutils.c(679) : warning C4028: formal parameter 3 different from declaration"
Cherry-pick:
https://source.winehq.org/git/wine.git/commit/
961d5c8ed05eeccbe216ff24faa0e3d6a0c2b332
CORE-7538
Katayama Hirofumi MZ [Thu, 20 Dec 2018 14:37:08 +0000 (23:37 +0900)]
[ROSAPPS][VGAFONTEDIT] Refactor on OpenInfo
Katayama Hirofumi MZ [Thu, 20 Dec 2018 14:16:04 +0000 (23:16 +0900)]
[ROSAPPS][VGAFONTEDIT] Fix memory leaks
Luo Yufan [Thu, 20 Dec 2018 13:40:03 +0000 (21:40 +0800)]
[TRANSLATION] Update Chinese translation. (#1170)
* [BROWSEUI] Update Traditional Chinese translation.
* [BROWSEUI] Update Simplified Chinese translation.
* [SHELL32] Update Traditional Chinese translation.
* [REGEDIT] Update Traditional Chinese translation.
* [BROWSEUI] Update Traditional Chinese translation.
Katayama Hirofumi MZ [Thu, 20 Dec 2018 13:33:59 +0000 (22:33 +0900)]
[ROSAPPS][VGAFONTEDIT] String/Memory check
Jared Smudde [Thu, 20 Dec 2018 08:38:32 +0000 (02:38 -0600)]
[DEVMGMT] Replace the blurry 32pixel icon with a clearer one. (#1169)
Device Manager's icon improvement.
Katayama Hirofumi MZ [Thu, 20 Dec 2018 08:25:32 +0000 (17:25 +0900)]
[USETUP][NTDLL_APITEST][KBDROST] Allow non-Latin codepage users to build ReactOS on MSVC (Retrial of #1150) (#1168)
- The converter is code7bit I made. code7bit: https://github.com/katahiromz/code7bit
- This converter converts non-clean characters in string literals.
- However I couldn't erase a ton of codepage C4819 warnings.
- CORE-15447
You can edit an European source file as follows:
- Right click the file in the Solution Explorer.
- Select "Open With...".
- Choose "C++ Source Code Editor (with encoding)".
- Choose "Central European (Windows) - Codepage 1260".
Pierre Schweitzer [Thu, 20 Dec 2018 07:49:00 +0000 (08:49 +0100)]
[NTOSKRNL] Check that caller has the priviliege to unload a driver
Also, probe the service name when unloading a driver if called from
user-mode. This will avoid that userland applications can trigger an
invalid read in the kernel (and thus, a BSOD).
CORE-15468
Hermès Bélusca-Maïto [Thu, 20 Dec 2018 02:46:42 +0000 (03:46 +0100)]
[NTOS] Minor formatting + don't hardcode sizeof(UCHAR) value.
Hermès Bélusca-Maïto [Thu, 20 Dec 2018 02:45:43 +0000 (03:45 +0100)]
[NTOS] Addendum to
d8cb37bf: return the correct Status from NtAllocateUuids().
Hermès Bélusca-Maïto [Thu, 20 Dec 2018 02:32:08 +0000 (03:32 +0100)]
[NTOS] Fixes for NtDisplayString().
- Require the user to have TCB privilege for using this function.
- Probe and capture the user-provided string (and avoid usermode-triggered BSODS ;-)
- Allocate the OEM-converted string in *NonPagedPool* because we are
going to transmit the buffer to BOOTVID.
Luo Yufan [Thu, 20 Dec 2018 02:25:12 +0000 (10:25 +0800)]
[TRANSLATION] Update Traditional Chinese translation. (#1166)
Translations for DESK, HDWWIZ, SYSDM, TIMEDATE and BROWSEUI.
If any Taiwanese contributors are present, please help improving the translations!
Stanislav Motylkov [Wed, 19 Dec 2018 23:35:22 +0000 (02:35 +0300)]
[NETSHELL] Use distinct icon for connection status window (#1167)
CORE-15445
Pierre Schweitzer [Wed, 19 Dec 2018 21:49:48 +0000 (22:49 +0100)]
[NTOSKRNL] Drop the ViewLock mutex in favour of the master spin lock
This will allow Cc calls during DPC, which is required by MS FastFAT
CORE-11819
Eric Kohl [Tue, 18 Dec 2018 20:35:12 +0000 (21:35 +0100)]
[NTOSKRNL] Fix indentation. No code changes.
Eric Kohl [Mon, 17 Dec 2018 20:23:10 +0000 (21:23 +0100)]
[NTOSKRNL] Fix indentation. No code changes.
Giannis Adamopoulos [Sun, 16 Dec 2018 11:16:29 +0000 (13:16 +0200)]
[NTUSER] Implement creating the system threads
- Add UserCreateSystemThread function that will signal csrss to create a new system thread.
- NtUserCreateWindowStation: Create the raw input thread and the desktop thread when the IO window station gets created.
- IntMakeHungWindowGhosted: Create the ghost system thread that will own all ghost windows.
- Let the raw input thread manage the window station of csrss.
[USERSRV] Remove system threads creating hack
- Implement SrvCreateSystemThreads
- Don't create the system threads in UserServerDllInitialization.