Colin Finck [Wed, 24 Apr 2019 08:48:15 +0000 (10:48 +0200)]
[REGTEST] Add regtest.cmd to the Run key inside regtest.cmd, so we're also started on the next reboot in case ReactOS crashed *and* the registry has been saved.
unattend.inf only allows to add RunOnce entries, which are in theory only executed on the first boot after installation.
For almost a decade, this worked anyway to start regtest.cmd again after a ReactOS crash, because the registry and thus the deletion of the RunOnce entry wasn't stored on disk in case of a crash.
Thanks to Sylvain for the hint!
As Explorer processes the Run key right after RunOnce and therefore picks up regtest.cmd a second time during the first boot, exit the script just after adding the Run key.
Otherwise, rosautotest.exe would be started twice, with catastrophic results.
Colin Finck [Tue, 23 Apr 2019 09:37:58 +0000 (11:37 +0200)]
[ROSAUTOTEST] Cache the result of GetLastError().
Colin Finck [Tue, 23 Apr 2019 07:17:05 +0000 (09:17 +0200)]
[ROSAUTOTEST] Implement a process activity timeout of 2 minutes. If there is no log output within 2 minutes, the test process is killed, and we continue with the next test.
This is a rather graceful approach compared to sysreg2's 3 minute timeout before killing and restarting the entire VM.
Since we added autochk for FAT filesystems, the filesystem is often "fixed" after a reset with the consequence that ReactOS doesn't boot up anymore.
The sysreg2 restart code still remains for handling tests causing BSODs.
Eric Kohl [Thu, 25 Apr 2019 22:03:27 +0000 (00:03 +0200)]
[POWERCFG] Fix the initialization of the power schemes page
CORE-4995
Oleg Dubinskiy [Sun, 14 Apr 2019 18:00:12 +0000 (21:00 +0300)]
[DPNHPAST] Import dpnhpast.dll from Wine (Staging) 4.5
Jared Smudde [Tue, 23 Apr 2019 05:47:02 +0000 (00:47 -0500)]
[BROWSEUI] Enable the Disconnect Network Drive menu item. (#1522)
CORE-13516, CORE-13518
Jared Smudde [Tue, 23 Apr 2019 05:46:28 +0000 (00:46 -0500)]
[MPR] Implement the function WNetDisconnectDialog(). (#1522)
CORE-13516, CORE-13518
Jared Smudde [Tue, 23 Apr 2019 05:45:49 +0000 (00:45 -0500)]
[NETPLWIZ] Implement the Disconnect Network Drive dialog. (#1522)
CORE-13516, CORE-13518
Katayama Hirofumi MZ [Wed, 24 Apr 2019 01:44:44 +0000 (10:44 +0900)]
[APPWIZ.CPL] Set a default shortcut-link description (#1520)
CORE-15511
Hermès Bélusca-Maïto [Wed, 24 Apr 2019 01:41:41 +0000 (03:41 +0200)]
[SHELL32] Make the new-item menu work (aka. make it dynamic) when the .lnk handler doesn't have any ShellNew entry.
Hermès Bélusca-Maïto [Wed, 24 Apr 2019 01:36:27 +0000 (03:36 +0200)]
[SHELL32] Code formatting/style/whitespace fix + fix two memory leaks in failure paths of CNewMenu::LoadItem().
Katayama Hirofumi MZ [Tue, 23 Apr 2019 01:48:34 +0000 (10:48 +0900)]
[SHELL32] Implement 'New Link' (Retrial of #1510), CORE-15511 (#1518)
Correctly create cache about ".lnk" and handling in the member functions.
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
Katayama Hirofumi MZ [Tue, 23 Apr 2019 05:25:18 +0000 (14:25 +0900)]
[MSPAINT] Set default extension .bmp (#1515)
Set the default extension of mspaint to .bmp. CORE-7114
Eric Kohl [Mon, 22 Apr 2019 22:12:23 +0000 (00:12 +0200)]
[STOBJECT] Store the "Show x icon in the taskbar" setting for the hotplug, power and volume icons.
CORE-12365
CORE-12972
CORE-15234
Eric Kohl [Mon, 22 Apr 2019 22:09:10 +0000 (00:09 +0200)]
[POWERCFG] Fix indentation and coding style. No code changes!
Eric Kohl [Mon, 22 Apr 2019 22:04:01 +0000 (00:04 +0200)]
[STOBJECT][MMSYS][POWERCFG] Store the "Show x icon in the taskbar" setting for the hotplug, power and volume icons.
CORE-12365
CORE-12972
CORE-15234
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 19:25:41 +0000 (21:25 +0200)]
[EXPLORER] Minor cleanup/comment fixes.
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 19:09:10 +0000 (21:09 +0200)]
[NTOS:CM] In CmpParseKey(), do not assert but instead correctly return failure if CmpHandleExitNode() doesn't return a valid node, or CmpCreateKeyControlBlock() fails.
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 17:41:19 +0000 (19:41 +0200)]
[NTOS] Fix typos.
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 17:33:20 +0000 (19:33 +0200)]
[FREELDR] Add some missing UiDrawBackdrop() calls.
Hermès Bélusca-Maïto [Mon, 22 Apr 2019 16:29:43 +0000 (18:29 +0200)]
[OPENGL32] Fix the order of the specified callbacks for the DrvSetCallbackProcs() call.
References:
- https://github.com/OpenSWR/openswr/blob/master/ogldriver/wgl.cpp
- https://github.com/Igalia/mesa/blob/master/src/gallium/state_trackers/wgl/stw_icd.h
- "OpenGL Installable Client Driver, Version 1.101 -- Reference Guide" by Microsoft Corporation.
Bernhard Feichtinger [Sat, 13 Apr 2019 21:24:21 +0000 (23:24 +0200)]
[OPENGL32] Fix usage of TEB members.
Bernhard Feichtinger [Sat, 13 Apr 2019 21:33:09 +0000 (23:33 +0200)]
[NTOS][USERSRV] Silence noisy debug output.
Mark Jansen [Mon, 22 Apr 2019 14:24:59 +0000 (16:24 +0200)]
[SYSSETUP] Fix a broken DPRINT
Thanks to Thomas for spotting it.
Eric Kohl [Mon, 22 Apr 2019 08:36:17 +0000 (10:36 +0200)]
[STOBJECT] Mark hotplug, power and volume context menu default items
Katayama Hirofumi MZ [Mon, 22 Apr 2019 05:20:42 +0000 (14:20 +0900)]
[GDI32_APITEST] Fix build s/IGNORE/NO_CHECK/
Katayama Hirofumi MZ [Mon, 22 Apr 2019 04:48:57 +0000 (13:48 +0900)]
[GDI32_APITEST] Rewrite DPtoLP testcase (#1509)
Sorry, I had to rewrite gdi32!DPtoLP testcase. ROSTESTS-319
Katayama Hirofumi MZ [Mon, 22 Apr 2019 04:48:14 +0000 (13:48 +0900)]
[GDI32_APITEST] Rewrite LPtoDP testcase (#1508)
Sorry, I had to rewrite gdi32!LPtoDP testcase. ROSTESTS-319
Eric Kohl [Sun, 21 Apr 2019 22:41:24 +0000 (00:41 +0200)]
[POWRPROF] EnumPwrSchemes: Fix callback string lengths
The callback routine should get the real lengths of the name and description strings in bytes instead of the buffer sizes in characters. This fixes buffer overflows in powercfg.cpl.
Serge Gautherie [Sun, 21 Apr 2019 19:15:11 +0000 (21:15 +0200)]
[ACGENRAL] Fix MSVC warning C4090 "different 'const' qualifiers" about a ShimLib_ShimFree() call (#1506)
Addendum to
007cc5cd.
CORE-7538
Katayama Hirofumi MZ [Sun, 21 Apr 2019 14:47:10 +0000 (23:47 +0900)]
[BOOTDATA] Add registry keys for ComDlg32 (#1511)
Add registry keys for ComDlg32. CORE-7114
Eric Kohl [Sat, 20 Apr 2019 21:26:57 +0000 (23:26 +0200)]
[NTOSKRNL] Revert
f71588ff as it seems to break the tests
Eric Kohl [Sat, 20 Apr 2019 20:48:38 +0000 (22:48 +0200)]
[POWERCFG] Use a list of power schemes (power policy, id, name and description) rather than a bare array of power policies. This will simplify adding and deleting schemes quite a lot.
Eric Kohl [Sat, 20 Apr 2019 12:43:16 +0000 (14:43 +0200)]
[POWERCFG] Fix the undue change of monitor switch off time
CORE-12495
Eric Kohl [Sat, 20 Apr 2019 12:36:22 +0000 (14:36 +0200)]
[POWERCFG] Fix coding style and indentation. No code changes!
Pierre Schweitzer [Sat, 20 Apr 2019 09:31:59 +0000 (11:31 +0200)]
[NTOSKRNL] Drop the useless Timestamp field
Pierre Schweitzer [Sat, 20 Apr 2019 09:24:54 +0000 (11:24 +0200)]
[GDI32] Reduce verbosity on debug builds
Pierre Schweitzer [Sat, 20 Apr 2019 09:23:35 +0000 (11:23 +0200)]
[NTOSKRNL] Don't set VACB dirty on release if already dirty
CORE-15954
Katayama Hirofumi MZ [Fri, 19 Apr 2019 23:35:39 +0000 (08:35 +0900)]
[ATL][ATLTEST] Adapt to RATL and improvements (#1501)
- Modify atldef.h for non-ReactOS environments.
- Update ATL testcase project files (from v120_xp to v140_xp).
- #define HAVE_APITEST and use it.
- s/NULL/0/
Hervé Poussineau [Fri, 19 Apr 2019 20:40:32 +0000 (22:40 +0200)]
[HIDCLASS] Implement IOCTL_HID_GET_FEATURE/IOCTL_HID_SET_FEATURE
Eric Kohl [Fri, 19 Apr 2019 20:30:46 +0000 (22:30 +0200)]
[KERNEL32] GetSystemPowerStatus(): Set the BATTERY_FLAG_CRITICAL flag if the battery life gets lower than 5 percent.
Eric Kohl [Fri, 19 Apr 2019 20:28:11 +0000 (22:28 +0200)]
[KERNEL32] GetSystemPowerStatus(): Fix coding style. No code changes!
Eric Kohl [Fri, 19 Apr 2019 19:50:13 +0000 (21:50 +0200)]
[STOBJECT] Improvements to the power notification icon
- Use GetSystemPowerStatus() instead of querying each battery.
- Add an ugly AC power icon. Should be fixed or replaced.
- Display AC power, battery charging, battery depleting and error cases. The AC power case was missing.
- Update some strings because we are no longer using float for the charge percentage.
@Turkish translators: Please check and update the translation of IDS_PWR_CHARGING!
Andreas Maier [Thu, 22 Nov 2018 21:15:55 +0000 (22:15 +0100)]
[DBGHELP] SymFromAddr: Handle 2 or more symbols at the same address correct.
There could be more then 2 symbols at the same addr.
Adjust function to handle that case correct.
Andreas Maier [Thu, 22 Nov 2018 21:14:24 +0000 (22:14 +0100)]
[DBGHELP] Set LastError for SymGetModuleBase-calls to ERROR_MOD_NOT_FOUND.
Correct last error in module_find_by_addr.
Andreas Maier [Thu, 22 Nov 2018 20:47:45 +0000 (21:47 +0100)]
[DBGHELP] set correct values in symt_fill_sym_info (SYMBOL_INFO).
* symtype: set to SymPdb not SymCv (may be for old pdb-files pre VS 6.0)
* flags: return SYMFLAG_PUBLIC_CODE for SymTagPublicSymbol if its a function.
* flags: do not return SYMFLAG_FUNCTION for SymTagFuncion.
Andreas Maier [Thu, 22 Nov 2018 20:34:14 +0000 (21:34 +0100)]
[DBGHELP] Add SYMFLAG_- and SYMTYPE_-defines.
Andreas Maier [Thu, 22 Nov 2018 20:27:48 +0000 (21:27 +0100)]
[DBGHELP] use correct record in codeview_snarf_public.
Use public_vx iststead of data_vx for public symbols.
Andreas Maier [Sat, 3 Nov 2018 20:26:48 +0000 (21:26 +0100)]
[DBGHELP] search for debugfiles in modulepath too.
Debug symbols (like PDB, ...) could not be found if the direcory of
the module and application differs. Applying this patch they will
be found.
Dbghelp searches the module path too. (See MS docs).
Serge Gautherie [Fri, 19 Apr 2019 13:39:16 +0000 (15:39 +0200)]
[CMAKE] msvc.cmake: Remove now redundant '/we4028' special case
Addendum to
545a2c79367e1457e4bc7ac14d3c0f840c7e063c.
CORE-7538
Katayama Hirofumi MZ [Fri, 19 Apr 2019 14:39:18 +0000 (23:39 +0900)]
[APPVEYOR] Enable fast_finish (#1494)
It stops the remaining jobs if any error happened. It becomes less time for waiting for building.
Serge Gautherie [Fri, 19 Apr 2019 13:12:16 +0000 (15:12 +0200)]
[BOOTDATA] AHKAppTests.cmd: Fix 'media' typo (#1502)
Addendum to
df2a8c4. s/media/medium/
Mark Jansen [Thu, 18 Apr 2019 19:17:00 +0000 (21:17 +0200)]
[NTOBJSHEX] Reorder include files in the precompiled header
Mark Jansen [Thu, 18 Apr 2019 17:21:25 +0000 (19:21 +0200)]
[APPHELP] Fix warnings
Mark Jansen [Thu, 18 Apr 2019 17:21:00 +0000 (19:21 +0200)]
[RSHELL] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Tue, 16 Apr 2019 21:04:07 +0000 (23:04 +0200)]
[SHELL32_APITEST] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Tue, 16 Apr 2019 21:03:42 +0000 (23:03 +0200)]
[MSGINA_APITEST] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Tue, 16 Apr 2019 21:03:22 +0000 (23:03 +0200)]
[NETREG] Use exceptions with stl
Mark Jansen [Tue, 16 Apr 2019 20:53:56 +0000 (22:53 +0200)]
[MSGINA] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Tue, 16 Apr 2019 20:51:34 +0000 (22:51 +0200)]
[NTOBJSHEX] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Tue, 16 Apr 2019 20:49:55 +0000 (22:49 +0200)]
[APPHELP_APITEST] Disable exceptions in atl when compiling without exceptions
Mark Jansen [Tue, 16 Apr 2019 20:39:36 +0000 (22:39 +0200)]
[SHELL32] Use the same definitions for shell32 and it's static libs
Mark Jansen [Sat, 6 Apr 2019 20:37:13 +0000 (22:37 +0200)]
[ATL] Retire atlnew
Mark Jansen [Fri, 5 Apr 2019 21:22:55 +0000 (23:22 +0200)]
[ATL][ATL_APITEST] Add test + implementation for CAtlFileMapping
Pierre Schweitzer [Thu, 18 Apr 2019 06:14:41 +0000 (08:14 +0200)]
[NTOSKRNL] Drop the no longer needed Dirty field
CORE-15954
Pierre Schweitzer [Wed, 17 Apr 2019 20:23:57 +0000 (22:23 +0200)]
[NTOSKRNL] Don't mark VACB dirty on unpin
This could happen if BCB was marked dirty previously.
Marking VACB dirty on unpin could lead to a double write of
the VACB, even if clean.
Indeed, now that setting BCB dirty leads to marking VACB
dirty, the VACB can be flushed in between by the lazy-writer.
The BCB state is not reset on VACB flush, contrary to the VACB state.
Thus, on unpin even if the VACB was already flushed, we were
setting back the dirty state, leading the VACB to be flushed again.
This could bring a small performance downgrade. Though it remains
limited since this is mostly used for FS metadata.
Possibly it could lead to metadata corruption, but this is likely
less possible.
CORE-15954
jimtabor [Wed, 17 Apr 2019 19:43:24 +0000 (14:43 -0500)]
[NtGDI] Update Region code
Wine Sync/Port and update for Regions. See CORE-15906.
jimtabor [Wed, 17 Apr 2019 19:09:58 +0000 (14:09 -0500)]
[GDI] Fixup attribute support for Regions
Start to fix CORE-13817 when GDI batch is turn on for SelectClipRgn.
Eric Kohl [Tue, 16 Apr 2019 18:14:36 +0000 (20:14 +0200)]
[NTOSKRNL] NtPowerInformation: Report an AC powered machine by default.
Pierre Schweitzer [Tue, 16 Apr 2019 06:25:09 +0000 (08:25 +0200)]
[KMTESTS:CC] Add tests for CcCopyWrite
CORE-15384
Katayama Hirofumi MZ [Tue, 16 Apr 2019 12:41:58 +0000 (21:41 +0900)]
[KERNEL32] Implement InvalidateNLSCache
Katayama Hirofumi MZ [Tue, 16 Apr 2019 11:57:02 +0000 (20:57 +0900)]
[KERNEL32] Fix handle leak and caching (follow-up of
7e38267)
Katayama Hirofumi MZ [Tue, 16 Apr 2019 02:10:00 +0000 (11:10 +0900)]
[KERNEL32] Era first year is GANNEN
Katayama Hirofumi MZ [Tue, 16 Apr 2019 01:38:51 +0000 (10:38 +0900)]
[BOOTDATA] Improve AHKAppTests.cmd (follow-up of #1476)
Thomas Faber [Mon, 4 Mar 2019 19:36:32 +0000 (20:36 +0100)]
[USBHUB_NEW] Support NULL HubExtension in USBH_PdoRemoveDevice.
Device removal can happen multiple times for PDOs.
Thomas Faber [Mon, 1 Apr 2019 12:04:56 +0000 (14:04 +0200)]
[USBHUB_NEW] Fix inverted check in USBH_RestoreDevice.
This allows re-enabling a disabled device.
Thomas Faber [Sun, 7 Apr 2019 09:54:43 +0000 (11:54 +0200)]
[USBCCGP] Allow unconfiguring the device in USBCCGP_PDOSelectConfiguration.
Fixes device removal for USB audio devices.
Thomas Faber [Sun, 3 Mar 2019 17:24:44 +0000 (18:24 +0100)]
[USBCCGP] Do not try to unconfigure a device that is not configured.
Fixes handling failed IRP_MN_START_DEVICE.
Thomas Faber [Sun, 14 Apr 2019 12:25:35 +0000 (14:25 +0200)]
[COMCTL32] Remove an unnecessary include.
Hermès Bélusca-Maïto [Sat, 13 Apr 2019 23:25:35 +0000 (01:25 +0200)]
[BOOTDATA] Remove stray value.
Hermès Bélusca-Maïto [Sat, 13 Apr 2019 23:19:03 +0000 (01:19 +0200)]
[WIN32SS:NTGDI] IntEscapeMatrix(): Use FreeType trigonometric functions instead of CRT ones.
Hermès Bélusca-Maïto [Sat, 13 Apr 2019 23:17:15 +0000 (01:17 +0200)]
[GDI32] Do not 'hard-assert' during the font-unit-test.
Hermès Bélusca-Maïto [Sat, 13 Apr 2019 16:24:01 +0000 (18:24 +0200)]
[3RDPARTY] Addendum to
146096cd: Make some warnings non-fatal.
Jared Smudde [Fri, 12 Apr 2019 23:20:59 +0000 (18:20 -0500)]
[OPENGLCFG] Edit the applet name so it uses the same capitalization scheme as the other Control Panel applets.
Jared Smudde [Fri, 12 Apr 2019 23:47:31 +0000 (18:47 -0500)]
[RAPPS] Fix blurry Theme category icon.
Oleg Dubinskiy [Sat, 13 Apr 2019 15:07:02 +0000 (18:07 +0300)]
[DIRECTX] Fix typos in readme.txt (#1498)
See also PR #687.
Thomas Faber [Mon, 8 Apr 2019 05:12:20 +0000 (07:12 +0200)]
[CMAKE] Don't use the PCH for generated files.
The PCH must be used with the same compiler flags it was generated with,
so don't use it for files that use modified flags.
Timo Kreuzer [Tue, 27 Feb 2018 21:00:40 +0000 (22:00 +0100)]
[CMAKE] Add 3 more critical warnings for MSVC
- C4311: pointer truncation from '<pointer>' to '<integer>'
- C4312: conversion from '<integer>' to '<pointer>' of greater size
- C4133: incompatible types - from '<x> *' to '<y> *'
- C4028: formal parameter different from declaration
Timo Kreuzer [Mon, 1 Apr 2019 15:55:03 +0000 (17:55 +0200)]
[3RDPARTY] Make some warnings non-fatal
Timo Kreuzer [Sun, 7 Apr 2019 16:17:18 +0000 (18:17 +0200)]
[DBGHELP] Fix 64 bit issue
Timo Kreuzer [Mon, 1 Apr 2019 12:24:05 +0000 (14:24 +0200)]
[REACTOS] Fix misc 64 bit issues
Timo Kreuzer [Fri, 4 Jan 2019 13:48:25 +0000 (14:48 +0100)]
[TREELIST] Fix 64 bit warnings
Katayama Hirofumi MZ [Thu, 11 Apr 2019 22:56:04 +0000 (07:56 +0900)]
[WIN32SS][NTUSER] Fix message time (#1259)
Fix CORE-15565 and make #1245 GetMessageTime testcase successful. CORE-15565
- Erase MsqCalculateMessageTime function.
- Use (DWORD)EngGetTickCount() instead.
- Ghosting is temporarily disabled.
Katayama Hirofumi MZ [Thu, 11 Apr 2019 09:23:32 +0000 (18:23 +0900)]
[WIN32SS][NTGDI] Delete unnecessary (ULONG) cast CORE-15755
Katayama Hirofumi MZ [Thu, 11 Apr 2019 08:57:57 +0000 (17:57 +0900)]
[GDI32][NTGDI] Avoid integer overflow (follow-up of #1492) (#1495)
Follow up of #1492. CORE-15755
- Use RtlULongMult function to check integer overflows.
Katayama Hirofumi MZ [Thu, 11 Apr 2019 02:46:52 +0000 (11:46 +0900)]
[GDI32][NTGDI][SETUP] Fix font enumeration part 2 (#1492)
Eliminate some bugs about font enumeration. CORE-15755
- Add "Microsoft Sans Serif" font substitution.
- Fix and improve the treatment of the nominal font names.
- Split IntGetFontFamilyInfo function from NtGdiGetFontFamilyInfo.
- Add DoFontSystemUnittest function for font system unittest to GDI32.
- Call DoFontSystemUnittest function at CreateFontIndirectW first call.
jimtabor [Thu, 11 Apr 2019 01:52:01 +0000 (20:52 -0500)]
[NtUser] Fix Theme Non Client Painting.
See CORE-7166 & CORE-15934.
jimtabor [Thu, 11 Apr 2019 00:24:50 +0000 (19:24 -0500)]
[DDraw] Fix DxDiag tests.
After the DC work is done while before releasing the DC flush the GDI
batch.
See CORE-15905. Someone may need to notify wine about this change.
Eric Kohl [Tue, 9 Apr 2019 19:44:03 +0000 (21:44 +0200)]
[NET][MC] Move remaining generic strings from net.exe to netmsg.dll.
Translators, please check the translations!
Katayama Hirofumi MZ [Tue, 9 Apr 2019 08:39:42 +0000 (17:39 +0900)]
[GDI32] Improve IntFontFamilyListUnique function (#1491)
Make gdi32!IntFontFamilyListUnique function std::unique compatible. Previous code didn't set the first entry correctly. CORE-15785