reactos.git
3 years ago[NET]
Pierre Schweitzer [Tue, 2 Aug 2016 10:10:25 +0000 (10:10 +0000)]
[NET]
Implement the "net use" usage of the net command.
This allows connecting remote resources to local system with assigning them a local name, to enumerate such connected resources and to delete them.

This obsoletes the hackssign application.

The implementation is a bit... raw. It is mainly here to demonstrate what's doable in ReactOS now. And to help using features we were lacking up to now.
For instance, you can make use of 'net use * \\vmware-host\Shared Folders\{YOURSHARE}' to assign a local letter to your VMware shared folders.

ROSAPPS-303

svn path=/trunk/; revision=72088

3 years ago[MPR]
Pierre Schweitzer [Tue, 2 Aug 2016 10:04:19 +0000 (10:04 +0000)]
[MPR]
Implement connected resources enumeration
To be sent upstream.

Patch 6/6

CORE-11757
ROSAPPS-303

svn path=/trunk/; revision=72087

3 years ago[MPR]
Pierre Schweitzer [Tue, 2 Aug 2016 09:57:24 +0000 (09:57 +0000)]
[MPR]
Set the CONNECT_LOCALDRIVE on successful local redirection
To be sent upstream.

Patch 5/6

CORE-11757
ROSAPPS-303

svn path=/trunk/; revision=72086

3 years ago[MPR]
Pierre Schweitzer [Tue, 2 Aug 2016 09:54:51 +0000 (09:54 +0000)]
[MPR]
Implement WNetCancelConnectionA(), WNetCancelConnectionW(), WNetCancelConnection2A()
Already sent upstream.

Patch 4/6

CORE-11757
ROSAPPS-303

svn path=/trunk/; revision=72085

3 years ago[MPR]
Pierre Schweitzer [Tue, 2 Aug 2016 09:53:54 +0000 (09:53 +0000)]
[MPR]
Implement WNetCancelConnection2W()
Already sent upstream.

Patch 3/6

CORE-11757
ROSAPPS-303

svn path=/trunk/; revision=72084

3 years ago[MPR]
Pierre Schweitzer [Tue, 2 Aug 2016 09:51:09 +0000 (09:51 +0000)]
[MPR]
Implement provider automatic selection for WNetUseConnection. That means you don't need anylonger to provider the network provider handling the remote name to establish a connection to the resource.
Already sent upstream.

Patch 2/6

CORE-11757
ROSAPPS-303

svn path=/trunk/; revision=72083

3 years ago[MPR]
Pierre Schweitzer [Tue, 2 Aug 2016 09:49:20 +0000 (09:49 +0000)]
[MPR]
Time to react (again!).

Implement automatic local name redirection for new connection. This implements the behavior of the CONNECT_REDIRECT flag of WNetUseConnection.
Already sent upstream.

Patch 1/6

CORE-11757
ROSAPPS-303

svn path=/trunk/; revision=72082

3 years ago[TRANSLATIONS] Russian translation update by Sergey Stopkin and co, with some fixes...
Amine Khaldi [Tue, 2 Aug 2016 09:16:16 +0000 (09:16 +0000)]
[TRANSLATIONS] Russian translation update by Sergey Stopkin and co, with some fixes by me. CORE-11752

svn path=/trunk/; revision=72081

3 years ago[NtUser]
James Tabor [Tue, 2 Aug 2016 04:05:16 +0000 (04:05 +0000)]
[NtUser]
- Fix crash while mouse cursor is moving over stress test window (RegEdit). This fixes VLC too. Tested SeaMonkey and it did not crash. See CORE-9169 and CORE-9836.

svn path=/trunk/; revision=72080

3 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Mon, 1 Aug 2016 23:29:55 +0000 (23:29 +0000)]
[EVENTVWR]
- Reorganize the header inclusions; add a PCH.
- Transform the event details dialog into a control that can be embedded:
  * in a resizable dialog,
  * or in a pane below the window listing the events.
CORE-11637

svn path=/trunk/; revision=72079

3 years ago[NOTEPAD]: Fix danish menu shortcuts.
Hermès Bélusca-Maïto [Mon, 1 Aug 2016 23:01:58 +0000 (23:01 +0000)]
[NOTEPAD]: Fix danish menu shortcuts.

svn path=/trunk/; revision=72078

3 years ago[KDGDB]
Jérôme Gardou [Mon, 1 Aug 2016 22:16:58 +0000 (22:16 +0000)]
[KDGDB]
 - Turn this thing into something useful
   - Pretend we are only one process to GDB (making it a kernel-only debugger...) until the GDB team sorts this out
   - This is a kernel debugger stub you know. You didn't seriously pretend that recursive functions would be fine, did you ?
[NTOS:KD64]
 - Fix build
Pix or it din't happen : https://jira.reactos.org/secure/attachment/36322/source_level_debugging_ros.png

svn path=/trunk/; revision=72077

3 years ago[NtUser]
James Tabor [Mon, 1 Aug 2016 19:13:48 +0000 (19:13 +0000)]
[NtUser]
- Fix a recursion issue while processing posted messages. Related to CORE-10471. Dedicated to Thomas Faber for Free before Use testing.
- Pass extra information along with posted messages.
- Trigger an event when cursor position has changed.

svn path=/trunk/; revision=72076

3 years ago- Remove trace.
James Tabor [Mon, 1 Aug 2016 18:15:45 +0000 (18:15 +0000)]
- Remove trace.

svn path=/trunk/; revision=72075

3 years ago[User32]
James Tabor [Mon, 1 Aug 2016 18:15:00 +0000 (18:15 +0000)]
[User32]
- Use correct value for win:test_mdi. Use post instead of send, fix message sequence.
- Minor code changes.

svn path=/trunk/; revision=72074

3 years ago[SHELL32] remove obsolete FIXME. was fixed in r68015
Christoph von Wittich [Mon, 1 Aug 2016 14:37:27 +0000 (14:37 +0000)]
[SHELL32] remove obsolete FIXME. was fixed in r68015

svn path=/trunk/; revision=72073

3 years ago[USERENV]
Dmitry Chapyshev [Mon, 1 Aug 2016 14:26:12 +0000 (14:26 +0000)]
[USERENV]
- Create separate function for setup session manager variables
- Fixed a regression in msi package winetest after r72066

svn path=/trunk/; revision=72072

3 years ago[VFATLIB]
Pierre Schweitzer [Mon, 1 Aug 2016 12:05:13 +0000 (12:05 +0000)]
[VFATLIB]
Don't leak memory

svn path=/trunk/; revision=72071

3 years ago[SHELL32]
Dmitry Chapyshev [Mon, 1 Aug 2016 11:29:01 +0000 (11:29 +0000)]
[SHELL32]
- Fixed memory leak

[DNSLIB]
- Fixed uninitialized variable

[USERENV]
- Fixed typo

svn path=/trunk/; revision=72070

3 years ago[NTFS]
Pierre Schweitzer [Mon, 1 Aug 2016 06:14:45 +0000 (06:14 +0000)]
[NTFS]
Don't attempt to read beyond stream size.
Patch by Trevor Thompson.

CORE-11707

svn path=/trunk/; revision=72067

3 years ago[USERENV]
Dmitry Chapyshev [Sun, 31 Jul 2016 13:46:23 +0000 (13:46 +0000)]
[USERENV]
- Implement GetUserSid() (based on GetUserSidFromToken())
- Remove GetUserSidFromToken() and use new exported function
- Move SID functions to sid.c
- SetUserEnvironmentVariable should not fail, if can't get the short path. Instead, a long path
- Setup environment variables from Session Manager

* This fixes all winetests for userenv.dll (+20 passed tests)

svn path=/trunk/; revision=72066

3 years ago[NtUser]
James Tabor [Sun, 31 Jul 2016 13:00:27 +0000 (13:00 +0000)]
[NtUser]
- Remove unused data.

svn path=/trunk/; revision=72065

3 years ago[BROWSEUI] Correct the 'Is this legal' url as suggested by Ken Rochard. Also rewrite...
Mark Jansen [Sun, 31 Jul 2016 11:59:15 +0000 (11:59 +0000)]
[BROWSEUI] Correct the 'Is this legal' url as suggested by Ken Rochard. Also rewrite the function to remove todo's, and make it localizable. CORE-11721 #resolve #comment Thanks!

svn path=/trunk/; revision=72063

3 years ago[REISERFS]
Pierre Schweitzer [Sun, 31 Jul 2016 10:13:39 +0000 (10:13 +0000)]
[REISERFS]
Reduce verbosity

svn path=/trunk/; revision=72062

3 years ago[ATL][ATL_APITEST] Implement / Improve CString, based upon the code that was already...
Mark Jansen [Sat, 30 Jul 2016 19:07:43 +0000 (19:07 +0000)]
[ATL][ATL_APITEST] Implement / Improve CString, based upon the code that was already there. CORE-11579 #resolve
Add code + tests for:
Conversion of A->W and W->A, equality operators, MakeLower, MakeUpper, Find, FindOneOf, ReverseFind, Compare, Mid, Left, Right, Format, Replace, Trim, TrimLeft, TrimRight.

svn path=/trunk/; revision=72061

3 years ago[SCSIPORT]: Port Dmitry's fix from r72059 to our scsiport driver too. I'm wondering...
Hermès Bélusca-Maïto [Sat, 30 Jul 2016 16:20:41 +0000 (16:20 +0000)]
[SCSIPORT]: Port Dmitry's fix from r72059 to our scsiport driver too. I'm wondering how "difficult" it would be to have some kind of scsiport library to be shared between the driver and freeldr's.

svn path=/trunk/; revision=72060

3 years ago[WHOAMI]
Dmitry Chapyshev [Sat, 30 Jul 2016 16:00:10 +0000 (16:00 +0000)]
[WHOAMI]
[ARP]
[TRACERT]
- Incorrect to compare the variable of BOOL type with TRUE. Any non-zero value is considered to be "true".

[FREELDR]
- Variable is assigned values twice
- The 'strlen' function was called multiple times inside the body of a loop
- It is inefficient to identify an empty string by using 'strlen(str) > 0' construct. A more efficient way is to check: str[0] != 0

[NTOBJSHEX]
[SLAYER]
[CMICONTROL]
- It is inefficient to identify an empty string by using 'strlen(str) > 0' construct. A more efficient way is to check: str[0] != 0

[SHELL32]
- There is no sense in testing the pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error
- Verifying that a pointer value is not NULL is not required. The 'if (ptr != NULL)' check can be removed
- Fix copy-paste error in CMenuFocusManager::PlaceHooks()

[SRCLIENT]
- Remove unneeded check. A part of conditional expression is always false.

[DISK]
[ATAPI]
- Variable is assigned values twice

* All bugs found by PVS-Studio

svn path=/trunk/; revision=72059

3 years ago[SOLITAIRE]
Eric Kohl [Sat, 30 Jul 2016 14:09:58 +0000 (14:09 +0000)]
[SOLITAIRE]
Add Portuguese/Brazillian translation.
Patch by Lucas Raziel.
CORE-11665 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=72058

3 years ago[INF]
Eric Kohl [Sat, 30 Jul 2016 13:39:56 +0000 (13:39 +0000)]
[INF]
Update russian translation of inf strings.
Patch by amber.
CORE-11604 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=72057

3 years ago[FASTFAT]
Pierre Schweitzer [Sat, 30 Jul 2016 12:53:09 +0000 (12:53 +0000)]
[FASTFAT]
Fix a FIXME

svn path=/trunk/; revision=72056

3 years ago[BROWSEUI]
Giannis Adamopoulos [Sat, 30 Jul 2016 12:47:39 +0000 (12:47 +0000)]
[BROWSEUI]
- Move handling of DISPID_NAVIGATECOMPLETE2 event from CAddressBand to CAddressEditBox as the todo comments say it should be.
- Remove the todo entries that are complete.
- Remove IDispatch from CAddressBand as it is not really needed. Now CAddressBand takes care only of positioning and handling the button while CAddressEditBox does all the parsing and interaction with the browser.

svn path=/trunk/; revision=72055

3 years ago[NtUser]
James Tabor [Sat, 30 Jul 2016 12:32:28 +0000 (12:32 +0000)]
[NtUser]
- Fix hang while inputting mouse message. Fix CORE-9998.

svn path=/trunk/; revision=72054

3 years ago[BROWSEUI]
Giannis Adamopoulos [Sat, 30 Jul 2016 11:53:16 +0000 (11:53 +0000)]
[BROWSEUI]
- Use the _CreateInstance postfix for all functions that instantiate a class.
- Move the the CreateInstance functions of the exported classes to browseui.h where we can select uniformly which built in classes we use.

svn path=/trunk/; revision=72053

3 years ago[USER32]
Dmitry Chapyshev [Sat, 30 Jul 2016 11:31:33 +0000 (11:31 +0000)]
[USER32]
- Add missing NULL-pointer checkes in rect functions
- Small coding-style fixes

svn path=/trunk/; revision=72052

3 years ago[PCIX]
Hermès Bélusca-Maïto [Fri, 29 Jul 2016 13:44:37 +0000 (13:44 +0000)]
[PCIX]
Fix Device_SaveCurrentSettings: do not reference BarArray too soon if the index is out of bounds (in that case it means we are handling a ROM "BAR").
CID 716153, reported by Victor Martinez Calvo.
CORE-11215 #resolve

svn path=/trunk/; revision=72050

3 years ago[XDK]
Hermès Bélusca-Maïto [Fri, 29 Jul 2016 13:17:58 +0000 (13:17 +0000)]
[XDK]
- Move the PCI_COMMON_HEADER_LAYOUT next to the structures that use it.
- Add IRP flags description comments.

svn path=/trunk/; revision=72049

3 years agoFix build.
Giannis Adamopoulos [Fri, 29 Jul 2016 12:59:16 +0000 (12:59 +0000)]
Fix build.

svn path=/trunk/; revision=72048

3 years ago[SHELL32]
Giannis Adamopoulos [Fri, 29 Jul 2016 12:56:06 +0000 (12:56 +0000)]
[SHELL32]
- Factor CFSDropTarget out of CFSFolder.
- For now their code is mixed (no code was moved), until we decide where exactly is should be kept.

svn path=/trunk/; revision=72047

3 years ago[BROWSEUI] - explorerband: get the caption string from resource file instead of hardc...
Robert Naumann [Fri, 29 Jul 2016 12:05:06 +0000 (12:05 +0000)]
[BROWSEUI] - explorerband: get the caption string from resource file instead of hardcoding it

svn path=/trunk/; revision=72046

3 years ago[SHELL32]
Giannis Adamopoulos [Fri, 29 Jul 2016 12:03:20 +0000 (12:03 +0000)]
[SHELL32]
- CDefView: Add a missing error check.
CORE-11594

svn path=/trunk/; revision=72045

3 years ago[EXT2]
Pierre Schweitzer [Fri, 29 Jul 2016 11:54:08 +0000 (11:54 +0000)]
[EXT2]
Reduce driver verbosity

svn path=/trunk/; revision=72044

3 years ago[BROWSEUI]
Giannis Adamopoulos [Fri, 29 Jul 2016 10:38:22 +0000 (10:38 +0000)]
[BROWSEUI]
- CExplorerBand: TranslateAcceleratorIO should return S_FALSE when it doesn't process the message in order to let other components process it.
CORE-11709

svn path=/trunk/; revision=72043

3 years ago[EXT2]
Pierre Schweitzer [Fri, 29 Jul 2016 10:29:16 +0000 (10:29 +0000)]
[EXT2]
Upgrade the driver to release 0.68.

CORE-11714

svn path=/trunk/; revision=72042

3 years ago[SHELLL32]
Giannis Adamopoulos [Fri, 29 Jul 2016 06:21:11 +0000 (06:21 +0000)]
[SHELLL32]
- Split GenericExtractIcon_CreateInstance into CGuidItemExtractIcon_CreateInstance, CFSExtractIcon_CreateInstance and CDrivesExtractIcon_CreateInstance.

svn path=/trunk/; revision=72041

3 years ago[INF]
Sylvain Petreolle [Thu, 28 Jul 2016 17:12:31 +0000 (17:12 +0000)]
[INF]
Add data for generic container devices.

svn path=/trunk/; revision=72036

3 years ago[SHELL32_APITEST]
Thomas Faber [Thu, 28 Jul 2016 15:25:35 +0000 (15:25 +0000)]
[SHELL32_APITEST]
- Add a test for CShellLink::GetDescription/SetDescription
CORE-5272

svn path=/trunk/; revision=72035

3 years ago[SHELL32] apply similar fixes to SetWorkingDirectory, SetArguments, SetIconLocation...
Christoph von Wittich [Thu, 28 Jul 2016 15:24:44 +0000 (15:24 +0000)]
[SHELL32] apply similar fixes to SetWorkingDirectory, SetArguments, SetIconLocation and SetRelativePath

svn path=/trunk/; revision=72034

3 years ago[SHELL32]check for NULL pointer in CShellLink::SetDescription. patch by Joachim Henze...
Christoph von Wittich [Thu, 28 Jul 2016 15:12:23 +0000 (15:12 +0000)]
[SHELL32]check for NULL pointer in CShellLink::SetDescription. patch by Joachim Henze. fixes Opera 12 installer CORE-5272

svn path=/trunk/; revision=72033

3 years ago[HIVECLS] Add support for RDP files. Patch by Jared Smudde. CORE-11655
Robert Naumann [Thu, 28 Jul 2016 13:27:33 +0000 (13:27 +0000)]
[HIVECLS] Add support for RDP files. Patch by Jared Smudde. CORE-11655

svn path=/trunk/; revision=72032

3 years ago[DOC]
Pierre Schweitzer [Thu, 28 Jul 2016 07:39:37 +0000 (07:39 +0000)]
[DOC]
Mark BTRFS as synced

svn path=/trunk/; revision=72031

3 years ago[CONSRV]
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 23:30:53 +0000 (23:30 +0000)]
[CONSRV]
- Do not hardcode the values of some flags used with GetKeyState.
- Rework a bit the 'OnScroll' function.
- Implement mouse scrolling the console.
CORE-9900 #resolve
CORE-8394
- In mouse selection mode, allow the user to enlarge the current selection area by pressing the SHIFT key together with clicking on some point.

svn path=/trunk/; revision=72030

3 years ago[SETUPAPI] CORE-11689 is enough documentation for the issue, so we don't really need...
Amine Khaldi [Wed, 27 Jul 2016 21:38:56 +0000 (21:38 +0000)]
[SETUPAPI] CORE-11689 is enough documentation for the issue, so we don't really need to mention it in every single build.

svn path=/trunk/; revision=72028

3 years ago[SHELL32]
Giannis Adamopoulos [Wed, 27 Jul 2016 20:51:36 +0000 (20:51 +0000)]
[SHELL32]
- Query the drop effect from the key state. After latest wine sync we correctly get all possible effects instead of the effect of the last DragOver event.
CORE-11681

svn path=/trunk/; revision=72026

3 years ago[BTRFS]
Pierre Schweitzer [Wed, 27 Jul 2016 19:32:05 +0000 (19:32 +0000)]
[BTRFS]
Import three fixes from my local GitHub repository:
- Don't attempt to remove Vcb from list twice on shutdown
- Properly add CCB to root_file
- Init cache for root_file so that cache uninit on shutdown isn't problematic

This fixes BTRFS in ReactOS.
These fixes have already been submitted upstream (https://github.com/maharmstone/btrfs/pull/23).

CORE-11674

svn path=/trunk/; revision=72024

3 years ago[BTRFS]
Pierre Schweitzer [Wed, 27 Jul 2016 19:24:26 +0000 (19:24 +0000)]
[BTRFS]
Sync btrfs to 0.5.
This breaks BTRFS in ReactOS.

CORE-11674

svn path=/trunk/; revision=72023

3 years ago[SETUPAPI_WINETEST]: Use #ifdef __REACTOS__ instead to underline our local difference...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 19:17:35 +0000 (19:17 +0000)]
[SETUPAPI_WINETEST]: Use #ifdef __REACTOS__ instead to underline our local differences wrt. the synced Wine code. Per Amine request.
ROSTESTS_234

svn path=/trunk/; revision=72022

3 years ago[SETUPAPI]: Temporarily remove the error popup since setupapi_winetest pops it out...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 19:12:35 +0000 (19:12 +0000)]
[SETUPAPI]: Temporarily remove the error popup since setupapi_winetest pops it out unexpectedly. We don't lose functionality wrt. what we had before r72008 (or with what Wine currently has).
CORE-11689

svn path=/trunk/; revision=72021

3 years ago[SETUPAPI_WINETEST]: Temporarily "hackfix" the test so that it uses a more "suitable...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 19:05:52 +0000 (19:05 +0000)]
[SETUPAPI_WINETEST]: Temporarily "hackfix" the test so that it uses a more "suitable" test path.
ROSTESTS-234

svn path=/trunk/; revision=72020

3 years ago[KMTESTS]
Pierre Schweitzer [Wed, 27 Jul 2016 16:40:30 +0000 (16:40 +0000)]
[KMTESTS]
Add missing dependency

svn path=/trunk/; revision=72019

3 years ago[NTOS:PO]
Thomas Faber [Wed, 27 Jul 2016 11:15:52 +0000 (11:15 +0000)]
[NTOS:PO]
- Send power IRPs to the top of the device stack instead of the PDO
CORE-10110 #resolve

svn path=/trunk/; revision=72017

3 years ago[SETUPAPI]: Implement SetupPromptForDiskA/W by importing dialog.c from Wine Staging...
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 00:48:41 +0000 (00:48 +0000)]
[SETUPAPI]: Implement SetupPromptForDiskA/W by importing dialog.c from Wine Staging 1.9.15.
(Add also the patch "Add patch to support IDF_CHECKFIRST in SetupPromptForDisk." by DarkPlayer - 541cc8d08661980dfe80fe2bb9dd27c91879e09f)

svn path=/trunk/; revision=72009

3 years ago[SETUPAPI]
Hermès Bélusca-Maïto [Wed, 27 Jul 2016 00:10:14 +0000 (00:10 +0000)]
[SETUPAPI]
- Transform the cached OsVersionInfo structure into a OSVERSIONINFOEXW that is then reused in SetupDiGetActualSectionToInstallExW.
- Remove few unused hardcoded strings.
- Add two TRACEs in SetupDiGetActualSectionToInstallExW to debug diverse INF file installation problems.
- parser.c: enclose the contents of the for-loop inside braces.
- Implement pSetupSetGlobalFlags and pSetupModifyGlobalFlags, see https://msdn.microsoft.com/en-us/library/bb432397(v=vs.85).aspx
- Popup an error message box in InstallHinfSectionW if an error happened and if interactive setup is allowed (through the global setup flags).

svn path=/trunk/; revision=72008

3 years ago[NTVDM]: Don't attempt to deinitialize the video console if it wasn't previously...
Hermès Bélusca-Maïto [Tue, 26 Jul 2016 19:57:40 +0000 (19:57 +0000)]
[NTVDM]: Don't attempt to deinitialize the video console if it wasn't previously initialized.
CORE-10182 #resolve

svn path=/trunk/; revision=72007

3 years ago[INF]: Use the correct icon for audio controller devices in the device manager. By...
Hermès Bélusca-Maïto [Tue, 26 Jul 2016 19:09:18 +0000 (19:09 +0000)]
[INF]: Use the correct icon for audio controller devices in the device manager. By Jared Smudde.
CORE-11679 #resolve #comment Committed, thanks!

svn path=/trunk/; revision=72006

3 years ago[BROWSEUI]
Giannis Adamopoulos [Tue, 26 Jul 2016 15:09:04 +0000 (15:09 +0000)]
[BROWSEUI]
- CExplorerBand: Implement showing the context menu on right click.
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=72004

3 years ago[BROWSEUI]
Giannis Adamopoulos [Tue, 26 Jul 2016 14:31:38 +0000 (14:31 +0000)]
[BROWSEUI]
- CExplorerBand: Expand the tree view to the current folder when a new folder is browser (either with the addressbar or by double clicking a folder).
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=72003

3 years ago[NTOSKRNL_VISTA]
Pierre Schweitzer [Mon, 25 Jul 2016 20:45:48 +0000 (20:45 +0000)]
[NTOSKRNL_VISTA]
Implement KeQueryActiveProcessorCount().

CORE-11674

svn path=/trunk/; revision=72001

3 years ago[MMSYS]: Improve AddSoundProfile, by Victor Martinez Calvo (with 1 minor modification...
Hermès Bélusca-Maïto [Mon, 25 Jul 2016 20:24:30 +0000 (20:24 +0000)]
[MMSYS]: Improve AddSoundProfile, by Victor Martinez Calvo (with 1 minor modification by myself):
◾ Don't return TRUE when CB_SETITEMDATA fails.
◾ Avoid pScheme NULL dereference if allocation fails. CID 1223154
◾ Avoid overflowing the destiny buffer by using StringCchCopy() CID 510953
and:
1) Make it more readable by returning as soon as possible when an error happens.
2) Make it more readable by reducing the nested ifs-checks.
3) Remove the added string in the combobox if the sound scheme buffer mem allocation fails (pt.3 modified).
CORE-11603 #resolve #comment Thanks!

svn path=/trunk/; revision=72000

3 years ago[TOOLS]
Thomas Faber [Mon, 25 Jul 2016 19:28:40 +0000 (19:28 +0000)]
[TOOLS]
- Fix MSVC 2013+ build. Patch by Victor Matovykh.
CORE-11575 #resolve

svn path=/trunk/; revision=71998

3 years ago[SHELL32]
Thomas Faber [Mon, 25 Jul 2016 19:25:46 +0000 (19:25 +0000)]
[SHELL32]
- Add missing dependency

svn path=/trunk/; revision=71997

3 years ago[ADVAPI32] silence debug spam
Christoph von Wittich [Mon, 25 Jul 2016 11:07:44 +0000 (11:07 +0000)]
[ADVAPI32] silence debug spam

svn path=/trunk/; revision=71995

3 years ago[WIN32K:NTUSER]
Thomas Faber [Mon, 25 Jul 2016 10:45:30 +0000 (10:45 +0000)]
[WIN32K:NTUSER]
- Fix UserDrawCaptionBar debug spam

svn path=/trunk/; revision=71994

3 years ago[NTOS:CC]
Thomas Faber [Mon, 25 Jul 2016 08:48:50 +0000 (08:48 +0000)]
[NTOS:CC]
- Unconditionally acquire the VACB lock during map/pin/unpin operations and release it appropriately
CORE-11555 #resolve
CORE-11654 CORE-11504 CORE-11328 #comment This might be fixed with r71993. Could you retry please?

svn path=/trunk/; revision=71993

3 years ago[NTVDM]
Aleksandar Andrejevic [Sun, 24 Jul 2016 18:25:50 +0000 (18:25 +0000)]
[NTVDM]
Implement the VGA AC Color Select register.
Implement INT 0x10, AH = 0x10, subfunction AL = 0x13.

svn path=/trunk/; revision=71992

3 years ago[NTOS:CC]
Thomas Faber [Sun, 24 Jul 2016 17:10:30 +0000 (17:10 +0000)]
[NTOS:CC]
- Centralize VACB locking/unlocking into inline functions for easier instrumentation

svn path=/trunk/; revision=71991

3 years ago[NTVDM]
Aleksandar Andrejevic [Sun, 24 Jul 2016 15:45:50 +0000 (15:45 +0000)]
[NTVDM]
Always reset the AC latch before writing to the AC index register.
CORE-11669 #resolve #comment Should be fixed in revision r71990.

svn path=/trunk/; revision=71990

3 years ago[EVENTVWR]
Hermès Bélusca-Maïto [Sun, 24 Jul 2016 15:24:50 +0000 (15:24 +0000)]
[EVENTVWR]
- Use helper functions for doing the filtering on the events (idea by Mark Jansen).
- Fix the states of menu items, depending on which event log/item (log file/filter; event item...) is currently selected.
- Correctly empty the event items list & cache whenever an event log/filter is closed (and avoid a crash when all logs/filters are closed and someone attempts to open an event item), during concurrent accesses. I use a reference count and AddRef/Release helpers.
- Get rid of the annoying log loading popup, and use instead the loading message displayed in the events listview as well as a progress-bar in the status bar.
CORE-11637

svn path=/trunk/; revision=71989

3 years ago[GDI32] Sync EMFDRV_PolyPolylinegon() with Wine Staging 1.9.14. CORE-11521
Amine Khaldi [Sat, 23 Jul 2016 21:33:40 +0000 (21:33 +0000)]
[GDI32] Sync EMFDRV_PolyPolylinegon() with Wine Staging 1.9.14. CORE-11521

svn path=/trunk/; revision=71986

3 years ago[CRT][GDI32] Introduce atan2 library, use it for gdi32 to fix a crash. CORE-11521
Mark Jansen [Sat, 23 Jul 2016 20:35:11 +0000 (20:35 +0000)]
[CRT][GDI32] Introduce atan2 library, use it for gdi32 to fix a crash. CORE-11521
As suggested by Thomas :)

svn path=/trunk/; revision=71985

3 years ago[MPR]
Pierre Schweitzer [Sat, 23 Jul 2016 19:52:23 +0000 (19:52 +0000)]
[MPR]
Provide ReactOS specific implementation for WNetGetConnection(), we cannot use Wine's due to Wine specific MountMgr calls.

svn path=/trunk/; revision=71984

3 years ago[SHELL32] close hKey in error case
Christoph von Wittich [Sat, 23 Jul 2016 19:39:16 +0000 (19:39 +0000)]
[SHELL32] close hKey in error case

svn path=/trunk/; revision=71983

3 years ago[NTOS:IO]
Thomas Faber [Sat, 23 Jul 2016 18:18:11 +0000 (18:18 +0000)]
[NTOS:IO]
- Avoid infinite loop in IopMountVolume. Brought to you by Vadim Galyant.
CORE-11663 #resolve

svn path=/trunk/; revision=71982

3 years ago[SHELL32] Addendum to r71980, RegSetValueEx expects a size in bytes, not chars. CORE...
Mark Jansen [Sat, 23 Jul 2016 13:15:19 +0000 (13:15 +0000)]
[SHELL32] Addendum to r71980, RegSetValueEx expects a size in bytes, not chars. CORE-10439

svn path=/trunk/; revision=71981

3 years ago[SHELL32] cache entries of "New" menu
Christoph von Wittich [Sat, 23 Jul 2016 12:31:30 +0000 (12:31 +0000)]
[SHELL32] cache entries of "New" menu
CORE-10439

svn path=/trunk/; revision=71980

3 years ago[SHELL32]
Giannis Adamopoulos [Sat, 23 Jul 2016 08:42:38 +0000 (08:42 +0000)]
[SHELL32]
- CDefView: Add the skeleton check that should be used to implement moving items in the CDefView. Nothing more is implemented because GetKeyState is completely unreliable.

svn path=/trunk/; revision=71979

3 years ago[ADVPACK]: Addendum to r71977: Add the resource file into the CMakeList.
Hermès Bélusca-Maïto [Fri, 22 Jul 2016 14:15:09 +0000 (14:15 +0000)]
[ADVPACK]: Addendum to r71977: Add the resource file into the CMakeList.
CORE-7645

svn path=/trunk/; revision=71978

3 years ago[ADVPACK]: Add file version information resource.
Hermès Bélusca-Maïto [Fri, 22 Jul 2016 13:19:25 +0000 (13:19 +0000)]
[ADVPACK]: Add file version information resource.
CORE-7645 #comment Please retest the installation of Visual Basic 6 runtime with revision >= 71977.

svn path=/trunk/; revision=71977

3 years ago[USETUP]
Eric Kohl [Thu, 21 Jul 2016 20:53:43 +0000 (20:53 +0000)]
[USETUP]
Keyboard Modifier LEDs not working in usetup.
Patch by Carlo Bramini.
CORE-3368 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=71976

3 years ago[ACPPAGE] Add windows ME to the Win98 selection item. Patch by Lee Schroeder. CORE...
Mark Jansen [Thu, 21 Jul 2016 17:29:41 +0000 (17:29 +0000)]
[ACPPAGE] Add windows ME to the Win98 selection item. Patch by Lee Schroeder. CORE-11606 #resolve #comment Thanks!

svn path=/trunk/; revision=71975

3 years ago[SERIAL]
Thomas Faber [Wed, 20 Jul 2016 12:50:58 +0000 (12:50 +0000)]
[SERIAL]
- Properly stub SerialPower
CORE-11648

svn path=/trunk/; revision=71974

3 years ago[PARPORT]
Thomas Faber [Wed, 20 Jul 2016 12:21:11 +0000 (12:21 +0000)]
[PARPORT]
- Properly stub FdoPower and PdoPower
CORE-11648

svn path=/trunk/; revision=71973

3 years ago[PCIIDEX]
Thomas Faber [Wed, 20 Jul 2016 11:49:22 +0000 (11:49 +0000)]
[PCIIDEX]
- Add a stub for PciIdeXPowerDispatch
CORE-11648

svn path=/trunk/; revision=71972

3 years ago[SERVICES]
Eric Kohl [Tue, 19 Jul 2016 21:30:45 +0000 (21:30 +0000)]
[SERVICES]
Service logon page:
- Handle the interactive service type flag.
- Change the service configuration in the apply function.

svn path=/trunk/; revision=71971

3 years ago[KERNEL32_WINETEST] Sync thread tests with Wine Staging 1.9.14 now that Thomas fixed...
Amine Khaldi [Tue, 19 Jul 2016 18:12:15 +0000 (18:12 +0000)]
[KERNEL32_WINETEST] Sync thread tests with Wine Staging 1.9.14 now that Thomas fixed CORE-11511.

svn path=/trunk/; revision=71970

3 years ago[NTOS:KE]
Thomas Faber [Tue, 19 Jul 2016 12:51:49 +0000 (12:51 +0000)]
[NTOS:KE]
- Load LDT on context switch if required.
CORE-11511 #resolve

svn path=/trunk/; revision=71967

3 years ago[REGEDIT]
Hermès Bélusca-Maïto [Mon, 18 Jul 2016 22:27:17 +0000 (22:27 +0000)]
[REGEDIT]
- Minor whitespace fixes in main.c
- Use a correct info msgbox title when showing regedit command-line usage. Something to think about: translate the cmdline usage! :)

svn path=/trunk/; revision=71966

3 years ago[SERVMAN]
Eric Kohl [Mon, 18 Jul 2016 21:49:19 +0000 (21:49 +0000)]
[SERVMAN]
Service logon property page:
- Fix initialization and display bugs.
- Start work on the 'Apply' function. It doe not apply changes yet.
- Add password check messages.

svn path=/trunk/; revision=71965

3 years ago[BOOTDATA]: Disable automatic debugger startup on application crash. This allows...
Hermès Bélusca-Maïto [Mon, 18 Jul 2016 19:25:53 +0000 (19:25 +0000)]
[BOOTDATA]: Disable automatic debugger startup on application crash. This allows getting back the error popup as we used to have, and also warn the user there was indeed a problem, instead of silently start the default debugger (that I've set to an unexistant "drwtsn.exe") and fail silently, since that default debugger doesn't exist.
CORE-11508

svn path=/trunk/; revision=71964

3 years ago[USER32_WINETEST] Sync with Wine Staging 1.9.14.
Amine Khaldi [Mon, 18 Jul 2016 15:48:27 +0000 (15:48 +0000)]
[USER32_WINETEST] Sync with Wine Staging 1.9.14.

svn path=/trunk/; revision=71963

3 years ago[USER32] Add missing lprc check in SetRect().
Amine Khaldi [Mon, 18 Jul 2016 15:46:38 +0000 (15:46 +0000)]
[USER32] Add missing lprc check in SetRect().

svn path=/trunk/; revision=71962