12 months ago[BROWSEUI] CInternetToolbar: Implement hiding and showing the browser toolbars.
Giannis Adamopoulos [Mon, 22 Oct 2018 15:41:47 +0000 (18:41 +0300)]
[BROWSEUI] CInternetToolbar: Implement hiding and showing the browser toolbars.

12 months ago[NTOS:CM] CmpCmdHiveOpen(): Resolve FileAttributes->RootDirectory when a hive file...
Hermès Bélusca-Maïto [Sun, 21 Oct 2018 22:39:50 +0000 (00:39 +0200)]
[NTOS:CM] CmpCmdHiveOpen(): Resolve FileAttributes->RootDirectory when a hive file name is provided relative to it.

Fixes registry hive loading. CORE-13448

12 months ago[NTDLL_APITEST] Re-enable the part of the NtLoad/UnloadKey test related to force... 964/head
Hermès Bélusca-Maïto [Sun, 21 Oct 2018 21:09:32 +0000 (23:09 +0200)]
[NTDLL_APITEST] Re-enable the part of the NtLoad/UnloadKey test related to force-unload a hive with opened sub-key handles.

Effectively reverts b17ce9c8 (r75138).


12 months ago[NTOS:CM] Implement more support for force-unloading registry hives.
Hermès Bélusca-Maïto [Sun, 21 Oct 2018 21:08:51 +0000 (23:08 +0200)]
[NTOS:CM] Implement more support for force-unloading registry hives.
CORE-13448 CORE-10705

12 months ago[NTOS:CM] Add extra validation for the information class parameter in NtEnumerateValu...
Hermès Bélusca-Maïto [Sun, 21 Oct 2018 16:12:08 +0000 (18:12 +0200)]
[NTOS:CM] Add extra validation for the information class parameter in NtEnumerateValueKey().

12 months ago[NTOS:CM] Improve the capture of user-mode parameters. 960/head
Hermès Bélusca-Maïto [Sun, 21 Oct 2018 13:42:13 +0000 (15:42 +0200)]
[NTOS:CM] Improve the capture of user-mode parameters.

- Improve the capture of OBJECT_ATTRIBUTES parameters that are passed
  (by pointer) to the Cm* helper functions, and the capture of

- Correctly differentiate user-mode vs. kernel-mode root directory handles
  (in OBJECT_ATTRIBUTES): note that most of the Cm* APIs expect their
  parameters to be kernel-mode (pointers, handles...).


12 months ago[SYSDM] Fix controls order and label height in IDD_SYSSETTINGS dialog
Stanislav Motylkov [Sat, 20 Oct 2018 23:15:01 +0000 (02:15 +0300)]
[SYSDM] Fix controls order and label height in IDD_SYSSETTINGS dialog

This fixes checkbox rendering issue in russian translation.
Dialogs in other translations are ok.


12 months ago[APPWIZ] Do not display the message box if the user aborts the download 946/head
Bișoc George [Sun, 14 Oct 2018 14:07:51 +0000 (16:07 +0200)]
[APPWIZ] Do not display the message box if the user aborts the download


12 months ago[REGEDIT] Trivial resizing code fix 950/head
Katayama Hirofumi MZ [Mon, 15 Oct 2018 14:28:19 +0000 (23:28 +0900)]
[REGEDIT] Trivial resizing code fix

12 months ago[REGEDIT] Code formatting 949/head
Katayama Hirofumi MZ [Mon, 15 Oct 2018 14:13:06 +0000 (23:13 +0900)]
[REGEDIT] Code formatting

12 months ago[CHKDSK] Fix MSVC build (thanks for spotting the mistake!)
Pierre Schweitzer [Sun, 21 Oct 2018 09:22:45 +0000 (11:22 +0200)]
[CHKDSK] Fix MSVC build (thanks for spotting the mistake!)

Addendum to ec9fc7f

12 months ago[VFATLIB] Don't attempt to fix volume if not allowed
Pierre Schweitzer [Sun, 21 Oct 2018 09:12:10 +0000 (11:12 +0200)]
[VFATLIB] Don't attempt to fix volume if not allowed

12 months ago[CHKDSK] Add French translation
Pierre Schweitzer [Sun, 21 Oct 2018 09:06:06 +0000 (11:06 +0200)]
[CHKDSK] Add French translation

12 months ago[RAPPS][TRANSLATION] Estonian localization (#959)
Joann Mõndresku [Sat, 20 Oct 2018 23:58:02 +0000 (02:58 +0300)]
[RAPPS][TRANSLATION] Estonian localization (#959)

12 months ago[CHKDSK] Add russian translation
Stanislav Motylkov [Sat, 20 Oct 2018 19:49:37 +0000 (22:49 +0300)]
[CHKDSK] Add russian translation

12 months ago[TRANSLATION] Polish translation update
Adam Słaboń [Sat, 13 Oct 2018 10:27:52 +0000 (12:27 +0200)]
[TRANSLATION] Polish translation update

Polish translation of net, telnet, diskpart, devcpux, fontext, iernonce, lsasrv, themes, arping, frag, screensavers, ctm, fontsub, WinetestsGUI and localmon.
Update for dxdiag, msgina, msports, netcfgx, shell32 and syssetup.

12 months ago[CHKDSK] Implement localization support (#891)
Bișoc George [Sat, 20 Oct 2018 19:21:51 +0000 (21:21 +0200)]
[CHKDSK] Implement localization support (#891)

- Make the strings translatable.
- Include the English translation within the main resource file.
- Use ConResPrintf() and ConResPuts() for resource strings.

12 months ago[APPWIZ] Translation update for Romanian & Italian
Bișoc George [Thu, 11 Oct 2018 14:50:31 +0000 (16:50 +0200)]
[APPWIZ] Translation update for Romanian & Italian

12 months ago[MEDIA] Add a notice to the chinese translation document.
Hermès Bélusca-Maïto [Sat, 20 Oct 2018 17:57:18 +0000 (19:57 +0200)]
[MEDIA] Add a notice to the chinese translation document.

12 months agoAdd Notice for Chinese translation.
Luo Yufan [Thu, 11 Oct 2018 10:07:45 +0000 (18:07 +0800)]
Add Notice for Chinese translation.

12 months ago[NTOS:CM] Minor fixes.
Hermès Bélusca-Maïto [Sat, 20 Oct 2018 17:30:59 +0000 (19:30 +0200)]
[NTOS:CM] Minor fixes.

- Validate the information class parameter in NtQueryValueKey().
- Call the post-callback in NtSetValueKey() only if the callback
  has been registered and the CmSetValueKey() call is executed.

12 months ago[NTOS:CM] Reuse the saved previous-mode from the ExGetPreviousMode() calls.
Hermès Bélusca-Maïto [Sat, 20 Oct 2018 17:17:55 +0000 (19:17 +0200)]
[NTOS:CM] Reuse the saved previous-mode from the ExGetPreviousMode() calls.

12 months ago[MKHIVE] Minor code rearrangement.
Hermès Bélusca-Maïto [Sat, 20 Oct 2018 14:49:30 +0000 (16:49 +0200)]
[MKHIVE] Minor code rearrangement.

12 months ago[NOTEPAD] ReactOS Notepad Hindi Translation (#938)
Arnav Bhatt [Sat, 20 Oct 2018 17:41:32 +0000 (23:11 +0530)]
[NOTEPAD] ReactOS Notepad Hindi Translation (#938)

12 months ago[NTVDM] Allow opening files with write access on CDROM
Pierre Schweitzer [Sat, 20 Oct 2018 10:53:52 +0000 (12:53 +0200)]
[NTVDM] Allow opening files with write access on CDROM

Some applications, run on a CDROM, may attempt to open
a file with write access. CDFS driver will deny such
request in ReactOS (but also in Windows NT). Then, to
restore that behavior from old Windows (9X), our ntvdm,
as Microsoft ntvdm will attempt to reopen the file only
with read access, if opening failed because of denied access
and if the file is on a CDROM.


12 months ago[NTVDM] Implement INT21, AX=4408, Determine if a block device is removable. 940/head
Mark Jansen [Mon, 8 Oct 2018 21:12:19 +0000 (23:12 +0200)]
[NTVDM] Implement INT21, AX=4408, Determine if a block device is removable.

12 months ago[GFLAGS] Implement imagefile options 939/head
Mark Jansen [Sat, 13 Oct 2018 15:11:51 +0000 (17:11 +0200)]
[GFLAGS] Implement imagefile options

12 months ago[GFLAGS] Move common code to a shared location.
Mark Jansen [Sat, 13 Oct 2018 15:10:09 +0000 (17:10 +0200)]
[GFLAGS] Move common code to a shared location.

12 months ago[GFLAGS] Move code around to handle multiple options
Mark Jansen [Fri, 12 Oct 2018 23:14:15 +0000 (01:14 +0200)]
[GFLAGS] Move code around to handle multiple options

12 months ago[USETUP][EXPLORER] ReactOS explorer translation and hindi font substitution. (#954)
Arnav Bhatt [Fri, 19 Oct 2018 15:03:17 +0000 (20:33 +0530)]
[USETUP][EXPLORER] ReactOS explorer translation and hindi font substitution. (#954)

12 months ago[MKHIVE] Fix some compilation warnings.
Hermès Bélusca-Maïto [Thu, 18 Oct 2018 22:25:19 +0000 (00:25 +0200)]
[MKHIVE] Fix some compilation warnings.

12 months ago[USETUP] Add a couple of missing TrimTrailingPathSeparators_UStr() calls.
Hermès Bélusca-Maïto [Thu, 18 Oct 2018 20:58:48 +0000 (22:58 +0200)]
[USETUP] Add a couple of missing TrimTrailingPathSeparators_UStr() calls.

Fixes in particular a regression brought by 57402ee (thanks George Bisoc
for having noticed this), where the BTRFS bootsector code could not be
installed anymore.


12 months ago[MKHIVE] Fix cases where 'rc' was used without being initialized.
Hermès Bélusca-Maïto [Thu, 18 Oct 2018 21:07:41 +0000 (23:07 +0200)]
[MKHIVE] Fix cases where 'rc' was used without being initialized.

Fixes crashes when the tool is compiled with Run-Time Checks enabled.
And thus should fix the MSVC buildbots!
Thanks to Pierre for having brought this issue to me.


13 months ago[MKHIVE] Fix compilation warnings. 947/head
Hermès Bélusca-Maïto [Sun, 14 Oct 2018 22:32:48 +0000 (00:32 +0200)]
[MKHIVE] Fix compilation warnings.

13 months ago[SETUPLIB][USETUP] Minor code refactoring, consisting in renaming the "ntos boot...
Hermès Bélusca-Maïto [Thu, 8 Jun 2017 17:30:23 +0000 (17:30 +0000)]
[SETUPLIB][USETUP] Minor code refactoring, consisting in renaming the "ntos boot loader" stuff into "boot store", since this happens to be functionality that is a bit more general than previously thought.

- Fix the usage of the BootEntry's "Version" member.
- Don't surround with too many quotation marks the "friendly" boot entry name in AddBootStoreEntry().

svn path=/branches/setup_improvements/; revision=74964

13 months ago[USETUP] As evoked in 27603a10 (r74943), adapt the code in bootsup.c to abstract...
Hermès Bélusca-Maïto [Thu, 8 Jun 2017 02:43:51 +0000 (02:43 +0000)]
[USETUP] As evoked in 27603a10 (r74943), adapt the code in bootsup.c to abstract the manipulation of freeldr.ini and boot.ini, and make it use the new features of bldrsup.c committed in 27603a10 (r74952).

In particular the helper functions CreateCommonFreeLdrSections() and (Un)protectBootIni() are now removed from there (they are used in bldrsup.c only).
This should pave the way for future integration with other sorts of NT boot loaders (BootMgr and (u)EFI boot loader).

svn path=/branches/setup_improvements/; revision=74954

13 months ago[SETUPLIB] Adapt the code in osdetect.c to make it use the new features of bldrsup...
Hermès Bélusca-Maïto [Thu, 8 Jun 2017 02:20:33 +0000 (02:20 +0000)]
[SETUPLIB] Adapt the code in osdetect.c to make it use the new features of bldrsup.c committed in 27603a10 (r74952).

svn path=/branches/setup_improvements/; revision=74953

13 months ago[SETUPLIB] Introduce a lot of (Work in progress) functions to manipulate boot entries...
Hermès Bélusca-Maïto [Wed, 7 Jun 2017 15:58:44 +0000 (15:58 +0000)]
[SETUPLIB] Introduce a lot of (Work in progress) functions to manipulate boot entries from different boot "stores".

This concerns so far, only freeldr.ini and to an extent, boot.ini, but planning in the future to add support for registry-oriented BCD
as well as possibly direct (u)EFI entries, using the corresponding NT functions.
This code is so far only used in osdetect.c, but will be soon used by usetup's bootsup.c (note that some helper functions: CreateCommonFreeLdrSections()
and (Un)protectBootIni() are already taken from it and used in bldrsup.c).
- In EnumerateNTOSBootEntries(), continue enumerating the boot entries until the user callback returns an status code that is not successful.
- Remove some old code from osdetect.c; use directly BootEntry->FriendlyName when building the display names of the available installations, since now
  BootEntry->FriendlyName is a PCWSTR (and not a UNICODE_STRING anymore).

svn path=/branches/setup_improvements/; revision=74943

[SETUPLIB] Make the NTOS_BOOT_ENTRY structure more generic, so that it can wrap around either actual NTOS boot entry options, or FreeLdr-like boot-sector options.

In a sense, the NTOS_BOOT_ENTRY structure now looks much more like the NT structure "BOOT_ENTRY".
- Adapt the code in bldrsup.c to these modifications, and re-enable FreeLdr-like boot-sector-file support code that was commented out.
More code cleanup will follow later.

svn path=/branches/setup_improvements/; revision=74952

13 months ago[USETUP] Diverse fixes for path handling.
Hermès Bélusca-Maïto [Wed, 31 May 2017 02:19:08 +0000 (02:19 +0000)]
[USETUP] Diverse fixes for path handling.

- Convert almost all swprintf() into StringCchPrintfW() and wcscpy() into StringCchCopyW();
- Explicitly add a trailing path separator to the "\Device\HarddiskX\PartitionY(\)" paths
  when they refer to FS directories (and not to partition objects);
- Remove useless (and half-buggy) "Remove trailing backslash" code.

With that, it is possible to install ReactOS in e.g. C:\ReactOS (as usual), C:\ReactOS\dir1\dir2 (as many dirs as you wish), and also in C:\ (yes yes!).
But in that latter case, a strange bug related to the registry arises...

- Adjust some comments;
- Add some debugging DPRINTs;
- The SetInstallPathValue() is part of the big hack I've mentioned in f51faa4a (r74709).

svn path=/branches/setup_improvements/; revision=74717

13 months ago[USETUP] When installing new FreeLDR entries for recognized DOS/OS-2 boot loaders...
Hermès Bélusca-Maïto [Tue, 6 Jun 2017 23:44:56 +0000 (23:44 +0000)]
[USETUP] When installing new FreeLDR entries for recognized DOS/OS-2 boot loaders, use distinct OS section names. Also, add detection for the Dell Real-Mode Kernel OS (DRMK).

svn path=/branches/setup_improvements/; revision=74932

13 months ago[USETUP] Condense the different InstallFatXYBootSectorToDisk & ToFile functions into...
Hermès Bélusca-Maïto [Wed, 31 May 2017 02:03:10 +0000 (02:03 +0000)]
[USETUP] Condense the different InstallFatXYBootSectorToDisk & ToFile functions into a InstallFatXYBootSector() function that is called by both the ToDisk and ToFile flavours.

Also, trim any potential trailing path separator from the NT disk partition path before opening the partition object itself for read/write access.

svn path=/branches/setup_improvements/; revision=74715

13 months ago[USETUP] Move some functions around, but no functional code changes otherwise.
Hermès Bélusca-Maïto [Wed, 31 May 2017 01:47:39 +0000 (01:47 +0000)]
[USETUP] Move some functions around, but no functional code changes otherwise.

svn path=/branches/setup_improvements/; revision=74714

13 months ago[NETCFGX] Implement the Min and Max options for int, long and word parameters.
Eric Kohl [Sun, 14 Oct 2018 19:02:45 +0000 (21:02 +0200)]
[NETCFGX] Implement the Min and Max options for int, long and word parameters.


13 months ago[NEWDEV] Add InstallDevInstEx
Eric Kohl [Sun, 14 Oct 2018 16:17:42 +0000 (18:17 +0200)]
[NEWDEV] Add InstallDevInstEx

13 months ago[MKHIVE] Return win32-like error codes for functions that expect to do so. Fix and...
Hermès Bélusca-Maïto [Sun, 14 Oct 2018 15:10:04 +0000 (17:10 +0200)]
[MKHIVE] Return win32-like error codes for functions that expect to do so. Fix and comment out some unused ERROR_xxx/STATUS_xxx defines.

13 months ago[MKHIVE] Minor code formatting.
Hermès Bélusca-Maïto [Sun, 14 Oct 2018 14:28:13 +0000 (16:28 +0200)]
[MKHIVE] Minor code formatting.

13 months ago[MKHIVE] Implement RegDeleteKeyW() and RegDeleteValueW().
Hermès Bélusca-Maïto [Sun, 14 Oct 2018 13:31:12 +0000 (15:31 +0200)]
[MKHIVE] Implement RegDeleteKeyW() and RegDeleteValueW().

13 months ago[MKHIVE] Minor improvements.
Hermès Bélusca-Maïto [Sun, 14 Oct 2018 13:26:30 +0000 (15:26 +0200)]
[MKHIVE] Minor improvements.

- Fix a bug in RegpCreateOrOpenKey() when we attempt to open an
  non-existing (sub-)key.
- Check failure of RegCreateKeyExW() in CreateSymLink().
- Remove unneeded includes.
- Update few comments.

13 months ago[MKHIVE] Simplify CmiAddValueKey() by using CmpAddValueToList().
Hermès Bélusca-Maïto [Sun, 14 Oct 2018 13:14:52 +0000 (15:14 +0200)]
[MKHIVE] Simplify CmiAddValueKey() by using CmpAddValueToList().

13 months ago[MKHIVE] Sync a bit more of reginf.c with the corresponding setupapi code.
Hermès Bélusca-Maïto [Sat, 13 Oct 2018 22:32:26 +0000 (00:32 +0200)]
[MKHIVE] Sync a bit more of reginf.c with the corresponding setupapi code.

13 months ago[MKHIVE] Implement and use RegCloseKey().
Hermès Bélusca-Maïto [Sat, 13 Oct 2018 22:29:04 +0000 (00:29 +0200)]
[MKHIVE] Implement and use RegCloseKey().

13 months ago[NTOS][MKHIVE] Minor code formatting.
Hermès Bélusca-Maïto [Sat, 13 Oct 2018 23:20:31 +0000 (01:20 +0200)]
[NTOS][MKHIVE] Minor code formatting.

13 months ago[CMLIB] Adjust parameter types and annotations. Add diagnostic assertions.
Hermès Bélusca-Maïto [Sat, 13 Oct 2018 22:16:04 +0000 (00:16 +0200)]
[CMLIB] Adjust parameter types and annotations. Add diagnostic assertions.

13 months ago[FONT][WIN32SS] Use ExFreePoolWithTag instead of ExFreePool (#941)
Katayama Hirofumi MZ [Sun, 14 Oct 2018 07:47:52 +0000 (16:47 +0900)]
[FONT][WIN32SS] Use ExFreePoolWithTag instead of ExFreePool (#941)

13 months ago[NTOSKRNL] Add the CcPinMappedDataCount counter
Pierre Schweitzer [Sat, 13 Oct 2018 20:50:49 +0000 (22:50 +0200)]
[NTOSKRNL] Add the CcPinMappedDataCount counter

13 months ago[NTOSKRNL] Rewrite the way we create BCB for pinning
Pierre Schweitzer [Sat, 13 Oct 2018 20:46:10 +0000 (22:46 +0200)]
[NTOSKRNL] Rewrite the way we create BCB for pinning

We won't reuse a BCB created for mapping, we will now have
our own dedicated BCB.
This allows having a bit more cleaner implementation of CcPinMappedData()

13 months ago[CRT] spawn: define a unicode environment when needed 936/head
Mark Jansen [Fri, 12 Oct 2018 22:20:58 +0000 (00:20 +0200)]
[CRT] spawn: define a unicode environment when needed

13 months ago[SHELL32] CDefView: Query SFVM_DEFVIEWMODE before creating the list view. 935/head
Mark Jansen [Tue, 9 Oct 2018 18:57:23 +0000 (20:57 +0200)]
[SHELL32] CDefView: Query SFVM_DEFVIEWMODE before creating the list view.

13 months ago[FASTFAT] Don't mess my debug log when partition SysType is printed! (when invalid...
Hermès Bélusca-Maïto [Sat, 13 Oct 2018 17:57:24 +0000 (19:57 +0200)]
[FASTFAT] Don't mess my debug log when partition SysType is printed! (when invalid chars are printed)

13 months ago[RTL] Make a RtlQueryEnvironmentVariable_U() DPRINT a little bit more useful.
Hermès Bélusca-Maïto [Sat, 13 Oct 2018 17:44:13 +0000 (19:44 +0200)]
[RTL] Make a RtlQueryEnvironmentVariable_U() DPRINT a little bit more useful.

13 months ago[KMTESTS:CC] Add more tests for CcPinMappedData()
Pierre Schweitzer [Sat, 13 Oct 2018 17:24:07 +0000 (19:24 +0200)]
[KMTESTS:CC] Add more tests for CcPinMappedData()

13 months ago[NETCFGX] Move the NetClassInstaller to a separate file.
Eric Kohl [Sat, 13 Oct 2018 17:17:56 +0000 (19:17 +0200)]
[NETCFGX] Move the NetClassInstaller to a separate file.

13 months ago[KMTESTS:CC] Properly check for memory allocations
Pierre Schweitzer [Sat, 13 Oct 2018 17:17:00 +0000 (19:17 +0200)]
[KMTESTS:CC] Properly check for memory allocations

13 months ago[KMTESTS:CC] Add more tests for CcPinMappedData()
Pierre Schweitzer [Sat, 13 Oct 2018 17:15:48 +0000 (19:15 +0200)]
[KMTESTS:CC] Add more tests for CcPinMappedData()

13 months ago[KMTESTS:CC] Add more tests for CcPinMappedData()
Pierre Schweitzer [Sat, 13 Oct 2018 17:13:07 +0000 (19:13 +0200)]
[KMTESTS:CC] Add more tests for CcPinMappedData()

13 months ago[KMTESTS:CC] Add more tests for CcPinMappedData()
Pierre Schweitzer [Sat, 13 Oct 2018 16:53:08 +0000 (18:53 +0200)]
[KMTESTS:CC] Add more tests for CcPinMappedData()

13 months ago[KMTESTS:CC] Add a test showing our CcPinMappedData() implementation is broken
Pierre Schweitzer [Sat, 13 Oct 2018 12:23:38 +0000 (14:23 +0200)]
[KMTESTS:CC] Add a test showing our CcPinMappedData() implementation is broken

13 months ago[SDK] Implement __wine_spec_unimplemented_stub with ntdll functions 896/head
Mark Jansen [Wed, 5 Sep 2018 21:20:46 +0000 (23:20 +0200)]
[SDK] Implement __wine_spec_unimplemented_stub with ntdll functions

13 months ago[DBGHELP] Exclude stubs from pch
Mark Jansen [Wed, 5 Sep 2018 21:20:28 +0000 (23:20 +0200)]
[DBGHELP] Exclude stubs from pch

13 months ago[SDK] Add version option to our spec2def cmake command
Mark Jansen [Wed, 5 Sep 2018 19:59:16 +0000 (21:59 +0200)]
[SDK] Add version option to our spec2def cmake command

13 months ago[SDK] Add the WITH_RELAY option to msvc's spec2def command. (GCC already had it)
Mark Jansen [Wed, 5 Sep 2018 19:51:59 +0000 (21:51 +0200)]
[SDK] Add the WITH_RELAY option to msvc's spec2def command. (GCC already had it)

13 months ago[SPEC2DEF] Fix support for different OS versions.
Mark Jansen [Wed, 5 Sep 2018 19:49:02 +0000 (21:49 +0200)]
[SPEC2DEF] Fix support for different OS versions.

13 months ago[KERNEL32] Fix some stubs for 0x600+
Mark Jansen [Wed, 5 Sep 2018 19:46:37 +0000 (21:46 +0200)]
[KERNEL32] Fix some stubs for 0x600+

13 months ago[NTOS:KD] A few trivial code improvements
Serge Gautherie [Wed, 10 Oct 2018 23:29:39 +0000 (01:29 +0200)]
[NTOS:KD] A few trivial code improvements

13 months ago[NTOS:KD] Remove an unreachable "break;"
Serge Gautherie [Wed, 10 Oct 2018 23:22:05 +0000 (01:22 +0200)]
[NTOS:KD] Remove an unreachable "break;"

On behalf of Kudratov Olimjon.

13 months ago[NTOSKRNL] Don't keep the spin lock hold too long when we lost the BCB race
Pierre Schweitzer [Fri, 12 Oct 2018 06:20:32 +0000 (08:20 +0200)]
[NTOSKRNL] Don't keep the spin lock hold too long when we lost the BCB race

This will avoid a deadlock on unpin.

13 months ago[NTOSKRNL] Rewrite BCB handling to be more robust
Pierre Schweitzer [Thu, 11 Oct 2018 21:15:01 +0000 (23:15 +0200)]
[NTOSKRNL] Rewrite BCB handling to be more robust

We now handle race conditions when creating BCB to avoid
having duplicated BCB per shared maps.
Also, we already specify whether the memory will be pinned
when creating the BCB, to avoid potential duplications or
BCB misuse.

13 months ago[APPWIZ] Update French translation
Pierre Schweitzer [Wed, 10 Oct 2018 06:42:38 +0000 (08:42 +0200)]
[APPWIZ] Update French translation

13 months ago[NETCFGX] NetworkPropertySheetProvider: Fix property selection because the property...
Eric Kohl [Tue, 9 Oct 2018 21:19:48 +0000 (23:19 +0200)]
[NETCFGX] NetworkPropertySheetProvider: Fix property selection because the property list box is sorted.


13 months ago[BOOTDATA] Update optional modules according to 287d35b 926/head
Pierre Schweitzer [Tue, 9 Oct 2018 06:40:41 +0000 (08:40 +0200)]
[BOOTDATA] Update optional modules according to 287d35b

This fixes optional modules being installed in places
that make no sense.
This also fixes auto installation of Gecko. Thus, this
fixes unattended setup of ReactOS for testbots.


13 months ago[MKHIVE] Fixes for the previous fixes. 920/head
Hermès Bélusca-Maïto [Mon, 8 Oct 2018 23:23:52 +0000 (01:23 +0200)]
[MKHIVE] Fixes for the previous fixes.

- Fix parsing of the options.
- Only uppercase the file name part and NOT the full path!
  And do it in a way GCC-Linux correctly understands, aka.:
      *ptr = toupper(*ptr); ++ptr;
  but NOT!:
      *ptr++ = toupper(*ptr);
  (that last one worked on GCC-Win and MSVC).

[CMAKE] Let's keep SETUPREG.HIV and BCD hive file names in uppercase
(use the '-u' switch) while keeping the other ones in lowercase.

Should definitively fix GCCLin builder!

13 months ago[MKHIVE] Remove support for '/' options, this does not behave well under Linux.
Hermès Bélusca-Maïto [Mon, 8 Oct 2018 22:25:01 +0000 (00:25 +0200)]
[MKHIVE] Remove support for '/' options, this does not behave well under Linux.

13 months ago[MKHIVE] Minor additional functionality.
Hermès Bélusca-Maïto [Mon, 8 Oct 2018 22:09:27 +0000 (00:09 +0200)]
[MKHIVE] Minor additional functionality.

- Add support for '/' switch characters.
- Add '-?' switch.

- Add a '-u' switch to generate hive file names in uppercase (by default
  we keep these in lowercase). Should help in fixing GCCLin builder.

[CMAKE] Fix expected file name case. Should help in fixing GCCLin builder.

13 months ago[MKHIVE] Improve dprint output (delimiting where strings start & end: is useful for... 560/head
Hermès Bélusca-Maïto [Sat, 3 Jun 2017 16:41:00 +0000 (16:41 +0000)]
[MKHIVE] Improve dprint output (delimiting where strings start & end: is useful for empty strings).

svn path=/branches/setup_improvements/; revision=74768

13 months ago[MKHIVE][CMAKE] Make mkhive a bit more flexible, so that it can generate only specifi...
Hermès Bélusca-Maïto [Fri, 2 Jun 2017 00:34:10 +0000 (00:34 +0000)]
[MKHIVE][CMAKE] Make mkhive a bit more flexible, so that it can generate only specific hives on-demand (and not all of them always at once).

This commit is needed for building a single bootcd registry hive. It will also enable 1-st stage setup to have a proper registry present as done on Windows.

Note that the mkhive commands should really depend on the generated UTF16 INF files since the latter are those that are actually used as input for mkhive.
Otherwise, the mkhive calls & the UTF16 INF file conversion is not serialized and we can generate "corrupted" hives due to the fact that mkhive is using
INF files that are in the process of being (and therefore, only partially) generated.

svn path=/branches/setup_improvements/; revision=74741
svn path=/branches/setup_improvements/; revision=74749

13 months ago[BOOTDATA][CMAKE] Enumerate the four first installation directories in 'canonical... 558/head
Hermès Bélusca-Maïto [Sun, 7 Jan 2018 00:46:31 +0000 (01:46 +0100)]
[BOOTDATA][CMAKE] Enumerate the four first installation directories in 'canonical' order, to keep compatibility with Windows' txtsetup.sif/layout.inf.

13 months ago[SYSSETUP] Delete the created fonts when needed.
Hermès Bélusca-Maïto [Sun, 20 May 2018 18:35:56 +0000 (20:35 +0200)]
[SYSSETUP] Delete the created fonts when needed.

13 months ago[SYSSETUP] Use ARRAYSIZE / _countof instead of sizeof ratios.
Hermès Bélusca-Maïto [Thu, 10 Aug 2017 18:59:26 +0000 (18:59 +0000)]
[SYSSETUP] Use ARRAYSIZE / _countof instead of sizeof ratios.

svn path=/branches/setup_improvements/; revision=75523

13 months ago[SYSSETUP] Code formatting.
Hermès Bélusca-Maïto [Thu, 10 Aug 2017 18:56:15 +0000 (18:56 +0000)]
[SYSSETUP] Code formatting.

svn path=/branches/setup_improvements/; revision=75522

13 months ago[USERINIT] Enhancements for starting ReactOS GUI installer or Explorer shell.
Hermès Bélusca-Maïto [Thu, 13 Jul 2017 19:10:27 +0000 (19:10 +0000)]
[USERINIT] Enhancements for starting ReactOS GUI installer or Explorer shell.

- Transform TryToStartShell() into a StartProcess() function whose aim
  is just to start processes, since there is no extra initialization needed
  for starting a shell process.

- Modify StartInstaller() to call StartProcess() for starting the ReactOS GUI
  installer found on the installation media, from a path automatically expanded
  depending on the ambient CPU architecture.

svn path=/branches/setup_improvements/; revision=75331

13 months ago[WELCOME] Minor usage improvements.
Hermès Bélusca-Maïto [Mon, 8 Oct 2018 18:54:59 +0000 (20:54 +0200)]
[WELCOME] Minor usage improvements.

- Don't hardcode the installer file name in ExpandInstallerPath() but
  provide it from a parameter. Return TRUE/FALSE if the installer file
  is/is not found.

- Expand any environment string present in the items command line.

- Enable/disable the menu buttons depending on whether or not an
  associated command is present.

- Enable mirroring from resources.

13 months ago[WELCOME] Reduce Welcome's SUBSYSTEM requirements to WinNT 4 for x86 builds only...
Hermès Bélusca-Maïto [Sun, 20 May 2018 19:59:40 +0000 (21:59 +0200)]
[WELCOME] Reduce Welcome's SUBSYSTEM requirements to WinNT 4 for x86 builds only, so that we can still show something in old NT OSes.

13 months ago[WELCOME] Automatically expands the path to the ReactOS installer executable found...
Hermès Bélusca-Maïto [Thu, 13 Jul 2017 18:41:32 +0000 (18:41 +0000)]
[WELCOME] Automatically expands the path to the ReactOS installer executable found on the installation media, depending on the ambient CPU architecture.

svn path=/branches/setup_improvements/; revision=75330

13 months ago[NETCFGX] NetPropPageProvider: Add Base and Step parameter options.
Eric Kohl [Mon, 8 Oct 2018 16:55:39 +0000 (18:55 +0200)]
[NETCFGX] NetPropPageProvider: Add Base and Step parameter options.

13 months ago[SYSTEMINFO] Improve uptime source
Stanislav Motylkov [Mon, 8 Oct 2018 13:06:48 +0000 (16:06 +0300)]
[SYSTEMINFO] Improve uptime source

13 months ago[ROSTESTS] Add a test program. (#890) 919/head
Baruch Rutman [Fri, 28 Sep 2018 15:13:08 +0000 (18:13 +0300)]
[ROSTESTS] Add a test program. (#890)

Add a test program that shows how the *PSMTextOut() functions draw
the strings by a side by side comparison between LpkPSMTextOut() and

13 months ago[LPK] Small fix and a related comment. (#890)
Baruch Rutman [Fri, 28 Sep 2018 15:10:10 +0000 (18:10 +0300)]
[LPK] Small fix and a related comment. (#890)

[LPK][USER32] Fix reading layout checks.

- Both functions don't care about DT_RTLREADING flag.
- Added a different method to check reading order.

[USER32] Remove gcc-build breaker semicolon.

13 months ago[USER32] Implement UserLpkPSMTextOut(). (#890)
Baruch Rutman [Fri, 28 Sep 2018 15:02:38 +0000 (18:02 +0300)]
[USER32] Implement UserLpkPSMTextOut(). (#890)

This function is a condensed version of LpkPSMTextOut() (from lpk.dll),
but not bug-for-bug equivalent.
The main difference is that the underscore is drawn without taking into
account any kind of script processing.

13 months ago[LPK] Implement LpkPSMTextOut(). (#890)
Baruch Rutman [Thu, 27 Sep 2018 22:00:31 +0000 (01:00 +0300)]
[LPK] Implement LpkPSMTextOut(). (#890)

- The function is almost fully implemented, but some return values change wildly.
  The results are mostly compatible to the Windows results.

- Remove #ifdef (this is primary ReactOS code).

13 months ago[APPWIZ] Update russian translation (#917)
Stanislav Motylkov [Mon, 8 Oct 2018 12:53:11 +0000 (15:53 +0300)]
[APPWIZ] Update russian translation (#917)