Alexander Rechitskiy [Sat, 29 Sep 2018 14:43:32 +0000 (17:43 +0300)]
[README] Add a link to the nightly builds page for convenience (#881)
Pierre Schweitzer [Sat, 29 Sep 2018 14:21:44 +0000 (16:21 +0200)]
[NTOSKRNL] Don't lock file object on close if we're not called by Ob
IopCloseFile can be called by IopDeleteFile. In that situation, it
doesn't set any process as first parameter. Furthermore, we are in a
situation where it's not required to lock the file object (see the
assert before the call).
Abdulganiev Rafael [Sat, 29 Sep 2018 14:24:10 +0000 (18:24 +0400)]
[DESK.CPL] Remove monitor resource scaling (#876)
Stanislav Motylkov [Thu, 16 Aug 2018 19:31:03 +0000 (22:31 +0300)]
[SYSDM] Add hardware model name print
Stanislav Motylkov [Thu, 16 Aug 2018 18:53:45 +0000 (21:53 +0300)]
[SYSDM] Add one more IDC_MACHINELINE for model name
Stanislav Motylkov [Thu, 16 Aug 2018 18:48:05 +0000 (21:48 +0300)]
[SYSDM] Move system information controls 16 points higher
Stanislav Motylkov [Wed, 15 Aug 2018 17:43:01 +0000 (20:43 +0300)]
[UDMIHELP] Initialize output buffer if DMI string is NULL
Stanislav Motylkov [Thu, 27 Sep 2018 19:02:17 +0000 (22:02 +0300)]
[DMILIB] Process SKU and Family strings
Eric Kohl [Sat, 29 Sep 2018 12:58:55 +0000 (14:58 +0200)]
[MSPORTS] Implement the 'Filter Resource Method' setting for parallel ports
Pierre Schweitzer [Sat, 29 Sep 2018 09:36:45 +0000 (11:36 +0200)]
[DEVCPUX] Add French translation
Pierre Schweitzer [Sat, 29 Sep 2018 09:21:19 +0000 (11:21 +0200)]
[NTOSKRNL] Reference the file object before issuing the unlock all IRP
This fixes the last kmode assert triggered by httpd on ReactOS.
CORE-12045
Eric Kohl [Fri, 28 Sep 2018 23:57:59 +0000 (01:57 +0200)]
[msports] Notify the system of changes to the serial port settings.
Eric Kohl [Fri, 28 Sep 2018 23:31:02 +0000 (01:31 +0200)]
[SERVICES] Control set code clean-up
- Flush the new control set after the control set has been created.
- Make sure that we create a new control set only on the first boot after setup.
- Move the control set copy code to a separate function.
- Get rid of the global control set values.
Pierre Schweitzer [Fri, 28 Sep 2018 21:34:28 +0000 (23:34 +0200)]
[NTOSKRNL] Unlock file if required on last process handle close
Eric Kohl [Fri, 28 Sep 2018 15:51:12 +0000 (17:51 +0200)]
[SERVICES] RChangeServiceConfigW / RCreateServiceW: Use SecureZeroMemory to wipe clear-text passwords after use.
Eric Kohl [Fri, 28 Sep 2018 15:29:31 +0000 (17:29 +0200)]
[SERVICES] Fixed a missing comma
Eric Kohl [Fri, 28 Sep 2018 14:24:07 +0000 (16:24 +0200)]
[SERVICES] Create a new control set on a non-setup boot.
Hermès Bélusca-Maïto [Thu, 27 Sep 2018 22:36:59 +0000 (00:36 +0200)]
[ADVAPI32] Improve a bit CreateProcessAsUser().
- Check whether the user-provided token is a primary token.
- Do not fail when the RtlAdjustPrivilege() call fails (see the code
comment for an explanation). TL;DR is: that call may indeed fail but
the privilege may also not be necessary because the user-provided
token is a restricted version of the caller's primary token.
And this is situation is perfectly fine.
This fixes Java 7 installation, CORE-14874.
Hermès Bélusca-Maïto [Tue, 25 Sep 2018 23:33:02 +0000 (01:33 +0200)]
[NTOS:PS] In PspSetPrimaryToken(), check also for sibling token to determine whether it is required to have the SeAssignPrimaryTokenPrivilege.
In addition, it is the presence or absence of the 'Token' pointer that indicates whether or not we should use instead the provided token handle.
Hermès Bélusca-Maïto [Tue, 25 Sep 2018 22:51:38 +0000 (00:51 +0200)]
[NTOS:SE] Fixes for NT tokens.
- SeIsTokenChild(): Correctly check whether a caller-provided token
is a child from the current process' primary token by looking at
its ParentTokenId member.
- Add a SeIsTokenSibling() helper to determine whether a caller-provided
token and the current process' primary token are siblings, by comparing
their ParentTokenId's and AuthenticationId's.
NOTE: Children tokens are created through CreateRestrictedToken();
sibling tokens are created through DuplicateToken() (amongst others).
See slide 49 of https://www.slideshare.net/Shakacon/social-engineering-the-windows-kernel-by-james-forshaw
or https://googleprojectzero.blogspot.com/2016/01/raising-dead.html
for some details.
Bișoc George [Tue, 25 Sep 2018 14:50:13 +0000 (16:50 +0200)]
[DWNL] Add translations (for Romanian & Italian)
And include them as well.
Stanislav Motylkov [Wed, 26 Sep 2018 13:15:07 +0000 (16:15 +0300)]
[DEVCPUX] Add russian translation
Also make MHz string translatable. Addendum to
793e2a3.
Eric Kohl [Wed, 26 Sep 2018 21:48:01 +0000 (23:48 +0200)]
[NETCFGX] Add the most simple property sheet provider for network adapters
- Switch to WINE debug code.
- Build the UNICODE version of the DLL by default.
- Add the most simple property sheet provider.
Eric Kohl [Wed, 26 Sep 2018 21:42:00 +0000 (23:42 +0200)]
[SETUPAPI] SetupDiGetClassDevPropertySheetsW: Support class property sheet providers.
Stanislav Motylkov [Tue, 25 Sep 2018 14:36:48 +0000 (17:36 +0300)]
[MSPORTS] Add russian translation
Addendum to
69e834f.
Eric Kohl [Tue, 25 Sep 2018 19:51:19 +0000 (21:51 +0200)]
[DEVCPUX] Make the CPU property sheet page a little nicer and make it translatable
Eric Kohl [Tue, 25 Sep 2018 15:48:27 +0000 (17:48 +0200)]
[MSPORTS] Hackfix the code to determine the serial and parallel port numbers.
Now that SetupDiCreateDevRegKeyW is working as expected, we can no
longer (ab)use it to retrieve a ports resources. Use SetupDiGetDeviceInstanceIdW instead and open the registry keys manually.
Eric Kohl [Tue, 25 Sep 2018 12:27:10 +0000 (14:27 +0200)]
[MSPORTS] Implement serial port settings
- Fix the control styles and grouping in the dialogs.
- Implement reading, modifying and writing of the serial port settings.
Stanislav Motylkov [Tue, 25 Sep 2018 08:41:34 +0000 (11:41 +0300)]
[INF] Add russian translation to machine.inf
Addendum to
68eb0fd.
Eric Kohl [Mon, 24 Sep 2018 14:15:46 +0000 (16:15 +0200)]
[INF] machine.inf: Add settings for PCI RAM controllers
Eric Kohl [Sun, 23 Sep 2018 21:31:00 +0000 (23:31 +0200)]
[NETSHELL] Read, write and display the 'Notify me when this connection...' option for network connections.
Eric Kohl [Sun, 23 Sep 2018 18:17:35 +0000 (20:17 +0200)]
[SETUPAPI] Replace the remaining internal calls to SetupDiOpenDevRegKey and SetupDiCreateDevRegKeyW by calls to SETUPDI_OpenDrvKey, SETUPDI_CreateDevKey or SETUPDI_CreateDrvKey.
Mark Jansen [Sun, 23 Sep 2018 17:28:09 +0000 (19:28 +0200)]
[WIN32K] Work around GCC builds inventing dead keys.
CORE-14948
Mark Jansen [Sun, 23 Sep 2018 17:27:02 +0000 (19:27 +0200)]
[SHELL32_APITEST] Speed up the CUserNotification test in the failure case.
Hermès Bélusca-Maïto [Sat, 22 Sep 2018 13:41:17 +0000 (15:41 +0200)]
[SERVICES] Simplify the implementation of RGetServiceDisplayNameA/W() and RGetServiceKeyNameA/W().
Also comment about the observed behaviour of the returned number of "characters"
returned by the ANSI versions of these APIs (which is tested by advapi32_winetest:service).
[ADVAPI32:SCM] Add a comment concerning wide characters vs. bytes mismatch.
Eric Kohl [Sun, 23 Sep 2018 14:15:14 +0000 (16:15 +0200)]
[SETUPAPI] Do not use SetupDiOpenDevRegKey in other SetupDi functions. Use SETUPDI_OpenDevKey or SETUPDI_OpenDrvKey instead.
Note: The remaining calls to SetupDiOpenDevRegKey and SetupDiCreateDevRegKey will be fixed in another patch.
Fixes CORE-15091
Pierre Schweitzer [Sun, 23 Sep 2018 08:31:01 +0000 (10:31 +0200)]
[NTOSKRNL] Properly align VACB writes
Also simplify VACB reads alignment code.
Also add some sanity ASSERTs.
Hermès Bélusca-Maïto [Sat, 22 Sep 2018 22:12:24 +0000 (00:12 +0200)]
[BOOTDATA] Factorize the creation of user profile directories inside a helper function that can be called with different parameters.
Hermès Bélusca-Maïto [Sat, 22 Sep 2018 22:07:07 +0000 (00:07 +0200)]
[SHELL32] In _SHExpandEnvironmentStrings(), fall back to SHExpandEnvironmentStringsForUserW() if the simplified code paths failed.
This allows the code to give a last chance for expanding the string.
And if it still fails, we bail out as expected and the caller will
take appropriate actions.
As a by-product, this commit (together with the previous one
e2960914)
fixes the regression CORE-14981 (Quick-Launch bar couldn't be opened
in LiveCD).
Hermès Bélusca-Maïto [Sat, 22 Sep 2018 21:37:43 +0000 (23:37 +0200)]
[SHELL32] In _SHGetUserShellFolderPath(), check the return value of _SHExpandEnvironmentStrings()
and bail out if it failed. That way we won't use and cache in the registry an invalid-expanded string.
CORE-14981
Hermès Bélusca-Maïto [Sat, 22 Sep 2018 20:19:14 +0000 (22:19 +0200)]
[SHELL32] Partially synchronize wine/shellpath.c with Wine.
- Adjust the code with respect to:
"shell32: Re-add support for expanding ALLUSERSPROFILE for backward compatibility."
4a6855a575c02aa1569aab8b2e96720fc02f3f26 (Alexandre Julliard)
- "shell32: Avoid infinite loop in _SHExpandEnvironmentStrings."
ceea5bda14ecf4c8ce262fc7ab88df49e500bc38 (Alexandre Julliard)
- "shell32: Assume that system directory always contains a drive letter."
54530bc4933ae1014c3697c95e22b8ca5a275bc4 (Alexandre Julliard)
- "shell32: Use ARRAY_SIZE macro."
612a1941331485725952d34f3dcd5866fc318dc2 (Nikolay Sivov)
- "shell32: Fix a trace message."
bb09bb5750d617047aa23635731519a2f9486159 (Nikolay Sivov)
- "shell32: Fix SHGetFolderPathAndSubDir() trace message."
f75d5625966933562b974540a3f29dfcd720ad50 (Nikolay Sivov)
- "shell32: Pass correct buffer length to RegQueryValueExW()."
0bfb97dcba29552b51d8609fcc6e7bbc04bb8320 (Nikolay Sivov)
- "shell32: Remove unused string (Clang)."
8d50a8a246960749afba21eac117b4fcbbf2c79d (André Hentschel)
- "shell32: Use E_NOT_SUFFICIENT_BUFFER definition."
730e744e3bd6b706612fe0f90a7efb2e600f114f (Nikolay Sivov)
Bișoc George [Sat, 22 Sep 2018 19:40:57 +0000 (21:40 +0200)]
[MSCONFIG_NEW] Do not assign an access key to a letter with diacritic
Paweł Cholewa [Sat, 22 Sep 2018 12:53:13 +0000 (14:53 +0200)]
[DWNL] Add Polish translation
Eric Kohl [Sat, 22 Sep 2018 12:43:43 +0000 (14:43 +0200)]
[SETUPAPI] SetupDiCreateDevRegKeyW / SetupDiOpenDevRegKey: Create or open the 'Device Parameters' subkey of the given devices enum key when we try to access its hardware key.
This creates the PortName value in the proper location for serial ports.
Eric Kohl [Sat, 22 Sep 2018 09:20:27 +0000 (11:20 +0200)]
[NTOSKRNL] IoGetDeviceProperty: Add support for the DevicePropertyRemovalPolicy property.
This could probably fix CORE-15068.
Abdulganiev Rafael [Fri, 21 Sep 2018 21:42:27 +0000 (01:42 +0400)]
[BTHCI] Add a bluetooth icon (#871)
[BTHCI] Add a bluetooth icon
Pierre Schweitzer [Fri, 21 Sep 2018 20:35:33 +0000 (22:35 +0200)]
[DWNL] Add French translation
Eric Kohl [Fri, 21 Sep 2018 13:37:34 +0000 (15:37 +0200)]
[NTOSKRNL] Create the 'Device Parameters' subkey and add the 'FirmwareIdentified' value for all ACPI-enumerated devices.
Eric Kohl [Fri, 21 Sep 2018 13:08:43 +0000 (15:08 +0200)]
[NTOSKRNL] Fix the indentation of some pnp manager functions.
Pierre Schweitzer [Fri, 21 Sep 2018 06:35:38 +0000 (08:35 +0200)]
[KMTESTS:CC] Add tests for CcCopyRead that reproduce CORE-15067
CORE-15067
Pierre Schweitzer [Fri, 21 Sep 2018 06:31:05 +0000 (08:31 +0200)]
[NTOSKRNL] Avoid integer overflow when computing VACB read/write size
This could be triggered when attempting to read/write to really big
files. It was causing an attempt to read 0 bytes in Cc, leading to
asserts failure in the kernel (and corrupted file).
CORE-15067
Joachim Henze [Fri, 21 Sep 2018 01:04:31 +0000 (03:04 +0200)]
[WIN32K:NTUSER] Fix WIN32K BSOD mentioned in CORE-15027
Fixes accessing nullptr / invalid handle in Window->SystemMenu
I could trigger this occasionally when moving Opera 12.18 window
in front of Spotify 1.0.29.92 window.
Fix was:
authored by Thomas Faber (Thank you!)
tested by me
reviewed by James Tabor
Eric Kohl [Thu, 20 Sep 2018 15:53:08 +0000 (17:53 +0200)]
[BTHCI] Add a bluetooth class installer stub.
Now we really need a tango-compatible bluetooth icon!
Eric Kohl [Thu, 20 Sep 2018 11:52:03 +0000 (13:52 +0200)]
[INF] Add german translation to the bluetooth class inf file.
Robert Naumann [Thu, 20 Sep 2018 07:20:14 +0000 (09:20 +0200)]
[DWNL] forgot this file
Robert Naumann [Thu, 20 Sep 2018 07:16:22 +0000 (09:16 +0200)]
[DWNL] German translation
Joachim Henze [Wed, 19 Sep 2018 20:51:07 +0000 (22:51 +0200)]
[SCHEDSVC] Fix a typo in debug print that was introduced in 0.4.10-dev-544-g
0d13bb10151e226df996f6c1d5b509dbe000446d
Eric Kohl [Wed, 19 Sep 2018 14:35:12 +0000 (16:35 +0200)]
[WLNOTIFY] Disable the Logoff-Handler routine for the scheduler service.
The Logoff-Handler might try to notify the scheduler service which might already have been shut down. We need to fix the shutdown sequence, so that the service manager stops all running services.
Might fix CORE-14521.
Eric Kohl [Wed, 19 Sep 2018 10:28:58 +0000 (12:28 +0200)]
[ADVAPI32][SERVICES] Use the session key provided by SystemFunction028 to encrypt and decrypt the service passwords.
Stanislav Motylkov [Tue, 18 Sep 2018 21:21:09 +0000 (00:21 +0300)]
[DWNL] Improve print date
Stanislav Motylkov [Tue, 18 Sep 2018 21:19:22 +0000 (00:19 +0300)]
[DWNL] Add russian translation
Eric Kohl [Tue, 18 Sep 2018 21:57:54 +0000 (23:57 +0200)]
[ADVAPI32] Implement SystemFunction028 to always return the default session key.
Lee Schroeder [Tue, 18 Sep 2018 21:55:44 +0000 (15:55 -0600)]
[DWNL] Localize the File Download utility (#853)
Also, changed header string to include a start time stamp similar to the one in wget.
CORE-14498
Pierre Schweitzer [Tue, 18 Sep 2018 19:42:01 +0000 (21:42 +0200)]
[NTOSKRNL] Stub IoInitializeCrashDump()
Also call it from NtCreatePagingFile() when we have successfully created
a paging file on the system boot partition.
Eric Kohl [Tue, 18 Sep 2018 19:33:29 +0000 (21:33 +0200)]
[ADVAPI32][SERVICES] Pass encrypted passwords to the service manager.
- Encrypt passwords before passing them to the service manager. Right now, we are using a fixed encryption key. This will be fixed later.
- Replace the calls to ZeroMemory which are used to wipe the password buffers by calls to SecureZeroMemory.
Eric Kohl [Tue, 18 Sep 2018 13:55:18 +0000 (15:55 +0200)]
[IDL][LSASRV] Improve the credentials interface a little and update the lsa server code accordingly.
Eric Kohl [Mon, 17 Sep 2018 22:24:36 +0000 (00:24 +0200)]
[ADVAPI32_WINETEST] Fix the STATUS issues
Eric Kohl [Mon, 17 Sep 2018 21:19:02 +0000 (23:19 +0200)]
[ADVAPI32] SystemFunction004 and SystemFunction005 must return the required output buffer size via out->Length when the buffer is too small.
Eric Kohl [Mon, 17 Sep 2018 21:12:16 +0000 (23:12 +0200)]
[ADVAPI32_WINETEST] Add tests for SystemFunction004 and SystemFunction005.
These tests show that the required output buffer size it returned in out.Length field when STATUS_BUFFER_TOO_SMALL is returned.
This patch will be sent upstream.
Eric Kohl [Mon, 17 Sep 2018 14:34:48 +0000 (16:34 +0200)]
[ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted passwords to the service manager
Hermès Bélusca-Maïto [Sun, 16 Sep 2018 21:56:59 +0000 (23:56 +0200)]
[RPCSS] During the setup phase, the RPCSS service, initially running under the LocalSystem account, should re-configure itself to run under the NetworkService account.
This will also fix MS Office 2010 installation, where the installation
expects the NetworkService account profile to be already loaded (this
condition is always verified on Windows since RPCSS and other services
also run under this account).
CORE-14988, CORE-14989
Hermès Bélusca-Maïto [Sun, 16 Sep 2018 21:22:04 +0000 (23:22 +0200)]
[SERVICES] Add basic support for setting lpServiceStartName via RChangeServiceConfigW().
Hermès Bélusca-Maïto [Sun, 16 Sep 2018 21:16:17 +0000 (23:16 +0200)]
[SERVICES] Minor code style fixes; replace wcslen(xxx) ==/!= 0 and strcpy(string, 'empty-string') calls.
Eric Kohl [Sun, 16 Sep 2018 19:10:36 +0000 (21:10 +0200)]
[NETAPI32] Add more DFS stubs
Bișoc George [Sun, 16 Sep 2018 17:27:31 +0000 (19:27 +0200)]
[MSCONFIG_NEW] Small Romanian translation update
Bișoc George [Sun, 16 Sep 2018 17:23:15 +0000 (19:23 +0200)]
[CHARMAP_NEW] Update the E-mail header string
Extravert-ir [Sun, 16 Sep 2018 14:14:07 +0000 (17:14 +0300)]
[FREELDR] Fix MSVC warnings C4146 (#863)
BieHDC [Sun, 16 Sep 2018 14:05:15 +0000 (16:05 +0200)]
[GITIGNORE] Ignore [boot|live|hybrid]cd_extras (#866)
Exclude [boot|live|hybrid]cd_extras from git as well since they are not part of the source code itself.
Pierre Schweitzer [Sun, 16 Sep 2018 12:50:01 +0000 (14:50 +0200)]
[KERNEL32_VISTA] Make SleepConditionVariableSRW fail when it times out
This fixes a few newly added winetests.
Pierre Schweitzer [Sun, 16 Sep 2018 12:42:43 +0000 (14:42 +0200)]
[KERNEL32_VISTA] Make SleepConditionVariableCS fail when it times out
This fixes a few newly added winetests.
Pierre Schweitzer [Sun, 16 Sep 2018 10:03:08 +0000 (12:03 +0200)]
[KERNEL32_WINETEST] Enable ConditionVariable and SRW lock tests
If we cannot find the functions in kernel32, try to get them from
kernel32_vista. This will allow testing our own implementation, while
still failing in W2K3 (no implementation available).
Bernhard Feichtinger [Sat, 15 Sep 2018 21:08:30 +0000 (23:08 +0200)]
[RAMDISK] Implement missing IOCTLs
Mark Jansen [Fri, 11 May 2018 20:23:52 +0000 (22:23 +0200)]
[KERNEL32] Ensure the PebLock is always released in FlsFree
Mark Jansen [Fri, 11 May 2018 20:22:47 +0000 (22:22 +0200)]
[KERNEL32_APITEST] Test FLS locking & exception behavior.
Mark Jansen [Thu, 10 May 2018 20:23:16 +0000 (22:23 +0200)]
[NTDLL][KERNEL32] Implement FLS callbacks.
Mark Jansen [Tue, 8 May 2018 20:09:04 +0000 (22:09 +0200)]
[KERNEL32_APITEST] Add test exposing FLS internals.
Eric Kohl [Sat, 15 Sep 2018 12:10:01 +0000 (14:10 +0200)]
[DESK] Add MonitorClassInstaller
Pierre Schweitzer [Sat, 15 Sep 2018 08:54:00 +0000 (10:54 +0200)]
[SHELLBTRFS] Fix GCC build
CORE-15048
Thomas Faber [Sat, 15 Sep 2018 07:43:09 +0000 (09:43 +0200)]
[SHELLBTRFS] Add exports according to upstream .def file. CORE-15048
Pierre Schweitzer [Fri, 14 Sep 2018 20:30:41 +0000 (22:30 +0200)]
[MPR] Import Wine commit:
93fb279f4f3e150eee329b02ca5fb0251d8a239d
Properly handle device-less connections.
CORE-15012
Stanislav Motylkov [Sun, 9 Sep 2018 13:50:27 +0000 (16:50 +0300)]
[USETUP] Make countdown progress bar smoother
Stanislav Motylkov [Sun, 9 Sep 2018 15:45:41 +0000 (18:45 +0300)]
[USETUP] Update Russian translation
Stanislav Motylkov [Wed, 12 Sep 2018 19:16:45 +0000 (22:16 +0300)]
[SYSDM.CPL] Fixup control positions after font metrics fix
Stanislav Motylkov [Wed, 12 Sep 2018 18:42:06 +0000 (21:42 +0300)]
[DESK.CPL] Settings: Fixup control positions
Stanislav Motylkov [Wed, 12 Sep 2018 18:31:48 +0000 (21:31 +0300)]
[DESK.CPL] Screensaver: Fixup control positions
Stanislav Motylkov [Wed, 12 Sep 2018 18:04:49 +0000 (21:04 +0300)]
[DESK.CPL] Background: Fixup control positions after font metrics fix
Stanislav Motylkov [Wed, 12 Sep 2018 17:49:26 +0000 (20:49 +0300)]
[DESK.CPL] Appearance: Fixup control positions after font metrics fix
CORE-14274
Katayama Hirofumi MZ [Fri, 14 Sep 2018 09:04:36 +0000 (18:04 +0900)]
[TRANSLATION] Update Romanian translation (#851)
Translation from Stefan Fulea.
CORE-15023
Pierre Schweitzer [Fri, 14 Sep 2018 06:15:08 +0000 (08:15 +0200)]
[WINLOGON] Fix build
Add a specific internal header for MPR and include it in WinLogon.
CORE-15012
Pierre Schweitzer [Fri, 14 Sep 2018 06:06:13 +0000 (08:06 +0200)]
[MPR] Import Wine commit:
0799550075654094a3bed080aac722b9bea01307
Implement WNetClearConnections().
CORE-15012