Amine Khaldi [Sat, 9 Dec 2017 19:03:08 +0000 (20:03 +0100)]
[GDI32_APITEST] Properly add CreateDIBPatternBrush.c to the source files list instead of relying on CMake to do so.
Amine Khaldi [Sat, 9 Dec 2017 18:58:43 +0000 (19:58 +0100)]
[ACLEDIT][ATL][ATL80][FLTMGR] Get the def files out of the source files lists. #179
Pierre Schweitzer [Sat, 9 Dec 2017 13:35:22 +0000 (14:35 +0100)]
[FASTFAT] Finally drop the FileNameInformation class for directories.
It makes no sense for them and shouldn't be implemented.
It's an addendum to
9f3c801.
Amine Khaldi [Sat, 9 Dec 2017 13:18:25 +0000 (14:18 +0100)]
[FREELDR] The work done in r70692 overlooked the need to update the PCH lists of source files as well.
- We use this as a chance to also update the CMake file in terms of consistency.
- The clang-cl build applies the /Os flag on all the source files that are now using the PCH too.
Colin Finck [Sat, 9 Dec 2017 12:35:42 +0000 (13:35 +0100)]
[WINSPOOL] Provide stubs with tracing and reasonable failure codes for even more popular Spooler APIs.
This may get more applications to work which previously called into the WINE-generated stubs (that throw an exception).
It also improves debug logs when the "winspool" debug channel is enabled. With such detailed debug logs, we may get an idea which winspool APIs need to be implemented sooner than others.
Colin Finck [Sat, 9 Dec 2017 11:00:09 +0000 (12:00 +0100)]
[WINSPOOL] Add tracing to all exported APIs.
Colin Finck [Sat, 9 Dec 2017 09:59:40 +0000 (10:59 +0100)]
[WINSPOOL] Convert the returned Unicode string back to ANSI in GetDefaultPrinterA.
Thanks to Mark for the hint in CORE-14072!
Amine Khaldi [Sat, 9 Dec 2017 12:58:55 +0000 (13:58 +0100)]
[USER32_WINETEST] Add a PCH.
Amine Khaldi [Sat, 9 Dec 2017 12:40:23 +0000 (13:40 +0100)]
[ACPPAGE] Make use of the PCH.
Amine Khaldi [Sat, 9 Dec 2017 12:36:45 +0000 (13:36 +0100)]
[MSPAINT] Add some header guards.
Amine Khaldi [Sat, 9 Dec 2017 12:29:58 +0000 (13:29 +0100)]
[LSASRV] Deduplicate SAMPR_ULONG_ARRAY.
Amine Khaldi [Sat, 9 Dec 2017 12:24:35 +0000 (13:24 +0100)]
[MSAFD] Move the default debug channel to msafd.h.
Amine Khaldi [Sat, 9 Dec 2017 12:20:22 +0000 (13:20 +0100)]
[HAL] Add some header guards.
Amine Khaldi [Sat, 9 Dec 2017 12:11:45 +0000 (13:11 +0100)]
[VGA] Correct VgaInterpretCmdStream() declaration.
Amine Khaldi [Sat, 9 Dec 2017 12:04:23 +0000 (13:04 +0100)]
[UUID] Add a PCH.
Pierre Schweitzer [Sat, 9 Dec 2017 11:45:16 +0000 (12:45 +0100)]
[FASTFAT] Fix size checking in VfatGetFileNameInformation()
Pierre Schweitzer [Sat, 9 Dec 2017 11:33:29 +0000 (12:33 +0100)]
[FASTFAT] Don't mix FileNameInformation and FileNamesInformation (and support the later).
This commit fixes weird behavior in our FastFAT implementation. It was mixing two classes:
FileNameInformation and FileNamesInformation. It was handling FileNameInformation like
FileNamesInformation and was filling buffer with FILE_NAMES_INFORMATION structure instead
of FILE_NAME_INFORMATION structure (how many things did that break?!).
Also, it wasn't implementing the FileNamesInformation class at all. This is required by
ntdll_winetest:directory which doesn't expect it to fail and thus, attempts to read
never filled in memory.
This commit fixes the winetest crash, and may fix other weird FS behavior.
CORE-13367
Amine Khaldi [Sat, 9 Dec 2017 11:32:18 +0000 (12:32 +0100)]
[SAMLIB] Use precomp.h in dllmain.c.
Mark Jansen [Fri, 8 Dec 2017 23:51:56 +0000 (00:51 +0100)]
[SHELL32_APITEST] Add test for SHCreateFileExtractIconW
CORE-14082
Pierre Schweitzer [Sat, 9 Dec 2017 10:53:54 +0000 (11:53 +0100)]
[KERNEL32] Silent a noisy DPRINT1
Katayama Hirofumi MZ [Sat, 9 Dec 2017 10:06:51 +0000 (19:06 +0900)]
[WIN32K] Fix NtGdiGetTextFaceW to report face name correctly (#173)
Initialize TEXTOBJ.FaceName member in TextIntRealizeFont and use it in NtGdiGetTextFaceW
CORE-14071
Pierre Schweitzer [Sat, 9 Dec 2017 09:59:37 +0000 (10:59 +0100)]
[FASTFAT] Calculate more accurately buffer length in VfatGetAllInformation().
Pierre Schweitzer [Sat, 9 Dec 2017 09:58:19 +0000 (10:58 +0100)]
[FASTFAT] Allow partial returns on directory info query for first entry.
This mimics what MS FastFAT does and fixes (a bit) ntdll_winetest:directory.
It still crashes, but go farther.
CORE-13367
Amine Khaldi [Fri, 8 Dec 2017 22:15:31 +0000 (23:15 +0100)]
[STOBJECT] Improve the existing PCH and make use of it.
Amine Khaldi [Fri, 8 Dec 2017 22:04:48 +0000 (23:04 +0100)]
[CONSRV] Deduplicate GetScreenBufferSizeUnits(), SmallRectToRect() and ConsoleInput. Rename ConsoleList and InsertConsole(). #179
Pierre Schweitzer [Fri, 8 Dec 2017 21:45:04 +0000 (22:45 +0100)]
[SERVICES] Fix querying the status of a registered but not started driver.
The current implementation was broken and some dead code was never called; always failing before.
This fix revives this dead code!
Extra fix: avoid derefencing potential null-ptr.
And also, as bonus, comment the function so that logic can be easily understood.
CORE-14062
Thomas Faber [Tue, 21 Nov 2017 22:36:34 +0000 (23:36 +0100)]
[NTOS:MM] Implement and use MiAcquirePfnLockAtDpcLevel/MiReleasePfnLockFromDpcLevel.
Thomas Faber [Tue, 21 Nov 2017 22:33:42 +0000 (23:33 +0100)]
[NTOS:MM] Use inline functions to acquire/release the PFN lock.
Serge Gautherie [Sun, 26 Nov 2017 23:51:18 +0000 (00:51 +0100)]
[NTDLL_APITEST] Create Test_NtFreeVirtualMemory_Parameters(). CORE-13126
- Test 4th parameter ("ULONG FreeType") invalid values.
Thomas Faber [Thu, 7 Dec 2017 11:25:01 +0000 (12:25 +0100)]
[NTDLL_APITEST] Add license header for NtFreeVirtualMemory.c
James Tabor [Fri, 8 Dec 2017 03:14:21 +0000 (21:14 -0600)]
[User32|IMM32] Fix a recursion crash in IMM. See CORE-14041.
Required a sync port from wine. This is a hack fix with Win32SS until
proper IMM support is added to Win32SS.
Amine Khaldi [Thu, 7 Dec 2017 23:22:05 +0000 (00:22 +0100)]
[ADVAPI32_APITEST][NTDLL_APITEST][WINDOWSCODECS] Comment out some unused functions and types. Silences some clang-cl warnings.
Amine Khaldi [Thu, 7 Dec 2017 23:06:13 +0000 (00:06 +0100)]
[COMCTL32][FLTLIB][NETAPI32][SNDVOL32][STOBJECT][WBEMPROX] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings.
Amine Khaldi [Thu, 7 Dec 2017 22:54:22 +0000 (23:54 +0100)]
[SHELL32] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings.
Amine Khaldi [Thu, 7 Dec 2017 22:34:28 +0000 (23:34 +0100)]
[ADVAPI32] Remove unused debug channels and comment out unused variables. Silences some clang-cl warnings.
Amine Khaldi [Thu, 7 Dec 2017 22:26:59 +0000 (23:26 +0100)]
[FREETYPE][PORTCLS][RPCSS][SPOOLSV][STLPORT][USETUP][WLANSVC] Silence some clang-cl warnings.
Amine Khaldi [Thu, 7 Dec 2017 22:22:27 +0000 (23:22 +0100)]
[CMAKE/CLANG-CL] Don't pass /TP twice when we're dealing with a clang-cl c++ PCH. Pass -nostdinc instead of /X on clang-cl builds.
CNAmira [Thu, 7 Dec 2017 21:53:48 +0000 (05:53 +0800)]
[TRANSLATION] Update Simplified Chinese translations. (#170)
- Add Simplified Chinese translation for EVENTCREATE.
- Update translations for 'dxdiag', 'fontview', 'magnify', 'mmc', 'rapps' and 'wordpad'.
Patch by Li Keqing.
Amine Khaldi [Thu, 7 Dec 2017 21:37:40 +0000 (22:37 +0100)]
[USER32] We're still using this one. Fixes build.
Giannis Adamopoulos [Thu, 7 Dec 2017 21:24:32 +0000 (23:24 +0200)]
[BROWSEUI] Move _ILIsDesktop to a shared header to avoid having 3 instances of it
Amine Khaldi [Thu, 7 Dec 2017 21:24:40 +0000 (22:24 +0100)]
[USER32] Remove unused debug channels. Silences some clang-cl warnings.
Hermès Bélusca-Maïto [Thu, 7 Dec 2017 18:35:20 +0000 (19:35 +0100)]
[CMD] Fix resource string (unrecognized escape sequence); addendum to
9a59558.
Amine Khaldi [Sun, 3 Dec 2017 22:30:10 +0000 (23:30 +0100)]
[CMAKE/CLANG-CL] Silence some clang-cl warnings in consistency with our gcc build.
Serge Gautherie [Thu, 30 Nov 2017 00:44:40 +0000 (01:44 +0100)]
[NTDLL_APITEST] Allow the test to load on Windows XP. ROSTESTS-293
Ged Murphy [Wed, 6 Dec 2017 22:08:46 +0000 (22:08 +0000)]
[SERVMAN] Fix return check on PropSheet_IsDialogMessage.
Should fix the regression introduced in the last commit.
CORE-14068
Luo Yufan [Wed, 6 Dec 2017 14:35:27 +0000 (15:35 +0100)]
Update Simplified Chinese translation.
Alexander Shaposhnikov [Wed, 6 Dec 2017 09:23:49 +0000 (11:23 +0200)]
[README] Update to 0.4.7
Pierre Schweitzer [Tue, 5 Dec 2017 22:28:04 +0000 (23:28 +0100)]
[NTOSKRNL] Only activate dumper in DBG builds
Pierre Schweitzer [Tue, 5 Dec 2017 22:19:11 +0000 (23:19 +0100)]
[NTOSKRNL] Add a non paged memory dumper in case of low memory situation.
Its purpose is to dump the non paged consumption, tag by tag,
to allow tracking potential faulting driver in case ReactOS starts lacking memory.
This will look like what !poolused outputs, even though it doesn't deal with paged pool.
Thanks to Thomas for his kind review and improvement suggestions.
CORE-14048
Ged Murphy [Tue, 5 Dec 2017 22:13:02 +0000 (22:13 +0000)]
[SERVMAN]
- Avoid a potential race whereby the current service selection can change before the propsheet thread starts up
- Cleanup the depends data, it doesn't need to be passed around the propsheet
Pierre Schweitzer [Tue, 5 Dec 2017 20:38:40 +0000 (21:38 +0100)]
[VCDCLI] Add support for UDF/Joliet hidding.
By providing /u or /j switch on mount, the virtual CD-ROM class driver
will break the associated signatures on read so that FSDs cannot recognize them any longer.
Ged Murphy [Tue, 5 Dec 2017 12:25:14 +0000 (12:25 +0000)]
[Servman] Make the property sheets modeless so users can open multiple services at the same time (#166)
[SERVMAN]
- Make the property sheets modeless so users can open multiple services at the same time
- Untested in ros. In fact we have no code or tests cases to check that modeless property sheets work, so please raise a bug if you find any issues with the app.
- Dedicated to reactosfanboy
Stanislav Motylkov [Sun, 3 Dec 2017 15:45:24 +0000 (18:45 +0300)]
[SHELL32_APITEST] SHParseDisplayName: More tests for relative paths
Stanislav Motylkov [Sat, 2 Dec 2017 20:54:35 +0000 (23:54 +0300)]
[BROWSEUI] SHExplorerParseCmdLine: Improve relative path handling
CORE-12882, CORE-13847
Stanislav Motylkov [Sat, 2 Dec 2017 20:52:38 +0000 (23:52 +0300)]
[BROWSEUI_APITEST] Improve tests for relative paths
Serge Gautherie [Fri, 17 Nov 2017 00:44:31 +0000 (01:44 +0100)]
[SHELL32] shellpath.c: it is _WIN32_WINNT, not WIN32_WINNT. We even need to use __REACTOS__ instead here. CORE-12580
Amine Khaldi [Fri, 1 Dec 2017 23:20:14 +0000 (00:20 +0100)]
[AFD] Introduce and use pool tags. Thanks go to Arty for assisting me with this. CORE-14048
Stanislav Motylkov [Sat, 25 Nov 2017 20:18:48 +0000 (23:18 +0300)]
[IPHLPAPI] Implement interface name resolving functions
Including:
- NhGetInterfaceNameFromDeviceGuid
- NhGetInterfaceNameFromGuid
CORE-13831, CORE-14033
Reference:
https://github.com/boundary/wireshark/blob/master/capture_win_ifnames.c#L275
Stanislav Motylkov [Sat, 25 Nov 2017 17:06:21 +0000 (20:06 +0300)]
[IPHLPAPI_APITEST] Add tests for interface resolving functions
CORE-13831, CORE-14033
Pierre Schweitzer [Sun, 3 Dec 2017 17:13:25 +0000 (18:13 +0100)]
[VCDCLI] Implement a tool that allows managing vcdrom class driver.
It allows you managing virtual drives, mounting images, ejecting images, and so on.
It will load the driver when required.
It's less features complete that the MS GUI implementation.
I'll implement them later on, it can be quickly done.
What's missing: UDF/Joliet suppr and persistent mounts
Pierre Schweitzer [Sun, 3 Dec 2017 17:10:32 +0000 (18:10 +0100)]
[VCDROM] Implement the virtual CD-ROM class driver.
It was provided by MS as a separate package to download for Windows (up to 7).
That class driver allows creating virtual drives on which we can later mount ISOs images.
It's rather basic, but does the job.
To use it, you can use the GUI app from Microsoft (Virtual CD-ROM Control Panel)
or the vcdcli in CLI. We're compatible :-).
Note that it's not loaded at boot, you need to manually start it, to lower memory footprint.
Both applications will handle this for you.
Pierre Schweitzer [Sun, 3 Dec 2017 17:09:43 +0000 (18:09 +0100)]
[PSDK] Define the IOCTL_CDROM_EJECT_MEDIA IOCTL
Hermès Bélusca-Maïto [Sun, 3 Dec 2017 15:01:44 +0000 (16:01 +0100)]
[CMD] Fix the del /s command, reported by Pablo De Napoli. CORE-10460
The command should delete files in the specified directory and all of its
sub-directories, using any file pattern specified.
For example, the command:
del /S .\my_directory
should delete all the files inside my_directory and its sub-directories,
and as such should also detect that "my_directory" is indeed a directory,
while doing:
del /S .\my_file
should of course detect that "my_file" is indeed a file pattern, and thus,
delete all "my_file" files from the current directory and its sub-directories.
The command:
del /S some_directory\file_pattern
should delete "file_pattern" files from some_directory and its sub-directories.
Hermès Bélusca-Maïto [Thu, 23 Nov 2017 21:37:16 +0000 (22:37 +0100)]
[CMD] Fix the presentation of some confirmation prompts.
Amine Khaldi [Sat, 2 Dec 2017 20:17:22 +0000 (21:17 +0100)]
[USER32_APITEST] Add a PCH.
Amine Khaldi [Sat, 2 Dec 2017 20:05:46 +0000 (21:05 +0100)]
[NTDLL_APITEST] Add a PCH.
Amine Khaldi [Sat, 2 Dec 2017 20:00:06 +0000 (21:00 +0100)]
[GDI32_APITEST] Add a PCH.
Stanislav Motylkov [Sat, 2 Dec 2017 14:54:17 +0000 (17:54 +0300)]
[SHELL32] Fix show properties with Alt+Enter
Alexander Shaposhnikov [Sat, 2 Dec 2017 15:31:07 +0000 (17:31 +0200)]
[README] Clean up and finish styling
Unified the first badge row to use the same colors as reactos.org
Moved build related badges to 'Build' section
Fixed all links to use https and to be semantically correct
Replaced 'Tweet' badge with 'Follow', 'Flattr' with more general 'donate'
Added a sentence about donation
Thomas Faber [Sat, 2 Dec 2017 13:17:42 +0000 (14:17 +0100)]
[WINHTTP_WINETEST] Skip test_persistent_connection due to hang. CORE-14056 ROSTESTS-295
Thomas Faber [Sat, 2 Dec 2017 12:22:51 +0000 (13:22 +0100)]
[WININET_WINETEST] Skip test_redirect and test_persistent_connection due to hang. CORE-14055 ROSTESTS-294
Alexander Shaposhnikov [Sat, 2 Dec 2017 00:36:50 +0000 (02:36 +0200)]
[README] Changed the second badge row
Centered second badge row by using HTML code
Moved Coverity scan to the top, Flattr and Tweet - to the bottom
Linked "Download" and "Release" to reactos.org
Alexander Shaposhnikov [Sat, 2 Dec 2017 00:12:48 +0000 (02:12 +0200)]
[README] Changed and moved badges around
- Added Flattr button
- Removed GitHub stats badges because they were useless
- Change SPDX.org license link to our COPYING for correctness
Amine Khaldi [Fri, 1 Dec 2017 23:15:27 +0000 (00:15 +0100)]
[AFD] Zap unused TaCopyAddress() and TaCopyAddressInPlace().
James Tabor [Sun, 26 Nov 2017 20:48:06 +0000 (14:48 -0600)]
[GDI] Fix metafile crashes and null driver issues.
Patch by Jérôme Gardou modified by me.
CORE-14023 : Fix SetWorldTransform for metafiles #137
Includes CORE-12832 and CORE-13627.
Amine Khaldi [Sun, 26 Nov 2017 12:19:19 +0000 (13:19 +0100)]
[LIBTIRPC] Add a PCH.
Pierre Schweitzer [Sun, 26 Nov 2017 13:44:26 +0000 (14:44 +0100)]
[LIBTIRPC] Match rtime() propotype and implementation
Amine Khaldi [Sun, 26 Nov 2017 13:16:29 +0000 (14:16 +0100)]
[SHELLBTRFS] Add a PCH.
Amine Khaldi [Sun, 26 Nov 2017 12:22:37 +0000 (13:22 +0100)]
[NFS41_NP] Add a PCH.
Amine Khaldi [Sun, 26 Nov 2017 12:13:39 +0000 (13:13 +0100)]
[NFSD] Add a PCH.
Pierre Schweitzer [Sun, 26 Nov 2017 13:01:04 +0000 (14:01 +0100)]
[NTOSKRNL] Use ExAllocatePoolWithQuotaTag() when allocating SystemBuffer for the IRP
That way, in case the system lacks memory, an exception is thrown and IRP isn't sent
to the device with NULL SystemBuffer.
CORE-14048
Pierre Schweitzer [Sun, 26 Nov 2017 12:56:48 +0000 (13:56 +0100)]
[NTOSKRNL] Use cache aligned buffer for devioctrl
Amine Khaldi [Sun, 26 Nov 2017 12:26:39 +0000 (13:26 +0100)]
[NTOBJSHEX] Improve the existing PCH and make use of it.
Amine Khaldi [Sun, 26 Nov 2017 12:24:50 +0000 (13:24 +0100)]
[GLU32] Add a PCH.
Amine Khaldi [Sun, 26 Nov 2017 12:16:29 +0000 (13:16 +0100)]
[LIBJPEG] Add a PCH.
Pierre Schweitzer [Sat, 25 Nov 2017 19:15:28 +0000 (20:15 +0100)]
[CDFS_NEW] Fix broken cast.
Spotted by Thomas
David Quintana [Fri, 24 Nov 2017 18:55:23 +0000 (19:55 +0100)]
[CDFS_NEW] Address review comments:
- Don't define-out volatile.
- Cleanup the ros-specific hdd-backed device object on shutdown.
- Fix hdd-backed use. Required a rather ugly hack.
- Update README.FSD
David Quintana [Fri, 24 Nov 2017 17:15:42 +0000 (18:15 +0100)]
Revert "[CDFS_NEW] Use CdAcquireForCreateSection from the old driver in place of the newer CdFilterCallbackAcquireForCreateSection."
This reverts commit
8410d0327522b51be9926994ce2ec0263d36310f.
David Quintana [Fri, 24 Nov 2017 17:11:29 +0000 (18:11 +0100)]
[CDFS_NEW] Accept STATUS_NOT_IMPLEMENTED for IOCTL_CDROM_READ_TOC_EX fallback to IOCTL_CDROM_READ_TOC.
David Quintana [Fri, 24 Nov 2017 16:27:46 +0000 (17:27 +0100)]
[CDFS_NEW] Use CdAcquireForCreateSection from the old driver in place of the newer CdFilterCallbackAcquireForCreateSection.
David Quintana [Thu, 23 Nov 2017 20:05:28 +0000 (21:05 +0100)]
[CDFS_NEW] Re-apply many of the reactos-specific changes and fix build.
- Also, get rid of the old diff file.
David Quintana [Thu, 23 Nov 2017 20:02:16 +0000 (21:02 +0100)]
[CDFS_NEW] Replace old driver with a Ms-PL licensed version straight out of the driver samples github repository.
Katayama Hirofumi MZ [Sat, 25 Nov 2017 09:27:20 +0000 (18:27 +0900)]
[SHELL32] Don't show error when closing disk prop sheet (#144)
CORE-14035
jimtabor [Fri, 24 Nov 2017 23:22:43 +0000 (17:22 -0600)]
[GDI] - Add type for setting world transform modification modes.
References:
https://msdn.microsoft.com/en-us/library/
cc230538.aspx
https://github.com/KDE/krita/blob/master/libs/vectorimage/libemf/EmfEnums.h
Amine Khaldi [Fri, 24 Nov 2017 11:13:10 +0000 (12:13 +0100)]
[APPVEYOR] Add an appveyor.yml file. Dedicated to Alexander Shaposhnikov (sanchaez). [APPVEYOR/CLANG-CL] Add the clang-cl build as a second job next to our msvc build.
Amine Khaldi [Fri, 24 Nov 2017 11:07:56 +0000 (12:07 +0100)]
[DLLIMPORT_TEST] Skip this module in the clang-cl build until framedyn is back in it. CORE-11799
Amine Khaldi [Fri, 24 Nov 2017 11:01:43 +0000 (12:01 +0100)]
[CMAKE/CLANG-CL] Force clang-cl's identity to be MSVC instead of the default Clang one as the latter results in skipping several MSVC related CMake checks/tasks. CORE-11799
Pierre Schweitzer [Fri, 24 Nov 2017 11:00:10 +0000 (12:00 +0100)]
[FASTFAT_NEW] Fix build with FASTFATDBG set
Pierre Schweitzer [Thu, 23 Nov 2017 22:26:10 +0000 (23:26 +0100)]
[FASTFAT_NEW] Import again FastFAT from MS. This time from GitHub for license reasons.
This implies that a sample for W10.
It has been backported to NT5.2; not sure how it would work on a W2K3 (feel free to test!)
Pierre Schweitzer [Thu, 23 Nov 2017 22:23:16 +0000 (23:23 +0100)]
[PSDK] Add various defines needed to build fastfat_new