2 years ago[WINLOGON] Localize the shutdown timeout
Eric Kohl [Sun, 29 Apr 2018 15:09:37 +0000 (17:09 +0200)]
[WINLOGON] Localize the shutdown timeout

2 years ago[MODE] Use more translated strings. CORE-12178
Hermès Bélusca-Maïto [Sun, 29 Apr 2018 14:56:33 +0000 (16:56 +0200)]
[MODE] Use more translated strings. CORE-12178

2 years ago[SYSSETUP] Close the device key after the property sheet page has been released.
Eric Kohl [Sun, 29 Apr 2018 13:41:03 +0000 (15:41 +0200)]
[SYSSETUP] Close the device key after the property sheet page has been released.

2 years ago[CALC][CLIPBRD][SOLITAIRE][SPIDER][NOTEPAD][REGEDIT][TASKMGR] Disable help menu/button
Bișoc George [Tue, 24 Apr 2018 17:58:46 +0000 (19:58 +0200)]

2 years ago[SYSSETUP] Read driver settings from and write them to the registry
Eric Kohl [Sun, 29 Apr 2018 12:55:57 +0000 (14:55 +0200)]
[SYSSETUP] Read driver settings from and write them to the registry

- Read the driver settings from the registry.
- Write the driver settings to the registry.
- Make the read-only edit control for the input buffer length look like a non-read-only one because it is controlled by the up-down control.

2 years ago[FASTFAT] Reduce the number of local declaration.
Pierre Schweitzer [Sun, 29 Apr 2018 10:33:53 +0000 (12:33 +0200)]
[FASTFAT] Reduce the number of local declaration.

2 years ago[SDK] Enforce callback type for KdRosRegisterCliCallback(), KdRosDeregisterCliCallback().
Pierre Schweitzer [Sun, 29 Apr 2018 10:33:14 +0000 (12:33 +0200)]
[SDK] Enforce callback type for KdRosRegisterCliCallback(), KdRosDeregisterCliCallback().

2 years ago[FASTFAT] Use KdRosRegisterCliCallback() to register in KDBG.
Pierre Schweitzer [Sun, 29 Apr 2018 10:23:18 +0000 (12:23 +0200)]
[FASTFAT] Use KdRosRegisterCliCallback() to register in KDBG.

2 years ago[SDK] Make KdRosRegisterCliCallback() return status from KdSystemDebugControl().
Pierre Schweitzer [Sun, 29 Apr 2018 10:19:21 +0000 (12:19 +0200)]
[SDK] Make KdRosRegisterCliCallback() return status from KdSystemDebugControl().

2 years ago[FASTFAT] Introduce a KDBG extension.
Pierre Schweitzer [Sat, 28 Apr 2018 07:34:10 +0000 (09:34 +0200)]
[FASTFAT] Introduce a KDBG extension.

This is a PoC of what it's possible to realize thanks to an
already existing hack in ntoskrnl :-).
With this extension, on the kdb:> prompt, you're able to type
in commands that will be handled by the FastFAT driver and not
by the kernel, allowing internal debug, not possible otherwise.

So far, three commands exist:
- ?fat.vols: lists all the mounted volumes by FastFAT
- ?fat.files: lists all the files on a specific volume (with their attributes)
- ?fat.setdbgfile: allows watching on specifics files lifetime

This is obviously only the begin and could be greatly improved.

For instance, this is what allowed to debug CORE-14557

2 years ago[WINLOGON] Usability enhancement for the RPC SystemShutdown functionality.
Hermès Bélusca-Maïto [Sat, 28 Apr 2018 16:14:53 +0000 (18:14 +0200)]
[WINLOGON] Usability enhancement for the RPC SystemShutdown functionality.

- Perform an immediate system shutdown if the timeout is zero, otherwise
  display the countdown shutdown dialog.
- Cleanup pShutdownParams->pszMessage as soon as the dialog goes away.
- It actually appears (tested on Windows 2000 and 2003) that sending
  WM_CLOSE messages from a user-mode app to the shutdown dialog really
  do nothing (and in particular does not cancel the shutdown!), so modify
  the code to take this fact into account.

2 years ago[CMD] Improve how the command prompt displays when one presses Ctrl-C/break after...
Hermès Bélusca-Maïto [Sat, 28 Apr 2018 22:57:16 +0000 (00:57 +0200)]
[CMD] Improve how the command prompt displays when one presses Ctrl-C/break after having pressed ENTER, or after a command has been run.

2 years ago[CMD] Don't reset bCtrlBreak too early.
Hermès Bélusca-Maïto [Sat, 28 Apr 2018 22:53:49 +0000 (00:53 +0200)]
[CMD] Don't reset bCtrlBreak too early.

This allows to break commands such as:

C:\ReactOS\system32> for %f in (*.*) do dir

as one would expect: stop the currently running 'dir' and the 'for'.
"bCtrlBreak" doesn't need to be volatile too.

2 years ago[CMD] Use CheckCtrlBreak().
Hermès Bélusca-Maïto [Sat, 28 Apr 2018 22:50:40 +0000 (00:50 +0200)]
[CMD] Use CheckCtrlBreak().

2 years ago[CMD] Use _T() rather than L to initialise TCHARS.
James Woodcock [Fri, 27 Apr 2018 18:01:17 +0000 (19:01 +0100)]
[CMD] Use _T() rather than L to initialise TCHARS.

2 years ago[CMD] Fix CTRL-C handling.
James Woodcock [Fri, 27 Apr 2018 15:15:38 +0000 (16:15 +0100)]
[CMD] Fix CTRL-C handling.

Using CTRL-C to cancel command line input would leave the prompt in
a state where the next command would be ignored.  For example:


would cause cmd.exe to ignore the second dir command.

2 years ago[CMD] Don't pass CTRL-C to child processes.
James Woodcock [Fri, 27 Apr 2018 15:12:23 +0000 (16:12 +0100)]
[CMD] Don't pass CTRL-C to child processes.

The standard Win32 Console Control Handler will give CTRL-C events to
processes spawned from cmd.exe. If cmd.exe calls GenerateConsolCtrlEvent()
then the child process will receive two CTRL-C events.

2 years ago[FASTFAT] Don't leak directories FILE_OBJECT, FCB and cache entries. 524/head
Pierre Schweitzer [Thu, 26 Apr 2018 16:25:19 +0000 (18:25 +0200)]
[FASTFAT] Don't leak directories FILE_OBJECT, FCB and cache entries.

Once a directory is crossed (opened or a child is opened), associated
FCB structure is created in FastFAT, but also a stream FO for caching.
Up to now, due to an extra reference taken by the stream file object,
even when the directory was no longer used, the directory was kept in
memory: the FCB was never deleted, the file object was never dereferenced,
and the cache never released.

The immediate effect of this bug is that our FAT driver was leaking every
directory that was used affecting the whole OS situation. In case of
directories intensive operation (like extraction the ReactOS source code
in ReactOS ;-)), we were just killin the whole OS RAM without any way to
release it and recover.

The other side effects: IOs were faster as half of the FS was always
permanant in RAM.

This commit fixes the issue by forcing the FSD to release the FO,
and the cache when a directory is no longer used, leading to its
destruction in RAM.
Downside: on IO intensive operation, expect slowdowns, obviously,
there's less caching now. But more efficient!


2 years ago[NTOSKRNL] Also try to extract name from FCB when leaking VACB
Pierre Schweitzer [Fri, 27 Apr 2018 17:01:35 +0000 (19:01 +0200)]
[NTOSKRNL] Also try to extract name from FCB when leaking VACB

2 years ago[NTOSKRNL] In !filecache, try to display FCB name
Pierre Schweitzer [Fri, 27 Apr 2018 16:57:30 +0000 (18:57 +0200)]
[NTOSKRNL] In !filecache, try to display FCB name

When no name is set in the file object, try to read the name
from the FCB. We only support FastFAT (ours) FCB for now.

This is clearly a hack, but for a kdbg command, so ;-)

2 years ago[FASTFAT] When allocating a FCB, set its node type code.
Pierre Schweitzer [Fri, 27 Apr 2018 16:56:31 +0000 (18:56 +0200)]
[FASTFAT] When allocating a FCB, set its node type code.

We set the same value as MS FastFAT driver for consistency.

2 years ago[NTOSKNRL] In case we leak a VACB, debug as much information as possible.
Pierre Schweitzer [Fri, 27 Apr 2018 12:14:56 +0000 (14:14 +0200)]
[NTOSKNRL] In case we leak a VACB, debug as much information as possible.


2 years ago[NTOSKRNL] Noisily dereference mapped VACB on cache release.
Pierre Schweitzer [Fri, 27 Apr 2018 08:23:06 +0000 (10:23 +0200)]
[NTOSKRNL] Noisily dereference mapped VACB on cache release.

It seems that on process killing, some VACB may be deleted while
still mapped. With current reference counting, they will actually
not be deleted, but leaked, and an ASSERT will be triggered.


2 years ago[MSXML3] Fix buffer overflow in BindStatusCallback_GetBindInfo. CORE-14570
Thomas Faber [Thu, 26 Apr 2018 12:59:21 +0000 (14:59 +0200)]
[MSXML3] Fix buffer overflow in BindStatusCallback_GetBindInfo. CORE-14570

2 years agoCorrectly bugcheck if we aren't returning a usermode thread (#506)
Jason Johnson [Tue, 24 Apr 2018 22:07:02 +0000 (18:07 -0400)]
Correctly bugcheck if we aren't returning a usermode thread (#506)

Cause a corresponding bug check to occur for the reason of the user context flag being zero (a system thread), instead of using DbgBreakPoint.

2 years agoRemoved unreachable line (#517)
Peter Wathall [Tue, 24 Apr 2018 20:35:23 +0000 (20:35 +0000)]
Removed unreachable line (#517)

The break statement was unnecessary because the goto on the line before it returns from the routine so it can never be reached

2 years ago[SYSSETUP] PS2MousePropPageProvider: Use the UDN_DELTAPOS notification to change...
Eric Kohl [Mon, 23 Apr 2018 21:58:07 +0000 (23:58 +0200)]
[SYSSETUP] PS2MousePropPageProvider: Use the UDN_DELTAPOS notification to change the input buffer size in steps of 10

2 years ago[MSPAINT] Fix crash on zoom out
Stanislav Motylkov [Sat, 14 Apr 2018 12:42:34 +0000 (15:42 +0300)]
[MSPAINT] Fix crash on zoom out

- Check the denominator for zero for both zoomed width and height.
- Do not allow to move zoom slider above possible position.
- Move commonly used `zoomTo` function into new header file.


2 years ago[SYSSETUP] Initialize the property sheet page dialog and implement the Defaults button
Eric Kohl [Sun, 22 Apr 2018 21:59:28 +0000 (23:59 +0200)]
[SYSSETUP] Initialize the property sheet page dialog and implement the Defaults button

2 years ago[WIN32K] Implement UOI_FLAGS in NtUserGetObjectInformation(). Based from a patch...
Hermès Bélusca-Maïto [Sun, 22 Apr 2018 20:56:16 +0000 (22:56 +0200)]
[WIN32K] Implement UOI_FLAGS in NtUserGetObjectInformation(). Based from a patch by Jérôme Gardou.
CORE-13447 CORE-14422

This fixes closing nLite (.NET2) application, as well as any
other program that expects that the interactive window station is
reported as being visible. I thank Mark Jansen and Joachim Henze for
help and testing.

2 years ago[CPL][CONSOLE] Mistake corrections
Bișoc George [Fri, 13 Apr 2018 16:11:47 +0000 (18:11 +0200)]
[CPL][CONSOLE] Mistake corrections

2 years ago[NULL] Additions for the Null driver.
Hermès Bélusca-Maïto [Sun, 22 Apr 2018 20:13:52 +0000 (22:13 +0200)]
[NULL] Additions for the Null driver.

- Allow the driver to be unloaded, as on Windows.
- Use a static fast IO dispatch table, instead of allocating one and
  risking any potential memory allocation failure.
- Update the file header.

2 years ago[SDB] Add a fix for Globulation 2 unloading / reloading an aux dll.
Mark Jansen [Sat, 24 Feb 2018 13:58:40 +0000 (14:58 +0100)]
[SDB] Add a fix for Globulation 2 unloading / reloading an aux dll.
Reported in

2 years ago[SDK][ACGENRAL] Add the shim IgnoreFreeLibrary
Mark Jansen [Sat, 24 Feb 2018 13:57:56 +0000 (14:57 +0100)]
[SDK][ACGENRAL] Add the shim IgnoreFreeLibrary

2 years ago[XML2SDB] Add support for TAG_LINK_DATE and TAG_LINKER_VERSION.
Mark Jansen [Sat, 24 Feb 2018 17:42:42 +0000 (18:42 +0100)]

2 years ago[SHIMLIB] Update helper functions, add ShimLib_StringNDuplicateA
Mark Jansen [Sat, 24 Feb 2018 13:57:00 +0000 (14:57 +0100)]
[SHIMLIB] Update helper functions, add ShimLib_StringNDuplicateA

2 years ago[APPSHIM_APITEST] Add a test for the shim IgnoreFreeLibrary
Mark Jansen [Sat, 24 Feb 2018 13:55:11 +0000 (14:55 +0100)]
[APPSHIM_APITEST] Add a test for the shim IgnoreFreeLibrary

2 years ago[ZIPFLDR] Fix russian translation
Eric Kohl [Sun, 22 Apr 2018 15:42:20 +0000 (17:42 +0200)]
[ZIPFLDR] Fix russian translation

2 years ago[SHELL32] Partially sync SHGetFileInfo with wine to improve folder type names. 507/head
Mark Jansen [Sat, 21 Apr 2018 11:31:29 +0000 (13:31 +0200)]
[SHELL32] Partially sync SHGetFileInfo with wine to improve folder type names.

2 years ago[ZIPFLDR] Various usability improvements
Mark Jansen [Sat, 21 Apr 2018 10:50:05 +0000 (12:50 +0200)]
[ZIPFLDR] Various usability improvements
- Take the user-entered folder into account
- Hide size / ratio for folders

2 years ago[ATL] Add COMMAND_HANDLER macro.
Mark Jansen [Sat, 21 Apr 2018 10:48:08 +0000 (12:48 +0200)]

2 years ago[ZIPFLDR] Add Russian translation
Stanislav Motylkov [Sun, 22 Apr 2018 14:31:21 +0000 (17:31 +0300)]
[ZIPFLDR] Add Russian translation

2 years ago[NTOSKRNL] Minor PnP enhancements.
Hermès Bélusca-Maïto [Sun, 22 Apr 2018 14:31:53 +0000 (16:31 +0200)]
[NTOSKRNL] Minor PnP enhancements.

- For non-PnP devices reported to the PnP manager through the
  IoReportDetectedDevice() function, store the corresponding
  service/driver name and (non-)legacy information inside their
  HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Enum\Root\ entries.
- Drivers flagged as "DRVO_BUILTIN_DRIVER" (basically, only those
  created via a IoCreateDriver() call) have their "Service" name that
  contain "\Driver\", which should be stripped before being used in
  building e.g. the corresponding "DETECTEDxxx" PnP compatible IDs.

- Use explicit REG_OPTION_NON_VOLATILE flag where needed in the
  IopCreateDeviceKeyPath() calls.
- Save NULL-terminated REG-SZ string properties in the enumeration tree
  for each device enumerated inside \Enum\Root\.
- Always use upcased key name for the "LEGACY_***" elements in \Enum\Root\.
- Add a default "ConfigFlags" value for the legacy elements.
- Simplify few parts of code.

2 years ago[ACPI] Fix the format of the (default hardcoded) "unique" instance ID.
Hermès Bélusca-Maïto [Wed, 4 Apr 2018 00:25:49 +0000 (02:25 +0200)]
[ACPI] Fix the format of the (default hardcoded) "unique" instance ID.

2 years ago[NTOSKRNL] Whitespace fixes only.
Hermès Bélusca-Maïto [Tue, 3 Apr 2018 00:17:52 +0000 (02:17 +0200)]
[NTOSKRNL] Whitespace fixes only.

2 years ago[NTOSKRNL] Set the DRVO_BUILTIN_DRIVER DriverObject flag when a built-in driver is...
Hermès Bélusca-Maïto [Tue, 3 Apr 2018 00:14:48 +0000 (02:14 +0200)]
[NTOSKRNL] Set the DRVO_BUILTIN_DRIVER DriverObject flag when a built-in driver is created using IoCreateDriver().

2 years ago[NTOSKRNL] Set flags the standard way.
Hermès Bélusca-Maïto [Tue, 3 Apr 2018 00:10:08 +0000 (02:10 +0200)]
[NTOSKRNL] Set flags the standard way.

2 years ago[BROWSEUI] Apply a hack to prevent truncating the address bar text.
Doug Lyons [Sun, 22 Apr 2018 13:42:10 +0000 (15:42 +0200)]
[BROWSEUI] Apply a hack to prevent truncating the address bar text.

2 years ago[NTOS:MM] Fix ViewSize parameter passed to MiInsertVadEx() from MiCreatePebOrTeb()
Timo Kreuzer [Mon, 29 Jan 2018 11:37:26 +0000 (12:37 +0100)]
[NTOS:MM] Fix ViewSize parameter passed to MiInsertVadEx() from MiCreatePebOrTeb()
The size is in bytes, not in pages! On x86 we got away with it, since PEB and TEB require only a single page and the 1 passed to MiInsertVadEx() was aligned up to PAGE_SIZE. On x64 this doesn't work, since the size is 2 pages.

2 years ago[SYSSETUP] Add the property sheet page and initialize it
Eric Kohl [Sun, 22 Apr 2018 12:26:11 +0000 (14:26 +0200)]
[SYSSETUP] Add the property sheet page and initialize it

- Add the wheel detection option strings.
- Add the property sheet page and initialize the dialog.

2 years ago[SYSSETUP] Add the PS/2-Mouse property page dialog
Eric Kohl [Sun, 22 Apr 2018 09:59:47 +0000 (11:59 +0200)]
[SYSSETUP] Add the PS/2-Mouse property page dialog

2 years ago[README] Convert to UTF-8 without BOM.
Hermès Bélusca-Maïto [Sun, 22 Apr 2018 00:52:11 +0000 (02:52 +0200)]
[README] Convert to UTF-8 without BOM.

2 years ago[BOOTDATA] Increase the maximum size of the default event log files.
Hermès Bélusca-Maïto [Sun, 22 Apr 2018 00:51:32 +0000 (02:51 +0200)]
[BOOTDATA] Increase the maximum size of the default event log files.

2 years ago[EVTLIB] Silence some DPRINTs.
Hermès Bélusca-Maïto [Sun, 22 Apr 2018 00:42:04 +0000 (02:42 +0200)]
[EVTLIB] Silence some DPRINTs.

2 years ago[APISETS] Fix data forwarding. 511/head
Mark Jansen [Sat, 21 Apr 2018 16:55:57 +0000 (18:55 +0200)]
[APISETS] Fix data forwarding.
Thanks to Timo for the help :)

2 years ago[KERNEL32] Add Vista exports
Timo Kreuzer [Sun, 18 Feb 2018 21:21:31 +0000 (22:21 +0100)]
[KERNEL32] Add Vista exports

2 years ago[KERNEL32] Go back to auto-numbering of export ordinals
Timo Kreuzer [Sun, 18 Feb 2018 21:06:30 +0000 (22:06 +0100)]
[KERNEL32] Go back to auto-numbering of export ordinals
Using static numbers was a bad idea in the first place, since we already deal with x64, which has different ordinals. Also @ will automatically do the same thing! It does not mean "no ordinal", it only means automatically apply incrementing numbers.

2 years ago[SPEC2DEF] Implement support for different OS versions
Timo Kreuzer [Sun, 18 Feb 2018 20:22:52 +0000 (21:22 +0100)]
[SPEC2DEF] Implement support for different OS versions

2 years ago[SYSETUP] Add property page provider stubs and register them
Eric Kohl [Sat, 21 Apr 2018 12:14:49 +0000 (14:14 +0200)]
[SYSETUP] Add property page provider stubs and register them

2 years ago[COMCTL32_APITEST] Add some button tests
Giannis Adamopoulos [Sun, 8 Apr 2018 18:28:53 +0000 (21:28 +0300)]
[COMCTL32_APITEST] Add some button tests

2 years ago[COMCTL32] Sync with Wine Staging 3.3. CORE-14434
Giannis Adamopoulos [Wed, 4 Apr 2018 13:39:21 +0000 (16:39 +0300)]
[COMCTL32] Sync with Wine Staging 3.3. CORE-14434

2 years ago[ADVAPI32] Ignore the return value of the HandlerFunctionEx as well
Eric Kohl [Thu, 19 Apr 2018 04:09:57 +0000 (06:09 +0200)]
[ADVAPI32] Ignore the return value of the HandlerFunctionEx as well

Ignore the return value of the HandlerFunctionEx because we already ignore the return value of the HandlerFunction.
This fixes a winetest failure.

2 years ago[LOCALSPL] Fix 2 Clang-Cl warnings about ullResult and "UserName"
Serge Gautherie [Wed, 18 Apr 2018 15:25:34 +0000 (17:25 +0200)]
[LOCALSPL] Fix 2 Clang-Cl warnings about ullResult and "UserName"

- "warning: comparison of unsigned expression < 0 is always false [-Wtautological-unsigned-zero-compare]"
- "warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]"


2 years ago[NTOS:PNP] Use pool tagging for DEVICE_ACTION_DATA. CORE-10456
Thomas Faber [Sun, 17 Dec 2017 23:13:51 +0000 (00:13 +0100)]
[NTOS:PNP] Use pool tagging for DEVICE_ACTION_DATA. CORE-10456

2 years ago[NTOS:PNP] Rename IopDeviceRelations* to IopDeviceAction*. CORE-10456
Thomas Faber [Sun, 17 Dec 2017 21:53:01 +0000 (22:53 +0100)]
[NTOS:PNP] Rename IopDeviceRelations* to IopDeviceAction*. CORE-10456

2 years ago[MODE] Use ConUtils functions for printing to screen.
Hermès Bélusca-Maïto [Tue, 17 Apr 2018 22:44:39 +0000 (00:44 +0200)]
[MODE] Use ConUtils functions for printing to screen.

2 years ago[MODE] Improve few points in the MODE command. Adapted from a patch by Katayama Hirof...
Hermès Bélusca-Maïto [Tue, 17 Apr 2018 22:37:42 +0000 (00:37 +0200)]
[MODE] Improve few points in the MODE command. Adapted from a patch by Katayama Hirofumi MZ. CORE-12894

2 years ago[EVENTVWR] Additions for the Event Viewer.
Hermès Bélusca-Maïto [Tue, 17 Apr 2018 21:01:45 +0000 (23:01 +0200)]
[EVENTVWR] Additions for the Event Viewer.
CORE-11637, CORE-12269

- Implement support for remote connections to NT computers to view their
  event logs (and the event logs settings). For the moment the remote
  computer name specification is is only available via the command-line.
  Note that the paths to the event log files need also to be translated
  to network-share format.
- Implement loading and saving the settings of the event viewer.
- Implement showing/hiding the events description pane, the ListView
  grid, and whether or not to save the EventViewer settings.
- Handle hypertext link click handling for the RichEdit edit box of the
  events description dialog.

2 years ago[EVENTVWR] Code style only.
Hermès Bélusca-Maïto [Tue, 17 Apr 2018 20:43:47 +0000 (22:43 +0200)]
[EVENTVWR] Code style only.

2 years ago[NTOSKRNL] Properly reset VACB on free
Pierre Schweitzer [Sat, 14 Apr 2018 09:13:12 +0000 (11:13 +0200)]
[NTOSKRNL] Properly reset VACB on free

CID 1434271

2 years ago[NTOSKRNL] Drop the VACB lock.
Pierre Schweitzer [Sun, 8 Apr 2018 17:09:36 +0000 (19:09 +0200)]
[NTOSKRNL] Drop the VACB lock.
This has have several benefits for ReactOS Cc:
- It helps reducing potential deadlocks situations in Cc
- It speeds up ReactOS by reducing locks
- It gets us a bit closer to Windows VACB


2 years ago[NTOSKRNL] Use interlocked operations when dealing with map count.
Pierre Schweitzer [Sun, 8 Apr 2018 16:58:15 +0000 (18:58 +0200)]
[NTOSKRNL] Use interlocked operations when dealing with map count.


2 years ago[NTOSKRNL] Map the VACB in kernel space before inserting it in lists.
Pierre Schweitzer [Sun, 8 Apr 2018 16:45:38 +0000 (18:45 +0200)]
[NTOSKRNL] Map the VACB in kernel space before inserting it in lists.
The avoids race conditions where attempts to read from disk to
not fully initialized VACB were performed.
Also, added more debug prints in such situations.


2 years ago[NTOSKRNL] Add extra sanity checks for VACB lists.
Pierre Schweitzer [Sun, 8 Apr 2018 16:34:00 +0000 (18:34 +0200)]
[NTOSKRNL] Add extra sanity checks for VACB lists.
We now always initialize list members from the VACB
and make sure the list entry has properly been removed
from the list before free.


2 years ago[NTOS:MM] Do not map two pages into hyperspace in MiCopyFromUserPage. CORE-14548
Thomas Faber [Sun, 15 Apr 2018 17:42:18 +0000 (19:42 +0200)]
[NTOS:MM] Do not map two pages into hyperspace in MiCopyFromUserPage. CORE-14548

Doing this is not only wrong because it acquires the same spinlock twice,
it also completely breaks the TLB flushing logic in MiMapPageInHyperSpace.
If the PTE with Offset 1 is still valid when a wrap-around to 0 happens,
the TLB flush on wrap-around will not clear the entry for this previous page.
After another loop around all hyperspace pages, page 1 is re-used but its
TLB entry has not been flushed, which may result into incorrect translation.

2 years ago[ZIPFLDR] Add Chinese(Simplified) translation
Li Keqing [Sun, 15 Apr 2018 12:45:31 +0000 (20:45 +0800)]
[ZIPFLDR] Add Chinese(Simplified) translation

2 years ago[NET] Implement the options in the NET CONFIG SERVER command
Eric Kohl [Sun, 15 Apr 2018 13:32:01 +0000 (15:32 +0200)]
[NET] Implement the options in the NET CONFIG SERVER command

2 years ago[ZIPFLDR] Add French translation
Pierre Schweitzer [Sun, 15 Apr 2018 08:56:00 +0000 (10:56 +0200)]
[ZIPFLDR] Add French translation

2 years ago[WINLOGON] Romanian translation update
Bișoc George [Sat, 14 Apr 2018 15:29:55 +0000 (17:29 +0200)]
[WINLOGON] Romanian translation update

2 years ago[TRANSLATION][ZIPFLDR] Added Estonian translation
Joann Mõndresku [Sat, 14 Apr 2018 18:19:39 +0000 (21:19 +0300)]
[TRANSLATION][ZIPFLDR] Added Estonian translation

2 years ago[ZIPFLDR] Implement Romanian resource translation 476/head
Bișoc George [Sun, 8 Apr 2018 18:28:28 +0000 (20:28 +0200)]
[ZIPFLDR] Implement Romanian resource translation

2 years ago[ZIPFLDR] Implement Italian resource translation
Bișoc George [Sun, 8 Apr 2018 16:38:19 +0000 (18:38 +0200)]
[ZIPFLDR] Implement Italian resource translation

2 years ago[ZIPFLDR] Typo fix on constant
Bișoc George [Sun, 8 Apr 2018 15:31:29 +0000 (17:31 +0200)]
[ZIPFLDR] Typo fix on constant

2 years ago[ZIPFLDR] Support for multiple languages interface
Bișoc George [Sun, 8 Apr 2018 15:15:24 +0000 (17:15 +0200)]
[ZIPFLDR] Support for multiple languages interface

2 years ago[NETMSG] Add netmsg resource dll with some lmerr messages
Eric Kohl [Sat, 14 Apr 2018 16:31:14 +0000 (18:31 +0200)]
[NETMSG] Add netmsg resource dll with some lmerr messages

2 years ago[NET] Add help text for the NET GROUP command and improve the NET LOCALGROUP help...
Eric Kohl [Sat, 14 Apr 2018 12:54:50 +0000 (14:54 +0200)]
[NET] Add help text for the NET GROUP command and improve the NET LOCALGROUP help text

2 years ago[KERNEL32] FlsAlloc(): Add a missing '\n' to a DPRINT1()
Serge Gautherie [Sun, 8 Apr 2018 21:44:35 +0000 (23:44 +0200)]
[KERNEL32] FlsAlloc(): Add a missing '\n' to a DPRINT1()

2 years ago[SHELL32] Sync CShellDispatch and family with wine. 490/head
Mark Jansen [Fri, 13 Apr 2018 20:59:04 +0000 (22:59 +0200)]
[SHELL32] Sync CShellDispatch and family with wine.
Incorporates work from Ivan Rodionov.

2 years ago[SC] Don't leak service status info on success
Pierre Schweitzer [Sat, 14 Apr 2018 13:38:12 +0000 (15:38 +0200)]
[SC] Don't leak service status info on success

CID 1434266

2 years ago[NET] Add help text for the NET LOCALGROUP command
Eric Kohl [Sat, 14 Apr 2018 11:23:37 +0000 (13:23 +0200)]
[NET] Add help text for the NET LOCALGROUP command

2 years ago[VFATLIB] Simplify in-memory boot sector copy.
Pierre Schweitzer [Sat, 14 Apr 2018 10:05:32 +0000 (12:05 +0200)]
[VFATLIB] Simplify in-memory boot sector copy.
So that, coverity is happy again.

CID 143423014342331434238143424314342461434272

2 years ago[NTFS] When reading $I30 attribute fails, stop the rename operation.
Pierre Schweitzer [Sat, 14 Apr 2018 09:39:33 +0000 (11:39 +0200)]
[NTFS] When reading $I30 attribute fails, stop the rename operation.

This makes the function return the error instead of continuing and
performing use-after-frees operations.
This is likely to be a forgotten return!

CID 14342541434268

2 years ago[EVENTLOG] Register .evt file extension so that we can open event log files from...
Hermès Bélusca-Maïto [Fri, 13 Apr 2018 21:46:32 +0000 (23:46 +0200)]
[EVENTLOG] Register .evt file extension so that we can open event log files from the shell.

Take also the opportunity to fix a problematic "%1" in wordpad.exe command line.

2 years ago[HAL] Reset the stack pointer to the stack frame when calling second-entry interrupt...
Thomas Faber [Fri, 13 Apr 2018 06:48:57 +0000 (08:48 +0200)]
[HAL] Reset the stack pointer to the stack frame when calling second-entry interrupt handlers. CORE-14449

Because we can encounter pending interrupts repeatedly,
HalpEndSoftwareInterrupt and HalEndSystemInterrupt already clean up the stack
space for their arguments (done for CORE-11123/CORE-14076).
However these functions are called from C functions such as KiInterruptDispatch
and HalpDispatchInterrupt2[ndEntry]. These callers also use up stack space,
and it is unknown how much.
To fix this, we simply reset the stack pointer to the location of the trap
frame, which is where it points during a first-level dispatch. This cleans
up the stack usage of any callers higher up, and is okay because a return
will happen through the trap frame anyway.

Dedicated to Pierre.

2 years ago[EVENTVWR] Additions to the Event Viewer.
Hermès Bélusca-Maïto [Thu, 12 Apr 2018 22:52:25 +0000 (00:52 +0200)]
[EVENTVWR] Additions to the Event Viewer.

- Don't hardcode a buffer length in ExpandEnvironmentStringsW() call.
- If no file name is associated to a log (ErrorLog->FileName == NULL),
  don't try to attempt looking at its file properties. This also allows
  avoiding a crash in the FindFirstFileW() call under certain conditions
  on Windows.

2 years ago[NTDLL] Allow shimdata to override the process manifest. 485/head
Mark Jansen [Tue, 10 Apr 2018 22:18:17 +0000 (00:18 +0200)]
[NTDLL] Allow shimdata to override the process manifest.

2 years ago[SDB][APPHELP] Add ShimVersionNT data tags + read them in SdbPackAppCompatData
Mark Jansen [Tue, 10 Apr 2018 22:05:41 +0000 (00:05 +0200)]
[SDB][APPHELP] Add ShimVersionNT data tags + read them in SdbPackAppCompatData

2 years ago[APPHELP_APITEST] Add tests for Data tags
Mark Jansen [Tue, 10 Apr 2018 20:40:27 +0000 (22:40 +0200)]
[APPHELP_APITEST] Add tests for Data tags

2 years ago[APPHELP] Implement SdbQueryData[Ex][TagID]
Mark Jansen [Tue, 10 Apr 2018 20:42:03 +0000 (22:42 +0200)]
[APPHELP] Implement SdbQueryData[Ex][TagID]

2 years ago[XML2SDB] Add support for DATA in Layers.
Mark Jansen [Tue, 10 Apr 2018 20:39:29 +0000 (22:39 +0200)]
[XML2SDB] Add support for DATA in Layers.