Victor Perevertkin [Wed, 27 Mar 2019 23:45:32 +0000 (02:45 +0300)]
[USBSTOR] Do not create a new Irp for USB requests - use the original one
from higher-level driver instead.
Refactored CSWCompletionRoutine for correct handling different CSW
statuses, more work to be done here.
Victor Perevertkin [Tue, 26 Mar 2019 11:26:06 +0000 (14:26 +0300)]
[USBSTOR] Do not attempt additional processing of SCSI requests.
Now the driver sends all requests transparently.
Inspired by Vadim Galyant's patches to usbstor
Victor Perevertkin [Sun, 24 Mar 2019 20:01:43 +0000 (23:01 +0300)]
[FORMATTING][USBSTOR] Remove Captain Obvious and line-wasting comments.
Now the driver conforms with our current Coding Style.
No functional changes
Pierre Schweitzer [Mon, 10 Jun 2019 19:16:41 +0000 (21:16 +0200)]
[NTOSKRNL] Fix ObpLUIDDeviceMapsEnabled initialization
Eric Kohl [Mon, 10 Jun 2019 18:27:45 +0000 (20:27 +0200)]
[NETCFGX] Do not update the TCP/IP properties when the cancels the advanced properties dialog.
CORE-9908
Pierre Schweitzer [Mon, 10 Jun 2019 17:01:04 +0000 (19:01 +0200)]
[NETPLWIZ] Add French translation
Eric Kohl [Mon, 10 Jun 2019 15:22:11 +0000 (17:22 +0200)]
[NETSHELL] Network connections can't be renamed
Enable the 'Rename' and 'Delete' menu items for Administrators.
CORE-15348
Yaroslav Kibysh [Mon, 10 Jun 2019 08:20:17 +0000 (11:20 +0300)]
[CONSOLE] Update Ukrainian translation. (#1643)
Yaroslav Kibysh [Mon, 10 Jun 2019 07:52:23 +0000 (10:52 +0300)]
[MSGINA] Update Ukrainian translation. (#1642)
Hermès Bélusca-Maïto [Mon, 10 Jun 2019 14:57:59 +0000 (16:57 +0200)]
[CMD] Fix typo in Norwegian translation.
Yaroslav Kibysh [Mon, 10 Jun 2019 07:49:34 +0000 (10:49 +0300)]
[CMD] Update Ukrainian translation. (#1641)
Yaroslav Kibysh [Mon, 10 Jun 2019 07:40:49 +0000 (10:40 +0300)]
[RAPPS] Update Ukrainian translation. (#1640)
Yaroslav Kibysh [Mon, 10 Jun 2019 07:24:52 +0000 (10:24 +0300)]
[SHELL32] Update Ukrainian translation. (#1637)
Pierre Schweitzer [Mon, 10 Jun 2019 13:36:14 +0000 (15:36 +0200)]
[MSGINA] Update French translation
Joachim Henze [Mon, 10 Jun 2019 13:33:31 +0000 (15:33 +0200)]
[WIN32SS][NTUSER] Addendum to
0.4.12-dev-956-g0197c4f CORE-15893
Aims PixelPerfection for a regression that was introduced by
0.4.12-dev-954-g
1f619b27814f3bbf9673754a69bcae50c89fed19
and then improved already by
0.4.12-dev-956-g
0197c4f875d3332dbc4656a6360e3c7e9def2ed5
The tweaking got ack of Jim Tabor. Test results:
https://reactos.org/testman/compare.php?ids=68026,68029
Pierre Schweitzer [Mon, 10 Jun 2019 12:54:55 +0000 (14:54 +0200)]
[NTOSKRNL] Taggify some allocs
Pierre Schweitzer [Mon, 10 Jun 2019 12:49:50 +0000 (14:49 +0200)]
[NTOSKRNL] Implement SepCleanupLUIDDeviceMapDirectory
This will clean up all the links (drive letters) created
by an user on session deletion once LUID device maps are
in use
Pierre Schweitzer [Mon, 10 Jun 2019 10:30:49 +0000 (12:30 +0200)]
[NTOSKRNL] On session last reference removal, dereference LUID device map
Pierre Schweitzer [Mon, 3 Jun 2019 06:12:16 +0000 (08:12 +0200)]
[NTOSKRNL] Implement NtSetInformationProcess:ProcessDeviceMap
Eric Kohl [Sun, 9 Jun 2019 20:42:10 +0000 (22:42 +0200)]
[MSGINA] Add missing logon restriction messages.
Hermès Bélusca-Maïto [Sun, 9 Jun 2019 17:05:24 +0000 (19:05 +0200)]
[FASTFAT] Adjust the 'UnCleanCount', followng commit
9c3c0d12.
Hermès Bélusca-Maïto [Sun, 9 Jun 2019 15:56:06 +0000 (17:56 +0200)]
[FASTFAT] Minor cleanup of the main header file.
Serge Gautherie [Sun, 9 Jun 2019 13:57:45 +0000 (15:57 +0200)]
[SHELL32] SHCreateShellFolderView(): Fix parameter validation order. (#1632)
Fixes one modification from commit
ae2a85d0.
CORE-16098
Eric Kohl [Sun, 9 Jun 2019 13:25:13 +0000 (15:25 +0200)]
[NETAPI32] Ignore usriX_logon_hours and usriX_units_per_week if usriX_logon_hours is NULL.
Eric Kohl [Sun, 9 Jun 2019 12:50:07 +0000 (14:50 +0200)]
[NETAPI32] Do not try to set usriX_max_storage. Just ignore it.
Eric Kohl [Sat, 8 Jun 2019 18:41:53 +0000 (20:41 +0200)]
[NTOS:IO] Implement the PlugPlayControl.PlugPlayControlEnumerateDevice request
Drivers for Intel Pro/1000 NICs seem to install properly.
Serge Gautherie [Thu, 6 Jun 2019 22:14:40 +0000 (00:14 +0200)]
[BROWSEUI] Fix SHEnumClassesOfCategories() parameter validation. (#1622)
Addendum to
fdfef818. CORE-11711
Hermès Bélusca-Maïto [Sat, 8 Jun 2019 17:43:02 +0000 (19:43 +0200)]
[SHELL32] Fix some NULL-pointers validation.
- In the exported SHCreateDefaultContextMenu() and
IDataObject_Constructor() functions (called amongst others by
the exported CIDLData_CreateFromIDArray() function).
- In the exported SHCreateShellFolderView() function.
- In CDefView::GetItemObject(), where data was written to *ppvOut before
ppvOut was being checked for NULL.
Yaroslav Kibysh [Fri, 7 Jun 2019 12:06:52 +0000 (15:06 +0300)]
[BROWSEUI] Update Ukrainian translation. (#1626)
Yaroslav Kibysh [Fri, 7 Jun 2019 11:52:14 +0000 (14:52 +0300)]
[NEWDEV] Update Ukrainian translation. (#1625)
Yaroslav Kibysh [Fri, 7 Jun 2019 11:44:11 +0000 (14:44 +0300)]
[EXPLORER] Update Ukrainian translation. (#1624)
Yaroslav Kibysh [Fri, 7 Jun 2019 11:00:49 +0000 (14:00 +0300)]
[SHELL32] Update Ukrainian translation. (#1623)
Hermès Bélusca-Maïto [Sat, 8 Jun 2019 15:29:31 +0000 (17:29 +0200)]
[README] Fix the phrasing. Addendum to
8bfab2d4.
Eric Kohl [Thu, 6 Jun 2019 17:12:44 +0000 (19:12 +0200)]
[SETUPAPI] Fix a typo in CM_Query_Resource_Conflict_List.
Eric Kohl [Thu, 6 Jun 2019 17:08:43 +0000 (19:08 +0200)]
[SETUPAPI] GetDeviceInstanceKeyPath: Create a new driver instance property if needed and SEH-protect calls to umpnpmgr.
Eric Kohl [Thu, 6 Jun 2019 16:15:52 +0000 (18:15 +0200)]
[UMPNPMGR] Implement PNP_GetClassInstance().
Ender Ossel [Thu, 6 Jun 2019 16:01:48 +0000 (18:01 +0200)]
Add an Alpha note for new users in the README (#1270)
Serge Gautherie [Mon, 3 Jun 2019 23:14:31 +0000 (01:14 +0200)]
[ROSTESTS] Add missing '\n' to a few skip()
Hermès Bélusca-Maïto [Thu, 6 Jun 2019 14:33:44 +0000 (16:33 +0200)]
[BROWSEUI] Fix CSHEnumClassesOfCategories::Initialize() parameters validation. (#1559)
CORE-11711
Serge Gautherie [Thu, 9 May 2019 05:03:49 +0000 (07:03 +0200)]
[BROWSEUI_APITEST] Add a test for SHEnumClassesOfCategories. (#1559)
CORE-11711
Serge Gautherie [Thu, 9 May 2019 05:03:49 +0000 (07:03 +0200)]
[BROWSEUI] browseui.spec: Fix SHEnumClassesOfCategories() parameters. (#1559)
Joachim Henze [Thu, 6 Jun 2019 00:24:20 +0000 (02:24 +0200)]
[WIN32SS][FREETYPE] Avoid performance regression CORE-16020
by reverting essential parts of "Font rotation at arbitrary angles"
which was once committed in several steps:
Initial commit (PR#1207)
0.4.12-dev-243-g
f757a135192c02a3c41d8da47eb9dba21d34ebd1
broke font rendering for GTK apps CORE-15623
Second commit (PR#1238)
0.4.12-dev-558-g
64987cf2731f9762d0316274bf7877a9bd3d88ba
restored font rendering in GTK apps but introduced slowdown CORE-16020
Katayama agreed to the temporal revert and will try to come up later
with a performance optimized version.
We revert in 0.4.12-RC and 0.4.13-dev.
The revert will cause failure-increases in gdi32:TextTransform
https://reactos.org/testman/compare.php?ids=67898,67901
Serge Gautherie [Wed, 5 Jun 2019 23:53:53 +0000 (01:53 +0200)]
[BOOTLIB] Check DBG with #if, not #ifdef (#1621)
Serge Gautherie [Wed, 5 Jun 2019 23:51:46 +0000 (01:51 +0200)]
[LWIP] Fix src/core/init.c a bit (#1620)
Cherry-pick
http://git.savannah.nongnu.org/cgit/lwip.git/commit/src/core/init.c?id=
c0b534e5318baf870e2152c70d4d11a3a86181f3
Serge Gautherie [Wed, 5 Jun 2019 23:50:55 +0000 (01:50 +0200)]
[MBEDTLS] Use '#ifndef __REACTOS__', instead of '#if DBG & 0' (#1619)
- Don't use '|' on a '#if'
- Remove a personal comment.
Serge Gautherie [Wed, 5 Jun 2019 23:50:24 +0000 (01:50 +0200)]
[DXSDK] Improve dxerr?.h a bit (#1617)
*Use '||', instead of '|', on a '#if'.
*Synchronize some white spaces and blank lines.
Serge Gautherie [Wed, 5 Jun 2019 23:49:52 +0000 (01:49 +0200)]
[NCFTP] Check _DEBUG with #ifdef, not #if (#1616)
Serge Gautherie [Wed, 5 Jun 2019 23:49:18 +0000 (01:49 +0200)]
[NTDLL_VISTA] Check _DEBUG with #ifdef, not #if (#1615)
Serge Gautherie [Wed, 5 Jun 2019 16:37:07 +0000 (18:37 +0200)]
[ADVAPI32:REG] Remove some useless casts (#1614)
Serge Gautherie [Wed, 5 Jun 2019 16:15:02 +0000 (18:15 +0200)]
[USER32] RegisterClipboardFormatA(): Enable a SetLastError() (#1612)
Eric Kohl [Wed, 5 Jun 2019 08:23:55 +0000 (10:23 +0200)]
[MC] Add syntax and help texts for the NET SHARE command.
Serge Gautherie [Fri, 31 May 2019 14:29:16 +0000 (16:29 +0200)]
[LOCALSPL] Check DBG with #if, not #ifdef
Addendum to r74433.
Serge Gautherie [Wed, 15 May 2019 23:26:32 +0000 (01:26 +0200)]
[NTOS:MM] PeFmtCreateSection(): Improve AMD64 image failure case
Addendum to
98638cc2dfdde460ae49941c76dd51f1b796a001.
CORE-15981
Serge Gautherie [Tue, 4 Jun 2019 14:56:33 +0000 (16:56 +0200)]
Misc addendum to CORE-14271 (#1529)
* [ADVAPI32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check
RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a BOOL.
No functional change.
Addendum to
CORE-14271
* [USER32] Simplify RtlCreateUnicodeStringFromAsciiz() return value check
RtlCreateUnicodeStringFromAsciiz() returns a BOOLEAN, not a UINT.
Also, add a FIXME.
No functional change.
Addendum to
CORE-14271
* [USER32] Simplify RegisterClipboardFormatA/W() a bit
No functional change.
* [UDFS] Simplify SeSinglePrivilegeCheck() return value check
No functional change.
Addendum to
CORE-14271
Mas Ahmad Muhammad [Sun, 2 Jun 2019 11:55:07 +0000 (18:55 +0700)]
[RAPPS] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sun, 2 Jun 2019 11:54:12 +0000 (18:54 +0700)]
[EXPLORER] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:28:40 +0000 (05:28 +0700)]
[FORMAT] Update Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:19:59 +0000 (05:19 +0700)]
[RUNDLL32] Update Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:18:11 +0000 (05:18 +0700)]
[SUBST] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:08:13 +0000 (05:08 +0700)]
[SERVICES] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 22:03:51 +0000 (05:03 +0700)]
[RUNONCE] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 20:01:26 +0000 (03:01 +0700)]
[FONTVIEW] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 19:50:12 +0000 (02:50 +0700)]
[MSPAINT] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 14:21:21 +0000 (21:21 +0700)]
[OSK] Add Indonesian translation. (#1598)
Mas Ahmad Muhammad [Sat, 1 Jun 2019 12:28:34 +0000 (19:28 +0700)]
[REGEDIT] Update Indonesian translation. (#1598)
Eric Kohl [Tue, 4 Jun 2019 08:05:20 +0000 (10:05 +0200)]
[NET] Implement adding and deleting of network shares.
Serge Gautherie [Tue, 4 Jun 2019 02:48:04 +0000 (04:48 +0200)]
[WIN32KNT_APITEST] Replace remaining TESTX() (#1609)
Addendum to
b7794e8112e31a58829bac63d44de53677318c3d.
James Tabor [Mon, 3 Jun 2019 20:49:14 +0000 (15:49 -0500)]
[GDI32] Meta File Fix Ups
Remove pointer hack. Safer since using wines Enhanced Meta headers with
unknown wine magic information.
Katayama Hirofumi MZ [Sun, 2 Jun 2019 23:47:43 +0000 (08:47 +0900)]
Revert "[USER32] Make App Switcher use the owner window's icon (#1299)" (#1605)
This reverts commit
484943d04f0dc3f84b7c8e754d1d2505f0a41df3.
Eric Kohl [Sun, 2 Jun 2019 21:30:02 +0000 (23:30 +0200)]
[STORPORT] Detect attached devices
Pierre Schweitzer [Sun, 2 Jun 2019 19:44:45 +0000 (21:44 +0200)]
[NTOSKRNL] Add support for global DOS directory in ObpLookupEntryDirectory
If any exists, we'll loop over in that directory, trying to find the object
Serge Gautherie [Thu, 20 Sep 2018 22:58:14 +0000 (00:58 +0200)]
[WIN32KNT_APITEST:NTDD] Improve failure handling
And remove comments about ReactX.
ROSTESTS-315
Serge Gautherie [Fri, 21 Sep 2018 15:28:51 +0000 (17:28 +0200)]
[FORMATTING] Add/Remove a few spaces
Serge Gautherie [Mon, 24 Sep 2018 14:46:46 +0000 (16:46 +0200)]
[USER32_APITEST:WNDPROC] Improve failure handling
ROSTESTS-316
Serge Gautherie [Mon, 24 Sep 2018 14:45:41 +0000 (16:45 +0200)]
[USER32_APITEST:WNDPROC] 0 to NULL
Serge Gautherie [Mon, 24 Sep 2018 14:42:30 +0000 (16:42 +0200)]
[FORMATTING] 3-spaces to 4-spaces
And a few additional formatting improvements.
Eric Kohl [Sun, 2 Jun 2019 12:23:59 +0000 (14:23 +0200)]
[STORPORT] Fix resource list size calculation
Katayama Hirofumi MZ [Sun, 2 Jun 2019 10:17:50 +0000 (19:17 +0900)]
[WIN32SS][USER32] Fix Task Switcher more (#1602)
This PR will fix task switcher (Alt+Tab) as Win2k3. It became more reliable. CORE-15653
c.f. Raymond Chen's article: http://blogs.msdn.com/b/oldnewthing/archive/2007/10/08/
5351207.aspx
Pierre Schweitzer [Sun, 2 Jun 2019 08:48:35 +0000 (10:48 +0200)]
[NTOSKRNL] In case IopMountVolume call is a success, return its VPB
This fixes an extra (erroneous) reference being set on the VPB.
Based on a patch by Vadim Galyant
CORE-16080
Pierre Schweitzer [Sun, 2 Jun 2019 07:50:05 +0000 (09:50 +0200)]
[NTOSKRNL] On process primary token change, dereference device map
Katayama Hirofumi MZ [Sun, 2 Jun 2019 01:09:34 +0000 (10:09 +0900)]
[SDK][INCLUDE] Update msgdump.h
woachk [Sat, 1 Jun 2019 22:39:57 +0000 (00:39 +0200)]
[NDK/TESTS] The world isn't only amd64 or i386 (#1596)
woachk [Sat, 1 Jun 2019 22:38:56 +0000 (00:38 +0200)]
Update toolchain-msvc.cmake (#1593)
Adding armasm64 as the assembler. This on its own isn't too useful right now.
woachk [Sat, 1 Jun 2019 22:38:30 +0000 (00:38 +0200)]
[CONFIGURE] Add support for VS16.1 (#1594)
Joachim Henze [Sat, 1 Jun 2019 20:53:16 +0000 (22:53 +0200)]
[MSHTML] Fake Success in HTMLDocument_put_bgColor()
This avoids at startup of Instant Messenger "QIP 2005 8095"
a message-box with "OLE Error
8004001".
The issue is a subtask of CORE-11537
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
Note you still need to install Gecko 2.40 and Samba 1.3 from rapps for QIP.
Pierre Schweitzer [Sat, 1 Jun 2019 19:22:30 +0000 (21:22 +0200)]
[NTOSKRNL] Implement ObSetDirectoryDeviceMap
Pierre Schweitzer [Sat, 1 Jun 2019 19:05:14 +0000 (21:05 +0200)]
[NTOSKRNL] Implement SeGetLogonIdDeviceMap
Pierre Schweitzer [Sat, 1 Jun 2019 16:58:36 +0000 (18:58 +0200)]
[NTOSKRNL] Implement ObpSetCurrentProcessDeviceMap
Pierre Schweitzer [Sat, 1 Jun 2019 16:43:38 +0000 (18:43 +0200)]
[NTOSKRNL] Implement ObpReferenceDeviceMap()
Pierre Schweitzer [Sat, 1 Jun 2019 16:37:47 +0000 (18:37 +0200)]
[NTOSKRNL] Stub SeGetLogonIdDeviceMap
Pierre Schweitzer [Sat, 1 Jun 2019 15:39:29 +0000 (17:39 +0200)]
[NTOSKRNL] Simplify NtQueryInformationProcess:ProcessDeviceMap implementation
Pierre Schweitzer [Sat, 1 Jun 2019 15:28:11 +0000 (17:28 +0200)]
[NTOSKRNL] Add support for LUID mappings in ObQueryDeviceMapInformation
Pierre Schweitzer [Sat, 1 Jun 2019 13:18:52 +0000 (15:18 +0200)]
[NTOSKRNL] Implement support for PROCESS_DEVICEMAP_INFORMATION_EX in NtQueryInformationProcess
Pierre Schweitzer [Sat, 1 Jun 2019 12:56:28 +0000 (14:56 +0200)]
[NTOSKRNL] Implement ObIsLUIDDeviceMapsEnabled and call it in NtQueryInformationProcess
Pierre Schweitzer [Sat, 1 Jun 2019 12:40:24 +0000 (14:40 +0200)]
[NTOSKRNL] Disable LUID mapping until it's properly implemented
James Tabor [Sat, 1 Jun 2019 12:23:58 +0000 (07:23 -0500)]
[NtUser] Fix Clipboard Synthesized Returns
Add supported for Meta file synthesized renderings.
See CORE-12143.
Pierre Schweitzer [Sat, 1 Jun 2019 11:59:13 +0000 (13:59 +0200)]
[NTOSKRNL] On device map freeing, make directory object temporary again
Pierre Schweitzer [Sat, 1 Jun 2019 11:54:15 +0000 (13:54 +0200)]
[NTOSKRNL] De-duplicate code between Ob(f)DereferenceDeviceMap functions
Pierre Schweitzer [Sat, 1 Jun 2019 11:51:40 +0000 (13:51 +0200)]
[NTOSKRNL] Add a few ASSERTs to ObpGetDosDevicesProtection for DBG builds
Pierre Schweitzer [Sat, 1 Jun 2019 11:44:55 +0000 (13:44 +0200)]
[NTOSKRNL] Implement ObpFreeDosDevicesProtection to free DACL